@mrciphersmith/keryx 0.2.72 → 0.2.73

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (126) hide show
  1. package/dist/cli.js +352 -22
  2. package/package.json +2 -2
  3. package/src/gdskills/bundled/rules/core/gproject-contracts.mdc +1 -1
  4. package/src/gdskills/bundled/rules/core/jobs-documentation.mdc +1 -1
  5. package/src/gdskills/bundled/rules/core/subagent-context-construction.md +1 -1
  6. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.codex.md +326 -20
  7. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.cursor.md +320 -22
  8. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.opencode.md +326 -12
  9. package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.zed.md +333 -9
  10. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.codex.md +92 -4
  11. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.cursor.md +92 -4
  12. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.opencode.md +92 -4
  13. package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.zed.md +92 -4
  14. package/src/gdskills/bundled/skills/orchestration/context-collector/orchestrator-prompt.md +1 -1
  15. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.codex.md +154 -1098
  16. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.cursor.md +154 -1098
  17. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.opencode.md +154 -1098
  18. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.zed.md +154 -1098
  19. package/src/gdskills/bundled/skills/orchestration/feature-analyzer/orchestrator-prompt.md +1 -1
  20. package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.codex.md +101 -41
  21. package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.cursor.md +101 -41
  22. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.codex.md +115 -49
  23. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.cursor.md +115 -49
  24. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.opencode.md +115 -49
  25. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.zed.md +115 -49
  26. package/src/gdskills/bundled/skills/orchestration/issue-analyzer/orchestrator-prompt.md +1 -1
  27. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.codex.md +15 -6
  28. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.cursor.md +15 -6
  29. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.opencode.md +15 -6
  30. package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.zed.md +15 -6
  31. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.codex.md +1 -1
  32. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.cursor.md +1 -1
  33. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.md +1 -1
  34. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.opencode.md +1 -1
  35. package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.zed.md +1 -1
  36. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.codex.md +300 -55
  37. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.cursor.md +300 -55
  38. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.md +120 -37
  39. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.opencode.md +300 -55
  40. package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.zed.md +300 -55
  41. package/src/gdskills/bundled/skills/orchestration/task-implementer/input-contract.schema.json +56 -14
  42. package/src/gdskills/bundled/skills/orchestration/task-implementer/orchestrator-prompt.md +50 -23
  43. package/src/gdskills/bundled/skills/orchestration/task-implementer/output-contract.schema.json +6 -2
  44. package/src/gdskills/bundled/skills/orchestration/task-implementer/task-request.template.md +18 -12
  45. package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.codex.md +1 -1
  46. package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.cursor.md +1 -1
  47. package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.codex.md +168 -9
  48. package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.cursor.md +168 -9
  49. package/src/gdskills/bundled/skills/planning/interview/SKILL.codex.md +7 -1
  50. package/src/gdskills/bundled/skills/planning/interview/SKILL.cursor.md +7 -1
  51. package/src/gdskills/bundled/skills/planning/interviewer/SKILL.codex.md +7 -1
  52. package/src/gdskills/bundled/skills/planning/interviewer/SKILL.cursor.md +7 -1
  53. package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.codex.md +215 -9
  54. package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.cursor.md +215 -9
  55. package/src/gdskills/bundled/skills/planning/planner/SKILL.codex.md +168 -9
  56. package/src/gdskills/bundled/skills/planning/planner/SKILL.cursor.md +168 -9
  57. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.codex.md +2 -2
  58. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.cursor.md +2 -2
  59. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.opencode.md +2 -2
  60. package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.zed.md +2 -2
  61. package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.codex.md +133 -9
  62. package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.cursor.md +133 -9
  63. package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.codex.md +145 -9
  64. package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.cursor.md +145 -9
  65. package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.codex.md +210 -9
  66. package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.cursor.md +210 -9
  67. package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.codex.md +161 -9
  68. package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.cursor.md +161 -9
  69. package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.codex.md +1 -1
  70. package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.cursor.md +1 -1
  71. package/src/gdskills/bundled/skills/platform/hookify/SKILL.codex.md +1 -1
  72. package/src/gdskills/bundled/skills/platform/hookify/SKILL.cursor.md +1 -1
  73. package/src/gdskills/bundled/skills/quality/changelog/SKILL.codex.md +1 -1
  74. package/src/gdskills/bundled/skills/quality/changelog/SKILL.cursor.md +1 -1
  75. package/src/gdskills/bundled/skills/quality/commit/SKILL.codex.md +1 -1
  76. package/src/gdskills/bundled/skills/quality/commit/SKILL.cursor.md +1 -1
  77. package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.codex.md +1 -1
  78. package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.cursor.md +1 -1
  79. package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.codex.md +1 -1
  80. package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.cursor.md +1 -1
  81. package/src/gdskills/bundled/skills/quality/deploy/SKILL.codex.md +1 -1
  82. package/src/gdskills/bundled/skills/quality/deploy/SKILL.cursor.md +1 -1
  83. package/src/gdskills/bundled/skills/quality/perf-check/SKILL.codex.md +1 -1
  84. package/src/gdskills/bundled/skills/quality/perf-check/SKILL.cursor.md +1 -1
  85. package/src/gdskills/bundled/skills/quality/pr/SKILL.codex.md +1 -1
  86. package/src/gdskills/bundled/skills/quality/pr/SKILL.cursor.md +1 -1
  87. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.codex.md +15 -1
  88. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.cursor.md +248 -165
  89. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.opencode.md +15 -1
  90. package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.zed.md +359 -19
  91. package/src/gdskills/bundled/skills/quality/push/SKILL.codex.md +1 -1
  92. package/src/gdskills/bundled/skills/quality/push/SKILL.cursor.md +1 -1
  93. package/src/gdskills/bundled/skills/quality/security-audit/SKILL.codex.md +1 -1
  94. package/src/gdskills/bundled/skills/quality/security-audit/SKILL.cursor.md +1 -1
  95. package/src/gdskills/bundled/skills/quality/test-gen/SKILL.codex.md +1 -1
  96. package/src/gdskills/bundled/skills/quality/test-gen/SKILL.cursor.md +1 -1
  97. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.codex.md +299 -24
  98. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.cursor.md +296 -31
  99. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.opencode.md +309 -18
  100. package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.zed.md +312 -17
  101. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.codex.md +29 -30
  102. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.cursor.md +29 -30
  103. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.opencode.md +29 -30
  104. package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.zed.md +29 -30
  105. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.codex.md +21 -30
  106. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.cursor.md +21 -30
  107. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.opencode.md +21 -30
  108. package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.zed.md +21 -30
  109. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.codex.md +19 -23
  110. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.cursor.md +19 -23
  111. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.opencode.md +19 -23
  112. package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.zed.md +19 -23
  113. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.codex.md +17 -24
  114. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.cursor.md +17 -24
  115. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.opencode.md +17 -24
  116. package/src/gdskills/bundled/skills/review/code-style-review/SKILL.zed.md +17 -24
  117. package/src/gdskills/bundled/skills/review/review-orchestrator/SKILL.md +16 -3
  118. package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.claude.md +0 -46
  119. package/src/gdskills/bundled/skills/planning/interviewer/SKILL.claude.md +0 -94
  120. package/src/gdskills/bundled/skills/quality/changelog/SKILL.claude.md +0 -45
  121. package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.claude.md +0 -40
  122. package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.claude.md +0 -45
  123. package/src/gdskills/bundled/skills/quality/deploy/SKILL.claude.md +0 -42
  124. package/src/gdskills/bundled/skills/quality/perf-check/SKILL.claude.md +0 -48
  125. package/src/gdskills/bundled/skills/quality/security-audit/SKILL.claude.md +0 -40
  126. package/src/gdskills/bundled/skills/quality/test-gen/SKILL.claude.md +0 -30
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
85
85
  proposal and no `SKILL.md`. A project with no config file does not learn, and
86
86
  that is a supported state rather than an error.
87
87
 
88
- ## Determining the parent ref (deterministic — the branch parent, not the upstream)
88
+ ## Scope Detection
89
89
 
90
- Use the first variant that exists:
90
+ See shared script: `skills/shared/git-merge-base.md`
91
91
 
92
- 1. `origin/main`
93
- 2. `origin/master`
94
- 3. `main`
95
- 4. `master`
96
- 5. `@{upstream}` **only when it is not the current feature branch**
97
-
98
- ```bash
99
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
100
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
101
-
102
- PARENT=""
103
- if git rev-parse --verify -q "origin/main" >/dev/null; then
104
- PARENT="origin/main"
105
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
106
- PARENT="origin/master"
107
- elif git rev-parse --verify -q "main" >/dev/null; then
108
- PARENT="main"
109
- elif git rev-parse --verify -q "master" >/dev/null; then
110
- PARENT="master"
111
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
112
- PARENT="@{upstream}"
113
- else
114
- echo "Cannot determine parent ref" >&2
115
- exit 1
116
- fi
117
-
118
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
119
- ```
92
+ Run the script from that file to determine MERGE_BASE and SCOPE before
93
+ proceeding with the review.
120
94
 
121
95
  ## Commands to assemble the review slice
122
96
 
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
229
203
  +const x = 2;
230
204
  ```
231
205
 
206
+ ---
207
+
208
+ ## Scope Boundaries
209
+
210
+ This skill covers **review against this project's own learned conventions**,
211
+ following `code-review-learned-profile.mdc`. It has no opinions of its own.
212
+
213
+ | Concern | This skill | Use instead |
214
+ | -------------------------------------------------------------- | ---------- | ------------------------ |
215
+ | This project's accumulated review conventions | ✅ YES | — |
216
+ | General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
217
+ | MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
218
+ | Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
219
+ | Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
220
+
221
+ ---
222
+
232
223
  ## Job Context Awareness
233
224
 
234
225
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
85
85
  proposal and no `SKILL.md`. A project with no config file does not learn, and
86
86
  that is a supported state rather than an error.
87
87
 
88
- ## Determining the parent ref (deterministic — the branch parent, not the upstream)
88
+ ## Scope Detection
89
89
 
90
- Use the first variant that exists:
90
+ See shared script: `skills/shared/git-merge-base.md`
91
91
 
92
- 1. `origin/main`
93
- 2. `origin/master`
94
- 3. `main`
95
- 4. `master`
96
- 5. `@{upstream}` **only when it is not the current feature branch**
97
-
98
- ```bash
99
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
100
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
101
-
102
- PARENT=""
103
- if git rev-parse --verify -q "origin/main" >/dev/null; then
104
- PARENT="origin/main"
105
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
106
- PARENT="origin/master"
107
- elif git rev-parse --verify -q "main" >/dev/null; then
108
- PARENT="main"
109
- elif git rev-parse --verify -q "master" >/dev/null; then
110
- PARENT="master"
111
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
112
- PARENT="@{upstream}"
113
- else
114
- echo "Cannot determine parent ref" >&2
115
- exit 1
116
- fi
117
-
118
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
119
- ```
92
+ Run the script from that file to determine MERGE_BASE and SCOPE before
93
+ proceeding with the review.
120
94
 
121
95
  ## Commands to assemble the review slice
122
96
 
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
229
203
  +const x = 2;
230
204
  ```
231
205
 
206
+ ---
207
+
208
+ ## Scope Boundaries
209
+
210
+ This skill covers **review against this project's own learned conventions**,
211
+ following `code-review-learned-profile.mdc`. It has no opinions of its own.
212
+
213
+ | Concern | This skill | Use instead |
214
+ | -------------------------------------------------------------- | ---------- | ------------------------ |
215
+ | This project's accumulated review conventions | ✅ YES | — |
216
+ | General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
217
+ | MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
218
+ | Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
219
+ | Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
220
+
221
+ ---
222
+
232
223
  ## Job Context Awareness
233
224
 
234
225
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
85
85
  proposal and no `SKILL.md`. A project with no config file does not learn, and
86
86
  that is a supported state rather than an error.
87
87
 
88
- ## Determining the parent ref (deterministic — the branch parent, not the upstream)
88
+ ## Scope Detection
89
89
 
90
- Use the first variant that exists:
90
+ See shared script: `skills/shared/git-merge-base.md`
91
91
 
92
- 1. `origin/main`
93
- 2. `origin/master`
94
- 3. `main`
95
- 4. `master`
96
- 5. `@{upstream}` **only when it is not the current feature branch**
97
-
98
- ```bash
99
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
100
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
101
-
102
- PARENT=""
103
- if git rev-parse --verify -q "origin/main" >/dev/null; then
104
- PARENT="origin/main"
105
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
106
- PARENT="origin/master"
107
- elif git rev-parse --verify -q "main" >/dev/null; then
108
- PARENT="main"
109
- elif git rev-parse --verify -q "master" >/dev/null; then
110
- PARENT="master"
111
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
112
- PARENT="@{upstream}"
113
- else
114
- echo "Cannot determine parent ref" >&2
115
- exit 1
116
- fi
117
-
118
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
119
- ```
92
+ Run the script from that file to determine MERGE_BASE and SCOPE before
93
+ proceeding with the review.
120
94
 
121
95
  ## Commands to assemble the review slice
122
96
 
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
229
203
  +const x = 2;
230
204
  ```
231
205
 
206
+ ---
207
+
208
+ ## Scope Boundaries
209
+
210
+ This skill covers **review against this project's own learned conventions**,
211
+ following `code-review-learned-profile.mdc`. It has no opinions of its own.
212
+
213
+ | Concern | This skill | Use instead |
214
+ | -------------------------------------------------------------- | ---------- | ------------------------ |
215
+ | This project's accumulated review conventions | ✅ YES | — |
216
+ | General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
217
+ | MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
218
+ | Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
219
+ | Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
220
+
221
+ ---
222
+
232
223
  ## Job Context Awareness
233
224
 
234
225
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
@@ -85,38 +85,12 @@ An author the config does not name contributes nothing — their text reaches no
85
85
  proposal and no `SKILL.md`. A project with no config file does not learn, and
86
86
  that is a supported state rather than an error.
87
87
 
88
- ## Determining the parent ref (deterministic — the branch parent, not the upstream)
88
+ ## Scope Detection
89
89
 
90
- Use the first variant that exists:
90
+ See shared script: `skills/shared/git-merge-base.md`
91
91
 
92
- 1. `origin/main`
93
- 2. `origin/master`
94
- 3. `main`
95
- 4. `master`
96
- 5. `@{upstream}` **only when it is not the current feature branch**
97
-
98
- ```bash
99
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
100
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
101
-
102
- PARENT=""
103
- if git rev-parse --verify -q "origin/main" >/dev/null; then
104
- PARENT="origin/main"
105
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
106
- PARENT="origin/master"
107
- elif git rev-parse --verify -q "main" >/dev/null; then
108
- PARENT="main"
109
- elif git rev-parse --verify -q "master" >/dev/null; then
110
- PARENT="master"
111
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
112
- PARENT="@{upstream}"
113
- else
114
- echo "Cannot determine parent ref" >&2
115
- exit 1
116
- fi
117
-
118
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
119
- ```
92
+ Run the script from that file to determine MERGE_BASE and SCOPE before
93
+ proceeding with the review.
120
94
 
121
95
  ## Commands to assemble the review slice
122
96
 
@@ -229,6 +203,23 @@ index 0000000..1111111 100644
229
203
  +const x = 2;
230
204
  ```
231
205
 
206
+ ---
207
+
208
+ ## Scope Boundaries
209
+
210
+ This skill covers **review against this project's own learned conventions**,
211
+ following `code-review-learned-profile.mdc`. It has no opinions of its own.
212
+
213
+ | Concern | This skill | Use instead |
214
+ | -------------------------------------------------------------- | ---------- | ------------------------ |
215
+ | This project's accumulated review conventions | ✅ YES | — |
216
+ | General AI review (broader quality, performance, UX) | ❌ NO | `code-ai-review` |
217
+ | MobX store internals (actions, computed, reactions) | ❌ NO | `code-mobx-store-review` |
218
+ | Pure style/naming/architecture pattern audit | ❌ NO | `code-style-review` |
219
+ | Logic correctness with no learned lesson behind it | ❌ NO | `review-logic` |
220
+
221
+ ---
222
+
232
223
  ## Job Context Awareness
233
224
 
234
225
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY
@@ -10,6 +10,7 @@ metadata:
10
10
  version: "1.1.0"
11
11
  category: "review"
12
12
  compatible_harnesses: "cursor,codex,zed,opencode"
13
+ stack_requires: "mobx"
13
14
  license: "MIT"
14
15
  ---
15
16
 
@@ -28,30 +29,11 @@ license: "MIT"
28
29
  - Не ревьюй легаси вне измененного скоупа.
29
30
  - Привязывай замечания к измененным строкам в diff.
30
31
 
31
- ## Git workflow (определение parent и merge-base)
32
+ ## Scope Detection
32
33
 
33
- ```bash
34
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
35
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
36
-
37
- PARENT=""
38
- if git rev-parse --verify -q "origin/main" >/dev/null; then
39
- PARENT="origin/main"
40
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
41
- PARENT="origin/master"
42
- elif git rev-parse --verify -q "main" >/dev/null; then
43
- PARENT="main"
44
- elif git rev-parse --verify -q "master" >/dev/null; then
45
- PARENT="master"
46
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
47
- PARENT="@{upstream}"
48
- else
49
- echo "Cannot determine parent ref" >&2
50
- exit 1
51
- fi
52
-
53
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
54
- ```
34
+ See shared script: `skills/shared/git-merge-base.md`
35
+
36
+ Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
55
37
 
56
38
  ### Команды сбора изменений
57
39
 
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
246
228
 
247
229
  ---
248
230
 
231
+ ## Scope Boundaries
232
+
233
+ This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
234
+
235
+ | Concern | This skill | Use instead |
236
+ |---------|-----------|-------------|
237
+ | Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
238
+ | View↔Store boundary violations | ✅ YES | — |
239
+ | General code quality, readability, tests | ❌ NO | `code-ai-review` |
240
+ | Learned-convention enforcement | ❌ NO | `code-learned-review` |
241
+ | Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
242
+
243
+ ---
244
+
249
245
  ## Job Context Awareness
250
246
 
251
247
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
@@ -10,6 +10,7 @@ metadata:
10
10
  version: "1.1.0"
11
11
  category: "review"
12
12
  compatible_harnesses: "cursor,codex,zed,opencode"
13
+ stack_requires: "mobx"
13
14
  license: "MIT"
14
15
  ---
15
16
 
@@ -28,30 +29,11 @@ license: "MIT"
28
29
  - Не ревьюй легаси вне измененного скоупа.
29
30
  - Привязывай замечания к измененным строкам в diff.
30
31
 
31
- ## Git workflow (определение parent и merge-base)
32
+ ## Scope Detection
32
33
 
33
- ```bash
34
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
35
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
36
-
37
- PARENT=""
38
- if git rev-parse --verify -q "origin/main" >/dev/null; then
39
- PARENT="origin/main"
40
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
41
- PARENT="origin/master"
42
- elif git rev-parse --verify -q "main" >/dev/null; then
43
- PARENT="main"
44
- elif git rev-parse --verify -q "master" >/dev/null; then
45
- PARENT="master"
46
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
47
- PARENT="@{upstream}"
48
- else
49
- echo "Cannot determine parent ref" >&2
50
- exit 1
51
- fi
52
-
53
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
54
- ```
34
+ See shared script: `skills/shared/git-merge-base.md`
35
+
36
+ Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
55
37
 
56
38
  ### Команды сбора изменений
57
39
 
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
246
228
 
247
229
  ---
248
230
 
231
+ ## Scope Boundaries
232
+
233
+ This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
234
+
235
+ | Concern | This skill | Use instead |
236
+ |---------|-----------|-------------|
237
+ | Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
238
+ | View↔Store boundary violations | ✅ YES | — |
239
+ | General code quality, readability, tests | ❌ NO | `code-ai-review` |
240
+ | Learned-convention enforcement | ❌ NO | `code-learned-review` |
241
+ | Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
242
+
243
+ ---
244
+
249
245
  ## Job Context Awareness
250
246
 
251
247
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
@@ -10,6 +10,7 @@ metadata:
10
10
  version: "1.1.0"
11
11
  category: "review"
12
12
  compatible_harnesses: "cursor,codex,zed,opencode"
13
+ stack_requires: "mobx"
13
14
  license: "MIT"
14
15
  ---
15
16
 
@@ -28,30 +29,11 @@ license: "MIT"
28
29
  - Не ревьюй легаси вне измененного скоупа.
29
30
  - Привязывай замечания к измененным строкам в diff.
30
31
 
31
- ## Git workflow (определение parent и merge-base)
32
+ ## Scope Detection
32
33
 
33
- ```bash
34
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
35
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
36
-
37
- PARENT=""
38
- if git rev-parse --verify -q "origin/main" >/dev/null; then
39
- PARENT="origin/main"
40
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
41
- PARENT="origin/master"
42
- elif git rev-parse --verify -q "main" >/dev/null; then
43
- PARENT="main"
44
- elif git rev-parse --verify -q "master" >/dev/null; then
45
- PARENT="master"
46
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
47
- PARENT="@{upstream}"
48
- else
49
- echo "Cannot determine parent ref" >&2
50
- exit 1
51
- fi
52
-
53
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
54
- ```
34
+ See shared script: `skills/shared/git-merge-base.md`
35
+
36
+ Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
55
37
 
56
38
  ### Команды сбора изменений
57
39
 
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
246
228
 
247
229
  ---
248
230
 
231
+ ## Scope Boundaries
232
+
233
+ This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
234
+
235
+ | Concern | This skill | Use instead |
236
+ |---------|-----------|-------------|
237
+ | Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
238
+ | View↔Store boundary violations | ✅ YES | — |
239
+ | General code quality, readability, tests | ❌ NO | `code-ai-review` |
240
+ | Learned-convention enforcement | ❌ NO | `code-learned-review` |
241
+ | Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
242
+
243
+ ---
244
+
249
245
  ## Job Context Awareness
250
246
 
251
247
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
@@ -10,6 +10,7 @@ metadata:
10
10
  version: "1.1.0"
11
11
  category: "review"
12
12
  compatible_harnesses: "cursor,codex,zed,opencode"
13
+ stack_requires: "mobx"
13
14
  license: "MIT"
14
15
  ---
15
16
 
@@ -28,30 +29,11 @@ license: "MIT"
28
29
  - Не ревьюй легаси вне измененного скоупа.
29
30
  - Привязывай замечания к измененным строкам в diff.
30
31
 
31
- ## Git workflow (определение parent и merge-base)
32
+ ## Scope Detection
32
33
 
33
- ```bash
34
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
35
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
36
-
37
- PARENT=""
38
- if git rev-parse --verify -q "origin/main" >/dev/null; then
39
- PARENT="origin/main"
40
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
41
- PARENT="origin/master"
42
- elif git rev-parse --verify -q "main" >/dev/null; then
43
- PARENT="main"
44
- elif git rev-parse --verify -q "master" >/dev/null; then
45
- PARENT="master"
46
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
47
- PARENT="@{upstream}"
48
- else
49
- echo "Cannot determine parent ref" >&2
50
- exit 1
51
- fi
52
-
53
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
54
- ```
34
+ See shared script: `skills/shared/git-merge-base.md`
35
+
36
+ Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
55
37
 
56
38
  ### Команды сбора изменений
57
39
 
@@ -246,6 +228,20 @@ if (executor?.id !== this.executorId) {
246
228
 
247
229
  ---
248
230
 
231
+ ## Scope Boundaries
232
+
233
+ This skill covers **MobX store and state logic** — targeted review of store internals following `mobx-store-template.mdc` and `code-style-patterns.mdc`.
234
+
235
+ | Concern | This skill | Use instead |
236
+ |---------|-----------|-------------|
237
+ | Store structure, actions, computed, reactions, async runInAction | ✅ YES | — |
238
+ | View↔Store boundary violations | ✅ YES | — |
239
+ | General code quality, readability, tests | ❌ NO | `code-ai-review` |
240
+ | Learned-convention enforcement | ❌ NO | `code-learned-review` |
241
+ | Naming/style/architecture patterns outside stores | ❌ NO | `code-style-review` |
242
+
243
+ ---
244
+
249
245
  ## Job Context Awareness
250
246
 
251
247
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
@@ -28,32 +28,11 @@ license: "MIT"
28
28
  - Фидбек должен быть подробным: проблема -> почему это проблема -> где (файл/участок) -> что сделать -> пример исправления.
29
29
  - Исправления предлагай в виде unified diff-патчей, не вноси изменения в код напрямую.
30
30
 
31
- ## Git workflow (вычислить базу и diff)
31
+ ## Scope Detection
32
32
 
33
- Определи parent ref и вычисли merge-base:
33
+ See shared script: `skills/shared/git-merge-base.md`
34
34
 
35
- ```bash
36
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
37
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
38
-
39
- PARENT=""
40
- if git rev-parse --verify -q "origin/main" >/dev/null; then
41
- PARENT="origin/main"
42
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
43
- PARENT="origin/master"
44
- elif git rev-parse --verify -q "main" >/dev/null; then
45
- PARENT="main"
46
- elif git rev-parse --verify -q "master" >/dev/null; then
47
- PARENT="master"
48
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
49
- PARENT="@{upstream}"
50
- else
51
- echo "Cannot determine parent ref" >&2
52
- exit 1
53
- fi
54
-
55
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
56
- ```
35
+ Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
57
36
 
58
37
  Собери входные данные:
59
38
 
@@ -158,6 +137,20 @@ git diff --find-renames <FROM_SHA>..<TO_SHA>
158
137
 
159
138
  ---
160
139
 
140
+ ## Scope Boundaries
141
+
142
+ This skill covers **code style and architecture patterns** — naming, organization, TypeScript usage, pattern compliance per `code-style-patterns.mdc`.
143
+
144
+ | Concern | This skill | Use instead |
145
+ |---------|-----------|-------------|
146
+ | Naming conventions, file organization, import order | ✅ YES | — |
147
+ | TypeScript patterns, component/hook structure | ✅ YES | — |
148
+ | Architecture pattern compliance | ✅ YES | — |
149
+ | Logic correctness, type safety deep dives | ❌ NO | `code-ai-review` or `code-learned-review` |
150
+ | MobX store internals | ❌ NO | `code-mobx-store-review` |
151
+
152
+ ---
153
+
161
154
  ## Job Context Awareness
162
155
 
163
156
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include:
@@ -28,32 +28,11 @@ license: "MIT"
28
28
  - Фидбек должен быть подробным: проблема -> почему это проблема -> где (файл/участок) -> что сделать -> пример исправления.
29
29
  - Исправления предлагай в виде unified diff-патчей, не вноси изменения в код напрямую.
30
30
 
31
- ## Git workflow (вычислить базу и diff)
31
+ ## Scope Detection
32
32
 
33
- Определи parent ref и вычисли merge-base:
33
+ See shared script: `skills/shared/git-merge-base.md`
34
34
 
35
- ```bash
36
- BRANCH="$(git rev-parse --abbrev-ref HEAD)"
37
- UPSTREAM_REF="$(git rev-parse --abbrev-ref --symbolic-full-name @{upstream} 2>/dev/null || true)"
38
-
39
- PARENT=""
40
- if git rev-parse --verify -q "origin/main" >/dev/null; then
41
- PARENT="origin/main"
42
- elif git rev-parse --verify -q "origin/master" >/dev/null; then
43
- PARENT="origin/master"
44
- elif git rev-parse --verify -q "main" >/dev/null; then
45
- PARENT="main"
46
- elif git rev-parse --verify -q "master" >/dev/null; then
47
- PARENT="master"
48
- elif [ -n "$UPSTREAM_REF" ] && [ "$UPSTREAM_REF" != "$BRANCH" ] && [ "$UPSTREAM_REF" != "origin/$BRANCH" ]; then
49
- PARENT="@{upstream}"
50
- else
51
- echo "Cannot determine parent ref" >&2
52
- exit 1
53
- fi
54
-
55
- BASE_SHA="$(git merge-base HEAD "$PARENT")"
56
- ```
35
+ Run the script from that file to determine MERGE_BASE and SCOPE before proceeding with the review.
57
36
 
58
37
  Собери входные данные:
59
38
 
@@ -158,6 +137,20 @@ git diff --find-renames <FROM_SHA>..<TO_SHA>
158
137
 
159
138
  ---
160
139
 
140
+ ## Scope Boundaries
141
+
142
+ This skill covers **code style and architecture patterns** — naming, organization, TypeScript usage, pattern compliance per `code-style-patterns.mdc`.
143
+
144
+ | Concern | This skill | Use instead |
145
+ |---------|-----------|-------------|
146
+ | Naming conventions, file organization, import order | ✅ YES | — |
147
+ | TypeScript patterns, component/hook structure | ✅ YES | — |
148
+ | Architecture pattern compliance | ✅ YES | — |
149
+ | Logic correctness, type safety deep dives | ❌ NO | `code-ai-review` or `code-learned-review` |
150
+ | MobX store internals | ❌ NO | `code-mobx-store-review` |
151
+
152
+ ---
153
+
161
154
  ## Job Context Awareness
162
155
 
163
156
  When dispatched by `job-orchestrator` as part of a job pipeline, the prompt MAY include: