@mrciphersmith/keryx 0.2.72 → 0.2.73
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/cli.js +352 -22
- package/package.json +2 -2
- package/src/gdskills/bundled/rules/core/gproject-contracts.mdc +1 -1
- package/src/gdskills/bundled/rules/core/jobs-documentation.mdc +1 -1
- package/src/gdskills/bundled/rules/core/subagent-context-construction.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.codex.md +326 -20
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.cursor.md +320 -22
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.opencode.md +326 -12
- package/src/gdskills/bundled/skills/orchestration/code-verifier/SKILL.zed.md +333 -9
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.codex.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.cursor.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.opencode.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/SKILL.zed.md +92 -4
- package/src/gdskills/bundled/skills/orchestration/context-collector/orchestrator-prompt.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.codex.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.cursor.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.opencode.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/SKILL.zed.md +154 -1098
- package/src/gdskills/bundled/skills/orchestration/feature-analyzer/orchestrator-prompt.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.codex.md +101 -41
- package/src/gdskills/bundled/skills/orchestration/feature-dev/SKILL.cursor.md +101 -41
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.codex.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.cursor.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.opencode.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/SKILL.zed.md +115 -49
- package/src/gdskills/bundled/skills/orchestration/issue-analyzer/orchestrator-prompt.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.codex.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.cursor.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.opencode.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-documenter/SKILL.zed.md +15 -6
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.opencode.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/job-orchestrator/SKILL.zed.md +1 -1
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.codex.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.cursor.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.md +120 -37
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.opencode.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/SKILL.zed.md +300 -55
- package/src/gdskills/bundled/skills/orchestration/task-implementer/input-contract.schema.json +56 -14
- package/src/gdskills/bundled/skills/orchestration/task-implementer/orchestrator-prompt.md +50 -23
- package/src/gdskills/bundled/skills/orchestration/task-implementer/output-contract.schema.json +6 -2
- package/src/gdskills/bundled/skills/orchestration/task-implementer/task-request.template.md +18 -12
- package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.codex.md +168 -9
- package/src/gdskills/bundled/skills/planning/consistency-checker/SKILL.cursor.md +168 -9
- package/src/gdskills/bundled/skills/planning/interview/SKILL.codex.md +7 -1
- package/src/gdskills/bundled/skills/planning/interview/SKILL.cursor.md +7 -1
- package/src/gdskills/bundled/skills/planning/interviewer/SKILL.codex.md +7 -1
- package/src/gdskills/bundled/skills/planning/interviewer/SKILL.cursor.md +7 -1
- package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.codex.md +215 -9
- package/src/gdskills/bundled/skills/planning/patterns-researcher/SKILL.cursor.md +215 -9
- package/src/gdskills/bundled/skills/planning/planner/SKILL.codex.md +168 -9
- package/src/gdskills/bundled/skills/planning/planner/SKILL.cursor.md +168 -9
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.codex.md +2 -2
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.cursor.md +2 -2
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.opencode.md +2 -2
- package/src/gdskills/bundled/skills/planning/prd-creator/SKILL.zed.md +2 -2
- package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.codex.md +133 -9
- package/src/gdskills/bundled/skills/planning/problem-definer/SKILL.cursor.md +133 -9
- package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.codex.md +145 -9
- package/src/gdskills/bundled/skills/planning/project-discovery/SKILL.cursor.md +145 -9
- package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.codex.md +210 -9
- package/src/gdskills/bundled/skills/planning/spec-writer/SKILL.cursor.md +210 -9
- package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.codex.md +161 -9
- package/src/gdskills/bundled/skills/planning/stack-advisor/SKILL.cursor.md +161 -9
- package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/platform/claude-md-management/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/platform/hookify/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/platform/hookify/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/changelog/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/changelog/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/commit/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/commit/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/deploy/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/deploy/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/perf-check/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/perf-check/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/pr/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/pr/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.codex.md +15 -1
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.cursor.md +248 -165
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.opencode.md +15 -1
- package/src/gdskills/bundled/skills/quality/pr-issue-documenter/SKILL.zed.md +359 -19
- package/src/gdskills/bundled/skills/quality/push/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/push/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/security-audit/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/security-audit/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/test-gen/SKILL.codex.md +1 -1
- package/src/gdskills/bundled/skills/quality/test-gen/SKILL.cursor.md +1 -1
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.codex.md +299 -24
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.cursor.md +296 -31
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.opencode.md +309 -18
- package/src/gdskills/bundled/skills/quality/tests-creator/SKILL.zed.md +312 -17
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.codex.md +29 -30
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.cursor.md +29 -30
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.opencode.md +29 -30
- package/src/gdskills/bundled/skills/review/code-ai-review/SKILL.zed.md +29 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.codex.md +21 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.cursor.md +21 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.opencode.md +21 -30
- package/src/gdskills/bundled/skills/review/code-learned-review/SKILL.zed.md +21 -30
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.codex.md +19 -23
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.cursor.md +19 -23
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.opencode.md +19 -23
- package/src/gdskills/bundled/skills/review/code-mobx-store-review/SKILL.zed.md +19 -23
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.codex.md +17 -24
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.cursor.md +17 -24
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.opencode.md +17 -24
- package/src/gdskills/bundled/skills/review/code-style-review/SKILL.zed.md +17 -24
- package/src/gdskills/bundled/skills/review/review-orchestrator/SKILL.md +16 -3
- package/src/gdskills/bundled/skills/planning/brainstorm/SKILL.claude.md +0 -46
- package/src/gdskills/bundled/skills/planning/interviewer/SKILL.claude.md +0 -94
- package/src/gdskills/bundled/skills/quality/changelog/SKILL.claude.md +0 -45
- package/src/gdskills/bundled/skills/quality/db-migrate/SKILL.claude.md +0 -40
- package/src/gdskills/bundled/skills/quality/dependency-update/SKILL.claude.md +0 -45
- package/src/gdskills/bundled/skills/quality/deploy/SKILL.claude.md +0 -42
- package/src/gdskills/bundled/skills/quality/perf-check/SKILL.claude.md +0 -48
- package/src/gdskills/bundled/skills/quality/security-audit/SKILL.claude.md +0 -40
- package/src/gdskills/bundled/skills/quality/test-gen/SKILL.claude.md +0 -30
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: feature-dev
|
|
3
|
-
description: "
|
|
3
|
+
description: "Use when taking a feature from idea or GitHub issue all the way to a merge-ready PR in one guided workflow."
|
|
4
4
|
triggers:
|
|
5
5
|
- "/feature-dev"
|
|
6
6
|
- "Develop feature"
|
|
@@ -9,12 +9,18 @@ triggers:
|
|
|
9
9
|
- "Feature from scratch"
|
|
10
10
|
metadata:
|
|
11
11
|
author: "MrCipherSmith"
|
|
12
|
-
version: "
|
|
12
|
+
version: "2.0.0"
|
|
13
13
|
category: "workflow"
|
|
14
14
|
compatible_harnesses: "cursor,codex,zed,opencode,claude"
|
|
15
15
|
license: "MIT"
|
|
16
16
|
---
|
|
17
17
|
|
|
18
|
+
<SUBAGENT-STOP>
|
|
19
|
+
If you were dispatched as a subagent to execute a specific task, skip this skill entirely.
|
|
20
|
+
This skill is for interactive feature development sessions only.
|
|
21
|
+
Proceed directly with your assigned task.
|
|
22
|
+
</SUBAGENT-STOP>
|
|
23
|
+
|
|
18
24
|
# Feature Development (7-Phase)
|
|
19
25
|
|
|
20
26
|
End-to-end feature development workflow from idea to merge-ready PR.
|
|
@@ -25,66 +31,104 @@ End-to-end feature development workflow from idea to merge-ready PR.
|
|
|
25
31
|
- `/feature-dev #<issue>` — start from a GitHub issue
|
|
26
32
|
- `/feature-dev --resume` — resume interrupted feature-dev (checks for existing worktree/branch)
|
|
27
33
|
|
|
28
|
-
##
|
|
34
|
+
## 8-Phase Architecture
|
|
35
|
+
|
|
36
|
+
> **Rules always loaded:** `tdd-workflow.mdc`, `implementation-doc-mandate.mdc`, `error-handling.mdc`
|
|
37
|
+
> **Sub-agents used:** `tests-creator` (before implement), `code-verifier` (after implement)
|
|
38
|
+
|
|
39
|
+
### Phase 1: REQUIREMENTS + SPEC
|
|
29
40
|
|
|
30
|
-
### Phase 1: REQUIREMENTS
|
|
31
41
|
1. Parse input (description or GitHub issue via `gh issue view`)
|
|
32
42
|
2. Clarify ambiguities — ask the user up to 3 questions max
|
|
33
|
-
3. Produce
|
|
43
|
+
3. Produce the **Implementation Spec** (per `implementation-doc-mandate.mdc`):
|
|
34
44
|
- **What**: feature description in 2-3 sentences
|
|
35
45
|
- **Why**: user value / business reason
|
|
36
46
|
- **Scope**: what's in, what's explicitly out
|
|
37
47
|
- **Acceptance criteria**: testable bullet points
|
|
38
|
-
|
|
48
|
+
- **Approach**: which files will change, key design decisions
|
|
49
|
+
- **Test strategy**: framework, which scenarios will be covered
|
|
50
|
+
4. **Save spec** to `.feature-spec.md` in project root (add to .gitignore if not already)
|
|
51
|
+
5. **Get user confirmation before proceeding**
|
|
39
52
|
|
|
40
53
|
### Phase 2: DESIGN
|
|
54
|
+
|
|
41
55
|
1. Research the codebase:
|
|
42
56
|
- Find related modules via search tools
|
|
43
57
|
- Read neighboring implementations for patterns
|
|
44
|
-
-
|
|
58
|
+
- **Detect test framework** (package.json, existing test files) — needed for tests-creator
|
|
45
59
|
2. Produce implementation plan:
|
|
46
60
|
- Files to create/modify (with brief description of changes)
|
|
47
61
|
- Dependencies or packages needed
|
|
48
62
|
- Data model changes if any
|
|
49
63
|
- Estimated complexity: S / M / L
|
|
50
|
-
3.
|
|
64
|
+
3. Load relevant rules from `.metaproject/rules/core/` based on what will be built:
|
|
65
|
+
- Always: `tdd-workflow.mdc`, `error-handling.mdc`, `solid-principles.mdc`
|
|
66
|
+
- API/service code: `api-contracts.mdc`, `clean-architecture.mdc`
|
|
67
|
+
- Database: `database-patterns.mdc`
|
|
68
|
+
- Async: `async-patterns.mdc`
|
|
69
|
+
- Security-sensitive: `security-baseline.mdc`
|
|
70
|
+
4. **Get user confirmation on the plan**
|
|
51
71
|
|
|
52
72
|
### Phase 3: PREPARE
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
### Phase 4:
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
|
|
62
|
-
-
|
|
63
|
-
-
|
|
64
|
-
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
+
|
|
74
|
+
1. Create a feature branch: `wt switch -c feat/<name>`
|
|
75
|
+
2. Install any new dependencies
|
|
76
|
+
|
|
77
|
+
### Phase 4: TESTS-CREATOR (TDD — RED phase)
|
|
78
|
+
|
|
79
|
+
**Run before writing any implementation code.**
|
|
80
|
+
|
|
81
|
+
1. For each group of acceptance criteria, invoke `tests-creator`:
|
|
82
|
+
- Input: acceptance criteria from Phase 1 spec + target files from Phase 2 plan
|
|
83
|
+
- tests-creator detects framework and generates failing test stubs
|
|
84
|
+
- tests-creator commits the stubs and verifies RED state
|
|
85
|
+
2. Confirm test stubs are in place and failing before proceeding to Phase 5
|
|
86
|
+
|
|
87
|
+
### Phase 5: IMPLEMENT (TDD — GREEN phase)
|
|
88
|
+
|
|
89
|
+
1. Implement changes file by file, following the plan from Phase 2
|
|
90
|
+
2. Goal: make the failing tests from Phase 4 GREEN
|
|
91
|
+
3. Follow existing code patterns and loaded rules
|
|
92
|
+
4. After each file group, run quick inline check: `npx tsc --noEmit` (type errors only)
|
|
93
|
+
5. Commit with conventional message after each logical chunk
|
|
94
|
+
|
|
95
|
+
### Phase 6: VERIFY (code-verifier gate)
|
|
96
|
+
|
|
97
|
+
Run `code-verifier` on the full diff:
|
|
98
|
+
|
|
99
|
+
```
|
|
100
|
+
Invoke: skills/orchestration/code-verifier/SKILL.md
|
|
101
|
+
Input: codebase_path=<project_root>, scope=changed, base_branch=<base>
|
|
102
|
+
```
|
|
103
|
+
|
|
104
|
+
- `gate: PASS` → proceed to Phase 7
|
|
105
|
+
- `gate: FAIL` → fix findings, re-run code-verifier (max 2 cycles)
|
|
106
|
+
- Still FAIL after 2 cycles → report blocker to user, stop
|
|
107
|
+
|
|
108
|
+
### Phase 7: REVIEW (Self)
|
|
109
|
+
|
|
73
110
|
1. Launch the `review-orchestrator` skill on own changes
|
|
74
111
|
2. Or run a focused self-review:
|
|
75
112
|
- `git diff main...HEAD` — review the full diff
|
|
76
113
|
- Check for: TODOs left behind, console.logs, hardcoded values
|
|
77
|
-
- Verify all acceptance criteria from Phase 1
|
|
114
|
+
- Verify all acceptance criteria from Phase 1 spec
|
|
78
115
|
3. Fix any findings (max 2 review-fix cycles)
|
|
116
|
+
4. Re-run `code-verifier` after any fixes
|
|
117
|
+
|
|
118
|
+
### Phase 8: DELIVER + CHANGE REPORT
|
|
79
119
|
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
2. Commit with conventional message: `feat(<scope>): <description>`
|
|
83
|
-
3. Push branch
|
|
84
|
-
4. Create PR:
|
|
120
|
+
1. Push branch
|
|
121
|
+
2. Create PR:
|
|
85
122
|
- Link to issue if applicable
|
|
86
|
-
- Include acceptance criteria
|
|
87
|
-
- Add test plan
|
|
123
|
+
- Include acceptance criteria checklist
|
|
124
|
+
- Add test plan and code-verifier results
|
|
125
|
+
3. **Produce Change Report** (per `implementation-doc-mandate.mdc`):
|
|
126
|
+
- Files created/modified with descriptions
|
|
127
|
+
- Test count and results
|
|
128
|
+
- code-verifier gate result
|
|
129
|
+
- Acceptance criteria checklist (checked off)
|
|
130
|
+
- Commits list
|
|
131
|
+
4. Print Change Report to user
|
|
88
132
|
5. Report PR URL to user
|
|
89
133
|
|
|
90
134
|
## Status Updates
|
|
@@ -97,9 +141,25 @@ At each phase transition, report progress:
|
|
|
97
141
|
|
|
98
142
|
## Rules
|
|
99
143
|
|
|
100
|
-
- ALWAYS get user confirmation after Phase 1 (requirements) and Phase 2 (design)
|
|
101
|
-
- Phases 4-
|
|
144
|
+
- ALWAYS get user confirmation after Phase 1 (requirements + spec) and Phase 2 (design)
|
|
145
|
+
- Phases 4-7 are autonomous — no user interaction needed
|
|
102
146
|
- If stuck for >3 attempts on any step, report the blocker and ask user
|
|
103
|
-
- NEVER skip Phase
|
|
104
|
-
- NEVER
|
|
105
|
-
-
|
|
147
|
+
- NEVER skip Phase 4 (tests-creator) even if user says "skip tests" — this is TDD, not optional testing
|
|
148
|
+
- NEVER skip Phase 6 (code-verifier) — it is the quality gate, not a suggestion
|
|
149
|
+
- NEVER commit broken code (code-verifier gate must pass before PR)
|
|
150
|
+
- Keep commits atomic: one commit per logical chunk, not one giant commit
|
|
151
|
+
- ALWAYS produce the Change Report in Phase 8 — even if the PR was not created
|
|
152
|
+
|
|
153
|
+
## Red Flags — Stop and re-read this skill if you are thinking:
|
|
154
|
+
|
|
155
|
+
| Rationalization | Why it's wrong |
|
|
156
|
+
|---|---|
|
|
157
|
+
| "Requirements are clear enough, I'll skip the design phase" | Skipping design means discovering mismatches after code is written, not before |
|
|
158
|
+
| "The user already approved this approach verbally, no need to document" | Undocumented approval is invisible to reviewers and future agents; it doesn't exist |
|
|
159
|
+
| "Tests can be written after — implementation first to check if the approach works" | Writing tests after implementation makes you test what you built, not what was required |
|
|
160
|
+
| "This phase isn't needed for such a straightforward feature" | Every skipped phase is a deferred bug report |
|
|
161
|
+
| "I understand the requirements, confirmation is just a formality" | The confirmation step exists to catch the gap between what you understood and what was meant |
|
|
162
|
+
|
|
163
|
+
**IRON LAW 1: NEVER START IMPLEMENTING BEFORE THE SPEC IS WRITTEN AND CONFIRMED.**
|
|
164
|
+
**IRON LAW 2: NEVER WRITE IMPLEMENTATION CODE BEFORE TESTS-CREATOR HAS GENERATED FAILING STUBS.**
|
|
165
|
+
**IRON LAW 3: NEVER DELIVER WITHOUT A PASSING CODE-VERIFIER GATE AND A CHANGE REPORT.**
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: feature-dev
|
|
3
|
-
description: "
|
|
3
|
+
description: "Use when taking a feature from idea or GitHub issue all the way to a merge-ready PR in one guided workflow."
|
|
4
4
|
triggers:
|
|
5
5
|
- "/feature-dev"
|
|
6
6
|
- "Develop feature"
|
|
@@ -9,12 +9,18 @@ triggers:
|
|
|
9
9
|
- "Feature from scratch"
|
|
10
10
|
metadata:
|
|
11
11
|
author: "MrCipherSmith"
|
|
12
|
-
version: "
|
|
12
|
+
version: "2.0.0"
|
|
13
13
|
category: "workflow"
|
|
14
14
|
compatible_harnesses: "cursor,codex,zed,opencode,claude"
|
|
15
15
|
license: "MIT"
|
|
16
16
|
---
|
|
17
17
|
|
|
18
|
+
<SUBAGENT-STOP>
|
|
19
|
+
If you were dispatched as a subagent to execute a specific task, skip this skill entirely.
|
|
20
|
+
This skill is for interactive feature development sessions only.
|
|
21
|
+
Proceed directly with your assigned task.
|
|
22
|
+
</SUBAGENT-STOP>
|
|
23
|
+
|
|
18
24
|
# Feature Development (7-Phase)
|
|
19
25
|
|
|
20
26
|
End-to-end feature development workflow from idea to merge-ready PR.
|
|
@@ -25,66 +31,104 @@ End-to-end feature development workflow from idea to merge-ready PR.
|
|
|
25
31
|
- `/feature-dev #<issue>` — start from a GitHub issue
|
|
26
32
|
- `/feature-dev --resume` — resume interrupted feature-dev (checks for existing worktree/branch)
|
|
27
33
|
|
|
28
|
-
##
|
|
34
|
+
## 8-Phase Architecture
|
|
35
|
+
|
|
36
|
+
> **Rules always loaded:** `tdd-workflow.mdc`, `implementation-doc-mandate.mdc`, `error-handling.mdc`
|
|
37
|
+
> **Sub-agents used:** `tests-creator` (before implement), `code-verifier` (after implement)
|
|
38
|
+
|
|
39
|
+
### Phase 1: REQUIREMENTS + SPEC
|
|
29
40
|
|
|
30
|
-
### Phase 1: REQUIREMENTS
|
|
31
41
|
1. Parse input (description or GitHub issue via `gh issue view`)
|
|
32
42
|
2. Clarify ambiguities — ask the user up to 3 questions max
|
|
33
|
-
3. Produce
|
|
43
|
+
3. Produce the **Implementation Spec** (per `implementation-doc-mandate.mdc`):
|
|
34
44
|
- **What**: feature description in 2-3 sentences
|
|
35
45
|
- **Why**: user value / business reason
|
|
36
46
|
- **Scope**: what's in, what's explicitly out
|
|
37
47
|
- **Acceptance criteria**: testable bullet points
|
|
38
|
-
|
|
48
|
+
- **Approach**: which files will change, key design decisions
|
|
49
|
+
- **Test strategy**: framework, which scenarios will be covered
|
|
50
|
+
4. **Save spec** to `.feature-spec.md` in project root (add to .gitignore if not already)
|
|
51
|
+
5. **Get user confirmation before proceeding**
|
|
39
52
|
|
|
40
53
|
### Phase 2: DESIGN
|
|
54
|
+
|
|
41
55
|
1. Research the codebase:
|
|
42
56
|
- Find related modules via search tools
|
|
43
57
|
- Read neighboring implementations for patterns
|
|
44
|
-
-
|
|
58
|
+
- **Detect test framework** (package.json, existing test files) — needed for tests-creator
|
|
45
59
|
2. Produce implementation plan:
|
|
46
60
|
- Files to create/modify (with brief description of changes)
|
|
47
61
|
- Dependencies or packages needed
|
|
48
62
|
- Data model changes if any
|
|
49
63
|
- Estimated complexity: S / M / L
|
|
50
|
-
3.
|
|
64
|
+
3. Load relevant rules from `.metaproject/rules/core/` based on what will be built:
|
|
65
|
+
- Always: `tdd-workflow.mdc`, `error-handling.mdc`, `solid-principles.mdc`
|
|
66
|
+
- API/service code: `api-contracts.mdc`, `clean-architecture.mdc`
|
|
67
|
+
- Database: `database-patterns.mdc`
|
|
68
|
+
- Async: `async-patterns.mdc`
|
|
69
|
+
- Security-sensitive: `security-baseline.mdc`
|
|
70
|
+
4. **Get user confirmation on the plan**
|
|
51
71
|
|
|
52
72
|
### Phase 3: PREPARE
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
### Phase 4:
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
|
|
62
|
-
-
|
|
63
|
-
-
|
|
64
|
-
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
+
|
|
74
|
+
1. Create a feature branch: `wt switch -c feat/<name>`
|
|
75
|
+
2. Install any new dependencies
|
|
76
|
+
|
|
77
|
+
### Phase 4: TESTS-CREATOR (TDD — RED phase)
|
|
78
|
+
|
|
79
|
+
**Run before writing any implementation code.**
|
|
80
|
+
|
|
81
|
+
1. For each group of acceptance criteria, invoke `tests-creator`:
|
|
82
|
+
- Input: acceptance criteria from Phase 1 spec + target files from Phase 2 plan
|
|
83
|
+
- tests-creator detects framework and generates failing test stubs
|
|
84
|
+
- tests-creator commits the stubs and verifies RED state
|
|
85
|
+
2. Confirm test stubs are in place and failing before proceeding to Phase 5
|
|
86
|
+
|
|
87
|
+
### Phase 5: IMPLEMENT (TDD — GREEN phase)
|
|
88
|
+
|
|
89
|
+
1. Implement changes file by file, following the plan from Phase 2
|
|
90
|
+
2. Goal: make the failing tests from Phase 4 GREEN
|
|
91
|
+
3. Follow existing code patterns and loaded rules
|
|
92
|
+
4. After each file group, run quick inline check: `npx tsc --noEmit` (type errors only)
|
|
93
|
+
5. Commit with conventional message after each logical chunk
|
|
94
|
+
|
|
95
|
+
### Phase 6: VERIFY (code-verifier gate)
|
|
96
|
+
|
|
97
|
+
Run `code-verifier` on the full diff:
|
|
98
|
+
|
|
99
|
+
```
|
|
100
|
+
Invoke: skills/orchestration/code-verifier/SKILL.md
|
|
101
|
+
Input: codebase_path=<project_root>, scope=changed, base_branch=<base>
|
|
102
|
+
```
|
|
103
|
+
|
|
104
|
+
- `gate: PASS` → proceed to Phase 7
|
|
105
|
+
- `gate: FAIL` → fix findings, re-run code-verifier (max 2 cycles)
|
|
106
|
+
- Still FAIL after 2 cycles → report blocker to user, stop
|
|
107
|
+
|
|
108
|
+
### Phase 7: REVIEW (Self)
|
|
109
|
+
|
|
73
110
|
1. Launch the `review-orchestrator` skill on own changes
|
|
74
111
|
2. Or run a focused self-review:
|
|
75
112
|
- `git diff main...HEAD` — review the full diff
|
|
76
113
|
- Check for: TODOs left behind, console.logs, hardcoded values
|
|
77
|
-
- Verify all acceptance criteria from Phase 1
|
|
114
|
+
- Verify all acceptance criteria from Phase 1 spec
|
|
78
115
|
3. Fix any findings (max 2 review-fix cycles)
|
|
116
|
+
4. Re-run `code-verifier` after any fixes
|
|
117
|
+
|
|
118
|
+
### Phase 8: DELIVER + CHANGE REPORT
|
|
79
119
|
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
2. Commit with conventional message: `feat(<scope>): <description>`
|
|
83
|
-
3. Push branch
|
|
84
|
-
4. Create PR:
|
|
120
|
+
1. Push branch
|
|
121
|
+
2. Create PR:
|
|
85
122
|
- Link to issue if applicable
|
|
86
|
-
- Include acceptance criteria
|
|
87
|
-
- Add test plan
|
|
123
|
+
- Include acceptance criteria checklist
|
|
124
|
+
- Add test plan and code-verifier results
|
|
125
|
+
3. **Produce Change Report** (per `implementation-doc-mandate.mdc`):
|
|
126
|
+
- Files created/modified with descriptions
|
|
127
|
+
- Test count and results
|
|
128
|
+
- code-verifier gate result
|
|
129
|
+
- Acceptance criteria checklist (checked off)
|
|
130
|
+
- Commits list
|
|
131
|
+
4. Print Change Report to user
|
|
88
132
|
5. Report PR URL to user
|
|
89
133
|
|
|
90
134
|
## Status Updates
|
|
@@ -97,9 +141,25 @@ At each phase transition, report progress:
|
|
|
97
141
|
|
|
98
142
|
## Rules
|
|
99
143
|
|
|
100
|
-
- ALWAYS get user confirmation after Phase 1 (requirements) and Phase 2 (design)
|
|
101
|
-
- Phases 4-
|
|
144
|
+
- ALWAYS get user confirmation after Phase 1 (requirements + spec) and Phase 2 (design)
|
|
145
|
+
- Phases 4-7 are autonomous — no user interaction needed
|
|
102
146
|
- If stuck for >3 attempts on any step, report the blocker and ask user
|
|
103
|
-
- NEVER skip Phase
|
|
104
|
-
- NEVER
|
|
105
|
-
-
|
|
147
|
+
- NEVER skip Phase 4 (tests-creator) even if user says "skip tests" — this is TDD, not optional testing
|
|
148
|
+
- NEVER skip Phase 6 (code-verifier) — it is the quality gate, not a suggestion
|
|
149
|
+
- NEVER commit broken code (code-verifier gate must pass before PR)
|
|
150
|
+
- Keep commits atomic: one commit per logical chunk, not one giant commit
|
|
151
|
+
- ALWAYS produce the Change Report in Phase 8 — even if the PR was not created
|
|
152
|
+
|
|
153
|
+
## Red Flags — Stop and re-read this skill if you are thinking:
|
|
154
|
+
|
|
155
|
+
| Rationalization | Why it's wrong |
|
|
156
|
+
|---|---|
|
|
157
|
+
| "Requirements are clear enough, I'll skip the design phase" | Skipping design means discovering mismatches after code is written, not before |
|
|
158
|
+
| "The user already approved this approach verbally, no need to document" | Undocumented approval is invisible to reviewers and future agents; it doesn't exist |
|
|
159
|
+
| "Tests can be written after — implementation first to check if the approach works" | Writing tests after implementation makes you test what you built, not what was required |
|
|
160
|
+
| "This phase isn't needed for such a straightforward feature" | Every skipped phase is a deferred bug report |
|
|
161
|
+
| "I understand the requirements, confirmation is just a formality" | The confirmation step exists to catch the gap between what you understood and what was meant |
|
|
162
|
+
|
|
163
|
+
**IRON LAW 1: NEVER START IMPLEMENTING BEFORE THE SPEC IS WRITTEN AND CONFIRMED.**
|
|
164
|
+
**IRON LAW 2: NEVER WRITE IMPLEMENTATION CODE BEFORE TESTS-CREATOR HAS GENERATED FAILING STUBS.**
|
|
165
|
+
**IRON LAW 3: NEVER DELIVER WITHOUT A PASSING CODE-VERIFIER GATE AND A CHANGE REPORT.**
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: issue-analyzer
|
|
3
|
-
description: "
|
|
3
|
+
description: "Use when decomposing a GitHub issue into atomic tasks for AI implementation, planning task breakdown, or preparing work for task-implementer agents."
|
|
4
4
|
triggers:
|
|
5
5
|
- "Analyze issue"
|
|
6
6
|
- "Decompose issue"
|
|
@@ -9,8 +9,9 @@ triggers:
|
|
|
9
9
|
- "Plan issue implementation"
|
|
10
10
|
metadata:
|
|
11
11
|
author: "MrCipherSmith"
|
|
12
|
-
version: "1.
|
|
12
|
+
version: "1.1.0"
|
|
13
13
|
category: "analysis"
|
|
14
|
+
agent_worthy: true
|
|
14
15
|
compatible_harnesses: "cursor,codex,zed,opencode"
|
|
15
16
|
license: "MIT"
|
|
16
17
|
---
|
|
@@ -22,7 +23,7 @@ license: "MIT"
|
|
|
22
23
|
Analyzes a GitHub issue and decomposes it into atomic implementation tasks that can be dispatched to `task-implementer` sub-agents. Designed to run autonomously as a sub-agent — no user interaction required.
|
|
23
24
|
|
|
24
25
|
**Input:** GitHub issue URL (or repo + number) + codebase path(s)
|
|
25
|
-
**Output:**
|
|
26
|
+
**Output:** JSON analysis object with one task entry per atomic task, each containing full context for implementation
|
|
26
27
|
|
|
27
28
|
## When to Use
|
|
28
29
|
|
|
@@ -36,7 +37,7 @@ Analyzes a GitHub issue and decomposes it into atomic implementation tasks that
|
|
|
36
37
|
Phase 1: COLLECT → Fetch all issue data from GitHub
|
|
37
38
|
Phase 2: ANALYZE → Extract intent, find affected code areas
|
|
38
39
|
Phase 3: DECOMPOSE → Break into atomic tasks with dependencies
|
|
39
|
-
Phase 4: FORMALIZE → Emit
|
|
40
|
+
Phase 4: FORMALIZE → Emit structured JSON analysis object
|
|
40
41
|
```
|
|
41
42
|
|
|
42
43
|
---
|
|
@@ -48,7 +49,7 @@ Issue Analyzer Progress:
|
|
|
48
49
|
- [ ] Phase 1: Collect issue data from GitHub
|
|
49
50
|
- [ ] Phase 2: Analyze intent and search codebase
|
|
50
51
|
- [ ] Phase 3: Decompose into atomic tasks
|
|
51
|
-
- [ ] Phase 4: Formalize as
|
|
52
|
+
- [ ] Phase 4: Formalize as JSON output
|
|
52
53
|
```
|
|
53
54
|
|
|
54
55
|
### Phase 1: COLLECT
|
|
@@ -201,49 +202,102 @@ TASKS:
|
|
|
201
202
|
|
|
202
203
|
### Phase 4: FORMALIZE
|
|
203
204
|
|
|
204
|
-
Convert the task list into
|
|
205
|
+
Convert the task list into a structured JSON object for reliable machine parsing.
|
|
205
206
|
|
|
206
207
|
**Output structure:**
|
|
207
208
|
|
|
208
|
-
```
|
|
209
|
-
|
|
210
|
-
|
|
211
|
-
|
|
212
|
-
|
|
213
|
-
|
|
214
|
-
|
|
215
|
-
|
|
216
|
-
|
|
217
|
-
|
|
218
|
-
|
|
219
|
-
|
|
220
|
-
|
|
221
|
-
|
|
222
|
-
|
|
223
|
-
|
|
224
|
-
|
|
225
|
-
|
|
226
|
-
|
|
227
|
-
|
|
228
|
-
|
|
229
|
-
|
|
230
|
-
|
|
231
|
-
|
|
232
|
-
|
|
233
|
-
|
|
234
|
-
|
|
235
|
-
|
|
236
|
-
|
|
237
|
-
|
|
238
|
-
|
|
239
|
-
|
|
240
|
-
|
|
241
|
-
|
|
242
|
-
|
|
243
|
-
|
|
244
|
-
|
|
245
|
-
|
|
246
|
-
|
|
209
|
+
```json
|
|
210
|
+
{
|
|
211
|
+
"issue": {
|
|
212
|
+
"number": "<issue_number>",
|
|
213
|
+
"title": "<issue_title>",
|
|
214
|
+
"type": "<bug|feature|enhancement|refactoring|chore>",
|
|
215
|
+
"repo": "<owner/repo>",
|
|
216
|
+
"intent": "<1-2 sentence intent summary>",
|
|
217
|
+
"labels": ["<label1>", "<label2>"],
|
|
218
|
+
"assignees": ["<user1>"],
|
|
219
|
+
"total_tasks": "<N>"
|
|
220
|
+
},
|
|
221
|
+
"tasks": [
|
|
222
|
+
{
|
|
223
|
+
"task_id": "task-1",
|
|
224
|
+
"task_name": "<Descriptive Task Name>",
|
|
225
|
+
"task_type": "<ui_component|store_logic|service_api|refactoring|fix|mixed>",
|
|
226
|
+
"complexity": "<low|medium|high>",
|
|
227
|
+
"dependencies": [],
|
|
228
|
+
"description": "<full description of what to implement>",
|
|
229
|
+
"target_files": ["src/path/file.ts"],
|
|
230
|
+
"acceptance_criteria": ["criterion 1", "criterion 2"],
|
|
231
|
+
"context": "<relevant code context, key types, function signatures>",
|
|
232
|
+
"existing_tests": ["src/path/file.test.ts"],
|
|
233
|
+
"existing_stories": [],
|
|
234
|
+
"module_patterns": "<how similar code is written in this module>",
|
|
235
|
+
"requires_tests_creator": true
|
|
236
|
+
},
|
|
237
|
+
{
|
|
238
|
+
"task_id": "task-2",
|
|
239
|
+
"task_name": "<Descriptive Task Name>",
|
|
240
|
+
"task_type": "<type>",
|
|
241
|
+
"complexity": "<low|medium|high>",
|
|
242
|
+
"dependencies": ["task-1"],
|
|
243
|
+
"description": "<description>",
|
|
244
|
+
"target_files": ["src/path/other.ts"],
|
|
245
|
+
"acceptance_criteria": ["criterion 1"],
|
|
246
|
+
"context": "<context>",
|
|
247
|
+
"existing_tests": [],
|
|
248
|
+
"existing_stories": [],
|
|
249
|
+
"module_patterns": "<patterns>",
|
|
250
|
+
"requires_tests_creator": true
|
|
251
|
+
}
|
|
252
|
+
],
|
|
253
|
+
"dependency_order": ["task-1", "task-2"]
|
|
254
|
+
}
|
|
255
|
+
```
|
|
256
|
+
|
|
257
|
+
**Each task object is the explicit context for task-implementer.**
|
|
258
|
+
|
|
259
|
+
When `job-orchestrator` dispatches `task-implementer`, it passes the task object directly as the subagent's context. This means:
|
|
260
|
+
- `task.context`, `task.target_files`, and `task.acceptance_criteria` are **required fields** — never omit or leave them empty when the information exists.
|
|
261
|
+
- `task.context` must contain enough information for the implementer to start without reading the full codebase: key types, function signatures, relevant patterns, and any design decisions.
|
|
262
|
+
- `task.module_patterns` must describe how similar code is written nearby — the implementer uses this for style consistency.
|
|
263
|
+
|
|
264
|
+
**Red Flag: "The implementer can figure out the context from the codebase"**
|
|
265
|
+
|
|
266
|
+
→ It cannot — not reliably. An implementer with no context will make assumptions, produce inconsistent code, or ask questions. Every omitted field is a gap the implementer will fill with a guess.
|
|
267
|
+
|
|
268
|
+
## Reporting Results
|
|
269
|
+
|
|
270
|
+
Every final response to the orchestrator MUST begin with `STATUS: DONE` or `STATUS: BLOCKED`.
|
|
271
|
+
|
|
272
|
+
```
|
|
273
|
+
STATUS: DONE
|
|
274
|
+
|
|
275
|
+
## Analysis
|
|
276
|
+
[structured JSON analysis object]
|
|
277
|
+
```
|
|
278
|
+
|
|
279
|
+
Use `STATUS: BLOCKED` only if the issue cannot be fetched (404) or the codebase cannot be accessed.
|
|
280
|
+
|
|
281
|
+
**IRON LAW: THE FIRST LINE OF YOUR FINAL RESPONSE IS ALWAYS "STATUS: DONE" OR "STATUS: BLOCKED". THE JSON ANALYSIS FOLLOWS AFTER.**
|
|
282
|
+
|
|
283
|
+
**Rules for JSON output:**
|
|
284
|
+
- `dependency_order` must be topologically sorted — tasks with no dependencies come first
|
|
285
|
+
- `task_id` format: `task-1`, `task-2`, ... (sequential)
|
|
286
|
+
- `dependencies` lists task_ids that must complete before this task
|
|
287
|
+
- All string arrays may be empty `[]` but not omitted
|
|
288
|
+
- `context` and `module_patterns` may be empty string if not applicable
|
|
289
|
+
- `requires_tests_creator` is always `true` — orchestrator must dispatch `tests-creator` before `task-implementer` for each task
|
|
290
|
+
- Output the JSON block as the **final message** to the orchestrator, preceded by a brief summary (issue type, number of tasks, overall complexity)
|
|
291
|
+
|
|
292
|
+
**Return format** (final message to orchestrator):
|
|
293
|
+
```
|
|
294
|
+
Analysis complete.
|
|
295
|
+
- Issue type: <type>
|
|
296
|
+
- Total tasks: <N>
|
|
297
|
+
- Overall complexity: <low|medium|high>
|
|
298
|
+
- Dependency order: task-1 → task-2 → task-3
|
|
299
|
+
|
|
300
|
+
<json block>
|
|
247
301
|
```
|
|
248
302
|
|
|
249
303
|
---
|
|
@@ -280,22 +334,34 @@ This skill is designed to run fully autonomously. The following settings control
|
|
|
280
334
|
1. **DO NOT** ask the user any questions. All input comes from the input contract.
|
|
281
335
|
2. **DO NOT** modify any files. This is a read-only analysis skill.
|
|
282
336
|
3. **DO NOT** make assumptions about implementation approach — describe WHAT, not HOW.
|
|
283
|
-
4. **DO** include enough context in each
|
|
337
|
+
4. **DO** include enough context in each task entry for a task-implementer to start without asking questions.
|
|
284
338
|
5. **DO** respect the 3-layer architecture: Service → Store → Component ordering.
|
|
285
339
|
6. **DO** identify existing tests and stories so implementer knows what to update.
|
|
286
340
|
7. **DO** note module patterns (how similar code is written nearby) for consistency.
|
|
287
|
-
8. Return the
|
|
341
|
+
8. Return the JSON analysis result as your **final message** to the orchestrator.
|
|
288
342
|
|
|
289
343
|
---
|
|
290
344
|
|
|
345
|
+
## Red Flags — Stop and re-read this skill if you are thinking:
|
|
346
|
+
|
|
347
|
+
| Rationalization | Why it's wrong |
|
|
348
|
+
|---|---|
|
|
349
|
+
| "The issue title is clear enough, I'll skip reading the full body" | Acceptance criteria, repro steps, and constraints live in the body — the title is just a label |
|
|
350
|
+
| "I know this codebase, I don't need to search for affected files" | Prior knowledge drifts; the search step catches files that have changed since you last looked |
|
|
351
|
+
| "I'll create one big task instead of decomposing — simpler to track" | A monolithic task cannot be parallelized or independently verified; it defeats the whole system |
|
|
352
|
+
| "The dependencies between tasks seem obvious, no need to map them" | Untracked dependencies cause agents to overwrite each other's work or build on stale code |
|
|
353
|
+
| "The issue body is mostly boilerplate, I've got the gist" | Edge cases and acceptance criteria are often buried in what looks like boilerplate |
|
|
354
|
+
|
|
355
|
+
**IRON LAW: ALWAYS READ THE FULL ISSUE BODY AND SEARCH THE CODEBASE BEFORE DECOMPOSING INTO TASKS.**
|
|
356
|
+
|
|
291
357
|
## Job Context Awareness
|
|
292
358
|
|
|
293
359
|
When dispatched by `job-orchestrator`, the prompt MAY include:
|
|
294
360
|
|
|
295
361
|
```
|
|
296
362
|
JOB_NAME: <job-name>
|
|
297
|
-
JOBS_ROOT:
|
|
298
|
-
CONTEXT_PATH:
|
|
363
|
+
JOBS_ROOT: <JOBS_ROOT>
|
|
364
|
+
CONTEXT_PATH: <JOBS_ROOT>/<job-name>/ai/context.md
|
|
299
365
|
```
|
|
300
366
|
|
|
301
367
|
If `CONTEXT_PATH` is provided and the file exists, read it during Phase 2 (ANALYZE) to:
|