@moretea-labs/forge 1.5.1 → 1.7.0

package/src/runtime/control-plane/goal-loop/config-types.ts

@@ -1,213 +0,0 @@
-import type { ProviderCapability } from './types';
-
-/** Non-secret provider preference stored under controllerHome/global/. */
-export interface ProviderPreference {
-  providerId: string;
-  enabled: boolean;
-  /** Lower number = higher priority (1 first). */
-  priority: number;
-  /** Optional capability subset override; empty means use registry defaults. */
-  enabledCapabilities?: ProviderCapability[];
-  /** Env var name references only — never values. */
-  credentialEnvVars?: string[];
-  /**
-   * Remote API base URL (e.g. https://api.x.ai/v1). Never a secret.
-   * Only used for kind=remote_api providers.
-   */
-  baseUrl?: string;
-  /** Default model id for remote API providers (non-secret). */
-  model?: string;
-  notes?: string;
-  updatedAt?: string;
-}
-
-/**
- * Secrets for remote API providers — stored under controllerHome/global/provider-secrets.json
- * (never in the git repo). Values must never appear in facade list/status responses.
- */
-export interface ProviderSecretEntry {
-  /** Raw API key / bearer token. */
-  apiKey?: string;
-  updatedAt?: string;
-}
-
-export interface ProviderSecretsFile {
-  schemaVersion: 1;
-  updatedAt: string;
-  providers: Record<string, ProviderSecretEntry>;
-}
-
-export interface ProviderConfigFile {
-  schemaVersion: 1;
-  updatedAt: string;
-  /**
-   * When true, remote API providers may attempt live calls if also allowed by env.
-   * GUI preference is AND-gated with FORGE_ENABLE_LIVE_MODEL_PROVIDERS.
-   */
-  preferLiveModelProviders: boolean;
-  /** Master switch for autonomous goal loop ticks. */
-  goalLoopEnabled: boolean;
-  providers: ProviderPreference[];
-}
-
-export interface LocalToolPreference {
-  toolId: string;
-  enabled: boolean;
-  notes?: string;
-  updatedAt?: string;
-}
-
-export interface LocalToolConfigFile {
-  schemaVersion: 1;
-  updatedAt: string;
-  tools: LocalToolPreference[];
-}
-
-export type RoutingIntentKey =
-  | 'implementation'
-  | 'repair'
-  | 'planning'
-  | 'review'
-  | 'browser_planning'
-  | 'ios_analysis'
-  | 'deterministic_edit'
-  | 'fallback';
-
-export interface ExecutorRoutingConfigFile {
-  schemaVersion: 1;
-  updatedAt: string;
-  /** Ordered provider ids per intent. Handoff-only may appear only as last resort. */
-  orders: Record<RoutingIntentKey, string[]>;
-  defaultImplementationProvider?: string;
-  defaultRepairProvider?: string;
-  defaultPlanningProvider?: string;
-  defaultReviewProvider?: string;
-  defaultBrowserPlanningProvider?: string;
-  defaultIosAnalysisProvider?: string;
-}
-
-export interface GoalLoopPolicyConfigFile {
-  schemaVersion: 1;
-  updatedAt: string;
-  requireApprovalForExternalWrites: boolean;
-  requireApprovalForDestructiveChanges: boolean;
-  requireApprovalForBroadRefactors: boolean;
-  requireApprovalForBrowserFormSubmit: boolean;
-  requireApprovalForGmailSendOrTrash: boolean;
-  requireApprovalForAppStoreConnectWrites: boolean;
-  requireApprovalBeforeFinalMerge: boolean;
-  maxChangedFilesWithoutConfirmation: number;
-  maxChangedLinesWithoutConfirmation: number;
-  defaultRetryBudget: number;
-  maxRepairAttemptsPerProvider: number;
-}
-
-export interface CredentialStatusEntry {
-  providerId: string;
-  displayName: string;
-  requiredEnvVars: string[];
-  presentEnvVars: string[];
-  missingEnvVars: string[];
-  authPresent: boolean;
-  /** Auth from process env. */
-  envAuthPresent: boolean;
-  /** Auth from controllerHome stored secret (GUI-configured). */
-  storedAuthPresent: boolean;
-  /** Masked hint only, e.g. …abc1 — never full key. */
-  storedKeyHint?: string;
-  baseUrl?: string;
-  model?: string;
-  defaultBaseUrl?: string;
-  defaultModel?: string;
-  setupExample: string;
-  storageMode: 'environment_or_controller_home';
-  /** Never includes values. */
-  redacted: true;
-}
-
-export interface LocalToolDescriptor {
-  toolId: string;
-  displayName: string;
-  status: 'detected' | 'missing' | 'disabled';
-  enabled: boolean;
-  executablePath?: string;
-  version?: string;
-  lastHealthCheckAt?: string;
-  capabilityTags: string[];
-  usedByWorkflows: string[];
-  summary: string;
-  healthOk: boolean;
-  lastErrorSummary?: string;
-}
-
-export interface ProviderConfigCard {
-  providerId: string;
-  displayName: string;
-  kindLabel: string;
-  kind: string;
-  status: string;
-  statusLabel: string;
-  enabled: boolean;
-  priority: number;
-  directDispatch: boolean;
-  handoffOnly: boolean;
-  capabilities: string[];
-  safety: {
-    canMutateFilesDirectly: boolean;
-    requiresForgeApply: boolean;
-    externalSideEffects: 'never' | 'approval_required';
-  };
-  credential: {
-    authPresent: boolean;
-    requiredEnvVars: string[];
-    presentEnvVars: string[];
-    envAuthPresent?: boolean;
-    storedAuthPresent?: boolean;
-    storedKeyHint?: string;
-  };
-  /** Remote API settings shown/edited in GUI (non-secret fields). */
-  apiSettings?: {
-    configurable: boolean;
-    baseUrl: string;
-    model: string;
-    defaultBaseUrl: string;
-    defaultModel: string;
-    hasStoredApiKey: boolean;
-    storedKeyHint?: string;
-  };
-  liveModelCalls: {
-    envEnabled: boolean;
-    preferenceEnabled: boolean;
-    effectiveEnabled: boolean;
-  };
-  lastHealthCheckAt?: string;
-  lastErrorSummary?: string;
-  explanation?: string;
-  canEnableDirectDispatch: boolean;
-  summary: string;
-}
-
-export interface AutomationSettingsOverview {
-  goalLoopEnabled: boolean;
-  liveModelProvidersEffective: boolean;
-  liveModelProvidersEnv: boolean;
-  liveModelProvidersPreference: boolean;
-  directProvidersReady: number;
-  handoffOnlyCount: number;
-  providersNeedingConfig: number;
-  localToolsAvailable: number;
-  plainLanguageSummary: string;
-  defaultRoutes: Record<string, string>;
-}
-
-export interface AutomationSettingsViewModel {
-  schemaVersion: 1;
-  generatedAt: string;
-  overview: AutomationSettingsOverview;
-  providers: ProviderConfigCard[];
-  credentials: CredentialStatusEntry[];
-  localTools: LocalToolDescriptor[];
-  routing: ExecutorRoutingConfigFile;
-  policy: GoalLoopPolicyConfigFile;
-  warnings: string[];
-}

package/src/runtime/control-plane/goal-loop/executor-router.ts

@@ -1,109 +0,0 @@
-import { decideRoute } from '../routing/route-policy';
-import type { RoutingIntentKey } from './config-types';
-import type {
-  ExecutorRouteDecision,
-  ExecutorRouteInput,
-  ProviderDescriptor,
-  ProviderStatus,
-  TaskIntent,
-} from './types';
-
-export function intentToRoutingKey(intent: TaskIntent): RoutingIntentKey {
-  switch (intent) {
-    case 'deterministic_edit': return 'deterministic_edit';
-    case 'code_repair':
-    case 'verification_repair': return 'repair';
-    case 'architecture_planning': return 'planning';
-    case 'review': return 'review';
-    case 'browser_automation': return 'browser_planning';
-    case 'ios_build_or_sim': return 'ios_analysis';
-    case 'code_implementation':
-    case 'unknown':
-    default: return 'implementation';
-  }
-}
-
-function defaults(input: ExecutorRouteInput): Record<string, string | undefined> {
-  const config = input.routingConfig;
-  return {
-    implementation: config?.defaultImplementationProvider,
-    repair: config?.defaultRepairProvider,
-    planning: config?.defaultPlanningProvider,
-    review: config?.defaultReviewProvider,
-    browser_planning: config?.defaultBrowserPlanningProvider,
-    ios_analysis: config?.defaultIosAnalysisProvider,
-  };
-}
-
-/** @deprecated Compatibility adapter. Route Policy is the sole routing authority. */
-export function routeExecutor(input: ExecutorRouteInput): ExecutorRouteDecision {
-  const routeDecision = decideRoute(input.routePolicyInput ?? {
-    intent: {
-      objective: input.goal.objective,
-      scopeClear: true,
-      mutation: input.risk !== 'readonly',
-      taskIntent: input.taskIntent,
-      preferredProviderId: input.userConstraints?.preferProvider,
-      allowedProviderIds: input.goal.allowedExecutors,
-      forbiddenProviderIds: [...input.goal.forbiddenExecutors, ...(input.userConstraints?.forbidProvider ?? [])],
-      lastProviderId: input.goal.lastProviderId,
-      lastFailureClass: input.goal.lastFailureClass,
-      agentRequested: true,
-    },
-    workspace: {},
-    policy: {
-      risk: input.risk,
-      policyBlocked: input.policyBlocked,
-      requiresApproval: input.requiresApproval,
-      approvalConfirmed: input.requiresApproval === false,
-      remoteWrite: input.externalWrite,
-    },
-    capabilities: {
-      requiresWorker: true,
-      requiredProviderCapabilities: input.requiredCapabilities,
-      providers: input.providers,
-      routingOrders: input.routingConfig?.orders,
-      defaultProviders: defaults(input),
-    },
-    recovery: { required: true },
-  });
-  const selectedProvider = routeDecision.selectedProviderId
-    ? input.providers.find((provider) => provider.providerId === routeDecision.selectedProviderId)
-    : undefined;
-  return {
-    selectedProviderId: routeDecision.selectedProviderId,
-    ...(selectedProvider ? { selectedProvider } : {}),
-    reason: routeDecision.reasons.map((reason) => reason.message).join(' '),
-    directDispatch: Boolean(selectedProvider?.directDispatch && selectedProvider.kind !== 'handoff_only'),
-    handoffOnly: routeDecision.executionMode === 'handoff_only' || routeDecision.executorKind === 'handoff_only',
-    waitForUser: routeDecision.waitForUser,
-    approvalState: routeDecision.approvalState,
-    alternatives: routeDecision.alternatives,
-    routeDecision,
-  };
-}
-
-export function previewExecutorRoute(input: ExecutorRouteInput): ExecutorRouteDecision {
-  return routeExecutor(input);
-}
-
-export function providerReadyForDirectDispatch(
-  status: ProviderStatus,
-  kind: ProviderDescriptor['kind'],
-  directDispatch: boolean,
-): boolean {
-  return directDispatch && status === 'ready' && kind !== 'handoff_only';
-}
-
-export function validateRoutingOrder(order: string[], options: { allowHandoffOnlyAsLast?: boolean } = {}): {
-  ok: boolean;
-  warnings: string[];
-} {
-  const warnings: string[] = [];
-  const direct = order.filter((id) => id !== 'chatgpt_handoff');
-  if (direct.length === 0) warnings.push('Order contains only handoff-only providers; direct dispatch will not run.');
-  if (order.includes('chatgpt_handoff') && order[0] === 'chatgpt_handoff' && options.allowHandoffOnlyAsLast !== true) {
-    warnings.push('chatgpt_handoff is first; no direct provider will be tried before handoff.');
-  }
-  return { ok: true, warnings };
-}

package/src/runtime/control-plane/goal-loop/failure-taxonomy.ts

@@ -1,149 +0,0 @@
-import type { FailureClass, GoalStatus } from './types';
-
-export interface FailureClassificationInput {
-  message?: string;
-  exitCode?: number;
-  checkId?: string;
-  providerStatus?: string;
-  policyBlocked?: boolean;
-  externalWrite?: boolean;
-  dirtyWorktree?: boolean;
-  staleProjection?: boolean;
-  restartRequired?: boolean;
-  knownClass?: FailureClass;
-}
-
-export interface FailureClassification {
-  failureClass: FailureClass;
-  summary: string;
-  repairableByModel: boolean;
-  requiresApproval: boolean;
-  suggestedNextStatus: GoalStatus;
-  suggestedAction: string;
-}
-
-/**
- * Classify a failure into the goal-loop taxonomy and recommend the next bounded status.
- */
-export function classifyFailure(input: FailureClassificationInput): FailureClassification {
-  if (input.knownClass) {
-    return classificationFor(input.knownClass, input.message);
-  }
-
-  if (input.policyBlocked) {
-    return classificationFor('policy_blocked', input.message);
-  }
-  if (input.externalWrite) {
-    return classificationFor('external_write_requires_approval', input.message);
-  }
-  if (input.dirtyWorktree) {
-    return classificationFor('dirty_worktree', input.message);
-  }
-  if (input.staleProjection) {
-    return classificationFor('stale_runtime_projection', input.message);
-  }
-  if (input.restartRequired) {
-    return classificationFor('controller_restart_required', input.message);
-  }
-
-  const text = `${input.message ?? ''} ${input.checkId ?? ''} ${input.providerStatus ?? ''}`.toLowerCase();
-
-  if (text.includes('rate limit') || text.includes('rate_limited') || text.includes('429')) {
-    return classificationFor('provider_rate_limited', input.message);
-  }
-  if (text.includes('missing_auth') || text.includes('api key') || text.includes('unauthorized') || text.includes('401')) {
-    return classificationFor('missing_auth', input.message);
-  }
-  if (text.includes('unavailable') || text.includes('not found on path') || text.includes('econnrefused')) {
-    return classificationFor('provider_unavailable', input.message);
-  }
-  if (text.includes('merge conflict') || text.includes('conflict')) {
-    return classificationFor('merge_conflict', input.message);
-  }
-  if (text.includes('typecheck') || text.includes('tsc') || text.includes('type error')) {
-    return classificationFor('typecheck_failure', input.message);
-  }
-  if (text.includes('test') || text.includes('spec failed') || text.includes('assertion')) {
-    return classificationFor('test_failure', input.message);
-  }
-  if (text.includes('compile') || text.includes('syntax') || text.includes('source')) {
-    return classificationFor('source_defect', input.message);
-  }
-
-  return classificationFor('unknown', input.message);
-}
-
-function classificationFor(failureClass: FailureClass, message?: string): FailureClassification {
-  const summary = (message ?? failureClass).slice(0, 400);
-  switch (failureClass) {
-    case 'source_defect':
-    case 'test_failure':
-    case 'typecheck_failure':
-    case 'merge_conflict':
-      return {
-        failureClass,
-        summary,
-        repairableByModel: true,
-        requiresApproval: false,
-        suggestedNextStatus: 'repairing',
-        suggestedAction: 'Dispatch repair to a repair-capable invokable provider',
-      };
-    case 'provider_unavailable':
-    case 'provider_rate_limited':
-      return {
-        failureClass,
-        summary,
-        repairableByModel: false,
-        requiresApproval: false,
-        suggestedNextStatus: 'handoff_ready',
-        suggestedAction: 'Retry another provider or create handoff packet',
-      };
-    case 'missing_auth':
-      return {
-        failureClass,
-        summary,
-        repairableByModel: false,
-        requiresApproval: true,
-        suggestedNextStatus: 'waiting_for_user',
-        suggestedAction: 'Configure provider credentials outside the repo',
-      };
-    case 'policy_blocked':
-    case 'external_write_requires_approval':
-      return {
-        failureClass,
-        summary,
-        repairableByModel: false,
-        requiresApproval: true,
-        suggestedNextStatus: 'waiting_for_user',
-        suggestedAction: 'Obtain explicit user approval',
-      };
-    case 'dirty_worktree':
-    case 'stale_runtime_projection':
-      return {
-        failureClass,
-        summary,
-        repairableByModel: false,
-        requiresApproval: false,
-        suggestedNextStatus: 'repairing',
-        suggestedAction: 'Run local maintenance / reconcile before model repair',
-      };
-    case 'controller_restart_required':
-      return {
-        failureClass,
-        summary,
-        repairableByModel: false,
-        requiresApproval: true,
-        suggestedNextStatus: 'waiting_for_user',
-        suggestedAction: 'Restart controller/local bridge with authorization',
-      };
-    default:
-      return {
-        failureClass: 'unknown',
-        summary,
-        repairableByModel: false,
-        requiresApproval: false,
-        suggestedNextStatus: 'handoff_ready',
-        suggestedAction: 'Create handoff packet for human/ChatGPT review',
-      };
-  }
-}