@mohasinac/appkit 4.52.5 → 4.53.1

package/dist/features/products/components/ProductGalleryClient.js

@@ -31,7 +31,7 @@ export function ProductGalleryClient({ images, video, productName }) {
         return (_jsx(Div, { className: `${__O.hidden}`, border: "subtle", rounded: "xl", surface: "muted", children: _jsx(Row, { className: "aspect-square text-[var(--appkit-color-border)] dark:text-[var(--appkit-color-border-subtle)]", align: "center", justify: "center", children: _jsx(PlaceholderSvg, {}) }) }));
     }
     const activeSlide = slides[activeIndex] ?? slides[0];
-    return (_jsxs(Stack, { gap: "3", children: [_jsxs(Div, { rounded: "xl", className: "overflow-hidden border border-[var(--appkit-color-border-subtle)] cursor-zoom-in aspect-square w-full relative", onClick: () => setLightboxIndex(activeIndex), role: "button", tabIndex: 0, onKeyDown: (e) => {
+    return (_jsxs(Stack, { gap: "3", children: [_jsxs(Div, { rounded: "xl", surface: "muted", className: "overflow-hidden border border-[var(--appkit-color-border-subtle)] cursor-zoom-in aspect-square w-full relative", onClick: () => setLightboxIndex(activeIndex), role: "button", tabIndex: 0, onKeyDown: (e) => {
                     if (e.key === "Enter" || e.key === " ")
                         setLightboxIndex(activeIndex);
                 }, "aria-label": activeSlide.kind === "video"
@@ -42,7 +42,7 @@ export function ProductGalleryClient({ images, video, productName }) {
                                 : "Product video"
                             : productName
                                 ? `${productName} — image ${activeIndex + 1}`
-                                : `Product image ${activeIndex + 1}`, size: "gallery", className: "transition-transform duration-300 hover:scale-105" }), activeSlide.kind === "video" && (_jsx(Row, { className: "absolute inset-0 pointer-events-none", align: "center", justify: "center", children: _jsx(Row, { surface: "overlay-sm", rounded: "full", className: "h-16 w-16 text-white", align: "center", justify: "center", children: _jsx(Play, { className: "h-7 w-7 fill-current", "aria-hidden": "true" }) }) }))] }), slides.length > 1 && (_jsx(Div, { layout: "flex", gap: "2", className: `${__O.xAuto}`, padding: "b-2xs", children: slides.map((slide, i) => (_jsxs(Button, { variant: "ghost", type: "button", onClick: () => setActiveIndex(i), rounded: "lg", paddingX: "none", paddingY: "none", className: `relative flex-shrink-0 h-16 w-16 overflow-hidden border-2 transition-all${i === activeIndex
+                                : `Product image ${activeIndex + 1}`, size: "gallery", objectFit: "contain", className: "transition-transform duration-300 hover:scale-105" }), activeSlide.kind === "video" && (_jsx(Row, { className: "absolute inset-0 pointer-events-none", align: "center", justify: "center", children: _jsx(Row, { surface: "overlay-sm", rounded: "full", className: "h-16 w-16 text-white", align: "center", justify: "center", children: _jsx(Play, { className: "h-7 w-7 fill-current", "aria-hidden": "true" }) }) }))] }), slides.length > 1 && (_jsx(Div, { layout: "flex", gap: "2", className: `${__O.xAuto}`, padding: "b-2xs", children: slides.map((slide, i) => (_jsxs(Button, { variant: "ghost", type: "button", onClick: () => setActiveIndex(i), rounded: "lg", paddingX: "none", paddingY: "none", className: `relative flex-shrink-0 h-16 w-16 overflow-hidden border-2 transition-all${i === activeIndex
                         ? " border-primary-500"
                         : " border-transparent opacity-60 hover:opacity-100"}`, "aria-label": slide.kind === "video" ? "View video" : `View image ${i + 1}`, "aria-current": i === activeIndex ? "true" : undefined, children: [_jsx(MediaImage, { src: slide.kind === "video" ? slide.poster : slide.src, alt: slide.kind === "video" ? "Video thumbnail" : `Thumbnail ${i + 1}`, size: "thumbnail" }), slide.kind === "video" && (_jsx(Row, { surface: "overlay-xs", className: "absolute inset-0 pointer-events-none", align: "center", justify: "center", children: _jsx(Play, { className: "h-5 w-5 text-white fill-current", "aria-hidden": "true" }) }))] }, i))) })), slides.length > 1 && (
             // audit-content-alignment-ok: functional image-counter label under the gallery, not page content

package/dist/features/products/components/ProductGrid.js

@@ -165,7 +165,18 @@ function safeHref(href) {
     if (!href)
         return undefined;
     // drop any href that would navigate to a literal "/undefined" segment
-    if (href.includes("/undefined") || href.includes("/null"))
+    /*
+     * A SEGMENT that is literally "undefined"/"null" means an interpolation
+     * produced one — `/products/${maybeUndefined}`.
+     *
+     * Tested with a regex rather than `.includes("/undefined")`, which kills two
+     * birds: a regex literal is not a string Literal node, so the route-literal
+     * rule has nothing to flag and the eslint-disable that used to sit here is
+     * gone; and `.includes` matched any slug CONTAINING the word, so a real
+     * listing at `/products/undefined-sequence-bey` was silently dropped from
+     * the grid. The anchors make it a whole-segment test.
+     */
+    if (/\/(?:undefined|null)(?:\/|$)/.test(href))
         return undefined;
     return href;
 }

package/dist/features/products/components/ProductsIndexListing.d.ts

@@ -15,5 +15,20 @@ export interface ProductsIndexListingProps {
         label: string;
     }[];
     searchPlaceholder?: string;
+    /**
+     * Scope every query to one store, for a store-detail tab.
+     *
+     * 🛑 Added so a store tab can REUSE this component. There are six
+     * hand-written `Store<Type>Listing` components — ~140 lines each of the same
+     * toolbar, availability tabs, sticky pagination and card grid — and a seventh
+     * copy for spares would push a Rule-of-Three breach from six to seven while
+     * being the cheapest possible moment not to. Consolidating the existing six
+     * is its own session; not adding to them costs one prop.
+     *
+     * It OVERRIDES the URL's `storeId` rather than merging: on a store tab the
+     * store is the page, so a `?storeId=` from a stale link must not be able to
+     * show another seller's stock under this seller's heading.
+     */
+    storeId?: string;
 }
-export declare function ProductsIndexListing({ initialData, listingTypes, typeTabs, searchPlaceholder, }: ProductsIndexListingProps): React.JSX.Element;
+export declare function ProductsIndexListing({ initialData, listingTypes, typeTabs, searchPlaceholder, storeId: scopedStoreId, }: ProductsIndexListingProps): React.JSX.Element;

package/dist/features/products/components/ProductsIndexListing.js

@@ -67,7 +67,7 @@ function dedicatedPageFor(types) {
         label: `Full ${plugin.pluralLabel} filters →`,
     };
 }
-export function ProductsIndexListing({ initialData, listingTypes = GENERIC_PRODUCT_LISTING_TYPES, typeTabs = PRODUCT_TYPE_FILTER_TABS, searchPlaceholder = "Search products...", }) {
+export function ProductsIndexListing({ initialData, listingTypes = GENERIC_PRODUCT_LISTING_TYPES, typeTabs = PRODUCT_TYPE_FILTER_TABS, searchPlaceholder = "Search products...", storeId: scopedStoreId, }) {
     const router = useRouter();
     const table = useUrlTable({ defaults: { pageSize: "24", sort: DEFAULT_SORT } });
     const { showToast } = useToast();
@@ -155,7 +155,7 @@ export function ProductsIndexListing({ initialData, listingTypes = GENERIC_PRODU
         maxPrice: table.get(TABLE_KEYS.MAX_PRICE) ? Number(table.get(TABLE_KEYS.MAX_PRICE)) : undefined,
         condition: table.get(TABLE_KEYS.CONDITION) || undefined,
         brand: table.get(TABLE_KEYS.BRAND) || undefined,
-        storeId: table.get(TABLE_KEYS.STORE_ID) || undefined,
+        storeId: scopedStoreId || table.get(TABLE_KEYS.STORE_ID) || undefined,
         freeShipping: table.get(TABLE_KEYS.FREE_SHIPPING) === "true" ? true : undefined,
         // These three are in FILTER_KEYS (so they count toward the filter badge)
         // but were never put on the wire — the drawer sections were inert.
@@ -345,5 +345,5 @@ export function ProductsIndexListing({ initialData, listingTypes = GENERIC_PRODU
                 ] }), totalPages > 1 && (_jsx(StickyToolbar, { offset: "header+pagination", tone: "translucent", border: true, padding: "toolbar", children: _jsx(Row, { justify: "center", children: _jsx(Pagination, { currentPage: page, totalPages: totalPages, onPageChange: (p) => table.setPage(p) }) }) })), _jsx(Div, { padding: "y-lg", children: isLoading ? (_jsx(Grid, { cols: "cards", gap: "md", children: Array.from({ length: 10 }).map((_, i) => (_jsxs(Div, { className: `${__O.hidden} animate-pulse`, border: "subtle", rounded: "xl", children: [_jsx(Div, { className: "aspect-square", surface: "subtle" }), _jsxs(Stack, { className: `${__P.p3}`, gap: "sm", children: [_jsx(Div, { className: "h-3 w-3/4", surface: "subtle", rounded: "default" }), _jsx(Div, { className: "h-3 w-1/2", surface: "subtle", rounded: "default" }), _jsx(Div, { className: "h-4 w-1/3", surface: "subtle", rounded: "default" })] })] }, i))) })) : (_jsx(ProductGrid, { products: products, getProductHref: (p) => pluginFor(p.listingType ?? "standard").detailRoute(p.slug || p.id), view: view === "grid" ? "card" : "list", onWishlistToggle: handleWishlistToggle, wishlistedIds: wishlistedIds, onAddToCart: handleAddToCart, onBuyNow: handleBuyNow, selectionMode: selection.isSelecting, selectedIds: selection.selectedIdSet, onToggleSelect: selection.toggle })) }), _jsx(CompareOverlay, { isOpen: compareIds.length > 0, productIds: compareIds, productType: "product", onClose: () => {
                     setCompareIds([]);
                     selection.clearSelection();
-                }, onRemove: (id) => setCompareIds((ids) => ids.filter((i) => i !== id)) }), _jsx(FilterDrawer, { open: filterOpen, onOpen: openFilters, onClose: () => setFilterOpen(false), onApply: applyFilters, onReset: onFilterClear, activeCount: filterActiveCount, hideTrigger: true, children: _jsx(ProductFilters, { table: pendingTable, currencyPrefix: "\u20B9", listingTypeOptions: listingTypeOptions, listingTypeFooter: dedicatedPage ? (_jsx(Div, { padding: "x-md", paddingY: "b-sm", children: _jsx(TextLink, { href: dedicatedPage.href, size: "sm", weight: "medium", children: dedicatedPage.label }) })) : null, categoryOptions: categoryOptions, brandOptions: brandOptions, featureOptions: featureOptions }) }), _jsx(LoginRequiredModal, { isOpen: modalOpen, onClose: closeModal, message: modalMessage })] }));
+                }, onRemove: (id) => setCompareIds((ids) => ids.filter((i) => i !== id)), onAdd: (id) => setCompareIds((ids) => (ids.includes(id) ? ids : [...ids, id])) }), _jsx(FilterDrawer, { open: filterOpen, onOpen: openFilters, onClose: () => setFilterOpen(false), onApply: applyFilters, onReset: onFilterClear, activeCount: filterActiveCount, hideTrigger: true, children: _jsx(ProductFilters, { table: pendingTable, currencyPrefix: "\u20B9", listingTypeOptions: listingTypeOptions, listingTypeFooter: dedicatedPage ? (_jsx(Div, { padding: "x-md", paddingY: "b-sm", children: _jsx(TextLink, { href: dedicatedPage.href, size: "sm", weight: "medium", children: dedicatedPage.label }) })) : null, categoryOptions: categoryOptions, brandOptions: brandOptions, featureOptions: featureOptions }) }), _jsx(LoginRequiredModal, { isOpen: modalOpen, onClose: closeModal, message: modalMessage })] }));
 }

package/dist/features/products/components/ShowGroupSection.js

@@ -5,6 +5,8 @@ import Link from "next/link.js";
 import { Div, PricesOnly, Row, Span, Text, Modal, SideDrawer, Button } from "../../../ui/index.js";
 import { MediaImage } from "../../media/MediaImage.js";
 import { GroupMemberPicker } from "./GroupMemberPicker.js";
+import { resolveGroupMemberImage } from "../utils/group-member-image.js";
+import { readGroupRules } from "../../../_internal/shared/features/products/group-rules.js";
 import { formatCurrency } from "../../../utils/number.formatter.js";
 import { normalizeListingType } from "../utils/listing-type.js";
 import { pluginFor } from "../../../_internal/shared/listing-types/_registry.js";
@@ -18,7 +20,7 @@ function memberHref(m) {
     return pluginFor(normalizeListingType(m)).detailRoute(slug);
 }
 function MemberThumb({ member, isCurrent }) {
-    const image = member.images?.[0] ?? "";
+    const image = resolveGroupMemberImage(member);
     const href = memberHref(member);
     const price = formatCurrency(member.price, member.currency ?? "INR");
     return (_jsxs(Link, { href: href, "aria-label": member.title, className: "flex flex-col items-center gap-[var(--appkit-space-1-5)] flex-shrink-0 w-16 group", children: [_jsxs(Div, { rounded: "full", className: `relative w-14 h-14 overflow-hidden border-2 transition-all ${isCurrent
@@ -48,7 +50,18 @@ export function ShowGroupSection({ groupId, currentSlug, isParent, groupTitle })
     // The overlay is now a PICKER, not a read-only table: pick how many of each
     // member you want and add the whole selection as one cart line. The picker
     // stands itself down (read-only, no CTA) when the group spans sellers.
-    const tableContent = (_jsx(GroupMemberPicker, { groupId: groupId, groupSource: "product-group", members: members, onAdded: () => setShowAll(false), onAuthRequired: () => setShowAll(false) }));
+    const tableContent = (_jsx(GroupMemberPicker, { groupId: groupId, groupSource: "product-group", members: members, 
+        /*
+         * A product group's rules live on the PARENT, and the parent is one of
+         * the members this component already fetched — found by `isGroupParent`
+         * rather than by position, because the endpoint makes no ordering
+         * promise and the parent is not reliably first.
+         *
+         * 🛑 This is why the five rule fields are in `PRODUCT_PUBLIC_FIELDS`: they
+         * reach `toPublicGroupMember` through that allow-list, and without it the
+         * picker would silently see no rules and permit what the server refuses.
+         */
+        rules: readGroupRules(members.find((m) => m.isGroupParent)), onAdded: () => setShowAll(false), onAuthRequired: () => setShowAll(false) }));
     return (_jsxs(_Fragment, { children: [_jsxs(Div, { className: `${__O.hidden}`, surface: "muted", rounded: "xl", border: "default", children: [_jsxs(Row, { role: "button", tabIndex: 0, onClick: () => setOpen((v) => !v), onKeyDown: (e) => { if (e.key === "Enter" || e.key === " ") {
                             e.preventDefault();
                             setOpen((v) => !v);

package/dist/features/products/components/SparesListView.d.ts

@@ -0,0 +1,7 @@
+import React from "react";
+type SearchParams = Record<string, string | string[]>;
+export interface SparesListViewProps {
+    searchParams?: SearchParams;
+}
+export declare function SparesListView({ searchParams }: SparesListViewProps): Promise<React.JSX.Element>;
+export {};

package/dist/features/products/components/SparesListView.js

@@ -0,0 +1,39 @@
+import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
+import { Container, Heading, Main, Section, Text, TextLink } from "../../../ui/index.js";
+import { AdSlot } from "../../homepage/components/AdSlot.js";
+import { ProductsIndexListing } from "./ProductsIndexListing.js";
+import { PRODUCT_FIELDS } from "../../../constants/field-names.js";
+import { sortBy } from "../../../constants/sort.js";
+import { ROUTES } from "../../../next/routing/route-map.js";
+import { listPublicProducts, parsePublicProductParams, defaultAvailabilityForListingTypes, } from "../../../_internal/server/features/products/list-public.js";
+const DEFAULT_PAGE_SIZE = 24;
+const DEFAULT_SORT = sortBy(PRODUCT_FIELDS.CREATED_AT);
+/** The one type this page spans. Named so the two call sites cannot disagree. */
+const SPARES_LISTING_TYPES = ["spares"];
+export async function SparesListView({ searchParams = {} }) {
+    /*
+     * Filter semantics live in `listPublicProducts`, shared verbatim with
+     * `/api/products`, so the SSR first paint and the client's refetch cannot
+     * disagree about what the default view means. That matters more here than it
+     * looks: every public listing hook sets `staleTime: Infinity` once given SSR
+     * `initialData`, so a disagreement is FROZEN for that query key and no
+     * refetch ever repairs it (Root Cause #30).
+     */
+    const result = await listPublicProducts(parsePublicProductParams(searchParams, {
+        listingTypes: SPARES_LISTING_TYPES,
+        pageSize: DEFAULT_PAGE_SIZE,
+        sorts: DEFAULT_SORT,
+        // Derived from the plugin's own `hideDefault`, so this page and
+        // `ProductsIndexListing` cannot mirror two different literals.
+        ...defaultAvailabilityForListingTypes(SPARES_LISTING_TYPES),
+    }));
+    return (_jsxs(Main, { children: [_jsx(Section, { border: "bottom-subtle", paddingY: "b-md", padding: "t-xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, size: "3xl", weight: "bold", color: "primary", children: "Spares" }), _jsx(Text, { className: "mt-1", color: "muted", size: "sm", children: "Single components off disassembled tops \u2014 attack rings, weight disks, drivers, bits. Sellers list what they have spare; most are one of a kind." }), _jsxs(Text, { className: "mt-2", size: "sm", children: ["Not sure which part you need?", " ", _jsx(TextLink, { href: String(ROUTES.PUBLIC.PARTS), children: "Browse the parts glossary" }), " ", "\u2014 every component, what it does, and which tops use it."] })] }) }), _jsxs(Container, { size: "xl", padding: "x-md", children: [_jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-4 mt-4" }), _jsx(ProductsIndexListing
+                    // `undefined`, not `null` — React Query treats `null` as defined
+                    // data, so a failed query would freeze an empty grid forever under
+                    // `staleTime: Infinity`. Same reasoning as ProductsIndexPageView.
+                    , { 
+                        // `undefined`, not `null` — React Query treats `null` as defined
+                        // data, so a failed query would freeze an empty grid forever under
+                        // `staleTime: Infinity`. Same reasoning as ProductsIndexPageView.
+                        initialData: result ?? undefined, listingTypes: SPARES_LISTING_TYPES, searchPlaceholder: "Search spares by part, colour or model..." }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] })] }));
+}

package/dist/features/products/components/index.d.ts

@@ -32,8 +32,6 @@ export { FeatureBadge, FeatureBadgeList } from "./FeatureBadge";
 export type { FeatureBadgeProps, FeatureBadgeListProps, } from "./FeatureBadge";
 export { ProductFeaturesProvider, useProductFeatures, } from "./ProductFeaturesContext";
 export type { ProductFeaturesProviderProps } from "./ProductFeaturesContext";
-export { ProductsView } from "./ProductsView";
-export type { ProductsViewProps } from "./ProductsView";
 export { ProductDetailView } from "./ProductDetailView";
 export type { ProductDetailViewProps } from "./ProductDetailView";
 export { AuctionDetailView } from "./AuctionDetailView";

package/dist/features/products/components/index.js

@@ -21,7 +21,6 @@ export { ProductFeaturesSelector } from "./ProductFeaturesSelector.js";
 export { ProductFeatureBadges } from "./ProductFeatureBadges.js";
 export { FeatureBadge, FeatureBadgeList } from "./FeatureBadge.js";
 export { ProductFeaturesProvider, useProductFeatures, } from "./ProductFeaturesContext.js";
-export { ProductsView } from "./ProductsView.js";
 export { ProductDetailView } from "./ProductDetailView.js";
 export { AuctionDetailView } from "./AuctionDetailView.js";
 export { PreOrderDetailView } from "./PreOrderDetailView.js";

package/dist/features/products/config/listing-type-listing-config.d.ts

@@ -11,11 +11,8 @@ export interface ListingTypeListingRow {
     image?: string;
 }
 interface ListingTypeListingResponse {
-    /** Admin route shape. */
     items?: JsonArray;
     total?: number;
-    /** Seller route shape. */
-    products?: JsonArray;
     meta?: {
         total?: number;
     };

package/dist/features/products/config/listing-type-listing-config.js

@@ -55,8 +55,15 @@ export function buildListingTypeListingConfig(type, opts = {}) {
         endpoint: isSeller ? SELLER_ENDPOINTS.PRODUCTS : ADMIN_ENDPOINTS.PRODUCTS,
         // The type's own sort set, not a copy-pasted three-option array.
         sortOptions: [...plugin.sortOptions],
-        // The seller route returns `{ products }`, the admin route `{ items }`.
-        mapRows: (response) => toRecordArray(response.items ?? response.products).map((item, index) => ({
+        mapRows: (response) => 
+        /*
+         * `items` only. The `?? response.products` fallback is gone because both
+         * endpoints this config reads (`/api/admin/products`, `/api/store/products`)
+         * now emit the canonical key — verified before removing it. A defence
+         * against a shape that no longer exists reads as though the shape still
+         * might, which is how two spellings stay alive forever.
+         */
+        toRecordArray(response.items).map((item, index) => ({
             id: toStringValue(item.id, `${type}-${index}`),
             primary: toStringValue(item.title ?? item.productTitle, "Untitled listing"),
             secondary: [
@@ -82,5 +89,23 @@ export function buildListingTypeListingConfig(type, opts = {}) {
         // These are products filtered by listingType — reuse the real product
         // editor rather than leaving rows non-navigable.
         rowHrefTemplate: String(isSeller ? ROUTES.STORE.PRODUCTS_EDIT("{id}") : ROUTES.ADMIN.PRODUCTS_EDIT("{id}")),
+        /*
+         * Create, with THIS type preselected.
+         *
+         * All five pages this factory backs (art, classified, digital-codes, live,
+         * stickers) had no create control of any kind. `?listingType=` is read by
+         * the create page and passed to the editor as `initialListingType`, so an
+         * admin landing from the Art list starts on an art listing rather than on
+         * `standard` — which, on a type-scoped list, would create a row that
+         * immediately vanishes from the page it was created on.
+         *
+         * 🛑 A `primaryAction.href` rather than a `toolbarExtra` node: this is a
+         * `.ts` factory and cannot author JSX, which is the structural reason
+         * these five screens went without.
+         */
+        primaryAction: {
+            label: `Add ${plugin.typeLabel}`,
+            href: `${String(isSeller ? ROUTES.STORE.PRODUCTS_NEW : ROUTES.ADMIN.PRODUCTS_NEW)}?${PRODUCT_FIELDS.LISTING_TYPE}=${encodeURIComponent(type)}`,
+        },
     };
 }

package/dist/features/products/constants/action-defs.d.ts

@@ -411,6 +411,7 @@ export declare const SELLER_BULK_ACTIONS: {
     readonly live: readonly ["row-delete"];
     readonly art: readonly ["row-delete"];
     readonly stickers: readonly ["row-delete"];
+    readonly spares: readonly ["row-delete"];
     readonly auctions: readonly ["row-delete"];
     readonly preOrders: readonly ["row-delete"];
     readonly prizeDraws: readonly ["row-delete"];

package/dist/features/products/constants/action-defs.js

@@ -566,6 +566,7 @@ export const SELLER_BULK_ACTIONS = {
     live: [ROW_ACTION_ID.DELETE],
     art: [ROW_ACTION_ID.DELETE],
     stickers: [ROW_ACTION_ID.DELETE],
+    spares: [ROW_ACTION_ID.DELETE],
     auctions: [ROW_ACTION_ID.DELETE],
     preOrders: [ROW_ACTION_ID.DELETE],
     prizeDraws: [ROW_ACTION_ID.DELETE],

package/dist/features/products/constants/listing-tabs.d.ts

@@ -20,6 +20,7 @@
  * relevant array explicitly — those are genuinely different collections.
  */
 import type { ListingType } from "../types";
+import type { IconKey } from "../../../ui/icons/icon-registry";
 export interface ListingTab {
     id: string;
     label: string;
@@ -31,6 +32,14 @@ export interface ListingTab {
     collection?: "bundles";
     /** Set when the tab queries a non-product entity (e.g. `stores`). */
     entity?: "stores";
+    /**
+     * Leading glyph, carried from `ListingTypePlugin.iconKey`.
+     *
+     * Only set on tabs backed by ONE listing type. The combined Art & Stickers
+     * tab leaves it unset on purpose: it spans two types with two different
+     * glyphs, and picking either would claim the tab is only that one.
+     */
+    iconName?: IconKey;
 }
 /**
  * The types the generic `/products` browse page spans — the GENERAL CATALOGUE,

package/dist/features/products/constants/listing-tabs.js

@@ -58,7 +58,8 @@ export const ART_STICKERS_LISTING_TYPES = ["art", "stickers"];
  * straight into `sieveFilter("listingType", EQ, id)`. Never a display label.
  */
 function chipTab(type) {
-    return { id: type, label: pluginFor(type).chipLabel, listingType: type };
+    const plugin = pluginFor(type);
+    return { id: type, label: plugin.chipLabel, listingType: type, iconName: plugin.iconKey };
 }
 /**
  * A ROUTE-BACKED tab — `id` is the plugin's `tabSlug`, because it doubles as
@@ -67,7 +68,7 @@ function chipTab(type) {
  */
 function pluralTab(type) {
     const plugin = pluginFor(type);
-    return { id: plugin.tabSlug, label: plugin.pluralLabel, listingType: type };
+    return { id: plugin.tabSlug, label: plugin.pluralLabel, listingType: type, iconName: plugin.iconKey };
 }
 /**
  * Art and stickers share the combined `/art` browse page, so category/brand/

package/dist/features/products/hooks/useProducts.js

@@ -57,8 +57,8 @@ export function useProducts(params = {}, opts) {
         sp.set(LISTING_PARAM_NAMES.sorts.long, params.sort);
     if (params.page)
         sp.set("page", String(params.page));
-    if (params.perPage)
-        sp.set("pageSize", String(params.perPage));
+    if (params.pageSize)
+        sp.set("pageSize", String(params.pageSize));
     if (params.featured !== undefined)
         sp.set("featured", String(params.featured));
     if (params.minBid !== undefined)

package/dist/features/products/repository/products.repository.d.ts

@@ -267,16 +267,106 @@ export declare class ProductRepository extends BaseRepository<ProductDocument> {
     updateAvailableQuantity(productId: string, quantity: number): Promise<void>;
     updateBid(productId: string, bidAmount: number, bidCount: number): Promise<void>;
     findAvailable(): Promise<ProductDocument[]>;
+    /**
+     * Every member of a group, UNFILTERED — drafts, and every listing type.
+     *
+     * 🛑 This is the scope `dissolveGroup` needs and the ONLY one that may be
+     * unfiltered. A filtered dissolve leaves the excluded members carrying a
+     * `groupId` pointing at a group that no longer exists, which nothing ever
+     * clears — and that orphan is invisible until someone wonders why a product
+     * claims to be in a group with no other members.
+     */
+    findAllByGroupId(groupId: string): Promise<ProductDocument[]>;
+    /**
+     * Group members a BUYER may see: eligible types, published only.
+     *
+     * 🛑 The type filter is DERIVED from `canJoinProductGroup`, not hard-coded.
+     * It used to be a literal `["standard", "pre-order"]`, which silently dropped
+     * every `stickers` / `art` member from the query — so `ShowGroupSection` saw
+     * one member and returned null, and the picker was unreachable with nothing
+     * erroring anywhere (Root Cause #58).
+     *
+     * 🛑 The `status` filter is NEW and is a leak fix, not a tightening. There
+     * was no status filter at all, so DRAFT members were reaching the public
+     * `/api/products/group/[groupId]` payload; widening the type list without
+     * this would have widened that leak at the same time.
+     */
+    findGroupMembersForPublic(groupId: string): Promise<ProductDocument[]>;
+    /**
+     * Union the child-side query with the PARENT's own `groupChildSlugs`.
+     *
+     * Mirrors `resolveBundleMemberIds`, and exists for the same reason: Root
+     * Cause #42 documented a parent carrying `groupChildSlugs` while its children
+     * had no `groupId`, so a child-side query resolved only the parent and the
+     * group rendered as one member. The repository's six mutating methods all
+     * write both sides in one batch, so code cannot produce that state — but a
+     * seeded fixture or a direct Firestore edit still can, and the READER was
+     * never made resilient. `listBundleMembers` got this fix; this did not.
+     */
+    private withParentSideFallback;
+    /**
+     * @deprecated Ambiguous about scope — say which one you mean.
+     * Kept so no caller silently changes behaviour; it resolves to the PUBLIC
+     * scope, which is what every existing caller wanted.
+     */
     findByGroupId(groupId: string): Promise<ProductDocument[]>;
     startGroup(productId: string, slug: string): Promise<void>;
     updateGroupTitle(productId: string, groupTitle: string): Promise<void>;
     dissolveGroup(groupId: string): Promise<void>;
+    /**
+     * Link ONE child into a parent's group.
+     *
+     * 🛑 `arrayUnion`, not a spread of the in-memory `parent.groupChildSlugs`.
+     *
+     * The spread read a snapshot the CALLER was holding, so linking N children in
+     * a loop produced exactly ONE entry: every iteration computed
+     * `[...(stale ?? []), child]` from the same pre-loop document and the last
+     * write won. Nothing errored — each child got its own `groupId` correctly, so
+     * `findAllByGroupId` found them all while the parent's own
+     * `groupChildSlugs` claimed one member, which is what the group picker's
+     * fallback path and `GroupSettingsPanel` read.
+     *
+     * `arrayUnion` is also idempotent, so re-linking an existing child is a
+     * no-op instead of a duplicate id.
+     *
+     * For a known set, prefer `linkChildrenToGroup` below — one batch instead of
+     * N, which matters against Rule #6's round-trip budget when promoting a
+     * 60-part sticker sheet.
+     */
     linkChildToGroup(parent: ProductDocument, child: ProductDocument): Promise<void>;
+    /**
+     * Link SEVERAL children into a parent's group in one batch.
+     *
+     * Built for `promoteStickerSheetToListings`, which links every unique part of
+     * a sheet at once — N calls to `linkChildToGroup` would be N batch commits
+     * for work that is one logical change.
+     */
+    linkChildrenToGroup(parent: ProductDocument, children: readonly ProductDocument[]): Promise<void>;
     unlinkChildFromGroup(parent: ProductDocument, child: ProductDocument): Promise<void>;
     leaveGroup(child: ProductDocument, parent: ProductDocument | null): Promise<void>;
     addChildProduct(parent: ProductDocument, child: Omit<import("../schemas/firestore").ProductCreateInput, "groupId" | "isGroupParent" | "groupParentSlug" | "groupTitle">): Promise<ProductDocument>;
     deleteByStore(storeId: string): Promise<number>;
     delete(id: string): Promise<void>;
+    /**
+     * Every live listing OF one glossary part, across all stores.
+     *
+     * 🛑 NOT filtered by `listingType`, deliberately. Both `spares` and the
+     * 972 generated per-leaf catalogue rows (which are `standard`) carry
+     * `partGlossaryId`, and a buyer on `/parts/{slot}/{code}` wants any listing
+     * of that part — not only the ones that happen to be filed under the newer
+     * type. Narrowing to `spares` would hide most of the real inventory.
+     *
+     * 🛑 `orderBy` is `createdAt`, which EVERY document carries
+     * (`BaseRepository.create` writes it). Ordering by an optional field silently
+     * excludes every row lacking it — Root Cause #100, where `itemsSold` on zero
+     * of 95 products made a store`s whole review endpoint return nothing.
+     *
+     * Availability is filtered IN MEMORY rather than in the query: "available" is
+     * negation-shaped and no query expresses it, which is the asymmetry
+     * `baseAvailable` exists for. The window is bounded, so the cost is a few
+     * rows read and discarded.
+     */
+    findByPartGlossaryId(partGlossaryId: string, limit?: number): Promise<ProductDocument[]>;
     static readonly SIEVE_FIELDS: {
         id: {
             canFilter: boolean;
@@ -330,6 +420,14 @@ export declare class ProductRepository extends BaseRepository<ProductDocument> {
             canFilter: boolean;
             canSort: boolean;
         };
+        partGlossaryId: {
+            canFilter: boolean;
+            canSort: boolean;
+        };
+        colourway: {
+            canFilter: boolean;
+            canSort: boolean;
+        };
         isPromoted: {
             canFilter: boolean;
             canSort: boolean;