@mohasinac/appkit 4.52.5 → 4.53.1

package/dist/features/categories/api/[id]/price-guidance/route.d.ts

@@ -0,0 +1,42 @@
+/**
+ * feat-categories — GET /api/categories/[id]/price-guidance
+ *
+ * The seller-facing price hint `description-template/route.ts`'s own
+ * docstring names as "C1's job, from a surface that knows who is asking" —
+ * this is that surface. It is deliberately a SEPARATE endpoint rather than a
+ * field added back to the public, CDN-cached template route: that route's
+ * whole point is that anyone can fetch it, and `priceGuidance` is withheld
+ * from signed-out visitors for the same reason a listing's own price is
+ * (CLAUDE.md § "Guest price gating") — publishing the competitor-derived
+ * market band on an unauthenticated, publicly-cacheable response would be
+ * exactly the "a neighbouring surface publishes the range" leak that gate
+ * exists to close, even though the number is advisory rather than a real
+ * price.
+ *
+ * Consumer stub:
+ * ```ts
+ * // src/app/api/categories/[id]/price-guidance/route.ts
+ * export { categoryPriceGuidanceGET as GET } from "@mohasinac/appkit";
+ * ```
+ *
+ * ## What this does NOT resolve
+ *
+ * `PriceGuidanceBasis.gstRate` — "the rate that will be written onto this
+ * listing, resolved the same way `deriveTaxonomy` resolves it" — is left
+ * `undefined` here on purpose. `deriveTaxonomy` is a private method on
+ * `ProductRepository`, tightly coupled to the product WRITE path (it also
+ * applies `DEFAULT_GST_RATE` as a last resort, which is correct for a
+ * document being saved and would be a guess presented as fact on a read-only
+ * hint). `describePriceGuidanceBasis` already handles an unresolved rate
+ * correctly and safely: for the common case (a seller whose prices already
+ * include GST — the schema default), the rate is never consulted at all, so
+ * this omission costs nothing. Only an EXCLUSIVE-pricing seller sees the
+ * honest "could not be resolved" note instead of a converted figure — which
+ * is the behaviour `price-guidance.ts`'s own docstring prescribes for exactly
+ * this situation, not a half-measure standing in for the real resolution.
+ */
+export declare const GET: (request: Request, context?: {
+    params: Promise<{
+        id: string;
+    }>;
+} | undefined) => Promise<Response>;

package/dist/features/categories/api/[id]/price-guidance/route.js

@@ -0,0 +1,113 @@
+/**
+ * feat-categories — GET /api/categories/[id]/price-guidance
+ *
+ * The seller-facing price hint `description-template/route.ts`'s own
+ * docstring names as "C1's job, from a surface that knows who is asking" —
+ * this is that surface. It is deliberately a SEPARATE endpoint rather than a
+ * field added back to the public, CDN-cached template route: that route's
+ * whole point is that anyone can fetch it, and `priceGuidance` is withheld
+ * from signed-out visitors for the same reason a listing's own price is
+ * (CLAUDE.md § "Guest price gating") — publishing the competitor-derived
+ * market band on an unauthenticated, publicly-cacheable response would be
+ * exactly the "a neighbouring surface publishes the range" leak that gate
+ * exists to close, even though the number is advisory rather than a real
+ * price.
+ *
+ * Consumer stub:
+ * ```ts
+ * // src/app/api/categories/[id]/price-guidance/route.ts
+ * export { categoryPriceGuidanceGET as GET } from "@mohasinac/appkit";
+ * ```
+ *
+ * ## What this does NOT resolve
+ *
+ * `PriceGuidanceBasis.gstRate` — "the rate that will be written onto this
+ * listing, resolved the same way `deriveTaxonomy` resolves it" — is left
+ * `undefined` here on purpose. `deriveTaxonomy` is a private method on
+ * `ProductRepository`, tightly coupled to the product WRITE path (it also
+ * applies `DEFAULT_GST_RATE` as a last resort, which is correct for a
+ * document being saved and would be a guess presented as fact on a read-only
+ * hint). `describePriceGuidanceBasis` already handles an unresolved rate
+ * correctly and safely: for the common case (a seller whose prices already
+ * include GST — the schema default), the rate is never consulted at all, so
+ * this omission costs nothing. Only an EXCLUSIVE-pricing seller sees the
+ * honest "could not be resolved" note instead of a converted figure — which
+ * is the behaviour `price-guidance.ts`'s own docstring prescribes for exactly
+ * this situation, not a half-measure standing in for the real resolution.
+ */
+import { NextResponse } from "next/server.js";
+import { normalizeError } from "../../../../../errors/normalize.js";
+import { serverLogger } from "../../../../../monitoring/index.js";
+import { createRouteHandler } from "../../../../../next/api/routeHandler.js";
+import { getProviders } from "../../../../../contracts/index.js";
+import { categoriesRepository } from "../../../repository/categories.repository.js";
+import { isAdminUser } from "../../../../auth/role-predicates.js";
+import { priceGuidanceOnSellerBasis, describePriceGuidanceBasis, } from "../../../../../_internal/shared/features/categories/price-guidance.js";
+const MAX_ANCESTORS = 8;
+/**
+ * Nearest-first ancestor walk for `priceGuidance`, same shape as
+ * `description-template/route.ts`'s `resolveInherited` — the leaf's own band
+ * wins, and only a leaf with none falls back to the nearest ancestor that has
+ * one. ONE bounded `findByIds`, not a sequential walk: a seller form hitting
+ * this on every category change should not pay up to eight round trips for it.
+ */
+async function resolveInheritedGuidance(leaf) {
+    if (leaf.productDefaults?.priceGuidance)
+        return leaf.productDefaults.priceGuidance;
+    const parentIds = (leaf.parentIds ?? []).slice(0, MAX_ANCESTORS);
+    if (parentIds.length === 0)
+        return undefined;
+    const nearestFirst = [...parentIds].reverse();
+    const ancestors = await categoriesRepository.findByIds(nearestFirst);
+    const byId = new Map(ancestors.map((a) => [a.id, a]));
+    for (const pid of nearestFirst) {
+        const guidance = byId.get(pid)?.productDefaults?.priceGuidance;
+        if (guidance)
+            return guidance;
+    }
+    return undefined;
+}
+export const GET = createRouteHandler({
+    roles: ["seller", "admin", "moderator"],
+    handler: async ({ user, params }) => {
+        try {
+            const categoryId = params?.id;
+            if (!categoryId) {
+                return NextResponse.json({ success: false, error: "Missing category id" }, { status: 400 });
+            }
+            const leafDoc = await categoriesRepository.findById(categoryId);
+            if (!leafDoc) {
+                return NextResponse.json({ success: false, error: "Category not found" }, { status: 404 });
+            }
+            const guidance = await resolveInheritedGuidance(leafDoc);
+            if (!guidance) {
+                return NextResponse.json({ success: true, data: { guidance: null, basisNote: null } });
+            }
+            /*
+             * One read, admin exempted (no store to look up). `pricesIncludeGst`
+             * absent means `true` — matching the schema default and the store
+             * route's own `?? true` (see `PriceGuidanceBasis.sellerIncludesGst`'s
+             * docstring for why this must stay consistent everywhere it's read).
+             */
+            let sellerIncludesGst;
+            if (!isAdminUser(user)) {
+                const { db } = getProviders();
+                const storesRepo = db?.getRepository("stores");
+                const result = await storesRepo?.findAll({ filters: `ownerId==${user.uid}`, pageSize: 1 });
+                sellerIncludesGst = result?.data[0]?.pricesIncludeGst;
+            }
+            const basis = { sellerIncludesGst, gstRate: undefined };
+            const onSellerBasis = priceGuidanceOnSellerBasis(guidance, basis);
+            const basisNote = describePriceGuidanceBasis(basis);
+            return NextResponse.json({ success: true, data: { guidance: onSellerBasis, basisNote } }, {
+                // Per-seller basis, so never shared across callers.
+                headers: { "Cache-Control": "private, max-age=3600" },
+            });
+        }
+        catch (err) {
+            const e = normalizeError(err);
+            serverLogger.error("price-guidance read failed", { message: e.message });
+            return NextResponse.json({ success: false, error: "Could not load price guidance" }, { status: 500 });
+        }
+    },
+});

package/dist/features/categories/api/route.js

@@ -184,7 +184,7 @@ export async function GET(request) {
         if (slug) {
             const result = await repo.findAll({
                 filters: `slug==${slug}`,
-                perPage: 1,
+                pageSize: 1,
             });
             const category = result.data[0] ?? null;
             if (!category) {
@@ -223,7 +223,7 @@ export async function GET(request) {
             tier !== null ||
             type !== null;
         if (isFiltered) {
-            const perPage = pageSizeParam !== null && pageSizeParam > 0 ? pageSizeParam : 200;
+            const pageSize = pageSizeParam !== null && pageSizeParam > 0 ? pageSizeParam : 200;
             const page = pageParam ?? 1;
             /*
              * 🛑 `listingOnly` and `q` both force an in-memory window, and `total`
@@ -255,7 +255,7 @@ export async function GET(request) {
                 const res = isPaged
                     ? NextResponse.json({
                         success: true,
-                        data: { items: [], total: 0, page, perPage, totalPages: 0, hasMore: false },
+                        data: { items: [], total: 0, page, pageSize, totalPages: 0, hasMore: false },
                     })
                     : NextResponse.json({ success: true, data: [] });
                 res.headers.set("Cache-Control", CACHE_CONTROL_PUBLIC);
@@ -264,7 +264,7 @@ export async function GET(request) {
             const terms = plan.head ? [plan.head, ...plan.rest] : [];
             const needsWindow = listingOnly || terms.length > 0;
             const windowed = needsWindow
-                ? await repo.findAll({ filters, sort: "order", order: "asc", perPage: 500 })
+                ? await repo.findAll({ filters, sort: "order", order: "asc", pageSize: 500 })
                 : null;
             let items;
             let total;
@@ -274,8 +274,8 @@ export async function GET(request) {
                     .filter((d) => (terms.length ? matchesAllSearchTerms(d.searchTxt, terms) : true))
                     .sort((a, b) => (a.order ?? 0) - (b.order ?? 0));
                 total = kept.length;
-                const offset = (page - 1) * perPage;
-                items = (isPaged ? kept.slice(offset, offset + perPage) : kept).map(toCategoryListItem);
+                const offset = (page - 1) * pageSize;
+                items = (isPaged ? kept.slice(offset, offset + pageSize) : kept).map(toCategoryListItem);
             }
             else {
                 const result = await repo.findAll({
@@ -283,7 +283,7 @@ export async function GET(request) {
                     sort: "order",
                     order: "asc",
                     page: pageParam ?? undefined,
-                    perPage,
+                    pageSize,
                 });
                 total = result.total;
                 items = result.data
@@ -291,7 +291,7 @@ export async function GET(request) {
                     .map(toCategoryListItem);
             }
             items = await withLiveTotals(items);
-            const totalPages = total === 0 ? 0 : Math.max(1, Math.ceil(total / perPage));
+            const totalPages = total === 0 ? 0 : Math.max(1, Math.ceil(total / pageSize));
             /*
              * Shape switches on `?page=`, deliberately, and only there.
              *
@@ -311,7 +311,7 @@ export async function GET(request) {
             const res = isPaged
                 ? NextResponse.json({
                     success: true,
-                    data: { items, total, page, perPage, totalPages, hasMore: page < totalPages },
+                    data: { items, total, page, pageSize, totalPages, hasMore: page < totalPages },
                 })
                 : NextResponse.json({ success: true, data: items });
             res.headers.set("Cache-Control", CACHE_CONTROL_PUBLIC);
@@ -322,7 +322,7 @@ export async function GET(request) {
             filters,
             sort: "order",
             order: "asc",
-            perPage: 500,
+            pageSize: 500,
         });
         // Project BEFORE nesting — `CategoryTreeNode extends CategoryItem`, so the
         // children carry the public shape too rather than being raw documents

package/dist/features/categories/components/BrandDetailPageView.js

@@ -7,6 +7,7 @@ import { ROUTES } from "../../../next/routing/route-map.js";
 import { Anchor, Container, Div, Dl, Dt, Dd, Heading, Main, Nav, Section, Span, Stack, Text } from "../../../ui/index.js";
 import { DynamicBgDiv } from "../../../ui/components/DynamicBgDiv.js";
 import { MediaImage } from "../../media/MediaImage.js";
+import { RichTextRenderer } from "../../../ui/rich-text/RichTextRenderer.js";
 import { BrandDetailTabs } from "./BrandDetailTabs.js";
 import { CategoryGrid } from "./CategoryGrid.js";
 import { CategoryHighlightsAndFaqSection } from "./CategoryHighlightsAndFaqSection.js";
@@ -27,8 +28,23 @@ export async function BrandDetailPageView({ slug, initialBrand }) {
     // The brand IS this page's subject — a read failure must surface rather than
     // render an anonymous, empty brand page. `undefined` still means "no such
     // brand slug".
-    const brand = (initialBrand ?? (await categoriesRepository
-        .getCategoryBySlug(slug)) ?? undefined);
+    const brandDoc = initialBrand ?? (await categoriesRepository.getCategoryBySlug(slug)) ?? undefined;
+    const brand = (brandDoc ?? undefined);
+    /*
+     * 🛑 Read from the DOCUMENT, not from the `CategoryItem` cast — the same rule
+     * `CategoryDetailPageView` states for this exact field.
+     *
+     * `contentBody` is deliberately PRIVATE on the list projection: it is 400-900
+     * chars of HTML per row and `CategoryInlineSelect` fetches 200 rows on every
+     * seller-form open, so publishing it there would be the Fast-Origin-Transfer
+     * shape of Root Cause #104. Widening `CategoryItem` to satisfy one render site
+     * is exactly the invitation that comment warns about — and it is what the
+     * first attempt at this did, which `tsc` caught.
+     *
+     * No extra read: this page already holds the whole document (`initialBrand`,
+     * or the fetch above). Only the local cast hid it.
+     */
+    const brandContentBody = typeof brandDoc?.contentBody === "string" ? brandDoc.contentBody : null;
     const brandName = brand?.name;
     const [productsResult, tabCounts, allBundles, activeBrands, groupedListings, settings] = await Promise.all([
         brandName
@@ -152,5 +168,5 @@ export async function BrandDetailPageView({ slug, initialBrand }) {
     const ldFaq = brand?.faqs && brand.faqs.length > 0
         ? faqJsonLd(brand.faqs.map((f) => ({ question: f.question, answer: f.answer })))
         : null;
-    return (_jsxs(Main, { children: [_jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldBreadcrumb) } }), _jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldCollection) } }), ldFaq && (_jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldFaq) } })), _jsxs(Section, { className: `relative ${__O.hidden} ${hasCover ? "min-h-[220px] md:min-h-[280px]" : "bg-[var(--appkit-color-bg)]"}`, children: [hasCover && (_jsxs(_Fragment, { children: [_jsx(Div, { className: "absolute inset-0", children: _jsx(MediaImage, { src: coverImage, alt: "", size: "banner" }) }), _jsx(Div, { surface: "overlay-md", className: "absolute inset-0" })] })), !hasCover && (_jsx(DynamicBgDiv, { color: brandColor, className: "absolute inset-0 opacity-10" })), _jsxs(Div, { className: "relative z-10 max-w-7xl mx-auto", paddingY: hasCover ? "y-3xl" : "y-xl", padding: "x-md", children: [_jsxs(Nav, { layout: "flex", gap: "2xs", textSize: "sm", className: "mb-4", "aria-label": "Breadcrumb", children: [_jsx(Link, { href: String(ROUTES.HOME), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 transition-colors", children: "Home" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Link, { href: String(ROUTES.PUBLIC.BRANDS), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 transition-colors", children: "Brands" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Span, { weight: "medium", className: hasCover ? "text-white" : "text-[var(--appkit-color-text)]", children: brand?.name ?? slug })] }), _jsxs(Row, { className: "mb-3", align: "center", gap: "md", children: [brand?.display?.icon && (_jsx(Span, { className: "leading-none", size: "5xl", children: brand.display.icon })), _jsxs(_Fragment, { children: [_jsx(Heading, { color: "inverse", level: 1, className: `${hasCover ? "" : "text-[var(--appkit-color-text)]"}`, size: "3xl", mdSize: "4xl", weight: "bold", children: brand?.name ?? slug }), brand?.description && typeof brand.description === "string" && !brand.description.startsWith("{") && (_jsx(Text, { color: hasCover ? "inverse" : "muted", className: `max-w-2xl mt-1 ${hasCover ? "/80" : ""}`, size: "base", children: brand.description }))] })] }), _jsxs(Row, { gap: "sm", wrap: true, className: "mt-3", children: [(counts.products ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: "inverse", size: "xs", weight: "medium", className: `${hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "bg-primary/10 text-primary-700 dark:text-primary-400"}`, rounded: "full", padding: "pill-sm-tall", children: [counts.products.toLocaleString(), " ", counts.products === 1 ? "product" : "products"] })), (counts.auctions ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "warning", surface: hasCover ? undefined : "warning-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts.auctions.toLocaleString(), " ", counts.auctions === 1 ? "auction" : "auctions"] })), (counts["pre-orders"] ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "info", surface: hasCover ? undefined : "info-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts["pre-orders"].toLocaleString(), " ", counts["pre-orders"] === 1 ? "pre-order" : "pre-orders"] })), totalItems === 0 && (_jsx(Span, { size: "sm", className: hasCover ? "text-white/60" : "text-zinc-400", children: "No items listed yet" }))] })] })] }), (brand?.brandWebsite || brand?.brandCountry || brand?.brandFounded) && (_jsx(Section, { border: "subtle", surface: "default", className: "border-b", padding: "y-md", children: _jsx(Container, { size: "xl", children: _jsxs(Stack, { gap: "sm", children: [_jsx(Heading, { level: 2, size: "sm", weight: "semibold", color: "muted", transform: "uppercase", children: "About this brand" }), _jsxs(Dl, { divide: "subtle", rounded: "xl", border: "subtle", className: "overflow-hidden max-w-lg", children: [brand?.brandWebsite && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Website" }), _jsx(Dd, { className: "flex-1", children: _jsx(Anchor, { href: brand.brandWebsite, tone: "brand", underline: "hover", children: brand.brandWebsite }) })] })), brand?.brandCountry && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Country" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandCountry })] })), brand?.brandFounded && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Founded" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandFounded })] }))] })] }) }) })), _jsx(CategoryHighlightsAndFaqSection, { highlights: brand?.highlights, faqs: brand?.faqs }), _jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: brandName ? (_jsx(BrandDetailTabs, { brandName: brandName, initialProductsData: productsResult ?? undefined, initialBundles: brandBundles, counts: counts, enabledListingTypes: enabledListingTypes(settings), enabledCategoryTypes: enabledCategoryTypes(settings) })) : (_jsx(Text, { paddingY: "3xl", color: "muted", size: "sm", align: "start", children: "Brand not found." })) }) }), groupedListings.length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(GroupedListingsCarousel, { groups: groupedListings }) }) })), relatedBrands.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-t", padding: "y-lg", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 2, className: "mb-4", size: "xl", weight: "semibold", children: "Related Brands" }), _jsx(CategoryGrid, { categories: relatedBrands, getHref: (b) => String(ROUTES.PUBLIC.BRAND_DETAIL(b.slug)) })] }) }))] }));
+    return (_jsxs(Main, { children: [_jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldBreadcrumb) } }), _jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldCollection) } }), ldFaq && (_jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldFaq) } })), _jsxs(Section, { className: `relative ${__O.hidden} ${hasCover ? "min-h-[220px] md:min-h-[280px]" : "bg-[var(--appkit-color-bg)]"}`, children: [hasCover && (_jsxs(_Fragment, { children: [_jsx(Div, { className: "absolute inset-0", children: _jsx(MediaImage, { src: coverImage, alt: "", size: "banner" }) }), _jsx(Div, { surface: "overlay-md", className: "absolute inset-0" })] })), !hasCover && (_jsx(DynamicBgDiv, { color: brandColor, className: "absolute inset-0 opacity-10" })), _jsxs(Div, { className: "relative z-10 max-w-7xl mx-auto", paddingY: hasCover ? "y-3xl" : "y-xl", padding: "x-md", children: [_jsxs(Nav, { layout: "flex", gap: "2xs", textSize: "sm", className: "mb-4", "aria-label": "Breadcrumb", children: [_jsx(Link, { href: String(ROUTES.HOME), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 dark:hover:text-primary-400 transition-colors", children: "Home" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Link, { href: String(ROUTES.PUBLIC.BRANDS), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 dark:hover:text-primary-400 transition-colors", children: "Brands" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Span, { weight: "medium", className: hasCover ? "text-white" : "text-[var(--appkit-color-text)]", children: brand?.name ?? slug })] }), _jsxs(Row, { className: "mb-3", align: "center", gap: "md", children: [brand?.display?.icon && (_jsx(Span, { className: "leading-none", size: "5xl", children: brand.display.icon })), _jsxs(_Fragment, { children: [_jsx(Heading, { color: "inverse", level: 1, className: `${hasCover ? "" : "text-[var(--appkit-color-text)]"}`, size: "3xl", mdSize: "4xl", weight: "bold", children: brand?.name ?? slug }), brand?.description && typeof brand.description === "string" && !brand.description.startsWith("{") && (_jsx(Text, { color: hasCover ? "inverse" : "muted", className: `max-w-2xl mt-1 ${hasCover ? "/80" : ""}`, size: "base", children: brand.description }))] })] }), _jsxs(Row, { gap: "sm", wrap: true, className: "mt-3", children: [(counts.products ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: "inverse", size: "xs", weight: "medium", className: `${hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "bg-primary/10 text-primary-700 dark:text-primary-400"}`, rounded: "full", padding: "pill-sm-tall", children: [counts.products.toLocaleString(), " ", counts.products === 1 ? "product" : "products"] })), (counts.auctions ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "warning", surface: hasCover ? undefined : "warning-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts.auctions.toLocaleString(), " ", counts.auctions === 1 ? "auction" : "auctions"] })), (counts["pre-orders"] ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "info", surface: hasCover ? undefined : "info-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts["pre-orders"].toLocaleString(), " ", counts["pre-orders"] === 1 ? "pre-order" : "pre-orders"] })), totalItems === 0 && (_jsx(Span, { size: "sm", className: hasCover ? "text-white/60" : "text-zinc-400", children: "No items listed yet" }))] })] })] }), (brand?.brandWebsite || brand?.brandCountry || brand?.brandFounded) && (_jsx(Section, { border: "subtle", surface: "default", className: "border-b", padding: "y-md", children: _jsx(Container, { size: "xl", children: _jsxs(Stack, { gap: "sm", children: [_jsx(Heading, { level: 2, size: "sm", weight: "semibold", color: "muted", transform: "uppercase", children: "About this brand" }), _jsxs(Dl, { divide: "subtle", rounded: "xl", border: "subtle", className: "overflow-hidden max-w-lg", children: [brand?.brandWebsite && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Website" }), _jsx(Dd, { className: "flex-1", children: _jsx(Anchor, { href: brand.brandWebsite, tone: "brand", underline: "hover", children: brand.brandWebsite }) })] })), brand?.brandCountry && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Country" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandCountry })] })), brand?.brandFounded && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Founded" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandFounded })] }))] })] }) }) })), brandContentBody && brandContentBody.trim().length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(RichTextRenderer, { html: brandContentBody }) }) })), _jsx(CategoryHighlightsAndFaqSection, { highlights: brand?.highlights, faqs: brand?.faqs }), _jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: brandName ? (_jsx(BrandDetailTabs, { brandName: brandName, initialProductsData: productsResult ?? undefined, initialBundles: brandBundles, counts: counts, enabledListingTypes: enabledListingTypes(settings), enabledCategoryTypes: enabledCategoryTypes(settings) })) : (_jsx(Text, { paddingY: "3xl", color: "muted", size: "sm", align: "start", children: "Brand not found." })) }) }), groupedListings.length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(GroupedListingsCarousel, { groups: groupedListings }) }) })), relatedBrands.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-t", padding: "y-lg", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 2, className: "mb-4", size: "xl", weight: "semibold", children: "Related Brands" }), _jsx(CategoryGrid, { categories: relatedBrands, getHref: (b) => String(ROUTES.PUBLIC.BRAND_DETAIL(b.slug)) })] }) }))] }));
 }

package/dist/features/categories/components/BrandDetailTabs.js

@@ -35,6 +35,16 @@ const GENERIC_TAB_LISTING_TYPES = {
     [pluginFor("digital-code").tabSlug]: ["digital-code"],
     [pluginFor("live").tabSlug]: ["live"],
     [pluginFor("art").tabSlug]: ART_STICKERS_LISTING_TYPES,
+    /*
+     * Spares render generically — a product grid is the whole story, unlike an
+     * auction (countdown, bid history) or a prize draw (entries remaining).
+     *
+     * 🛑 Hand-written map; a missing entry is a tab you can CLICK that renders an
+     * empty panel. `audit-tab-body-coverage` exists for exactly this, after this
+     * file silently DROPPED four types while its `CategoryDetailTabs` twin
+     * rendered them as blank panels — two spellings of one gap.
+     */
+    [pluginFor("spares").tabSlug]: ["spares"],
 };
 export function BrandDetailTabs({ brandName, initialProductsData, initialBundles = [], counts, enabledListingTypes, enabledCategoryTypes, }) {
     const countFor = (id) => counts?.[id];

package/dist/features/categories/components/CategoriesIndexListing.js

@@ -4,7 +4,7 @@ import { useState, useCallback, useMemo } from "react";
 import { useCategoriesFiltered } from "../hooks/useCategories.js";
 import { CATEGORY_TABS, DEFAULT_CATEGORY_TAB, matchesCategoryTab, } from "../constants/category-tabs.js";
 import { ROUTES } from "../../../next/routing/route-map.js";
-import { Button, Div, Grid, ListingFilterDrawer, ListingToolbar, Pagination, Row, Stack, Text, StickyToolbar } from "../../../ui/index.js";
+import { Div, Grid, ListingFilterDrawer, ListingToolbar, OverflowRow, Pagination, Row, Stack, Text, StickyToolbar } from "../../../ui/index.js";
 import { CategoryCard } from "./CategoryGrid.js";
 import { CategoryFilters } from "./CategoryFilters.js";
 import { useUrlTable } from "../../../react/hooks/useUrlTable.js";
@@ -170,13 +170,28 @@ export function CategoriesIndexListing({ brandsOnly = false }) {
         pageSize: PAGE_SIZE,
     });
     const activeSearch = table.get(TABLE_KEYS.QUERY) || "";
-    const TABS = CATEGORY_TABS;
-    return (_jsxs(Div, { className: "min-h-screen", children: [!brandsOnly && (_jsx(Row, { gap: "xs", border: "default", className: "border-b mb-2", children: TABS.map((tab) => (_jsx(Button, { variant: "ghost", type: "button", onClick: () => switchTab(tab.key), paddingX: "md", paddingY: "y-xs-tall", textSize: "sm", weight: "medium", className: [
-                        "transition-colors border-b-2 -mb-px rounded-none",
-                        activeTab === tab.key
-                            ? "border-primary text-primary dark:text-primary-400 dark:border-primary-400"
-                            : "border-transparent text-[var(--appkit-color-text-muted)] hover:text-zinc-800 text-[var(--appkit-color-text-muted)] hover:text-[var(--appkit-color-text-muted)]",
-                    ].join(" "), children: tab.label }, tab.key))) })), _jsx(ListingToolbar, { filterCount: activeFilterCount, onFiltersClick: openFilters, searchValue: searchInput, searchPlaceholder: activeTab === "brands" || brandsOnly ? "Search brands..." : "Search categories...", onSearchChange: setSearchInput, onSearchCommit: commitSearch, sortValue: sort, sortOptions: SORT_OPTIONS, onSortChange: (v) => { table.set(TABLE_KEYS.SORT, v); }, view: view, onViewChange: handleViewToggle, onResetAll: resetAll, hasActiveState: hasActiveState, toggles: [
+    /*
+     * 🛑 `<OverflowRow>`, not a hand-rolled row of ghost Buttons.
+     *
+     * This was five `<Button variant="ghost">`s in a `<Row>` with a hand-written
+     * underline — no `role="tablist"`, no `role="tab"`, and no overflow
+     * behaviour at all, so on a narrow viewport the last tabs simply ran past
+     * the right edge with no scrollbar and no affordance. The Known-TS-Patterns
+     * table bans exactly that shape ("A hand-rolled overflow-x-auto row of
+     * pills/tabs → <OverflowRow>"), and the primitive built for it had shipped
+     * three weeks earlier without this surface being migrated.
+     *
+     * `variant="tabs"` because these swap a panel in place — they rewrite the
+     * `tab` URL param and re-partition one already-cached payload; they do not
+     * navigate. That is also why the items carry `onSelect` rather than `href`,
+     * and therefore why `linkProps`/`scroll` do not apply here.
+     */
+    const tabItems = CATEGORY_TABS.map((tab) => ({
+        id: tab.key,
+        label: tab.label,
+        onSelect: () => switchTab(tab.key),
+    }));
+    return (_jsxs(Div, { className: "min-h-screen", children: [!brandsOnly && (_jsx(Div, { className: "mb-2", children: _jsx(OverflowRow, { items: tabItems, activeId: activeTab, variant: "tabs", ariaLabel: "Category index sections", searchPlaceholder: "Search sections\u2026" }) })), _jsx(ListingToolbar, { filterCount: activeFilterCount, onFiltersClick: openFilters, searchValue: searchInput, searchPlaceholder: activeTab === "brands" || brandsOnly ? "Search brands..." : "Search categories...", onSearchChange: setSearchInput, onSearchCommit: commitSearch, sortValue: sort, sortOptions: SORT_OPTIONS, onSortChange: (v) => { table.set(TABLE_KEYS.SORT, v); }, view: view, onViewChange: handleViewToggle, onResetAll: resetAll, hasActiveState: hasActiveState, toggles: [
                     { label: "Featured only", active: table.get(TABLE_KEYS.IS_FEATURED) === "true", onChange: (next) => table.set(TABLE_KEYS.IS_FEATURED, next ? "true" : "") },
                 ] }), totalPages > 1 && (_jsx(StickyToolbar, { offset: "header+pagination", tone: "translucent", border: true, padding: "toolbar", children: _jsx(Row, { justify: "center", children: _jsx(Pagination, { currentPage: page, totalPages: totalPages, onPageChange: (p) => table.setPage(p) }) }) })), _jsx(Div, { padding: "y-lg", children: renderCategoryGrid({ isLoading, categories, view, activeSearch, activeTab, brandsOnly }) }), renderCategoryFilterDrawer({ filterOpen, setFilterOpen, activeFilterCount, clearFilters, applyFilters, pendingTable })] }));
 }