@mohasinac/appkit 4.43.0 → 4.45.0

package/dist/features/categories/api/[id]/description-template/route.js

@@ -0,0 +1,252 @@
+/**
+ * feat-categories — GET /api/categories/[id]/description-template
+ *
+ * The ONE read the seller form makes when a category or condition changes.
+ *
+ * ```ts
+ * // app/api/categories/[id]/description-template/route.ts
+ * export { categoryDescriptionTemplateGET as GET } from "@mohasinac/appkit";
+ * ```
+ *
+ * ## Why an endpoint rather than letting the client walk the tree
+ *
+ * A description template lives on the category and INHERITS: a named-model
+ * leaf like `category-dragoon-g` carries no body of its own, and the right one
+ * is on the `category-original-engine-gear` line above it. Resolving that on
+ * the client would be one request per ancestor, on every category change, from
+ * a form — up to five round trips to answer one question.
+ *
+ * Here it is **two reads worst case and zero on a cache hit**: the leaf, then
+ * one bounded `getAll` over at most four ancestors, behind a one-hour edge
+ * cache. The response depends only on `(id, variant)` and category content
+ * changes when an admin edits it, so an hour of staleness costs a seller
+ * nothing and saves a function invocation per keystroke-free form open.
+ *
+ * ## 🛑 NO MONEY IN THIS PAYLOAD
+ *
+ * `Cache-Control: public` means a CDN holds this and anyone can fetch it, so
+ * `priceGuidance` is deliberately stripped even though it sits in the same
+ * `productDefaults` object. The band is competitor-derived market data, not a
+ * listing price — but prices are withheld from signed-out visitors precisely
+ * because hiding one number is pointless if a neighbouring surface publishes
+ * the range, and a publicly-cached endpoint is exactly such a surface. The
+ * seller's price hint is C1's job, from a surface that knows who is asking.
+ *
+ * `taxCodeId` is stripped for a different reason: nothing on the client reads
+ * it. The rate is resolved server-side by `deriveTaxonomy`, which is the whole
+ * point of the reference being server-resolved (C2a) — a client that knew the
+ * code could not do anything correct with it.
+ */
+import { NextResponse } from "next/server.js";
+import { normalizeError } from "../../../../../errors/normalize.js";
+import { serverLogger } from "../../../../../monitoring/index.js";
+/*
+ * The repository directly, which is the established shape for an appkit API
+ * route (blog/[slug], products/[id] and seller/products all do the same). The
+ * `getProviders()` contract exposes only the generic `IRepository`, so the
+ * bounded `findByIds` ancestor walk this route needs is not reachable through
+ * it — and the alternative is four sequential reads on a route the seller form
+ * hits on every category change.
+ */
+import { categoriesRepository } from "../../../repository/categories.repository.js";
+import { usedPlaceholders } from "../../../../../_internal/shared/templating/placeholders.js";
+/**
+ * The variants a caller may ask for.
+ *
+ * 🛑 Validated against the union rather than passed through. An unrecognised
+ * variant must fall back to `default` and not reach a `templates.find()` that
+ * would answer `null` — because `null` here means "this category has no
+ * template", which the picker renders as "No template yet". A typo'd variant
+ * would therefore look like missing content rather than a bad request, and
+ * nobody would ever find it.
+ */
+const VARIANTS = [
+    "default",
+    "new_in_box",
+    "new_in_packet",
+    "pre_owned",
+    "replica",
+];
+/** At most four ancestors on a five-tier tree, so the walk is bounded by shape. */
+const MAX_ANCESTORS = 8;
+function toPublicDefaults(d) {
+    if (!d)
+        return {};
+    /*
+     * An explicit allow-list, not a spread-and-delete. Root Cause #70: a
+     * deny-list keyed on a TypeScript interface is structurally blind to fields
+     * the interface does not declare, and this object gains fields over time.
+     */
+    const out = {};
+    if (d.specifications?.length)
+        out.specifications = d.specifications;
+    if (d.inTheBox?.length)
+        out.inTheBox = d.inTheBox;
+    if (d.defaultCondition)
+        out.defaultCondition = d.defaultCondition;
+    if (d.defaultAuthenticity)
+        out.defaultAuthenticity = d.defaultAuthenticity;
+    if (d.seoKeywords?.length)
+        out.seoKeywords = d.seoKeywords;
+    if (d.faqTemplates?.length)
+        out.faqTemplates = d.faqTemplates;
+    return out;
+}
+function pickTemplate(doc, variant) {
+    const all = doc?.descriptionTemplates;
+    if (!all?.length)
+        return null;
+    /*
+     * The asked-for variant, else the category's `default`, else nothing. NOT
+     * "the first template in the array": a category offering a reproduction
+     * body and a new-in-box body has no natural first, and answering with
+     * whichever the author happened to list first would silently hand a
+     * brand-new listing the reproduction disclosure.
+     */
+    return (all.find((t) => t.variant === variant) ??
+        all.find((t) => t.variant === "default") ??
+        null);
+}
+/**
+ * The `productDefaults` fields the picker can inherit, resolved INDIVIDUALLY.
+ *
+ * 🛑 PER FIELD, not per object, and the first version of this route got it
+ * wrong in exactly the way C2a's `applyCategoryDefaults` was written to avoid.
+ *
+ * A named-model leaf DOES carry a `productDefaults` object — its
+ * `defaultFeatures` (blader, battle type, spin) — while the spec rows and the
+ * in-the-box list live on the tier-3 line above it. Stopping at "the leaf has
+ * an object, so stop looking" therefore returned the blader and silently
+ * dropped the specs, so the picker could never say "this will add 2
+ * specification rows". Caught by a test asserting the picker still gets what
+ * it needs, which the money-stripping assertion sitting beside it would
+ * otherwise have made look fine.
+ */
+const INHERITABLE_DEFAULT_KEYS = [
+    "specifications",
+    "inTheBox",
+    "defaultCondition",
+    "defaultAuthenticity",
+    "seoKeywords",
+    "faqTemplates",
+];
+const isEmptyValue = (v) => v == null || (Array.isArray(v) && v.length === 0);
+/** Fill only the keys still missing, from `src`. Returns what is still absent. */
+function mergeDefaults(into, src) {
+    if (src) {
+        for (const k of INHERITABLE_DEFAULT_KEYS) {
+            if (isEmptyValue(into[k]) && !isEmptyValue(src[k])) {
+                into[k] = src[k];
+            }
+        }
+    }
+    return INHERITABLE_DEFAULT_KEYS.filter((k) => isEmptyValue(into[k]));
+}
+/**
+ * Walk the ancestors nearest-first for whatever the leaf did not supply.
+ *
+ * Extracted because `audit-code-quality` flagged the inline version at
+ * brace-depth 6, and it was right — "for each ancestor, if we still need a
+ * template, if this one has it" is three questions in one block, and the
+ * nesting is what hides the ordering guarantee below.
+ */
+async function resolveInherited(parentIds, variant, seed) {
+    const out = { ...seed };
+    if (parentIds.length === 0)
+        return out;
+    // `parentIds` is root-first/nearest-last, so reverse it. ONE `getAll`: four
+    // sequential reads would be four round trips on a route the seller form hits
+    // on every category change.
+    const nearestFirst = [...parentIds].reverse();
+    const ancestors = await categoriesRepository.findByIds(nearestFirst);
+    /*
+     * 🛑 Re-indexed into the ASKED-FOR order rather than trusted.
+     *
+     * `findByIds` dedupes and drops ids that no longer exist, so its result is
+     * in request order but may be SHORTER — and "nearest ancestor wins" is the
+     * whole semantics here. Walking `nearestFirst` instead of the result means a
+     * missing ancestor cannot silently promote a more distant one to first
+     * place, which would hand a leaf the ROOT's generic body while reporting
+     * that it came from the line.
+     */
+    const byId = new Map(ancestors.map((a) => [a.id, a]));
+    for (const pid of nearestFirst) {
+        const d = byId.get(pid);
+        if (!d)
+            continue;
+        const found = out.template ? null : pickTemplate(d, variant);
+        if (found) {
+            out.template = found;
+            out.inheritedFrom = pid;
+            out.inheritedFromName = d.name ?? null;
+        }
+        // PER FIELD — see INHERITABLE_DEFAULT_KEYS. Stop only once the template is
+        // settled AND no inheritable default is still missing.
+        const stillMissing = mergeDefaults(out.defaults, d.productDefaults);
+        if (out.template && stillMissing.length === 0)
+            break;
+    }
+    return out;
+}
+export async function GET(request, context) {
+    try {
+        const { id } = await context.params;
+        const raw = new URL(request.url).searchParams.get("variant") ?? "default";
+        const variant = VARIANTS.includes(raw)
+            ? raw
+            : "default";
+        const leafDoc = await categoriesRepository.findById(id);
+        if (!leafDoc) {
+            return NextResponse.json({ success: false, error: "Category not found" }, { status: 404 });
+        }
+        const leaf = leafDoc;
+        const parentIds = (leaf.parentIds ?? []).slice(0, MAX_ANCESTORS);
+        /*
+         * The leaf's own defaults are COPIED into the accumulator rather than
+         * referenced, so the per-field merge below cannot mutate the document the
+         * repository cached.
+         */
+        const { template, inheritedFrom, inheritedFromName, defaults } = await resolveInherited(parentIds, variant, {
+            template: pickTemplate(leaf, variant),
+            inheritedFrom: null,
+            inheritedFromName: null,
+            defaults: { ...(leaf.productDefaults ?? {}) },
+        });
+        /*
+         * 🛑 `placeholders` is RE-DERIVED here and not trusted from the stored
+         * template.
+         *
+         * The field's own contract says absent means "re-parse", never "no slots",
+         * and the seeded bodies deliberately leave it unset so there is one
+         * implementation rather than a hand-written list that drifts the first time
+         * a body is edited. The picker needs the real list to report "2 of 9 slots
+         * could not be filled", and a stale list is how a literal `{{series}}`
+         * reaches a published description.
+         */
+        const placeholders = template ? usedPlaceholders(template.body) : [];
+        return NextResponse.json({
+            success: true,
+            data: {
+                template: template
+                    ? { ...template, placeholders }
+                    : null,
+                /** Null when the template came from the category itself. */
+                inheritedFrom,
+                inheritedFromName,
+                defaults: toPublicDefaults(defaults),
+            },
+        }, {
+            headers: {
+                // One hour at the edge. The response is a pure function of
+                // (id, variant) over admin-authored content; an hour of staleness
+                // costs a seller nothing and removes an invocation per form open.
+                "Cache-Control": "public, max-age=3600, s-maxage=3600, stale-while-revalidate=86400",
+            },
+        });
+    }
+    catch (err) {
+        const e = normalizeError(err);
+        serverLogger.error("description-template read failed", { message: e.message });
+        return NextResponse.json({ success: false, error: "Could not load the category template" }, { status: 500 });
+    }
+}

package/dist/features/categories/api/[id]/route.js

@@ -10,10 +10,10 @@
  */
 import { NextResponse } from "next/server.js";
 import { z } from "zod";
-import { mediaUrlSchema } from "../../../../validation/schemas";
-import { getProviders } from "../../../../contracts";
-import { createRouteHandler } from "../../../../next";
-import { normalizeError } from "../../../../errors/normalize";
+import { mediaUrlSchema } from "../../../../validation/schemas.js";
+import { getProviders } from "../../../../contracts/index.js";
+import { createRouteHandler } from "../../../../next/api/routeHandler.js";
+import { normalizeError } from "../../../../errors/normalize.js";
 const ERR_CATEGORY_NOT_FOUND = "Category not found";
 // ---- GET /api/categories/[id] ------------------------------------------------
 export async function GET(_request, context) {

package/dist/features/categories/api/route.js

@@ -14,10 +14,14 @@
  */
 import { NextResponse } from "next/server.js";
 import { z } from "zod";
-import { mediaUrlSchema } from "../../../validation/schemas";
-import { getProviders } from "../../../contracts";
-import { createRouteHandler } from "../../../next";
-import { normalizeError } from "../../../errors/normalize";
+import { mediaUrlSchema } from "../../../validation/schemas.js";
+import { getProviders } from "../../../contracts/index.js";
+import { createRouteHandler } from "../../../next/api/routeHandler.js";
+import { toCategoryListItem } from "../../../_internal/server/features/categories/adapters.js";
+import { isListingCategory } from "../constants/listing-categories.js";
+import { planSearchTxt } from "../../../utils/search-txt-query.js";
+import { matchesAllSearchTerms } from "../../../utils/search-txt.js";
+import { normalizeError } from "../../../errors/normalize.js";
 const CACHE_CONTROL_PUBLIC = "public, max-age=3600, s-maxage=3600, stale-while-revalidate=86400";
 function buildTreeFromFlat(items, rootId) {
     const byId = new Map(items.map((i) => [i.id, i]));
@@ -77,10 +81,65 @@ export async function GET(request) {
         const rawFilters = param(url, "filters");
         const tier = numParam(url, "tier");
         const pageSizeParam = numParam(url, "pageSize");
+        /*
+         * 🛑 `?page=` MEANS "give me a paged flat list", and reading it fixes two
+         * live bugs rather than adding a feature.
+         *
+         * (a) `useAdminListingData` ALWAYS sends `page` and `pageSize`, so
+         *     `/admin/categories` has been requesting `?flat=true&page=N` while
+         *     this handler ignored `page` entirely — the pager advanced the URL
+         *     and returned page 1's rows every time. It also returned a bare
+         *     array with no `total`, so `extractCategoryTotal` fell back to
+         *     `mappedRows.length`, making `totalPages` 1 and disabling Next. The
+         *     list showed 50 of 58 categories with no way to reach the rest.
+         *
+         * (b) `loadOptionsFrom` (the catalogue editor's category and brand
+         *     pickers) sends ONLY `page`/`pageSize`/`q` — none of which `isFiltered`
+         *     tested — so it fell through to TREE mode and then read `.items` off
+         *     a bare array of nested nodes. `data.items ?? []` meant both pickers
+         *     were permanently empty. Same shape as the `useCategoryTree` bug:
+         *     `isFiltered` did not include the params real callers send.
+         */
+        const pageParam = numParam(url, "page");
+        const isPaged = pageParam !== null && pageParam > 0;
+        /*
+         * `?listingOnly=true` drops brand / bundle / sublisting rows.
+         *
+         * Applied in memory because the test cannot be a query clause — a plain
+         * listing category OMITS `categoryType`, so there is no value to match
+         * and an inequality would exclude every real category. See
+         * `constants/listing-categories.ts`.
+         *
+         * Server-side rather than per-caller: three surfaces had hand-written the
+         * same Set and the fourth (`loadCategoryOptions`, the catalogue editor's
+         * category picker) shipped without one, offering "Takara-Tomy" and
+         * "Original Collector's Set" as categories.
+         */
+        const listingOnly = param(url, "listingOnly") === "true";
+        /*
+         * `q` is read now that `searchTxt` exists.
+         *
+         * `loadOptionsFrom` has always sent it and this handler never read it, so
+         * the catalogue editor's category picker returned the same unfiltered page
+         * for every term — the search box accepted typing and changed nothing.
+         * Root Cause #62's shape, and the second half of why that picker was
+         * useless (the first being that it got a nested tree, §A1c).
+         */
+        const q = (param(url, "q") ?? "").trim();
         const { db } = getProviders();
         if (!db) {
             return NextResponse.json({ success: false, error: "Database provider not registered" }, { status: 503 });
         }
+        /*
+         * 🛑 Typed as the DOCUMENT, not as `CategoryItem`.
+         *
+         * This was `getRepository<CategoryItem>`, which is a cast-by-generic: the
+         * repository returns raw Firestore documents at runtime, so every return
+         * site below was handing out `createdBy`, `createdByStoreId` and the
+         * unbounded `metrics.productIds[]`/`auctionIds[]` while tsc believed the
+         * payload was already projected. Naming the real shape is what makes the
+         * missing `toCategoryListItem` calls a compile error instead of a leak.
+         */
         const repo = db.getRepository("categories");
         // -- Single slug lookup ----------------------------------------------------
         if (slug) {
@@ -92,7 +151,7 @@ export async function GET(request) {
             if (!category) {
                 return NextResponse.json({ success: false, error: "Category not found" }, { status: 404 });
             }
-            return NextResponse.json({ success: true, data: category });
+            return NextResponse.json({ success: true, data: toCategoryListItem(category) });
         }
         // -- Build Sieve filter string from query params ----------------------------
         const parts = [];
@@ -117,6 +176,7 @@ export async function GET(request) {
         // -- Filtered flat list modes -----------------------------------------------
         // If any filter is active, or ?flat=true → return flat array
         const isFiltered = flat === "true" ||
+            isPaged ||
             parentId !== null ||
             featured === "true" ||
             isBrand === "true" ||
@@ -125,14 +185,95 @@ export async function GET(request) {
             type !== null;
         if (isFiltered) {
             const perPage = pageSizeParam !== null && pageSizeParam > 0 ? pageSizeParam : 200;
-            const result = await repo.findAll({
-                filters,
-                sort: "order",
-                order: "asc",
-                perPage,
-            });
-            const items = result.data.sort((a, b) => (a.order ?? 0) - (b.order ?? 0));
-            const res = NextResponse.json({ success: true, data: items });
+            const page = pageParam ?? 1;
+            /*
+             * 🛑 `listingOnly` and `q` both force an in-memory window, and `total`
+             * is the reason.
+             *
+             * Each removes rows AFTER the query, so the repository's own `total`
+             * would be an over-count and `hasMore` would promise a "Load more" page
+             * that renders empty. Rather than ship a number that is wrong in a
+             * direction nobody can see, fetch one bounded window, filter it, and
+             * paginate the result — so `total` is exact.
+             *
+             * Affordable because this collection is small and hard-capped at 500 by
+             * `base.ts` anyway: 58 rows today, ~330 after the taxonomy seed. Past
+             * the cap the window truncates, which is the same ceiling the sitemap
+             * builder has and is tracked as its own item — it is not made worse
+             * here.
+             *
+             * The MATCH uses `matchesAllSearchTerms` over the stored `searchTxt`,
+             * not `name.includes()`, so this route and the admin route's real
+             * push-down agree on what a term means: word prefixes, accent-folded,
+             * all terms ANDed, lineage included via `ancestors[].name`. Two
+             * different notions of "matches" across two pickers over one collection
+             * is the drift this reuse avoids.
+             */
+            const plan = planSearchTxt(q);
+            // A query that normalised to no usable token must return NOTHING.
+            // Emitting no clause returns the whole collection and calls it a result.
+            if (plan.empty) {
+                const res = isPaged
+                    ? NextResponse.json({
+                        success: true,
+                        data: { items: [], total: 0, page, perPage, totalPages: 0, hasMore: false },
+                    })
+                    : NextResponse.json({ success: true, data: [] });
+                res.headers.set("Cache-Control", CACHE_CONTROL_PUBLIC);
+                return res;
+            }
+            const terms = plan.head ? [plan.head, ...plan.rest] : [];
+            const needsWindow = listingOnly || terms.length > 0;
+            const windowed = needsWindow
+                ? await repo.findAll({ filters, sort: "order", order: "asc", perPage: 500 })
+                : null;
+            let items;
+            let total;
+            if (windowed) {
+                const kept = windowed.data
+                    .filter((d) => (listingOnly ? isListingCategory(d) : true))
+                    .filter((d) => (terms.length ? matchesAllSearchTerms(d.searchTxt, terms) : true))
+                    .sort((a, b) => (a.order ?? 0) - (b.order ?? 0));
+                total = kept.length;
+                const offset = (page - 1) * perPage;
+                items = (isPaged ? kept.slice(offset, offset + perPage) : kept).map(toCategoryListItem);
+            }
+            else {
+                const result = await repo.findAll({
+                    filters,
+                    sort: "order",
+                    order: "asc",
+                    page: pageParam ?? undefined,
+                    perPage,
+                });
+                total = result.total;
+                items = result.data
+                    .sort((a, b) => (a.order ?? 0) - (b.order ?? 0))
+                    .map(toCategoryListItem);
+            }
+            const totalPages = total === 0 ? 0 : Math.max(1, Math.ceil(total / perPage));
+            /*
+             * Shape switches on `?page=`, deliberately, and only there.
+             *
+             * A paged caller gets an envelope carrying `total`/`totalPages`/`hasMore`
+             * — without `total` the admin pager computes `totalPages = 1` from the
+             * row count and disables Next, which is the "50 of 58 rows" bug. A
+             * caller that sends no `page` keeps the bare array it has always had,
+             * because `useCategories` and `useTopCategories` are TYPED as
+             * `CategoryItem[]` and would throw on `.map` of an object (Root Cause
+             * #20 — a public shape change must update its call sites, and these
+             * callers never ask for paging, so the correct move is not to change
+             * their shape at all).
+             *
+             * `hasMore` exists because `loadOptionsFrom` reads it for "Load more";
+             * it used to read it off a bare array and always got `false`.
+             */
+            const res = isPaged
+                ? NextResponse.json({
+                    success: true,
+                    data: { items, total, page, perPage, totalPages, hasMore: page < totalPages },
+                })
+                : NextResponse.json({ success: true, data: items });
             res.headers.set("Cache-Control", CACHE_CONTROL_PUBLIC);
             return res;
         }
@@ -143,8 +284,12 @@ export async function GET(request) {
             order: "asc",
             perPage: 500,
         });
+        // Project BEFORE nesting — `CategoryTreeNode extends CategoryItem`, so the
+        // children carry the public shape too rather than being raw documents
+        // reachable one level down.
+        const allItems = allResult.data.map(toCategoryListItem);
         if (tree === "true" || !flat) {
-            const treeNodes = buildTreeFromFlat(allResult.data, rootId);
+            const treeNodes = buildTreeFromFlat(allItems, rootId);
             const res = NextResponse.json({ success: true, data: treeNodes });
             res.headers.set("Cache-Control", CACHE_CONTROL_PUBLIC);
             return res;
@@ -153,7 +298,7 @@ export async function GET(request) {
         // because isFiltered catches it, but kept for clarity)
         const res = NextResponse.json({
             success: true,
-            data: allResult.data.sort((a, b) => (a.order ?? 0) - (b.order ?? 0)),
+            data: allItems.sort((a, b) => (a.order ?? 0) - (b.order ?? 0)),
         });
         res.headers.set("Cache-Control", CACHE_CONTROL_PUBLIC);
         return res;

package/dist/features/categories/columns/index.js

@@ -1,4 +1,4 @@
-import { buildColumns, renderBoolean, renderNullable, } from "../../../ui/columns";
+import { buildColumns, renderBoolean, renderNullable, } from "../../../ui/columns/index.js";
 /**
  * Default admin column definitions for a category table.
  *

package/dist/features/categories/components/BrandDetailPageView.js

@@ -1,23 +1,24 @@
 import { jsx as _jsx, Fragment as _Fragment, jsxs as _jsxs } from "react/jsx-runtime";
 import { Row, SIEVE_OP, sieveAnd, sieveFilter } from "@mohasinac/appkit";
 import { sortBy } from "@mohasinac/appkit";
-import Link from "next/link";
-import { categoriesRepository, productRepository, } from "../../../repositories";
-import { ROUTES } from "../../../next";
-import { Anchor, Container, Div, Dl, Dt, Dd, Heading, Main, Nav, Section, Span, Stack, Text } from "../../../ui";
-import { DynamicBgDiv } from "../../../ui/components/DynamicBgDiv";
-import { MediaImage } from "../../media/MediaImage";
-import { BrandDetailTabs } from "./BrandDetailTabs";
-import { CategoryGrid } from "./CategoryGrid";
-import { CategoryHighlightsAndFaqSection } from "./CategoryHighlightsAndFaqSection";
-import { GroupedListingsCarousel } from "../../grouped/components/GroupedListingsCarousel";
-import { getGroupsForBrand } from "../../../_internal/server/features/grouped/data";
-import { listingTabCounts, } from "../../../_internal/server/features/products/listing-tab-counts";
-import { CATEGORY_PAGE_TABS } from "../../products/constants/listing-tabs";
-import { enabledCategoryTypes, enabledListingTypes } from "../../../_internal/shared/listing-types/feature-flags";
-import { siteSettingsRepository } from "../../../repositories";
-import { safeRead } from "../../../errors/safe-read";
-import { hidePublicTestData } from "../../../_internal/server/features/tester/visibility";
+import Link from "next/link.js";
+import { categoriesRepository, productRepository, } from "../../../repositories/index.js";
+import { ROUTES } from "../../../next/routing/route-map.js";
+import { Anchor, Container, Div, Dl, Dt, Dd, Heading, Main, Nav, Section, Span, Stack, Text } from "../../../ui/index.js";
+import { DynamicBgDiv } from "../../../ui/components/DynamicBgDiv.js";
+import { MediaImage } from "../../media/MediaImage.js";
+import { BrandDetailTabs } from "./BrandDetailTabs.js";
+import { CategoryGrid } from "./CategoryGrid.js";
+import { CategoryHighlightsAndFaqSection } from "./CategoryHighlightsAndFaqSection.js";
+import { breadcrumbJsonLd, collectionPageJsonLd, faqJsonLd, } from "../../../seo/json-ld.js";
+import { GroupedListingsCarousel } from "../../grouped/components/GroupedListingsCarousel.js";
+import { getGroupsForBrand } from "../../../_internal/server/features/grouped/data.js";
+import { listingTabCounts, } from "../../../_internal/server/features/products/listing-tab-counts.js";
+import { CATEGORY_PAGE_TABS } from "../../products/constants/listing-tabs.js";
+import { enabledCategoryTypes, enabledListingTypes } from "../../../_internal/shared/listing-types/feature-flags.js";
+import { siteSettingsRepository } from "../../../repositories/index.js";
+import { safeRead } from "../../../errors/safe-read.js";
+import { hidePublicTestData } from "../../../_internal/server/features/tester/visibility.js";
 const __O = {
     hidden: "overflow-hidden",
 };
@@ -99,5 +100,46 @@ export async function BrandDetailPageView({ slug, initialBrand }) {
     // Header total — `?? 0` is right here (a pill just doesn't render), unlike the
     // tab bar where an unknown count must keep its tab visible.
     const totalItems = Object.values(counts).reduce((sum, n) => sum + (n ?? 0), 0);
-    return (_jsxs(Main, { children: [_jsxs(Section, { className: `relative ${__O.hidden} ${hasCover ? "min-h-[220px] md:min-h-[280px]" : "bg-[var(--appkit-color-bg)]"}`, children: [hasCover && (_jsxs(_Fragment, { children: [_jsx(Div, { className: "absolute inset-0", children: _jsx(MediaImage, { src: coverImage, alt: "", size: "banner" }) }), _jsx(Div, { surface: "overlay-md", className: "absolute inset-0" })] })), !hasCover && (_jsx(DynamicBgDiv, { color: brandColor, className: "absolute inset-0 opacity-10" })), _jsxs(Div, { className: "relative z-10 max-w-7xl mx-auto", paddingY: hasCover ? "y-3xl" : "y-xl", padding: "x-md", children: [_jsxs(Nav, { layout: "flex", gap: "2xs", textSize: "sm", className: "mb-4", "aria-label": "Breadcrumb", children: [_jsx(Link, { href: String(ROUTES.HOME), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 transition-colors", children: "Home" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Link, { href: String(ROUTES.PUBLIC.BRANDS), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 transition-colors", children: "Brands" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Span, { weight: "medium", className: hasCover ? "text-white" : "text-[var(--appkit-color-text)]", children: brand?.name ?? slug })] }), _jsxs(Row, { className: "mb-3", align: "center", gap: "md", children: [brand?.display?.icon && (_jsx(Span, { className: "leading-none", size: "5xl", children: brand.display.icon })), _jsxs(_Fragment, { children: [_jsx(Heading, { color: "inverse", level: 1, className: `${hasCover ? "" : "text-[var(--appkit-color-text)]"}`, size: "3xl", mdSize: "4xl", weight: "bold", children: brand?.name ?? slug }), brand?.description && typeof brand.description === "string" && !brand.description.startsWith("{") && (_jsx(Text, { color: hasCover ? "inverse" : "muted", className: `max-w-2xl mt-1 ${hasCover ? "/80" : ""}`, size: "base", children: brand.description }))] })] }), _jsxs(Row, { gap: "sm", wrap: true, className: "mt-3", children: [(counts.products ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: "inverse", size: "xs", weight: "medium", className: `${hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "bg-primary/10 text-primary-700 dark:text-primary-400"}`, rounded: "full", padding: "pill-sm-tall", children: [counts.products.toLocaleString(), " ", counts.products === 1 ? "product" : "products"] })), (counts.auctions ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "warning", surface: hasCover ? undefined : "warning-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts.auctions.toLocaleString(), " ", counts.auctions === 1 ? "auction" : "auctions"] })), (counts["pre-orders"] ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "info", surface: hasCover ? undefined : "info-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts["pre-orders"].toLocaleString(), " ", counts["pre-orders"] === 1 ? "pre-order" : "pre-orders"] })), totalItems === 0 && (_jsx(Span, { size: "sm", className: hasCover ? "text-white/60" : "text-zinc-400", children: "No items listed yet" }))] })] })] }), (brand?.brandWebsite || brand?.brandCountry || brand?.brandFounded) && (_jsx(Section, { border: "subtle", surface: "default", className: "border-b", padding: "y-md", children: _jsx(Container, { size: "xl", children: _jsxs(Stack, { gap: "sm", children: [_jsx(Heading, { level: 2, size: "sm", weight: "semibold", color: "muted", transform: "uppercase", children: "About this brand" }), _jsxs(Dl, { divide: "subtle", rounded: "xl", border: "subtle", className: "overflow-hidden max-w-lg", children: [brand?.brandWebsite && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Website" }), _jsx(Dd, { className: "flex-1", children: _jsx(Anchor, { href: brand.brandWebsite, tone: "brand", underline: "hover", children: brand.brandWebsite }) })] })), brand?.brandCountry && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Country" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandCountry })] })), brand?.brandFounded && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Founded" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandFounded })] }))] })] }) }) })), _jsx(CategoryHighlightsAndFaqSection, { highlights: brand?.highlights, faqs: brand?.faqs }), _jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: brandName ? (_jsx(BrandDetailTabs, { brandName: brandName, initialProductsData: productsResult ?? undefined, initialBundles: brandBundles, counts: counts, enabledListingTypes: enabledListingTypes(settings), enabledCategoryTypes: enabledCategoryTypes(settings) })) : (_jsx(Text, { paddingY: "3xl", color: "muted", size: "sm", align: "start", children: "Brand not found." })) }) }), groupedListings.length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(GroupedListingsCarousel, { groups: groupedListings }) }) })), relatedBrands.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-t", padding: "y-lg", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 2, className: "mb-4", size: "xl", weight: "semibold", children: "Related Brands" }), _jsx(CategoryGrid, { categories: relatedBrands, getHref: (b) => String(ROUTES.PUBLIC.BRAND_DETAIL(b.slug)) })] }) }))] }));
+    /*
+     * ── D4: structured data on the brand page ───────────────────────────────
+     *
+     * Same gap as the category page and the same fix — verified: zero `JsonLd`
+     * references in this file before this change. §5 item 4 asks for exactly
+     * this trio here, and notes the `revalidate` half was already banked by
+     * `7d9dcf7c7` (this route is 3600 now), so the JSON-LD was all that remained.
+     *
+     * 🛑 `CollectionPage`, NOT `Brand`. A `Brand` node describes the brand as an
+     * entity; this page is a LISTING of that brand's items, and the markup should
+     * say what the page IS. The brand's own identity facts (website, country,
+     * founded) are rendered in the About panel for a human — turning them into a
+     * `Brand` node is a separate decision with its own rich-result implications,
+     * and claiming one without being the brand's own site invites a wrong one.
+     *
+     * Costs no extra read: `brand`, `counts` and `faqs` are already in hand.
+     */
+    const brandPath = String(ROUTES.PUBLIC.BRAND_DETAIL(slug));
+    const ldBreadcrumb = breadcrumbJsonLd([
+        { name: "Home", url: "/" },
+        { name: "Brands", url: String(ROUTES.PUBLIC.BRANDS) },
+        { name: brand?.name ?? "Brand", url: brandPath },
+    ]);
+    /*
+     * 🛑 No `items`, deliberately. A brand page's contents are the brand's
+     * PRODUCTS, and an `ItemList` of products without prices is the weaker half
+     * of a node whose useful form is blocked here (`audit-guest-price-leak` R3,
+     * because the page shows a signed-out crawler no prices at all). The
+     * category page lists child CATEGORIES because taxonomy routing is its real
+     * contribution; a brand has no sub-brands, so there is nothing equivalent to
+     * list. `totalItems` still states the scale, which is the part worth saying.
+     */
+    const ldCollection = collectionPageJsonLd({
+        name: brand?.name ?? "Brand",
+        url: brandPath,
+        ...(brand?.description ? { description: brand.description } : {}),
+        totalItems,
+    });
+    const ldFaq = brand?.faqs && brand.faqs.length > 0
+        ? faqJsonLd(brand.faqs.map((f) => ({ question: f.question, answer: f.answer })))
+        : null;
+    return (_jsxs(Main, { children: [_jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldBreadcrumb) } }), _jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldCollection) } }), ldFaq && (_jsx("script", { type: "application/ld+json", dangerouslySetInnerHTML: { __html: JSON.stringify(ldFaq) } })), _jsxs(Section, { className: `relative ${__O.hidden} ${hasCover ? "min-h-[220px] md:min-h-[280px]" : "bg-[var(--appkit-color-bg)]"}`, children: [hasCover && (_jsxs(_Fragment, { children: [_jsx(Div, { className: "absolute inset-0", children: _jsx(MediaImage, { src: coverImage, alt: "", size: "banner" }) }), _jsx(Div, { surface: "overlay-md", className: "absolute inset-0" })] })), !hasCover && (_jsx(DynamicBgDiv, { color: brandColor, className: "absolute inset-0 opacity-10" })), _jsxs(Div, { className: "relative z-10 max-w-7xl mx-auto", paddingY: hasCover ? "y-3xl" : "y-xl", padding: "x-md", children: [_jsxs(Nav, { layout: "flex", gap: "2xs", textSize: "sm", className: "mb-4", "aria-label": "Breadcrumb", children: [_jsx(Link, { href: String(ROUTES.HOME), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 transition-colors", children: "Home" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Link, { href: String(ROUTES.PUBLIC.BRANDS), className: hasCover ? "text-white/70 hover:text-white transition-colors" : "text-[var(--appkit-color-text-muted)] hover:text-primary-600 transition-colors", children: "Brands" }), _jsx(Span, { className: hasCover ? "text-white/40" : "text-zinc-400", children: "/" }), _jsx(Span, { weight: "medium", className: hasCover ? "text-white" : "text-[var(--appkit-color-text)]", children: brand?.name ?? slug })] }), _jsxs(Row, { className: "mb-3", align: "center", gap: "md", children: [brand?.display?.icon && (_jsx(Span, { className: "leading-none", size: "5xl", children: brand.display.icon })), _jsxs(_Fragment, { children: [_jsx(Heading, { color: "inverse", level: 1, className: `${hasCover ? "" : "text-[var(--appkit-color-text)]"}`, size: "3xl", mdSize: "4xl", weight: "bold", children: brand?.name ?? slug }), brand?.description && typeof brand.description === "string" && !brand.description.startsWith("{") && (_jsx(Text, { color: hasCover ? "inverse" : "muted", className: `max-w-2xl mt-1 ${hasCover ? "/80" : ""}`, size: "base", children: brand.description }))] })] }), _jsxs(Row, { gap: "sm", wrap: true, className: "mt-3", children: [(counts.products ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: "inverse", size: "xs", weight: "medium", className: `${hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "bg-primary/10 text-primary-700 dark:text-primary-400"}`, rounded: "full", padding: "pill-sm-tall", children: [counts.products.toLocaleString(), " ", counts.products === 1 ? "product" : "products"] })), (counts.auctions ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "warning", surface: hasCover ? undefined : "warning-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts.auctions.toLocaleString(), " ", counts.auctions === 1 ? "auction" : "auctions"] })), (counts["pre-orders"] ?? 0) > 0 && (_jsxs(Span, { layout: "inline-flex", gap: "xs", color: hasCover ? "inverse" : "info", surface: hasCover ? undefined : "info-surface", size: "xs", weight: "medium", className: hasCover ? "bg-[rgba(255,255,255,0.2)] backdrop-blur-sm" : "", rounded: "full", padding: "pill-sm-tall", children: [counts["pre-orders"].toLocaleString(), " ", counts["pre-orders"] === 1 ? "pre-order" : "pre-orders"] })), totalItems === 0 && (_jsx(Span, { size: "sm", className: hasCover ? "text-white/60" : "text-zinc-400", children: "No items listed yet" }))] })] })] }), (brand?.brandWebsite || brand?.brandCountry || brand?.brandFounded) && (_jsx(Section, { border: "subtle", surface: "default", className: "border-b", padding: "y-md", children: _jsx(Container, { size: "xl", children: _jsxs(Stack, { gap: "sm", children: [_jsx(Heading, { level: 2, size: "sm", weight: "semibold", color: "muted", transform: "uppercase", children: "About this brand" }), _jsxs(Dl, { divide: "subtle", rounded: "xl", border: "subtle", className: "overflow-hidden max-w-lg", children: [brand?.brandWebsite && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Website" }), _jsx(Dd, { className: "flex-1", children: _jsx(Anchor, { href: brand.brandWebsite, tone: "brand", underline: "hover", children: brand.brandWebsite }) })] })), brand?.brandCountry && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Country" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandCountry })] })), brand?.brandFounded && (_jsxs(Row, { gap: "md", oddEven: "zebra", surface: "default", padding: "inline", children: [_jsx(Dt, { className: "w-32 flex-shrink-0", color: "primary", weight: "medium", children: "Founded" }), _jsx(Dd, { className: "flex-1", color: "muted", children: brand.brandFounded })] }))] })] }) }) })), _jsx(CategoryHighlightsAndFaqSection, { highlights: brand?.highlights, faqs: brand?.faqs }), _jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: brandName ? (_jsx(BrandDetailTabs, { brandName: brandName, initialProductsData: productsResult ?? undefined, initialBundles: brandBundles, counts: counts, enabledListingTypes: enabledListingTypes(settings), enabledCategoryTypes: enabledCategoryTypes(settings) })) : (_jsx(Text, { paddingY: "3xl", color: "muted", size: "sm", align: "start", children: "Brand not found." })) }) }), groupedListings.length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(GroupedListingsCarousel, { groups: groupedListings }) }) })), relatedBrands.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-t", padding: "y-lg", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 2, className: "mb-4", size: "xl", weight: "semibold", children: "Related Brands" }), _jsx(CategoryGrid, { categories: relatedBrands, getHref: (b) => String(ROUTES.PUBLIC.BRAND_DETAIL(b.slug)) })] }) }))] }));
 }