@mohasinac/appkit 4.43.0 → 4.45.0

package/dist/_internal/server/features/checkout/actions.js

@@ -1,6 +1,6 @@
-import { normalizeError } from "../../../../errors/normalize";
-import { buildOrderSourceContext } from "./source-context";
-import { roundRupees } from "../../../../utils/number.formatter";
+import { normalizeError } from "../../../../errors/normalize.js";
+import { buildOrderSourceContext } from "./source-context.js";
+import { roundRupees } from "../../../../utils/number.formatter.js";
 /**
  * Checkout server actions (appkit).
  *
@@ -9,39 +9,42 @@ import { roundRupees } from "../../../../utils/number.formatter";
  * directly. The consumer is responsible for auth/rate-limit/Next-specific
  * concerns; the action only does transactional order placement.
  */
-import { ApiError, ValidationError, NotFoundError, ERROR_MESSAGES } from "../../../../errors";
-import { ORDER_FIELDS } from "../../../../constants/field-names";
-import { serverLogger } from "../../../../monitoring";
-import { unitOfWork, adminNotificationsRepository, siteSettingsRepository, userRepository, storeRepository, couponsRepository, claimedCouponsRepository, addressesRepository, productRepository, } from "../../../../repositories";
-import { computePreOrderDepositAmount, lineTotalFor, sumGroupGst, unitPriceFor, } from "../../../shared/checkout/order-math";
-import { failedCheckoutRepository } from "../../../../features/checkout/repository/failed-checkout.repository";
-import { sendOrderConfirmationEmail } from "../../../../features/contact/server";
-import { splitCartIntoOrderGroups } from "../../../../features/orders/index";
-import { resolveCouponCategorySlugs } from "../../../../features/promotions/actions/coupon-actions";
-import { assertCheckoutLane, assertLockedLinesStillValid, finalizeLockedLines, } from "./locked-lines";
-import { activeLane, defaultCheckoutItems, laneOf, } from "../../../shared/checkout/lanes";
-import { computeCodHandlingFee, computeWhatsAppNotifyFee, computeGiftWrapFee, computeShipmentProtectionFee, computeCheckoutFees, allocateCheckoutFees, } from "../../../shared/fees/calculator";
-import { getAdminDb, getAdminRealtimeDb, RTDB_PATHS, } from "../../../../providers/db-firebase";
-import { PRODUCT_COLLECTION, PRODUCT_CODES_SUBCOLLECTION } from "../../../../features/products/schemas/firestore";
-import { CART_COLLECTION } from "../../../../features/cart/schemas/index";
+import { ApiError, ValidationError, NotFoundError, ERROR_MESSAGES } from "../../../../errors/index.js";
+import { ORDER_FIELDS } from "../../../../constants/field-names.js";
+import { serverLogger } from "../../../../monitoring/index.js";
+import { unitOfWork, adminNotificationsRepository, siteSettingsRepository, userRepository, storeRepository, couponsRepository, claimedCouponsRepository, addressesRepository, productRepository, } from "../../../../repositories/index.js";
+import { isIntraStateSupply } from "../../../shared/fees/calculator.js";
+import { computePreOrderDepositAmount, lineTotalFor, sumGroupGst, unitPriceFor, } from "../../../shared/checkout/order-math.js";
+import { failedCheckoutRepository } from "../../../../features/checkout/repository/failed-checkout.repository.js";
+import { sendOrderConfirmationEmail } from "../../../../features/contact/server.js";
+import { splitCartIntoOrderGroups } from "../../../../features/orders/index.js";
+import { DEFAULT_STORE_SHIPPING_POLICY, quoteShipping, toStoreShippingPolicy, } from "../../../shared/features/shipping/mode.js";
+import { computeProtectionFees } from "../../../shared/features/shipping/protections.js";
+import { resolveCouponCategorySlugs } from "../../../../features/promotions/actions/coupon-actions.js";
+import { assertCheckoutLane, assertLockedLinesStillValid, finalizeLockedLines, } from "./locked-lines.js";
+import { activeLane, defaultCheckoutItems, laneOf, } from "../../../shared/checkout/lanes.js";
+import { computeCodHandlingFee, computeWhatsAppNotifyFee, computeGiftWrapFee, computeShipmentProtectionFee, computeSaleProtectionFee, computeCheckoutFees, allocateCheckoutFees, } from "../../../shared/fees/calculator.js";
+import { getAdminDb, getAdminRealtimeDb, RTDB_PATHS, } from "../../../../providers/db-firebase/index.js";
+import { PRODUCT_COLLECTION, PRODUCT_CODES_SUBCOLLECTION } from "../../../../features/products/schemas/firestore.js";
+import { CART_COLLECTION } from "../../../../features/cart/schemas/index.js";
 // S-SBUNI-RULES 2026-05-13 — bundle cart-line stock fan-out helpers.
-import { getCartItemMemberIds, getExpandedDecrements, bucketCartItemsByStock, isMultiMemberLine, } from "./bundle-expansion";
-import { expandCartLineToOrderRows } from "./expand-order-items";
-import { OrderStatusValues, PaymentStatusValues, PaymentMethodValues, OutOfStockPolicyValues, } from "../../../../features/orders/schemas/index";
-import { getDefaultCurrency } from "../../../../core/index";
-import { getProviders } from "../../../../contracts";
-import { paiseToRupees } from "../../../../core/money";
-import { CHECKOUT_DEFAULT_COMMISSIONS, CHECKOUT_DEFAULT_EMI_SETTINGS } from "../../../shared/features/checkout/config";
-import { checkEmiEligibility, computeEmiSchedule } from "../../../shared/features/emi/schedule";
-import { formatShippingAddress } from "./data";
-import { enforceMaxPerUserForCart } from "./prize-bundle-gates";
-import { getListingRule, runSyncPreflight, } from "../../../shared/checkout/rules";
-import { cartIsDigitalOnly } from "../../../shared/listing-types/cart-shipping";
-import { processRefundAction } from "../refunds/actions";
-import { sendNotification } from "../../../../features/admin/actions/notification-actions";
-import { resolveDisplayedUpiId } from "./upi-resolution";
-import { PAYMENT_WINDOW_MS } from "../../../../features/orders/constants/payment-window";
-import { isCheckoutValueOtpVerified } from "../../../../features/checkout/actions/checkout-value-otp-actions";
+import { getCartItemMemberIds, getExpandedDecrements, bucketCartItemsByStock, isMultiMemberLine, } from "./bundle-expansion.js";
+import { expandCartLineToOrderRows } from "./expand-order-items.js";
+import { OrderStatusValues, PaymentStatusValues, PaymentMethodValues, OutOfStockPolicyValues, } from "../../../../features/orders/schemas/index.js";
+import { getDefaultCurrency } from "../../../../core/index.js";
+import { getProviders } from "../../../../contracts/index.js";
+import { paiseToRupees } from "../../../../core/money.js";
+import { CHECKOUT_DEFAULT_COMMISSIONS, CHECKOUT_DEFAULT_EMI_SETTINGS } from "../../../shared/features/checkout/config.js";
+import { checkEmiEligibility, computeEmiSchedule } from "../../../shared/features/emi/schedule.js";
+import { formatShippingAddress } from "./data.js";
+import { enforceMaxPerUserForCart } from "./prize-bundle-gates.js";
+import { getListingRule, runSyncPreflight, } from "../../../shared/checkout/rules/index.js";
+import { cartIsDigitalOnly } from "../../../shared/listing-types/cart-shipping.js";
+import { processRefundAction } from "../refunds/actions.js";
+import { sendNotification } from "../../../../features/admin/actions/notification-actions.js";
+import { resolveDisplayedUpiId } from "./upi-resolution.js";
+import { PAYMENT_WINDOW_MS } from "../../../../features/orders/constants/payment-window.js";
+import { isCheckoutValueOtpVerified } from "../../../../features/checkout/actions/checkout-value-otp-actions.js";
 const AUDIT_LOG_FAIL_MSG = "checkout: audit log failed (non-critical)";
 /**
  * SB-UNI-N — Atomically claim the next available digital code for a confirmed
@@ -86,14 +89,14 @@ async function claimDigitalCodeForOrder(db, productId, orderId, userId, opts) {
          * Deliberately awaited but non-fatal inside: a failed recount must not undo
          * a claim the buyer has already paid for.
          */
-        const { recountPool } = await import("../digital-code/pool");
+        const { recountPool } = await import("../digital-code/pool.js");
         await recountPool(productId).catch((e) => serverLogger.error("claimDigitalCode: recount failed", {
             error: normalizeError(e).message,
             productId,
         }));
     }
     if (claimed && opts?.userEmail) {
-        const { sendDigitalCodeClaimedEmail } = await import("../../../../features/contact/server");
+        const { sendDigitalCodeClaimedEmail } = await import("../../../../features/contact/server.js");
         sendDigitalCodeClaimedEmail({
             to: opts.userEmail,
             userName: opts.userName ?? "there",
@@ -181,19 +184,87 @@ function accumulateCouponUsage(accumulator, couponCode, couponId, discountAmount
  * a single source of truth instead of a third re-implementation.
  */
 export async function resolveShippingCost(storeId) {
-    if (!storeId)
-        return { shippingFee: 0, storeOwnerId: undefined, storeEmiEnabled: false, storeState: undefined };
+    if (!storeId) {
+        return {
+            shippingFee: 0,
+            storeOwnerId: undefined,
+            storeEmiEnabled: false,
+            storeState: undefined,
+            shippingPolicy: DEFAULT_STORE_SHIPPING_POLICY,
+            shippingUnavailable: false,
+            storeProtections: { shipping: false, sale: false },
+        };
+    }
     const store = await storeRepository.findById(storeId);
     const storeOwnerId = store?.ownerId;
     const storeEmiEnabled = store?.emiEnabled === true;
     const storeState = await resolveStoreState(storeId);
+    /*
+     * ── C5b: the store's shipping MODE, not a flat number ──────────────────
+     *
+     * This read `sellerUser.shippingConfig.customShippingPrice ?? 0` — one flat
+     * rupee figure off the store OWNER's user document, with no weight,
+     * destination, pincode or courier in it. Meanwhile `ShippingConfigDocument`
+     * (zones, per-kg rates, free-above, express surcharge, full CRUD, seed data)
+     * was read by NO money path at all, so there were two shipping-config
+     * systems and the authoritative one was the flat number by accident.
+     *
+     * 🛑 The policy lives on the STORE, because shipping is charged per store
+     * and `splitCartIntoOrderGroups` groups on `storeId` — a user who owns two
+     * stores would otherwise price both the same, which is Root Cause #65's
+     * granularity mismatch.
+     *
+     * 🛑 The LEGACY flat number is still honoured as a `flat` mode when a store
+     * has no policy of its own. Not for compatibility's sake — for correctness:
+     * a seller who set ₹100 on the old surface and has not seen the new one must
+     * keep charging ₹100, not silently drop to free. Migration is a seller
+     * visiting their settings, not a reseed.
+     */
+    const policy = store?.shippingPricing
+        ? toStoreShippingPolicy(store.shippingPricing)
+        : await legacyFlatPolicy(storeOwnerId);
+    /*
+     * 🛑 `goodsValue: 0` and no carrier rate here, deliberately.
+     *
+     * This function resolves the POLICY; it does not know the cart. A caller
+     * that needs the charged amount calls `quoteShipping` with the group's goods
+     * value and, for `estimate` mode, a rate — and `shippingFee` below stays the
+     * non-carrier answer so every existing caller behaves exactly as before
+     * until it is converted. An `estimate`-mode store therefore reports
+     * `shippingUnavailable`, which is the signal to go and get a rate rather
+     * than a zero that would ship for free at our expense.
+     */
+    const quote = quoteShipping({ policy, goodsValue: 0, carrierRate: null });
+    return {
+        shippingFee: quote.kind === "charge" ? quote.amount : 0,
+        storeOwnerId: storeOwnerId ?? undefined,
+        storeEmiEnabled,
+        storeState,
+        shippingPolicy: policy,
+        shippingUnavailable: quote.kind === "unavailable",
+        storeProtections: {
+            shipping: store?.supportsShippingProtection === true,
+            sale: store?.supportsSaleProtection === true,
+        },
+    };
+}
+/**
+ * The pre-C5b flat number, read as a `flat` mode.
+ *
+ * One extra read, and only for a store that has never saved a policy — so it
+ * disappears as sellers touch their settings rather than needing a migration.
+ */
+async function legacyFlatPolicy(storeOwnerId) {
     if (!storeOwnerId)
-        return { shippingFee: 0, storeOwnerId: undefined, storeEmiEnabled, storeState };
+        return DEFAULT_STORE_SHIPPING_POLICY;
     const sellerUser = await userRepository.findById(storeOwnerId);
-    const shippingConfig = sellerUser?.shippingConfig;
-    if (!shippingConfig?.isConfigured)
-        return { shippingFee: 0, storeOwnerId, storeEmiEnabled, storeState };
-    return { shippingFee: shippingConfig.customShippingPrice ?? 0, storeOwnerId, storeEmiEnabled, storeState };
+    const legacy = sellerUser?.shippingConfig;
+    if (!legacy?.isConfigured)
+        return DEFAULT_STORE_SHIPPING_POLICY;
+    const amount = legacy.customShippingPrice ?? 0;
+    if (!(amount > 0))
+        return DEFAULT_STORE_SHIPPING_POLICY;
+    return { mode: { kind: "flat", amount } };
 }
 /** P-8 GST — the seller's registered/pickup state, used to determine intra- vs inter-state tax. */
 async function resolveStoreState(storeId) {
@@ -391,7 +462,7 @@ async function createOrderForGroup(group, orderType, ctx) {
     const firstItem = group[0].item;
     const firstProduct = group[0].product;
     // Add-ons are this store's choice, not the cart's — see OrderGroupContext.
-    const { whatsappNotifyAddon = false, giftWrapAddon = false, giftWrapMessage, shipmentProtectionAddon = false, } = storeAddons?.[firstItem.storeId] ?? {};
+    const { whatsappNotifyAddon = false, giftWrapAddon = false, giftWrapMessage, shipmentProtectionAddon = false, saleProtectionAddon = false, } = storeAddons?.[firstItem.storeId] ?? {};
     const { platformFee = 0, gstOnFee: platformFeeGst = 0 } = platformFeeByStore.get(firstItem.storeId) ?? {};
     const groupTotal = group.reduce((sum, { item, product }) => sum + lineTotalFor(item, product), 0);
     // S-SBUNI-RULES 2026-05-13 — order-item decoration via rule registry.
@@ -404,23 +475,44 @@ async function createOrderForGroup(group, orderType, ctx) {
         return expandCartLineToOrderRows(item, product, ctx.productById).map((baseLine) => itemRule.decorateOrderItem(baseLine, product));
     });
     const totalQuantity = group.reduce((sum, { item }) => sum + item.quantity, 0);
-    const { shippingFee, storeOwnerId, storeEmiEnabled, storeState } = await resolveShippingCost(firstItem.storeId);
+    const { shippingFee, storeOwnerId, storeEmiEnabled, storeState, storeProtections } = await resolveShippingCost(firstItem.storeId);
     // P-8 GST — sum per-line-item tax (each product may carry its own gstRate),
     // then split the group total into a single cgst/sgst/igst breakdown for the
     // order document. Skipped entirely when GST is off or the buyer's state is
     // unknown (digital-only carts have no shipping address).
     let gstBreakdown;
     if (gstSettings?.enabled && buyerState) {
-        const intraState = !!storeState && storeState === buyerState;
+        /*
+         * 🛑 `isIntraStateSupply`, not `storeState === buyerState`. That raw
+         * comparison read "Karnataka" / "karnataka" / "KA" as three different
+         * states — the exact drift `constants/geo/subdivisions.ts` opens by
+         * documenting — and a store with no address resolved to `false`, i.e.
+         * silently inter-state. `null` means "cannot tell" and is logged rather
+         * than guessed; the AMOUNT is identical either way (IGST total ==
+         * CGST+SGST total), so what was wrong was the split on the invoice.
+         */
+        const intra = isIntraStateSupply(storeState, buyerState);
+        if (intra === null) {
+            serverLogger.warn("[gst] place of supply undetermined — defaulting to inter-state (IGST)", { storeId: firstItem.storeId, hasStoreState: !!storeState });
+        }
         // Per-member, not per-line: a bundle or grouped line spans several products
         // with several different rates, and taxing the whole line at one product's
         // rate is wrong in both directions. Shared with previewCheckoutPricing so
         // the figure shown and the figure charged cannot drift.
-        const { taxableAmount, gstAmount } = sumGroupGst(group.map(({ item }) => item), ctx.productById, intraState);
-        if (taxableAmount > 0) {
-            gstBreakdown = intraState
-                ? { taxableAmount, cgst: Math.round(gstAmount / 2), sgst: gstAmount - Math.round(gstAmount / 2), igst: 0, gstAmount }
-                : { taxableAmount, cgst: 0, sgst: 0, igst: gstAmount, gstAmount };
+        const summary = sumGroupGst(group.map(({ item }) => item), ctx.productById, intra ?? false);
+        /*
+         * The split is taken AS COMPUTED, per slice, by `calculateGst` inside
+         * `sumGroupGst`. It used to be re-derived here as
+         * `Math.round(gstAmount / 2)` — whole rupees, so ₹161.82 became
+         * 81.00/80.82 rather than 80.91/80.91, and a ₹0.52 total rounded to 0 and
+         * was then dropped off the invoice entirely by the `|| undefined` below.
+         *
+         * The guard is on EITHER base: an order of purely exempt goods has a real
+         * taxable value to report and zero tax, and skipping it left the invoice
+         * unable to reconcile.
+         */
+        if (summary.taxableAmount > 0 || summary.exemptAmount > 0) {
+            gstBreakdown = summary;
         }
     }
     const isCodLike = paymentMethod === "cod" || paymentMethod === "upi_manual" || paymentMethod === "cash";
@@ -445,7 +537,33 @@ async function createOrderForGroup(group, orderType, ctx) {
     const codHandlingFee = paymentMethod === "cod" ? computeCodHandlingFee(groupTotal, commissions) : 0;
     const whatsappNotifyFee = computeWhatsAppNotifyFee(whatsappNotifyAddon, commissions);
     const giftWrapFee = computeGiftWrapFee(giftWrapAddon, commissions);
-    const shipmentProtectionFee = computeShipmentProtectionFee(groupTotal, shipmentProtectionAddon, commissions);
+    /*
+     * ── C5e: all three protection tiers, enforced SERVER-SIDE ────────────────
+     *
+     * 🛑 The picker filtering the checkbox is not enough. `storeAddons` is a
+     * field on the cart document, so a hand-crafted `PUT /api/cart/addons` can
+     * tick a protection the seller declined — and billing for cover we will not
+     * honour is worse than any of the defects C5e exists to close. So the fee is
+     * gated here too, on the same three tiers the picker renders.
+     *
+     * The `finalSale` test reads the ORDER ITEMS we are about to write, i.e. the
+     * snapshot, never the live product — `OrderDocumentItem.finalSale` exists
+     * precisely so a seller cannot flip the switch after the sale.
+     */
+    const groupHasFinalSale = orderItems.some((line) => line.finalSale === true);
+    const { shippingProtectionFee: shipmentProtectionFee, saleProtectionFee } = computeProtectionFees({
+        subtotal: groupTotal,
+        selected: { shipping: shipmentProtectionAddon, sale: saleProtectionAddon },
+        tiers: {
+            platformShipping: commissions.shipmentProtectionFeeEnabled === true,
+            platformSale: commissions.saleProtectionFeeEnabled === true,
+            sellerShipping: storeProtections.shipping,
+            sellerSale: storeProtections.sale,
+            finalSale: groupHasFinalSale,
+        },
+        shippingFee: (s, sel) => computeShipmentProtectionFee(s, sel, commissions),
+        saleFee: (s, sel) => computeSaleProtectionFee(s, sel, commissions),
+    });
     const groupCouponCodes = new Set();
     const groupLines = group.map(({ item }) => ({ itemId: item.itemId, lineTotal: item.price * item.quantity }));
     const { couponDiscount, appliedDiscounts } = computeGroupCouponDiscount(appliedCoupons, groupLines, groupTotal, cartSubtotal, firstItem.storeId);
@@ -458,7 +576,19 @@ async function createOrderForGroup(group, orderType, ctx) {
     // The platform commission is now charged on EVERY payment method. It used to
     // be added only on the online-payment path, so COD / UPI-manual / cash / EMI
     // buyers silently never paid it.
-    const orderTotal = Math.max(0, groupTotal - couponDiscount) + shippingFee + codHandlingFee + whatsappNotifyFee + giftWrapFee + shipmentProtectionFee + platformFee + platformFeeGst + (emiSchedule?.surchargeAmount ?? 0) + (gstBreakdown?.gstAmount ?? 0);
+    const orderTotal = 
+    /*
+     * 🛑 Product GST is NOT a term here, and its absence is the model.
+     *
+     * Prices are tax-INCLUSIVE: the GST is already inside `groupTotal`, backed
+     * out by `sumGroupGst` for reporting rather than added on top. A ₹999
+     * listing at 5% charges ₹999, of which ₹47.57 is tax we remit.
+     *
+     * `platformFeeGst` IS a term, and the asymmetry is correct: that is GST on
+     * OUR service fee to the seller, charged to the buyer on top of the fee —
+     * not tax on the goods.
+     */
+    Math.max(0, groupTotal - couponDiscount) + shippingFee + codHandlingFee + whatsappNotifyFee + giftWrapFee + shipmentProtectionFee + saleProtectionFee + platformFee + platformFeeGst + (emiSchedule?.surchargeAmount ?? 0);
     const imageUrls = [
         ...new Set(group
             .map(({ product }) => product.mainImage)
@@ -534,7 +664,23 @@ async function createOrderForGroup(group, orderType, ctx) {
         giftWrapMessage: !adminBypass && giftWrapFee > 0 ? giftWrapMessage?.slice(0, 500) : undefined,
         shipmentProtectionAddon: !adminBypass && shipmentProtectionFee > 0 ? true : undefined,
         shipmentProtectionFee: !adminBypass && shipmentProtectionFee > 0 ? shipmentProtectionFee : undefined,
+        saleProtectionAddon: !adminBypass && saleProtectionFee > 0 ? true : undefined,
+        saleProtectionFee: !adminBypass && saleProtectionFee > 0 ? saleProtectionFee : undefined,
         taxableAmount: gstBreakdown?.taxableAmount,
+        /* Exempt goods are a reportable nil-rated supply, kept OUT of
+         * `taxableAmount` so the taxed base stays the base the tax was charged on,
+         * and recorded here so the invoice's columns can reconcile. */
+        exemptAmount: gstBreakdown?.exemptAmount || undefined,
+        /* Our registration AS IT STANDS NOW. A tax invoice without the supplier's
+         * GSTIN is not a tax invoice, and the invoice page cannot read it from
+         * site settings — `gst` is in PRIVATE_SITE_FIELDS. See the schema. */
+        supplierGstin: gstSettings?.enabled ? gstSettings.gstin || undefined : undefined,
+        supplierLegalName: gstSettings?.enabled ? gstSettings.legalName || undefined : undefined,
+        supplierAddress: gstSettings?.enabled ? gstSettings.address || undefined : undefined,
+        /* Per-rate, for Rule 46. Computed by `sumGroupGst` rather than re-derived
+         * downstream — a mixed 5%+18% order cannot produce a compliant invoice
+         * from the aggregate triple alone. */
+        gstByRate: gstBreakdown?.byRate.length ? gstBreakdown.byRate : undefined,
         /*
          * 🛑 This must include the GST on the PLATFORM FEE, not just product GST.
          *
@@ -902,6 +1048,7 @@ const EMPTY_PRICING_PREVIEW = {
     whatsappNotifyFee: 0,
     giftWrapFee: 0,
     shipmentProtectionFee: 0,
+    saleProtectionFee: 0,
     gstAmount: 0,
     couponDiscount: 0,
     platformFee: 0,
@@ -972,7 +1119,7 @@ export async function previewCheckoutPricing(input) {
     for (const { items: group } of orderGroups) {
         const firstItem = group[0].item;
         const groupTotal = group.reduce((sum, { item, product }) => sum + lineTotalFor(item, product), 0);
-        const { shippingFee: groupShippingFee, storeState } = await resolveShippingCost(firstItem.storeId);
+        const { shippingFee: groupShippingFee, storeState, storeProtections } = await resolveShippingCost(firstItem.storeId);
         // Add-ons are per store, read off the cart document — the same entry
         // createOrderForGroup will read when the order is actually placed.
         const addons = cart.storeAddons?.[firstItem.storeId] ?? {};
@@ -982,14 +1129,48 @@ export async function previewCheckoutPricing(input) {
         const groupCodHandlingFee = paymentMethod === "cod" ? computeCodHandlingFee(groupTotal, commissions) : 0;
         const groupWhatsappFee = computeWhatsAppNotifyFee(addons.whatsappNotifyAddon ?? false, commissions);
         const groupGiftWrapFee = computeGiftWrapFee(addons.giftWrapAddon ?? false, commissions);
-        const groupShipmentProtectionFee = computeShipmentProtectionFee(groupTotal, addons.shipmentProtectionAddon ?? false, commissions);
+        /*
+         * C5e — the same three tiers `createOrderForGroup` enforces, so the figure
+         * SHOWN and the figure CHARGED cannot differ over an add-on the seller
+         * declined.
+         *
+         * 🛑 `finalSale` is read off the LIVE product here, not a snapshot, and
+         * that is correct rather than an oversight: at preview time no order exists
+         * to have snapshotted it. The snapshot matters at the other two moments —
+         * order creation (so the written row is authoritative) and claim time (so a
+         * seller cannot flip the switch after the sale).
+         */
+        const groupHasFinalSale = group.some(({ product }) => product?.finalSale === true);
+        const { shippingProtectionFee: groupShipmentProtectionFee, saleProtectionFee: groupSaleProtectionFee, } = computeProtectionFees({
+            subtotal: groupTotal,
+            selected: {
+                shipping: addons.shipmentProtectionAddon ?? false,
+                sale: addons.saleProtectionAddon ?? false,
+            },
+            tiers: {
+                platformShipping: commissions.shipmentProtectionFeeEnabled === true,
+                platformSale: commissions.saleProtectionFeeEnabled === true,
+                sellerShipping: storeProtections.shipping,
+                sellerSale: storeProtections.sale,
+                finalSale: groupHasFinalSale,
+            },
+            shippingFee: (s, sel) => computeShipmentProtectionFee(s, sel, commissions),
+            saleFee: (s, sel) => computeSaleProtectionFee(s, sel, commissions),
+        });
         let groupGstAmount = 0;
         if (siteSettings?.gst?.enabled && resolvedAddress?.state) {
-            const intraState = !!storeState && storeState === resolvedAddress.state;
+            /*
+             * `isIntraStateSupply`, matching `createOrderForGroup` exactly — this
+             * was the same raw `===` and had to change with it, or the figure SHOWN
+             * and the figure CHARGED would split on different state comparisons.
+             * The total is unaffected by the answer (IGST total == CGST+SGST total),
+             * but using one rule in both places is what keeps that true.
+             */
+            const intra = isIntraStateSupply(storeState, resolvedAddress.state);
             // Same helper createOrderForGroup uses — the two disagreeing is the
             // recurring defect here (Root Cause #59), and it is the buyer seeing one
             // tax figure and being charged another.
-            groupGstAmount = sumGroupGst(group.map(({ item }) => item), resolvedProductById, intraState).gstAmount;
+            groupGstAmount = sumGroupGst(group.map(({ item }) => item), resolvedProductById, intra ?? false).gstAmount;
         }
         const groupLines = group.map(({ item, product }) => ({ itemId: item.itemId, lineTotal: lineTotalFor(item, product) }));
         const { couponDiscount: groupCouponDiscount } = computeGroupCouponDiscount(appliedCoupons, groupLines, groupTotal, cartSubtotal, firstItem.storeId);
@@ -1002,6 +1183,16 @@ export async function previewCheckoutPricing(input) {
             whatsappNotifyFee: groupWhatsappFee,
             giftWrapFee: groupGiftWrapFee,
             shipmentProtectionFee: groupShipmentProtectionFee,
+            saleProtectionFee: groupSaleProtectionFee,
+            /*
+             * INFORMATIONAL — the tax already INSIDE these prices, so checkout can
+             * render "incl. GST ₹47.57". 🛑 Deliberately NOT added to `total` below:
+             * it was, under the old add-on-top math, and removing it from all five
+             * money sites together is what the tax-inclusive model consists of. A
+             * preview that still added it would show a total ₹47.57 higher than the
+             * order it previews — the shown-vs-charged drift this field exists to
+             * prevent, reintroduced from the other direction.
+             */
             gstAmount: groupGstAmount,
             couponDiscount: groupCouponDiscount,
             total: Math.max(0, groupTotal - groupCouponDiscount) +
@@ -1010,7 +1201,10 @@ export async function previewCheckoutPricing(input) {
                 groupWhatsappFee +
                 groupGiftWrapFee +
                 groupShipmentProtectionFee +
-                groupGstAmount,
+                groupSaleProtectionFee,
+            supportsShippingProtection: storeProtections.shipping,
+            supportsSaleProtection: storeProtections.sale,
+            hasFinalSaleItem: groupHasFinalSale,
         });
     }
     const sum = (pick) => stores.reduce((acc, s) => acc + pick(s), 0);
@@ -1019,6 +1213,7 @@ export async function previewCheckoutPricing(input) {
     const whatsappNotifyFeeTotal = sum((s) => s.whatsappNotifyFee);
     const giftWrapFeeTotal = sum((s) => s.giftWrapFee);
     const shipmentProtectionFeeTotal = sum((s) => s.shipmentProtectionFee);
+    const saleProtectionFeeTotal = sum((s) => s.saleProtectionFee);
     const gstAmount = sum((s) => s.gstAmount);
     const couponDiscount = sum((s) => s.couponDiscount);
     // One capped commission for the whole checkout, on every payment method —
@@ -1030,6 +1225,7 @@ export async function previewCheckoutPricing(input) {
         whatsappNotifyFeeTotal +
         giftWrapFeeTotal +
         shipmentProtectionFeeTotal +
+        saleProtectionFeeTotal +
         platformFee +
         gstOnFee +
         gstAmount;
@@ -1040,6 +1236,7 @@ export async function previewCheckoutPricing(input) {
         whatsappNotifyFee: whatsappNotifyFeeTotal,
         giftWrapFee: giftWrapFeeTotal,
         shipmentProtectionFee: shipmentProtectionFeeTotal,
+        saleProtectionFee: saleProtectionFeeTotal,
         gstAmount,
         couponDiscount,
         platformFee,
@@ -1184,13 +1381,13 @@ async function refundDroppedItemsForPhonePeCheckout(input) {
  * from the inline version this replaced.
  */
 async function createPhonePeGroupOrder(group, orderType, ctx) {
-    const { appliedCoupons, cartSubtotal, storeAddons, platformFeeByStore, siteSettings, uid, userName, userEmail, merchantOrderId, phonepeOrderId, transactionId, shippingAddress, notes, outOfStockPolicy, unavailablePaid, orderIds, emailsToSend, couponUsageAccumulator, productById: phonepeProductById, } = ctx;
+    const { appliedCoupons, cartSubtotal, storeAddons, platformFeeByStore, siteSettings, uid, userName, userEmail, merchantOrderId, phonepeOrderId, transactionId, shippingAddress, notes, outOfStockPolicy, unavailablePaid, orderIds, emailsToSend, couponUsageAccumulator, productById: phonepeProductById, buyerState, } = ctx;
     const firstItem = group[0].item;
     const groupTotal = group.reduce((sum, { item, product }) => sum + lineTotalFor(item, product), 0);
     // Reuses the same store/seller lookup as the COD/UPI path above instead
     // of re-implementing it inline — was two sequential findById calls per
     // seller group here, duplicated from resolveShippingCost.
-    const { shippingFee, storeOwnerId } = await resolveShippingCost(firstItem.storeId);
+    const { shippingFee, storeOwnerId, storeState } = await resolveShippingCost(firstItem.storeId);
     const groupLines = group.map(({ item, product }) => ({ itemId: item.itemId, lineTotal: lineTotalFor(item, product) }));
     const { couponDiscount, appliedDiscounts } = computeGroupCouponDiscount(appliedCoupons, groupLines, groupTotal, cartSubtotal, firstItem.storeId);
     // Mirrors createOrderForGroup — without this the online-payment path wrote
@@ -1221,16 +1418,39 @@ async function createPhonePeGroupOrder(group, orderType, ctx) {
     const giftWrapFee = computeGiftWrapFee(addons.giftWrapAddon ?? false, commissionRates);
     const giftWrapMessage = addons.giftWrapMessage;
     const shipmentProtectionFee = computeShipmentProtectionFee(groupTotal, addons.shipmentProtectionAddon ?? false, commissionRates);
+    /*
+     * P-8 GST — now wired through this path. C0c defect 1.
+     *
+     * The comment that used to sit here deferred it, correctly identifying the
+     * blocker: `expectedPaymentAmountRs` compares against what PhonePe already
+     * captured, so adding product GST here WITHOUT adding it to the upstream
+     * pre-payment amount would either fail the mismatch check or silently
+     * under-charge. Both halves move in this change, plus the create-order route
+     * that decides the captured amount.
+     *
+     * 🛑 What unblocked it: the GST TOTAL does not depend on the place of
+     * supply. IGST total equals CGST+SGST total, so `/api/payment/create-order`
+     * can compute the amount before the delivery address is even known — which
+     * is the thing it genuinely cannot see. Measured across ~285k rate/base
+     * combinations, the two differ by at most ₹0.01 (from `round(half × 2)` in
+     * the intra branch), and the guard's tolerance is ₹1.
+     *
+     * Only the SPLIT needs the address, and this function has it.
+     */
+    let phonepeGst;
+    if (siteSettings?.gst?.enabled && buyerState) {
+        const intra = isIntraStateSupply(storeState, buyerState);
+        if (intra === null) {
+            serverLogger.warn("[gst] place of supply undetermined on the online path — defaulting to inter-state (IGST)", { storeId: firstItem.storeId, hasStoreState: !!storeState });
+        }
+        const summary = sumGroupGst(group.map(({ item }) => item), phonepeProductById, intra ?? false);
+        if (summary.taxableAmount > 0 || summary.exemptAmount > 0)
+            phonepeGst = summary;
+    }
+    /* Product GST is not a term — prices are tax-inclusive, so it is already
+     * inside `groupTotal`. Matches the COD/UPI path exactly; `platformFeeGst`
+     * stays because that is GST on our fee, charged on top. */
     const orderTotal = Math.max(0, groupTotal - couponDiscount) + shippingFee + whatsappNotifyFee + giftWrapFee + shipmentProtectionFee + platformFee + platformFeeGst;
-    // P-8 GST — deliberately NOT wired into this PhonePe-verify path. The
-    // amount-mismatch check above (expectedPaymentAmountRs) compares against
-    // what the buyer already paid via the PhonePe order created earlier in
-    // the flow; adding product GST here without also adding it to that
-    // upstream pre-payment amount calculation would either fail the mismatch
-    // check or silently under/over-charge. Wiring GST through the full
-    // PhonePe create→confirm round-trip is separate follow-up work, tracked
-    // alongside P-13 (PhonePe is disabled by default today, so this order
-    // type doesn't currently carry a GST breakdown).
     // S-SBUNI-RULES 2026-05-13 — order-item decoration via rule registry.
     // Same expansion as the COD/UPI path. This was a THIRD hand-rolled copy of
     // the price rule (`isBundle ? item.price : product.price`) that — like the
@@ -1311,6 +1531,26 @@ async function createPhonePeGroupOrder(group, orderType, ctx) {
         giftWrapMessage: giftWrapFee > 0 ? giftWrapMessage?.slice(0, 500) : undefined,
         shipmentProtectionAddon: shipmentProtectionFee > 0 ? true : undefined,
         shipmentProtectionFee: shipmentProtectionFee > 0 ? shipmentProtectionFee : undefined,
+        /*
+         * The tax breakdown, matching `createOrderForGroup` field for field.
+         * This path recorded NONE of it before C0c defect 1 — so an online order
+         * carried no `taxableAmount`, no `gstAmount` and no split, and the order
+         * page's Tax row could not render even once GST was enabled. Both the
+         * product GST and the platform-fee GST are summed into `gstAmount`, which
+         * is what makes the order's own lines reconcile to its total.
+         */
+        taxableAmount: phonepeGst?.taxableAmount,
+        exemptAmount: phonepeGst?.exemptAmount || undefined,
+        // Our registration at the moment of supply — see the schema. Mirrors the
+        // COD/UPI path so both produce an invoiceable order.
+        supplierGstin: siteSettings?.gst?.enabled ? siteSettings.gst.gstin || undefined : undefined,
+        supplierLegalName: siteSettings?.gst?.enabled ? siteSettings.gst.legalName || undefined : undefined,
+        supplierAddress: siteSettings?.gst?.enabled ? siteSettings.gst.address || undefined : undefined,
+        gstByRate: phonepeGst?.byRate.length ? phonepeGst.byRate : undefined,
+        gstAmount: (phonepeGst?.gstAmount ?? 0) + platformFeeGst || undefined,
+        cgst: phonepeGst?.cgst || undefined,
+        sgst: phonepeGst?.sgst || undefined,
+        igst: phonepeGst?.igst || undefined,
         couponCode: appliedDiscounts[0]?.code,
         couponDiscount: couponDiscount > 0 ? couponDiscount : undefined,
         appliedDiscounts: appliedDiscounts.length > 0 ? appliedDiscounts : undefined,
@@ -1563,6 +1803,35 @@ export async function verifyAndPlacePhonePeOrderAction(input) {
                 computeGiftWrapFee(addons.giftWrapAddon ?? false, commissionRates) +
                 computeShipmentProtectionFee(groupSubtotal, addons.shipmentProtectionAddon ?? false, commissionRates));
         }, 0);
+        /*
+         * Product GST, matching what `/api/payment/create-order` charged.
+         *
+         * 🛑 This term's ABSENCE was half of C0c defect 1. The guard agreed with
+         * the create path only because both omitted it, so an undercharge could
+         * never trip the check — the two were consistently wrong together, which
+         * is the worst available state for a guard.
+         *
+         * `intraState: false` is deliberate and is not a guess about the buyer's
+         * address: the TOTAL does not depend on the place of supply (IGST total ==
+         * CGST+SGST total), measured to within ₹0.01 across ~285k rate/base
+         * combinations, and this comparison already carries a ₹1 tolerance.
+         * Only the split needs the address, and the split is not checked here.
+         */
+        /*
+         * 🛑 No product-GST term, and the reason is the tax-inclusive model rather
+         * than the omission this guard was fixed for an hour earlier.
+         *
+         * Defect 1's fix added `expectedProductGst` here, because the three money
+         * sites had to AGREE with the preview and the preview added the tax. The
+         * model then changed: every price carries its tax inside, so the correct
+         * shared value became zero-added — at the capture route, at both order
+         * paths, at the preview, and here. The agreement defect 1 established is
+         * preserved; what changed is the figure all five agree on.
+         *
+         * `cartSubtotalRs` therefore already contains the GST, and adding it again
+         * would make this guard demand ~₹580 more than the buyer owes on a
+         * ₹5,547 cart — rejecting every correctly-charged order.
+         */
         const expectedPaymentAmountRs = cartSubtotalRs + expectedPlatformFee + expectedGstOnFee + expectedAddonFees + expectedShippingFee;
         // Reuses the order already fetched above to confirm COMPLETED — PhonePe's
         // own amount is in its wire-format smallest unit. // audit-money-units-ok: describes the PhonePe boundary conversion this line performs, not our storage convention
@@ -1611,6 +1880,10 @@ export async function verifyAndPlacePhonePeOrderAction(input) {
             phonepeOrderId: phonepeOrder.gatewayOrderId,
             transactionId: phonepeOrder.transactionId,
             shippingAddress,
+            // For the CGST/SGST vs IGST split. The TOTAL does not depend on it
+            // (see createPhonePeGroupOrder), which is what let the pre-payment
+            // amount be computed before this address was known.
+            buyerState: resolvedAddressPp?.state,
             notes,
             outOfStockPolicy,
             unavailablePaid,

package/dist/_internal/server/features/checkout/bundle-expansion.js

@@ -20,12 +20,12 @@
  * checkout — the Firestore transaction guarantees the second checkout sees
  * the first's decrement before re-running its own validation.
  */
-import { ProductStatusValues } from "../../../../features/products/schemas/firestore";
-import { getCartLineMembers } from "../../../shared/checkout/line-members";
+import { ProductStatusValues } from "../../../../features/products/schemas/firestore.js";
+import { getCartLineMembers } from "../../../shared/checkout/line-members.js";
 // Re-exported here so the many existing importers of this module keep working;
 // the definitions live in shared/ because `rules/_registry.ts` and
 // `order-math.ts` need them too and cannot import from server/.
-export { getCartLineMembers, getCartItemMemberIds, isMultiMemberLine, } from "../../../shared/checkout/line-members";
+export { getCartLineMembers, getCartItemMemberIds, isMultiMemberLine, } from "../../../shared/checkout/line-members.js";
 /** Build the unique-product-id + per-product decrement map for a cart. */
 export function getExpandedDecrements(cartItems) {
     const decrements = new Map();