@mmerterden/multi-agent-pipeline 20.7.0 → 20.8.0

package/pipeline/skills/shared/external/pdfkit/evals/evals.json

@@ -3,39 +3,39 @@
   "evals": [
     {
       "id": 1,
-      "prompt": "Review this PDFKit page-navigation code for iOS: `if let page = document.page(at: selectedIndex) { pdfView.go(to: page) }`, plus remove/exchange buttons that call `removePage(at:)` and `exchangePage(at:withPageAt:)` directly. What should change?",
-      "expected_output": "A concise PDFKit review that explains zero-based page indices, guards page access and page mutations before calling PDFDocument APIs, and supplies corrected Swift snippets.",
+      "prompt": "Review this helper from our statement viewer: it treats the first page as page 1, calls document.page(at: userNumber) and relies on it returning nil past the end, and passes user input straight into insert(_:at:), removePage(at:) and exchangePage(at:withPageAt:). What needs fixing?",
+      "expected_output": "Explains that PDFKit page indices are zero-based, that every index must be checked to be at least 0 and below pageCount before page(at:), insert, removePage or exchangePage, that inserting at pageCount appends, and that out-of-range indices raise exceptions instead of returning nil.",
       "files": [],
       "assertions": [
-        "States that PDFDocument page indices are zero-based and that page(at:), insert(_:at:), removePage(at:), and exchangePage(at:withPageAt:) must be called only with valid bounds.",
-        "Corrects the page navigation snippet by checking selectedIndex is greater than or equal to zero and less than document.pageCount before calling page(at:).",
-        "Corrects remove or exchange operations with pageCount-based guards instead of relying on optional binding or catching nil.",
-        "Does not claim page(at:) safely returns nil for out-of-range indices."
+        "States that page indices start at zero",
+        "Checks index >= 0 and index < pageCount before page(at:)",
+        "Applies the same bounds check to insert, removePage and exchangePage",
+        "Does not claim that page(at:) safely returns nil for an out-of-range index"
       ]
     },
     {
       "id": 2,
-      "prompt": "I'm adding a PencilKit-style drawing layer over a PDFView using PDFPageOverlayViewProvider. Sketch the PDFKit-side structure for provider ownership, visible-page lifecycle, and saving the edits back into the PDF.",
-      "expected_output": "A PDFKit overlay plan that keeps the overlay provider strongly owned, uses PDFPageOverlayViewProvider lifecycle callbacks to persist per-page overlay state, and explains that overlay views must be converted to PDF annotations or burned in before saving.",
+      "prompt": "We want users to draw signatures on top of pages in our contract app using a per-page overlay, and then save the signed PDF. Outline the PDFKit side of this.",
+      "expected_output": "Uses PDFPageOverlayViewProvider, keeps the provider strongly owned because pageOverlayViewProvider is weak, implements overlayViewFor and willEndDisplayingOverlayView to capture state, explains that overlay views are not written by write(to:) or dataRepresentation(), converts the drawing into annotations, appearance streams or burned-in page content before saving, and hands PencilKit tool details to the drawing skill.",
       "files": [],
       "assertions": [
-        "Notes that PDFView.pageOverlayViewProvider is weak and the provider must be strongly retained by a controller, coordinator, or other owner.",
-        "Uses pdfView(_:overlayViewFor:) for creating page overlay views and willEndDisplayingOverlayView to capture state before a page overlay leaves display.",
-        "States that overlay views are not automatically saved as PDF content.",
-        "Recommends converting overlay data into annotations, custom annotation appearance streams, or rendered/burned-in page content before write(to:) or dataRepresentation().",
-        "Keeps PencilKit drawing details as a handoff rather than turning the answer into a general PencilKit tutorial."
+        "Retains the overlay provider elsewhere because pageOverlayViewProvider is weak",
+        "Uses pdfView(_:overlayViewFor:) and pdfView(_:willEndDisplayingOverlayView:for:)",
+        "States that overlay views are not saved automatically",
+        "Converts overlay content to annotations, appearance streams or burned-in content before saving",
+        "Leaves PencilKit tool configuration to a PencilKit-focused skill"
       ]
     },
     {
       "id": 3,
-      "prompt": "Which skill should handle a feature that displays a PDF, fills text and checkbox fields, shows thumbnails, and wraps the view in SwiftUI? Mention any sibling-skill handoffs for broader SwiftUI or drawing behavior.",
-      "expected_output": "A boundary-aware answer that activates PDFKit for PDFView, PDFDocument, widget annotations, thumbnails, and PDF-specific SwiftUI wrapping while routing broad interop and drawing-tool concerns to sibling skills.",
+      "prompt": "Which of these belong in the PDFKit skill: showing a PDF with form fields, searching and extracting text, adding highlight annotations, generating thumbnails, saving the file, designing a general UIViewRepresentable architecture for our whole app, and building a freehand pen and marker toolbar?",
+      "expected_output": "Keeps display, form widgets, search and extraction, annotations, thumbnails and saving in PDFKit, routes general representable architecture to swiftui-uikit-interop, and routes freehand drawing tools to PencilKit or PaperKit, noting that PDFKit does not supply the PencilKit tool model or PaperKit markup UI.",
       "files": [],
       "assertions": [
-        "Keeps PDF display, form widgets, text extraction/search, annotations, thumbnails, and PDFDocument save behavior in the PDFKit skill.",
-        "Routes general UIViewRepresentable architecture beyond the PDFView wrapper to swiftui-uikit-interop when needed.",
-        "Routes freehand drawing tool behavior to PencilKit or PaperKit when the task is about drawing tools rather than PDF overlay lifecycle.",
-        "Does not claim PDFKit itself provides the full PencilKit drawing tool model or PaperKit markup UI."
+        "Keeps display, form widgets, search, extraction, annotations, thumbnails and saving in PDFKit",
+        "Routes general UIViewRepresentable architecture to swiftui-uikit-interop",
+        "Routes freehand drawing tools to PencilKit or PaperKit",
+        "States that PDFKit does not provide the PencilKit tool model or PaperKit markup UI"
       ]
     }
   ]