@mmerterden/multi-agent-pipeline 12.6.0 → 12.7.0

package/pipeline/scripts/repo-map.mjs

@@ -26,10 +26,10 @@
 //   2  -  usage / arg error
 //   3  -  root directory missing / not a repo
 
-import { promises as fs } from 'node:fs';
-import { existsSync, statSync } from 'node:fs';
-import path from 'node:path';
-import process from 'node:process';
+import { promises as fs } from "node:fs";
+import { existsSync, statSync } from "node:fs";
+import path from "node:path";
+import process from "node:process";
 
 // ---- CLI args --------------------------------------------------------------
 
@@ -38,25 +38,25 @@ function parseArgs(argv) {
     root: process.cwd(),
     budget: 2000,
     top: 25,
-    format: 'md',
+    format: "md",
     include: null,
     exclude: null,
     verbose: false,
   };
   for (let i = 2; i < argv.length; i++) {
     const a = argv[i];
-    if (a === '--root') args.root = path.resolve(argv[++i]);
-    else if (a === '--budget') args.budget = parseInt(argv[++i], 10);
-    else if (a === '--top') args.top = parseInt(argv[++i], 10);
-    else if (a === '--format') args.format = argv[++i];
-    else if (a === '--include') args.include = argv[++i].split(',').filter(Boolean);
-    else if (a === '--exclude') args.exclude = argv[++i].split(',').filter(Boolean);
-    else if (a === '--verbose' || a === '-v') args.verbose = true;
-    else if (a === '--help' || a === '-h') {
+    if (a === "--root") args.root = path.resolve(argv[++i]);
+    else if (a === "--budget") args.budget = parseInt(argv[++i], 10);
+    else if (a === "--top") args.top = parseInt(argv[++i], 10);
+    else if (a === "--format") args.format = argv[++i];
+    else if (a === "--include") args.include = argv[++i].split(",").filter(Boolean);
+    else if (a === "--exclude") args.exclude = argv[++i].split(",").filter(Boolean);
+    else if (a === "--verbose" || a === "-v") args.verbose = true;
+    else if (a === "--help" || a === "-h") {
       console.log(
-        'usage: repo-map.mjs [--root DIR] [--budget TOKENS] [--top N]\n' +
-          '                   [--format md|json] [--include GLOB,...]\n' +
-          '                   [--exclude GLOB,...] [--verbose]'
+        "usage: repo-map.mjs [--root DIR] [--budget TOKENS] [--top N]\n" +
+          "                   [--format md|json] [--include GLOB,...]\n" +
+          "                   [--exclude GLOB,...] [--verbose]",
       );
       process.exit(0);
     } else {
@@ -64,16 +64,16 @@ function parseArgs(argv) {
       process.exit(2);
     }
   }
-  if (!['md', 'json'].includes(args.format)) {
+  if (!["md", "json"].includes(args.format)) {
     console.error(`repo-map: --format must be md or json (got "${args.format}")`);
     process.exit(2);
   }
   if (!Number.isFinite(args.budget) || args.budget < 100) {
-    console.error('repo-map: --budget must be an integer >= 100');
+    console.error("repo-map: --budget must be an integer >= 100");
     process.exit(2);
   }
   if (!Number.isFinite(args.top) || args.top < 1) {
-    console.error('repo-map: --top must be >= 1');
+    console.error("repo-map: --top must be >= 1");
     process.exit(2);
   }
   return args;
@@ -82,24 +82,38 @@ function parseArgs(argv) {
 // ---- File walking ----------------------------------------------------------
 
 const DEFAULT_IGNORE = new Set([
-  '.git', '.worktrees', 'node_modules', 'Pods', '.build', 'DerivedData', '.next',
-  'dist', 'build', '__pycache__', '.venv', 'venv', '.cache',
-  '.gradle', '.idea', '.vscode', 'target',
+  ".git",
+  ".worktrees",
+  "node_modules",
+  "Pods",
+  ".build",
+  "DerivedData",
+  ".next",
+  "dist",
+  "build",
+  "__pycache__",
+  ".venv",
+  "venv",
+  ".cache",
+  ".gradle",
+  ".idea",
+  ".vscode",
+  "target",
 ]);
 
 const LANG_EXT = {
-  '.swift': 'swift',
-  '.kt':    'kotlin',
-  '.kts':   'kotlin',
-  '.ts':    'ts',
-  '.tsx':   'ts',
-  '.js':    'js',
-  '.mjs':   'js',
-  '.cjs':   'js',
-  '.jsx':   'js',
-  '.py':    'python',
-  '.sh':    'bash',
-  '.bash':  'bash',
+  ".swift": "swift",
+  ".kt": "kotlin",
+  ".kts": "kotlin",
+  ".ts": "ts",
+  ".tsx": "ts",
+  ".js": "js",
+  ".mjs": "js",
+  ".cjs": "js",
+  ".jsx": "js",
+  ".py": "python",
+  ".sh": "bash",
+  ".bash": "bash",
 };
 
 async function walk(root, args) {
@@ -112,7 +126,7 @@ async function walk(root, args) {
       return;
     }
     for (const e of entries) {
-      if (e.name.startsWith('.') && DEFAULT_IGNORE.has(e.name)) continue;
+      if (e.name.startsWith(".") && DEFAULT_IGNORE.has(e.name)) continue;
       if (DEFAULT_IGNORE.has(e.name)) continue;
       const full = path.join(dir, e.name);
       if (e.isDirectory()) {
@@ -151,8 +165,8 @@ const EXTRACTORS = {
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
-      const signature = `${kind} ${name}${rest ? ' ' + rest : ''}`.trim();
+      const rest = (m[3] || "").trim();
+      const signature = `${kind} ${name}${rest ? " " + rest : ""}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
     return out;
@@ -165,8 +179,8 @@ const EXTRACTORS = {
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
-      const signature = `${kind} ${name}${rest ? ' ' + rest : ''}`.trim();
+      const rest = (m[3] || "").trim();
+      const signature = `${kind} ${name}${rest ? " " + rest : ""}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
     return out;
@@ -179,8 +193,8 @@ const EXTRACTORS = {
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
-      const signature = `export ${kind} ${name}${rest ? ' ' + rest : ''}`.trim();
+      const rest = (m[3] || "").trim();
+      const signature = `export ${kind} ${name}${rest ? " " + rest : ""}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
     return out;
@@ -188,13 +202,12 @@ const EXTRACTORS = {
   js: (src) => EXTRACTORS.ts(src),
   python: (src) => {
     const out = [];
-    const re =
-      /^(?:\s{0,4})(?:async\s+)?(class|def)\s+([A-Za-z_][A-Za-z0-9_]*)(\([^)]*\))?/gm;
+    const re = /^(?:\s{0,4})(?:async\s+)?(class|def)\s+([A-Za-z_][A-Za-z0-9_]*)(\([^)]*\))?/gm;
     let m;
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
+      const rest = (m[3] || "").trim();
       const signature = `${kind} ${name}${rest}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
@@ -207,15 +220,15 @@ const EXTRACTORS = {
     let m;
     while ((m = re.exec(src))) {
       const name = m[1];
-      out.push({ kind: 'fn', name, signature: `${name}()` });
+      out.push({ kind: "fn", name, signature: `${name}()` });
     }
     return out;
   },
 };
 
 function truncateSig(s, max = 100) {
-  s = s.replace(/\s+/g, ' ').trim();
-  return s.length > max ? s.slice(0, max - 1) + '...' : s;
+  s = s.replace(/\s+/g, " ").trim();
+  return s.length > max ? s.slice(0, max - 1) + "..." : s;
 }
 
 // ---- Pipeline --------------------------------------------------------------
@@ -228,8 +241,8 @@ async function buildMap(args) {
   const files = await walk(args.root, args);
   if (args.verbose) console.error(`repo-map: scanned ${files.length} source files`);
   if (files.length === 0) {
-    if (args.format === 'json') console.log('[]');
-    else console.log('');
+    if (args.format === "json") console.log("[]");
+    else console.log("");
     return;
   }
 
@@ -239,7 +252,7 @@ async function buildMap(args) {
   for (const f of files) {
     let src;
     try {
-      src = await fs.readFile(f.abs, 'utf8');
+      src = await fs.readFile(f.abs, "utf8");
     } catch {
       continue;
     }
@@ -266,16 +279,49 @@ async function buildMap(args) {
 
   // Hard stop-list for sub-3-char + universally-shared shell helpers.
   const STOP_IDENTIFIERS = new Set([
-    'init', 'main', 'run', 'start', 'stop', 'pass', 'fail', 'warn', 'need',
-    'check', 'log', 'set', 'get', 'add', 'new', 'fix', 'has', 'is', 'on',
-    'self', 'this', 'next', 'prev', 'data', 'item', 'name', 'type', 'value',
-    'count', 'list', 'map', 'each', 'reduce', 'true', 'false', 'null', 'undefined',
+    "init",
+    "main",
+    "run",
+    "start",
+    "stop",
+    "pass",
+    "fail",
+    "warn",
+    "need",
+    "check",
+    "log",
+    "set",
+    "get",
+    "add",
+    "new",
+    "fix",
+    "has",
+    "is",
+    "on",
+    "self",
+    "this",
+    "next",
+    "prev",
+    "data",
+    "item",
+    "name",
+    "type",
+    "value",
+    "count",
+    "list",
+    "map",
+    "each",
+    "reduce",
+    "true",
+    "false",
+    "null",
+    "undefined",
   ]);
 
   for (const f of files) {
     let src;
     try {
-      src = await fs.readFile(f.abs, 'utf8');
+      src = await fs.readFile(f.abs, "utf8");
     } catch {
       continue;
     }
@@ -283,7 +329,7 @@ async function buildMap(args) {
       if (name.length < 3) continue;
       if (STOP_IDENTIFIERS.has(name.toLowerCase())) continue;
       if (owners.size === 1 && owners.has(f.path)) continue;
-      const re = new RegExp(`\\b${escapeRe(name)}\\b`, 'g');
+      const re = new RegExp(`\\b${escapeRe(name)}\\b`, "g");
       const matches = src.match(re);
       if (!matches) continue;
       // TF-IDF: credit per occurrence is divided by the number of owners.
@@ -313,7 +359,7 @@ async function buildMap(args) {
   ranks.sort((a, b) => b.score - a.score);
   const top = ranks.slice(0, args.top);
 
-  if (args.format === 'json') {
+  if (args.format === "json") {
     const obj = top.map((r) => ({
       path: r.path,
       lang: r.lang,
@@ -329,7 +375,7 @@ async function buildMap(args) {
   const charBudget = args.budget * 4;
   const header = `# Repo Map (top ${args.top}, budget ${args.budget} tokens)\n`;
   let used = header.length;
-  let out = header + '\n';
+  let out = header + "\n";
   let printed = 0;
 
   for (const r of top) {
@@ -338,16 +384,16 @@ async function buildMap(args) {
     const block =
       `## ${r.path}  [rank ${r.normScore.toFixed(3)}, in_refs ${r.ins}]\n` +
       (filteredDecls.length === 0
-        ? '_no top-level declarations extracted_\n'
-        : filteredDecls.map((d) => `- ${d.signature}`).join('\n') + '\n') +
-      '\n';
+        ? "_no top-level declarations extracted_\n"
+        : filteredDecls.map((d) => `- ${d.signature}`).join("\n") + "\n") +
+      "\n";
     if (used + block.length > charBudget && printed > 0) break;
     out += block;
     used += block.length;
     printed += 1;
   }
   if (printed === 0) {
-    out += '_no files extracted within budget_\n';
+    out += "_no files extracted within budget_\n";
   } else if (printed < top.length) {
     out += `_truncated to ${printed} files (token budget)_\n`;
   }
@@ -355,13 +401,13 @@ async function buildMap(args) {
 }
 
 function escapeRe(s) {
-  return s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
 }
 
 // ---- Main ------------------------------------------------------------------
 
 const args = parseArgs(process.argv);
 buildMap(args).catch((err) => {
-  console.error('repo-map: fatal  - ', err.message);
+  console.error("repo-map: fatal  - ", err.message);
   process.exit(1);
 });

package/pipeline/scripts/review-scope.mjs

@@ -63,7 +63,13 @@ function main() {
   try {
     report = JSON.parse(readInput());
   } catch {
-    emit({ scope: "full", reason: "no-risk-data-fail-safe", churn: null, maxScore: null, blockers: [] });
+    emit({
+      scope: "full",
+      reason: "no-risk-data-fail-safe",
+      churn: null,
+      maxScore: null,
+      blockers: [],
+    });
     return;
   }
 

package/pipeline/scripts/routine-registry.mjs

@@ -25,14 +25,7 @@
 //
 // Exit: 0 ok, 1 error (validation / collision / not-found), 64 usage.
 
-import {
-  existsSync,
-  readFileSync,
-  writeFileSync,
-  mkdirSync,
-  rmSync,
-  renameSync,
-} from "node:fs";
+import { existsSync, readFileSync, writeFileSync, mkdirSync, rmSync, renameSync } from "node:fs";
 import { join, dirname } from "node:path";
 
 const NAME_RE = /^[a-z0-9][a-z0-9-]*$/;
@@ -200,7 +193,9 @@ function cmdRemove(home, name) {
     prefs.global.routines = routines;
     writePrefs(home, prefs);
   }
-  console.log(`routine-registry: removed "${name}" (clears from autocomplete on next session reload)`);
+  console.log(
+    `routine-registry: removed "${name}" (clears from autocomplete on next session reload)`,
+  );
 }
 
 function main() {

package/pipeline/scripts/run-aggregator.mjs

@@ -120,7 +120,9 @@ function loadCostTable() {
   const path = flags["cost-table"] || join(__dirname, "cost-table.json");
   const tbl = loadJson(path);
   if (!tbl?.prices) {
-    process.stderr.write(`run-aggregator: cost table missing or malformed at ${path}, costs will be 0\n`);
+    process.stderr.write(
+      `run-aggregator: cost table missing or malformed at ${path}, costs will be 0\n`,
+    );
     return { prices: {} };
   }
   return tbl;
@@ -211,8 +213,8 @@ for (const phase of tracker.phases || []) {
       phase.status === "completed"
         ? "phase.complete"
         : phase.status === "failed"
-        ? "phase.failed"
-        : "phase.transition";
+          ? "phase.failed"
+          : "phase.transition";
     events.push({
       kind: eventKind,
       ts: phase.completed_at,
@@ -262,7 +264,9 @@ const lastTs =
     .filter((e) => e.kind.startsWith("phase.complete") || e.kind === "phase.failed")
     .map((e) => e.ts)
     .sort()
-    .pop() || tracker.started_at || "";
+    .pop() ||
+  tracker.started_at ||
+  "";
 
 events.push({
   kind: "run.end",
@@ -286,7 +290,9 @@ const summary = {
 };
 
 // ─────────────────────────────────────────────────────────────────────────
-const outLines = (flags["summary-only"] ? [summary] : [...events, summary]).map((e) => JSON.stringify(e));
+const outLines = (flags["summary-only"] ? [summary] : [...events, summary]).map((e) =>
+  JSON.stringify(e),
+);
 const outContent = outLines.join("\n") + "\n";
 
 if (flags.stdout) {

package/pipeline/scripts/run-metrics.mjs

@@ -48,7 +48,9 @@ try {
 }
 
 let state;
-try { state = JSON.parse(raw); } catch (e) {
+try {
+  state = JSON.parse(raw);
+} catch (e) {
   console.error(`run-metrics: bad JSON: ${e.message}`);
   process.exit(2);
 }
@@ -58,7 +60,7 @@ try { state = JSON.parse(raw); } catch (e) {
 const iterations = Array.isArray(state.reviewIterations)
   ? state.reviewIterations.filter((it) => it && typeof it === "object")
   : [];
-const lastTriage = iterations.length ? (iterations[iterations.length - 1].triage || {}) : {};
+const lastTriage = iterations.length ? iterations[iterations.length - 1].triage || {} : {};
 
 const accepted = Array.isArray(lastTriage.accepted) ? lastTriage.accepted : [];
 const deferred = Array.isArray(lastTriage.deferred) ? lastTriage.deferred : [];
@@ -78,18 +80,21 @@ let rawFindings = 0;
 let acceptedAll = 0;
 let classifiedAll = 0;
 for (const it of iterations) {
-  for (const r of (Array.isArray(it.reviewers) ? it.reviewers : [])) {
+  for (const r of Array.isArray(it.reviewers) ? it.reviewers : []) {
     rawFindings += Array.isArray(r?.findings) ? r.findings.length : 0;
   }
   const t = it.triage || {};
   acceptedAll += Array.isArray(t.accepted) ? t.accepted.length : 0;
-  classifiedAll += (Array.isArray(t.accepted) ? t.accepted.length : 0)
-    + (Array.isArray(t.deferred) ? t.deferred.length : 0)
-    + (Array.isArray(t.rejected) ? t.rejected.length : 0);
+  classifiedAll +=
+    (Array.isArray(t.accepted) ? t.accepted.length : 0) +
+    (Array.isArray(t.deferred) ? t.deferred.length : 0) +
+    (Array.isArray(t.rejected) ? t.rejected.length : 0);
 }
 
 // Build outcome across repos (multi-repo aware).
-const projects = Array.isArray(state.projects) ? state.projects.filter((p) => p && typeof p === "object") : [];
+const projects = Array.isArray(state.projects)
+  ? state.projects.filter((p) => p && typeof p === "object")
+  : [];
 let buildPassed = null;
 if (projects.length) {
   buildPassed = projects.every((p) => {
@@ -100,7 +105,7 @@ if (projects.length) {
   });
 } else if (state.buildStatus !== undefined) {
   const b = state.buildStatus;
-  buildPassed = typeof b === "string" ? b === "passed" : (b && b.ok === true);
+  buildPassed = typeof b === "string" ? b === "passed" : b && b.ok === true;
 }
 
 const metrics = {

package/pipeline/scripts/run-smokes.mjs

@@ -22,7 +22,43 @@ import { fileURLToPath } from "node:url";
 const scriptsDir = dirname(fileURLToPath(import.meta.url));
 const timeoutSec = Number(process.env.SMOKE_TIMEOUT_SECONDS || 180);
 const bail = process.env.SMOKE_NO_BAIL !== "1";
-const filters = process.argv.slice(2);
+const argv = process.argv.slice(2);
+const reportCounts = argv.includes("--counts");
+const filters = argv.filter((a) => !a.startsWith("--"));
+
+// How many assertions did a suite actually make?
+//
+// Exit code alone cannot answer that, and the difference matters: three smokes
+// were exiting 0 having checked nothing. smoke-workflow-audit skipped both its
+// linters because neither was installed anywhere, so the GitHub Actions
+// security audit had never run while showing green - it was hiding a
+// high-severity finding. smoke-plugin-validate had no manifest to validate in
+// this repo at all. A gate that cannot fail is worse than no gate, because the
+// green tick is read as coverage.
+//
+// The four output shapes actually in use here, surveyed across all suites
+// rather than assumed. Anything a suite prints that matches none of them
+// counts as zero, which is the intended answer: an unrecognisable result is
+// not evidence that something was checked.
+//
+//   1. "══ name: 22 passed, 0 failed ══"   most suites
+//   2. "check-md-links: 212 files OK"      counted sweeps
+//   3. per-line "✓" / "ok " / "PASS:"      suites with no summary line
+//   4. "smoke-language-axis: ok"           terse single-verdict suites
+function countAssertions(stdout) {
+  const passed = [...stdout.matchAll(/(\d+) passed/g)];
+  if (passed.length > 0) return Number(passed[passed.length - 1][1]);
+
+  const swept = [...stdout.matchAll(/(\d+) (?:files|patterns|checks|entries) (?:OK|clean)/gi)];
+  if (swept.length > 0) return Number(swept[swept.length - 1][1]);
+
+  const marks = stdout.match(/^[ \t]*(✓|ok |PASS[: ])/gm);
+  if (marks) return marks.length;
+
+  if (/^\S+: ok\s*$/m.test(stdout)) return 1;
+
+  return 0;
+}
 
 const suites = readdirSync(scriptsDir)
   .filter((f) => f.startsWith("smoke-") && f.endsWith(".sh"))
@@ -49,10 +85,28 @@ for (const suite of suites) {
   const secs = ((Date.now() - t0) / 1000).toFixed(1);
 
   const timedOut = res.error && res.error.code === "ETIMEDOUT";
-  const ok = !timedOut && res.status === 0;
+  const asserted = countAssertions(res.stdout || "");
+  const ok = !timedOut && res.status === 0 && (reportCounts || asserted > 0);
+
+  if (reportCounts) {
+    console.log(`${String(asserted).padStart(4)}  ${suite}`);
+    continue;
+  }
 
   if (ok) {
-    console.log(`ok   ${suite} (${secs}s)`);
+    console.log(`ok   ${suite} (${secs}s, ${asserted} checks)`);
+    continue;
+  }
+
+  if (!timedOut && res.status === 0 && asserted === 0) {
+    console.error(
+      `FAIL ${suite} (exited 0 having asserted nothing, ${secs}s)\n` +
+        "     A suite that checks nothing reports coverage it does not have.\n" +
+        "     Give it something to assert, or delete it.",
+    );
+    if (res.stdout) console.error(res.stdout.split("\n").slice(-15).join("\n"));
+    failures.push(suite);
+    if (bail) break;
     continue;
   }