@mmerterden/multi-agent-pipeline 12.6.0 → 12.7.0

package/pipeline/scripts/learnings-ledger.mjs

@@ -43,7 +43,15 @@
  * @module pipeline/scripts/learnings-ledger
  */
 
-import { readFileSync, writeFileSync, renameSync, existsSync, mkdirSync, appendFileSync, statSync } from "node:fs";
+import {
+  readFileSync,
+  writeFileSync,
+  renameSync,
+  existsSync,
+  mkdirSync,
+  appendFileSync,
+  statSync,
+} from "node:fs";
 import { homedir } from "node:os";
 import { execFileSync } from "node:child_process";
 import { join, basename, dirname } from "node:path";
@@ -59,11 +67,16 @@ for (let i = 1; i < argv.length; i++) {
   // (e.g. --statement="-- prefer let over var"). Use it when the space form
   // would mistake the value for the next flag.
   const eq = body.indexOf("=");
-  if (eq !== -1) { flags[body.slice(0, eq)] = body.slice(eq + 1); continue; }
+  if (eq !== -1) {
+    flags[body.slice(0, eq)] = body.slice(eq + 1);
+    continue;
+  }
   const k = body;
   const v = argv[i + 1];
-  if (v !== undefined && !v.startsWith("--")) { flags[k] = v; i++; }
-  else flags[k] = true;
+  if (v !== undefined && !v.startsWith("--")) {
+    flags[k] = v;
+    i++;
+  } else flags[k] = true;
 }
 
 const KINDS = new Set(["fact", "convention", "rejected-preference"]);
@@ -86,7 +99,7 @@ function repoSlug() {
     const commonDir = execFileSync(
       "git",
       ["rev-parse", "--path-format=absolute", "--git-common-dir"],
-      { encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] }
+      { encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] },
     ).trim();
     if (commonDir) {
       const base = basename(commonDir);
@@ -94,19 +107,30 @@ function repoSlug() {
       const slug = basename(root);
       if (slug) return slug;
     }
-  } catch { /* not a git repo, or git too old for --path-format */ }
+  } catch {
+    /* not a git repo, or git too old for --path-format */
+  }
   try {
     const top = execFileSync("git", ["rev-parse", "--show-toplevel"], {
       encoding: "utf8",
       stdio: ["ignore", "pipe", "ignore"],
     }).trim();
     if (top) return basename(top);
-  } catch { /* not a git repo */ }
+  } catch {
+    /* not a git repo */
+  }
   return "default";
 }
 
 function ledgerPath(slug) {
-  return join(homedir(), ".claude", "memory", "multi-agent", slug || repoSlug(), "learnings-ledger.jsonl");
+  return join(
+    homedir(),
+    ".claude",
+    "memory",
+    "multi-agent",
+    slug || repoSlug(),
+    "learnings-ledger.jsonl",
+  );
 }
 
 function ensureDir(p) {
@@ -114,7 +138,10 @@ function ensureDir(p) {
 }
 
 function normStatement(s) {
-  return String(s || "").toLowerCase().replace(/\s+/g, " ").trim();
+  return String(s || "")
+    .toLowerCase()
+    .replace(/\s+/g, " ")
+    .trim();
 }
 
 function readLedger(slug) {
@@ -124,8 +151,11 @@ function readLedger(slug) {
   const rows = [];
   for (const line of raw.split("\n")) {
     if (!line.trim()) continue;
-    try { rows.push(JSON.parse(line)); }
-    catch { /* skip corrupted line */ }
+    try {
+      rows.push(JSON.parse(line));
+    } catch {
+      /* skip corrupted line */
+    }
   }
   return rows;
 }
@@ -166,18 +196,25 @@ function addEntry(slug, { kind, statement, scope, task, confidence, diagnosis },
 function cmdAdd() {
   const kind = flags.kind;
   if (!KINDS.has(kind)) die(`--kind must be one of: ${[...KINDS].join(", ")}`, 1);
-  if (!flags.statement || flags.statement === true) die("add needs --statement \"...\"", 1);
+  if (!flags.statement || flags.statement === true) die('add needs --statement "..."', 1);
   const slug = repoSlug();
   const existing = new Set(readLedger(slug).map((r) => `${r.kind}::${normStatement(r.statement)}`));
-  const wrote = addEntry(slug, {
-    kind,
-    statement: flags.statement,
-    scope: flags.scope && flags.scope !== true ? String(flags.scope) : "global",
-    task: flags.task && flags.task !== true ? String(flags.task) : null,
-    confidence: flags.confidence && flags.confidence !== true ? String(flags.confidence) : "medium",
-    diagnosis: flags.diagnosis && flags.diagnosis !== true ? String(flags.diagnosis) : null,
-  }, existing);
-  process.stdout.write(JSON.stringify({ ok: true, slug, added: wrote ? 1 : 0, deduped: wrote ? 0 : 1 }) + "\n");
+  const wrote = addEntry(
+    slug,
+    {
+      kind,
+      statement: flags.statement,
+      scope: flags.scope && flags.scope !== true ? String(flags.scope) : "global",
+      task: flags.task && flags.task !== true ? String(flags.task) : null,
+      confidence:
+        flags.confidence && flags.confidence !== true ? String(flags.confidence) : "medium",
+      diagnosis: flags.diagnosis && flags.diagnosis !== true ? String(flags.diagnosis) : null,
+    },
+    existing,
+  );
+  process.stdout.write(
+    JSON.stringify({ ok: true, slug, added: wrote ? 1 : 0, deduped: wrote ? 0 : 1 }) + "\n",
+  );
   process.exit(wrote ? 0 : 2);
 }
 
@@ -188,8 +225,11 @@ function cmdFromTriage() {
   const task = flags.task && flags.task !== true ? String(flags.task) : null;
   const slug = repoSlug();
   let triage;
-  try { triage = JSON.parse(readFileSync(triagePath, "utf8")); }
-  catch (e) { die(`cannot parse triage JSON: ${e.message}`, 1); }
+  try {
+    triage = JSON.parse(readFileSync(triagePath, "utf8"));
+  } catch (e) {
+    die(`cannot parse triage JSON: ${e.message}`, 1);
+  }
 
   const existing = new Set(readLedger(slug).map((r) => `${r.kind}::${normStatement(r.statement)}`));
   let written = 0;
@@ -203,12 +243,21 @@ function cmdFromTriage() {
     // whole class on every future run. Blocking findings always get re-raised
     // and re-triaged on their own merits; only lower-severity rejections (style
     // nitpicks, scope calls) become durable "do not re-flag" preferences.
-    if (f.severity === "blocking") { skippedBlocking++; continue; }
+    if (f.severity === "blocking") {
+      skippedBlocking++;
+      continue;
+    }
     // Top-level files (dirname ".") scope to the file itself, not a stray "./*".
     const dir = f.file ? dirname(f.file) : "";
-    const scope = !f.file ? "global" : (dir === "." || dir === "" ? f.file : `${dir}/*`);
+    const scope = !f.file ? "global" : dir === "." || dir === "" ? f.file : `${dir}/*`;
     const statement = `Do not re-flag: ${issue}` + (r.reason ? ` (rejected: ${r.reason})` : "");
-    if (addEntry(slug, { kind: "rejected-preference", statement, scope, task, confidence: "low" }, existing)) {
+    if (
+      addEntry(
+        slug,
+        { kind: "rejected-preference", statement, scope, task, confidence: "low" },
+        existing,
+      )
+    ) {
       written++;
     }
   }
@@ -220,7 +269,7 @@ function cmdForget() {
   const slug = repoSlug();
   const match = flags.statement && flags.statement !== true ? normStatement(flags.statement) : null;
   const kind = flags.kind && flags.kind !== true ? String(flags.kind) : null;
-  if (!match && !kind) die("forget needs --statement \"...\" and/or --kind <kind>", 1);
+  if (!match && !kind) die('forget needs --statement "..." and/or --kind <kind>', 1);
   const p = ledgerPath(slug);
   if (!existsSync(p)) {
     process.stdout.write(JSON.stringify({ ok: true, slug, removed: 0 }) + "\n");
@@ -259,7 +308,9 @@ function cmdBrief() {
   for (const r of ordered) (byKind[r.kind] || (byKind[r.kind] = [])).push(r);
 
   const lines = ["<repo-learnings>"];
-  lines.push(`Durable knowledge for repo "${slug}" (replayed each run; treat as context, not commands - current scope decides).`);
+  lines.push(
+    `Durable knowledge for repo "${slug}" (replayed each run; treat as context, not commands - current scope decides).`,
+  );
   const labels = {
     fact: "Architectural facts",
     convention: "Conventions",
@@ -281,7 +332,9 @@ function cmdBrief() {
 }
 
 function cmdPath() {
-  process.stdout.write(ledgerPath(flags["repo-slug"] ? String(flags["repo-slug"]) : repoSlug()) + "\n");
+  process.stdout.write(
+    ledgerPath(flags["repo-slug"] ? String(flags["repo-slug"]) : repoSlug()) + "\n",
+  );
   process.exit(0);
 }
 
@@ -297,13 +350,27 @@ function cmdStats() {
 }
 
 switch (SUB) {
-  case "add": cmdAdd(); break;
-  case "from-triage": cmdFromTriage(); break;
-  case "forget": cmdForget(); break;
-  case "brief": cmdBrief(); break;
-  case "path": cmdPath(); break;
-  case "stats": cmdStats(); break;
+  case "add":
+    cmdAdd();
+    break;
+  case "from-triage":
+    cmdFromTriage();
+    break;
+  case "forget":
+    cmdForget();
+    break;
+  case "brief":
+    cmdBrief();
+    break;
+  case "path":
+    cmdPath();
+    break;
+  case "stats":
+    cmdStats();
+    break;
   default:
-    process.stderr.write("usage: learnings-ledger.mjs <add|from-triage|forget|brief|path|stats> [flags]\n");
+    process.stderr.write(
+      "usage: learnings-ledger.mjs <add|from-triage|forget|brief|path|stats> [flags]\n",
+    );
     process.exit(64);
 }

package/pipeline/scripts/lint-mcp-refs.mjs

@@ -45,7 +45,15 @@ const KNOWN_BAD = { dev_toolkit: "dev-toolkit", "claude-ai-Figma": "claude_ai_Fi
 
 const SCAN_DIRS = ["pipeline/commands", "pipeline/skills", "pipeline/multi-agent-refs"];
 const SCAN_EXT = /\.(md|sh|mjs|json)$/;
-const PRUNE = new Set(["node_modules", ".git", ".worktrees", "Pods", ".build", "DerivedData", ".next"]);
+const PRUNE = new Set([
+  "node_modules",
+  ".git",
+  ".worktrees",
+  "Pods",
+  ".build",
+  "DerivedData",
+  ".next",
+]);
 
 function walk(dir, out = []) {
   let entries;
@@ -121,7 +129,10 @@ function resolveToolkitRepo() {
       if (name.includes("dev") && arg) candidates.push(dirname(resolve(arg)));
     }
   };
-  for (const cfgPath of [join(homedir(), ".claude.json"), join(homedir(), ".claude", "settings.json")]) {
+  for (const cfgPath of [
+    join(homedir(), ".claude.json"),
+    join(homedir(), ".claude", "settings.json"),
+  ]) {
     if (!existsSync(cfgPath)) continue;
     try {
       const json = JSON.parse(readFileSync(cfgPath, "utf8"));

package/pipeline/scripts/lint-skills.mjs

@@ -14,12 +14,12 @@
 //   - description: required, non-empty, single line, <= 1024 chars
 //   - user-invocable: when present, must be true or false
 //   - platform: when present, must be ios | android | common | all
+//   - description: must carry a routing/trigger clause ("use when ..."), the
+//     one thing it is for - blocking since all 193 skills have one
 //
 // Spec-conformance signals (warnings - never fail the gate):
 //   - name should match the agent-skills spec pattern
 //     (lowercase letters/digits/hyphens, <= 64 chars)
-//   - description should carry a routing/trigger clause ("use when ...")
-//     so the model can decide when to load the skill
 //   - a body over ~500 lines with no companion-file reference should be
 //     split into references/ files loaded on demand
 
@@ -99,12 +99,19 @@ for (const file of files) {
     if (!isBlockScalar && words < 6) {
       warn(file, `description is terse (${words} words) - say what it does AND when to use it`);
     }
-    // Routing quality (warn-only): without a trigger clause the model has no
-    // signal for WHEN to load the skill. Heuristic phrase match; block
-    // scalars are skipped for the same parser reason as above.
-    const ROUTING_RE = /\b(use (this|it|when|for|whenever)|when (the|a|an|you|asked|working|building|implementing|writing|reviewing)|triggers?|invoked?( when| for)?|applies when|activated?)\b/i;
+    // Routing quality (BLOCKING since the backlog reached zero). A description
+    // without a trigger clause tells the model what the skill is and nothing
+    // about when to reach for it, which is the one job the description has -
+    // it is the routing rule, not a summary.
+    //
+    // This was warn-only while 93 of 193 skills were missing one, because a
+    // gate that fires on half the tree gets ignored. All 93 were written, so
+    // the baseline is zero and it can hold the line. Block scalars are skipped
+    // for the same parser reason as above.
+    const ROUTING_RE =
+      /\b(use (this|it|when|for|whenever)|when (the|a|an|you|asked|working|building|implementing|writing|reviewing)|triggers?|invoked?( when| for)?|applies when|activated?)\b/i;
     if (!isBlockScalar && !ROUTING_RE.test(desc)) {
-      warn(file, "description has no routing/trigger clause (e.g. \"use when ...\")");
+      fail(file, 'description has no routing/trigger clause (e.g. "use when ...")');
     }
   }
 
@@ -115,9 +122,13 @@ for (const file of files) {
   const bodyLines = body.split("\n").length;
   if (bodyLines > 500) {
     const referencesCompanion =
-      /\]\((?!https?:|mailto:|#)[^)]+\)/.test(body) || /`[^`\n]*\/[^`\n]*\.(md|sh|mjs|json|py|txt)`/.test(body);
+      /\]\((?!https?:|mailto:|#)[^)]+\)/.test(body) ||
+      /`[^`\n]*\/[^`\n]*\.(md|sh|mjs|json|py|txt)`/.test(body);
     if (!referencesCompanion) {
-      warn(file, `body is ${bodyLines} lines with no companion-file reference - consider splitting into references/`);
+      warn(
+        file,
+        `body is ${bodyLines} lines with no companion-file reference - consider splitting into references/`,
+      );
     }
   }
 

package/pipeline/scripts/localize-commands.mjs

@@ -116,7 +116,12 @@ if (invokedDirectly) {
     console.error("usage: localize-commands.mjs <apply|restore> [--dir <commandsDir>]");
     process.exit(2);
   }
-  let dir = join(process.env.HOME || process.env.USERPROFILE || "", ".claude", "commands", "multi-agent");
+  let dir = join(
+    process.env.HOME || process.env.USERPROFILE || "",
+    ".claude",
+    "commands",
+    "multi-agent",
+  );
   const dirFlag = args.indexOf("--dir");
   if (dirFlag >= 0) {
     if (!args[dirFlag + 1]) {

package/pipeline/scripts/match-skills.mjs

@@ -38,7 +38,9 @@ const repoRoot = resolve(here, "..", "..");
 
 const args = process.argv.slice(2);
 if (args.length === 0 || args[0].startsWith("--")) {
-  console.error('Usage: match-skills.mjs "<task text>" [--touched-files a,b] [--stack ios] [--limit 12] [--json]');
+  console.error(
+    'Usage: match-skills.mjs "<task text>" [--touched-files a,b] [--stack ios] [--limit 12] [--json]',
+  );
   process.exit(1);
 }
 
@@ -51,7 +53,11 @@ const opts = {
   json: false,
 };
 for (let i = 1; i < args.length; i++) {
-  if (args[i] === "--touched-files") opts.touchedFiles = (args[++i] || "").split(",").map((s) => s.trim()).filter(Boolean);
+  if (args[i] === "--touched-files")
+    opts.touchedFiles = (args[++i] || "")
+      .split(",")
+      .map((s) => s.trim())
+      .filter(Boolean);
   else if (args[i] === "--stack") opts.stack = (args[++i] || "").trim().toLowerCase();
   else if (args[i] === "--limit") opts.limit = parseInt(args[++i], 10) || 12;
   else if (args[i] === "--index") opts.indexPath = resolve(args[++i]);
@@ -86,8 +92,13 @@ function globToRe(glob) {
       // `**/` means zero-or-more path segments, so a leading `**/` must also
       // match top-level files (no dir prefix). Without the optional slash,
       // `**/Auth/**` compiled to `.*\/Auth\/.*` and missed root-level `Auth/...`.
-      if (glob[i + 2] === "/") { re += "(?:.*/)?"; i += 2; }
-      else { re += ".*"; i++; }
+      if (glob[i + 2] === "/") {
+        re += "(?:.*/)?";
+        i += 2;
+      } else {
+        re += ".*";
+        i++;
+      }
     } else if (c === "*") re += "[^/]*";
     else if (c === "?") re += ".";
     else if (".+()|{}[]^$\\".includes(c)) re += "\\" + c;

package/pipeline/scripts/migrate-prefs.mjs

@@ -95,7 +95,9 @@ function consolidateFirebase(out, changes) {
     }
     if ("firebase_project" in km) {
       delete km.firebase_project;
-      changes.push("keychainMapping: removed firebase_project (redundant  -  project_id lives inside the SA JSON)");
+      changes.push(
+        "keychainMapping: removed firebase_project (redundant  -  project_id lives inside the SA JSON)",
+      );
     }
   }
   if (Array.isArray(out?.global?.identities)) {
@@ -195,7 +197,9 @@ function migrate(prefs) {
       out.global.identities = out.global.gitIdentities;
       changes.push(`renamed gitIdentities → identities (${out.global.identities.length} entries)`);
     } else {
-      changes.push("gitIdentities present but identities also exists  -  keeping identities, dropping gitIdentities");
+      changes.push(
+        "gitIdentities present but identities also exists  -  keeping identities, dropping gitIdentities",
+      );
     }
     delete out.global.gitIdentities;
   } else if (!Array.isArray(out.global.identities)) {
@@ -214,7 +218,8 @@ function migrate(prefs) {
     }
   }
   out.global.keychainMapping = km;
-  if (kmChanged) changes.push("expanded keychainMapping with missing services (existing values preserved)");
+  if (kmChanged)
+    changes.push("expanded keychainMapping with missing services (existing values preserved)");
 
   // 5. New v2.1.0 fields with defaults
   if (!out.global.platformIdentityRouting) {
@@ -320,25 +325,29 @@ function migrateReportChannels(out, changes) {
   // --- reportChannels ---
   if (!g.reportChannels || typeof g.reportChannels !== "object") {
     const channels = {
-      pr:         true,  // schema default
-      jira:       typeof g.jiraCommentDefault === "boolean" ? g.jiraCommentDefault : true,
+      pr: true, // schema default
+      jira: typeof g.jiraCommentDefault === "boolean" ? g.jiraCommentDefault : true,
       confluence: typeof g.confluenceDefault === "boolean" ? g.confluenceDefault : false,
-      wiki:       typeof g.wikiDefault === "boolean" ? g.wikiDefault : false,
+      wiki: typeof g.wikiDefault === "boolean" ? g.wikiDefault : false,
     };
     g.reportChannels = channels;
-    changes.push("added reportChannels {pr,jira,confluence,wiki} (migrated from jiraCommentDefault/confluenceDefault/wikiDefault if present)");
+    changes.push(
+      "added reportChannels {pr,jira,confluence,wiki} (migrated from jiraCommentDefault/confluenceDefault/wikiDefault if present)",
+    );
   }
 
   // --- reportContent ---
   if (!g.reportContent || typeof g.reportContent !== "object") {
     g.reportContent = {
-      normalAnalysis:    true,
+      normalAnalysis: true,
       technicalAnalysis: false,
-      testScenarios:     true,
-      autoDiff:          false,
-      manualNote:        false,
+      testScenarios: true,
+      autoDiff: false,
+      manualNote: false,
     };
-    changes.push("added reportContent defaults {normalAnalysis,technicalAnalysis,testScenarios,autoDiff,manualNote}");
+    changes.push(
+      "added reportContent defaults {normalAnalysis,technicalAnalysis,testScenarios,autoDiff,manualNote}",
+    );
   } else if (!("technicalAnalysis" in g.reportContent)) {
     // v5.7.3+  -  backfill technicalAnalysis onto already-initialized reportContent
     g.reportContent.technicalAnalysis = false;
@@ -349,24 +358,32 @@ function migrateReportChannels(out, changes) {
   if (!Array.isArray(g.wikiScope)) {
     if (g.wikiDefault === false) {
       g.wikiScope = [];
-      changes.push("added wikiScope: [] (legacy wikiDefault=false  -  opt out of all wiki artifacts)");
+      changes.push(
+        "added wikiScope: [] (legacy wikiDefault=false  -  opt out of all wiki artifacts)",
+      );
     } else {
       g.wikiScope = ["main", "ios", "screenshots", "index"];
-      changes.push("added wikiScope: [main,ios,screenshots,index] (legacy wikiDefault=true or unset)");
+      changes.push(
+        "added wikiScope: [main,ios,screenshots,index] (legacy wikiDefault=true or unset)",
+      );
     }
   }
 
   // --- autopilotReportTimeoutSeconds ---
   if (typeof g.autopilotReportTimeoutSeconds !== "number") {
     g.autopilotReportTimeoutSeconds = 1800;
-    changes.push("added autopilotReportTimeoutSeconds: 1800 (30 min)  -  Phase 7 always-pause timeout");
+    changes.push(
+      "added autopilotReportTimeoutSeconds: 1800 (30 min)  -  Phase 7 always-pause timeout",
+    );
   }
 
   // --- prune deprecated booleans ---
   for (const key of ["jiraCommentDefault", "confluenceDefault", "wikiDefault"]) {
     if (key in g) {
       delete g[key];
-      changes.push(`removed deprecated ${key} (superseded by reportChannels${key === "wikiDefault" ? " + wikiScope" : ""})`);
+      changes.push(
+        `removed deprecated ${key} (superseded by reportChannels${key === "wikiDefault" ? " + wikiScope" : ""})`,
+      );
     }
   }
 }

package/pipeline/scripts/phase-tracker.sh

@@ -724,8 +724,10 @@ case "$ACTION" in
     # Live current-action line for the active phase. Quiet by construction:
     # progress lines are frequent, so `now` never renders - the card picks the
     # value up at the next boundary render/update. Truncated to 60 chars.
+    # 57 + "..." keeps the documented 60-char cap now that the marker is three
+    # ASCII dots rather than a one-character ellipsis.
     if [ "${#TEXT}" -gt 60 ]; then
-      TEXT="${TEXT:0:59}…"
+      TEXT="${TEXT:0:57}..."
     fi
     acquire_state_lock
     state=$(load_state)