@markjaquith/agency 1.11.1 → 2.1.0

package/src/services/FilterRepoService.ts

@@ -1,164 +0,0 @@
-import { Effect, Data, pipe } from "effect"
-import { spawnProcess } from "../utils/process"
-
-// Error types for FilterRepo operations
-class FilterRepoError extends Data.TaggedError("FilterRepoError")<{
-	message: string
-	cause?: unknown
-}> {}
-
-class FilterRepoNotInstalledError extends Data.TaggedError(
-	"FilterRepoNotInstalledError",
-)<{
-	message: string
-}> {}
-
-/**
- * Service for git-filter-repo operations.
- * git-filter-repo is an external Python tool for rewriting git history.
- */
-export class FilterRepoService extends Effect.Service<FilterRepoService>()(
-	"FilterRepoService",
-	{
-		sync: () => ({
-			/**
-			 * Check if git-filter-repo is installed.
-			 * @returns true if installed, false otherwise
-			 */
-			isInstalled: () =>
-				pipe(
-					spawnProcess(["which", "git-filter-repo"]),
-					Effect.map((result) => result.exitCode === 0),
-					Effect.catchAll(() => Effect.succeed(false)),
-				),
-
-			/**
-			 * Run git-filter-repo with the given arguments.
-			 * @param gitRoot - The git repository root
-			 * @param args - Arguments to pass to git-filter-repo
-			 * @param options - Additional options
-			 * @returns Object with exitCode, stdout, stderr
-			 */
-			run: (
-				gitRoot: string,
-				args: readonly string[],
-				options?: {
-					readonly env?: Record<string, string>
-					readonly verboseLog?: (message: string) => void
-					readonly streamOutput?: boolean
-					readonly progressIntervalMs?: number
-				},
-			) =>
-				Effect.gen(function* () {
-					// First check if git-filter-repo is installed
-					const installed = yield* pipe(
-						spawnProcess(["which", "git-filter-repo"]),
-						Effect.map((result) => result.exitCode === 0),
-						Effect.catchAll(() => Effect.succeed(false)),
-					)
-
-					if (!installed) {
-						return yield* Effect.fail(
-							new FilterRepoNotInstalledError({
-								message:
-									"git-filter-repo is not installed. Install it with: pip install git-filter-repo",
-							}),
-						)
-					}
-
-					const fullArgs = ["git-filter-repo", ...args]
-					const verboseLog = options?.verboseLog ?? (() => {})
-
-					verboseLog(`Running ${fullArgs.join(" ")} in ${gitRoot}`)
-					if (options?.streamOutput) {
-						verboseLog("Streaming git-filter-repo output directly")
-					}
-
-					const result = yield* pipe(
-						spawnProcess(fullArgs, {
-							cwd: gitRoot,
-							env: options?.env,
-							stdout: options?.streamOutput ? "inherit" : "pipe",
-							stderr: options?.streamOutput ? "inherit" : "pipe",
-							onProgress: options?.streamOutput
-								? ({ elapsedMs, pid }) => {
-										const elapsedSeconds = Math.round(elapsedMs / 1000)
-										verboseLog(
-											`git-filter-repo still running after ${elapsedSeconds}s${pid ? ` (pid ${pid})` : ""}`,
-										)
-									}
-								: undefined,
-							progressIntervalMs: options?.progressIntervalMs,
-						}),
-						Effect.mapError(
-							(error) =>
-								new FilterRepoError({
-									message: `git-filter-repo failed: ${error.stderr}`,
-									cause: error,
-								}),
-						),
-					)
-
-					verboseLog(`git-filter-repo exited with code ${result.exitCode}`)
-
-					if (result.exitCode !== 0) {
-						return yield* Effect.fail(
-							new FilterRepoError({
-								message: `git-filter-repo failed with exit code ${result.exitCode}: ${result.stderr}`,
-							}),
-						)
-					}
-
-					return result
-				}),
-
-			/**
-			 * Filter files from repository history.
-			 * This is a higher-level operation that handles common filtering patterns.
-			 * @param gitRoot - The git repository root
-			 * @param options - Filtering options
-			 */
-			filterFiles: (
-				gitRoot: string,
-				options: {
-					readonly refs?: string
-					readonly pathsToRemove?: readonly string[]
-					readonly pathRenames?: readonly { from: string; to: string }[]
-					readonly force?: boolean
-				},
-			) =>
-				Effect.gen(function* () {
-					const args: string[] = []
-
-					if (options.refs) {
-						args.push("--refs", options.refs)
-					}
-
-					if (options.pathsToRemove) {
-						for (const path of options.pathsToRemove) {
-							args.push("--invert-paths", "--path", path)
-						}
-					}
-
-					if (options.pathRenames) {
-						for (const rename of options.pathRenames) {
-							args.push("--path-rename", `${rename.from}:${rename.to}`)
-						}
-					}
-
-					if (options.force) {
-						args.push("--force")
-					}
-
-					// Always use these safety options
-					args.push("--prune-empty=always")
-
-					const filterRepo = yield* FilterRepoService
-
-					return yield* filterRepo.run(gitRoot, args, {
-						env: { GIT_CONFIG_GLOBAL: "" },
-					})
-				}),
-		}),
-	},
-) {}

package/src/services/FormatterService.test.ts

@@ -1,432 +0,0 @@
-import { test, expect, describe, beforeEach, afterEach } from "bun:test"
-import { join } from "path"
-import { Effect } from "effect"
-import { FormatterService } from "../services/FormatterService"
-import { createTempDir, cleanupTempDir, runTestEffect } from "../test-utils"
-
-describe("FormatterService", () => {
-	let tempDir: string
-
-	beforeEach(async () => {
-		tempDir = await createTempDir()
-	})
-
-	afterEach(async () => {
-		await cleanupTempDir(tempDir)
-	})
-
-	describe("detectPackageManager", () => {
-		test("returns null when no package.json exists", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBeNull()
-		})
-
-		test("detects bun from bun.lockb", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-			await Bun.write(join(tempDir, "bun.lockb"), "")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("bun")
-		})
-
-		test("detects bun from bun.lock", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-			await Bun.write(join(tempDir, "bun.lock"), "")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("bun")
-		})
-
-		test("detects yarn from yarn.lock", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-			await Bun.write(join(tempDir, "yarn.lock"), "")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("yarn")
-		})
-
-		test("detects pnpm from pnpm-lock.yaml", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-			await Bun.write(join(tempDir, "pnpm-lock.yaml"), "")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("pnpm")
-		})
-
-		test("detects npm from package-lock.json", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-			await Bun.write(join(tempDir, "package-lock.json"), "{}")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("npm")
-		})
-
-		test("defaults to npm when package.json exists but no lock file", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("npm")
-		})
-
-		test("bun.lockb takes priority over yarn.lock", async () => {
-			await Bun.write(join(tempDir, "package.json"), "{}")
-			await Bun.write(join(tempDir, "bun.lockb"), "")
-			await Bun.write(join(tempDir, "yarn.lock"), "")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectPackageManager(tempDir)
-				}),
-			)
-			expect(result).toBe("bun")
-		})
-	})
-
-	describe("detectFormatter", () => {
-		test("returns null when no package.json exists", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBeNull()
-		})
-
-		test("detects prettier in devDependencies", async () => {
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({
-					devDependencies: { prettier: "^3.0.0" },
-				}),
-			)
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBe("prettier")
-		})
-
-		test("detects prettier in dependencies", async () => {
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({
-					dependencies: { prettier: "^3.0.0" },
-				}),
-			)
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBe("prettier")
-		})
-
-		test("detects oxfmt in devDependencies", async () => {
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({
-					devDependencies: { oxfmt: "^0.1.0" },
-				}),
-			)
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBe("oxfmt")
-		})
-
-		test("oxfmt takes priority over prettier", async () => {
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({
-					devDependencies: { prettier: "^3.0.0", oxfmt: "^0.1.0" },
-				}),
-			)
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBe("oxfmt")
-		})
-
-		test("returns null when no formatter is in dependencies", async () => {
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({
-					devDependencies: { typescript: "^5.0.0" },
-				}),
-			)
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBeNull()
-		})
-
-		test("handles malformed package.json gracefully", async () => {
-			await Bun.write(join(tempDir, "package.json"), "not valid json")
-
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.detectFormatter(tempDir)
-				}),
-			)
-			expect(result).toBeNull()
-		})
-	})
-
-	describe("buildFormatterCommand", () => {
-		test("builds prettier command with bun", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("prettier", "bun", [
-						"/path/to/file.md",
-					])
-				}),
-			)
-			expect(result).toEqual([
-				"bun",
-				"x",
-				"prettier",
-				"--write",
-				"/path/to/file.md",
-			])
-		})
-
-		test("builds prettier command with yarn", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("prettier", "yarn", [
-						"/path/to/file.md",
-					])
-				}),
-			)
-			expect(result).toEqual([
-				"yarn",
-				"dlx",
-				"prettier",
-				"--write",
-				"/path/to/file.md",
-			])
-		})
-
-		test("builds prettier command with pnpm", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("prettier", "pnpm", [
-						"/path/to/file.md",
-					])
-				}),
-			)
-			expect(result).toEqual([
-				"pnpm",
-				"exec",
-				"prettier",
-				"--write",
-				"/path/to/file.md",
-			])
-		})
-
-		test("builds prettier command with npm", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("prettier", "npm", [
-						"/path/to/file.md",
-					])
-				}),
-			)
-			expect(result).toEqual(["npx", "prettier", "--write", "/path/to/file.md"])
-		})
-
-		test("builds oxfmt command with bun", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("oxfmt", "bun", [
-						"/path/to/file.json",
-					])
-				}),
-			)
-			expect(result).toEqual(["bun", "x", "oxfmt", "/path/to/file.json"])
-		})
-
-		test("handles multiple files", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("prettier", "bun", [
-						"/path/to/file.md",
-						"/path/to/file.json",
-					])
-				}),
-			)
-			expect(result).toEqual([
-				"bun",
-				"x",
-				"prettier",
-				"--write",
-				"/path/to/file.md",
-				"/path/to/file.json",
-			])
-		})
-
-		test("returns null for empty file list", async () => {
-			const result = await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					return yield* service.buildFormatterCommand("prettier", "bun", [])
-				}),
-			)
-			expect(result).toBeNull()
-		})
-	})
-
-	describe("formatFiles", () => {
-		test("silently does nothing when no package.json exists", async () => {
-			const logs: string[] = []
-			const verboseLog = (msg: string) => logs.push(msg)
-
-			await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					yield* service.formatFiles(tempDir, ["AGENTS.md"], verboseLog)
-				}),
-			)
-
-			expect(logs.some((l) => l.includes("No formatter"))).toBe(true)
-		})
-
-		test("silently does nothing when no formatter in package.json", async () => {
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({ devDependencies: { typescript: "^5.0.0" } }),
-			)
-
-			const logs: string[] = []
-			const verboseLog = (msg: string) => logs.push(msg)
-
-			await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					yield* service.formatFiles(tempDir, ["AGENTS.md"], verboseLog)
-				}),
-			)
-
-			expect(logs.some((l) => l.includes("No formatter"))).toBe(true)
-		})
-
-		test("filters to only md/json/jsonc files", async () => {
-			const logs: string[] = []
-			const verboseLog = (msg: string) => logs.push(msg)
-
-			await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					yield* service.formatFiles(
-						tempDir,
-						["somefile.ts", "other.txt"],
-						verboseLog,
-					)
-				}),
-			)
-
-			expect(logs.some((l) => l.includes("No formattable files"))).toBe(true)
-		})
-
-		test("does nothing with empty file list", async () => {
-			const logs: string[] = []
-			const verboseLog = (msg: string) => logs.push(msg)
-
-			await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					yield* service.formatFiles(tempDir, [], verboseLog)
-				}),
-			)
-
-			expect(logs.some((l) => l.includes("No files to format"))).toBe(true)
-		})
-
-		test("silently handles formatter command failure", async () => {
-			// Set up a project with prettier but no actual prettier installed
-			await Bun.write(
-				join(tempDir, "package.json"),
-				JSON.stringify({ devDependencies: { prettier: "^3.0.0" } }),
-			)
-			await Bun.write(join(tempDir, "bun.lockb"), "")
-			await Bun.write(join(tempDir, "AGENTS.md"), "# Test")
-
-			const logs: string[] = []
-			const verboseLog = (msg: string) => logs.push(msg)
-
-			// Should not throw even though prettier isn't actually installed
-			await runTestEffect(
-				Effect.gen(function* () {
-					const service = yield* FormatterService
-					yield* service.formatFiles(tempDir, ["AGENTS.md"], verboseLog)
-				}),
-			)
-
-			// Should have detected the formatter and attempted to run it
-			expect(logs.some((l) => l.includes("Detected formatter: prettier"))).toBe(
-				true,
-			)
-		})
-	})
-})