@markjaquith/agency 1.11.1 → 2.1.0

package/src/commands/emit.test.ts

@@ -1,576 +0,0 @@
-import { test, expect, describe, beforeEach, afterEach } from "bun:test"
-import { join } from "path"
-import { symlink } from "fs/promises"
-import { emit } from "../commands/emit"
-import { task } from "../commands/task"
-import { resolveGitInternalPath } from "../utils/git-path"
-import {
-	createTempDir,
-	cleanupTempDir,
-	initGitRepo,
-	initAgency,
-	fileExists,
-	getGitOutput,
-	getCurrentBranch,
-	createCommit,
-	checkoutBranch,
-	createBranch,
-	addAndCommit,
-	setupRemote,
-	runTestEffect,
-	runTestEffectWithMockFilterRepo,
-	clearCapturedFilterRepoCalls,
-	getLastCapturedFilterRepoCall,
-} from "../test-utils"
-
-// Cache the git-filter-repo availability check (it doesn't change during test run)
-let hasGitFilterRepoCache: boolean | null = null
-async function checkGitFilterRepo(): Promise<boolean> {
-	if (hasGitFilterRepoCache === null) {
-		const proc = Bun.spawn(["which", "git-filter-repo"], {
-			stdout: "pipe",
-			stderr: "pipe",
-		})
-		await proc.exited
-		hasGitFilterRepoCache = proc.exitCode === 0
-	}
-	return hasGitFilterRepoCache
-}
-
-describe("emit command", () => {
-	let tempDir: string
-	let originalCwd: string
-
-	beforeEach(async () => {
-		tempDir = await createTempDir()
-		originalCwd = process.cwd()
-		process.chdir(tempDir)
-
-		// Set config path to non-existent file to use defaults
-		process.env.AGENCY_CONFIG_PATH = join(tempDir, "non-existent-config.json")
-		// Set config dir to temp dir to avoid picking up user's config files
-		process.env.AGENCY_CONFIG_DIR = await createTempDir()
-
-		// Initialize git repo with main branch (already includes initial commit)
-		await initGitRepo(tempDir)
-
-		// Create a source branch (with agency-- prefix)
-		await createBranch(tempDir, "agency--test-feature")
-
-		// Initialize AGENTS.md and commit in one go
-		await initAgency(tempDir, "test")
-
-		await runTestEffect(task({ silent: true, fromCurrent: true }))
-		await addAndCommit(tempDir, "AGENTS.md", "Add AGENTS.md")
-
-		// Set up origin/main for git-filter-repo
-		await setupRemote(tempDir, "origin", tempDir)
-	})
-
-	afterEach(async () => {
-		process.chdir(originalCwd)
-		delete process.env.AGENCY_CONFIG_PATH
-		if (process.env.AGENCY_CONFIG_DIR) {
-			await cleanupTempDir(process.env.AGENCY_CONFIG_DIR)
-			delete process.env.AGENCY_CONFIG_DIR
-		}
-		await cleanupTempDir(tempDir)
-	})
-
-	describe("basic functionality", () => {
-		test("fails when there are uncommitted changes", async () => {
-			// Create uncommitted changes
-			await Bun.write(join(tempDir, "uncommitted.txt"), "uncommitted\n")
-
-			expect(
-				runTestEffect(emit({ silent: true, skipFilter: true })),
-			).rejects.toThrow(/uncommitted changes/)
-		})
-
-		test("fails when there are staged but uncommitted changes", async () => {
-			// Create a staged but uncommitted change
-			await Bun.write(join(tempDir, "staged.txt"), "staged\n")
-			await Bun.spawn(["git", "add", "staged.txt"], {
-				cwd: tempDir,
-				stdout: "pipe",
-				stderr: "pipe",
-			}).exited
-
-			expect(
-				runTestEffect(emit({ silent: true, skipFilter: true })),
-			).rejects.toThrow(/uncommitted changes/)
-		})
-
-		test("throws error when git-filter-repo is not installed", async () => {
-			const hasGitFilterRepo = await checkGitFilterRepo()
-			if (hasGitFilterRepo) {
-				// Skip this test if git-filter-repo IS installed
-				return
-			}
-
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			expect(runTestEffect(emit({ silent: true }))).rejects.toThrow(
-				"git-filter-repo is not installed",
-			)
-		})
-
-		test("creates emit branch with default name", async () => {
-			// Go back to main and create a fresh source branch (no inherited agency.json)
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--feature")
-			// Create agency.json for this branch
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["AGENTS.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await addAndCommit(tempDir, "agency.json", "Feature commit")
-
-			// Create emit branch (skip filter for speed)
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			// Check that emit branch exists (default pattern is %branch%, so emit is just "feature")
-			const branches = await getGitOutput(tempDir, [
-				"branch",
-				"--list",
-				"feature",
-			])
-			expect(branches.trim()).toContain("feature")
-
-			// Check we're still on the source branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-		})
-
-		test("sets emit branch upstream when remote branch exists", async () => {
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--feature")
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["AGENTS.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await addAndCommit(tempDir, "agency.json", "Feature commit")
-
-			await getGitOutput(tempDir, [
-				"update-ref",
-				"refs/remotes/origin/feature",
-				"HEAD",
-			])
-
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			const remote = await getGitOutput(tempDir, [
-				"config",
-				"--get",
-				"branch.feature.remote",
-			])
-			const merge = await getGitOutput(tempDir, [
-				"config",
-				"--get",
-				"branch.feature.merge",
-			])
-			expect(remote.trim()).toBe("origin")
-			expect(merge.trim()).toBe("refs/heads/feature")
-
-			await checkoutBranch(tempDir, "feature")
-			const pushRef = await getGitOutput(tempDir, [
-				"rev-parse",
-				"--abbrev-ref",
-				"@{push}",
-			])
-			expect(pushRef.trim()).toBe("origin/feature")
-		})
-
-		test("creates emit branch with custom name", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			// Skip filter for speed - we're just testing branch creation
-			await runTestEffect(
-				emit({ emit: "custom-pr", silent: true, skipFilter: true }),
-			)
-
-			const branches = await getGitOutput(tempDir, [
-				"branch",
-				"--list",
-				"custom-pr",
-			])
-			expect(branches.trim()).toContain("custom-pr")
-
-			// Check we're still on the source branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-		})
-
-		test("completes emit workflow successfully", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			// Should complete without throwing (skip filter for speed)
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			// Should still be on source branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-		})
-
-		test("preserves files on source branch after emit", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			// Skip filter for speed - we're testing source branch preservation
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			// Should still be on source branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-
-			// Check that test file still exists on source branch
-			expect(await fileExists(join(tempDir, "test.txt"))).toBe(true)
-
-			const files = await getGitOutput(tempDir, ["ls-files"])
-			expect(files).toContain("test.txt")
-		})
-
-		test("original branch remains untouched", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			// Create emit branch (skip filter for speed)
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			// Should still be on feature branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-
-			// Check that AGENTS.md still exist on original branch
-			const files = await getGitOutput(tempDir, ["ls-files"])
-			expect(files).toContain("AGENTS.md")
-		})
-
-		test("works correctly when run multiple times (recreates emit branch)", async () => {
-			await createBranch(tempDir, "agency--feature")
-
-			// Modify AGENTS.md on feature branch
-			await Bun.write(
-				join(tempDir, "AGENTS.md"),
-				"# Modified by feature branch\n",
-			)
-			await addAndCommit(tempDir, "AGENTS.md", "Modify AGENTS.md")
-
-			// Run emit command first time (skip filter for speed)
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			// Switch back to feature branch
-			await checkoutBranch(tempDir, "agency--feature")
-
-			// Make another commit
-			await createCommit(tempDir, "Another feature commit")
-
-			// Run emit command second time (skip filter for speed)
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			// Should complete successfully without interactive prompts and stay on source branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-		})
-
-		test("accepts explicit base branch argument", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			// Create emit branch with explicit base branch (skip filter for speed)
-			await runTestEffect(
-				emit({ baseBranch: "main", silent: true, skipFilter: true }),
-			)
-
-			// Should stay on source branch
-			const currentBranch = await getCurrentBranch(tempDir)
-			expect(currentBranch).toBe("agency--feature")
-		})
-
-		test("throws error if provided base branch does not exist", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			// This should fail even with skipFilter since base branch validation happens first
-			expect(
-				runTestEffect(
-					emit({ baseBranch: "nonexistent", silent: true, skipFilter: true }),
-				),
-			).rejects.toThrow("does not exist")
-		})
-	})
-
-	describe("error handling", () => {
-		test("throws error when not in a git repository", async () => {
-			const nonGitDir = await createTempDir()
-			process.chdir(nonGitDir)
-
-			expect(runTestEffect(emit({ silent: true }))).rejects.toThrow(
-				"Not in a git repository",
-			)
-
-			await cleanupTempDir(nonGitDir)
-		})
-	})
-
-	describe("silent mode", () => {
-		test("silent flag suppresses output", async () => {
-			await createBranch(tempDir, "agency--feature")
-			await createCommit(tempDir, "Feature commit")
-
-			const logs: string[] = []
-			const originalLog = console.log
-			console.log = (...args: any[]) => logs.push(args.join(" "))
-
-			// Skip filter for speed
-			await runTestEffect(emit({ silent: true, skipFilter: true }))
-
-			console.log = originalLog
-
-			expect(logs.length).toBe(0)
-		})
-	})
-
-	describe("filter-repo command construction (with mock)", () => {
-		beforeEach(() => {
-			clearCapturedFilterRepoCalls()
-		})
-
-		test("throws when emitted CLAUDE.md references AGENCY.md", async () => {
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--claude-reference-test")
-
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["AGENTS.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await Bun.write(
-				join(tempDir, "CLAUDE.md"),
-				"# Instructions\n\n@AGENCY.md\n",
-			)
-			await addAndCommit(
-				tempDir,
-				["agency.json", "CLAUDE.md"],
-				"Add Claude agency reference",
-			)
-
-			await expect(
-				runTestEffectWithMockFilterRepo(emit({ silent: true })),
-			).rejects.toThrow(
-				"CLAUDE.md on emitted branch claude-reference-test still references @AGENCY.md",
-			)
-		})
-
-		test("constructs correct filter-repo arguments", async () => {
-			// Set up fresh branch with agency.json
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--filter-test")
-
-			// Create agency.json with injected files
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["AGENTS.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await addAndCommit(tempDir, "agency.json", "Add agency.json")
-
-			// Run emit with mock filter-repo (not skipFilter!)
-			await runTestEffectWithMockFilterRepo(emit({ silent: true }))
-
-			// Verify filter-repo was called with correct arguments
-			const lastCall = getLastCapturedFilterRepoCall()
-			expect(lastCall).toBeDefined()
-
-			// Should include paths for base files (TASK.md, AGENCY.md, agency.json)
-			// Note: CLAUDE.md is NOT in base files - it's only filtered if it was created
-			// by agency (in which case it would be in injectedFiles)
-			// and injected files (AGENTS.md)
-			expect(lastCall!.args).toContain("--path")
-			expect(lastCall!.args).toContain("TASK.md")
-			expect(lastCall!.args).toContain("AGENCY.md")
-			expect(lastCall!.args).toContain("agency.json")
-			expect(lastCall!.args).toContain("AGENTS.md")
-
-			// Should include invert-paths and force flags
-			expect(lastCall!.args).toContain("--invert-paths")
-			expect(lastCall!.args).toContain("--force")
-
-			// Should include refs for the commit range
-			expect(lastCall!.args).toContain("--refs")
-
-			// Should have GIT_CONFIG_GLOBAL env set
-			expect(lastCall!.env?.GIT_CONFIG_GLOBAL).toBe("")
-		})
-
-		test("streams git-filter-repo output in verbose mode", async () => {
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--verbose-filter-test")
-
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["AGENTS.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await addAndCommit(tempDir, "agency.json", "Add agency.json")
-
-			await runTestEffectWithMockFilterRepo(
-				emit({ silent: true, verbose: true }),
-			)
-
-			const lastCall = getLastCapturedFilterRepoCall()
-			expect(lastCall).toBeDefined()
-			expect(lastCall!.streamOutput).toBe(true)
-			expect(lastCall!.progressIntervalMs).toBe(5000)
-		})
-
-		test("logs filter preflight diagnostics in verbose mode", async () => {
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--filter-diagnostics-test")
-
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["AGENTS.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await addAndCommit(tempDir, "agency.json", "Add agency.json")
-
-			const logs: string[] = []
-			const originalLog = console.log
-			console.log = (...args: any[]) => logs.push(args.join(" "))
-
-			try {
-				await runTestEffectWithMockFilterRepo(emit({ verbose: true }))
-			} finally {
-				console.log = originalLog
-			}
-
-			expect(logs.join("\n")).toContain("Commit range contains")
-			expect(logs.join("\n")).toContain("Filtered paths are touched by")
-			expect(logs.join("\n")).toContain("Filtered path diff contains")
-		})
-
-		test("includes symlink targets in files to filter", async () => {
-			// Set up fresh branch
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--symlink-test")
-
-			// Create AGENTS.md as the real file
-			await Bun.write(join(tempDir, "AGENTS.md"), "# Real file\n")
-
-			// Create CLAUDE.md as a symlink to AGENTS.md
-			await symlink("AGENTS.md", join(tempDir, "CLAUDE.md"))
-
-			// Create agency.json with CLAUDE.md in injectedFiles (since it's no longer in baseFiles)
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: ["CLAUDE.md"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await addAndCommit(
-				tempDir,
-				["AGENTS.md", "CLAUDE.md", "agency.json"],
-				"Add files with symlink",
-			)
-
-			// Run emit with mock filter-repo
-			await runTestEffectWithMockFilterRepo(emit({ silent: true }))
-
-			// Verify filter-repo was called with both CLAUDE.md AND AGENTS.md
-			const lastCall = getLastCapturedFilterRepoCall()
-			expect(lastCall).toBeDefined()
-
-			// Should include CLAUDE.md (the symlink)
-			expect(lastCall!.args).toContain("CLAUDE.md")
-
-			// Should also include AGENTS.md (the symlink target)
-			// This is the key assertion - the symlink target should be filtered too
-			expect(lastCall!.args).toContain("AGENTS.md")
-		})
-
-		test("expands injected dot-directory globs into filter paths", async () => {
-			await checkoutBranch(tempDir, "main")
-			await createBranch(tempDir, "agency--dotdir-test")
-
-			await Bun.spawn(["mkdir", "-p", join(tempDir, ".agents", "foo")], {
-				stdout: "pipe",
-				stderr: "pipe",
-			}).exited
-
-			await Bun.write(
-				join(tempDir, "agency.json"),
-				JSON.stringify({
-					version: 1,
-					injectedFiles: [".agents/**"],
-					template: "test",
-					createdAt: new Date().toISOString(),
-				}),
-			)
-			await Bun.write(join(tempDir, ".agents", "foo", "bar.whatever"), "test\n")
-			await addAndCommit(
-				tempDir,
-				["agency.json", ".agents/foo/bar.whatever"],
-				"Add template dot-directory file",
-			)
-
-			await runTestEffectWithMockFilterRepo(emit({ silent: true }))
-
-			const lastCall = getLastCapturedFilterRepoCall()
-			expect(lastCall).toBeDefined()
-			expect(lastCall!.args).toContain(".agents/foo/bar.whatever")
-		})
-	})
-
-	describe("git path resolution", () => {
-		test("resolves relative git internal paths from git root", () => {
-			expect(
-				resolveGitInternalPath(
-					"/repo/worktree",
-					"../.git/worktrees/worktree/filter-repo",
-				),
-			).toBe("/repo/.git/worktrees/worktree/filter-repo")
-		})
-
-		test("preserves absolute git internal paths", () => {
-			expect(
-				resolveGitInternalPath(
-					"/repo/worktree",
-					"/repo/.git/worktrees/worktree/filter-repo",
-				),
-			).toBe("/repo/.git/worktrees/worktree/filter-repo")
-		})
-	})
-})