@maka/maka-cli 5.66.0 → 5.67.0

package/bundle/typescript/src/commands/game/sideQuest/game.js

@@ -32,6 +32,7 @@ import { BacklogCommand } from './commands/backlog.js';
 // help index offers, never what the verb accepts (item D).
 import { isPlaytester, probePlaytesterStanding } from './utilities/playtester.js';
 import { RolesCommand } from './commands/roles.js';
+import { ReviewCommand } from './commands/review.js';
 import { SinCommand } from './commands/sin.js';
 import { GoCommand } from './commands/go.js';
 import { UseCommand } from './commands/use.js';
@@ -186,6 +187,9 @@ export default class Game {
     // social layer stays dark (presence, cloud mirror, street, drafts).
     _owner;
     _anonymous = false;
+    _bench = false;
+    _reproItemId;
+    _closing = false;
     _logFilePath = '';
     _tier = 1;
     /**
@@ -254,6 +258,66 @@ export default class Game {
     get isAnonymous() {
         return this._anonymous;
     }
+    /**
+     * A REPRO BENCH: a scratch session stood up to reproduce one backlog
+     * item. Not a life -- no save, no street presence, no shared table.
+     *
+     * SEPARATE FROM `isAnonymous`, and the separation is the point. The
+     * bench first reused the anonymous flag, since both want the street
+     * left alone -- and that quietly took the BACKLOG with it, because
+     * anonymity is a promise about a RUNNER ("nothing about them leaves
+     * this machine") and the backlog is one of the things it forbids. So
+     * a play-tester standing in the bench built for their own report was
+     * refused when they tried to answer it, which is the one thing the
+     * bench exists for.
+     *
+     * Two different concerns wearing one flag: "this character is
+     * private" and "this session is scratch". A bench is not private --
+     * it is the opposite, a place to file and confirm from.
+     */
+    get isBench() {
+        return this._bench;
+    }
+    /** The backlog item this bench was stood up for, if any.
+     *
+     *  The review commands read it so an answer needs no index. Player
+     *  ruling 2026-08-28: "I shouldn't have to pick from the list of
+     *  review items -- I AM reviewing an item." Making someone name which
+     *  report they mean, while they are standing in the scene built for
+     *  that report, is asking a question the session already answered. */
+    get reproItemId() {
+        return this._reproItemId;
+    }
+    /**
+     * CLOSE THE SESSION SHORTLY, leaving the last message on screen.
+     *
+     * For a bench that has just been answered (player request 2026-08-28:
+     * "after accepting or rejecting, give a 3s timeout and then close the
+     * session"). The pause is the point -- exiting the instant the post
+     * lands would wipe the confirmation before it could be read, and the
+     * confirmation is the only proof the answer went anywhere.
+     *
+     * Exits code 0, which is the same door `quit` goes through: the save
+     * seal in ui.ts fires (a no-op for a bench, which has no save path)
+     * and the launcher parent, which is the terminal's guaranteed
+     * janitor, restores the terminal exactly as it would after any other
+     * exit. No second teardown path.
+     *
+     * Idempotent: the first request wins, so answering twice in three
+     * seconds cannot stack timers.
+     */
+    closeAfter(ms, reason) {
+        if (this._closing)
+            return;
+        this._closing = true;
+        const timer = setTimeout(() => {
+            Logger.getInstance().write(`<<<<<<<<--------- Closing session: ${reason}`);
+            process.exit(0);
+        }, ms);
+        // Never hold the process open on its own account -- if everything
+        // else has finished, going now is right.
+        timer.unref?.();
+    }
     get sessionDir() {
         return this._logFilePath ? dirname(this._logFilePath) : undefined;
     }
@@ -452,13 +516,13 @@ export default class Game {
      * push one right now and say so.
      */
     async pushPresenceNow() {
-        if (this._anonymous)
+        if (this._anonymous || this._bench)
             return 'offline';
         return heartbeatPresenceNow(this.presencePayload());
     }
     startPresenceHeartbeat() {
-        if (this._anonymous)
-            return; // account-less: never on the street
+        if (this._anonymous || this._bench)
+            return; // account-less, or a bench: never on the street
         if (this._presenceTimer)
             return;
         this.beatPresence();
@@ -1512,8 +1576,8 @@ export default class Game {
     /** The transport, hooks-first, CLI default second; undefined =
      *  offline/logged out/classic mode (callers degrade quietly). */
     async streetTransport() {
-        if (this._anonymous)
-            return undefined; // account-less: no street
+        if (this._anonymous || this._bench)
+            return undefined; // account-less, or a bench: no street
         if (this.listStreetPlayers && this.sendPage) {
             return { list: this.listStreetPlayers, send: this.sendPage };
         }
@@ -1805,6 +1869,8 @@ ${client.name} won't be remembering anything. Dead Johnsons pay nothing -- and t
         CommandFactory.registerCommand('note', NoteCommand);
         CommandFactory.registerCommand('backlog', BacklogCommand);
         CommandFactory.registerCommand('roles', RolesCommand);
+        // The short form of "backlog review" -- see commands/review.ts.
+        CommandFactory.registerCommand('review', ReviewCommand);
         CommandFactory.registerCommand('sin', SinCommand);
         CommandFactory.registerCommand('sins', SinCommand);
         CommandFactory.registerCommand('papers', SinCommand);
@@ -2078,6 +2144,8 @@ ${client.name} won't be remembering anything. Dead Johnsons pay nothing -- and t
         this._saveFilePath = options.saveFilePath;
         this._owner = options.owner;
         this._anonymous = options.anonymousRunner === true;
+        this._bench = options.reproBench === true;
+        this._reproItemId = options.reproItemId;
         // Ask the server, once, whether this account is a play-tester, so
         // the help index can stop advertising a backlog that will only 403
         // (item D). Fire-and-forget on purpose: it never blocks the boot,
@@ -2130,7 +2198,23 @@ ${client.name} won't be remembering anything. Dead Johnsons pay nothing -- and t
         // spawned in a phantom hideout and read it as a kick back to the
         // hub). The room object still exists for any code that touches
         // _homeRoom; it's just not in the scene.
-        if (!options.sharedRun) {
+        // A BENCH GETS NO HIDEOUT EITHER, for the same reason a shared run
+        // does not: nobody lives here. It is two rooms and a door.
+        //
+        // FOUND FROM A LIVE SESSION LOG (2026-08-28). The bench promises
+        // "you start standing at the barrier", and it did not: the hideout
+        // was added and the player was moved INTO it, so the first thing a
+        // reviewer had to do was "go up" out of a home the bench had built
+        // them. They reported the steps as wrong; the steps were right and
+        // the scene had grown a room.
+        //
+        // WORTH RECORDING WHY THE DRY RUN MISSED IT. The headless harness
+        // boots with sharedRun: true, so it took the branch that skips all
+        // of this -- the replay I had been calling proof of the bench was
+        // quietly proving a DIFFERENT scene from the one a player gets.
+        // Adding reproBench here is what makes the two agree, which is the
+        // property the dry run was supposed to have all along.
+        if (!options.sharedRun && !options.reproBench) {
             this.scene.addRoom(this._homeRoom);
             this.connectHomeRoom(this.player.currentLocation);
             // Every session starts AT HOME -- the hideout, one door from the
@@ -2796,7 +2880,7 @@ ${client.name} won't be remembering anything. Dead Johnsons pay nothing -- and t
         // offer flow (his call, accept/decline, the taxi) works unchanged.
         // Offline owners fall back to the Phase B ghost riders below.
         let sharedDeclineNote = '';
-        if (this.hasHub && !this._anonymous) {
+        if (this.hasHub && !this._anonymous && !this._bench) {
             const srMod = await import('./utilities/shared-run.js').catch(() => undefined);
             const preferred = this.preferredDraftSessionID;
             this.preferredDraftSessionID = undefined;