@magnusekdahl/parallix 1.3.3 → 1.3.4

package/lib/review/review-commands.ts

@@ -51,7 +51,7 @@ export function readTextFlag(
   inlineFlag: string,
   fileFlag: string,
   label: string,
-  options: { readFileSync?: typeof fs.readFileSync; error?: (msg: string) => void; exit?: (code: number) => never } = {}
+  options: { readFileSync?: typeof fs.readFileSync; error?: (_msg: string) => void; exit?: (_code: number) => never } = {}
 ): string | null {
   const readFileSync = options.readFileSync || fs.readFileSync;
   const error = options.error || fmt.log.plainError;
@@ -98,8 +98,8 @@ export function formatStaticReviewSuccess(slug: string): string {
 function repairStaleActiveTaskAfterReview(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     getTaskStatusFn?: typeof getTaskStatus;
     resolveTaskFileFn?: typeof resolveTaskFile;
     transitionTaskFn?: typeof transitionTask;
@@ -133,7 +133,7 @@ function repairStaleActiveTaskAfterReview(
 
 async function commitPersistedReviewOutputs(
   slug: string,
-  options: { worktree?: string; taskFile?: string | null; log?: (msg: string) => void; error?: (msg: string) => void } = {}
+  options: { worktree?: string; taskFile?: string | null; log?: (_msg: string) => void; error?: (_msg: string) => void } = {}
 ): Promise<{ ok: boolean; dirty?: boolean; unsafe?: boolean }> {
   return commitSafeMissionArtifacts(slug, options.worktree || process.cwd(), {
     taskFile: options.taskFile || null,
@@ -146,8 +146,8 @@ export function postStaticReviewComment(
   slug: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     resolveTaskFileFn?: typeof resolveTaskFile;
     getTaskImplementerFn?: typeof getTaskImplementer;
     resolveWorktreeFn?: typeof resolveWorktree;
@@ -215,7 +215,7 @@ export function postStaticReviewComment(
 export function performStaticReview(
   slug: string,
   options: {
-    log?: (msg: string) => void;
+    log?: (_msg: string) => void;
     findMissionDir?: typeof findMissionDir;
     findCheckpoints?: typeof findCheckpoints;
     readFileSync?: typeof fs.readFileSync;
@@ -338,9 +338,9 @@ export function verifyReview(
   slug: string,
   skipGate: boolean | string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
     findMissionDirFn?: typeof findMissionDir;
     getCurrentBranchFn?: typeof getCurrentBranch;
@@ -522,15 +522,15 @@ export async function submitForReview(
   slug: string,
   skipGate: boolean | string,
   options: {
-    exit?: (code: number) => never;
+    exit?: (_code: number) => never;
     resolveTaskFileFn?: typeof resolveTaskFile;
     getTaskImplementerFn?: typeof getTaskImplementer;
     resolveWorktreeFn?: typeof resolveWorktree;
-    performHandoffFn?: (slug: string, opts?: Record<string, unknown>) => Promise<Record<string, unknown>>;
+    performHandoffFn?: (_slug: string, _opts?: Record<string, unknown>) => Promise<Record<string, unknown>>;
     readReviewStateFn?: typeof readReviewState;
     isReviewProviderEnabledFn?: typeof isProviderEnabled;
     isForgejoReviewEnabledFn?: typeof isProviderEnabled;
-    log?: (msg: string) => void;
+    log?: (_msg: string) => void;
   } = {}
 ): Promise<void> {
   const exit = options.exit || process.exit;
@@ -583,9 +583,9 @@ export async function submitForReview(
 export async function readComments(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     readTokenFn?: typeof readToken;
     readReviewStateFn?: typeof readReviewState;
     resolveReviewUserFn?: typeof resolveReviewUser;
@@ -676,9 +676,9 @@ export async function readComments(
 export async function pushRound(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
     resolveTaskFileFn?: typeof resolveTaskFile;
     getTaskImplementerFn?: typeof getTaskImplementer;
@@ -800,7 +800,7 @@ export async function pushRound(
 export function showReviewStatus(
   slug: string,
   options: {
-    log?: (msg: string) => void;
+    log?: (_msg: string) => void;
     readReviewStateFn?: typeof readReviewState;
     resolveWorktreeFn?: typeof resolveWorktree;
   } = {}
@@ -843,9 +843,9 @@ export function commentRound(
   slug: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     readReviewStateFn?: typeof readReviewState;
     writeReviewStateFn?: typeof writeReviewState;
     resolveReviewUserFn?: typeof resolveReviewUser;
@@ -902,8 +902,8 @@ export function commentRound(
 export async function consumeArtifacts(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     resolveWorktreeFn?: typeof resolveWorktree;
     transitionTaskFn?: typeof transitionTask;
     consumeReviewerArtifactsFn?: typeof consumeReviewerArtifacts;
@@ -1015,9 +1015,9 @@ export function submitReviewRound(
   outcome: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     transitionTaskFn?: typeof transitionTask;
     readReviewStateFn?: typeof readReviewState;
     writeReviewStateFn?: typeof writeReviewState;
@@ -1178,9 +1178,9 @@ export function submitReviewRound(
 export async function closeMissionPr(
   slug: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     readTokenFn?: typeof readToken;
     readReviewStateFn?: typeof readReviewState;
     resolveReviewUserFn?: typeof resolveReviewUser;
@@ -1233,9 +1233,9 @@ export function createEventHandler(
   slug: string,
   args: string[],
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
     readReviewStateFn?: typeof readReviewState;
   } = {}
@@ -1349,9 +1349,9 @@ export function importLegacyHandler(
   slug: string,
   args: string[],
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     resolveWorktreeFn?: typeof resolveWorktree;
   } = {}
 ): void {
@@ -1383,9 +1383,9 @@ export async function review(
   args: string[],
   options: {
     inferSlugFn?: typeof inferSlug;
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    exit?: (code: number) => never;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    exit?: (_code: number) => never;
     verifyReviewFn?: typeof verifyReview;
     submitForReviewFn?: typeof submitForReview;
     consumeArtifactsFn?: typeof consumeArtifacts;

package/lib/review/review-events.ts

@@ -207,8 +207,8 @@ export interface CreateEventParams {
 export interface CreateEventOptions {
   skipGit?: boolean;
   gitFn?: typeof git;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
   worktree?: string;
   allowMissingRequiredFields?: boolean;
 }
@@ -247,7 +247,7 @@ export interface ReadAllEventsOptions {
   rootDir?: string;
   readdirSync?: typeof fs.readdirSync;
   readFileSync?: typeof fs.readFileSync;
-  error?: (msg: string) => void;
+  error?: (_msg: string) => void;
 }
 
 export interface ParseEventResult {
@@ -352,14 +352,14 @@ function classifyComment(comment: { body?: string }): string | null {
 }
 
 export interface ConsumeHumanNotesOptions {
-  getCommentsFn?: (branch: string, token: string) => Promise<unknown[]>;
-  createEventFn?: typeof createEvent;
-  readTokenFn?: (user: string) => string | null;
+  getCommentsFn?: (_branch: string, _token: string) => Promise<unknown[]>;
+    createEventFn?: typeof createEvent;
+    readTokenFn?: (_user: string) => string | null;
   reviewIdentity?: string | null;
   forgejoUser?: string | null;
   worktree?: string;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
 }
 
 /**
@@ -578,8 +578,8 @@ function createEvent(slug: string, eventType: string, params: CreateEventParams,
 
 export interface ImportLegacyArtifactOptions {
   tmpDir?: string;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
   worktree?: string;
 }
 
@@ -650,9 +650,9 @@ const LEGACY_ARTIFACT_TO_EVENT_TYPE: Readonly<Record<string, string>> = Object.f
 
 export interface ImportAllLegacyOptions {
   tmpDir?: string;
-  error?: (msg: string) => void;
+  error?: (_msg: string) => void;
   worktree?: string;
-  log?: (msg: string) => void;
+  log?: (_msg: string) => void;
 }
 
 /**

package/lib/review/review-loop.js

@@ -44,12 +44,16 @@ exports.maybeUpdateGraphifyBeforeReview = maybeUpdateGraphifyBeforeReview;
 exports.applyAgentFallback = applyAgentFallback;
 exports.persistNormalizedPhaseRepair = persistNormalizedPhaseRepair;
 exports.stageLaunchSinceMs = stageLaunchSinceMs;
+exports.classifyGateFailure = classifyGateFailure;
+exports.runPreReviewGate = runPreReviewGate;
+exports.handleGateFailureAutoBounce = handleGateFailureAutoBounce;
 exports.startReviewLoop = startReviewLoop;
 const fs = __importStar(require("fs"));
 const path = __importStar(require("path"));
 const fmt = __importStar(require("../core/fmt.js"));
 const git_js_1 = require("../core/git.js");
 const mission_utils_js_1 = require("../core/mission-utils.js");
+const verification_js_1 = require("../core/verification.js");
 const backlog_js_1 = require("../tools/backlog.js");
 const state_map_js_1 = require("../core/state-map.js");
 const review_adapter_js_1 = require("./review-adapter.js");
@@ -232,10 +236,164 @@ function stageLaunchSinceMs(result) {
     return Number.isFinite(startedMs) ? startedMs : 0;
 }
 // ============================================================================
+// Pre-review Gate Enforcement (ADR 0048 Control C1 / TASK-1385)
+// ============================================================================
+// Minimal error classifier stub for gate failures (TASK-1389 dependency).
+// Maps gate failures to Class 6: genuine gate failure — code issue, dispatch: auto-send-back.
+// TASK-1389 will replace this with the full 8-class dispatch table.
+const GATE_FAILURE_CLASS = 'class-6-genuine-gate-failure';
+const GATE_FAILURE_ACTION = 'auto-send-back';
+function classifyGateFailure(_output) {
+    // Gate failures are genuine code issues — always relaunchable via auto-send-back.
+    // The full classifier (TASK-1389) will expand this to 8 classes with nuanced dispatch.
+    return {
+        classification: GATE_FAILURE_CLASS,
+        action: GATE_FAILURE_ACTION,
+        isRelaunchable: true,
+    };
+}
+/**
+ * Run the verification gate with the mission area before a review round.
+ * Captures stdout/stderr for use in auto-bounce fix prompts.
+ */
+async function runPreReviewGate(slug, worktree, opts = {}) {
+    const { findMissionAreaFn = mission_utils_js_1.findMissionArea, runFn: runFnOverride = git_js_1.run, log = fmt.log.plain, error = fmt.log.plainError, } = opts;
+    const missionDir = (0, mission_utils_js_1.findMissionDir)(slug, worktree);
+    const area = missionDir ? findMissionAreaFn(missionDir) : 'docs';
+    const command = (0, verification_js_1.formatVerificationCommand)(area, worktree);
+    if (command === NO_GATE_NOTICE_ALIAS) {
+        log(fmt.status('INFO', `No verification gate configured for area ${area}; skipping pre-review gate check.`));
+        return { ok: true, area, command, exitCode: 0, stdout: '', stderr: '' };
+    }
+    log(fmt.status('INFO', `Pre-review gate for area "${area}": ${fmt.command(command)}`));
+    // Run with pipe mode to capture output for auto-bounce fix prompts.
+    const result = runFnOverride('bash', ['-lc', command], {
+        cwd: worktree,
+        stdio: 'pipe',
+        maxBuffer: 10 * 1024 * 1024, // 10MB buffer
+    });
+    const stdout = typeof result.stdout === 'string' ? result.stdout : '';
+    const stderr = typeof result.stderr === 'string' ? result.stderr : '';
+    if (result.status !== 0) {
+        error(fmt.status('FAIL', `Pre-review gate failed for area "${area}" (exit ${result.status}).`));
+        if (stderr) {
+            error(`  stderr: ${stderr.split('\n').slice(0, 10).join('\n  ')}`);
+        }
+        return {
+            ok: false,
+            area,
+            command,
+            exitCode: result.status,
+            stdout,
+            stderr,
+            error: `verification gate failed with exit code ${result.status}`,
+        };
+    }
+    log(fmt.status('PASS', `Pre-review gate passed for area "${area}".`));
+    return { ok: true, area, command, exitCode: 0, stdout, stderr };
+}
+const NO_GATE_NOTICE_ALIAS = ': # no verification gate configured (set adapters.verification.command)';
+/**
+ * Handle a pre-review gate failure by auto-bouncing to the implementer.
+ * Does NOT consume a reviewer cycle or transition the task out of review status.
+ * Tracks retry count in review state metadata.
+ * Returns true if bounced, false if retry limit exceeded (mission strands).
+ */
+async function handleGateFailureAutoBounce(slug, worktree, gateResult, implementer, opts = {}) {
+    const { startAgentFn = agents_js_1.startAgent, writeReviewStateFn = review_state_js_1.writeReviewState, readReviewStateFn = review_state_js_1.readReviewState, transitionTaskFn = backlog_js_1.transitionTask, applyAgentFallbackFn = applyAgentFallback, taskResolution, enforceTaskAssigneeFn, log = fmt.log.plain, error = fmt.log.plainError, sleepFn: _sleepFn = review_polling_js_1.delay, buildCompactActOnReviewPromptFn: _buildCompactActOnReviewPromptFn = review_prompts_js_1.buildCompactActOnReviewPrompt, isForgejoReviewEnabledFn: _isForgejoReviewEnabledFn, isReviewProviderEnabledFn: _isReviewProviderEnabledFn, legacyIsForgejoReviewEnabledFn: _legacyIsForgejoReviewEnabledFn, exit: _exit = process.exit, } = opts;
+    const MAX_GATE_RETRY = 2;
+    // Read persisted state to get current retry count
+    const persisted = readReviewStateFn(slug, worktree);
+    const retryCount = persisted && persisted.metadata && typeof persisted.metadata === 'object'
+        ? (Number(persisted.metadata.gateFailureRetryCount) || 0)
+        : 0;
+    if (retryCount >= MAX_GATE_RETRY) {
+        error(fmt.status('FAIL', `Pre-review gate failure: max retries exceeded (${MAX_GATE_RETRY}). Mission stranded for ${slug}.`));
+        error(fmt.status('FAIL', `Area "${gateResult.area}" verification failed ${retryCount} times. Human intervention required.`));
+        error(fmt.status('FAIL', `Gate output:\n${gateResult.stdout || gateResult.stderr || '(no output)'}\n`));
+        return { bounced: false, stranded: true };
+    }
+    // Classify the failure
+    const combinedOutput = gateResult.stderr || gateResult.stdout || 'Gate failed with exit code ' + gateResult.exitCode;
+    const classification = classifyGateFailure(combinedOutput);
+    log(fmt.status('WARN', `Pre-review gate failed for area "${gateResult.area}" (exit ${gateResult.exitCode}). Classification: ${classification.classification}.`));
+    // Build fix prompt with captured gate output
+    const fixPrompt = [
+        `PRE-REVIEW GATE FAILURE — FIX REQUIRED`,
+        ``,
+        `Mission: ${slug}`,
+        `Area: ${gateResult.area}`,
+        `Gate command: ${gateResult.command}`,
+        `Exit code: ${gateResult.exitCode}`,
+        ``,
+        `Gate output (use this to diagnose and fix):`,
+        `---`,
+        gateResult.stdout || '(no stdout)',
+        `---`,
+        gateResult.stderr || '(no stderr)',
+        `---`,
+        ``,
+        `Classification: ${classification.classification} — ${classification.action}`,
+        `Retry attempt: ${retryCount + 1}/${MAX_GATE_RETRY}`,
+        ``,
+        `Fix the underlying issue so the verification gate passes for area "${gateResult.area}".`,
+        `After fixing, the review loop will re-run the gate before the next review round.`,
+    ].join('\n');
+    // Increment retry count in metadata
+    if (!persisted || !persisted.metadata || typeof persisted.metadata !== 'object') {
+        // Create new metadata
+    }
+    const metadata = persisted && persisted.metadata && typeof persisted.metadata === 'object'
+        ? { ...persisted.metadata }
+        : {};
+    metadata.gateFailureRetryCount = retryCount + 1;
+    // Update review state with incremented retry count
+    if (persisted) {
+        const updatedState = { ...persisted, metadata };
+        writeReviewStateFn(slug, updatedState, worktree);
+    }
+    else {
+        writeReviewStateFn(slug, { metadata }, worktree);
+    }
+    // Transition task back to active (implementer phase) without consuming reviewer cycle
+    transitionTaskFn(slug, 'active', { rootDir: worktree, log });
+    log(fmt.status('INFO', `Auto-bouncing to implementer (${implementer}) with fix prompt. Retry ${retryCount + 1}/${MAX_GATE_RETRY}.`));
+    // Launch implementer with the fix prompt
+    try {
+        const launchResult = await startAgentFn('act-on-review', {
+            agent: implementer,
+            prompt: (_actualImplementer) => fixPrompt,
+            worktree,
+            slug,
+            role: 'implementer',
+            exclude: [],
+        });
+        // Apply any agent fallback if needed
+        implementer = applyAgentFallbackFn({
+            role: 'implementer',
+            original: implementer,
+            launchResult,
+            state: persisted || {},
+            slug,
+            worktree,
+            taskResolution,
+            log,
+            writeReviewStateFn,
+            enforceTaskAssigneeFn,
+        });
+    }
+    catch (err) {
+        error(fmt.status('FAIL', `Could not relaunch implementer (${implementer}) for gate failure auto-bounce: ${err.message}`));
+        return { bounced: false, stranded: true };
+    }
+    log(fmt.status('INFO', `Implementer (${implementer}) relaunched with gate failure fix prompt.`));
+    return { bounced: true, stranded: false };
+}
+// ============================================================================
 // Main Review Loop
 // ============================================================================
 async function startReviewLoop(slug, opts = {}) {
-    let { implementer, reviewer, focus = 'all', maxAttempts = DEFAULT_MAX_ATTEMPTS, dryRun = false, reset = false, continue: continueFlag = false, isContinue = false, verbose = false, pollTimeoutSeconds = null, worktree: callerWorktree, missionPath, resetReviewStateFn = review_state_js_1.resetReviewState, maybeUpdateGraphifyBeforeReviewFn = maybeUpdateGraphifyBeforeReview, readReviewStateFn = review_state_js_1.readReviewState, resolveTaskFileFn = backlog_js_1.resolveTaskFile, getTaskImplementerFn = backlog_js_1.getTaskImplementer, getTaskStatusFn = backlog_js_1.getTaskStatus, transitionTaskFn = backlog_js_1.transitionTask, toVirtualFn = state_map_js_1.toVirtual, transitionVirtualFn = state_map_js_1.transitionVirtual, workflowLauncherStatusFn = agents_js_1.workflowLauncherStatus, buildAutonomousReviewMatrixFn = runtime_matrix_js_1.buildAutonomousReviewMatrix, formatMatrixSummaryFn = runtime_matrix_js_1.formatMatrixSummary, selectAgentFn = agents_js_1.selectAgent, providerAvailableFn = undefined, runFn = git_js_1.run, getPrStatusFn = review_adapter_js_1.getPrStatus, enforceTaskAssigneeFn = backlog_js_1.enforceTaskAssignee, resolveReviewUserFn = undefined, forgejoAvailableFn = null, resolveForgejoUserFn = null, readTokenFn = review_adapter_js_1.readToken, getCommentsFn = review_adapter_js_1.getComments, postCommentFn = review_adapter_js_1.postComment, postReviewFn = review_adapter_js_1.postReview, writeReviewStateFn = review_state_js_1.writeReviewState, startAgentFn = agents_js_1.startAgent, pollForReviewFn = review_polling_js_1.pollForReview, pollForDispositionFn = review_polling_js_1.pollForDisposition, applyAgentFallbackFn = applyAgentFallback, buildReviewPromptFn = review_prompts_js_1.buildReviewPrompt, buildActOnReviewPromptFn = review_prompts_js_1.buildActOnReviewPrompt, buildCompactReviewPromptFn = review_prompts_js_1.buildCompactReviewPrompt, buildCompactActOnReviewPromptFn = review_prompts_js_1.buildCompactActOnReviewPrompt, consumeReviewerArtifactsFn = review_artifacts_js_1.consumeReviewerArtifacts, consumeImplementerArtifactsFn = review_artifacts_js_1.consumeImplementerArtifacts, rebaseBeforeReviewRoundFn = rebase_js_1.rebaseBeforeReviewRound, eligibleAgentsForStepFn = agents_js_1.eligibleAgentsForStep, log = fmt.log.plain, error = fmt.log.plainError, getLatestReviewForPrFn = review_adapter_js_1.getLatestReviewForPr, getLatestDispositionForPrFn = review_adapter_js_1.getLatestDispositionForPr, sleepFn = review_polling_js_1.delay, exit = process.exit, gitFn = git_js_1.git, isReviewProviderEnabledFn = undefined, legacyIsForgejoReviewEnabledFn = null, isForgejoReviewEnabledFn = null, recordStageStatsSafeFn = () => { } } = opts;
+    let { implementer, reviewer, focus = 'all', maxAttempts = DEFAULT_MAX_ATTEMPTS, dryRun = false, reset = false, continue: continueFlag = false, isContinue = false, verbose = false, pollTimeoutSeconds = null, worktree: callerWorktree, missionPath, runPreReviewGateFn = runPreReviewGate, handleGateFailureAutoBounceFn = handleGateFailureAutoBounce, resetReviewStateFn = review_state_js_1.resetReviewState, maybeUpdateGraphifyBeforeReviewFn = maybeUpdateGraphifyBeforeReview, readReviewStateFn = review_state_js_1.readReviewState, resolveTaskFileFn = backlog_js_1.resolveTaskFile, getTaskImplementerFn = backlog_js_1.getTaskImplementer, getTaskStatusFn = backlog_js_1.getTaskStatus, transitionTaskFn = backlog_js_1.transitionTask, toVirtualFn = state_map_js_1.toVirtual, transitionVirtualFn = state_map_js_1.transitionVirtual, workflowLauncherStatusFn = agents_js_1.workflowLauncherStatus, buildAutonomousReviewMatrixFn = runtime_matrix_js_1.buildAutonomousReviewMatrix, formatMatrixSummaryFn = runtime_matrix_js_1.formatMatrixSummary, selectAgentFn = agents_js_1.selectAgent, providerAvailableFn = undefined, runFn = git_js_1.run, getPrStatusFn = review_adapter_js_1.getPrStatus, enforceTaskAssigneeFn = backlog_js_1.enforceTaskAssignee, resolveReviewUserFn = undefined, forgejoAvailableFn = null, resolveForgejoUserFn = null, readTokenFn = review_adapter_js_1.readToken, getCommentsFn = review_adapter_js_1.getComments, postCommentFn = review_adapter_js_1.postComment, postReviewFn = review_adapter_js_1.postReview, writeReviewStateFn = review_state_js_1.writeReviewState, startAgentFn = agents_js_1.startAgent, pollForReviewFn = review_polling_js_1.pollForReview, pollForDispositionFn = review_polling_js_1.pollForDisposition, applyAgentFallbackFn = applyAgentFallback, buildReviewPromptFn = review_prompts_js_1.buildReviewPrompt, buildActOnReviewPromptFn = review_prompts_js_1.buildActOnReviewPrompt, buildCompactReviewPromptFn = review_prompts_js_1.buildCompactReviewPrompt, buildCompactActOnReviewPromptFn = review_prompts_js_1.buildCompactActOnReviewPrompt, consumeReviewerArtifactsFn = review_artifacts_js_1.consumeReviewerArtifacts, consumeImplementerArtifactsFn = review_artifacts_js_1.consumeImplementerArtifacts, rebaseBeforeReviewRoundFn = rebase_js_1.rebaseBeforeReviewRound, eligibleAgentsForStepFn = agents_js_1.eligibleAgentsForStep, log = fmt.log.plain, error = fmt.log.plainError, getLatestReviewForPrFn = review_adapter_js_1.getLatestReviewForPr, getLatestDispositionForPrFn = review_adapter_js_1.getLatestDispositionForPr, sleepFn = review_polling_js_1.delay, exit = process.exit, gitFn = git_js_1.git, isReviewProviderEnabledFn = undefined, legacyIsForgejoReviewEnabledFn = null, isForgejoReviewEnabledFn = null, recordStageStatsSafeFn = () => { } } = opts;
     const performHandoffFn = opts.performHandoffFn || (await getHandoff()).performHandoff;
     let prNumber = null;
     isContinue = Boolean(isContinue || continueFlag);
@@ -595,6 +753,30 @@ async function startReviewLoop(slug, opts = {}) {
         if (attempt > state.round) {
             state.advanceRound();
         }
+        // Snapshot the primary branch's HEAD commit for this round. This is a
+        // fallback value only, used for paths that don't rebase this round (a
+        // dry run, or resuming with an existing reviewState): once
+        // rebaseBeforeReviewRoundFn runs below, HEAD is rebased onto primary's
+        // *current* tip, so the baseline is re-captured immediately after the
+        // rebase completes (see below). Capturing it here, before the rebase,
+        // would pin the diff to a stale pre-rebase SHA; since rebase replays
+        // primary's newer commits into HEAD's ancestry, diffing against that
+        // stale SHA would surface exactly the "not rebased to main" noise this
+        // baseline exists to suppress (task-1407).
+        // Falls back to undefined (letting the prompt builders resolve the live
+        // primary branch ref themselves) if the primary branch cannot be detected,
+        // e.g. in a repo with no main/master branch yet.
+        const captureReviewBaseline = () => {
+            try {
+                const primaryBranchName = (0, mission_utils_js_1.getPrimaryBranch)(worktree, gitFn);
+                const reviewBaselineResult = gitFn(['-C', worktree, 'rev-parse', primaryBranchName]);
+                return (reviewBaselineResult.stdout || '').trim() || primaryBranchName;
+            }
+            catch {
+                return undefined;
+            }
+        };
+        let reviewBaseline = captureReviewBaseline();
         let reviewState;
         if (state.phase === 'reviewing') {
             // Check if we can skip reviewer launch
@@ -626,7 +808,7 @@ async function startReviewLoop(slug, opts = {}) {
                     }
                     else {
                         log(`\n--- DRY-RUN: reviewer (${reviewer}) prompt ---`);
-                        log(buildReviewPromptFn({ reviewer: reviewer, branch, implementer: implementer, focus, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualReviewer: '{{AGENT_NAME}}' }));
+                        log(buildReviewPromptFn({ reviewer: reviewer, branch, implementer: implementer, focus, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualReviewer: '{{AGENT_NAME}}', reviewBaseline }));
                     }
                 }
             }
@@ -643,11 +825,58 @@ async function startReviewLoop(slug, opts = {}) {
                         exit(1);
                         return;
                     }
+                    // Re-capture after rebase: HEAD is now rebased onto primary's tip,
+                    // so the pre-rebase snapshot above is stale and must be replaced
+                    // with the SHA that HEAD was actually rebased onto (task-1407).
+                    reviewBaseline = captureReviewBaseline();
                     if (!dryRun) {
                         transitionTaskFn(slug, 'review', { rootDir: worktree, log });
                     }
                     state.phase = 'reviewing';
                     writeReviewStateFn(slug, state, worktree);
+                    // Pre-review gate enforcement (ADR 0048 Control C1 / TASK-1385):
+                    // Run the verification gate before the reviewer launches. On failure,
+                    // auto-bounce to the implementer with captured gate output as fix prompt.
+                    // No reviewer cycle is consumed when the gate fails and auto-bounce occurs.
+                    if (!dryRun) {
+                        const preReviewGateResult = await runPreReviewGateFn(slug, worktree, {
+                            runFn: runFn,
+                            log,
+                            error,
+                        });
+                        if (!preReviewGateResult.ok) {
+                            log(fmt.status('WARN', `Pre-review gate failed for area "${preReviewGateResult.area}" (exit ${preReviewGateResult.exitCode}). Auto-bouncing to implementer.`));
+                            const bounceResult = await handleGateFailureAutoBounceFn(slug, worktree, preReviewGateResult, implementer, {
+                                startAgentFn: startAgentFn,
+                                writeReviewStateFn: writeReviewStateFn,
+                                readReviewStateFn: readReviewStateFn,
+                                transitionTaskFn: transitionTaskFn,
+                                applyAgentFallbackFn: applyAgentFallbackFn,
+                                taskResolution,
+                                enforceTaskAssigneeFn,
+                                log,
+                                error,
+                                sleepFn,
+                                buildCompactActOnReviewPromptFn,
+                                isForgejoReviewEnabledFn,
+                                isReviewProviderEnabledFn,
+                                legacyIsForgejoReviewEnabledFn,
+                                exit,
+                            });
+                            if (bounceResult.stranded) {
+                                error(fmt.status('FAIL', `Pre-review gate failure stranded mission ${slug}. Exiting review loop.`));
+                                exit(1);
+                                return;
+                            }
+                            if (bounceResult.bounced) {
+                                log(fmt.status('INFO', `Auto-bounce succeeded. Continuing to next round.`));
+                                continue;
+                            }
+                        }
+                        else {
+                            log(fmt.status('PASS', `Pre-review gate passed for area "${preReviewGateResult.area}".`));
+                        }
+                    }
                     if (reviewer === 'autonomous' && !forgejoEnabled) {
                         log(fmt.status('INFO', `Round ${attempt}: reviewer identity is autonomous; skipping reviewer launch and using local review artifacts only.`));
                     }
@@ -657,7 +886,7 @@ async function startReviewLoop(slug, opts = {}) {
                         try {
                             reviewerLaunchResult = await startAgentFn('review', {
                                 agent: reviewer,
-                                prompt: (actualReviewer) => buildCompactReviewPromptFn({ reviewer: reviewer, branch, implementer: implementer, focus, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualReviewer }),
+                                prompt: (actualReviewer) => buildCompactReviewPromptFn({ reviewer: reviewer, branch, implementer: implementer, focus, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualReviewer, reviewBaseline }),
                                 worktree, slug, role: 'reviewer', exclude: [implementer]
                             });
                         }
@@ -722,7 +951,7 @@ async function startReviewLoop(slug, opts = {}) {
                         try {
                             relaunchResult = await startAgentFn('review', {
                                 agent: reviewer,
-                                prompt: (actualReviewer) => buildCompactReviewPromptFn({ reviewer: reviewer, branch, implementer: implementer, focus, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualReviewer }) + '\n\n' + recoveryPrompt,
+                                prompt: (actualReviewer) => buildCompactReviewPromptFn({ reviewer: reviewer, branch, implementer: implementer, focus, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualReviewer, reviewBaseline }) + '\n\n' + recoveryPrompt,
                                 worktree, slug, role: 'reviewer', exclude: [implementer]
                             });
                         }
@@ -864,7 +1093,7 @@ async function startReviewLoop(slug, opts = {}) {
             // First launch or re-launch after stale BLOCKED/PARKED
             if (dryRun) {
                 log(`\n--- DRY-RUN: implementer (${implementer}) act-on-review prompt ---`);
-                log(buildActOnReviewPromptFn({ implementer: implementer, branch, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualImplementer: '{{AGENT_NAME}}' }));
+                log(buildActOnReviewPromptFn({ implementer: implementer, branch, attempt, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualImplementer: '{{AGENT_NAME}}', reviewBaseline }));
                 if (reLaunch) {
                     log(fmt.status('INFO', `Round ${attempt}: stale BLOCKED/PARKED disposition replaced by fresh implementer action.`));
                 }
@@ -881,7 +1110,7 @@ async function startReviewLoop(slug, opts = {}) {
                 try {
                     implementerLaunchResult = await startAgentFn('act-on-review', {
                         agent: implementer,
-                        prompt: (actualImplementer) => buildCompactActOnReviewPromptFn({ implementer: implementer, branch, attempt, reviewOutcome: reviewState, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualImplementer }),
+                        prompt: (actualImplementer) => buildCompactActOnReviewPromptFn({ implementer: implementer, branch, attempt, reviewOutcome: reviewState, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualImplementer, reviewBaseline }),
                         worktree, slug, role: 'implementer', exclude: [reviewer]
                     });
                 }
@@ -943,7 +1172,7 @@ async function startReviewLoop(slug, opts = {}) {
                     try {
                         relaunchResult = await startAgentFn('act-on-review', {
                             agent: implementer,
-                            prompt: (actualImplementer) => buildCompactActOnReviewPromptFn({ implementer: implementer, branch, attempt, reviewOutcome: reviewState, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualImplementer }) + '\n\n' + recoveryPrompt,
+                            prompt: (actualImplementer) => buildCompactActOnReviewPromptFn({ implementer: implementer, branch, attempt, reviewOutcome: reviewState, repoRoot: worktree, missionPath: effectiveMissionPath || undefined, actualImplementer, reviewBaseline }) + '\n\n' + recoveryPrompt,
                             worktree, slug, role: 'implementer', exclude: [reviewer]
                         });
                     }