@magnusekdahl/parallix 1.3.3 → 1.3.4

package/lib/commands/stats.ts

@@ -28,11 +28,6 @@ interface StatsOptions {
   exit?: Function;
 }
 
-interface CsvData {
-  headers: string[];
-  rows: Record<string, string>[];
-}
-
 interface NormalizeStatsRowOptions {
   repo?: string;
   rootDir?: string;
@@ -42,67 +37,6 @@ interface LoadStatsCsvOptions {
   rootDir?: string;
 }
 
-interface TelemetryToStatsOptions {
-  agentFamily: string;
-  durationMinutes?: number;
-  model?: string;
-}
-
-interface UpsertStatsRowOptions {
-  filePath?: string;
-  rootDir?: string;
-}
-
-interface RecordStageStatsOptions {
-  slug: string;
-  stage: string;
-  rootDir?: string;
-  filePath?: string;
-  date?: string;
-  implementer?: string;
-  reviewer?: string;
-  prFixRounds?: string;
-  telemetry?: unknown;
-  durationMinutes?: number;
-  model?: string | null;
-}
-
-interface RecordIntegrationStatsOptions {
-  slug: string;
-  rootDir?: string;
-  filePath?: string;
-  date?: string;
-}
-
-interface RecordActiveStatsOptions {
-  stage?: string;
-  slug: string;
-  rootDir?: string;
-  prFixRounds?: string;
-  model?: string;
-}
-
-interface RecordReviewStatsOptions {
-  stage?: string;
-  slug: string;
-  rootDir?: string;
-  reviewer?: string;
-  implementer?: string;
-  prFixRounds?: string;
-  model?: string;
-}
-
-interface RenderWeeklyStatsReportOptions {
-  today?: Date | string;
-  rootDir?: string | null;
-}
-
-interface RenderRangeStatsReportOptions {
-  rootDir?: string | null;
-  from?: string;
-  to?: string;
-}
-
 interface StatsRow {
   date?: string;
   repo?: string;
@@ -137,16 +71,6 @@ interface StatsRow {
   missions?: number;
 }
 
-interface MissionStats {
-  implementer: string;
-  missions: number;
-  averageFixRounds: string;
-}
-
-interface AccModeOptions {
-  mode?: 'sum' | 'max' | 'replace';
-}
-
 interface StatsCsvPathOptions {
   filePath?: string;
   rootDir?: string;
@@ -154,14 +78,6 @@ interface StatsCsvPathOptions {
   forWrite?: boolean;
 }
 
-interface StatsCmdOptions {
-  log?: Function;
-  error?: Function;
-  exit?: Function;
-  rootDir?: string;
-}
-
-
 import * as fs from 'node:fs';
 import * as path from 'node:path';
 
@@ -172,7 +88,7 @@ import { readReviewState } from '../review/review-state.js';
 import * as reviewEvents from '../review/review-events.js';
 import { git } from '../core/git.js';
 import { migrateStats } from '../core/persistent-data-migration.js';
-import { getPrimaryWorktree, findMissionDir } from '../core/mission-utils.js';
+import { findMissionDir } from '../core/mission-utils.js';
 import * as forgejo from '../tools/forgejo.js';
 import * as storage from '../core/storage.js';
 
@@ -180,16 +96,19 @@ import * as storage from '../core/storage.js';
 // and one-time header migration of legacy stats files (task-1251).
 const LEGACY_HEADERS = ['date', 'mission', 'classification', 'implementer', 'pr_fix_rounds'];
 
-// Extended 21-column telemetry schema (task-1314 + task-1251). Legacy 5-column rows are
-// migrated in-memory on load: the legacy columns are preserved and the new
-// columns default to '' (text) or '0' (numeric). On the next write the file
-// header is upgraded and existing rows gain the new columns.
+// Extended 22-column telemetry schema (task-1314 + task-1251 + task-1380). Legacy
+// 5-column rows are migrated in-memory on load: the legacy columns are preserved
+// and the new columns default to '' (text) or '0' (numeric). On the next write the
+// file header is upgraded and existing rows gain the new columns. The `closed`
+// column (task-1380) stores 'yes' for closed/integrated missions and is empty for
+// in-progress stage rows; filtering by `closed === 'yes'` excludes in-progress
+// missions from weekly and range mission counts.
 const STATS_HEADERS = [
   'date', 'repo', 'mission', 'classification', 'implementer', 'pr_fix_rounds',
   'provider', 'model', 'implementer_agent', 'reviewer_agent', 'stage',
   'input_tokens', 'output_tokens', 'cached_tokens', 'context_tokens',
   'tool_calls', 'openai_usage_before', 'openai_usage_after',
-  'openai_usage_delta', 'duration_minutes', 'cost_usd'
+  'openai_usage_delta', 'duration_minutes', 'cost_usd', 'closed'
 ];
 
 // Columns coerced to non-negative integers on canonicalization.
@@ -382,9 +301,23 @@ function loadStatsCsv(filePath: string | null = null, options: LoadStatsCsvOptio
     return { headers: [...STATS_HEADERS], rows: [] };
   }
 
+  // Detect whether the loaded CSV already has the `closed` column (task-1380).
+  // Legacy CSVs (pre-closed) lack the column; their rows represent completed
+  // missions written at integration time, so default `closed` to 'yes' for
+  // backward compatibility. Modern CSVs already have the column set per-row.
+  const hasClosedColumn = data.headers.includes('closed');
+  const migratedRows = data.rows.map((row: Record<string, string>) => {
+    const normalized = normalizeStatsRow(row, { rootDir: options.rootDir });
+    if (!hasClosedColumn) {
+      // Legacy CSV: all rows are from integration time, treat as closed.
+      return { ...normalized, closed: 'yes' };
+    }
+    return { ...normalized, closed: row.closed || '' };
+  });
+
   return {
     headers: [...STATS_HEADERS],
-    rows: data.rows.map((row: Record<string, string>) => normalizeStatsRow(row, { rootDir: options.rootDir })),
+    rows: migratedRows,
   };
 }
 
@@ -393,7 +326,8 @@ function loadStatsCsv(filePath: string | null = null, options: LoadStatsCsvOptio
  * Map any row (legacy 5-column or full 21-column) to the full schema, defaulting
  * missing text columns to '' and numeric columns to '0'. `stage` defaults to
  * 'default' so legacy rows and integration rows share the (repo, mission, stage)
- * upsert key.
+ * upsert key. `closed` defaults to '' (unset) — the backward-compat default of
+ * 'yes' for legacy CSV rows is applied exclusively in `loadStatsCsv`.
  */
 function normalizeStatsRow(row: StatsRow = {} as StatsRow, options: NormalizeStatsRowOptions = {} as NormalizeStatsRowOptions) {
   const repo = String(row.repo || options.repo || resolveStatsRepoName(options.rootDir)).trim();
@@ -419,6 +353,7 @@ function normalizeStatsRow(row: StatsRow = {} as StatsRow, options: NormalizeSta
     openai_usage_delta: row.openai_usage_delta || '0',
     duration_minutes: row.duration_minutes || '0',
     cost_usd: row.cost_usd || '0',
+    closed: row.closed || '',
   };
 }
 
@@ -819,11 +754,14 @@ function rowInWindow(row, window) {
  */
 function summarizeMissionWindow(rows, window) {
   const windowRows = rows.filter(row => rowInWindow(row, window));
+  // Filter to only closed missions (task-1380): rows without closed:'yes' are
+  // in-progress stage rows and should not inflate mission counts.
+  const closedRows = windowRows.filter(row => row.closed === 'yes');
   // Deduplicate by mission so multi-stage telemetry rows don't inflate counts.
   // One row per unique repo+mission pair is kept (first occurrence is sufficient
   // since classification is stable across stages for the same mission in a repo).
   const seenMissions = new Set();
-  const uniqueMissions = windowRows.filter(row => {
+  const uniqueMissions = closedRows.filter(row => {
     const key = statsMissionKey(row);
     if (seenMissions.has(key)) {return false;}
     seenMissions.add(key);
@@ -834,7 +772,7 @@ function summarizeMissionWindow(rows, window) {
   const unknown = uniqueMissions.filter(row => normalizeClassification(row.classification) === 'unknown').length;
   const validMissions = uniqueMissions.filter(row => normalizeClassification(row.classification) !== null);
   return {
-    rows: windowRows,
+    rows: closedRows,
     total: validMissions.length,
     userValue,
     aiSdlc,
@@ -882,10 +820,12 @@ function summarizeAgentWindow(rows, window, options = {}) {
   const opts = options;
   const { rootDir = null, deriveFixRoundsFn = deriveFixRoundsLocalAuthoritative } = opts;
   const windowRows = rows.filter(row => rowInWindow(row, window));
+  // Filter to only closed missions (task-1380).
+  const closedWindowRows = windowRows.filter(row => row.closed === 'yes');
   // Only count missions with a valid classification so the agent table totals
   // align with the mission-count table (which also excludes null/invalid
   // classifications via summarizeMissionWindow → validMissions).
-  const validWindowRows = windowRows.filter(row => normalizeClassification(row.classification) !== null);
+  const validWindowRows = closedWindowRows.filter(row => normalizeClassification(row.classification) !== null);
   // Deduplicate globally by (repo, mission) first so each mission is counted
   // exactly once across all agent groups — matching the mission-count table.
   // Prefer the row where model === implementer (the implementer's own model),
@@ -1139,7 +1079,8 @@ function renderMissionPhaseReport(rows, slug, options = {}) {
   const wantedRepo = String(opts.repo || resolveStatsRepoName(opts.rootDir)).trim();
   const missionRows = (rows || []).filter(row =>
     String(row.mission || '').trim().toLowerCase() === wanted &&
-    String(row.repo || '').trim() === wantedRepo
+    String(row.repo || '').trim() === wantedRepo &&
+    row.closed === 'yes'
   );
 
   const byStage = new Map();
@@ -1620,6 +1561,7 @@ function canonicalizeStatsRow(row, options = {}) {
     classification: /** @type{string|number|boolean|undefined} */(normalizeClassification(row.classification)),
     implementer: /** @type{string|number|boolean|undefined} */(normalizeImplementer(row.implementer)),
     stage: String(row.stage || '').trim().toLowerCase() || 'default',
+    closed: row.closed || '',
   };
   for (const key of USAGE_NUMBERS) {
     canonical[key] = String(Math.max(0, Number.parseInt(String(/** @type{any} */(normalized)[key]), 10) || 0));
@@ -1709,6 +1651,7 @@ function recordIntegrationStats(options = {}) {
     classification,
     implementer: implementerInfo.implementer,
     pr_fix_rounds: implementerInfo.prFixRounds,
+    closed: 'yes',
   }, { filePath, rootDir });
 
   return {
@@ -2184,6 +2127,7 @@ if (typeof module !== 'undefined') { module.exports = stats; }
   deriveFinalImplementerFromBranchHistory,
   deriveImplementerAndFixRoundsFromPrComments,
   deriveImplementerAndFixRounds,
+  summarizeMissionWindow,
   summarizeAgentWindow,
   colorAverageFixRounds,
   colorMissionCounts,

package/lib/core/fmt.ts

@@ -98,8 +98,8 @@ export function branch(text: string): string { return colorize('magenta', text);
 export function sha(text: string): string { return colorize('yellow', text); }
 export function command(text: string): string { return colorize('green', text); }
 
-type LogFn = (...args: unknown[]) => void;
-type LogFunc = (text: string) => string | null;
+type LogFn = (..._args: unknown[]) => void;
+type LogFunc = (_text: string) => string | null;
 
 type Logger = {
   log: LogFn;

package/lib/core/git.ts

@@ -1,4 +1,4 @@
-import childProcess, { spawnSync } from 'node:child_process';
+import { spawnSync } from 'node:child_process';
 import type { SpawnSyncOptions } from 'node:child_process';
 import * as fsMod from 'node:fs';
 import * as pathMod from 'node:path';
@@ -90,7 +90,7 @@ interface RebaseStateResult {
 }
 
 interface GitRunner {
-  (args: string[]): GitResult;
+  (_args: string[]): GitResult;
 }
 
 interface DetectRebaseOptions {

package/lib/core/gitignore.ts

@@ -24,11 +24,11 @@ interface EnsureOptions {
   lstatSyncFn?: typeof fs.lstatSync;
   readFileSyncFn?: typeof fs.readFileSync;
   writeFileSyncFn?: typeof fs.writeFileSync;
-  logFn?: (msg: string) => void;
+  logFn?: (_msg: string) => void;
 }
 
 type EnsureWorkflowGitignoreFn = {
-  (rootDir: string, options?: EnsureOptions): GitignoreResult;
+  (_rootDir: string, _options?: EnsureOptions): GitignoreResult;
   WORKFLOW_ENTRIES: typeof WORKFLOW_ENTRIES;
   ensureWorkflowGitignore: EnsureWorkflowGitignoreFn;
 };

package/lib/core/mission-utils.js

@@ -986,7 +986,7 @@ function findMissionDocInBranches(slug, rootDir = process.cwd(), gitRunner) {
             return candidates;
         }
     }
-    catch (e) {
+    catch (_e) {
         return candidates;
     }
     const branches = branchResult.stdout.trim().split('\n')
@@ -1002,7 +1002,7 @@ function findMissionDocInBranches(slug, rootDir = process.cwd(), gitRunner) {
                     break;
                 }
             }
-            catch (err) {
+            catch (_err) {
                 // ignore
             }
         }

package/lib/core/mission-utils.ts

@@ -929,7 +929,7 @@ export function findMissionDocInBranches(slug: string, rootDir: string = process
   try {
     branchResult = runner(['-C', rootDir, 'branch', '-a', '--format=%(refname:short)']);
     if (branchResult.status !== 0) {return candidates;}
-  } catch (e) {
+  } catch (_e) {
     return candidates;
   }
 
@@ -946,7 +946,7 @@ export function findMissionDocInBranches(slug: string, rootDir: string = process
           candidates.push({ branch, path: f });
           break;
         }
-      } catch (err) {
+      } catch (_err) {
         // ignore
       }
     }

package/lib/core/persistent-data-migration.ts

@@ -176,7 +176,7 @@ function migrateStats(options: { sourcePaths?: string[]; sourcePath?: string; de
 
 interface BlocklistSource { filePath: string; payload: Record<string, unknown>; blocklist: Record<string, unknown>; }
 
-function readBlocklistSource(filePath: string, warn: (...args: unknown[]) => void, hardFailure = false): BlocklistSource | null {
+function readBlocklistSource(filePath: string, warn: (..._args: unknown[]) => void, hardFailure = false): BlocklistSource | null {
   if (!filePath || !fs.existsSync(filePath)) {return null;}
   try {
     const payload = JSON.parse(fs.readFileSync(filePath, 'utf8')) as Record<string, unknown>;
@@ -208,7 +208,7 @@ function sameValue(left: unknown, right: unknown): boolean {
  * @param options - Migration configuration (warn callback, destinationPath, sourcePaths)
  * @returns Result with destination path, merged blocklist, and conflict details
  */
-function migrateAgentBlocklists(options: { warn?: (...args: unknown[]) => void; destinationPath?: string; sourcePaths?: string[] } = {}): { destinationPath: string; blocklist: Record<string, unknown>; conflicts: unknown[] } {
+function migrateAgentBlocklists(options: { warn?: (..._args: unknown[]) => void; destinationPath?: string; sourcePaths?: string[] } = {}): { destinationPath: string; blocklist: Record<string, unknown>; conflicts: unknown[] } {
   const opts = options;
   const warn = opts.warn || (() => {});
   const destinationPath = opts.destinationPath || storage.resolveAgentsLocalPath({ ensureDir: true });

package/lib/core/spawn-tee.ts

@@ -17,7 +17,7 @@ interface SpawnTeeResult {
 }
 
 interface NoOutputWatchdog {
-  onNoOutput?: (event: { command: string; args: string[]; pid: number | undefined; elapsedMs: number }) => void;
+  onNoOutput?: (_event: { command: string; args: string[]; pid: number | undefined; elapsedMs: number }) => void;
   initialDelayMs?: number;
   intervalMs?: number;
 }

package/lib/core/state-map.ts

@@ -81,11 +81,11 @@ export function toVirtual(actualState: string, map: Record<string, unknown> = lo
 }
 
 interface TransitionVirtualOptions {
-  log?: (msg: string) => void;
+  log?: (_msg: string) => void;
 }
 
 interface TransitionTaskFn {
-  (slug: string, actual: string, options: TransitionVirtualOptions): boolean;
+  (_slug: string, _actual: string, _options: TransitionVirtualOptions): boolean;
 }
 
 export function transitionVirtual(transitionTaskFn: TransitionTaskFn, slug: string, virtualState: string, options: TransitionVirtualOptions = {}, mapParam?: Record<string, unknown>): boolean {

package/lib/core/storage.ts

@@ -89,7 +89,7 @@ export function resolveParallixHome(
  */
 export interface ResolveStatsOptions {
   ensureDir?: boolean;
-  warn?: (...args: unknown[]) => void;
+  warn?: (..._args: unknown[]) => void;
 }
 
 export function resolveStatsPath(options: ResolveStatsOptions = {}): string {

package/lib/core/verification.ts

@@ -21,7 +21,7 @@ interface GitResult {
   error?: Error | null;
 }
 
-export type GitFn = (args: string[], options?: GitOptions) => GitResult;
+export type GitFn = (_args: string[], _options?: GitOptions) => GitResult;
 
 export interface VerificationAdapterConfig {
   command: string | null;

package/lib/review/rebase.ts

@@ -14,7 +14,7 @@ import { resolveWorktree, isMissionArtifact, isWorkflowGeneratedArtifact } from
 import { isProviderEnabled } from './review-adapter.js';
 import { spawnSync } from 'child_process';
 
-type RunFn = (cmd: string, args: string[], opts: { cwd?: string; encoding?: string; stdio?: unknown[] }) => { status: number | null; stdout?: string; stderr?: string };
+type RunFn = (_cmd: string, _args: string[], _opts: { cwd?: string; encoding?: string; stdio?: unknown[] }) => { status: number | null; stdout?: string; stderr?: string };
 
 const _spawnSync = spawnSync as unknown as RunFn;
 
@@ -39,11 +39,11 @@ export async function commitSafeMissionArtifacts(slug: string, worktree: string,
 }: {
   taskFile?: string | null;
   gitFn?: typeof git;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
-  isMissionArtifactFn?: (file: string, slug: string, rootDir: string) => boolean;
-  isWorkflowGeneratedArtifactFn?: (file: string) => boolean;
-  resolveStatsRelPathFn?: (rootDir: string) => string | null;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
+  isMissionArtifactFn?: (_file: string, _slug: string, _rootDir: string) => boolean;
+  isWorkflowGeneratedArtifactFn?: (_file: string) => boolean;
+  resolveStatsRelPathFn?: (_rootDir: string) => string | null;
 } = {}): Promise<{ ok: boolean; dirty: boolean; unsafe?: boolean }> {
   const rootDir = worktree || process.cwd();
   const statusResult = gitFn(['-C', rootDir, 'status', '--porcelain=v1', '-z']);
@@ -131,15 +131,15 @@ export async function rebaseBeforeReviewRound(slug: string, {
   legacyIsForgejoReviewEnabledFn = null,
   isForgejoReviewEnabledFn = null
 }: {
-  runFn?: (cmd: string, args: string[], opts: { cwd?: string; encoding?: string; stdio?: unknown[] }) => { status: number | null; stdout?: string; stderr?: string };
+  runFn?: (_cmd: string, _args: string[], _opts: { cwd?: string; encoding?: string; stdio?: unknown[] }) => { status: number | null; stdout?: string; stderr?: string };
   gitFn?: typeof git;
   taskFile?: string | null;
   worktree?: string;
-  log?: (msg: string) => void;
-  error?: (msg: string) => void;
-  isReviewProviderEnabledFn?: ((wt: string) => boolean) | undefined | null;
-  legacyIsForgejoReviewEnabledFn?: ((wt: string) => boolean) | null;
-  isForgejoReviewEnabledFn?: ((wt: string) => boolean) | null;
+  log?: (_msg: string) => void;
+  error?: (_msg: string) => void;
+  isReviewProviderEnabledFn?: ((_wt: string) => boolean) | undefined | null;
+  legacyIsForgejoReviewEnabledFn?: ((_wt: string) => boolean) | null;
+  isForgejoReviewEnabledFn?: ((_wt: string) => boolean) | null;
 } = {}): Promise<{ ok: boolean; sharedFileConflicts: boolean }> {
   const cleanup = await commitSafeMissionArtifacts(slug, worktree, { taskFile, gitFn, log, error });
   if (!cleanup.ok) {

package/lib/review/review-artifacts.ts

@@ -102,12 +102,12 @@ function postWorkflowComment(
   slug: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    readTokenFn?: (user: string, opts: { rootDir?: string }) => string | null;
-    postCommentFn?: (branch: string, token: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    readReviewStateFn?: (s: string, r?: string) => any;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    readTokenFn?: (_user: string, _opts: { rootDir?: string }) => string | null;
+    postCommentFn?: (_branch: string, _token: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    readReviewStateFn?: (_s: string, _r?: string) => any;
     rootDir?: string;
     reviewIdentity?: string;
     forgejoUser?: string;
@@ -172,11 +172,11 @@ function recordLocalReviewVerdict(
   outcome: string,
   options: {
     worktree?: string;
-    writeReviewStateFn?: (s: string, st: any, w: string) => boolean;
-    createEventFn?: (s: string, t: string, p: Record<string, unknown>, o: Record<string, unknown>) => CreateResult;
-    readReviewStateFn?: (s: string, r?: string) => any;
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    writeReviewStateFn?: (_s: string, _st: any, _w: string) => boolean;
+    createEventFn?: (_s: string, _t: string, _p: Record<string, unknown>, _o: Record<string, unknown>) => CreateResult;
+    readReviewStateFn?: (_s: string, _r?: string) => any;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     reviewer?: string;
   } = {}
 ): void {
@@ -216,18 +216,18 @@ function postWorkflowReview(
   outcome: string,
   message: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
-    readTokenFn?: (user: string, opts: { rootDir?: string }) => string | null;
-    postReviewFn?: (branch: string, token: string, outcome: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    readReviewStateFn?: (s: string, r?: string) => any;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
+    readTokenFn?: (_user: string, _opts: { rootDir?: string }) => string | null;
+    postReviewFn?: (_branch: string, _token: string, _outcome: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    readReviewStateFn?: (_s: string, _r?: string) => any;
     worktree?: string;
     reviewIdentity?: string;
     forgejoUser?: string;
-    getPrAuthorFn?: (branch: string, token: string, opts?: Record<string, unknown>) => unknown;
-    writeReviewStateFn?: (s: string, st: any, w: string) => boolean;
-    createEventFn?: (s: string, t: string, p: Record<string, unknown>, o: Record<string, unknown>) => CreateResult;
+    getPrAuthorFn?: (_branch: string, _token: string, _opts?: Record<string, unknown>) => unknown;
+    writeReviewStateFn?: (_s: string, _st: any, _w: string) => boolean;
+    createEventFn?: (_s: string, _t: string, _p: Record<string, unknown>, _o: Record<string, unknown>) => CreateResult;
   } = {}
 ): { ok: boolean; error?: string; skipped?: boolean; reason?: string; prAuthor?: unknown } {
   const log = options.log || fmt.log.plain;
@@ -292,8 +292,8 @@ async function consumeReviewerArtifacts(
   slug: string,
   reviewer: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     readArtifactFn?: typeof readArtifactFile;
     deleteArtifactFn?: typeof deleteArtifactFile;
     tmpDir?: string | null;
@@ -301,12 +301,12 @@ async function consumeReviewerArtifacts(
     worktree?: string;
     providerEnabled?: boolean | null;
     forgejoEnabled?: boolean | null;
-    readTokenFn?: (user: string, opts?: Record<string, unknown>) => string | null;
-    getCommentsFn?: (branch: string, token: string) => Promise<unknown[]>;
-    postCommentFn?: (branch: string, token: string, body: string, opts?: Record<string, unknown>) => unknown;
-    postReviewFn?: (branch: string, token: string, outcome: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    createEventFn?: (s: string, t: string, p: CreateEventParams, o: CreateEventOptions) => CreateEventResult;
+    readTokenFn?: (_user: string, _opts?: Record<string, unknown>) => string | null;
+    getCommentsFn?: (_branch: string, _token: string) => Promise<unknown[]>;
+    postCommentFn?: (_branch: string, _token: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    postReviewFn?: (_branch: string, _token: string, _outcome: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    createEventFn?: (_s: string, _t: string, _p: CreateEventParams, _o: CreateEventOptions) => CreateEventResult;
   } = {}
 ): Promise<{ consumed: boolean; ok?: boolean; reviewState?: string | null }> {
   const log = options.log || fmt.log.plain;
@@ -452,8 +452,8 @@ async function consumeImplementerArtifacts(
   slug: string,
   implementer: string,
   options: {
-    log?: (msg: string) => void;
-    error?: (msg: string) => void;
+    log?: (_msg: string) => void;
+    error?: (_msg: string) => void;
     readArtifactFn?: typeof readArtifactFile;
     deleteArtifactFn?: typeof deleteArtifactFile;
     tmpDir?: string | null;
@@ -461,11 +461,11 @@ async function consumeImplementerArtifacts(
     worktree?: string;
     providerEnabled?: boolean | null;
     forgejoEnabled?: boolean | null;
-    readTokenFn?: (user: string, opts?: Record<string, unknown>) => string | null;
-    getCommentsFn?: (branch: string, token: string) => Promise<unknown[]>;
-    postCommentFn?: (branch: string, token: string, body: string, opts?: Record<string, unknown>) => unknown;
-    buildMetadataFooterFn?: (s: string, r?: string) => string;
-    createEventFn?: (s: string, t: string, p: CreateEventParams, o: CreateEventOptions) => CreateEventResult;
+    readTokenFn?: (_user: string, _opts?: Record<string, unknown>) => string | null;
+    getCommentsFn?: (_branch: string, _token: string) => Promise<unknown[]>;
+    postCommentFn?: (_branch: string, _token: string, _body: string, _opts?: Record<string, unknown>) => unknown;
+    buildMetadataFooterFn?: (_s: string, _r?: string) => string;
+    createEventFn?: (_s: string, _t: string, _p: CreateEventParams, _o: CreateEventOptions) => CreateEventResult;
   } = {}
 ): Promise<{ consumed: boolean; ok?: boolean; disposition?: string | null }> {
   const log = options.log || fmt.log.plain;