@m13v/s4l 1.7.5-rc.2 → 1.7.5-rc.21

package/scripts/release-mcpb.sh

@@ -187,6 +187,23 @@ fi
 
 command -v mcpb >/dev/null || die "mcpb CLI not found (npm i -g @anthropic-ai/mcpb)"
 
+# ---- 0b. Regression gate: no silent-fallback / bare-python3 reintroductions --
+# scripts/test_no_silent_fallbacks.py locks in two recurring bug classes that
+# have separately shipped to customers more than once (X handle -> hardcoded
+# "m13v_" impersonation, DEFAULT_ACCOUNTS, and bare "python3" subprocess spawns
+# of Playwright-dependent scripts silently dying on a fresh install with no
+# Playwright on PATH -- see bug_twitter_reply_bare_python3_no_playwright.md
+# and bug_twitter_handle_scrape_brittle_m13v_fallback.md). Runs BEFORE any
+# build/pack/publish work so a regression blocks the release, not a customer.
+# Applies to every path that actually builds a new artifact (stable + both
+# --staging and default runs); --promote ships an already-tested artifact
+# byte-for-byte with no rebuild, so it's exempt (handled in step 0 above,
+# which exits before reaching here) -- that artifact already passed this gate
+# when it was first built.
+say "Regression gate: scripts/test_no_silent_fallbacks.py"
+python3 "$REPO_ROOT/scripts/test_no_silent_fallbacks.py" \
+  || die "regression gate failed -- a silent-fallback / bare-python3 issue was (re)introduced. See output above; do not release until it's clean or the finding is reviewed into the test's ALLOWLIST with a reason."
+
 # ---- 1. Resolve + WRITE version into the repo-root package.json -------------
 # The repo-root package.json is the SINGLE source of truth: `npm pack` reads it
 # to build the embedded pipeline.tgz, so the bundle shell and the bundled

package/scripts/reset-test-machine.sh

@@ -304,12 +304,18 @@ fi
 echo
 
 # ---- 1c. Claude Desktop scheduled tasks -----------------------------------
-# Onboarding creates the queue-worker tasks (and historically the deprecated
-# single autopilot) under ~/.claude/scheduled-tasks/. They live OUTSIDE the
-# state dir, so a reset that skips them leaves idle workers firing every minute
-# against a wiped install. Remove the task dirs. Like the .mcpb registry, the
-# host (Claude Desktop) owns the live schedule and rewrites it on quit. Step [0]
-# already quit it; this warns only if it came back (--keep-claude / relaunch).
+# Onboarding creates the queue-worker task (current installs: the universal
+# `s4l-worker`; legacy installs: `saps-worker`/`saps-phase1-query`/
+# `saps-phase2b-draft`/the deprecated single `social-autoposter-autopilot`)
+# under ~/.claude/scheduled-tasks/. They live OUTSIDE the state dir, so a
+# reset that skips them leaves idle workers firing every minute against a
+# wiped install. TASK_IDS must be kept in sync with WORKER_TASK_IDS in
+# s4l_menubar.py / schedule_state.py / scheduled_tasks_snapshot.py — this list
+# went stale after the `s4l-worker` rename (2026-07-02) and every "deep reset"
+# since then silently left the live task running (found 2026-07-15). Like the
+# .mcpb registry, the host (Claude Desktop) owns the live schedule and
+# rewrites it on quit. Step [0] already quit it; this warns only if it came
+# back (--keep-claude / relaunch).
 echo "[1c] Claude Desktop scheduled tasks (queue workers + deprecated autopilot)"
 SCHED_DIR="$HOME_DIR/.claude/scheduled-tasks"
 if pgrep -x "Claude" >/dev/null 2>&1; then
@@ -322,7 +328,7 @@ if [ -d "$SCHED_DIR" ]; then
     [ -e "$d" ] && TASK_IDS+=("$(basename "$d")")
   done
 fi
-for t in saps-phase1-query saps-phase2b-draft social-autoposter-autopilot; do
+for t in s4l-worker saps-worker saps-phase1-query saps-phase2b-draft social-autoposter-autopilot; do
   TASK_IDS+=("$t")
 done
 if [ "${#TASK_IDS[@]}" -gt 0 ]; then

package/scripts/scan_twitter_thread_followups.py

@@ -65,6 +65,12 @@ DEFAULT_MAX_URLS = 40
 REPO_DIR = os.path.expanduser("~/social-autoposter")
 REPLY_PAGE_LIMIT = 500
 
+# Pinned interpreter, never the literal "python3": twitter_browser.py (below)
+# imports Playwright, and bare "python3" resolves to the caller's system
+# Python on PATH, which has no Playwright on a fresh install (silent
+# failure). See scripts/twitter_post_plan.py:131.
+PYTHON = os.environ.get("S4L_PYTHON") or sys.executable
+
 
 def load_config():
     if os.path.exists(CONFIG_PATH):
@@ -137,7 +143,7 @@ def run_browser_scrape(urls, scroll_count=3):
             f.write(u + "\n")
     try:
         proc = subprocess.run(
-            ["python3", os.path.join(REPO_DIR, "scripts/twitter_browser.py"),
+            [PYTHON, os.path.join(REPO_DIR, "scripts/twitter_browser.py"),
              "thread-followups", urls_path, str(scroll_count)],
             capture_output=True, text=True, timeout=1800,
         )

package/scripts/schedule_state.py

@@ -110,7 +110,7 @@ HEALTHY_DRAIN_MAX_SECONDS = 1200
 # (an idle queue has no pending job at all, so a quiet pipeline never trips it).
 STALL_SECONDS = HEALTHY_DRAIN_MAX_SECONDS
 # A job claimed but still sitting in running/ this long: the worker picked it up
-# and then wedged mid-run (the claude -p drafting child died / never spawned).
+# and then wedged mid-run.
 RUNNING_STALL_SECONDS = HEALTHY_DRAIN_MAX_SECONDS
 # The producer's "drafting Nm" label alive this long: the end-to-end clock. This
 # is the only timer that spans claim→die→requeue churn loops, which reset the two