@m13v/s4l 1.7.5-rc.2 → 1.7.5-rc.21

package/mcp/manifest.json

@@ -2,7 +2,7 @@
   "dxt_version": "0.1",
   "name": "social-autoposter",
   "display_name": "S4L",
-  "version": "1.7.5-rc.2",
+  "version": "1.7.5-rc.21",
   "description": "Draft, review, approve, and autopilot X/Twitter posts.",
   "long_description": "## **⚠️ The disclaimer above is generic Claude boilerplate.** Anthropic shows the same warning on every plugin regardless of what it does; any plugin has the same level of access as any app you download from the internet.\n\nS4L is an open source product developed by Mediar.ai Incorporated, a VC-backed San Francisco-based startup.\n\nTo get started:\n\n1\\. Copy this prompt: **Set me up on S4L plugin end to end**\n\n2\\. Quit with CMD+Q, reopen Claude, paste into a new chat.\n\nWhat happens next:\n\n* About every 5 minutes S4L scans X for posts that match your topics and drafts replies in your voice.\n* Drafts show up as review cards, usually the first within a few minutes. Nothing is posted automatically; you approve each one.\n* Posting autopilot stays off until you explicitly turn it on.",
   "author": {

package/mcp/menubar/s4l_card.py

@@ -1180,20 +1180,45 @@ class _ReviewController(NSObject):
             age_label.setAlignment_(NSTextAlignmentRight)
             content.addSubview_(age_label)
             right_x -= age_w + 4
-        handle_w = right_x - (M + 78) - 4
+        # Platform mark (brand identification, inline with the author row):
+        # Reddit's orange "r/" vs X's glyph, so a mixed-platform review queue
+        # reads at a glance which network each card posts to.
+        _plat = (d.get("platform") or "twitter").lower()
+        _mark = "r/" if _plat == "reddit" else "\U0001d54f"
+        _mark_w = 18
+        _mark_label = _label(
+            NSMakeRect(M + 78, H - 70, _mark_w, 18), _mark, size=12, bold=True
+        )
+        if _plat == "reddit":
+            try:
+                # Reddit orangered (#FF4500); best effort, falls back to the
+                # default label color on any AppKit hiccup.
+                _mark_label.setTextColor_(
+                    NSColor.colorWithSRGBRed_green_blue_alpha_(1.0, 0.27, 0.0, 1.0)
+                )
+            except Exception:
+                pass
+        content.addSubview_(_mark_label)
+        _author_x = M + 78 + _mark_w
+        handle_w = right_x - _author_x - 4
         if handle:
             # Size the link to its text so the follower count can sit right
             # after the handle instead of at a fixed column.
-            text = f"@{handle}"
+            text = f"u/{handle}" if _plat == "reddit" else f"@{handle}"
             measured = NSAttributedString.alloc().initWithString_attributes_(
                 text, {NSFontAttributeName: _font(12, True)}
             ).size().width
             link_w = min(int(measured) + 8, handle_w)
+            _prof_url = (
+                f"https://www.reddit.com/user/{handle}"
+                if _plat == "reddit"
+                else f"https://x.com/{handle}"
+            )
             self._add_link(
                 content,
-                NSMakeRect(M + 78, H - 70, link_w, 18),
+                NSMakeRect(_author_x, H - 70, link_w, 18),
                 text,
-                f"https://x.com/{handle}",
+                _prof_url,
                 bold=True,
                 kind="profile_click",
             )
@@ -1202,7 +1227,7 @@ class _ReviewController(NSObject):
             if followers and fol_w > 20:
                 content.addSubview_(
                     _label(
-                        NSMakeRect(M + 78 + link_w, H - 70, fol_w, 18),
+                        NSMakeRect(_author_x + link_w, H - 70, fol_w, 18),
                         f"· {followers}",
                         size=11,
                         muted=True,
@@ -1210,7 +1235,7 @@ class _ReviewController(NSObject):
                 )
         else:
             content.addSubview_(
-                _label(NSMakeRect(M + 78, H - 70, handle_w, 18), "thread", size=12, bold=True, muted=True)
+                _label(NSMakeRect(_author_x, H - 70, handle_w, 18), "thread", size=12, bold=True, muted=True)
             )
         # Non-English drafts: the prep step stamps display-only English
         # translations (thread_text_en / reply_text_en) on the candidate. The
@@ -1859,6 +1884,7 @@ class _ReviewController(NSObject):
                 # decision can be shipped to /api/v1/review-events without
                 # re-reading the plan.
                 "candidate_id": d.get("candidate_id"),
+                "platform": d.get("platform"),
                 "project": d.get("project"),
                 "thread_url": d.get("thread_url"),
                 "thread_author": d.get("thread_author"),

package/mcp/menubar/s4l_menubar.py

@@ -334,7 +334,6 @@ SETUP_PROMPT = (
     "Keep going without asking me to approve each safe setup step. Ask only if I "
     "must interactively sign in or no product can be identified."
 )
-UPDATE_PROMPT = "Update the S4L plugin to the latest version."
 # Re-arm goes through the HOST create_scheduled_task path (the same one onboarding
 # uses) — it registers the routines under whatever account is logged in and shows
 # up in Routines. The host tool only runs inside an agent chat, so the menu bar
@@ -494,42 +493,6 @@ def _glyph(status):
     return GLYPH.get(status, "·")
 
 
-def _osa_quote(s):
-    """Escape a Python string for an AppleScript double-quoted literal."""
-    return s.replace("\\", "\\\\").replace('"', '\\"')
-
-
-def _claude_send_script(prompt):
-    """AppleScript that focuses Claude, pastes `prompt` into the focused composer,
-    and presses Return. Uses the clipboard (saved + restored) rather than slow
-    per-character keystrokes, and waits longer on a cold launch so the window is
-    ready before pasting."""
-    p = _osa_quote(prompt)
-    return "\n".join(
-        [
-            'set prevClip to ""',
-            "try",
-            "    set prevClip to (the clipboard as text)",
-            "end try",
-            f'set the clipboard to "{p}"',
-            'tell application "System Events" to set wasRunning to (exists process "Claude")',
-            'tell application "Claude" to activate',
-            "if wasRunning then",
-            "    delay 0.5",
-            "else",
-            "    delay 2.5",
-            "end if",
-            'tell application "System Events"',
-            '    keystroke "v" using {command down}',
-            "    delay 0.15",
-            "    key code 36",
-            "end tell",
-            "delay 0.3",
-            'if prevClip is not "" then set the clipboard to prevClip',
-        ]
-    )
-
-
 class S4LMenuBar(rumps.App):
     def __init__(self):
         super().__init__("S4L", quit_button=None)
@@ -710,23 +673,6 @@ class S4LMenuBar(rumps.App):
         except Exception:
             return False
 
-    def _manual_paste_fallback(self, prompt, reason):
-        """Automation couldn't paste (no Accessibility, or osascript failed). Don't
-        dead-end: drop the prompt on the clipboard and open Claude so the user can
-        paste it themselves (Cmd+V, Enter). This is what makes re-arm/setup usable
-        even when the TCC grant is stale (granted but the running process still
-        reads untrusted until restart)."""
-        copied = self._copy_to_clipboard(prompt)
-        self._open_claude()
-        if copied:
-            self._notify(
-                "S4L · prompt copied to clipboard",
-                f"{reason} Paste it into Claude (⌘V) and press Enter to continue.",
-            )
-        else:
-            self._notify("S4L", f"{reason} Open Claude and type your request there.")
-        return False
-
     def _clipboard_prompt(self, prompt, title, action_desc):
         """The menu bar's UNIVERSAL way to hand an agent-driven action to Claude
         without depending on the MCP/loopback being up (the menu bar can't inject
@@ -751,20 +697,13 @@ class S4LMenuBar(rumps.App):
         self._open_claude()
         return True
 
-    def _send_to_claude(self, prompt):
-        """Back-compat shim: every agent-driven menu action now uses the reliable
-        clipboard-prompt model (no flaky auto-type). Delegates to _clipboard_prompt."""
-        return self._clipboard_prompt(
-            prompt, "Send to Claude", "Claude will take it from there"
-        )
-
     # Agent-driven action: hand the full setup prompt to Claude via the clipboard.
     def _setup(self, _=None):
         self._clipboard_prompt(
             SETUP_PROMPT,
             "Set up S4L in Claude",
-            "Claude will set up your runtime, connect X, configure your project, and "
-            "schedule the autopilot",
+            "Claude will set up your runtime, connect X (or Reddit), configure your "
+            "project, and schedule the autopilot",
         )
 
 
@@ -1151,13 +1090,14 @@ class S4LMenuBar(rumps.App):
     )
 
     # Posting volume (2026-07-13): server-side per-install throttle for the
-    # twitter cycle's virality bar. None = driver default. The labels carry
-    # ballpark rates; exact per-install estimates live on the dashboard's
-    # Posting Volume section (Stats tab). Internal values stay high|medium|low
-    # (DB CHECK + API enum); Aggressive/Steady/Chill are display names only
-    # (renamed 2026-07-14 per user).
+    # twitter cycle's virality bar. The labels carry ballpark rates; exact
+    # per-install estimates live on the dashboard's Posting Volume section
+    # (Stats tab). Internal values stay high|medium|low (DB CHECK + API enum);
+    # Aggressive/Steady/Chill are display names only (renamed 2026-07-14).
+    # There is NO separate "default" state (removed 2026-07-14 per user): an
+    # install that never chose resolves to Steady server-side, so the menu
+    # shows Steady checked.
     POSTING_MODE_PRESETS = (
-        (None, "Default (cycle setting)"),
         ("high", "Aggressive (100+ posts/day)"),
         ("medium", "Steady (~30 posts/day)"),
         ("low", "Chill (~5 posts/day)"),
@@ -1188,11 +1128,11 @@ class S4LMenuBar(rumps.App):
             sys.stderr.flush()
 
     def _posting_mode_label(self, mode):
-        """Menu copy for a posting-volume mode value."""
+        """Menu copy for a posting-volume mode value (unknown/unset = Steady)."""
         for preset, label in self.POSTING_MODE_PRESETS:
             if preset == mode:
                 return label
-        return "Default (cycle setting)"
+        return "Steady (~30 posts/day)"
 
     def _on_posting_mode_preset(self, mode, _sender=None):
         """Set the server-side posting-volume mode (network POST; a click may
@@ -1304,26 +1244,6 @@ class S4LMenuBar(rumps.App):
         except Exception:
             pass
 
-    # ---- disable scheduled tasks (menu-bar driven) ------------------------
-    def _has_scheduled_tasks(self):
-        """Read-only: True if any S4L worker/autopilot task is registered in any
-        scheduled-tasks.json. Gates whether the 'Disable scheduled tasks' item is
-        worth showing."""
-        try:
-            wanted = set(WORKER_TASK_IDS) | set(DEPRECATED_TASK_IDS)
-            for f in glob.glob(SCHED_REGISTRY_GLOB):
-                try:
-                    with open(f) as fh:
-                        d = json.load(fh)
-                except Exception:
-                    continue
-                for t in d.get("scheduledTasks", []):
-                    if t.get("id") in wanted:
-                        return True
-        except Exception:
-            pass
-        return False
-
     def _pause_toggle(self, _=None):
         """Pause/Resume: the lighter, fully reversible alternative to Quit. Stops
         S4L's own scan/draft/post pipeline (the launchd kicker + its support
@@ -1475,9 +1395,6 @@ class S4LMenuBar(rumps.App):
             # exit as final. os._exit because we're on a background thread.
             os._exit(0)
 
-    def _update(self, _=None):
-        self._send_to_claude(UPDATE_PROMPT)
-
     # ---- .mcpb self-update (menu-bar driven) ------------------------------
     @staticmethod
     def _ext_dir():
@@ -1594,13 +1511,6 @@ class S4LMenuBar(rumps.App):
             pass
         return dirs
 
-    @classmethod
-    def _claude_user_data_dir(cls):
-        """First custom --user-data-dir among running instances, or None.
-        Prefer _claude_user_data_dirs when relaunching after a kill — the
-        kill takes every profile down, not just this one."""
-        return next((d for d in cls._claude_user_data_dirs() if d), None)
-
     @staticmethod
     def _claude_running():
         """True while a Claude Desktop main process is alive. pgrep -x matches
@@ -2213,6 +2123,14 @@ class S4LMenuBar(rumps.App):
         ):
             label = self._posting_label
         if label:
+            # Menu bar stays CONCISE (user rule 2026-07-14): strip the trailing
+            # elapsed-duration token the producer encodes in the label ("draft
+            # 2m", "draft ⧖18m") from the TITLE only. The full label (with the
+            # duration the stall detector's _label_elapsed_secs parses) still
+            # lives in activity.json — this is display-side trimming, never a
+            # change to the data.
+            import re as _re
+            label = _re.sub(r"\s*⧖?\s*\d+\s*[sm]\s*$", "", str(label)).strip() or label
             # The update arrow must stay visible even while a tool runs, so the
             # "update available" signal is never masked by activity. _tick skips the
             # title repaint while the spinner owns it, so the arrow is injected here.
@@ -3056,7 +2974,11 @@ class S4LMenuBar(rumps.App):
                 cid = None
             st.review_event_add(
                 {
-                    "platform": "twitter",
+                    # reddit cards ship platform=reddit (2026-07-14); their
+                    # candidate_id is rd-prefixed and int()s to None above, so
+                    # the server's twitter_candidates row flip never fires for
+                    # them (by design — see merge_review_queue.py).
+                    "platform": decision.get("platform") or "twitter",
                     "project": decision.get("project"),
                     "candidate_id": cid,
                     "batch_id": batch,
@@ -3135,17 +3057,19 @@ class S4LMenuBar(rumps.App):
         self._ship_review_event(batch, decision)
         if not decision.get("approved"):
             n = decision.get("n")
-            # Durable local record FIRST, mirroring approved_queue_add for approvals.
+            # Durable local record FIRST, mirroring the approve branch below.
             # review_drafts() consults this, so the rejected card is suppressed from
             # re-review IMMEDIATELY and even if the loopback is down when the
             # background plan-flag write below runs. Without this, a reject was a
             # fire-and-forget loopback call with a swallowed exception, so rejects
             # silently vanished and the card "came back" — unlike durable approvals.
+            # A failure here is captured (not silently swallowed) so a broken
+            # durable write is visible instead of looking identical to success.
             try:
                 st.store_stamp_decision(batch, decision)
                 self._session_decisions.append(dict(decision))
-            except Exception:
-                pass
+            except Exception as e:
+                _capture(e, phase="reject_stamp_decision")
 
             def _persist_reject():
                 try:
@@ -3160,8 +3084,15 @@ class S4LMenuBar(rumps.App):
         # restart resumes the drain instead of stranding it and re-presenting the
         # card. The in-memory _post_q below is just the fast path; this file is the
         # source of truth review_drafts() consults to avoid re-showing it.
-        st.store_stamp_decision(batch, decision)
-        self._session_decisions.append(dict(decision))
+        # Same try/except shape as the reject branch above (was previously
+        # unguarded here, an asymmetry with no intentional reason): a failure is
+        # captured, not silently swallowed, and the post still gets enqueued below
+        # either way — this write is a resume/dedup aid, not a gate on posting.
+        try:
+            st.store_stamp_decision(batch, decision)
+            self._session_decisions.append(dict(decision))
+        except Exception as e:
+            _capture(e, phase="approve_stamp_decision")
         with self._review_lock:
             self._posts_outstanding += 1
             self._posting_batch_total += 1
@@ -3571,10 +3502,10 @@ class S4LMenuBar(rumps.App):
         items.append(cadence_menu)
 
         # Posting volume: server-side per-install throttle (virality bar).
-        # read_posting_mode() is cached and non-blocking; until the first
-        # refresh lands the submenu shows Default checked, then corrects on
-        # the next rebuild.
-        pv_mode = st.read_posting_mode()
+        # read_posting_mode() is cached and non-blocking; unknown/unset shows
+        # as Steady (the server resolves unset the same way), corrected on the
+        # rebuild after the first refresh lands.
+        pv_mode = st.read_posting_mode() or "medium"
         pv_menu = rumps.MenuItem(
             f"Posting volume: {self._posting_mode_label(pv_mode).split(' (')[0].lower()}"
         )