@lotics/ui 7.18.0 → 7.19.1

package/AGENTS.md

@@ -684,7 +684,8 @@ was only ever about the review surfaces' sparkles/severity glyphs, not functiona
     header; the rows below it Divider-separated; a sortable column shows its `SortHeader` sort glyph
     ALWAYS so it reads as sortable). A `TableRow` with no `onPress` renders a STATIC read-only row (no
     hover wash / pointer cursor) so `Table` also serves read-only tabular data (a fee breakdown, a spec
-    sheet), not just interactive registers. Make it SELECTABLE with the `Table` `leading` gutter + `selectAll`
+    sheet), not just interactive registers. A pressable `TableRow` REQUIRES `accessibilityLabel`
+    ("Open …") — its keyboard door is an empty overlay with no content to derive a name from. Make it SELECTABLE with the `Table` `leading` gutter + `selectAll`
     slot — a `CheckboxInput` per `TableRow` (`leading`) + a select-all in the header band, the ticked
     rows `marked`, paired with a `FloatingActionBar`; the selection state is the **`useSelection()`**
     hook (`selected`/`count`/`toggle`/`setAll`/`allSelected`/`indeterminate`/`clear` — gating which
@@ -698,9 +699,13 @@ was only ever about the review surfaces' sparkles/severity glyphs, not functiona
   a fixed `width`, so amount/status columns don't jitter).
 - **Row actions are ALWAYS-VISIBLE siblings, never hover-revealed, never nested.** A pressable row =
   a role-less surface (the hover/press wash, via DOM `mouseenter` so it covers the whole row) + an
-  accessible "Open …" door (the body, a button) + trailing actions (⋯, remove ✕, edit) as SIBLINGS of
+  accessible "Open …" door (a button) + trailing actions (⋯, remove ✕, edit) as SIBLINGS of
   the door — a button must not contain another button, so the action is independently pressable and
-  the ✕ isn't swallowed by the row press (`FileRow` and `PressableRow` are the references). Actions
+  the ✕ isn't swallowed by the row press (`FileRow` and `PressableRow` are the references). The door
+  wraps the row body ONLY when that body is non-interactive by construction (`FileRow`'s name/meta);
+  where the body is arbitrary app content — `TableRow`'s cells, which legitimately carry a `Link` or
+  a popover trigger — the door is an EMPTY absolutely-positioned sibling under the cells (tab stop +
+  name + focus ring; mouse rides the surface), so a control in a cell never nests inside it. Actions
   stay **visible** — a hover-only action is invisible to keyboard and touch users. The ONLY exception
   is a DENSE tree/register where a persistent per-row action would clutter (e.g. the DB sidebar):
   reveal on hover **OR focus-within**, keeping the action in the DOM + tab order and gating only its

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lotics/ui",
-  "version": "7.18.0",
+  "version": "7.19.1",
   "type": "module",
   "exports": {
     "./tokens": "./src/tokens.ts",

package/src/agent_run.tsx

@@ -379,18 +379,20 @@ function ToolGroup(props: {
 }
 
 const styles = StyleSheet.create({
-  narration: { paddingHorizontal: 8 },
+  // No horizontal self-inset: the run sits flush so the CONSUMER'S gutter governs
+  // alignment (an 8px inset made its text misalign with dialog titles / sibling
+  // lines in every padded container).
+  narration: {},
   group: { gap: 2 },
   row: {
     flexDirection: "row",
     alignItems: "center",
     gap: 10,
     minHeight: CONTROL_HEIGHT,
-    paddingHorizontal: 8,
     borderRadius: CONTROL_RADIUS,
   },
   dotCol: { width: 18, alignItems: "center" },
   rowBody: { flex: 1 },
   // Reasoning body aligns under the "Thinking" label (past the dot column + gap).
-  reasoning: { paddingLeft: 36, paddingRight: 8, paddingBottom: 4 },
+  reasoning: { paddingLeft: 28, paddingBottom: 4 },
 });

package/src/pressable_row.tsx

@@ -26,7 +26,10 @@ export interface PressableRowProps {
   variant?: "register" | "bleed" | "inset";
   /** Cells + trailing controls. Nested pressables (CTAs, checkboxes, ⋯)
    * claim their own presses; put the accessible door inside — a plain
-   * `Pressable` with role="button" + "Open …" label around the row body. */
+   * `Pressable` with role="button" + "Open …" label. Wrap the row body with it
+   * only when the body is non-interactive by construction; a body that can
+   * carry its own controls gets an EMPTY absolutely-positioned door as their
+   * sibling instead (a button must not contain a button — see `TableRow`). */
   children: ReactNode;
   /** Layout only (gap, minHeight overrides). The surface owns its press
    * states — never pass backgroundColor for hover/selected. */

package/src/table.tsx

@@ -114,14 +114,10 @@ export function Table(props: TableProps) {
   );
 }
 
-export interface TableRowProps {
-  /** Opens the record (the drawer). The door + the full-row surface both call it. */
-  onPress?: () => void;
+export type TableRowProps = {
   selected?: boolean;
   /** Part of a multi-select set — a resting blue tint (the open/hover wash overrides it). */
   marked?: boolean;
-  /** Accessible name for the door (the keyboard-focusable open target). */
-  accessibilityLabel?: string;
   /** Outside the door, BEFORE the cells (a selection checkbox) — width = Table `leading`. */
   leading?: ReactNode;
   /** Outside the door, AFTER the cells (a ⋯ menu / a button) — width = Table `trailing`. */
@@ -130,14 +126,31 @@ export interface TableRowProps {
   minHeight?: number;
   /** The `TableCell`s, one per column, in column order. */
   children: ReactNode;
-}
+} & (
+  | {
+      /** Opens the record (the drawer). The door + the full-row surface both call it. */
+      onPress: () => void;
+      /** Accessible name for the door (the keyboard-focusable open target). REQUIRED
+       *  on a pressable row: the door is an empty overlay (cells are its siblings, so
+       *  a cell control never nests in a button), which means it has no text content
+       *  to derive a name from — without a label it's a nameless button. */
+      accessibilityLabel: string;
+    }
+  | { onPress?: undefined; accessibilityLabel?: undefined }
+);
 
 /**
  * A register row: a full-bleed `PressableRow` (its hover wash spans the whole row,
- * incl. the leading/trailing controls) wrapping the door — an inner
- * `role="button"` `Pressable` (the keyboard-accessible open) around the cells —
- * with optional `leading`/`trailing` slots OUTSIDE the door so their own presses
- * win. Cells map to `Table`'s columns by position.
+ * incl. the leading/trailing controls) holding the cells, with the door — the
+ * keyboard-accessible `role="button"` open target — as an EMPTY absolutely-
+ * positioned SIBLING beneath them, never their ancestor. A button must not
+ * contain interactive descendants, and cells legitimately carry their own
+ * controls (a popover trigger, a `Link`); wrapping the cells in the door nests
+ * `<button>` in `<button>` (invalid HTML — React hydration warning). The door
+ * carries the tab stop, the accessible name, and the focus ring (spanning the
+ * row, rounded to the register wash); mouse presses ride the `PressableRow`
+ * surface, and nested controls claim their own. `leading`/`trailing` slots stay
+ * independently pressable. Cells map to `Table`'s columns by position.
  */
 export function TableRow(props: TableRowProps) {
   const { onPress, selected, marked, accessibilityLabel, leading, trailing, minHeight = 52, children } = props;
@@ -157,7 +170,7 @@ export function TableRow(props: TableRowProps) {
     return (
       <View style={styles.staticRow}>
         {ctx.leading > 0 ? <View style={{ width: ctx.leading }}>{leading}</View> : null}
-        <View style={[styles.door, { minHeight }]}>{cells}</View>
+        <View style={[styles.cells, { minHeight }]}>{cells}</View>
         {ctx.trailing > 0 ? <View style={{ width: ctx.trailing, alignItems: "flex-end" }}>{trailing}</View> : null}
       </View>
     );
@@ -165,17 +178,21 @@ export function TableRow(props: TableRowProps) {
 
   return (
     <PressableRow onPress={onPress} selected={selected} marked={marked} style={styles.row}>
-      {ctx.leading > 0 ? <View style={{ width: ctx.leading }}>{leading}</View> : null}
+      {ctx.leading > 0 ? <View style={[styles.slot, { width: ctx.leading }]}>{leading}</View> : null}
+      {/* An absolutely-positioned sibling paints — and hit-tests — above in-flow
+          content, which would swallow every cell control's press; the slots lift
+          above it via zIndex 1 (z-index applies to flex items), so the door gets
+          only the keyboard. Negative z on the door instead would escape the row
+          (no stacking context) and bury the focus ring under the Card background. */}
       <Pressable
         accessibilityRole="button"
         accessibilityLabel={accessibilityLabel}
         onPress={onPress}
         {...focusProps}
-        style={[styles.door, { minHeight }, focusVisible && { boxShadow: FOCUS_RING }]}
-      >
-        {cells}
-      </Pressable>
-      {ctx.trailing > 0 ? <View style={{ width: ctx.trailing, alignItems: "flex-end" }}>{trailing}</View> : null}
+        style={[styles.door, focusVisible && { boxShadow: FOCUS_RING }]}
+      />
+      <View style={[styles.cells, { minHeight }]}>{cells}</View>
+      {ctx.trailing > 0 ? <View style={[styles.slot, { width: ctx.trailing, alignItems: "flex-end" }]}>{trailing}</View> : null}
     </PressableRow>
   );
 }
@@ -219,10 +236,27 @@ const styles = StyleSheet.create({
     gap: 14,
     paddingHorizontal: 20,
   },
+  // The keyboard door: an empty overlay spanning the row — the tab stop + focus
+  // ring live here, the cells are its SIBLINGS (see TableRow's doc). Radius
+  // matches the register wash.
   door: {
+    position: "absolute",
+    top: 0,
+    right: 0,
+    bottom: 0,
+    left: 0,
+    borderRadius: 10,
+  },
+  cells: {
     flex: 1,
     flexDirection: "row",
     alignItems: "center",
     gap: 14,
+    zIndex: 1,
+  },
+  // Leading/trailing gutters carry their own controls — lifted above the door
+  // like the cells.
+  slot: {
+    zIndex: 1,
   },
 });