@lobehub/lobehub 2.0.0-next.50 → 2.0.0-next.51

package/apps/desktop/src/main/controllers/__tests__/ShellCommandCtr.test.ts

@@ -0,0 +1,499 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+
+import type { App } from '@/core/App';
+
+import ShellCommandCtr from '../ShellCommandCtr';
+
+// Mock logger
+vi.mock('@/utils/logger', () => ({
+  createLogger: () => ({
+    debug: vi.fn(),
+    info: vi.fn(),
+    warn: vi.fn(),
+    error: vi.fn(),
+  }),
+}));
+
+// Mock child_process
+vi.mock('node:child_process', () => ({
+  spawn: vi.fn(),
+}));
+
+// Mock crypto
+vi.mock('node:crypto', () => ({
+  randomUUID: vi.fn(() => 'test-uuid-123'),
+}));
+
+const mockApp = {} as unknown as App;
+
+describe('ShellCommandCtr', () => {
+  let shellCommandCtr: ShellCommandCtr;
+  let mockSpawn: any;
+  let mockChildProcess: any;
+
+  beforeEach(async () => {
+    vi.clearAllMocks();
+
+    // Import mocks
+    const childProcessModule = await import('node:child_process');
+    mockSpawn = vi.mocked(childProcessModule.spawn);
+
+    // Create mock child process
+    mockChildProcess = {
+      stdout: {
+        on: vi.fn(),
+      },
+      stderr: {
+        on: vi.fn(),
+      },
+      on: vi.fn(),
+      kill: vi.fn(),
+      exitCode: null,
+    };
+
+    mockSpawn.mockReturnValue(mockChildProcess);
+
+    shellCommandCtr = new ShellCommandCtr(mockApp);
+  });
+
+  describe('handleRunCommand', () => {
+    describe('synchronous mode', () => {
+      it('should execute command successfully', async () => {
+        let exitCallback: (code: number) => void;
+        let stdoutCallback: (data: Buffer) => void;
+
+        mockChildProcess.on.mockImplementation((event: string, callback: any) => {
+          if (event === 'exit') {
+            exitCallback = callback;
+            // Simulate successful exit
+            setTimeout(() => exitCallback(0), 10);
+          }
+          return mockChildProcess;
+        });
+
+        mockChildProcess.stdout.on.mockImplementation((event: string, callback: any) => {
+          if (event === 'data') {
+            stdoutCallback = callback;
+            // Simulate output
+            setTimeout(() => stdoutCallback(Buffer.from('test output\n')), 5);
+          }
+          return mockChildProcess.stdout;
+        });
+
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        const result = await shellCommandCtr.handleRunCommand({
+          command: 'echo "test"',
+          description: 'test command',
+        });
+
+        expect(result.success).toBe(true);
+        expect(result.stdout).toBe('test output\n');
+        expect(result.exit_code).toBe(0);
+      });
+
+      it('should handle command timeout', async () => {
+        mockChildProcess.on.mockImplementation(() => mockChildProcess);
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        const result = await shellCommandCtr.handleRunCommand({
+          command: 'sleep 10',
+          description: 'long running command',
+          timeout: 100,
+        });
+
+        expect(result.success).toBe(false);
+        expect(result.error).toContain('timed out');
+        expect(mockChildProcess.kill).toHaveBeenCalled();
+      });
+
+      it('should handle command execution error', async () => {
+        let errorCallback: (error: Error) => void;
+
+        mockChildProcess.on.mockImplementation((event: string, callback: any) => {
+          if (event === 'error') {
+            errorCallback = callback;
+            setTimeout(() => errorCallback(new Error('Command not found')), 10);
+          }
+          return mockChildProcess;
+        });
+
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        const result = await shellCommandCtr.handleRunCommand({
+          command: 'invalid-command',
+          description: 'invalid command',
+        });
+
+        expect(result.success).toBe(false);
+        expect(result.error).toBe('Command not found');
+      });
+
+      it('should handle non-zero exit code', async () => {
+        let exitCallback: (code: number) => void;
+
+        mockChildProcess.on.mockImplementation((event: string, callback: any) => {
+          if (event === 'exit') {
+            exitCallback = callback;
+            setTimeout(() => exitCallback(1), 10);
+          }
+          return mockChildProcess;
+        });
+
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        const result = await shellCommandCtr.handleRunCommand({
+          command: 'exit 1',
+          description: 'failing command',
+        });
+
+        expect(result.success).toBe(false);
+        expect(result.exit_code).toBe(1);
+      });
+
+      it('should capture stderr output', async () => {
+        let exitCallback: (code: number) => void;
+        let stderrCallback: (data: Buffer) => void;
+
+        mockChildProcess.on.mockImplementation((event: string, callback: any) => {
+          if (event === 'exit') {
+            exitCallback = callback;
+            setTimeout(() => exitCallback(1), 10);
+          }
+          return mockChildProcess;
+        });
+
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation((event: string, callback: any) => {
+          if (event === 'data') {
+            stderrCallback = callback;
+            setTimeout(() => stderrCallback(Buffer.from('error message\n')), 5);
+          }
+          return mockChildProcess.stderr;
+        });
+
+        const result = await shellCommandCtr.handleRunCommand({
+          command: 'command-with-error',
+          description: 'command with stderr',
+        });
+
+        expect(result.stderr).toBe('error message\n');
+      });
+
+      it('should enforce timeout limits', async () => {
+        mockChildProcess.on.mockImplementation(() => mockChildProcess);
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        // Test minimum timeout
+        const minResult = await shellCommandCtr.handleRunCommand({
+          command: 'sleep 5',
+          timeout: 500, // Below 1000ms minimum
+        });
+
+        expect(minResult.success).toBe(false);
+        expect(minResult.error).toContain('1000ms'); // Should use 1000ms minimum
+      });
+    });
+
+    describe('background mode', () => {
+      it('should start command in background', async () => {
+        mockChildProcess.on.mockImplementation(() => mockChildProcess);
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        const result = await shellCommandCtr.handleRunCommand({
+          command: 'long-running-task',
+          description: 'background task',
+          run_in_background: true,
+        });
+
+        expect(result.success).toBe(true);
+        expect(result.shell_id).toBe('test-uuid-123');
+      });
+
+      it('should use correct shell on Windows', async () => {
+        const originalPlatform = process.platform;
+        Object.defineProperty(process, 'platform', { value: 'win32' });
+
+        mockChildProcess.on.mockImplementation(() => mockChildProcess);
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        await shellCommandCtr.handleRunCommand({
+          command: 'dir',
+          description: 'windows command',
+          run_in_background: true,
+        });
+
+        expect(mockSpawn).toHaveBeenCalledWith('cmd.exe', ['/c', 'dir'], expect.any(Object));
+
+        Object.defineProperty(process, 'platform', { value: originalPlatform });
+      });
+
+      it('should use correct shell on Unix', async () => {
+        const originalPlatform = process.platform;
+        Object.defineProperty(process, 'platform', { value: 'darwin' });
+
+        mockChildProcess.on.mockImplementation(() => mockChildProcess);
+        mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+        mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+        await shellCommandCtr.handleRunCommand({
+          command: 'ls',
+          description: 'unix command',
+          run_in_background: true,
+        });
+
+        expect(mockSpawn).toHaveBeenCalledWith('/bin/sh', ['-c', 'ls'], expect.any(Object));
+
+        Object.defineProperty(process, 'platform', { value: originalPlatform });
+      });
+    });
+  });
+
+  describe('handleGetCommandOutput', () => {
+    beforeEach(async () => {
+      mockChildProcess.on.mockImplementation(() => mockChildProcess);
+      mockChildProcess.stdout.on.mockImplementation((event: string, callback: any) => {
+        if (event === 'data') {
+          // Simulate some output
+          setTimeout(() => callback(Buffer.from('line 1\n')), 5);
+          setTimeout(() => callback(Buffer.from('line 2\n')), 10);
+        }
+        return mockChildProcess.stdout;
+      });
+      mockChildProcess.stderr.on.mockImplementation((event: string, callback: any) => {
+        if (event === 'data') {
+          setTimeout(() => callback(Buffer.from('error line\n')), 7);
+        }
+        return mockChildProcess.stderr;
+      });
+
+      // Start a background process first
+      await shellCommandCtr.handleRunCommand({
+        command: 'test-command',
+        run_in_background: true,
+      });
+    });
+
+    it('should retrieve command output', async () => {
+      // Wait for output to be captured
+      await new Promise((resolve) => setTimeout(resolve, 20));
+
+      const result = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(result.success).toBe(true);
+      expect(result.stdout).toContain('line 1');
+      expect(result.stderr).toContain('error line');
+    });
+
+    it('should return error for non-existent shell_id', async () => {
+      const result = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'non-existent-id',
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('not found');
+    });
+
+    it('should filter output with regex', async () => {
+      // Wait for output to be captured
+      await new Promise((resolve) => setTimeout(resolve, 20));
+
+      const result = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+        filter: 'line 1',
+      });
+
+      expect(result.success).toBe(true);
+      expect(result.output).toContain('line 1');
+      expect(result.output).not.toContain('line 2');
+    });
+
+    it('should only return new output since last read', async () => {
+      // Wait for initial output
+      await new Promise((resolve) => setTimeout(resolve, 20));
+
+      // First read
+      const firstResult = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(firstResult.stdout).toContain('line 1');
+
+      // Second read should return empty (no new output)
+      const secondResult = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(secondResult.stdout).toBe('');
+      expect(secondResult.stderr).toBe('');
+    });
+
+    it('should handle invalid regex filter gracefully', async () => {
+      await new Promise((resolve) => setTimeout(resolve, 20));
+
+      const result = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+        filter: '[invalid(regex',
+      });
+
+      expect(result.success).toBe(true);
+      // Should return unfiltered output when filter is invalid
+    });
+
+    it('should report running status correctly', async () => {
+      mockChildProcess.exitCode = null;
+
+      const runningResult = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(runningResult.running).toBe(true);
+
+      // Simulate process exit
+      mockChildProcess.exitCode = 0;
+
+      const exitedResult = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(exitedResult.running).toBe(false);
+    });
+
+    it('should track stdout and stderr offsets separately when streaming output', async () => {
+      // Create a new background process with manual control over stdout/stderr
+      let stdoutCallback: (data: Buffer) => void;
+      let stderrCallback: (data: Buffer) => void;
+
+      mockChildProcess.stdout.on.mockImplementation((event: string, callback: any) => {
+        if (event === 'data') {
+          stdoutCallback = callback;
+        }
+        return mockChildProcess.stdout;
+      });
+
+      mockChildProcess.stderr.on.mockImplementation((event: string, callback: any) => {
+        if (event === 'data') {
+          stderrCallback = callback;
+        }
+        return mockChildProcess.stderr;
+      });
+
+      // Start a new background process
+      await shellCommandCtr.handleRunCommand({
+        command: 'test-interleaved',
+        run_in_background: true,
+      });
+
+      // Simulate stderr output first
+      stderrCallback(Buffer.from('error 1\n'));
+      await new Promise((resolve) => setTimeout(resolve, 5));
+
+      // First read - should get stderr
+      const firstRead = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+      expect(firstRead.stderr).toBe('error 1\n');
+      expect(firstRead.stdout).toBe('');
+
+      // Simulate stdout output after stderr
+      stdoutCallback(Buffer.from('output 1\n'));
+      await new Promise((resolve) => setTimeout(resolve, 5));
+
+      // Second read - should get stdout without losing data
+      const secondRead = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+      expect(secondRead.stdout).toBe('output 1\n');
+      expect(secondRead.stderr).toBe('');
+
+      // Simulate more stderr
+      stderrCallback(Buffer.from('error 2\n'));
+      await new Promise((resolve) => setTimeout(resolve, 5));
+
+      // Third read - should get new stderr
+      const thirdRead = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+      expect(thirdRead.stderr).toBe('error 2\n');
+      expect(thirdRead.stdout).toBe('');
+
+      // Simulate more stdout
+      stdoutCallback(Buffer.from('output 2\n'));
+      await new Promise((resolve) => setTimeout(resolve, 5));
+
+      // Fourth read - should get new stdout
+      const fourthRead = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+      expect(fourthRead.stdout).toBe('output 2\n');
+      expect(fourthRead.stderr).toBe('');
+    });
+  });
+
+  describe('handleKillCommand', () => {
+    beforeEach(async () => {
+      mockChildProcess.on.mockImplementation(() => mockChildProcess);
+      mockChildProcess.stdout.on.mockImplementation(() => mockChildProcess.stdout);
+      mockChildProcess.stderr.on.mockImplementation(() => mockChildProcess.stderr);
+
+      // Start a background process
+      await shellCommandCtr.handleRunCommand({
+        command: 'test-command',
+        run_in_background: true,
+      });
+    });
+
+    it('should kill command successfully', async () => {
+      const result = await shellCommandCtr.handleKillCommand({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(result.success).toBe(true);
+      expect(mockChildProcess.kill).toHaveBeenCalled();
+    });
+
+    it('should return error for non-existent shell_id', async () => {
+      const result = await shellCommandCtr.handleKillCommand({
+        shell_id: 'non-existent-id',
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain('not found');
+    });
+
+    it('should remove process from map after killing', async () => {
+      await shellCommandCtr.handleKillCommand({
+        shell_id: 'test-uuid-123',
+      });
+
+      // Try to get output from killed process
+      const outputResult = await shellCommandCtr.handleGetCommandOutput({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(outputResult.success).toBe(false);
+      expect(outputResult.error).toContain('not found');
+    });
+
+    it('should handle kill error gracefully', async () => {
+      mockChildProcess.kill.mockImplementation(() => {
+        throw new Error('Kill failed');
+      });
+
+      const result = await shellCommandCtr.handleKillCommand({
+        shell_id: 'test-uuid-123',
+      });
+
+      expect(result.success).toBe(false);
+      expect(result.error).toBe('Kill failed');
+    });
+  });
+});

package/changelog/v1.json

@@ -1,4 +1,13 @@
 [
+  {
+    "children": {
+      "improvements": [
+        "Update ERNIE-5.0-Thinking-Preview model."
+      ]
+    },
+    "date": "2025-11-13",
+    "version": "2.0.0-next.51"
+  },
   {
     "children": {
       "fixes": [

package/locales/ar/chat.json

@@ -369,6 +369,26 @@
     "remained": "متبقي",
     "used": "مستخدم"
   },
+  "tool": {
+    "intervention": {
+      "approve": "الموافقة",
+      "approveAndRemember": "الموافقة والتذكر",
+      "approveOnce": "الموافقة لمرة واحدة فقط",
+      "mode": {
+        "allowList": "قائمة السماح",
+        "allowListDesc": "تنفيذ الأدوات المعتمدة فقط تلقائيًا",
+        "autoRun": "الموافقة التلقائية",
+        "autoRunDesc": "الموافقة تلقائيًا على تنفيذ جميع الأدوات",
+        "manual": "يدوي",
+        "manualDesc": "يتطلب الموافقة اليدوية في كل مرة يتم فيها الاستدعاء"
+      },
+      "reject": "رفض",
+      "rejectReasonPlaceholder": "إدخال سبب الرفض سيساعد الوكيل على الفهم وتحسين الإجراءات المستقبلية",
+      "rejectTitle": "رفض استدعاء الأداة هذه المرة",
+      "rejectedWithReason": "تم رفض استدعاء الأداة هذه المرة بشكل يدوي: {{reason}}",
+      "toolRejected": "تم رفض استدعاء الأداة هذه المرة بشكل يدوي"
+    }
+  },
   "topic": {
     "checkOpenNewTopic": "هل ترغب في فتح موضوع جديد؟",
     "checkSaveCurrentMessages": "هل ترغب في حفظ الدردشة الحالية كموضوع؟",

package/locales/ar/common.json

@@ -135,6 +135,7 @@
     }
   },
   "close": "إغلاق",
+  "confirm": "تأكيد",
   "contact": "اتصل بنا",
   "copy": "نسخ",
   "copyFail": "فشل في النسخ",

package/locales/ar/components.json

@@ -106,6 +106,12 @@
     "keyPlaceholder": "المفتاح",
     "valuePlaceholder": "القيمة"
   },
+  "LocalFile": {
+    "action": {
+      "open": "فتح",
+      "showInFolder": "عرض في المجلد"
+    }
+  },
   "MaxTokenSlider": {
     "unlimited": "غير محدود"
   },

package/locales/ar/plugin.json

@@ -255,6 +255,7 @@
       "moveLocalFiles": "نقل الملفات",
       "readLocalFile": "قراءة محتوى الملف",
       "renameLocalFile": "إعادة تسمية",
+      "runCommand": "تشغيل الأمر",
       "searchLocalFiles": "بحث في الملفات",
       "writeLocalFile": "كتابة في الملف"
     },

package/locales/bg-BG/chat.json

@@ -369,6 +369,26 @@
     "remained": "Оставащи",
     "used": "Използвани"
   },
+  "tool": {
+    "intervention": {
+      "approve": "Одобряване",
+      "approveAndRemember": "Одобряване и запомняне",
+      "approveOnce": "Одобряване само този път",
+      "mode": {
+        "allowList": "Бял списък",
+        "allowListDesc": "Автоматично се изпълняват само одобрените инструменти",
+        "autoRun": "Автоматично одобрение",
+        "autoRunDesc": "Автоматично одобряване на всички изпълнения на инструменти",
+        "manual": "Ръчно",
+        "manualDesc": "Необходимо е ръчно одобрение при всяко извикване"
+      },
+      "reject": "Отхвърляне",
+      "rejectReasonPlaceholder": "Въведете причина за отхвърляне, за да помогнете на агента да разбере и подобри бъдещите действия",
+      "rejectTitle": "Отхвърляне на това извикване на инструмент",
+      "rejectedWithReason": "Това извикване на инструмент беше умишлено отхвърлено: {{reason}}",
+      "toolRejected": "Това извикване на инструмент беше умишлено отхвърлено"
+    }
+  },
   "topic": {
     "checkOpenNewTopic": "Да се отвори ли нова тема?",
     "checkSaveCurrentMessages": "Искате ли да запазите текущата сесия като тема?",

package/locales/bg-BG/common.json

@@ -135,6 +135,7 @@
     }
   },
   "close": "Затвори",
+  "confirm": "Потвърди",
   "contact": "Свържете се с нас",
   "copy": "Копирай",
   "copyFail": "Копирането не е успешно",

package/locales/bg-BG/components.json

@@ -106,6 +106,12 @@
     "keyPlaceholder": "Ключ",
     "valuePlaceholder": "Стойност"
   },
+  "LocalFile": {
+    "action": {
+      "open": "Отвори",
+      "showInFolder": "Показване в папката"
+    }
+  },
   "MaxTokenSlider": {
     "unlimited": "Неограничено"
   },

package/locales/bg-BG/plugin.json

@@ -255,6 +255,7 @@
       "moveLocalFiles": "Преместване на файлове",
       "readLocalFile": "Четене на съдържание на файл",
       "renameLocalFile": "Преименуване",
+      "runCommand": "Изпълни код",
       "searchLocalFiles": "Търсене на файлове",
       "writeLocalFile": "Запис в файл"
     },

package/locales/de-DE/chat.json

@@ -369,6 +369,26 @@
     "remained": "Verbleibend",
     "used": "Verwendet"
   },
+  "tool": {
+    "intervention": {
+      "approve": "Genehmigen",
+      "approveAndRemember": "Genehmigen und merken",
+      "approveOnce": "Nur dieses Mal genehmigen",
+      "mode": {
+        "allowList": "Positivliste",
+        "allowListDesc": "Nur automatisch genehmigte Tools ausführen",
+        "autoRun": "Automatisch genehmigen",
+        "autoRunDesc": "Alle Tool-Ausführungen automatisch genehmigen",
+        "manual": "Manuell",
+        "manualDesc": "Jede Ausführung muss manuell genehmigt werden"
+      },
+      "reject": "Ablehnen",
+      "rejectReasonPlaceholder": "Die Angabe eines Ablehnungsgrundes hilft dem Agenten, zukünftige Aktionen zu verbessern",
+      "rejectTitle": "Tool-Ausführung ablehnen",
+      "rejectedWithReason": "Die Tool-Ausführung wurde abgelehnt: {{reason}}",
+      "toolRejected": "Die Tool-Ausführung wurde abgelehnt"
+    }
+  },
   "topic": {
     "checkOpenNewTopic": "Soll ein neues Thema eröffnet werden?",
     "checkSaveCurrentMessages": "Möchten Sie die aktuelle Konversation als Thema speichern?",

package/locales/de-DE/common.json

@@ -135,6 +135,7 @@
     }
   },
   "close": "Schließen",
+  "confirm": "Bestätigen",
   "contact": "Kontakt",
   "copy": "Kopieren",
   "copyFail": "Kopieren fehlgeschlagen",

package/locales/de-DE/components.json

@@ -106,6 +106,12 @@
     "keyPlaceholder": "Schlüssel",
     "valuePlaceholder": "Wert"
   },
+  "LocalFile": {
+    "action": {
+      "open": "Öffnen",
+      "showInFolder": "Im Ordner anzeigen"
+    }
+  },
   "MaxTokenSlider": {
     "unlimited": "Unbegrenzt"
   },