@loaders.gl/tile-converter 3.3.0-alpha.4 → 3.3.0-alpha.5

package/dist/workers/3d-tiles-attributes-worker.js

@@ -6,4 +6,4 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const worker_utils_1 = require("@loaders.gl/worker-utils");
 const b3dm_converter_1 = __importDefault(require("../3d-tiles-converter/helpers/b3dm-converter"));
 const b3dmConverter = new b3dm_converter_1.default();
-(0, worker_utils_1.createWorker)(async (data, options = {}) => b3dmConverter.convert(data, options.attributes));
+(0, worker_utils_1.createWorker)(async (data, options = {}) => b3dmConverter.convert(data, options.featureAttributes));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@loaders.gl/tile-converter",
-  "version": "3.3.0-alpha.4",
+  "version": "3.3.0-alpha.5",
   "description": "Converter",
   "license": "MIT",
   "publishConfig": {
@@ -43,19 +43,19 @@
     "build-3d-tiles-attributes-worker": "esbuild src/workers/3d-tiles-attributes-worker.ts --outfile=dist/3d-tiles-attributes-worker.js --platform=node --target=esnext,node12 --minify --bundle --sourcemap --define:__VERSION__=\\\"$npm_package_version\\\""
   },
   "dependencies": {
-    "@loaders.gl/3d-tiles": "3.3.0-alpha.4",
-    "@loaders.gl/crypto": "3.3.0-alpha.4",
-    "@loaders.gl/draco": "3.3.0-alpha.4",
-    "@loaders.gl/gltf": "3.3.0-alpha.4",
-    "@loaders.gl/i3s": "3.3.0-alpha.4",
-    "@loaders.gl/images": "3.3.0-alpha.4",
-    "@loaders.gl/loader-utils": "3.3.0-alpha.4",
-    "@loaders.gl/polyfills": "3.3.0-alpha.4",
-    "@loaders.gl/schema": "3.3.0-alpha.4",
-    "@loaders.gl/textures": "3.3.0-alpha.4",
-    "@loaders.gl/tiles": "3.3.0-alpha.4",
-    "@loaders.gl/worker-utils": "3.3.0-alpha.4",
-    "@loaders.gl/zip": "3.3.0-alpha.4",
+    "@loaders.gl/3d-tiles": "3.3.0-alpha.5",
+    "@loaders.gl/crypto": "3.3.0-alpha.5",
+    "@loaders.gl/draco": "3.3.0-alpha.5",
+    "@loaders.gl/gltf": "3.3.0-alpha.5",
+    "@loaders.gl/i3s": "3.3.0-alpha.5",
+    "@loaders.gl/images": "3.3.0-alpha.5",
+    "@loaders.gl/loader-utils": "3.3.0-alpha.5",
+    "@loaders.gl/polyfills": "3.3.0-alpha.5",
+    "@loaders.gl/schema": "3.3.0-alpha.5",
+    "@loaders.gl/textures": "3.3.0-alpha.5",
+    "@loaders.gl/tiles": "3.3.0-alpha.5",
+    "@loaders.gl/worker-utils": "3.3.0-alpha.5",
+    "@loaders.gl/zip": "3.3.0-alpha.5",
     "@luma.gl/engine": "^8.5.4",
     "@math.gl/core": "^3.5.1",
     "@math.gl/culling": "^3.5.1",
@@ -75,5 +75,5 @@
   "peerDependencies": {
     "@loaders.gl/core": "^3.2.0"
   },
-  "gitHead": "d1c524fd3cb9296ecd1bf7d185765c4f6aaef6a1"
+  "gitHead": "d2df3bead97710c45fd2974cd51ecd7d5f7f5ea4"
 }

package/src/3d-tiles-attributes-worker.ts

@@ -26,7 +26,7 @@ export const Tile3dAttributesWorker = {
   module: 'tile-converter',
   version: VERSION,
   options: {
-    attributes: null
+    featureAttributes: null
   }
 };
 

package/src/3d-tiles-converter/helpers/b3dm-converter.ts

@@ -27,7 +27,7 @@ export default class B3dmConverter {
     i3sAttributesData: I3SAttributesData,
     featureAttributes: any = null
   ): Promise<ArrayBuffer> {
-    const gltf = await this.buildGltf(i3sAttributesData);
+    const gltf = await this.buildGltf(i3sAttributesData, featureAttributes);
     const b3dm = encodeSync(
       {
         gltfEncoded: new Uint8Array(gltf),
@@ -45,7 +45,10 @@ export default class B3dmConverter {
    * @param i3sTile - Tile3D instance for I3S node
    * @returns - encoded glb content
    */
-  async buildGltf(i3sAttributesData: I3SAttributesData): Promise<ArrayBuffer> {
+  async buildGltf(
+    i3sAttributesData: I3SAttributesData,
+    featureAttributes: any
+  ): Promise<ArrayBuffer> {
     const {tileContent, textureFormat} = i3sAttributesData;
     const {
       material,
@@ -77,6 +80,7 @@ export default class B3dmConverter {
       cartographicOrigin,
       modelMatrix
     );
+    this._createBatchIds(tileContent, featureAttributes);
     if (attributes.normals && !this._checkNormals(attributes.normals.value)) {
       delete attributes.normals;
     }
@@ -163,25 +167,28 @@ export default class B3dmConverter {
   }
 
   /**
-   * Generate batchId attribute from faceRanges.
-   * @param {Uint32Array} faceRanges - the source array
-   * @returns {Float32Array} batchId list.
+   * Create _BATCHID attribute
+   * @param {Object} i3sContent - the source object
+   * @returns {void}
    */
-  _generateBatchId(faceRanges) {
-    const batchIdArraySize = (faceRanges[faceRanges.length - 1] + 1) * 3;
-    const batchId = new Float32Array(batchIdArraySize);
-    let rangeIndex = 0;
-    let currentBatchId = 0;
-
-    for (let index = 0; index < faceRanges.length / 2; index++) {
-      const fromIndex = faceRanges[rangeIndex] * 3;
-      const untilPosition = (faceRanges[rangeIndex + 1] + 1) * 3;
+  _createBatchIds(i3sContent, featureAttributes) {
+    const {featureIds} = i3sContent;
+    const {OBJECTID: objectIds} = featureAttributes || {};
+    if (!featureIds || !objectIds) {
+      return;
+    }
 
-      batchId.fill(currentBatchId, fromIndex, untilPosition);
-      rangeIndex += 2;
-      currentBatchId += 1;
+    for (let i = 0; i < featureIds.length; i++) {
+      const featureId = featureIds[i];
+      const batchId = objectIds.indexOf(featureId);
+      featureIds[i] = batchId;
     }
-    return batchId;
+
+    i3sContent.attributes._BATCHID = {
+      size: 1,
+      byteOffset: 0,
+      value: featureIds
+    };
   }
 
   /**

package/src/workers/3d-tiles-attributes-worker.ts

@@ -3,4 +3,4 @@ import B3dmConverter from '../3d-tiles-converter/helpers/b3dm-converter';
 
 const b3dmConverter = new B3dmConverter();
 
-createWorker(async (data, options = {}) => b3dmConverter.convert(data, options.attributes));
+createWorker(async (data, options = {}) => b3dmConverter.convert(data, options.featureAttributes));