@linzjs/step-ag-grid 2.4.5 → 2.4.6

package/package.json

@@ -2,7 +2,7 @@
   "name": "@linzjs/step-ag-grid",
   "repository": "github:linz/step-ag-grid.git",
   "license": "MIT",
-  "version": "2.4.5",
+  "version": "2.4.6",
   "keywords": [
     "aggrid",
     "ag-grid",
@@ -53,7 +53,7 @@
     "css": "sass ./src/styles/index.scss:dist/index.css --no-source-map",
     "test": "react-scripts test",
     "eject": "react-scripts eject",
-    "lint": "eslint ./src --ext .js,.ts,.tsx --fix --cache",
+    "lint": "eslint ./src --ext .js,.ts,.tsx --fix --cache --ignore-path .gitignore",
     "storybook": "start-storybook -p 6006",
     "build-storybook": "build-storybook",
     "deploy-storybook": "npx --yes -p @storybook/storybook-deployer storybook-to-ghpages",

package/src/components/gridForm/{GridFormPopoutMenu.tsx → GridFormPopoverMenu.tsx}

@@ -29,7 +29,7 @@ export interface MenuOption<RowType> {
  * NOTE: If the popout menu doesn't appear on single click when also selecting row it's because
  * you need a useMemo around your columnDefs
  */
-export const GridFormPopoutMenu = <RowType extends GridBaseRow>(_props: GridFormPopoutMenuProps<RowType>) => {
+export const GridFormPopoverMenu = <RowType extends GridBaseRow>(_props: GridFormPopoutMenuProps<RowType>) => {
   const props = _props as GridFormPopoutMenuProps<RowType> & CellParams<RowType>;
   const { updatingCells } = useContext(GridContext);
   const optionsInitialising = useRef(false);

package/src/components/gridPopoverEdit/GridPopoverMenu.tsx

@@ -3,7 +3,7 @@ import "./GridPopoverMenu.scss";
 import { GenericMultiEditCellClass } from "../GenericCellClass";
 import { GridBaseRow } from "../Grid";
 import { ColDefT, GenericCellEditorProps, GridCell } from "../GridCell";
-import { GridFormPopoutMenu, GridFormPopoutMenuProps } from "../gridForm/GridFormPopoutMenu";
+import { GridFormPopoverMenu, GridFormPopoutMenuProps } from "../gridForm/GridFormPopoverMenu";
 import { GridRenderPopoutMenuCell } from "../gridRender/GridRenderPopoutMenuCell";
 import { GenericCellColDef } from "../gridRender/GridRenderGenericCell";
 
@@ -28,7 +28,7 @@ export const GridPopoverMenu = <RowType extends GridBaseRow>(
       },
     },
     {
-      editor: GridFormPopoutMenu,
+      editor: GridFormPopoverMenu,
       ...custom,
     },
   );

package/src/contexts/GridContextProvider.tsx

@@ -238,12 +238,7 @@ export const GridContextProvider = (props: GridContextProps): ReactElement => {
 
     return await gridApiOp(async (gridApi) => {
       const selectedRows = props.selectedRows;
-      //TODO do I need to do this for all rows?
-      /*if (!props.multiEdit) {
-        // You can't use data as it could be an orphaned reference due to updates
-        selectedRows = selectedRows.filter((row) => row.id === props.data.id);
-      }
-*/
+
       let ok = false;
       await modifyUpdating(
         props.field ?? "",

package/src/index.ts

@@ -30,7 +30,7 @@ export { GridPopoverTextInput } from "./components/gridPopoverEdit/GridPopoverTe
 export { GridFormSubComponentTextInput } from "./components/gridForm/GridFormSubComponentTextInput";
 export * from "./components/gridForm/GridFormDropDown";
 export * from "./components/gridForm/GridFormMultiSelect";
-export * from "./components/gridForm/GridFormPopoutMenu";
+export * from "./components/gridForm/GridFormPopoverMenu";
 
 export { GridHeaderSelect } from "./components/gridHeader/GridHeaderSelect";
 

package/src/react-menu3/components/ControlledMenu.tsx

@@ -88,7 +88,7 @@ export const ControlledMenuFr = (
       if (!isWithinMenu(ev.target)) {
         ev.preventDefault();
         ev.stopPropagation();
-        // FIXME There's an issue in React17
+        // Note: There's an issue in React17
         // the cell doesn't refresh during update if save is invoked from a native event
         // This doesn't happen in React18
         // To work around it, I invoke the save by clicking on a passed in invisible button ref

package/src/react-menu3/components/Menu.tsx

@@ -31,7 +31,7 @@ export interface MenuProps extends RootMenuProps, UncontrolledMenuProps {
 
 export function MenuFr(
   { "aria-label": ariaLabel, menuButton, instanceRef, onMenuChange, ...restProps }: MenuProps,
-  externalRef: ForwardedRef<any>, // FIXME Matt correct type?
+  externalRef: ForwardedRef<ReactElement>,
 ) {
   const [stateProps, toggleMenu, openMenu] = useMenuStateAndFocus(restProps);
   const isOpen = isMenuOpen(stateProps.state);
@@ -69,7 +69,7 @@ export function MenuFr(
     e.preventDefault();
   };
 
-  // FIXME erk! button seems to be many types
+  // Too many mixed types here to figure out what to pick for button.  Bad code.
   const button: any = safeCall(menuButton, { open: isOpen });
   if (!button || !button.type) throw new Error("Menu requires a menuButton prop.");
 

package/src/react-menu3/components/MenuButton.tsx

@@ -7,7 +7,7 @@ export interface MenuButtonProps extends BaseProps<MenuButtonModifiers> {
   disabled?: boolean;
   children?: ReactNode;
 
-  // FIXME Matt added, seems to be an internal thing
+  // Seems to be an internal thing, wasn't in original code
   isOpen?: boolean;
 }
 

package/src/react-menu3/components/MenuGroup.tsx

@@ -24,7 +24,6 @@ export const MenuGroupFr = (
   useLayoutEffect(() => {
     let maxHeight;
     if (takeOverflow && overflowAmt != null && overflowAmt >= 0 && ref.current) {
-      // FIXME Matt added && ref.current
       maxHeight = ref.current.getBoundingClientRect().height - overflowAmt;
       if (maxHeight < 0) maxHeight = 0;
     }
@@ -38,7 +37,7 @@ export const MenuGroupFr = (
   return (
     <div
       {...restProps}
-      ref={useCombinedRef(externalRef, ref)} // TODO wierd refs
+      ref={useCombinedRef(externalRef, ref)}
       className={useBEM({ block: menuClass, element: menuGroupClass, className })}
       style={{ ...style, ...overflowStyle }}
     />

package/src/react-menu3/components/MenuItem.tsx

@@ -89,11 +89,16 @@ const MenuItemFr = ({
   const isAnchor = !!href && !isDisabled && !isRadio && !isCheckBox;
   const isChecked = isRadio ? radioGroup.value === value : isCheckBox ? !!checked : false;
 
-  // FIXME handle click seems to be a combination of multiple event types
+  // handle click seems to be a combination of multiple event types, bad code.
   const handleClick = (e: any) => {
     if (isDisabled) {
-      e.stopPropagation();
-      e.preventDefault();
+      if (e.syntheticEvent) {
+        e.syntheticEvent.stopPropagation();
+        e.syntheticEvent.preventDefault();
+      } else {
+        e.stopPropagation();
+        e.preventDefault();
+      }
       return;
     }
 

package/src/react-menu3/components/SubMenu.tsx

@@ -175,7 +175,6 @@ export const SubMenuFr = ({
   const { isParentOpen, isSubmenuOpen, setOpenSubmenuCount, dispatch, updateItems } = useContext(MenuListItemContext);
   const isPortal = parentOverflow !== "visible";
 
-  // FIXME Matt no idea what's going on here
   const [stateProps, toggleMenu, _openMenu] = useMenuStateAndFocus(settings);
 
   const { state } = stateProps;

package/src/react-menu3/hooks/useBEM.ts

@@ -7,7 +7,7 @@ interface useBemProps {
   block: string;
   element?: string;
   modifiers?: useBemModifiers;
-  className?: ClassNameProp<any>; // FIXME Matt any?
+  className?: ClassNameProp<any>;
 }
 
 // Generate className following BEM methodology: http://getbem.com/naming/