@linzjs/step-ag-grid 2.4.5 → 2.4.6

package/dist/index.js

@@ -1313,7 +1313,7 @@ var ControlledMenuFr = function (_a, externalRef) {
         if (!isWithinMenu(ev.target)) {
             ev.preventDefault();
             ev.stopPropagation();
-            // FIXME There's an issue in React17
+            // Note: There's an issue in React17
             // the cell doesn't refresh during update if save is invoked from a native event
             // This doesn't happen in React18
             // To work around it, I invoke the save by clicking on a passed in invisible button ref
@@ -1461,7 +1461,7 @@ function MenuFr(_a, externalRef) {
         }
         e.preventDefault();
     };
-    // FIXME erk! button seems to be many types
+    // Too many mixed types here to figure out what to pick for button.  Bad code.
     var button = safeCall(menuButton, { open: isOpen });
     if (!button || !button.type)
         throw new Error("Menu requires a menuButton prop.");
@@ -1487,7 +1487,6 @@ var SubMenuFr = function (_a) {
     var _d = react.useContext(MenuListContext), parentMenuRef = _d.parentMenuRef, parentDir = _d.parentDir, parentOverflow = _d.overflow;
     var _e = react.useContext(MenuListItemContext), isParentOpen = _e.isParentOpen, isSubmenuOpen = _e.isSubmenuOpen, setOpenSubmenuCount = _e.setOpenSubmenuCount, dispatch = _e.dispatch, updateItems = _e.updateItems;
     var isPortal = parentOverflow !== "visible";
-    // FIXME Matt no idea what's going on here
     var _f = useMenuStateAndFocus(settings), stateProps = _f[0], toggleMenu = _f[1], _openMenu = _f[2];
     var state = stateProps.state;
     var isDisabled = !!disabled;
@@ -1633,11 +1632,17 @@ var MenuItemFr = function (_a) {
     var isCheckBox = type === "checkbox";
     var isAnchor = !!href && !isDisabled && !isRadio && !isCheckBox;
     var isChecked = isRadio ? radioGroup.value === value : isCheckBox ? !!checked : false;
-    // FIXME handle click seems to be a combination of multiple event types
+    // handle click seems to be a combination of multiple event types, bad code.
     var handleClick = function (e) {
         if (isDisabled) {
-            e.stopPropagation();
-            e.preventDefault();
+            if (e.syntheticEvent) {
+                e.syntheticEvent.stopPropagation();
+                e.syntheticEvent.preventDefault();
+            }
+            else {
+                e.stopPropagation();
+                e.preventDefault();
+            }
             return;
         }
         var event = {
@@ -1731,7 +1736,6 @@ var MenuGroupFr = function (_a, externalRef) {
     useIsomorphicLayoutEffect(function () {
         var maxHeight;
         if (takeOverflow && overflowAmt != null && overflowAmt >= 0 && ref.current) {
-            // FIXME Matt added && ref.current
             maxHeight = ref.current.getBoundingClientRect().height - overflowAmt;
             if (maxHeight < 0)
                 maxHeight = 0;
@@ -3266,7 +3270,7 @@ var PopoutMenuSeparator = Object.freeze({ __isMenuSeparator__: true });
  * NOTE: If the popout menu doesn't appear on single click when also selecting row it's because
  * you need a useMemo around your columnDefs
  */
-var GridFormPopoutMenu = function (_props) {
+var GridFormPopoverMenu = function (_props) {
     var props = _props;
     var updatingCells = react.useContext(GridContext).updatingCells;
     var optionsInitialising = react.useRef(false);
@@ -3339,7 +3343,7 @@ var GridPopoverMenu = function (colDef, custom) {
     return GridCell(__assign(__assign({ maxWidth: 40, editable: colDef.editable != null ? colDef.editable : true, cellStyle: { "justify-content": "flex-end" }, cellRenderer: GridRenderPopoutMenuCell, cellClass: (custom === null || custom === void 0 ? void 0 : custom.multiEdit) ? GenericMultiEditCellClass : undefined }, colDef), { cellRendererParams: {
             // Menus open on single click, this parameter is picked up in Grid.tsx
             singleClickEdit: true
-        } }), __assign({ editor: GridFormPopoutMenu }, custom));
+        } }), __assign({ editor: GridFormPopoverMenu }, custom));
 };
 
 var bearingValueFormatter = function (params) {
@@ -3911,7 +3915,7 @@ exports.GridContext = GridContext;
 exports.GridContextProvider = GridContextProvider;
 exports.GridFormDropDown = GridFormDropDown;
 exports.GridFormMultiSelect = GridFormMultiSelect;
-exports.GridFormPopoutMenu = GridFormPopoutMenu;
+exports.GridFormPopoverMenu = GridFormPopoverMenu;
 exports.GridFormSubComponentTextInput = GridFormSubComponentTextInput;
 exports.GridHeaderSelect = GridHeaderSelect;
 exports.GridIcon = GridIcon;