@linimin/pi-letscook 0.1.45 → 0.1.47

package/scripts/active-slice-contract-test.sh

@@ -75,11 +75,12 @@ assertIncludes('README.md', 'Deterministic active-slice contract regression now
 assertIncludes('README.md', 'includes deterministic active-slice contract coverage plus observability coverage');
 assertIncludes('scripts/release-check.sh', 'bash ./scripts/active-slice-contract-test.sh');
 assertIncludes('.agent/verify_completion_stop.sh', 'npm run release-check >/dev/null');
-assertIncludes('extensions/completion/index.ts', "const planMirrorFields = ['locked_notes', 'must_fix_findings', 'implementation_surfaces', 'verification_commands', 'basis_commit', 'remaining_contract_ids_before', 'release_blocker_count_before', 'high_value_gap_count_before'];");
-assertIncludes('extensions/completion/index.ts', 'Selected/in-progress/committed/done .agent/active-slice.json is the canonical implementation contract.');
-assertIncludes('extensions/completion/index.ts', 'Active slice contract drift: ${activeContractDrift}');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildVerifyControlPlaneScript(');
+assertIncludes('extensions/completion/state-store.ts', 'return fs.readFileSync(trackedScriptPath, "utf8");');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Selected/in-progress/committed/done .agent/active-slice.json is the canonical implementation contract.');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Active slice contract drift: ${args.activeContractDrift}');
 assertIncludes('extensions/completion/index.ts', 'Canonical active-slice contract drift is currently: ${activeContractDrift}');
-assertIncludes('extensions/completion/index.ts', '`active_slice_contract_drift_fields: ${activeContractDrift}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`active_slice_contract_drift_fields: ${args.activeSliceContractDrift}`');
 assertIncludes('extensions/completion/index.ts', 'treat .agent/active-slice.json as the canonical implementation contract');
 assertIncludes('.agent/verify_completion_control_plane.sh', "const planMirrorFields = ['locked_notes', 'must_fix_findings', 'implementation_surfaces', 'verification_commands', 'basis_commit', 'remaining_contract_ids_before', 'release_blocker_count_before', 'high_value_gap_count_before'];");
 assertIncludes('.agent/verify_completion_control_plane.sh', 'slice_id must match a slice in .agent/plan.json when status carries an exact handoff');

package/scripts/canonical-evidence-artifact-test.sh

@@ -96,11 +96,11 @@ assertSectionIncludes('skills/completion-protocol/references/completion.md', '##
 assertSectionIncludes('skills/completion-protocol/references/completion.md', '## Canonical Inputs', '- `.agent/verification-evidence.json`');
 assertSectionIncludes('skills/completion-protocol/references/completion.md', '## Compaction And Recovery', '- `.agent/verification-evidence.json`');
 assertSectionIncludes('skills/completion-protocol/references/completion.md', '## Compaction And Recovery', '`completion-implementer` must also re-read canonical `.agent/state.json`, `.agent/plan.json`, `.agent/active-slice.json`, and `.agent/verification-evidence.json` before resuming work.');
-assertIncludes('extensions/completion/index.ts', 'Verification evidence artifact: ${evidence.path}');
-assertIncludes('extensions/completion/index.ts', 'Verification evidence summary: ${evidence.summary}');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Verification evidence artifact: ${args.evidence.path} (${args.evidence.status})');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Verification evidence summary: ${args.evidence.summary}');
 assertIncludes('extensions/completion/index.ts', 'Canonical verification evidence artifact is currently: ${evidence.path} (${evidence.status})');
-assertIncludes('extensions/completion/index.ts', '`- verification_evidence_path: ${evidence.path}`');
-assertIncludes('extensions/completion/index.ts', '`- verification_evidence_summary: ${evidence.summary}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- verification_evidence_path: ${evidence.path}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- verification_evidence_summary: ${evidence.summary}`');
 assertIncludes('extensions/completion/index.ts', 'Consume .agent/verification-evidence.json instead of temp-only verification summaries when it is populated.');
 assertIncludes('scripts/release-check.sh', 'bash .agent/verify_completion_control_plane.sh');
 assertIncludes('scripts/release-check.sh', 'bash ./scripts/canonical-evidence-artifact-test.sh');

package/scripts/context-proposal-test.sh

@@ -158,6 +158,85 @@ PY
 
 rm -rf .agent
 
+# No workflow yet: when multiple structured discussions exist, bare /cook should prioritize the latest
+# concrete implementation mission instead of failing closed on older structured context.
+SESSION_ZERO_LATEST_WINDOW="$TMPDIR/session-zero-latest-window.jsonl"
+DISCUSSION_ZERO_LATEST_OLDER=$'Mission: Remove the completion status line while keeping the completion widget.\nScope:\n- Keep the non-running completion widget.\nConstraints:\n- Do not reintroduce any other completion status surface.\nAcceptance:\n- Keep observability regression coverage truthful.'
+DISCUSSION_ZERO_LATEST_NEWER=$'Mission: Fix login redirect callback behavior.\nScope:\n- Update the callback redirect decision logic.\nConstraints:\n- Do not refactor the broader auth flow.\nAcceptance:\n- Add a regression test for returning to the requested page.'
+DISCUSSION_SNAPSHOT_ZERO_LATEST_WINDOW="$TMPDIR/context-proposal-latest-window.json"
+python3 - "$SESSION_ZERO_LATEST_WINDOW" "$ROOT" "$DISCUSSION_ZERO_LATEST_OLDER" "$DISCUSSION_ZERO_LATEST_NEWER" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+session_path = Path(sys.argv[1])
+cwd = sys.argv[2]
+older = sys.argv[3]
+newer = sys.argv[4]
+session_path.parent.mkdir(parents=True, exist_ok=True)
+entries = [
+    {
+        "type": "session",
+        "version": 3,
+        "id": "11111111-1111-4111-8111-111111111111",
+        "timestamp": "2026-01-01T00:00:00.000Z",
+        "cwd": cwd,
+    },
+    {
+        "type": "message",
+        "id": "a1b2c3d4",
+        "parentId": None,
+        "timestamp": "2026-01-01T00:00:01.000Z",
+        "message": {
+            "role": "user",
+            "content": older,
+            "timestamp": 1767225601000,
+        },
+    },
+    {
+        "type": "message",
+        "id": "b2c3d4e5",
+        "parentId": "a1b2c3d4",
+        "timestamp": "2026-01-01T00:00:02.000Z",
+        "message": {
+            "role": "user",
+            "content": newer,
+            "timestamp": 1767225602000,
+        },
+    },
+]
+with session_path.open('w', encoding='utf-8') as fh:
+    for entry in entries:
+        fh.write(json.dumps(entry, ensure_ascii=False) + "\n")
+PY
+
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$DISCUSSION_SNAPSHOT_ZERO_LATEST_WINDOW" \
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+pi --session "$SESSION_ZERO_LATEST_WINDOW" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-context-proposal-latest-window.out" 2>"$TMPDIR/pi-completion-context-proposal-latest-window.err"
+
+python3 - "$DISCUSSION_SNAPSHOT_ZERO_LATEST_WINDOW" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+mission = 'Fix login redirect callback behavior.'
+proposal = json.loads(Path(sys.argv[1]).read_text())
+state = json.loads(Path('.agent/state.json').read_text())
+plan = json.loads(Path('.agent/plan.json').read_text())
+active = json.loads(Path('.agent/active-slice.json').read_text())
+
+assert proposal['mission'] == mission, 'latest structured discussion should win over older structured context'
+assert proposal['scope'] == ['Update the callback redirect decision logic.'], 'latest structured discussion should preserve the latest scope only'
+assert proposal['analysis']['suppressedNegatedTopics'] == ['Do not refactor the broader auth flow.'], 'latest structured discussion should preserve negated implementation topics separately from the mission'
+assert state['mission_anchor'] == mission, 'latest structured discussion should initialize state.json with the latest mission'
+assert plan['mission_anchor'] == mission, 'latest structured discussion should initialize plan.json with the latest mission'
+assert active['mission_anchor'] == mission, 'latest structured discussion should initialize active-slice.json with the latest mission'
+PY
+
+rm -rf .agent
+
 # No workflow yet: bare /cook should fail closed when a required structured section is missing and analyst output is unavailable.
 SESSION_ZERO_MISSING="$TMPDIR/session-zero-missing-section.jsonl"
 DISCUSSION_ZERO_MISSING=$'Mission: Remove the completion status line while keeping the completion widget.\nScope:\n- Keep the non-running completion widget.\n- Suppress the widget while a completion role is active.\nConstraints:\n- Do not reintroduce any other completion status surface.'
@@ -182,26 +261,35 @@ assert '/cook failed closed' in output, 'missing-section structured discussion s
 assert 'Mission/Scope/Constraints/Acceptance' in output, 'missing-section structured discussion should explain the strict fallback requirement'
 PY
 
-# No workflow yet: bare /cook should fail closed on ambiguous structured discussion when analyst output is unavailable.
+# No workflow yet: when one structured discussion message contains multiple complete mission blocks,
+# bare /cook should prioritize the latest block and preserve earlier blocks as alternate missions.
 SESSION_ZERO_AMBIG="$TMPDIR/session-zero-ambiguous.jsonl"
-DISCUSSION_ZERO_AMBIG=$'Mission: Remove the completion status line while keeping the completion widget.\nScope:\n- Keep the non-running completion widget.\nConstraints:\n- Do not reintroduce any other completion status surface.\nAcceptance:\n- Update README to match the shipped behavior.\nMission: Ship an unrelated widget overhaul.\nScope:\n- Replace the widget entirely.'
+DISCUSSION_ZERO_AMBIG=$'Mission: Remove the completion status line while keeping the completion widget.\nScope:\n- Keep the non-running completion widget.\nConstraints:\n- Do not reintroduce any other completion status surface.\nAcceptance:\n- Update README to match the shipped behavior.\nMission: Ship an unrelated widget overhaul.\nScope:\n- Replace the widget entirely.\nConstraints:\n- Do not modify the completion widget.\nAcceptance:\n- Land the unrelated overhaul changes only.'
+DISCUSSION_SNAPSHOT_ZERO_AMBIG="$TMPDIR/context-proposal-ambiguous-latest-block.json"
 write_session "$SESSION_ZERO_AMBIG" "$ROOT" "$DISCUSSION_ZERO_AMBIG"
 
 PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
 PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$DISCUSSION_SNAPSHOT_ZERO_AMBIG" \
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
 pi --session "$SESSION_ZERO_AMBIG" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-context-proposal-ambiguous.out" 2>"$TMPDIR/pi-completion-context-proposal-ambiguous.err"
 
-python3 - "$TMPDIR/pi-completion-context-proposal-ambiguous.out" "$TMPDIR/pi-completion-context-proposal-ambiguous.err" <<'PY'
+python3 - "$DISCUSSION_SNAPSHOT_ZERO_AMBIG" <<'PY'
+import json
 import sys
 from pathlib import Path
 
-output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
-assert not Path('.agent').exists(), 'ambiguous structured discussion should fail closed without writing canonical state'
-assert '/cook failed closed' in output, 'ambiguous structured discussion should explain the fail-closed startup outcome'
-assert 'Mission/Scope/Constraints/Acceptance' in output, 'ambiguous structured discussion should explain the strict fallback requirement'
+mission = 'Ship an unrelated widget overhaul.'
+proposal = json.loads(Path(sys.argv[1]).read_text())
+state = json.loads(Path('.agent/state.json').read_text())
+
+assert proposal['mission'] == mission, 'latest complete mission block should win inside a single structured discussion message'
+assert proposal['analysis']['alternateMissions'] == ['Remove the completion status line while keeping the completion widget.'], 'earlier complete mission blocks should be preserved as alternate missions'
+assert state['mission_anchor'] == mission, 'latest complete mission block should initialize canonical mission state'
 PY
 
+rm -rf .agent
+
 # No workflow yet: bare /cook structured fallback should normalize placeholder planning phrasing
 # into the concrete implementation mission when scope/acceptance clearly describe shipped work.
 SESSION_ZERO_NORMALIZED="$TMPDIR/session-zero-normalized.jsonl"
@@ -699,6 +787,100 @@ assert plan['mission_anchor'] == mission, 'summary-only active bare /cook should
 assert active['mission_anchor'] == mission, 'summary-only active bare /cook should keep active-slice.json unchanged'
 PY
 
+# Active workflow: when recent discussion suggests a different implementation goal but the proposal is
+# still incomplete, bare /cook should surface the chooser instead of silently resuming the current workflow.
+SESSION_ONE_AMBIGUOUS_CHOOSER="$TMPDIR/session-one-ambiguous-chooser.jsonl"
+DISCUSSION_ONE_AMBIGUOUS_CHOOSER=$'Mission: Fix login redirect callback behavior.\nScope:\n- Update the callback redirect decision logic for the current auth flow.'
+AMBIGUOUS_ROUTING_ONE="$TMPDIR/active-ambiguous-routing.json"
+AMBIGUOUS_CHOOSER_ONE="$TMPDIR/active-ambiguous-chooser.json"
+AMBIGUOUS_RESUME_PROMPT_ONE="$TMPDIR/unexpected-active-ambiguous-resume.txt"
+AMBIGUOUS_PROPOSAL_ONE="$TMPDIR/unexpected-active-ambiguous-proposal.json"
+write_session "$SESSION_ONE_AMBIGUOUS_CHOOSER" "$ROOT" "$DISCUSSION_ONE_AMBIGUOUS_CHOOSER"
+
+PI_COMPLETION_EXISTING_WORKFLOW_ACTION=cancel \
+PI_COMPLETION_CONTEXT_PROPOSAL_ANALYST_OUTPUT='{"mission":"Fix login redirect callback behavior.","scope":["Update the callback redirect decision logic for the current auth flow."],"constraints":[],"acceptance":[],"task_type":"completion-workflow","evaluation_profile":"completion-rubric-v1","confidence":0.72,"possible_noise":["older completion widget cleanup"]}' \
+PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$AMBIGUOUS_ROUTING_ONE" \
+PI_COMPLETION_TEST_EXISTING_WORKFLOW_CHOOSER_PATH="$AMBIGUOUS_CHOOSER_ONE" \
+PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$AMBIGUOUS_RESUME_PROMPT_ONE" \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$AMBIGUOUS_PROPOSAL_ONE" \
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+pi --session "$SESSION_ONE_AMBIGUOUS_CHOOSER" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-context-proposal-active-ambiguous-chooser.out" 2>"$TMPDIR/pi-completion-context-proposal-active-ambiguous-chooser.err"
+
+python3 - "$AMBIGUOUS_ROUTING_ONE" "$AMBIGUOUS_CHOOSER_ONE" "$AMBIGUOUS_RESUME_PROMPT_ONE" "$AMBIGUOUS_PROPOSAL_ONE" "$TMPDIR/pi-completion-context-proposal-active-ambiguous-chooser.out" "$TMPDIR/pi-completion-context-proposal-active-ambiguous-chooser.err" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+mission = 'Remove the completion status line while keeping the completion widget.'
+routing = json.loads(Path(sys.argv[1]).read_text())
+chooser = json.loads(Path(sys.argv[2]).read_text())
+resume_path = Path(sys.argv[3])
+proposal_path = Path(sys.argv[4])
+output = Path(sys.argv[5]).read_text() + Path(sys.argv[6]).read_text()
+state = json.loads(Path('.agent/state.json').read_text())
+plan = json.loads(Path('.agent/plan.json').read_text())
+active = json.loads(Path('.agent/active-slice.json').read_text())
+
+assert routing['mode'] == 'bare', 'ambiguous active bare /cook should snapshot bare routing mode'
+assert routing['action'] == 'unclear', 'incomplete replacement discussion should stay ambiguous until the chooser resolves it'
+assert routing['reason'] == 'ambiguous_discussion', 'incomplete replacement discussion should record the ambiguous-discussion reason'
+assert routing['currentMissionAnchor'] == mission, 'ambiguous chooser routing should preserve the current mission anchor'
+assert routing['proposedMissionAnchor'] == 'Fix login redirect callback behavior.', 'ambiguous chooser routing should expose the latest inferred mission'
+assert chooser['title'].startswith('Existing completion workflow found'), 'ambiguous active bare /cook should still open the existing-workflow chooser'
+assert chooser['choices'][0].startswith('Continue current workflow'), 'ambiguous chooser should keep the continue option'
+assert chooser['choices'][1].startswith('Start new workflow from recent discussion'), 'ambiguous chooser should offer the recent-discussion replacement option'
+assert not resume_path.exists(), 'ambiguous active bare /cook should not silently queue a resume prompt before the chooser resolves it'
+assert not proposal_path.exists(), 'ambiguous chooser cancel should not open the final proposal confirmation'
+assert 'Discuss changes in the main chat and rerun /cook.' in output, 'ambiguous chooser cancel should redirect users back to the main chat and rerun /cook'
+assert state['mission_anchor'] == mission, 'ambiguous chooser cancel should keep state.json unchanged'
+assert plan['mission_anchor'] == mission, 'ambiguous chooser cancel should keep plan.json unchanged'
+assert active['mission_anchor'] == mission, 'ambiguous chooser cancel should keep active-slice.json unchanged'
+PY
+
+# Active workflow: when recent discussion contains multiple complete replacement missions, bare /cook should
+# surface all candidates and allow the chooser to select a non-primary alternate mission.
+SESSION_ONE_MULTI_CANDIDATE="$TMPDIR/session-one-multi-candidate.jsonl"
+DISCUSSION_ONE_MULTI_CANDIDATE=$'Mission: Fix login redirect callback behavior.\nScope:\n- Update the callback redirect decision logic for the current auth flow.\nConstraints:\n- Do not refactor the broader auth flow.\nAcceptance:\n- Add a regression test for returning to the requested page.\nMission: Add logout redirect regression coverage.\nScope:\n- Add coverage for logout redirect behavior.\nConstraints:\n- Do not change login redirect behavior in this pass.\nAcceptance:\n- Land a dedicated logout redirect regression test.'
+MULTI_ROUTING_ONE="$TMPDIR/active-multi-routing.json"
+MULTI_CHOOSER_ONE="$TMPDIR/active-multi-chooser.json"
+MULTI_PROPOSAL_ONE="$TMPDIR/active-multi-proposal.json"
+write_session "$SESSION_ONE_MULTI_CANDIDATE" "$ROOT" "$DISCUSSION_ONE_MULTI_CANDIDATE"
+
+PI_COMPLETION_EXISTING_WORKFLOW_MISSION='Fix login redirect callback behavior.' \
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$MULTI_ROUTING_ONE" \
+PI_COMPLETION_TEST_EXISTING_WORKFLOW_CHOOSER_PATH="$MULTI_CHOOSER_ONE" \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$MULTI_PROPOSAL_ONE" \
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+pi --session "$SESSION_ONE_MULTI_CANDIDATE" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-context-proposal-active-multi.out" 2>"$TMPDIR/pi-completion-context-proposal-active-multi.err"
+
+python3 - "$MULTI_ROUTING_ONE" "$MULTI_CHOOSER_ONE" "$MULTI_PROPOSAL_ONE" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+selected = 'Fix login redirect callback behavior.'
+routing = json.loads(Path(sys.argv[1]).read_text())
+chooser = json.loads(Path(sys.argv[2]).read_text())
+proposal = json.loads(Path(sys.argv[3]).read_text())
+state = json.loads(Path('.agent/state.json').read_text())
+plan = json.loads(Path('.agent/plan.json').read_text())
+active = json.loads(Path('.agent/active-slice.json').read_text())
+
+assert routing['action'] == 'unclear', 'multi-candidate replacement discussion should stay ambiguous until the chooser selects one mission'
+assert routing['reason'] == 'ambiguous_discussion', 'multi-candidate replacement discussion should record ambiguous-discussion routing'
+assert routing['alternateMissions'] == ['Fix login redirect callback behavior.'], 'routing snapshot should preserve alternate candidate missions'
+assert chooser['candidateMissions'] == ['Add logout redirect regression coverage.', 'Fix login redirect callback behavior.'], 'chooser snapshot should list the primary and alternate candidate missions'
+assert len(chooser['choices']) == 4, 'chooser should expose continue, primary, alternate, and cancel choices'
+assert 'Scope\n- Add coverage for logout redirect behavior.' in chooser['choices'][1], 'primary chooser option should summarize the candidate scope'
+assert 'Acceptance\n- Add a regression test for returning to the requested page.' in chooser['choices'][2], 'alternate chooser option should summarize the candidate acceptance'
+assert proposal['mission'] == selected, 'selected alternate mission should flow into the final proposal confirmation'
+assert state['mission_anchor'] == selected, 'selected alternate mission should rewrite state.json after approval'
+assert plan['mission_anchor'] == selected, 'selected alternate mission should rewrite plan.json after approval'
+assert active['mission_anchor'] == selected, 'selected alternate mission should rewrite active-slice.json after approval'
+PY
+
 # Active workflow: bare /cook with a placeholder planning mission should still route through the existing
 # refocus chooser and final Start/Cancel gate before canonical state is rewritten.
 SESSION_ONE_REFOCUS_NORMALIZED="$TMPDIR/session-one-refocus-normalized.jsonl"
@@ -747,10 +929,93 @@ assert plan['mission_anchor'] == mission, 'active bare /cook refocus should rewr
 assert active['mission_anchor'] == mission, 'active bare /cook refocus should rewrite active-slice.json only after approval'
 PY
 
-# Completed workflow: bare /cook should normalize placeholder planning phrasing for the next workflow
-# round too, not only for fresh startup.
+# Completed workflow: bare /cook should suppress proposals that simply restate the completed mission
+# without a clear reopen or next-round signal.
 mark_done
 
+SESSION_TWO_COMPLETED_SUPPRESS="$TMPDIR/session-two-completed-suppress.jsonl"
+CURRENT_DONE_MISSION="$(python3 - <<'PY'
+import json
+from pathlib import Path
+print(json.loads(Path('.agent/state.json').read_text())['mission_anchor'])
+PY
+)"
+DISCUSSION_TWO_COMPLETED_SUPPRESS="Mission: ${CURRENT_DONE_MISSION}
+Scope:
+- Keep the current completed mission exactly as-is.
+Constraints:
+- Do not start a different workflow from this discussion.
+Acceptance:
+- Keep the finished mission closed and unchanged."
+DISCUSSION_SNAPSHOT_TWO_COMPLETED_SUPPRESS="$TMPDIR/context-proposal-next-round-completed-suppress.json"
+write_session "$SESSION_TWO_COMPLETED_SUPPRESS" "$ROOT" "$DISCUSSION_TWO_COMPLETED_SUPPRESS"
+
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$DISCUSSION_SNAPSHOT_TWO_COMPLETED_SUPPRESS" \
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+pi --session "$SESSION_TWO_COMPLETED_SUPPRESS" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-context-proposal-next-round-completed-suppress.out" 2>"$TMPDIR/pi-completion-context-proposal-next-round-completed-suppress.err"
+
+python3 - "$TMPDIR/pi-completion-context-proposal-next-round-completed-suppress.out" "$TMPDIR/pi-completion-context-proposal-next-round-completed-suppress.err" "$DISCUSSION_SNAPSHOT_TWO_COMPLETED_SUPPRESS" "$CURRENT_DONE_MISSION" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
+snapshot = Path(sys.argv[3])
+expected = sys.argv[4]
+state = json.loads(Path('.agent/state.json').read_text())
+
+assert state['mission_anchor'] == expected, 'completed-topic suppression should keep the done workflow mission anchor unchanged'
+assert state['continuation_policy'] == 'done', 'completed-topic suppression should keep the workflow closed'
+assert not snapshot.exists(), 'completed-topic suppression should not emit a proposal snapshot when the latest discussion only repeats finished work'
+assert '/cook failed closed' in output, 'completed-topic suppression should fail closed instead of reopening the finished mission'
+PY
+
+# Completed workflow: bare /cook should also suppress proposals that merely restate canonical
+# verification evidence for already verified work.
+python3 - <<'PY'
+import json
+from pathlib import Path
+
+state = json.loads(Path('.agent/state.json').read_text())
+state['latest_verified_slice'] = 'verified-logout-redirect'
+Path('.agent/state.json').write_text(json.dumps(state, indent=2) + '\n')
+
+evidence = json.loads(Path('.agent/verification-evidence.json').read_text())
+evidence.update({
+    'subject_type': 'selected_slice',
+    'slice_id': 'verified-logout-redirect',
+    'goal': 'Add logout redirect regression coverage.',
+    'summary': 'Verified logout redirect regression coverage already matches the selected slice and current HEAD.',
+    'outcome': 'pass',
+})
+Path('.agent/verification-evidence.json').write_text(json.dumps(evidence, indent=2) + '\n')
+PY
+
+SESSION_TWO_VERIFIED_SUPPRESS="$TMPDIR/session-two-verified-suppress.jsonl"
+DISCUSSION_TWO_VERIFIED_SUPPRESS=$'Mission: Add logout redirect regression coverage.\nScope:\n- Add coverage for logout redirect behavior.\nConstraints:\n- Do not change the verified logout redirect work.\nAcceptance:\n- Keep the verified logout redirect regression coverage unchanged.'
+DISCUSSION_SNAPSHOT_TWO_VERIFIED_SUPPRESS="$TMPDIR/context-proposal-next-round-verified-suppress.json"
+write_session "$SESSION_TWO_VERIFIED_SUPPRESS" "$ROOT" "$DISCUSSION_TWO_VERIFIED_SUPPRESS"
+
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$DISCUSSION_SNAPSHOT_TWO_VERIFIED_SUPPRESS" \
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+pi --session "$SESSION_TWO_VERIFIED_SUPPRESS" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-context-proposal-next-round-verified-suppress.out" 2>"$TMPDIR/pi-completion-context-proposal-next-round-verified-suppress.err"
+
+python3 - "$TMPDIR/pi-completion-context-proposal-next-round-verified-suppress.out" "$TMPDIR/pi-completion-context-proposal-next-round-verified-suppress.err" "$DISCUSSION_SNAPSHOT_TWO_VERIFIED_SUPPRESS" <<'PY'
+import sys
+from pathlib import Path
+
+output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
+snapshot = Path(sys.argv[3])
+assert not snapshot.exists(), 'verification-evidence overlap suppression should not emit a proposal snapshot for already verified work'
+assert '/cook failed closed' in output, 'verification-evidence overlap suppression should fail closed when the latest discussion only repeats verified work'
+PY
+
+# Completed workflow: bare /cook should normalize placeholder planning phrasing for the next workflow
+# round too, not only for fresh startup.
 SESSION_TWO_NORMALIZED="$TMPDIR/session-two-normalized.jsonl"
 DISCUSSION_TWO_NORMALIZED=$'Mission: 開始實作這個方案\nScope:\n- Normalize bare /cook planning phrasing for the next workflow round.\n- Reset canonical state for the new implementation mission.\nConstraints:\n- Do not resume the completed workflow when the new round is clearly different.\nAcceptance:\n- Start a new round with the normalized mission anchor.'
 DISCUSSION_SNAPSHOT_TWO_NORMALIZED="$TMPDIR/context-proposal-next-round-normalized.json"
@@ -836,8 +1101,8 @@ assert plan['plan_basis'] == 'user_refocus', 'plan_basis should reset to user_re
 assert active['status'] == 'idle', 'active-slice should reset to idle for the next workflow round'
 PY
 
-# Active workflow: inline /cook hint should flow through routing plus final proposal confirmation
-# and still leave canonical state unchanged when the final proposal is cancelled.
+# Active workflow: /cook <text> should be rejected before routing or proposal confirmation
+# and still leave canonical state unchanged.
 ACTIVE_INLINE_REJECTION_ROUTING="$TMPDIR/context-proposal-active-inline-arg-routing.json"
 ACTIVE_INLINE_REJECTION_PROPOSAL="$TMPDIR/context-proposal-active-inline-arg-proposal.json"
 ACTIVE_INLINE_REJECTION_CHOOSER="$TMPDIR/context-proposal-active-inline-arg-chooser.json"
@@ -886,15 +1151,16 @@ tracked = [
     Path('.agent/verification-evidence.json'),
 ]
 
-assert routing.exists(), 'active inline /cook hint should run active-workflow routing'
-assert proposal.exists(), 'active inline /cook hint should open final proposal confirmation after refocus is chosen'
-assert chooser.exists(), 'active inline /cook hint should open the existing-workflow chooser'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'active /cook <text> rejection should explain the bare-only contract'
+assert not routing.exists(), 'active /cook <text> rejection should not run active-workflow routing'
+assert not proposal.exists(), 'active /cook <text> rejection should not open proposal confirmation'
+assert not chooser.exists(), 'active /cook <text> rejection should not open the existing-workflow chooser'
 after = {path.name: path.read_text() for path in tracked}
-assert before == after, 'active inline /cook hint should leave canonical files unchanged when confirmation is cancelled'
+assert before == after, 'active /cook <text> rejection should leave canonical files unchanged'
 PY
 
-# Completed workflow: inline /cook hint should also drive the next-round proposal and leave
-# canonical state unchanged when the proposal is cancelled.
+# Completed workflow: /cook <text> should be rejected before any next-round proposal is derived
+# and still leave canonical state unchanged.
 mark_done
 
 DONE_INLINE_REJECTION_ROUTING="$TMPDIR/context-proposal-done-inline-arg-routing.json"
@@ -944,13 +1210,14 @@ tracked = [
     Path('.agent/verification-evidence.json'),
 ]
 state_before = json.loads(before['state.json'])
-assert state_before['current_phase'] == 'done', 'done inline /cook rejection should start from a completed workflow'
-assert state_before['project_done'] is True, 'done inline /cook rejection should start from project_done=true'
-assert not routing.exists(), 'done inline /cook args should not run active/done workflow routing'
-assert proposal.exists(), 'done inline /cook hint should open next-round proposal confirmation'
-assert not chooser.exists(), 'done inline /cook args should not open the chooser flow'
+assert state_before['current_phase'] == 'done', 'done /cook <text> rejection should start from a completed workflow'
+assert state_before['project_done'] is True, 'done /cook <text> rejection should start from project_done=true'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'done /cook <text> rejection should explain the bare-only contract'
+assert not routing.exists(), 'done /cook <text> rejection should not run active/done workflow routing'
+assert not proposal.exists(), 'done /cook <text> rejection should not open next-round proposal confirmation'
+assert not chooser.exists(), 'done /cook <text> rejection should not open the chooser flow'
 after = {path.name: path.read_text() for path in tracked}
-assert before == after, 'done inline /cook hint cancel should leave canonical files unchanged'
+assert before == after, 'done /cook <text> rejection should leave canonical files unchanged'
 PY
 
 # Completed workflow again: /cook with no goal should be able to use model-assisted
@@ -1086,4 +1353,9 @@ assert 'Discuss changes in the main chat and rerun /cook.' in output, 'cancel co
 assert not Path('.agent').exists(), 'cancel action should not write canonical workflow state'
 PY
 
+grep -q 'export async function deriveCookContextProposalFromRecentDiscussion' "$PKG_ROOT/extensions/completion/proposal.ts"
+grep -q 'export function parseContextProposalAnalystOutput' "$PKG_ROOT/extensions/completion/proposal.ts"
+grep -q 'export function buildContextProposalConfirmationLayout' "$PKG_ROOT/extensions/completion/prompt-surfaces.ts"
+grep -q 'export function buildEvaluationRoleContextLines' "$PKG_ROOT/extensions/completion/prompt-surfaces.ts"
+
 echo "context proposal test passed: $ROOT"

package/scripts/legacy-cleanup-test.sh

@@ -0,0 +1,107 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$ROOT"
+
+node <<'NODE'
+const fs = require('node:fs');
+
+const read = (file) => fs.readFileSync(file, 'utf8');
+const assertIncludes = (file, snippet) => {
+  const text = read(file);
+  if (!text.includes(snippet)) {
+    throw new Error(`${file} is missing expected legacy-cleanup ownership text: ${snippet}`);
+  }
+};
+const assertNotIncludes = (file, snippet) => {
+  const text = read(file);
+  if (text.includes(snippet)) {
+    throw new Error(`${file} still contains stale monolith ownership text: ${snippet}`);
+  }
+};
+
+assertIncludes('extensions/completion/state-store.ts', 'export async function scaffoldCompletionFiles(');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildAgentReadme(');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildVerifyStopScript(');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildVerifyControlPlaneScript(');
+assertIncludes('extensions/completion/state-store.ts', 'export function currentTaskType(');
+assertIncludes('extensions/completion/state-store.ts', 'export function currentEvaluationProfile(');
+
+assertIncludes('extensions/completion/status-surface.ts', 'export function nowMs(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function formatElapsed(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function createLiveRoleActivity(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function cloneLiveRoleActivity(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function applyLiveRoleEvent(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function pushRecentActivity(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function truncateInline(');
+
+assertIncludes('extensions/completion/proposal.ts', 'export function normalizeMissionAnchorText(');
+assertIncludes('extensions/completion/proposal.ts', 'export function isWeakMissionAnchor(');
+assertIncludes('extensions/completion/proposal.ts', 'export function deriveMissionAnchor(');
+assertIncludes('extensions/completion/proposal.ts', 'export function assessMissionAnchor(');
+assertIncludes('extensions/completion/proposal.ts', 'export function stripCodeBlocks(');
+assertIncludes('extensions/completion/proposal.ts', 'export function missionAnchorsStrictlyEquivalent(');
+assertIncludes('extensions/completion/proposal.ts', 'export function missionAnchorsLikelyEquivalent(');
+assertIncludes('extensions/completion/proposal.ts', 'export function collectRecentDiscussionEntries(');
+assertIncludes('extensions/completion/proposal.ts', 'export function serializeRecentDiscussionEntries(');
+assertIncludes('extensions/completion/proposal.ts', 'export function extractJsonObjectFromText(');
+
+assertIncludes('extensions/completion/role-runner.ts', 'export async function analyzeContextProposalWithAgent(');
+assertIncludes('extensions/completion/role-runner.ts', 'class StartupAnalystOverlay extends Container');
+assertIncludes('extensions/completion/role-runner.ts', 'async function runContextProposalAnalystSubprocess(');
+
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'export function buildSystemReminder(');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'export function buildResumeCapsule(');
+
+assertIncludes('extensions/completion/index.ts', 'scaffoldCompletionFiles as scaffoldCompletionFilesOnDisk');
+assertIncludes('extensions/completion/index.ts', 'return await scaffoldCompletionFilesOnDisk(root, missionAnchor, {');
+assertIncludes('extensions/completion/index.ts', 'applyLiveRoleEvent,');
+assertIncludes('extensions/completion/index.ts', 'cloneLiveRoleActivity,');
+assertIncludes('extensions/completion/index.ts', 'createLiveRoleActivity,');
+assertIncludes('extensions/completion/index.ts', 'formatElapsed,');
+assertIncludes('extensions/completion/index.ts', 'nowMs,');
+
+assertNotIncludes('extensions/completion/index.ts', 'async function detectVerifierCommand(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildAgentReadme(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildMission(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildVerifyStopScript(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildVerifyControlPlaneScript(');
+assertNotIncludes('extensions/completion/index.ts', 'async function ensureGitignore(');
+assertNotIncludes('extensions/completion/index.ts', 'function currentTaskType(');
+assertNotIncludes('extensions/completion/index.ts', 'function currentEvaluationProfile(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatCount(');
+assertNotIncludes('extensions/completion/index.ts', 'function completionRemainingSummary(');
+assertNotIncludes('extensions/completion/index.ts', 'function envNumber(');
+assertNotIncludes('extensions/completion/index.ts', 'function nowMs(');
+assertNotIncludes('extensions/completion/index.ts', 'type LiveActivitySignal = {');
+assertNotIncludes('extensions/completion/index.ts', 'function cloneLiveRoleActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function createLiveRoleActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'type RoleMessage = {');
+assertNotIncludes('extensions/completion/index.ts', 'function applyLiveRoleEvent(');
+assertNotIncludes('extensions/completion/index.ts', 'function maybeInjectTestLiveRoleActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function maybeReplayTestLiveRoleEvents(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatElapsed(');
+assertNotIncludes('extensions/completion/index.ts', 'function truncateInline(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatToolActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function pushRecentActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function parseStructuredProgress(');
+assertNotIncludes('extensions/completion/index.ts', 'function lastAssistantText(');
+assertNotIncludes('extensions/completion/index.ts', 'function normalizeMissionAnchorText(');
+assertNotIncludes('extensions/completion/index.ts', 'function isWeakMissionAnchor(');
+assertNotIncludes('extensions/completion/index.ts', 'function assessMissionAnchor(');
+assertNotIncludes('extensions/completion/index.ts', 'function stripCodeBlocks(');
+assertNotIncludes('extensions/completion/index.ts', 'function missionAnchorsStrictlyEquivalent(');
+assertNotIncludes('extensions/completion/index.ts', 'function missionAnchorsLikelyEquivalent(');
+assertNotIncludes('extensions/completion/index.ts', 'function collectRecentDiscussionEntries(');
+assertNotIncludes('extensions/completion/index.ts', 'function serializeRecentDiscussionEntries(');
+assertNotIncludes('extensions/completion/index.ts', 'function extractJsonObjectFromText(');
+assertNotIncludes('extensions/completion/index.ts', 'function contextProposalAnalystModelArg(');
+assertNotIncludes('extensions/completion/index.ts', 'async function runContextProposalAnalystSubprocess(');
+assertNotIncludes('extensions/completion/index.ts', 'async function analyzeContextProposalWithAgent(');
+assertNotIncludes('extensions/completion/index.ts', 'function deriveMissionAnchor(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildSystemReminder(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildResumeCapsule(');
+NODE
+
+echo "legacy cleanup test passed: $ROOT"

package/scripts/observability-status-test.sh

@@ -237,4 +237,43 @@ PI_COMPLETION_TEST_ROLE_EVENT_STREAM_JSON="$LIVE_ROLE_EVENT_STREAM_JSON" \
 pi -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-status-stalled.out" 2>"$TMPDIR/pi-completion-status-stalled.err"
 assert_status_json "$STALLED_JSON" stalled
 
+cd "$PKG_ROOT"
+
+node <<'NODE'
+const fs = require('node:fs');
+
+const read = (file) => fs.readFileSync(file, 'utf8');
+const assertIncludes = (file, snippet) => {
+  const text = read(file);
+  if (!text.includes(snippet)) {
+    throw new Error(`${file} is missing required status/policy extraction text: ${snippet}`);
+  }
+};
+const assertNotIncludes = (file, snippet) => {
+  const text = read(file);
+  if (text.includes(snippet)) {
+    throw new Error(`${file} still contains stale inline status/policy text: ${snippet}`);
+  }
+};
+
+assertIncludes('extensions/completion/status-surface.ts', 'export async function refreshCompletionStatus(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function buildCompletionStatusSurface(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function buildInlineRunningLines(');
+assertIncludes('extensions/completion/policy-guards.ts', 'export function toolCallBlockReason(');
+assertIncludes('extensions/completion/state-store.ts', 'export function completionRootKey(');
+assertIncludes('extensions/completion/index.ts', 'import { toolCallBlockReason } from "./policy-guards";');
+assertIncludes('extensions/completion/index.ts', 'buildInlineRunningLines');
+assertIncludes('extensions/completion/index.ts', 'formatInlineRunningText');
+assertIncludes('extensions/completion/index.ts', 'refreshCompletionStatus');
+assertIncludes('extensions/completion/index.ts', 'const reason = toolCallBlockReason({');
+assertIncludes('extensions/completion/index.ts', 'await refreshCompletionStatus({ ctx, ...statusSurfaceArgs });');
+assertNotIncludes('extensions/completion/index.ts', 'function buildCompletionStatusSurface(');
+assertNotIncludes('extensions/completion/index.ts', 'async function writeCompletionStatusProbe(');
+assertNotIncludes('extensions/completion/index.ts', 'function isAllowedControlPlanePath(');
+assertNotIncludes('extensions/completion/index.ts', 'function isMutatingBash(');
+assertNotIncludes('extensions/completion/index.ts', 'async function refreshStatus(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildInlineRunningLines(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatInlineRunningText(');
+NODE
+
 echo "observability status test passed: $TMPDIR"

package/scripts/refocus-test.sh

@@ -131,13 +131,13 @@ tracked = [
     Path('.agent/verification-evidence.json'),
 ]
 current_state = json.loads(before['state.json'])
-assert current_state['mission_anchor'] == initial_mission, 'active inline /cook args should start from the current mission anchor'
-assert 'Cancelled existing workflow confirmation.' in output, 'active inline /cook hint cancel should surface chooser cancellation'
-assert routing.exists(), 'active inline /cook hint should run active-workflow routing'
-assert not proposal.exists(), 'active inline /cook hint cancel at chooser should not open final proposal confirmation'
-assert chooser.exists(), 'active inline /cook hint should open the existing-workflow chooser'
+assert current_state['mission_anchor'] == initial_mission, 'active /cook <text> rejection should start from the current mission anchor'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'active /cook <text> rejection should explain the bare-only contract'
+assert not routing.exists(), 'active /cook <text> rejection should not run active-workflow routing'
+assert not proposal.exists(), 'active /cook <text> rejection should not open final proposal confirmation'
+assert not chooser.exists(), 'active /cook <text> rejection should not open the existing-workflow chooser'
 after = {path.name: path.read_text() for path in tracked}
-assert before == after, 'active inline /cook hint cancel should leave canonical files unchanged'
+assert before == after, 'active /cook <text> rejection should leave canonical files unchanged'
 PY
 
 SESSION_INITIAL_REFOCUS="$TMPDIR/session-initial-bare-refocus.jsonl"