@linimin/pi-letscook 0.1.45 → 0.1.47

package/scripts/release-check.sh

@@ -4,7 +4,7 @@ set -euo pipefail
 ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 cd "$ROOT"
 
-echo "[release-check] running control-plane validation, bare /cook parity, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, evaluator calibration, and rubric contract coverage"
+echo "[release-check] running control-plane validation, bare /cook parity, role-runner extraction, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, legacy cleanup, evaluator calibration, and rubric contract coverage"
 bash .agent/verify_completion_control_plane.sh
 
 echo "[release-check] verifying public /cook parity"
@@ -14,9 +14,9 @@ from pathlib import Path
 
 checks = {
     "README.md": [
-        "Bare `/cook` and `/cook <hint>` are the supported workflow entrypoints.",
-        "If the recent context is fuzzy, `/cook <hint>` can provide a short high-priority user hint for the proposal analyst",
-        "clarify the mission in the main chat before rerunning `/cook`",
+        "Bare `/cook` is the only supported workflow entrypoint.",
+        "`/cook <text>` is no longer supported; put mission text in the main chat, then rerun bare `/cook`.",
+        "clarify the mission in the main chat before rerunning bare `/cook`",
         "Matching or unclear discussion resumes from canonical `.agent/**` state.",
         "approval-only Start/Cancel gate",
         "Start new workflow from recent discussion",
@@ -24,27 +24,26 @@ checks = {
         "README/CHANGELOG updates still count as concrete repo changes",
         "assistant-produced summaries and plan/spec/design-doc/proposal-only artifacts do not",
         "Assistant/summary artifacts or plan/spec/design-doc/proposal-only context do not refocus the workflow.",
+        "`/cook <text>` is rejected without running proposal routing or rewriting workflow state.",
     ],
     "CHANGELOG.md": [
-        "bare `/cook` as the only supported workflow entrypoint",
-        "clarify the mission before rerunning bare `/cook`",
-        "packaged parity now fails closed on the bare-only contract",
-        "that old inline-argument path is no longer supported now that bare `/cook` is the only public entrypoint",
-        "README/CHANGELOG/docs-only deliverables as concrete repo-change missions",
-        "ignore assistant/branch/compaction summary artifacts for startup/refocus readiness",
-        "plan/spec/design-doc/proposal-only context without rewriting canonical state",
+        "removed inline `/cook <text>` argument support so bare `/cook` is now the only supported workflow entrypoint",
+        "packaged release parity fail closed when command arguments are passed instead of discussion driving proposal derivation",
+        "historically allowed `/cook <hint>` as an analyst-only high-priority prompt",
+        "that inline-argument path has since been removed so bare `/cook` is now the only supported entrypoint",
     ],
     "extensions/completion/index.ts": [
-        'description: "Discussion-driven /cook workflow: start, continue, refocus, or start the next round"',
-        "If an inline /cook hint is present, treat it as a high-priority user hint that may focus the mission, but do not ignore conflicting discussion or skip missing details.",
-        "/cook failed closed because recent discussion and any optional inline /cook hint did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun /cook.",
+        'description: "Bare /cook workflow: start, continue, refocus, or start the next round"',
+        'const COOK_BARE_ONLY_GUIDANCE =',
+        '"/cook only supports the bare /cook entrypoint. Move mission text into the main chat, then rerun /cook."',
+        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun /cook."',
     ],
 }
 
 forbidden = {
-    "README.md": ["compatibility" + " shim"],
+    "README.md": ["compatibility" + " shim", "/cook <hint>", "optional inline /cook hint"],
     "CHANGELOG.md": ["compatibility" + " shim"],
-    "extensions/completion/index.ts": ["temporary" + " compatibility" + " shim, pass /cook"],
+    "extensions/completion/index.ts": ["temporary" + " compatibility" + " shim, pass /cook", "inline /cook hint", "optional inline /cook hint"],
 }
 
 for path, needles in checks.items():
@@ -63,9 +62,11 @@ PY
 npm run smoke-test
 npm run refocus-test
 npm run context-proposal-test
+bash ./scripts/role-runner-contract-test.sh
 bash ./scripts/canonical-evidence-artifact-test.sh
 bash ./scripts/active-slice-contract-test.sh
 npm run observability-status-test
+bash ./scripts/legacy-cleanup-test.sh
 npm run evaluator-calibration-test
 npm run rubric-contract-test
 npm pack --dry-run >/dev/null

package/scripts/role-runner-contract-test.sh

@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$ROOT"
+
+node <<'NODE'
+const fs = require('node:fs');
+
+const read = (file) => fs.readFileSync(file, 'utf8');
+const assertIncludes = (file, snippet) => {
+  const text = read(file);
+  if (!text.includes(snippet)) {
+    throw new Error(`${file} is missing required role-runner extraction text: ${snippet}`);
+  }
+};
+const assertNotIncludes = (file, snippet) => {
+  const text = read(file);
+  if (text.includes(snippet)) {
+    throw new Error(`${file} still contains stale inline role-runner text: ${snippet}`);
+  }
+};
+
+assertIncludes('extensions/completion/role-runner.ts', 'import { completionRootKey, findCompletionRoot, findRepoRoot, loadCompletionDataForReminder } from "./state-store";');
+assertIncludes('extensions/completion/role-runner.ts', 'import { parseReportFields, transcribeRoleOutput, type TranscriptionResult } from "./transcription";');
+assertIncludes('extensions/completion/role-runner.ts', 'const agent = await loadAgentDefinition(params.root, params.role);');
+assertIncludes('extensions/completion/role-runner.ts', 'await loadCompletionDataForReminder(params.root);');
+assertIncludes('extensions/completion/role-runner.ts', 'const systemPromptTemp = await writeTempFile(params.root, "pi-completion-role-", agent.systemPrompt);');
+assertIncludes('extensions/completion/role-runner.ts', 'const reportFields = parseReportFields(output);');
+assertIncludes('extensions/completion/role-runner.ts', 'const transcription = exitCode === 0 ? await transcribeRoleOutput(params.role, params.root, output, reportFields) : undefined;');
+assertIncludes('extensions/completion/role-runner.ts', 'env: { ...process.env, PI_COMPLETION_ROLE: params.role },');
+assertIncludes('extensions/completion/role-runner.ts', 'async function runContextProposalAnalystSubprocess(');
+assertIncludes('extensions/completion/role-runner.ts', 'export async function analyzeContextProposalWithAgent(');
+assertIncludes('extensions/completion/index.ts', 'import { analyzeContextProposalWithAgent, runCompletionRole } from "./role-runner";');
+assertIncludes('extensions/completion/index.ts', 'const result = await runCompletionRole({');
+assertIncludes('extensions/completion/index.ts', 'await analyzeContextProposalWithAgent({');
+assertNotIncludes('extensions/completion/index.ts', 'const systemPromptTemp = await writeTempFile(runCwd, "pi-cook-proposal-analyst-", CONTEXT_PROPOSAL_ANALYST_SYSTEM_PROMPT);');
+assertNotIncludes('extensions/completion/index.ts', 'const invocation = getPiInvocation(args);');
+assertNotIncludes('extensions/completion/index.ts', 'async function loadAgentDefinition(');
+assertNotIncludes('extensions/completion/index.ts', 'async function writeTempFile(');
+assertNotIncludes('extensions/completion/index.ts', 'function getPiInvocation(');
+NODE
+
+echo "role-runner contract test passed"

package/scripts/rubric-contract-test.sh

@@ -77,13 +77,15 @@ assertIncludes('CHANGELOG.md', 'added canonical `task_type: completion-workflow`
 assertIncludes('CHANGELOG.md', 'threaded canonical `evaluation_profile` plus the active-slice implementation contract into reviewer/auditor/stop-judge reminder and dispatch surfaces');
 assertIncludes('CHANGELOG.md', 'made reviewer/auditor/stop-judge transcription fail closed on malformed rubric-bearing outputs while still accepting valid reports');
 assertIncludes('extensions/completion/index.ts', 'Canonical routing profile:\\n- task_type: ${taskType}\\n- evaluation_profile: ${evaluationProfile}');
-assertIncludes('extensions/completion/index.ts', '`Task type: ${currentTaskType(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', '`Evaluation profile: ${currentEvaluationProfile(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', '`task_type: ${currentTaskType(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', '`evaluation_profile: ${currentEvaluationProfile(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', 'Canonical evaluation handoff for ${role}:');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`Task type: ${args.taskType ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`Evaluation profile: ${args.evaluationProfile ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- task_type: ${deps.currentTaskType(snapshot) ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- evaluation_profile: ${deps.currentEvaluationProfile(snapshot) ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Canonical evaluation handoff for ${role}:');
 assertIncludes('extensions/completion/index.ts', 'buildEvaluationRoleReminderText(snapshot, nextRole)');
-assertIncludes('extensions/completion/index.ts', 'roleReporting.transcribeCanonicalRoleReport');
+assertIncludes('extensions/completion/index.ts', 'import { parseFirstNumber, parseYesNo } from "./transcription";');
+assertIncludes('extensions/completion/role-runner.ts', 'import { parseReportFields, transcribeRoleOutput, type TranscriptionResult } from "./transcription";');
+assertIncludes('extensions/completion/transcription.ts', 'roleReporting.transcribeCanonicalRoleReport');
 assertIncludes('extensions/completion/role-reporting.js', 'Missing Rubric heading for ${role}.');
 assertIncludes('extensions/completion/role-reporting.js', 'Reviewer output cannot mark \'Acceptable as-is: yes\' when any rubric line is fail.');
 assertIncludes('extensions/completion/role-reporting.js', 'Auditor output must answer \'Tracked and unignored worktree is clean\' with yes or no.');

package/scripts/smoke-test.sh

@@ -84,11 +84,11 @@ routing = Path(sys.argv[3])
 proposal = Path(sys.argv[4])
 chooser = Path(sys.argv[5])
 
-assert not Path('.agent').exists(), 'startup inline /cook hint cancel should leave canonical state untouched'
-assert not routing.exists(), 'startup inline /cook hint should not open active-workflow routing'
-assert proposal.exists(), 'startup inline /cook hint should still prepare a proposal for confirmation'
-assert not chooser.exists(), 'startup inline /cook hint should not open the chooser flow during startup'
-assert 'Cancelled recent-discussion workflow proposal.' in output, 'startup inline /cook hint cancel should surface the proposal cancellation message'
+assert not Path('.agent').exists(), 'startup /cook <text> rejection should leave canonical state untouched'
+assert not routing.exists(), 'startup /cook <text> rejection should not open active-workflow routing'
+assert not proposal.exists(), 'startup /cook <text> rejection should not prepare a proposal snapshot'
+assert not chooser.exists(), 'startup /cook <text> rejection should not open the chooser flow'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'startup /cook <text> rejection should explain the bare-only contract'
 PY
 
 write_session "$BOOTSTRAP_SESSION" "$ROOT" "$BOOTSTRAP_DISCUSSION"