@lenylvt/pi-coding-agent 0.64.0

package/src/core/tools/edit.ts

@@ -0,0 +1,307 @@
+import type { AgentTool } from "@lenylvt/pi-agent-core";
+import { Container, Text } from "@lenylvt/pi-tui";
+import { type Static, Type } from "@sinclair/typebox";
+import { constants } from "fs";
+import { access as fsAccess, readFile as fsReadFile, writeFile as fsWriteFile } from "fs/promises";
+import { renderDiff } from "../../modes/interactive/components/diff.js";
+import type { ToolDefinition } from "../extensions/types.js";
+import {
+	applyEditsToNormalizedContent,
+	detectLineEnding,
+	type Edit,
+	generateDiffString,
+	normalizeToLF,
+	restoreLineEndings,
+	stripBom,
+} from "./edit-diff.js";
+import { withFileMutationQueue } from "./file-mutation-queue.js";
+import { resolveToCwd } from "./path-utils.js";
+import { invalidArgText, shortenPath, str } from "./render-utils.js";
+import { wrapToolDefinition } from "./tool-definition-wrapper.js";
+
+type EditRenderState = Record<string, never>;
+
+const replaceEditSchema = Type.Object(
+	{
+		oldText: Type.String({
+			description:
+				"Exact text for one targeted replacement. It must be unique in the original file and must not overlap with any other edits[].oldText in the same call.",
+		}),
+		newText: Type.String({ description: "Replacement text for this targeted edit." }),
+	},
+	{ additionalProperties: false },
+);
+
+const editSchema = Type.Object(
+	{
+		path: Type.String({ description: "Path to the file to edit (relative or absolute)" }),
+		edits: Type.Array(replaceEditSchema, {
+			description:
+				"One or more targeted replacements. Each edit is matched against the original file, not incrementally. Do not include overlapping or nested edits. If two changes touch the same block or nearby lines, merge them into one edit instead.",
+		}),
+	},
+	{ additionalProperties: false },
+);
+
+export type EditToolInput = Static<typeof editSchema>;
+type LegacyEditToolInput = EditToolInput & {
+	oldText?: unknown;
+	newText?: unknown;
+};
+
+export interface EditToolDetails {
+	/** Unified diff of the changes made */
+	diff: string;
+	/** Line number of the first change in the new file (for editor navigation) */
+	firstChangedLine?: number;
+}
+
+/**
+ * Pluggable operations for the edit tool.
+ * Override these to delegate file editing to remote systems (for example SSH).
+ */
+export interface EditOperations {
+	/** Read file contents as a Buffer */
+	readFile: (absolutePath: string) => Promise<Buffer>;
+	/** Write content to a file */
+	writeFile: (absolutePath: string, content: string) => Promise<void>;
+	/** Check if file is readable and writable (throw if not) */
+	access: (absolutePath: string) => Promise<void>;
+}
+
+const defaultEditOperations: EditOperations = {
+	readFile: (path) => fsReadFile(path),
+	writeFile: (path, content) => fsWriteFile(path, content, "utf-8"),
+	access: (path) => fsAccess(path, constants.R_OK | constants.W_OK),
+};
+
+export interface EditToolOptions {
+	/** Custom operations for file editing. Default: local filesystem */
+	operations?: EditOperations;
+}
+
+function prepareEditArguments(input: unknown): EditToolInput {
+	if (!input || typeof input !== "object") {
+		return input as EditToolInput;
+	}
+
+	const args = input as LegacyEditToolInput;
+	if (typeof args.oldText !== "string" || typeof args.newText !== "string") {
+		return input as EditToolInput;
+	}
+
+	const edits = Array.isArray(args.edits) ? [...args.edits] : [];
+	edits.push({ oldText: args.oldText, newText: args.newText });
+	const { oldText: _oldText, newText: _newText, ...rest } = args;
+	return { ...rest, edits } as EditToolInput;
+}
+
+function validateEditInput(input: EditToolInput): { path: string; edits: Edit[] } {
+	if (!Array.isArray(input.edits) || input.edits.length === 0) {
+		throw new Error("Edit tool input is invalid. edits must contain at least one replacement.");
+	}
+	return { path: input.path, edits: input.edits };
+}
+
+type RenderableEditArgs = {
+	path?: string;
+	file_path?: string;
+	edits?: Edit[];
+	oldText?: string;
+	newText?: string;
+};
+
+function formatEditCall(
+	args: RenderableEditArgs | undefined,
+	theme: typeof import("../../modes/interactive/theme/theme.js").theme,
+): string {
+	const invalidArg = invalidArgText(theme);
+	const rawPath = str(args?.file_path ?? args?.path);
+	const path = rawPath !== null ? shortenPath(rawPath) : null;
+	const pathDisplay = path === null ? invalidArg : path ? theme.fg("accent", path) : theme.fg("toolOutput", "...");
+	return `${theme.fg("toolTitle", theme.bold("edit"))} ${pathDisplay}`;
+}
+
+function formatEditResult(
+	args: RenderableEditArgs | undefined,
+	result: {
+		content: Array<{ type: string; text?: string; data?: string; mimeType?: string }>;
+		details?: EditToolDetails;
+	},
+	theme: typeof import("../../modes/interactive/theme/theme.js").theme,
+	isError: boolean,
+): string | undefined {
+	const rawPath = str(args?.file_path ?? args?.path);
+	if (isError) {
+		const errorText = result.content
+			.filter((c) => c.type === "text")
+			.map((c) => c.text || "")
+			.join("\n");
+		if (!errorText) {
+			return undefined;
+		}
+		return `\n${theme.fg("error", errorText)}`;
+	}
+
+	const resultDiff = result.details?.diff;
+	if (!resultDiff) {
+		return undefined;
+	}
+	return `\n${renderDiff(resultDiff, { filePath: rawPath ?? undefined })}`;
+}
+
+export function createEditToolDefinition(
+	cwd: string,
+	options?: EditToolOptions,
+): ToolDefinition<typeof editSchema, EditToolDetails | undefined, EditRenderState> {
+	const ops = options?.operations ?? defaultEditOperations;
+	return {
+		name: "edit",
+		label: "edit",
+		description:
+			"Edit a single file using exact text replacement. Every edits[].oldText must match a unique, non-overlapping region of the original file. If two changes affect the same block or nearby lines, merge them into one edit instead of emitting overlapping edits. Do not include large unchanged regions just to connect distant changes.",
+		promptSnippet:
+			"Make precise file edits with exact text replacement, including multiple disjoint edits in one call",
+		promptGuidelines: [
+			"Use edit for precise changes (edits[].oldText must match exactly)",
+			"When changing multiple separate locations in one file, use one edit call with multiple entries in edits[] instead of multiple edit calls",
+			"Each edits[].oldText is matched against the original file, not after earlier edits are applied. Do not emit overlapping or nested edits. Merge nearby changes into one edit.",
+			"Keep edits[].oldText as small as possible while still being unique in the file. Do not pad with large unchanged regions.",
+		],
+		parameters: editSchema,
+		prepareArguments: prepareEditArguments,
+		async execute(_toolCallId, input: EditToolInput, signal?: AbortSignal, _onUpdate?, _ctx?) {
+			const { path, edits } = validateEditInput(input);
+			const absolutePath = resolveToCwd(path, cwd);
+
+			return withFileMutationQueue(
+				absolutePath,
+				() =>
+					new Promise<{
+						content: Array<{ type: "text"; text: string }>;
+						details: EditToolDetails | undefined;
+					}>((resolve, reject) => {
+						// Check if already aborted.
+						if (signal?.aborted) {
+							reject(new Error("Operation aborted"));
+							return;
+						}
+
+						let aborted = false;
+
+						// Set up abort handler.
+						const onAbort = () => {
+							aborted = true;
+							reject(new Error("Operation aborted"));
+						};
+
+						if (signal) {
+							signal.addEventListener("abort", onAbort, { once: true });
+						}
+
+						// Perform the edit operation.
+						void (async () => {
+							try {
+								// Check if file exists.
+								try {
+									await ops.access(absolutePath);
+								} catch {
+									if (signal) {
+										signal.removeEventListener("abort", onAbort);
+									}
+									reject(new Error(`File not found: ${path}`));
+									return;
+								}
+
+								// Check if aborted before reading.
+								if (aborted) {
+									return;
+								}
+
+								// Read the file.
+								const buffer = await ops.readFile(absolutePath);
+								const rawContent = buffer.toString("utf-8");
+
+								// Check if aborted after reading.
+								if (aborted) {
+									return;
+								}
+
+								// Strip BOM before matching. The model will not include an invisible BOM in oldText.
+								const { bom, text: content } = stripBom(rawContent);
+								const originalEnding = detectLineEnding(content);
+								const normalizedContent = normalizeToLF(content);
+								const { baseContent, newContent } = applyEditsToNormalizedContent(
+									normalizedContent,
+									edits,
+									path,
+								);
+
+								// Check if aborted before writing.
+								if (aborted) {
+									return;
+								}
+
+								const finalContent = bom + restoreLineEndings(newContent, originalEnding);
+								await ops.writeFile(absolutePath, finalContent);
+
+								// Check if aborted after writing.
+								if (aborted) {
+									return;
+								}
+
+								// Clean up abort handler.
+								if (signal) {
+									signal.removeEventListener("abort", onAbort);
+								}
+
+								const diffResult = generateDiffString(baseContent, newContent);
+								resolve({
+									content: [
+										{
+											type: "text",
+											text: `Successfully replaced ${edits.length} block(s) in ${path}.`,
+										},
+									],
+									details: { diff: diffResult.diff, firstChangedLine: diffResult.firstChangedLine },
+								});
+							} catch (error: unknown) {
+								// Clean up abort handler.
+								if (signal) {
+									signal.removeEventListener("abort", onAbort);
+								}
+
+								if (!aborted) {
+									reject(error instanceof Error ? error : new Error(String(error)));
+								}
+							}
+						})();
+					}),
+			);
+		},
+		renderCall(args, theme, context) {
+			const text = (context.lastComponent as Text | undefined) ?? new Text("", 0, 0);
+			text.setText(formatEditCall(args, theme));
+			return text;
+		},
+		renderResult(result, _options, theme, context) {
+			const output = formatEditResult(context.args, result as any, theme, context.isError);
+			if (!output) {
+				const component = (context.lastComponent as Container | undefined) ?? new Container();
+				component.clear();
+				return component;
+			}
+			const text = (context.lastComponent as Text | undefined) ?? new Text("", 0, 0);
+			text.setText(output);
+			return text;
+		},
+	};
+}
+
+export function createEditTool(cwd: string, options?: EditToolOptions): AgentTool<typeof editSchema> {
+	return wrapToolDefinition(createEditToolDefinition(cwd, options));
+}
+
+/** Default edit tool using process.cwd() for backwards compatibility. */
+export const editToolDefinition = createEditToolDefinition(process.cwd());
+export const editTool = createEditTool(process.cwd());

package/src/core/tools/file-mutation-queue.ts

@@ -0,0 +1,39 @@
+import { realpathSync } from "node:fs";
+import { resolve } from "node:path";
+
+const fileMutationQueues = new Map<string, Promise<void>>();
+
+function getMutationQueueKey(filePath: string): string {
+	const resolvedPath = resolve(filePath);
+	try {
+		return realpathSync.native(resolvedPath);
+	} catch {
+		return resolvedPath;
+	}
+}
+
+/**
+ * Serialize file mutation operations targeting the same file.
+ * Operations for different files still run in parallel.
+ */
+export async function withFileMutationQueue<T>(filePath: string, fn: () => Promise<T>): Promise<T> {
+	const key = getMutationQueueKey(filePath);
+	const currentQueue = fileMutationQueues.get(key) ?? Promise.resolve();
+
+	let releaseNext!: () => void;
+	const nextQueue = new Promise<void>((resolveQueue) => {
+		releaseNext = resolveQueue;
+	});
+	const chainedQueue = currentQueue.then(() => nextQueue);
+	fileMutationQueues.set(key, chainedQueue);
+
+	await currentQueue;
+	try {
+		return await fn();
+	} finally {
+		releaseNext();
+		if (fileMutationQueues.get(key) === chainedQueue) {
+			fileMutationQueues.delete(key);
+		}
+	}
+}

package/src/core/tools/find.ts

@@ -0,0 +1,314 @@
+import type { AgentTool } from "@lenylvt/pi-agent-core";
+import { Text } from "@lenylvt/pi-tui";
+import { type Static, Type } from "@sinclair/typebox";
+import { spawnSync } from "child_process";
+import { existsSync } from "fs";
+import { globSync } from "glob";
+import path from "path";
+import { keyHint } from "../../modes/interactive/components/keybinding-hints.js";
+import { ensureTool } from "../../utils/tools-manager.js";
+import type { ToolDefinition, ToolRenderResultOptions } from "../extensions/types.js";
+import { resolveToCwd } from "./path-utils.js";
+import { getTextOutput, invalidArgText, shortenPath, str } from "./render-utils.js";
+import { wrapToolDefinition } from "./tool-definition-wrapper.js";
+import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateHead } from "./truncate.js";
+
+function toPosixPath(value: string): string {
+	return value.split(path.sep).join("/");
+}
+
+const findSchema = Type.Object({
+	pattern: Type.String({
+		description: "Glob pattern to match files, e.g. '*.ts', '**/*.json', or 'src/**/*.spec.ts'",
+	}),
+	path: Type.Optional(Type.String({ description: "Directory to search in (default: current directory)" })),
+	limit: Type.Optional(Type.Number({ description: "Maximum number of results (default: 1000)" })),
+});
+
+export type FindToolInput = Static<typeof findSchema>;
+
+const DEFAULT_LIMIT = 1000;
+
+export interface FindToolDetails {
+	truncation?: TruncationResult;
+	resultLimitReached?: number;
+}
+
+/**
+ * Pluggable operations for the find tool.
+ * Override these to delegate file search to remote systems (for example SSH).
+ */
+export interface FindOperations {
+	/** Check if path exists */
+	exists: (absolutePath: string) => Promise<boolean> | boolean;
+	/** Find files matching glob pattern. Returns relative or absolute paths. */
+	glob: (pattern: string, cwd: string, options: { ignore: string[]; limit: number }) => Promise<string[]> | string[];
+}
+
+const defaultFindOperations: FindOperations = {
+	exists: existsSync,
+	// This is a placeholder. Actual fd execution happens in execute() when no custom glob is provided.
+	glob: () => [],
+};
+
+export interface FindToolOptions {
+	/** Custom operations for find. Default: local filesystem plus fd */
+	operations?: FindOperations;
+}
+
+function formatFindCall(
+	args: { pattern: string; path?: string; limit?: number } | undefined,
+	theme: typeof import("../../modes/interactive/theme/theme.js").theme,
+): string {
+	const pattern = str(args?.pattern);
+	const rawPath = str(args?.path);
+	const path = rawPath !== null ? shortenPath(rawPath || ".") : null;
+	const limit = args?.limit;
+	const invalidArg = invalidArgText(theme);
+	let text =
+		theme.fg("toolTitle", theme.bold("find")) +
+		" " +
+		(pattern === null ? invalidArg : theme.fg("accent", pattern || "")) +
+		theme.fg("toolOutput", ` in ${path === null ? invalidArg : path}`);
+	if (limit !== undefined) {
+		text += theme.fg("toolOutput", ` (limit ${limit})`);
+	}
+	return text;
+}
+
+function formatFindResult(
+	result: {
+		content: Array<{ type: string; text?: string; data?: string; mimeType?: string }>;
+		details?: FindToolDetails;
+	},
+	options: ToolRenderResultOptions,
+	theme: typeof import("../../modes/interactive/theme/theme.js").theme,
+	showImages: boolean,
+): string {
+	const output = getTextOutput(result, showImages).trim();
+	let text = "";
+	if (output) {
+		const lines = output.split("\n");
+		const maxLines = options.expanded ? lines.length : 20;
+		const displayLines = lines.slice(0, maxLines);
+		const remaining = lines.length - maxLines;
+		text += `\n${displayLines.map((line) => theme.fg("toolOutput", line)).join("\n")}`;
+		if (remaining > 0) {
+			text += `${theme.fg("muted", `\n... (${remaining} more lines,`)} ${keyHint("app.tools.expand", "to expand")})`;
+		}
+	}
+
+	const resultLimit = result.details?.resultLimitReached;
+	const truncation = result.details?.truncation;
+	if (resultLimit || truncation?.truncated) {
+		const warnings: string[] = [];
+		if (resultLimit) warnings.push(`${resultLimit} results limit`);
+		if (truncation?.truncated) warnings.push(`${formatSize(truncation.maxBytes ?? DEFAULT_MAX_BYTES)} limit`);
+		text += `\n${theme.fg("warning", `[Truncated: ${warnings.join(", ")}]`)}`;
+	}
+	return text;
+}
+
+export function createFindToolDefinition(
+	cwd: string,
+	options?: FindToolOptions,
+): ToolDefinition<typeof findSchema, FindToolDetails | undefined> {
+	const customOps = options?.operations;
+	return {
+		name: "find",
+		label: "find",
+		description: `Search for files by glob pattern. Returns matching file paths relative to the search directory. Respects .gitignore. Output is truncated to ${DEFAULT_LIMIT} results or ${DEFAULT_MAX_BYTES / 1024}KB (whichever is hit first).`,
+		promptSnippet: "Find files by glob pattern (respects .gitignore)",
+		parameters: findSchema,
+		async execute(
+			_toolCallId,
+			{ pattern, path: searchDir, limit }: { pattern: string; path?: string; limit?: number },
+			signal?: AbortSignal,
+			_onUpdate?,
+			_ctx?,
+		) {
+			return new Promise((resolve, reject) => {
+				if (signal?.aborted) {
+					reject(new Error("Operation aborted"));
+					return;
+				}
+
+				const onAbort = () => reject(new Error("Operation aborted"));
+				signal?.addEventListener("abort", onAbort, { once: true });
+
+				(async () => {
+					try {
+						const searchPath = resolveToCwd(searchDir || ".", cwd);
+						const effectiveLimit = limit ?? DEFAULT_LIMIT;
+						const ops = customOps ?? defaultFindOperations;
+
+						// If custom operations provide glob(), use that instead of fd.
+						if (customOps?.glob) {
+							if (!(await ops.exists(searchPath))) {
+								reject(new Error(`Path not found: ${searchPath}`));
+								return;
+							}
+							const results = await ops.glob(pattern, searchPath, {
+								ignore: ["**/node_modules/**", "**/.git/**"],
+								limit: effectiveLimit,
+							});
+							signal?.removeEventListener("abort", onAbort);
+							if (results.length === 0) {
+								resolve({
+									content: [{ type: "text", text: "No files found matching pattern" }],
+									details: undefined,
+								});
+								return;
+							}
+
+							// Relativize paths against the search root for stable output.
+							const relativized = results.map((p) => {
+								if (p.startsWith(searchPath)) return toPosixPath(p.slice(searchPath.length + 1));
+								return toPosixPath(path.relative(searchPath, p));
+							});
+							const resultLimitReached = relativized.length >= effectiveLimit;
+							const rawOutput = relativized.join("\n");
+							const truncation = truncateHead(rawOutput, { maxLines: Number.MAX_SAFE_INTEGER });
+							let resultOutput = truncation.content;
+							const details: FindToolDetails = {};
+							const notices: string[] = [];
+							if (resultLimitReached) {
+								notices.push(`${effectiveLimit} results limit reached`);
+								details.resultLimitReached = effectiveLimit;
+							}
+							if (truncation.truncated) {
+								notices.push(`${formatSize(DEFAULT_MAX_BYTES)} limit reached`);
+								details.truncation = truncation;
+							}
+							if (notices.length > 0) {
+								resultOutput += `\n\n[${notices.join(". ")}]`;
+							}
+							resolve({
+								content: [{ type: "text", text: resultOutput }],
+								details: Object.keys(details).length > 0 ? details : undefined,
+							});
+							return;
+						}
+
+						// Default implementation uses fd.
+						const fdPath = await ensureTool("fd", true);
+						if (!fdPath) {
+							reject(new Error("fd is not available and could not be downloaded"));
+							return;
+						}
+
+						// Build fd arguments.
+						const args: string[] = [
+							"--glob",
+							"--color=never",
+							"--hidden",
+							"--max-results",
+							String(effectiveLimit),
+						];
+						// Include .gitignore files from the search tree.
+						const gitignoreFiles = new Set<string>();
+						const rootGitignore = path.join(searchPath, ".gitignore");
+						if (existsSync(rootGitignore)) gitignoreFiles.add(rootGitignore);
+						try {
+							const nestedGitignores = globSync("**/.gitignore", {
+								cwd: searchPath,
+								dot: true,
+								absolute: true,
+								ignore: ["**/node_modules/**", "**/.git/**"],
+							});
+							for (const file of nestedGitignores) gitignoreFiles.add(file);
+						} catch {
+							// ignore
+						}
+						for (const gitignorePath of gitignoreFiles) args.push("--ignore-file", gitignorePath);
+						args.push(pattern, searchPath);
+
+						const result = spawnSync(fdPath, args, { encoding: "utf-8", maxBuffer: 10 * 1024 * 1024 });
+						signal?.removeEventListener("abort", onAbort);
+						if (result.error) {
+							reject(new Error(`Failed to run fd: ${result.error.message}`));
+							return;
+						}
+
+						const output = result.stdout?.trim() || "";
+						if (result.status !== 0) {
+							const errorMsg = result.stderr?.trim() || `fd exited with code ${result.status}`;
+							if (!output) {
+								reject(new Error(errorMsg));
+								return;
+							}
+						}
+						if (!output) {
+							resolve({
+								content: [{ type: "text", text: "No files found matching pattern" }],
+								details: undefined,
+							});
+							return;
+						}
+
+						const lines = output.split("\n");
+						const relativized: string[] = [];
+						for (const rawLine of lines) {
+							const line = rawLine.replace(/\r$/, "").trim();
+							if (!line) continue;
+							const hadTrailingSlash = line.endsWith("/") || line.endsWith("\\");
+							let relativePath = line;
+							if (line.startsWith(searchPath)) {
+								relativePath = line.slice(searchPath.length + 1);
+							} else {
+								relativePath = path.relative(searchPath, line);
+							}
+							if (hadTrailingSlash && !relativePath.endsWith("/")) relativePath += "/";
+							relativized.push(toPosixPath(relativePath));
+						}
+
+						const resultLimitReached = relativized.length >= effectiveLimit;
+						const rawOutput = relativized.join("\n");
+						const truncation = truncateHead(rawOutput, { maxLines: Number.MAX_SAFE_INTEGER });
+						let resultOutput = truncation.content;
+						const details: FindToolDetails = {};
+						const notices: string[] = [];
+						if (resultLimitReached) {
+							notices.push(
+								`${effectiveLimit} results limit reached. Use limit=${effectiveLimit * 2} for more, or refine pattern`,
+							);
+							details.resultLimitReached = effectiveLimit;
+						}
+						if (truncation.truncated) {
+							notices.push(`${formatSize(DEFAULT_MAX_BYTES)} limit reached`);
+							details.truncation = truncation;
+						}
+						if (notices.length > 0) {
+							resultOutput += `\n\n[${notices.join(". ")}]`;
+						}
+						resolve({
+							content: [{ type: "text", text: resultOutput }],
+							details: Object.keys(details).length > 0 ? details : undefined,
+						});
+					} catch (e: any) {
+						signal?.removeEventListener("abort", onAbort);
+						reject(e);
+					}
+				})();
+			});
+		},
+		renderCall(args, theme, context) {
+			const text = (context.lastComponent as Text | undefined) ?? new Text("", 0, 0);
+			text.setText(formatFindCall(args, theme));
+			return text;
+		},
+		renderResult(result, options, theme, context) {
+			const text = (context.lastComponent as Text | undefined) ?? new Text("", 0, 0);
+			text.setText(formatFindResult(result as any, options, theme, context.showImages));
+			return text;
+		},
+	};
+}
+
+export function createFindTool(cwd: string, options?: FindToolOptions): AgentTool<typeof findSchema> {
+	return wrapToolDefinition(createFindToolDefinition(cwd, options));
+}
+
+/** Default find tool using process.cwd() for backwards compatibility. */
+export const findToolDefinition = createFindToolDefinition(process.cwd());
+export const findTool = createFindTool(process.cwd());