@ledgerhq/live-common 23.1.0 → 24.0.0-next.2

package/src/families/ethereum/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,6 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+
 import invariant from "invariant";
 import { BigNumber } from "bignumber.js";
 import type { AccountRaw, DatasetTest } from "../../types";
@@ -11,24 +14,7 @@ import type { Transaction } from "./types";
 import ethereumScanAccounts1 from "./datasets/ethereum.scanAccounts.1";
 import ethereum_classic from "./datasets/ethereum_classic";
 import { syncAccount } from "../../__tests__/test-helpers/bridge";
-export const ethereum1: AccountRaw = {
-  id: "js:1:ethereum:0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5:",
-  seedIdentifier: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
-  name: "Ethereum legacy xpub6Bem...JyAdpYZy",
-  derivationMode: "",
-  index: 0,
-  freshAddress: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
-  freshAddressPath: "44'/60'/0'/0/0",
-  freshAddresses: [],
-  pendingOperations: [],
-  operations: [],
-  currencyId: "ethereum",
-  unitMagnitude: 18,
-  balance: "",
-  blockHeight: 0,
-  lastSyncDate: "",
-  xpub: "",
-};
+import { ethereum1 } from "./datasets/ethereum1";
 
 const expectedTokenAccount = (a) => {
   invariant(a && a.type === "TokenAccount", "expected token account");
@@ -171,4 +157,5 @@ const dataset: DatasetTest<Transaction> = {
     ethereum_classic,
   },
 };
-export default dataset;
+
+testBridge(dataset);

package/src/families/ethereum/datasets/ethereum1.ts

@@ -0,0 +1,20 @@
+import type { AccountRaw } from "../../../types";
+
+export const ethereum1: AccountRaw = {
+  id: "js:1:ethereum:0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5:",
+  seedIdentifier: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
+  name: "Ethereum legacy xpub6Bem...JyAdpYZy",
+  derivationMode: "",
+  index: 0,
+  freshAddress: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
+  freshAddressPath: "44'/60'/0'/0/0",
+  freshAddresses: [],
+  pendingOperations: [],
+  operations: [],
+  currencyId: "ethereum",
+  unitMagnitude: 18,
+  balance: "",
+  blockHeight: 0,
+  lastSyncDate: "",
+  xpub: "",
+};

package/src/families/ethereum/modules/{compound.resilience.test.ts → compound.resilience.integration.test.ts}

@@ -4,7 +4,7 @@ import { fromAccountRaw } from "../../../account";
 import type { Account } from "../../../types";
 import { getAccountBridge } from "../../../bridge";
 import { makeBridgeCacheSystem } from "../../../bridge/cache";
-import { ethereum1 } from "../test-dataset";
+import { ethereum1 } from "../datasets/ethereum1";
 import { setEnv } from "../../../env";
 setEnv("COMPOUND_API", "https://status.ledger.com"); // hack to hit an endpoint that actually is going to 404
 

package/src/families/ethereum/modules/erc1155.ts

@@ -8,8 +8,8 @@ import {
 } from "@ledgerhq/errors";
 import { validateRecipient } from "../transaction";
 import type { ModeModule, Transaction } from "../types";
-import type { Account } from "../../../types";
 import { prepareTransaction } from "./erc721";
+import { Account } from "../../../types";
 
 const NotOwnedNft = createCustomErrorClass("NotOwnedNft");
 const NotEnoughNftOwned = createCustomErrorClass("NotEnoughNftOwned");
@@ -124,10 +124,17 @@ const erc1155Transfer: ModeModule = {
    */
   fillOptimisticOperation(a, t, op) {
     op.type = "FEES";
-    op.extra = {
-      ...op.extra,
-      approving: true, // workaround to track the status ENABLING
-    };
+    op.nftOperations = t.tokenIds?.map((tokenId, i) => ({
+      ...op,
+      id: "", // operation ID will be filled by patchOperationWithHash
+      type: "NFT_OUT",
+      senders: [eip55.encode(a.freshAddress)],
+      recipients: [eip55.encode(t.recipient)],
+      standard: "ERC1155",
+      contract: eip55.encode(t.collection ?? ""),
+      tokenId,
+      value: t.quantities?.[i] || new BigNumber(0),
+    }));
   },
 
   prepareTransaction,

package/src/families/ethereum/modules/erc721.ts

@@ -118,6 +118,17 @@ const erc721Transfer: ModeModule = {
    */
   fillOptimisticOperation(a, t, op) {
     op.type = "FEES";
+    op.nftOperations = t.tokenIds?.map((tokenId, i) => ({
+      ...op,
+      id: "", // operation ID will be filled by patchOperationWithHash
+      type: "NFT_OUT",
+      senders: [eip55.encode(a.freshAddress)],
+      recipients: [eip55.encode(t.recipient)],
+      standard: "ERC721",
+      contract: eip55.encode(t.collection ?? ""),
+      tokenId,
+      value: t.quantities?.[i] || new BigNumber(0),
+    }));
   },
 
   getResolutionConfig: () => ({ nft: true }),

package/src/families/ethereum/nft.unit.test.ts

@@ -13,6 +13,7 @@ import {
   nftsFromOperations,
 } from "../../nft";
 import { Transaction } from "./types";
+import { encodeERC1155OperationId } from "../../nft/nftOperationId";
 
 describe("nft merging", () => {
   const makeNFT = (
@@ -92,18 +93,21 @@ describe("nft merging", () => {
 describe("OpenSea lazy minting bs", () => {
   test("should have a correct on-chain nft amount even with OpenSea lazy minting", () => {
     const makeNftOperation = (
-      type: Operation["type"],
-      value: string | number,
-      dateOrder: number
+      params: [Operation["type"], number],
+      index: number
     ): Operation => {
+      const [type, value] = params;
+
       if (!["NFT_IN", "NFT_OUT"].includes(type)) {
         return {} as Operation;
       }
 
-      const id = encodeAccountId({
+      const now = Date.now() + index;
+      const currencyId = "polygon";
+      const accountId = encodeAccountId({
         type: "type",
-        currencyId: "polygon",
         xpubOrAddress: "0xbob",
+        currencyId,
         derivationMode: "",
         version: "1",
       });
@@ -112,11 +116,12 @@ describe("OpenSea lazy minting bs", () => {
       const contract = "0x0000000000000000000000000000000000000000";
       const fee = new BigNumber(0);
       const tokenId = "42069";
-      const hash = "FaKeHasH";
-      const date = new Date(Date.now() + dateOrder ?? 0);
+      const hash = "FaKeHasH" + now;
+      const date = new Date(now);
+      const nftId = encodeNftId(accountId, contract, tokenId, currencyId);
 
       return {
-        id,
+        id: encodeERC1155OperationId(nftId, hash, type),
         hash,
         senders: [sender],
         recipients: [receiver],
@@ -126,20 +131,22 @@ describe("OpenSea lazy minting bs", () => {
         tokenId,
         value: new BigNumber(value),
         type,
-        accountId: id,
+        accountId,
         date,
       } as Operation;
     };
 
     // scenario with bob lazy minting 10 NFTs
-    const ops = [
-      makeNftOperation("NFT_OUT", 5, 0), // lazy mint sending 5 NFT
-      makeNftOperation("NFT_IN", 1, 1), // receiving 1 of them back
-      makeNftOperation("NFT_IN", 2, 2), // receiving 2 of them back
-      makeNftOperation("NFT_OUT", 2, 3), // lazy mint sending 5 NFT (transformed by OpenSea in 2 txs) 1/2 (off-chain)
-      makeNftOperation("NFT_OUT", 3, 4), // lazy mint sending 5 NFT (transformed by OpenSea in 2 txs) 2/2 (on-chain)
-      makeNftOperation("NFT_IN", 1, 5), // receiving 1 back
-    ];
+    const ops = (
+      [
+        ["NFT_OUT", 5], // lazy mint sending 5 NFT
+        ["NFT_IN", 1], // receiving 1 of them back
+        ["NFT_IN", 2], // receiving 2 of them back
+        ["NFT_OUT", 2], // lazy mint sending 5 NFT (transformed by OpenSea in 2 txs) 1/2 (off-chain)
+        ["NFT_OUT", 3], // lazy mint sending 5 NFT (transformed by OpenSea in 2 txs) 2/2 (on-chain)
+        ["NFT_IN", 1], // receiving 1 back
+      ] as [Operation["type"], number][]
+    ).map((params, i) => makeNftOperation(params, i));
 
     // What happened for bob:
     //

package/src/families/ethereum/{synchronisation.test.ts → synchronisation.integration.test.ts}

@@ -5,7 +5,7 @@ import { getAccountCurrency } from "../../account/helpers";
 import type { Account, SubAccount } from "../../types";
 import { getAccountBridge } from "../../bridge";
 import { makeBridgeCacheSystem } from "../../bridge/cache";
-import { ethereum1 } from "./test-dataset";
+import { ethereum1 } from "./datasets/ethereum1";
 
 describe("blacklistedTokenIds functionality", () => {
   const account = fromAccountRaw(ethereum1);

package/src/families/ethereum/synchronisation.ts

@@ -20,6 +20,11 @@ import { API, apiForCurrency, Tx } from "../../api/Ethereum";
 import { digestTokenAccounts, prepareTokenAccounts } from "./modules";
 import { findTokenByAddressInCurrency } from "@ledgerhq/cryptoassets";
 import { encodeNftId, isNFTActive, nftsFromOperations } from "../../nft";
+import { encodeOperationId } from "../../operation";
+import {
+  encodeERC1155OperationId,
+  encodeERC721OperationId,
+} from "../../nft/nftOperationId";
 
 export const getAccountShape: GetAccountShape = async (
   infoInput,
@@ -167,7 +172,9 @@ export const getAccountShape: GetAccountShape = async (
   const nfts = isNFTActive(currency)
     ? mergeNfts(
         initialAccount?.nfts || [],
-        nftsFromOperations(operations).filter((n) => n.amount.gt(0))
+        nftsFromOperations(
+          mergeOps(operations, initialAccount?.pendingOperations || [])
+        ).filter((n) => n.amount.gt(0))
       )
     : undefined;
 
@@ -289,7 +296,7 @@ const txToOps =
           if (sending) {
             const type = "OUT";
             all.push({
-              id: `${accountId}-${hash}-${type}`,
+              id: encodeOperationId(accountId, hash, type),
               hash,
               type,
               value,
@@ -308,7 +315,7 @@ const txToOps =
           if (receiving) {
             const type = "IN";
             all.push({
-              id: `${accountId}-${hash}-${type}`,
+              id: encodeOperationId(accountId, hash, type),
               hash,
               type,
               value,
@@ -349,7 +356,7 @@ const txToOps =
             if (sending) {
               const type = "NFT_OUT";
               all.push({
-                id: `${nftId}-${hash}-${type}`,
+                id: encodeERC721OperationId(nftId, hash, type),
                 senders: [sender],
                 recipients: [receiver],
                 contract,
@@ -371,7 +378,7 @@ const txToOps =
             if (receiving) {
               const type = "NFT_IN";
               all.push({
-                id: `${nftId}-${hash}-${type}`,
+                id: encodeERC721OperationId(nftId, hash, type),
                 senders: [sender],
                 recipients: [receiver],
                 contract,
@@ -414,17 +421,12 @@ const txToOps =
             event.transfers.forEach((transfer, j) => {
               const tokenId = transfer.id;
               const value = new BigNumber(transfer.value);
-              const nftId = encodeNftId(
-                id,
-                event.contract,
-                tokenId,
-                currency.id
-              );
+              const nftId = encodeNftId(id, contract, tokenId, currency.id);
 
               if (sending) {
                 const type = "NFT_OUT";
                 all.push({
-                  id: `${nftId}-${hash}-${type}-i${i}_${j}`,
+                  id: encodeERC1155OperationId(nftId, hash, type, i, j),
                   senders: [sender],
                   recipients: [receiver],
                   contract,
@@ -447,7 +449,7 @@ const txToOps =
               if (receiving) {
                 const type = "NFT_IN";
                 all.push({
-                  id: `${nftId}-${hash}-${type}-i${i}_${j}`,
+                  id: encodeERC1155OperationId(nftId, hash, type, i, j),
                   senders: [sender],
                   recipients: [receiver],
                   contract,
@@ -481,7 +483,7 @@ const txToOps =
     if (sending) {
       const type = value.eq(0) ? "FEES" : "OUT";
       ops.push({
-        id: `${id}-${hash}-${type}`,
+        id: encodeOperationId(id, hash, type),
         hash,
         type,
         value: hasFailed ? new BigNumber(fee) : value.plus(fee),
@@ -502,10 +504,11 @@ const txToOps =
     }
 
     if (receiving) {
+      const type = "IN";
       ops.push({
-        id: `${id}-${hash}-IN`,
+        id: encodeOperationId(id, hash, type),
         hash: hash,
-        type: "IN",
+        type,
         value,
         fee,
         blockHeight,
@@ -531,10 +534,11 @@ const txToOps =
         subOperations.length ||
         nftOperations.length)
     ) {
+      const type = "NONE";
       ops.push({
-        id: `${id}-${hash}-NONE`,
+        id: encodeOperationId(id, hash, type),
         hash: hash,
-        type: "NONE",
+        type,
         value: new BigNumber(0),
         fee,
         blockHeight,

package/src/families/filecoin/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,10 +1,17 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+import { getAccountBridge } from "../../bridge";
+import {
+  decodeAccountId,
+  encodeAccountId,
+  fromAccountRaw,
+} from "../../account";
 import { BigNumber } from "bignumber.js";
 import {
   AmountRequired,
   InvalidAddress,
   NotEnoughBalance,
 } from "@ledgerhq/errors";
-
 import type { DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import { fromTransactionRaw } from "../filecoin/transaction";
@@ -13,7 +20,6 @@ import { CurrenciesData } from "../../types";
 const SEED_IDENTIFIER = "f1p74d4mlmeyc4agflhjqsnvoyzyfdai7fmkyso2a";
 const ACCOUNT_1 = "f1p74d4mlmeyc4agflhjqsnvoyzyfdai7fmkyso2a";
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const filecoin: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [],
   scanAccounts: [
@@ -150,4 +156,30 @@ const dataset: DatasetTest<Transaction> = {
     filecoin,
   },
 };
-export default dataset;
+
+testBridge(dataset);
+
+describe("estimateMaxSpendable", () => {
+  test("it should failed on invalid recipient", async () => {
+    const accounts = dataset.currencies["filecoin"].accounts || [];
+    const accountData = accounts[0];
+
+    const account = fromAccountRaw({
+      ...accountData.raw,
+      id: encodeAccountId({
+        ...decodeAccountId(accountData.raw.id),
+        type: dataset.implementations[0],
+      }),
+    });
+
+    const accountBridge = getAccountBridge(account);
+    const estimate = async () => {
+      await accountBridge.estimateMaxSpendable({
+        account,
+        transaction: { recipient: "notavalidrecipient" },
+      });
+    };
+
+    await expect(estimate).rejects.toThrowError(new InvalidAddress());
+  });
+});

package/src/families/hedera/__snapshots__/bridge.integration.test.ts.snap

@@ -0,0 +1,5 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`hedera currency bridge scanAccounts hedera seed 1 1`] = `Array []`;
+
+exports[`hedera currency bridge scanAccounts hedera seed 1 2`] = `Array []`;

package/src/families/hedera/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,5 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
 import type { CurrenciesData, DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import {
@@ -88,7 +90,8 @@ const hedera: CurrenciesData<Transaction> = {
 const dataset: DatasetTest<Transaction> = {
   implementations: ["js"],
   currencies: {
-    // hedera, // LIVE-2376
+    hedera,
   },
 };
-export default dataset;
+
+testBridge(dataset);

package/src/families/polkadot/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,4 +1,9 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+import { disconnect } from "./api";
 import { BigNumber } from "bignumber.js";
+import { canUnbond, MAX_UNLOCKINGS } from "./logic";
+import type { Account } from "../../types";
 import {
   NotEnoughBalance,
   RecipientRequired,
@@ -15,7 +20,7 @@ import {
   PolkadotAllFundsWarning,
   PolkadotDoMaxSendInstead,
 } from "./errors";
-import type { DatasetTest } from "../../types";
+import type { DatasetTest, CurrenciesData } from "../../types";
 import { fromTransactionRaw } from "./transaction";
 import type { Transaction } from "./types";
 const ACCOUNT_SAME_STASHCONTROLLER =
@@ -26,8 +31,7 @@ const ACCOUNT_EMPTY = "111111111111111111111111111111111HC1";
 const ACCOUNT_WITH_NO_OPERATION =
   "12EsPA79dvhtjp1bYvCiEWPsQmmdKGss44GzE3CT9tTo9g4Q";
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const polkadot = {
+const polkadot: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [
     "polkadotResources.unlockings", // Due to completion date that change everyday (estimated time)
     "polkadotResources.nominations", // TODO: try to only ignore status
@@ -685,7 +689,79 @@ const polkadot = {
 const dataset: DatasetTest<Transaction> = {
   implementations: ["js"],
   currencies: {
-    // polkadot, // LL-7806
+    polkadot,
   },
 };
-export default dataset;
+
+// Disconnect all api clients that could be open.
+afterAll(async () => {
+  await disconnect();
+});
+
+testBridge(dataset);
+
+describe("canUnbond", () => {
+  test("can unbond", () => {
+    const account: Partial<Account> = {
+      polkadotResources: {
+        controller: "",
+        stash: "",
+        nonce: 0,
+        numSlashingSpans: 0,
+        lockedBalance: new BigNumber(10000),
+        unlockedBalance: new BigNumber(0),
+        unlockingBalance: new BigNumber(0),
+        nominations: [],
+        unlockings: [
+          ...Array(MAX_UNLOCKINGS - 1).map(() => ({
+            amount: new BigNumber(Math.random()),
+            completionDate: new Date(),
+          })),
+        ],
+      },
+    };
+    expect(canUnbond(account as Account)).toBeTruthy();
+  });
+  test("can't unbond because unlockings is too much", () => {
+    const account: Partial<Account> = {
+      polkadotResources: {
+        controller: "",
+        stash: "",
+        nonce: 0,
+        numSlashingSpans: 0,
+        lockedBalance: new BigNumber(1000000),
+        unlockedBalance: new BigNumber(0),
+        unlockingBalance: new BigNumber(0),
+        nominations: [],
+        unlockings: [
+          ...Array(MAX_UNLOCKINGS).map(() => ({
+            amount: new BigNumber(Math.random()),
+            completionDate: new Date(),
+          })),
+        ],
+      },
+    };
+    expect(canUnbond(account as Account)).toBeFalsy();
+  });
+  test("can't unbond because not enough lockedBalance", () => {
+    const account: Partial<Account> = {
+      polkadotResources: {
+        controller: "",
+        stash: "",
+        nonce: 0,
+        numSlashingSpans: 0,
+        lockedBalance: new BigNumber(100),
+        unlockedBalance: new BigNumber(0),
+        unlockingBalance: new BigNumber(100),
+        nominations: [],
+        unlockings: [
+          ...Array(MAX_UNLOCKINGS).map(() => ({
+            amount: new BigNumber(Math.random()),
+            completionDate: new Date(),
+          })),
+        ],
+      },
+    };
+    expect(canUnbond(account as Account)).toBeFalsy();
+  });
+});

package/src/families/ripple/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,6 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+
 // import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
 import { BigNumber } from "bignumber.js";
 import type { DatasetTest } from "../../types";
@@ -160,4 +163,5 @@ const dataset: DatasetTest<Transaction> = {
     },
   },
 };
-export default dataset;
+
+testBridge(dataset);