@ledgerhq/live-common 23.1.0 → 24.0.0-next.2

package/src/__tests__/test-helpers/bridge.ts

@@ -1,6 +1,5 @@
 import invariant from "invariant";
 import { BigNumber } from "bignumber.js";
-import { Observable, defer, from } from "rxjs";
 import { reduce, filter, map } from "rxjs/operators";
 import flatMap from "lodash/flatMap";
 import omit from "lodash/omit";
@@ -32,7 +31,6 @@ import {
   toTransactionRaw,
   toTransactionStatusRaw,
 } from "../../transaction";
-import { getBalanceHistoryJS, getRanges } from "../../portfolio";
 import { getAccountBridge, getCurrencyBridge } from "../../bridge";
 import { mockDeviceWithAPDUs, releaseMockDevice } from "./mockDevice";
 import { implicitMigration } from "../../migrations/accounts";
@@ -69,10 +67,7 @@ export function syncAccount<T extends Transaction>(
     .toPromise();
 }
 
-export function testBridge<T extends Transaction>(
-  family: string,
-  data: DatasetTest<T>
-) {
+export function testBridge<T extends Transaction>(data: DatasetTest<T>): void {
   // covers all bridges through many different accounts
   // to test the common shared properties of bridges.
   const accountsRelated: Array<{
@@ -120,7 +115,7 @@ export function testBridge<T extends Transaction>(
     );
   });
   const accountsFoundInScanAccountsMap = {};
-  const preloadObservables: Array<Observable<any>> = [];
+
   currenciesRelated.map(({ currencyData, currency }) => {
     const bridge = getCurrencyBridge(currency);
 
@@ -212,16 +207,6 @@ export function testBridge<T extends Transaction>(
         describe("scanAccounts", () => {
           scanAccounts.forEach((sa) => {
             // we start running the scan accounts in parallel!
-            preloadObservables.push(
-              defer(() =>
-                from(
-                  scanAccountsCached(sa.apdus).then(
-                    () => null,
-                    () => {}
-                  )
-                )
-              )
-            );
             test(sa.name, async () => {
               const accounts = await scanAccountsCached(sa.apdus);
               accounts.forEach((a) => {
@@ -514,21 +499,6 @@ export function testBridge<T extends Transaction>(
             });
           });
         });
-        makeTest(
-          "account balanceHistory (when exists) matches getBalanceHistoryJS",
-          async () => {
-            const account = await getSynced();
-            getRanges().forEach((range) => {
-              const balanceHistory =
-                account.balanceHistory && account.balanceHistory[range];
-              if (!balanceHistory) return;
-              const history = getBalanceHistoryJS(account, range);
-              expect(balanceHistory.map((b) => b.value)).toEqual(
-                history.map((b) => b.value)
-              );
-            });
-          }
-        );
         describe("createTransaction", () => {
           makeTest(
             "empty transaction is an object with empty recipient and zero amount",
@@ -785,7 +755,4 @@ export function testBridge<T extends Transaction>(
         });
       });
     });
-  return {
-    preloadObservables,
-  };
 }

package/src/__tests__/test-helpers/setup.ts

@@ -1,6 +1,9 @@
+import winston from "winston";
+import { listen } from "@ledgerhq/logs";
 import BigNumber from "bignumber.js";
 import { setSupportedCurrencies } from "../../currencies";
 import { setPlatformVersion } from "../../platform/version";
+import { EnvName, setEnvUnsafe } from "../../env";
 
 jest.setTimeout(360000);
 
@@ -62,3 +65,39 @@ setSupportedCurrencies([
   "cardano",
   "cardano_testnet",
 ]);
+
+for (const k in process.env) setEnvUnsafe(k as EnvName, process.env[k]);
+
+const { VERBOSE, VERBOSE_FILE } = process.env;
+const logger = winston.createLogger({
+  level: "debug",
+  transports: [],
+});
+const { format } = winston;
+const { combine, timestamp, json } = format;
+const winstonFormat = combine(timestamp(), json());
+
+if (VERBOSE_FILE) {
+  logger.add(
+    new winston.transports.File({
+      format: winstonFormat,
+      filename: VERBOSE_FILE,
+      level: "debug",
+    })
+  );
+}
+
+logger.add(
+  new winston.transports.Console({
+    format: winstonFormat,
+    silent: !VERBOSE,
+  })
+);
+// eslint-disable-next-line no-unused-vars
+listen(({ type, message, ...rest }) => {
+  logger.log("debug", {
+    message: type + (message ? ": " + message : ""),
+    // $FlowFixMe
+    ...rest,
+  });
+});

package/src/api/Ripple.ts

@@ -2,6 +2,8 @@ import { BigNumber } from "bignumber.js";
 import { getEnv } from "../env";
 import network from "../network";
 import { parseCurrencyUnit, getCryptoCurrencyById } from "../currencies";
+import { retry } from "../promise";
+import { NEW_ACCOUNT_ERROR_MESSAGE } from "../families/ripple/bridge/js";
 
 const defaultEndpoint = () => getEnv("API_RIPPLE_RPC");
 
@@ -47,74 +49,117 @@ export const getAccountInfo = async (
   recipient: string,
   current?: boolean
 ): Promise<AccountInfo> => {
-  const res = await network({
-    method: "POST",
-    url: `${defaultEndpoint()}`,
-    data: {
-      method: "account_info",
-      params: [
-        {
-          account: recipient,
-          ledger_index: current ? "current" : "validated",
-        },
-      ],
-    },
+  const res = async () => {
+    const res = await network({
+      method: "POST",
+      url: `${defaultEndpoint()}`,
+      data: {
+        method: "account_info",
+        params: [
+          {
+            account: recipient,
+            ledger_index: current ? "current" : "validated",
+          },
+        ],
+      },
+    });
+    if (
+      res.data.result.status !== "success" &&
+      res.data.result.error !== NEW_ACCOUNT_ERROR_MESSAGE
+    ) {
+      throw new Error(`couldn't fetch account info ${recipient}`);
+    }
+
+    return res.data.result;
+  };
+
+  return retry(() => res(), {
+    maxRetry: getEnv("GET_CALLS_RETRY"),
   });
-  return res.data.result;
 };
 
 export const getServerInfo = async (
   endpointConfig?: string | null | undefined
 ): Promise<any> => {
-  const res = await network({
-    method: "POST",
-    url: endpointConfig ?? `${defaultEndpoint()}`,
-    data: {
-      method: "server_info",
-      params: [
-        {
-          ledger_index: "validated",
-        },
-      ],
-    },
-  });
+  const res = async () => {
+    const res = await network({
+      method: "POST",
+      url: endpointConfig ?? `${defaultEndpoint()}`,
+      data: {
+        method: "server_info",
+        params: [
+          {
+            ledger_index: "validated",
+          },
+        ],
+      },
+    });
 
-  return res.data.result;
+    if (res.data.result.status !== "success") {
+      throw new Error(`couldn't fetch server info`);
+    }
+
+    return res.data.result;
+  };
+
+  return retry(() => res(), {
+    maxRetry: getEnv("GET_CALLS_RETRY"),
+  });
 };
 
 export const getTransactions = async (
   address: string,
   options: any | undefined
 ): Promise<any> => {
-  const res = await network({
-    method: "POST",
-    url: `${defaultEndpoint()}`,
-    data: {
-      method: "account_tx",
-      params: [
-        {
-          account: address,
-          ledger_index: "validated",
-          ...options,
-        },
-      ],
-    },
+  const res = async () => {
+    const res = await network({
+      method: "POST",
+      url: `${defaultEndpoint()}`,
+      data: {
+        method: "account_tx",
+        params: [
+          {
+            account: address,
+            ledger_index: "validated",
+            ...options,
+          },
+        ],
+      },
+    });
+    return res.data.result.transactions;
+
+    if (res.data.result.status !== "success") {
+      throw new Error(`couldn't getTransactions for ${address}`);
+    }
+  };
+
+  return retry(() => res(), {
+    maxRetry: getEnv("GET_CALLS_RETRY"),
   });
-  return res.data.result.transactions;
 };
 
 export default async function getLedgerIndex(): Promise<number> {
-  const ledgerResponse = await network({
-    method: "POST",
-    url: `${defaultEndpoint()}`,
-    data: {
-      method: "ledger",
-      params: [
-        {
-          ledger_index: "validated",
-        },
-      ],
-    },
+  const res = async () => {
+    const ledgerResponse = await network({
+      method: "POST",
+      url: `${defaultEndpoint()}`,
+      data: {
+        method: "ledger",
+        params: [
+          {
+            ledger_index: "validated",
+          },
+        ],
+      },
+    });
+
+    if (ledgerResponse.data.result.status !== "success") {
+      throw new Error(`couldn't fetch getLedgerIndex`);
+    }
+
+    return ledgerResponse.data.result.ledger_index;
+  };
+  return retry(() => res(), {
+    maxRetry: getEnv("GET_CALLS_RETRY"),
   });
-  return ledgerResponse.data.result.ledger_index;
 }

package/src/apps/support.ts

@@ -21,7 +21,9 @@ export function shouldUpgrade(
     appName === "Bitcoin"
   ) {
     // https://donjon.ledger.com/lsb/010/
-    return !semver.satisfies(semver.coerce(appVersion) || "", ">= 1.4.0");
+    return !semver.satisfies(appVersion || "", ">= 1.4.0", {
+      includePrerelease: true, // this will allow pre-release tags that would otherwise return false. E.g. 1.0.0-dev
+    });
   }
 
   return false;
@@ -43,7 +45,9 @@ export function mustUpgrade(
   const range = appVersionsRequired[appName];
 
   if (range) {
-    return !semver.satisfies(appVersion, range);
+    return !semver.satisfies(appVersion || "", range, {
+      includePrerelease: true, // this will allow pre-release tags that would otherwise return false. E.g. 1.0.0-dev
+    });
   }
 
   return false;

package/src/bot/index.ts

@@ -22,11 +22,10 @@ import { runWithAppSpec } from "./engine";
 import { formatReportForConsole, formatError } from "./formatters";
 import {
   initialState,
-  calculate,
   loadCountervalues,
   inferTrackingPairForAccounts,
 } from "../countervalues/logic";
-import { getPortfolio } from "../portfolio";
+import { getPortfolio } from "../portfolio/v2";
 type Arg = Partial<{
   currency: string;
   family: string;
@@ -119,23 +118,15 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
   });
   const period = "month";
 
-  const calc = (c, v, date) =>
-    countervaluesState
-      ? new BigNumber(
-          calculate(countervaluesState, {
-            date,
-            value: v.toNumber(),
-            from: c,
-            to: usd,
-          }) || 0
-        )
-      : new BigNumber(0);
-
-  const portfolio = getPortfolio(allAccountsAfter, period, calc);
-  const totalUSD = countervaluesState
+  const portfolio = countervaluesState
+    ? getPortfolio(allAccountsAfter, period, countervaluesState, usd)
+    : null;
+  const totalUSD = portfolio
     ? formatCurrencyUnit(
         usd.units[0],
-        portfolio.balanceHistory[portfolio.balanceHistory.length - 1].value,
+        new BigNumber(
+          portfolio.balanceHistory[portfolio.balanceHistory.length - 1].value
+        ),
         {
           showCode: true,
         }
@@ -378,14 +369,25 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
     }
 
     if (countervaluesState && r.accountsAfter) {
-      const portfolio = getPortfolio(r.accountsAfter, period, calc);
-      const totalUSD = formatCurrencyUnit(
-        usd.units[0],
-        portfolio.balanceHistory[portfolio.balanceHistory.length - 1].value,
-        {
-          showCode: true,
-        }
+      const portfolio = getPortfolio(
+        r.accountsAfter,
+        period,
+        countervaluesState,
+        usd
       );
+      const totalUSD = portfolio
+        ? formatCurrencyUnit(
+            usd.units[0],
+            new BigNumber(
+              portfolio.balanceHistory[
+                portfolio.balanceHistory.length - 1
+              ].value
+            ),
+            {
+              showCode: true,
+            }
+          )
+        : "";
       balance += " (" + totalUSD + ")";
     }
 

package/src/bot/test.bot.ts

@@ -1,6 +1,6 @@
-import { setup } from "../__tests__/test-helpers/libcore-setup";
+import "../__tests__/test-helpers/setup";
 import { bot } from ".";
-setup("bot");
+
 jest.setTimeout(110 * 60 * 1000);
 const { BOT_FILTER_CURRENCY, BOT_FILTER_FAMILY } = process.env;
 test("bot", async () => {

package/src/countervalues/react.tsx

@@ -10,30 +10,8 @@ import React, {
   useCallback,
   ReactElement,
 } from "react";
-import type {
-  Account,
-  AccountLike,
-  PortfolioRange,
-  Currency,
-  CryptoCurrency,
-  TokenCurrency,
-  AccountPortfolio,
-  Portfolio,
-  CurrencyPortfolio,
-  AssetsDistribution,
-  Unit,
-} from "../types";
-import {
-  getBalanceHistoryWithCountervalue,
-  getPortfolio,
-  getCurrencyPortfolio,
-  getAssetsDistribution,
-} from "../portfolio";
-import {
-  getAccountCurrency,
-  flattenAccounts,
-  getAccountUnit,
-} from "../account/helpers";
+import type { Account, AccountLike, Currency, Unit } from "../types";
+import { getAccountCurrency, getAccountUnit } from "../account/helpers";
 import {
   initialState,
   calculate,
@@ -304,113 +282,6 @@ export function useCalculateMany(
   // TODO how to approach perf for this? hash function of the datapoints? responsability on user land?
   return calculateMany(state, dataPoints, query);
 }
-// TODO perf of the useCalculate*, does it even worth worrying?
-// TODO move to portfolio module (I couldn't make useCountervaluesState to work there)
-export function useBalanceHistoryWithCountervalue({
-  account,
-  range,
-  to,
-}: {
-  account: AccountLike;
-  range: PortfolioRange;
-  to: Currency;
-}): AccountPortfolio {
-  const from = getAccountCurrency(account);
-  const state = useCountervaluesState();
-  return useMemo(
-    () =>
-      getBalanceHistoryWithCountervalue(account, range, (_, value, date) => {
-        const countervalue = calculate(state, {
-          value: value.toNumber(),
-          from,
-          to,
-          disableRounding: true,
-          date,
-        });
-        return typeof countervalue === "number"
-          ? new BigNumber(countervalue)
-          : countervalue;
-      }),
-    [account, from, to, range, state]
-  );
-}
-export function usePortfolio({
-  accounts,
-  range,
-  to,
-}: {
-  accounts: Account[];
-  range: PortfolioRange;
-  to: Currency;
-}): Portfolio {
-  const state = useCountervaluesState();
-  return useMemo(
-    () =>
-      getPortfolio(accounts, range, (from, value, date) => {
-        const countervalue = calculate(state, {
-          value: value.toNumber(),
-          from,
-          to,
-          disableRounding: true,
-          date,
-        });
-        return typeof countervalue === "number"
-          ? new BigNumber(countervalue)
-          : countervalue;
-      }),
-    [accounts, range, state, to]
-  );
-}
-export function useCurrencyPortfolio({
-  accounts: rawAccounts,
-  range,
-  to,
-  currency,
-}: {
-  accounts: Account[];
-  range: PortfolioRange;
-  to: Currency;
-  currency: CryptoCurrency | TokenCurrency;
-}): CurrencyPortfolio {
-  const accounts = flattenAccounts(rawAccounts).filter(
-    (a) => getAccountCurrency(a) === currency
-  );
-  const state = useCountervaluesState();
-  return useMemo(
-    () =>
-      getCurrencyPortfolio(accounts, range, (from, value, date) => {
-        const countervalue = calculate(state, {
-          value: value.toNumber(),
-          from,
-          to,
-          disableRounding: true,
-          date,
-        });
-        return typeof countervalue === "number"
-          ? new BigNumber(countervalue)
-          : countervalue;
-      }),
-    [accounts, range, state, to]
-  );
-}
-export function useDistribution({
-  accounts,
-  to,
-}: {
-  accounts: Account[];
-  to: Currency;
-}): AssetsDistribution {
-  const calc = useCalculateCountervalueCallback({
-    to,
-  });
-  return useMemo(() => {
-    return getAssetsDistribution(accounts, calc, {
-      minShowFirst: 6,
-      maxShowFirst: 6,
-      showFirstThreshold: 0.95,
-    });
-  }, [accounts, calc]);
-}
 
 export function useCalculateCountervalueCallback({
   to,

package/src/currencies/__snapshots__/sortByMarketcap.test.ts.snap

@@ -118,7 +118,6 @@ Array [
   "ethereum/erc20/thorchain_eth_rune",
   "ethereum/erc20/acuteanglecoin",
   "pivx",
-  "ethereum/erc20/constellation_token",
   "ethereum/erc20/reserve_rights",
   "ethereum/erc20/wcoin",
   "ethereum/erc20/shipchain",
@@ -1747,6 +1746,7 @@ Array [
   "ethereum/erc20/bavala",
   "ethereum/erc20/bayc_history_-the_great_floor_sweep",
   "ethereum/erc20/baz_token",
+  "ethereum/erc20/bb_verse",
   "ethereum/erc20/bbn",
   "ethereum/erc20/bcap",
   "ethereum/erc20/bcat",
@@ -2751,6 +2751,7 @@ Array [
   "ethereum/erc20/eub_chain",
   "ethereum/erc20/eur_tether__erc20_",
   "ethereum/erc20/eurbase_stablecoin",
+  "ethereum/erc20/euro_coin",
   "ethereum/erc20/euro_stable_token",
   "ethereum/erc20/europechain",
   "ethereum/erc20/eurxb",
@@ -2868,6 +2869,7 @@ Array [
   "ethereum/erc20/floki_wife",
   "ethereum/erc20/flow_protocol",
   "ethereum/erc20/flux",
+  "ethereum/erc20/flux_(zel)",
   "ethereum/erc20/flux_protocol",
   "ethereum/erc20/fluz_fluz_global",
   "ethereum/erc20/flynnjamm",
@@ -3412,6 +3414,7 @@ Array [
   "ethereum/erc20/konomi",
   "ethereum/erc20/korea_medical_tba",
   "ethereum/erc20/koris",
+  "ethereum/erc20/kounotori",
   "ethereum/erc20/kper_network",
   "ethereum/erc20/kpop",
   "ethereum/erc20/kprcoin",
@@ -4678,6 +4681,7 @@ Array [
   "ethereum/erc20/strikex",
   "ethereum/erc20/strips_token",
   "ethereum/erc20/strong",
+  "ethereum/erc20/stronger",
   "ethereum/erc20/stronghold",
   "ethereum/erc20/strudel_finance",
   "ethereum/erc20/successlife",
@@ -4899,6 +4903,7 @@ Array [
   "ethereum/erc20/toka",
   "ethereum/erc20/tokamak_network_token",
   "ethereum/erc20/tokemak",
+  "ethereum/erc20/tokemaksushilppool",
   "ethereum/erc20/tokemon",
   "ethereum/erc20/token_1337",
   "ethereum/erc20/token_play",
@@ -5600,6 +5605,7 @@ Array [
   "polygon/erc20/cerby_token",
   "polygon/erc20/chainlink_token",
   "polygon/erc20/chiliz",
+  "polygon/erc20/city_of_block",
   "polygon/erc20/clintex",
   "polygon/erc20/clocks_token",
   "polygon/erc20/conch_coin",
@@ -5872,6 +5878,7 @@ Array [
   "bsc/bep20/bakerytoken",
   "bsc/bep20/bat_true_dollar",
   "bsc/bep20/bat_true_share",
+  "bsc/bep20/bb_verse",
   "bsc/bep20/bdollar",
   "bsc/bep20/bdollar_share",
   "bsc/bep20/bearn.fi",
@@ -5962,6 +5969,7 @@ Array [
   "bsc/bep20/canyacoin",
   "bsc/bep20/car",
   "bsc/bep20/cartesi_token",
+  "bsc/bep20/catcoin",
   "bsc/bep20/catecoin",
   "bsc/bep20/catecoin_old",
   "bsc/bep20/ceek",
@@ -6051,6 +6059,7 @@ Array [
   "bsc/bep20/floki_rocket",
   "bsc/bep20/flokimooni",
   "bsc/bep20/formation_finance",
+  "bsc/bep20/foxfinancev2",
   "bsc/bep20/free_coin_bsc",
   "bsc/bep20/frmx_token",
   "bsc/bep20/frog_inu",
@@ -6077,6 +6086,7 @@ Array [
   "bsc/bep20/hacken_token",
   "bsc/bep20/hakka_finance_on_xdai_on_bsc",
   "bsc/bep20/happinesstoken",
+  "bsc/bep20/happy_4th_of_july",
   "bsc/bep20/hard",
   "bsc/bep20/harmony_one",
   "bsc/bep20/hedge_token",
@@ -6100,6 +6110,7 @@ Array [
   "bsc/bep20/juggernaut_defi",
   "bsc/bep20/julswap",
   "bsc/bep20/jumptoken",
+  "bsc/bep20/jupyter",
   "bsc/bep20/jurassic_token",
   "bsc/bep20/kaby_arena",
   "bsc/bep20/kalmar_token",
@@ -6139,6 +6150,7 @@ Array [
   "bsc/bep20/mobox",
   "bsc/bep20/moeda_loyalty_points",
   "bsc/bep20/moeda_seeds",
+  "bsc/bep20/moneu_token",
   "bsc/bep20/monsta_infinite_token",
   "bsc/bep20/moomonster_token",
   "bsc/bep20/moonienft_token",
@@ -6240,6 +6252,7 @@ Array [
   "bsc/bep20/shambala",
   "bsc/bep20/shard",
   "bsc/bep20/shiba_inu",
+  "bsc/bep20/shibnobi",
   "bsc/bep20/shield_protocol",
   "bsc/bep20/shill",
   "bsc/bep20/shirtum",
@@ -6338,6 +6351,7 @@ Array [
   "bsc/bep20/waultswap",
   "bsc/bep20/wazirx_token",
   "bsc/bep20/weather",
+  "bsc/bep20/weed_inu",
   "bsc/bep20/weetwo",
   "bsc/bep20/weyu",
   "bsc/bep20/wink",