@lavalogic/scoria 0.37.44 → 0.37.45

package/dist/Components/Table/NestedTable.svelte

@@ -1,135 +1,132 @@
-<svelte:options runes />
-
-<script
-	lang="ts"
-	module
->
-	import Table from './Table.svelte';
-	import type { NestedTableProps } from './NestedTableProps.js';
-	import type { Primitive, TableInitOptions } from './Types/Context/TableInitOptions.js';
-	import { TableContext } from './Types/Context/TableContext.svelte.js';
-	import { LocalTableDataRepository } from './Types/DataRepository/LocalTableDataRepository.svelte.js';
-	import { ToolbarPosition } from './Types/Toolbar/ToolbarPosition.js';
-
-	/**
-	 * Default `TableInitOptions` overrides applied to every nested table.
-	 * Tuned for read-only inline display: copy, resize and column
-	 * reordering are turned off, quick / advanced filtering remain on so
-	 * the consumer can still narrow rows, the toolbar is hidden, and the
-	 * footer is suppressed because pagination is rarely useful for inline
-	 * nested data.
-	 *
-	 * Frozen so consumers cannot accidentally mutate the shared default
-	 * object.
-	 */
-	const DEFAULT_NESTED_TABLE_OPTIONS: Omit<
-		TableInitOptions<object, never>,
-		'selectionExtractor' | 'getUserId'
-	> = Object.freeze({
-		allowCopy: false,
-		enableResize: false,
-		// Was `false`; flipped to `true` so nested-table columns can be
-		// reordered and pinned by default like the outer table. The
-		// `inner.allowReorder` option on `col.expand` (and the matching
-		// `allowReorder` on top-level `createTable`) still lets callers
-		// opt out per inner table when they want to lock the layout.
-		allowColumnReordering: true,
-		allowQuickFiltering: true,
-		allowAdvancedFiltering: true,
-		toolbar: ToolbarPosition.None,
-		displayFooter: false,
-	});
-</script>
-
-<script
-	lang="ts"
-	generics="T extends object,IdType extends Primitive"
->
-	const {
-		tableName,
-		data,
-		columnDefWrapper,
-		options,
-		oncontextmenu,
-		getUserId,
-	}: NestedTableProps<T, IdType> = $props();
-
-	// Reactive wrapper exposing the `data` prop as `.value` so the
-	// underlying LocalTableDataRepository can read it through its
-	// RefWrapper contract without us materialising a copy.
-	const wrapper = {
-		get value() {
-			return data;
-		},
-	};
-
-	let root: HTMLDivElement | undefined = $state();
-
-	// Track the parent `.datatable`'s visible width (clientWidth) via
-	// ResizeObserver. `.datatable` is the horizontal scroll container,
-	// so its `clientWidth` is the visible viewport regardless of how
-	// wide the inner `.datatable-grid` has grown via `min-width:
-	// max-content`. Measuring `.flex_table` instead would pick up the
-	// scroll-content width through flex `min-width: auto` propagation,
-	// which sized the nested table to the full grid (much wider than
-	// the visible area) and broke the sticky-fit behaviour.
-	//
-	// Reading layout inside a derivation would force a synchronous
-	// reflow on every reactive re-run; the ResizeObserver path keeps
-	// it out of the reactive graph (workorder NestedTable P1).
-	let maxWidth: number | undefined = $state();
-	$effect(() => {
-		if (!root) {
-			return;
-		}
-		const scrollHost = root.closest('.datatable');
-		if (!(scrollHost instanceof HTMLElement)) {
-			return;
-		}
-		maxWidth = scrollHost.clientWidth;
-		const ro = new ResizeObserver(() => {
-			maxWidth = scrollHost.clientWidth;
-		});
-		ro.observe(scrollHost);
-		return () => {
-			ro.disconnect();
-		};
-	});
-
-	// These class instances are plain objects whose internal fields are
-	// already `$state`-backed; wrapping them in `$state(...)` (as the
-	// pre-cleanup version did) adds a redundant reactive layer. The
-	// dataRepo and tableContext references must remain stable across
-	// updates: a fresh `dataRepo` would clear filter/sort state, and a
-	// fresh `tableContext` would tear down focus.
-	//
-	// svelte-ignore state_referenced_locally
-	const dataRepo = new LocalTableDataRepository<T>(tableName, wrapper, () => getUserId());
-
-	// svelte-ignore state_referenced_locally
-	const tableContext = TableContext.init<T, IdType>(columnDefWrapper, tableName, dataRepo, {
-		...DEFAULT_NESTED_TABLE_OPTIONS,
-		...options,
-		getUserId: () => getUserId(),
-	});
-</script>
-
-<!-- svelte-ignore a11y_no_static_element_interactions -->
-<div
-	class="limit-height"
-	bind:this={root}
-	style:width={maxWidth != null ? `${maxWidth}px` : null}
-	oncontextmenu={(e) => {
-		e.stopPropagation();
-		oncontextmenu?.(e);
-	}}
->
-	<Table
-		nested
-		{tableContext}
-	/>
-</div>
-
+<svelte:options runes />
+
+<script
+	lang="ts"
+	module
+>
+	import Table from './Table.svelte';
+	import type { NestedTableProps } from './NestedTableProps.js';
+	import type { Primitive, TableInitOptions } from './Types/Context/TableInitOptions.js';
+	import { TableContext } from './Types/Context/TableContext.svelte.js';
+	import { LocalTableDataRepository } from './Types/DataRepository/LocalTableDataRepository.svelte.js';
+	import { ToolbarPosition } from './Types/Toolbar/ToolbarPosition.js';
+
+	/**
+	 * Default `TableInitOptions` overrides applied to every nested table.
+	 * Tuned for read-only inline display: copy, resize and column
+	 * reordering are turned off, quick / advanced filtering remain on so
+	 * the consumer can still narrow rows, the toolbar is hidden, and the
+	 * footer is suppressed because pagination is rarely useful for inline
+	 * nested data.
+	 *
+	 * Frozen so consumers cannot accidentally mutate the shared default
+	 * object.
+	 */
+	const DEFAULT_NESTED_TABLE_OPTIONS: Omit<
+		TableInitOptions<object, never>,
+		'selectionExtractor' | 'getUserId'
+	> = Object.freeze({
+		allowCopy: false,
+		enableResize: false,
+		// Nested-table columns can be reordered and pinned by default like
+		// the outer table. Callers opt out per inner table via the
+		// `inner.allowReorder` option on `col.expand` (or the matching
+		// `allowReorder` on top-level `createTable`).
+		allowColumnReordering: true,
+		allowQuickFiltering: true,
+		allowAdvancedFiltering: true,
+		toolbar: ToolbarPosition.None,
+		displayFooter: false,
+	});
+</script>
+
+<script
+	lang="ts"
+	generics="T extends object,IdType extends Primitive"
+>
+	const {
+		tableName,
+		data,
+		columnDefWrapper,
+		options,
+		oncontextmenu,
+		getUserId,
+	}: NestedTableProps<T, IdType> = $props();
+
+	// Reactive wrapper exposing the `data` prop as `.value` so the
+	// underlying LocalTableDataRepository can read it through its
+	// RefWrapper contract without us materialising a copy.
+	const wrapper = {
+		get value() {
+			return data;
+		},
+	};
+
+	let root: HTMLDivElement | undefined = $state();
+
+	// Track the parent `.datatable`'s visible width (clientWidth) via
+	// ResizeObserver. `.datatable` is the horizontal scroll container, so
+	// its `clientWidth` is the visible viewport regardless of how wide the
+	// inner `.datatable-grid` has grown via `min-width: max-content`. Do
+	// NOT measure `.flex_table` instead - flex `min-width: auto`
+	// propagates the scroll-content width and sizes the nested table to
+	// the full grid, breaking the sticky-fit behaviour.
+	//
+	// Reading layout inside a derivation would force a synchronous reflow
+	// on every reactive re-run; the ResizeObserver path keeps it out of
+	// the reactive graph.
+	let maxWidth: number | undefined = $state();
+	$effect(() => {
+		if (!root) {
+			return;
+		}
+		const scrollHost = root.closest('.datatable');
+		if (!(scrollHost instanceof HTMLElement)) {
+			return;
+		}
+		maxWidth = scrollHost.clientWidth;
+		const ro = new ResizeObserver(() => {
+			maxWidth = scrollHost.clientWidth;
+		});
+		ro.observe(scrollHost);
+		return () => {
+			ro.disconnect();
+		};
+	});
+
+	// These class instances have `$state`-backed internal fields, so they
+	// must NOT be wrapped in `$state(...)` (that would add a redundant
+	// reactive layer). The `dataRepo` and `tableContext` references must
+	// stay stable across updates: a fresh `dataRepo` would clear
+	// filter/sort state, and a fresh `tableContext` would tear down focus.
+	//
+	// svelte-ignore state_referenced_locally
+	const dataRepo = new LocalTableDataRepository<T>(tableName, wrapper, () => getUserId());
+
+	// svelte-ignore state_referenced_locally
+	const tableContext = TableContext.init<T, IdType>(columnDefWrapper, tableName, dataRepo, {
+		...DEFAULT_NESTED_TABLE_OPTIONS,
+		...options,
+		getUserId: () => getUserId(),
+	});
+</script>
+
+<!-- svelte-ignore a11y_no_static_element_interactions -->
+<div
+	class="limit-height"
+	bind:this={root}
+	style:width={maxWidth != null ? `${maxWidth}px` : null}
+	oncontextmenu={(e) => {
+		e.stopPropagation();
+		oncontextmenu?.(e);
+	}}
+>
+	<Table
+		nested
+		{tableContext}
+	/>
+</div>
+
 <style>.limit-height {
   position: sticky;
   left: 0;
@@ -138,4 +135,4 @@
   box-sizing: border-box;
   background-color: #f4f7f9;
   box-shadow: inset 0px 7px 5px -6px #cbd4da, inset 0px -7px 5px -6px #cbd4da;
-}</style>
+}</style>

package/dist/Components/Table/SubApis.svelte.d.ts

@@ -1,13 +1,9 @@
 /**
  * Sub-API facade constructors. Each `makeXxxApi(tableContext)` returns a
  * frozen object literal whose shape matches the corresponding interface in
- * `Types/Public/TableSubApis.ts`. Reads delegate to the underlying Phase 6
+ * `Types/Public/TableSubApis.ts`. Reads delegate to the underlying
  * sub-context (`tableContext._selection`, `_filtering`, etc.); writes
  * delegate to the matching setter or method.
- *
- * Phase 1 ships these as a thin facade over the existing internals. Phase 2
- * will collapse the duplication once the legacy delegating accessors on
- * `TableContext` are removed.
  */
 import type { TableContext } from './Types/Context/TableContext.svelte.js';
 import type { Primitive } from './Types/Context/TableInitOptions.js';

package/dist/Components/Table/SubApis.svelte.js

@@ -1,14 +1,11 @@
 /**
  * Sub-API facade constructors. Each `makeXxxApi(tableContext)` returns a
  * frozen object literal whose shape matches the corresponding interface in
- * `Types/Public/TableSubApis.ts`. Reads delegate to the underlying Phase 6
+ * `Types/Public/TableSubApis.ts`. Reads delegate to the underlying
  * sub-context (`tableContext._selection`, `_filtering`, etc.); writes
  * delegate to the matching setter or method.
- *
- * Phase 1 ships these as a thin facade over the existing internals. Phase 2
- * will collapse the duplication once the legacy delegating accessors on
- * `TableContext` are removed.
  */
+import { escapeForSpreadsheet } from './clipboardEscape.js';
 // ─────────────────────────────────────────────────────────────────────────
 // Selection
 // ─────────────────────────────────────────────────────────────────────────
@@ -23,11 +20,23 @@ export function makeSelectionApi(ctx) {
         toggle(row) {
             void ctx._selection.toggleSelected(row);
         },
-        set(rowId, row) {
-            ctx._selection.selectedItems.set(rowId, row);
+        set(_rowId, row) {
+            // Route through the sub-context's flush-aware writer so the
+            // pending-changes buffer and `_keyCache` stay consistent. The
+            // caller's `rowId` is ignored — the underlying writer recomputes
+            // the key from the row reference via the configured
+            // `selectionExtractor`, which is the source of truth.
+            void ctx._selection.setSelected(row, true);
         },
         delete(rowId) {
-            ctx._selection.selectedItems.delete(rowId);
+            // Resolve the row from the live selected map so we can route
+            // removal through `setSelected(false)` and pick up the same
+            // flush + cache-invalidation semantics. No-op when the id is
+            // not currently selected.
+            const row = ctx._selection.selectedItems.get(rowId);
+            if (row !== undefined) {
+                void ctx._selection.setSelected(row, false);
+            }
         },
         clear() {
             ctx._selection.resetSelectedItems();
@@ -160,11 +169,9 @@ export function makeColumnsApi(ctx, specsById) {
             ctx._columnLayout.columnVisibility = next;
         },
         setPinning(columnId, side) {
-            // `ColumnPinningState` is `{ left?: ReadonlyMap<string, number>;
-            // right?: ReadonlyMap<string, number>; }`. Each map keys a column
-            // id to the width at which it is pinned. The columns sub-context
-            // fills in widths from the column-sizing state when we delegate;
-            // here we provide 0 as a placeholder for newly-pinned columns.
+            // `ColumnPinningState` maps each column id to the pinned width.
+            // The columns sub-context fills in real widths from column-sizing
+            // when we delegate, so 0 is a safe placeholder here.
             const current = ctx._columnLayout.columnPinning;
             // Local, single-shot rebuild before reassigning the reactive container.
             // eslint-disable-next-line svelte/prefer-svelte-reactivity
@@ -212,8 +219,8 @@ export function makeFocusApi(ctx) {
         },
         moveTo(row, column) {
             // `CellCoordinates` carries `{ id, row, column }` so the focus
-            // target is addressable by both ordinal index and stable id. We
-            // look up the id from the column-layout's ordered defs.
+            // target is addressable by both ordinal index and stable id; the
+            // id is looked up from the column-layout's ordered defs.
             const defs = ctx._columnLayout.columnDefs;
             if (column < 0 || column >= defs.length) {
                 return;
@@ -231,16 +238,12 @@ export function makeFocusApi(ctx) {
 // ─────────────────────────────────────────────────────────────────────────
 export function makePreferencesApi(ctx) {
     // Adapt the internal `ColumnDefSet<T>` shape to the public `SavedPreset`
-    // shape. The internal `ColumnDefSet` carries `name`, `sortingState`,
-    // `visibilityState`, `columnPinningState`, and `columnDefs`. It does NOT
-    // carry a `savedAt` timestamp or a per-column `columnSizing` map; the
-    // public `SavedPreset.savedAt` is a placeholder until Phase 2 extends
-    // the internal shape, and the per-column `width` falls back to the def's
-    // `minSize`.
+    // shape. `ColumnDefSet` has no `savedAt` timestamp or per-column sizing
+    // map, so `savedAt` is an epoch-zero placeholder and per-column `width`
+    // falls back to the def's `minSize`.
     const adapt = (set) => ({
         name: set.name,
-        // Static epoch-zero placeholder until Phase 2 extends ColumnDefSet with a
-        // real timestamp; no reactivity needed for a literal placeholder.
+        // Literal placeholder, no reactivity needed.
         // eslint-disable-next-line svelte/prefer-svelte-reactivity
         savedAt: new Date(0).toISOString(),
         columns: set.columnDefs.map((c) => ({
@@ -333,11 +336,9 @@ export function makeModalApi(ctx) {
             return ctx.openModalCell;
         },
         open(row, columnId) {
-            // The underlying setter takes the row by reference. Cells
-            // compare via object identity, so passing the same instance
-            // the table holds for the row is load-bearing - callers
-            // typically have that instance in hand from `table.rows`,
-            // `table.selection.map`, or a `col.actions` callback.
+            // Cells compare row identity by reference, so callers must pass
+            // the same instance the table holds (from `table.rows`,
+            // `table.selection.map`, or a `col.actions` callback).
             ctx.setOpenModalCell({ row, columnId });
         },
         close() {
@@ -357,9 +358,6 @@ export function makeClipboardApi(ctx) {
             await ctx.copyHighlightedRowsToClipboard();
         },
         async copyCell(row, columnId) {
-            // Phase 1: minimal implementation. Phase 2 will route through the
-            // shared `escapeForSpreadsheet` helper to neutralise formula-
-            // injection prefixes consistently with the other copy paths.
             const def = ctx._columnLayout.columnDefsById.get(columnId);
             if (!def) {
                 return;
@@ -374,7 +372,10 @@ export function makeClipboardApi(ctx) {
                     : typeof value === 'number' || typeof value === 'boolean'
                         ? value.toString()
                         : JSON.stringify(value);
-            await navigator.clipboard.writeText(text);
+            // Neutralise formula-injection prefixes ('=', '+', '-', '@', tab,
+            // CR). Aligns single-cell copy with copySelection /
+            // copyHighlighted, which both pass through `escapeForSpreadsheet`.
+            await navigator.clipboard.writeText(escapeForSpreadsheet(text));
         },
     });
 }