@lavalogic/scoria 0.37.44 → 0.37.45

package/dist/Components/Table/Body/Rows/Columns/ProgressCell.svelte

@@ -1,107 +1,107 @@
-<svelte:options runes />
-
-<script
-	lang="ts"
-	module
->
-	import ProgressBubble from '../../../../ProgressBubble.svelte';
-	import type { ProgressBarTableCell } from '../../../Types/Columns/ProgressBarTableCell.js';
-	import { TableContext } from '../../../Types/Context/TableContext.svelte.js';
-	import { type Primitive } from '../../../Types/Context/TableInitOptions.js';
-	import { devCatch, isValidityTuple } from '../../../../../Helpers/Helpers.svelte.js';
-	import { Validity } from '../../../../../Types/Internal/Validity.js';
-	import { getContext } from 'svelte';
-
-	/**
-	 * Props for {@link ProgressCell}. The cell renders a single `<ProgressBubble>`
-	 * whose `[done, total]` tuple comes from `cell.getValue()`.
-	 */
-	export interface ProgressCellProps<T extends object, FilterValueType> {
-		/** Progress-bar table cell whose `[done, total]` value should be rendered. */
-		cell: ProgressBarTableCell<T, FilterValueType>;
-	}
-</script>
-
-<script
-	lang="ts"
-	generics="T extends object, FilterValueType, RowIdType extends Primitive"
->
-	const { cell }: ProgressCellProps<T, FilterValueType> = $props();
-
-	/**
-	 * Tuple of `[done, total]`. The cast is unavoidable until `ProgressBarDef`
-	 * carries a narrowed `TValue = [number, number]` generic; tracked under
-	 * the cross-cutting RowGenericThreading + ProgressBarDef.value follow-up.
-	 */
-	const value: [number, number] = $derived(cell.getValue()) as [number, number];
-
-	const tableContext = getContext<TableContext<T, RowIdType>>(TableContext.identifier);
-
-	const focusDetails = $derived(tableContext._focus.getFocusDetailsFor(cell));
-
-	let validity: Validity = $state(Validity.Valid);
-	$effect(() => {
-		const validityPromise = focusDetails.validity;
-
-		validityPromise
-			.then((v) => {
-				if (!v) {
-					validity = Validity.Neutral;
-				} else if (isValidityTuple(v)) {
-					validity = v.value;
-				} else {
-					validity = v;
-				}
-			})
-			.catch(devCatch);
-	});
-
-	const colours = $derived(
-		cell.column.columnDef.getColour(cell.row.original, cell.row.originalIndex, value)
-	);
-</script>
-
-<!-- svelte-ignore a11y_mouse_events_have_key_events -->
-<!-- svelte-ignore a11y_no_static_element_interactions -->
-<div
-	id={`${tableContext.tableName}-cell-${cell.row.visibleIndex}-${cell.column.id}`}
-	tabIndex={0}
-	class="focusable"
-	class:multifocus={focusDetails.isMultiFocused}
-	class:multifocus-start={focusDetails.isMultiFocusStart}
-	style={focusDetails.outline}
-	class:info={validity == Validity.Info}
-	class:success={validity == Validity.Valid}
-	class:warning={validity == Validity.Warning}
-	class:error={validity == Validity.Invalid}
-	onmousedown={(e) => {
-		// start focus only on left click
-		if (e.button === 0) {
-			if (e.shiftKey) {
-				e.preventDefault();
-				tableContext.setFocusEnd(focusDetails.coordinates);
-			} else {
-				tableContext.startFocus(focusDetails.coordinates);
-			}
-		}
-	}}
-	onmouseover={() => {
-		if (tableContext.isMousingDown) {
-			tableContext.setFocusEnd(focusDetails.coordinates);
-		}
-	}}
-	onmouseup={() => {
-		tableContext.endFocus(focusDetails.coordinates);
-	}}
->
-	<div class="bubble-parent">
-		<ProgressBubble
-			{value}
-			{colours}
-		/>
-	</div>
-</div>
-
+<svelte:options runes />
+
+<script
+	lang="ts"
+	module
+>
+	import ProgressBubble from '../../../../ProgressBubble.svelte';
+	import type { ProgressBarTableCell } from '../../../Types/Columns/ProgressBarTableCell.js';
+	import { TableContext } from '../../../Types/Context/TableContext.svelte.js';
+	import { type Primitive } from '../../../Types/Context/TableInitOptions.js';
+	import { devCatch, isValidityTuple } from '../../../../../Helpers/Helpers.svelte.js';
+	import { Validity } from '../../../../../Types/Internal/Validity.js';
+	import { getContext } from 'svelte';
+
+	/**
+	 * Props for {@link ProgressCell}. The cell renders a single `<ProgressBubble>`
+	 * whose `[done, total]` tuple comes from `cell.getValue()`.
+	 */
+	export interface ProgressCellProps<T extends object, FilterValueType> {
+		/** Progress-bar table cell whose `[done, total]` value should be rendered. */
+		cell: ProgressBarTableCell<T, FilterValueType>;
+	}
+</script>
+
+<script
+	lang="ts"
+	generics="T extends object, FilterValueType, RowIdType extends Primitive"
+>
+	const { cell }: ProgressCellProps<T, FilterValueType> = $props();
+
+	/**
+	 * Tuple of `[done, total]`. The cast is unavoidable until `ProgressBarDef`
+	 * carries a narrowed `TValue = [number, number]` generic; tracked under
+	 * the cross-cutting RowGenericThreading + ProgressBarDef.value follow-up.
+	 */
+	const value: [number, number] = $derived(cell.getValue()) as [number, number];
+
+	const tableContext = getContext<TableContext<T, RowIdType>>(TableContext.identifier);
+
+	const focusDetails = $derived(tableContext._focus.getFocusDetailsFor(cell));
+
+	let validity: Validity = $state(Validity.Valid);
+	$effect(() => {
+		const validityPromise = focusDetails.validity;
+
+		validityPromise
+			.then((v) => {
+				if (!v) {
+					validity = Validity.Neutral;
+				} else if (isValidityTuple(v)) {
+					validity = v.value;
+				} else {
+					validity = v;
+				}
+			})
+			.catch(devCatch);
+	});
+
+	const colours = $derived(
+		cell.column.columnDef.getColour(cell.row.original, cell.row.originalIndex, value)
+	);
+</script>
+
+<!-- svelte-ignore a11y_mouse_events_have_key_events -->
+<!-- svelte-ignore a11y_no_static_element_interactions -->
+<div
+	id={`${tableContext.tableName}-cell-${cell.row.visibleIndex}-${cell.column.id}`}
+	tabIndex={0}
+	class="focusable"
+	class:multifocus={focusDetails.isMultiFocused}
+	class:multifocus-start={focusDetails.isMultiFocusStart}
+	style={focusDetails.outline}
+	class:info={validity == Validity.Info}
+	class:success={validity == Validity.Valid}
+	class:warning={validity == Validity.Warning}
+	class:error={validity == Validity.Invalid}
+	onmousedown={(e) => {
+		// start focus only on left click
+		if (e.button === 0) {
+			if (e.shiftKey) {
+				e.preventDefault();
+				tableContext.setFocusEnd(focusDetails.coordinates);
+			} else {
+				tableContext.startFocus(focusDetails.coordinates);
+			}
+		}
+	}}
+	onmouseover={() => {
+		if (tableContext.isMousingDown) {
+			tableContext.setFocusEnd(focusDetails.coordinates);
+		}
+	}}
+	onmouseup={() => {
+		tableContext.endFocus(focusDetails.coordinates);
+	}}
+>
+	<div class="bubble-parent">
+		<ProgressBubble
+			{value}
+			{colours}
+		/>
+	</div>
+</div>
+
 <style>.focusable,
 .checkbox-cell,
 .input-cell,
@@ -188,4 +188,4 @@ div.bubble-parent {
   align-items: center;
   gap: 0.75rem;
   --line-height: 1;
-}</style>
+}</style>

package/dist/Components/Table/Body/Rows/Columns/SelectColumn.d.ts

@@ -3,14 +3,17 @@ import type { SelectDef } from '../../../Types/Columns/Definitions/Accessors/Sel
 /**
  * Narrowed `Column<T>` whose `columnDef` is a `SelectDef`.
  *
- * The variance markers (`in FilterValueType`, `out SelectValueType`) mirror
- * the underlying `SelectDef` declaration and let TypeScript co-/contra-variance
- * follow the assignability of select-typed columns. The historical defaults
- * (`FilterValueType = T`, `SelectValueType = T`) are intentionally retained
- * to avoid mass-breakage of the eight `SelectColumn<T>` consumers; the
- * type-strictness review proposed tightening these to `unknown`. Tightening
- * is deferred (see workorder Cell Glue Types finding 2).
+ * The historical default `FilterValueType = T` is retained to avoid
+ * mass-breakage of the eight `SelectColumn<T>` consumers; the
+ * type-strictness review proposed tightening it to `unknown` as a
+ * follow-up.
+ *
+ * No variance marker is declared on `FilterValueType` because
+ * `SelectDef` uses it in both contravariant (`filterFn`) and covariant
+ * (`getOptions`) positions, making it invariant. The third generic
+ * that used to track the select option value type was collapsed into
+ * `FilterValueType` per the F4 generic-leak audit.
  */
-export interface SelectColumn<T extends object, in FilterValueType = T, out SelectValueType = T> extends Column<T, FilterValueType> {
-    columnDef: SelectDef<T, FilterValueType, SelectValueType>;
+export interface SelectColumn<T extends object, FilterValueType = T> extends Column<T, FilterValueType> {
+    columnDef: SelectDef<T, FilterValueType>;
 }

package/dist/Components/Table/Body/Rows/Columns/SelectTableCell.d.ts

@@ -5,11 +5,11 @@ import type { SelectColumn } from './SelectColumn.js';
  * and `MultiSelect` cell hosts consume this so that `cell.column.columnDef`
  * resolves directly to a `SelectDef` without runtime casts.
  *
- * The third generic on `SelectColumn` (`SelectValueType`) is not threaded
- * through here for consistency with the rest of the cell-glue group; the
- * underlying `SelectColumn<T, FilterValueType>` defaults `SelectValueType` to
- * `T` so the cell still compiles. Threading that third generic through is
- * deferred (see workorder Cell Glue Types finding 4).
+ * `SelectDef`'s former third generic (the option value type) was collapsed
+ * into `FilterValueType` per the F4 generic-leak audit, so this cell shape
+ * now threads a single generic that doubles as both the filter-fn value
+ * type and the option value type. The historical `FilterValueType = T`
+ * default on `SelectColumn` keeps existing call sites compiling.
  */
 export interface SelectTableCell<T extends object, FilterValueType> extends TableCell<T, FilterValueType> {
     column: SelectColumn<T, FilterValueType>;

package/dist/Components/Table/Body/Rows/Columns/TableAction.svelte

@@ -1,87 +1,87 @@
-<svelte:options runes />
-
-<script
-	lang="ts"
-	module
->
-	import Button from '../../../../Button.svelte';
-	import type { TableActionButton } from '../../../Types/Columns/TableActionButton.js';
-	import { getErrorMessage } from '../../../../../Helpers/Helpers.svelte.js';
-	import { ColourSet } from '../../../../../scss/colours.js';
-	import { Size } from '../../../../../Types/Internal/Size.js';
-	import type { ActionsTableCell } from './ActionsTableCell.js';
-
-	/**
-	 * Props for {@link TableAction}. Renders a single row-action `<Button>`
-	 * inside the actions popover; resolves the per-row label and enabled flag
-	 * from the `action` callbacks (each may be sync or async).
-	 *
-	 * Kept inline because extracting it would change the public import path
-	 * for the `TableActionProps` type (breaking); the sibling-Props file
-	 * extraction is deferred to the cross-cutting Props-extraction sweep.
-	 */
-	export interface TableActionProps<T extends object, FilterValueType> {
-		/** The action button to render (one button per `cell.column.columnDef.actions[*]`). */
-		action: TableActionButton<T>;
-		/** The host actions-cell instance, used to resolve per-row state. */
-		cell: ActionsTableCell<T, FilterValueType>;
-	}
-</script>
-
-<script
-	lang="ts"
-	generics="T extends object, FilterValueType"
->
-	import { dev } from '$app/environment';
-
-	const { action, cell }: TableActionProps<T, FilterValueType> = $props();
-
-	/**
-	 * Resolved [label, isEnabled] tuple. Both sources are awaited in parallel
-	 * via Promise.all so an async `getLabel` does not serialise behind an
-	 * async `isDisabled`.
-	 */
-	const buttonStatePromise: Promise<[string, boolean]> = $derived.by(() => {
-		const disabledResult = action.isDisabled?.(cell.row.original, cell.row.originalIndex);
-
-		const isEnabledPromise: Promise<boolean> =
-			disabledResult == null
-				? Promise.resolve(
-						cell.column.columnDef.isEnabled?.(cell.row.original, cell.row.originalIndex, action) ??
-							true
-					)
-				: typeof disabledResult === 'boolean'
-					? Promise.resolve(!disabledResult)
-					: disabledResult.then((it) => !it);
-
-		const labelPromise: Promise<string> = Promise.resolve(
-			action.getLabel(cell.row.original, cell.row.originalIndex)
-		);
-
-		return Promise.all([labelPromise, isEnabledPromise]);
-	});
-</script>
-
-{#await buttonStatePromise}
-	<!-- intentionally empty: the actions popover frame already conveys the loading state -->
-{:then [label, isEnabled]}
-	<Button
-		fullWidth
-		size={Size.Medium}
-		colourSet={cell.column.columnDef.getColourSet?.(
-			cell.row.original,
-			cell.row.originalIndex,
-			action
-		) ?? ColourSet.Secondary}
-		disabled={!isEnabled}
-		onclick={() => {
-			action.callback(cell.row.original, cell.row.originalIndex);
-		}}>{label}</Button
-	>
-{:catch e}
-	{#if dev}
-		Error Loading Button: {getErrorMessage(e)}
-	{:else}
-		Error Loading Button
-	{/if}
-{/await}
+<svelte:options runes />
+
+<script
+	lang="ts"
+	module
+>
+	import Button from '../../../../Button.svelte';
+	import type { TableActionButton } from '../../../Types/Columns/TableActionButton.js';
+	import { getErrorMessage } from '../../../../../Helpers/Helpers.svelte.js';
+	import { ColourSet } from '../../../../../scss/colours.js';
+	import { Size } from '../../../../../Types/Internal/Size.js';
+	import type { ActionsTableCell } from './ActionsTableCell.js';
+
+	/**
+	 * Props for {@link TableAction}. Renders a single row-action `<Button>`
+	 * inside the actions popover; resolves the per-row label and enabled flag
+	 * from the `action` callbacks (each may be sync or async).
+	 *
+	 * Kept inline because extracting it would change the public import path
+	 * for the `TableActionProps` type (breaking); the sibling-Props file
+	 * extraction is deferred to the cross-cutting Props-extraction sweep.
+	 */
+	export interface TableActionProps<T extends object, FilterValueType> {
+		/** The action button to render (one button per `cell.column.columnDef.actions[*]`). */
+		action: TableActionButton<T>;
+		/** The host actions-cell instance, used to resolve per-row state. */
+		cell: ActionsTableCell<T, FilterValueType>;
+	}
+</script>
+
+<script
+	lang="ts"
+	generics="T extends object, FilterValueType"
+>
+	import { dev } from '$app/environment';
+
+	const { action, cell }: TableActionProps<T, FilterValueType> = $props();
+
+	/**
+	 * Resolved [label, isEnabled] tuple. Both sources are awaited in parallel
+	 * via Promise.all so an async `getLabel` does not serialise behind an
+	 * async `isDisabled`.
+	 */
+	const buttonStatePromise: Promise<[string, boolean]> = $derived.by(() => {
+		const disabledResult = action.isDisabled?.(cell.row.original, cell.row.originalIndex);
+
+		const isEnabledPromise: Promise<boolean> =
+			disabledResult == null
+				? Promise.resolve(
+						cell.column.columnDef.isEnabled?.(cell.row.original, cell.row.originalIndex, action) ??
+							true
+					)
+				: typeof disabledResult === 'boolean'
+					? Promise.resolve(!disabledResult)
+					: disabledResult.then((it) => !it);
+
+		const labelPromise: Promise<string> = Promise.resolve(
+			action.getLabel(cell.row.original, cell.row.originalIndex)
+		);
+
+		return Promise.all([labelPromise, isEnabledPromise]);
+	});
+</script>
+
+{#await buttonStatePromise}
+	<!-- intentionally empty: the actions popover frame already conveys the loading state -->
+{:then [label, isEnabled]}
+	<Button
+		fullWidth
+		size={Size.Medium}
+		colourSet={cell.column.columnDef.getColourSet?.(
+			cell.row.original,
+			cell.row.originalIndex,
+			action
+		) ?? ColourSet.Secondary}
+		disabled={!isEnabled}
+		onclick={() => {
+			action.callback(cell.row.original, cell.row.originalIndex);
+		}}>{label}</Button
+	>
+{:catch e}
+	{#if dev}
+		Error Loading Button: {getErrorMessage(e)}
+	{:else}
+		Error Loading Button
+	{/if}
+{/await}