@lamentis/naome 1.3.13 → 1.3.15

package/crates/naome-core/src/workflow/phases.rs

@@ -8,13 +8,7 @@ use serde_json::Value;
 use crate::models::NaomeError;
 
 use super::phase_inference::infer_phases;
-
-#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct CommandCheckResult {
-    pub check_id: String,
-    pub exit_code: i32,
-}
+use super::phase_model::{CheckDefinition, CommandCheckResult, PhaseDefinition};
 
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
@@ -35,20 +29,6 @@ pub struct VerificationPhaseStatus {
     pub blocked_by: Vec<String>,
 }
 
-#[derive(Debug, Clone)]
-pub(super) struct CheckDefinition {
-    pub(super) id: String,
-    pub(super) command: String,
-    pub(super) cost: String,
-}
-
-#[derive(Debug, Clone)]
-pub(super) struct PhaseDefinition {
-    pub(super) id: String,
-    pub(super) order: u32,
-    pub(super) check_ids: Vec<String>,
-}
-
 pub fn verification_phase_plan(
     root: &Path,
     completed: &[CommandCheckResult],

package/crates/naome-core/tests/architecture_cache.rs

@@ -0,0 +1,212 @@
+use naome_core::{validate_architecture, ArchitectureScanOptions};
+use std::path::Path;
+use std::process::Command;
+
+mod architecture_support;
+
+use architecture_support::FixtureRepo;
+
+#[test]
+fn changed_only_uses_incremental_cache_after_initial_safe_full_scan() {
+    let repo = FixtureRepo::new();
+    repo.write(
+        "naome.arch.yaml",
+        forbidden_domain_to_infrastructure_config(),
+    );
+    repo.write("src/domain/event.ts", "export const event = 1;\n");
+    repo.write("src/infrastructure/db.ts", "export const db = 1;\n");
+    repo.init_git();
+
+    let initial = validate_architecture(repo.path(), changed_only()).unwrap();
+
+    assert!(initial.changed_only_requested);
+    assert!(initial.changed_only_degraded_to_full_scan);
+    assert_eq!(initial.changed_only_mode, "degraded_full_scan");
+    assert_eq!(
+        initial.changed_only_degradation_reason.as_deref(),
+        Some("cache_miss")
+    );
+
+    repo.write(
+        "src/domain/event.ts",
+        "import { db } from '../infrastructure/db';\nexport const event = db;\n",
+    );
+
+    let incremental = validate_architecture(repo.path(), changed_only()).unwrap();
+
+    assert!(incremental.changed_only_requested);
+    assert!(!incremental.changed_only_degraded_to_full_scan);
+    assert_eq!(incremental.changed_only_mode, "incremental_cache");
+    assert_eq!(incremental.changed_only_degradation_reason, None);
+    assert_eq!(incremental.files_scanned, 1);
+    assert_eq!(incremental.summary.errors, 1);
+    assert_eq!(
+        incremental.violations[0].path.as_deref(),
+        Some("src/domain/event.ts")
+    );
+}
+
+#[test]
+fn changed_only_degrades_when_architecture_config_changes() {
+    let repo = FixtureRepo::new();
+    repo.write(
+        "naome.arch.yaml",
+        forbidden_domain_to_infrastructure_config(),
+    );
+    repo.write("src/domain/event.ts", "export const event = 1;\n");
+    repo.write("src/infrastructure/db.ts", "export const db = 1;\n");
+    repo.init_git();
+    validate_architecture(repo.path(), changed_only()).unwrap();
+
+    repo.write(
+        "naome.arch.yaml",
+        "layers:\n  application:\n    paths:\n      - \"src/**\"\n",
+    );
+
+    let report = validate_architecture(repo.path(), changed_only()).unwrap();
+
+    assert!(report.changed_only_degraded_to_full_scan);
+    assert_eq!(report.changed_only_mode, "degraded_full_scan");
+    assert_eq!(
+        report.changed_only_degradation_reason.as_deref(),
+        Some("config_changed")
+    );
+}
+
+#[test]
+fn changed_only_degrades_when_repository_file_set_changes() {
+    let repo = FixtureRepo::new();
+    repo.write(
+        "naome.arch.yaml",
+        forbidden_domain_to_infrastructure_config(),
+    );
+    repo.write("src/domain/event.ts", "export const event = 1;\n");
+    repo.write("src/infrastructure/db.ts", "export const db = 1;\n");
+    repo.init_git();
+    validate_architecture(repo.path(), changed_only()).unwrap();
+
+    repo.write("src/domain/new.ts", "export const fresh = 1;\n");
+
+    let report = validate_architecture(repo.path(), changed_only()).unwrap();
+
+    assert!(report.changed_only_degraded_to_full_scan);
+    assert_eq!(report.changed_only_mode, "degraded_full_scan");
+    assert_eq!(
+        report.changed_only_degradation_reason.as_deref(),
+        Some("file_set_changed")
+    );
+}
+
+#[test]
+fn changed_only_degrades_when_cached_clean_file_content_changed() {
+    let repo = FixtureRepo::new();
+    repo.write(
+        "naome.arch.yaml",
+        forbidden_domain_to_infrastructure_config(),
+    );
+    repo.write("src/domain/event.ts", "export const event = 1;\n");
+    repo.write("src/infrastructure/db.ts", "export const db = 1;\n");
+    repo.init_git();
+    validate_architecture(repo.path(), changed_only()).unwrap();
+
+    repo.write(
+        "src/domain/event.ts",
+        "import { db } from '../infrastructure/db';\nexport const event = db;\n",
+    );
+    commit_all(repo.path(), "content change after cache");
+
+    let report = validate_architecture(repo.path(), changed_only()).unwrap();
+
+    assert!(report.changed_only_requested);
+    assert!(report.changed_only_degraded_to_full_scan);
+    assert_eq!(report.changed_only_mode, "degraded_full_scan");
+    assert_eq!(
+        report.changed_only_degradation_reason.as_deref(),
+        Some("content_changed")
+    );
+    assert_eq!(report.summary.errors, 1);
+}
+
+#[test]
+fn changed_only_degrades_when_go_module_context_changes() {
+    let repo = FixtureRepo::new();
+    repo.write(
+        "naome.arch.yaml",
+        forbidden_domain_to_infrastructure_config(),
+    );
+    repo.write("go.mod", "module example.com/old\n\ngo 1.22\n");
+    repo.write(
+        "src/domain/event.go",
+        "package domain\n\nimport \"example.com/new/src/infrastructure/db\"\n\nvar Event = db.Value\n",
+    );
+    repo.write(
+        "src/infrastructure/db/db.go",
+        "package db\n\nvar Value = 1\n",
+    );
+    repo.init_git();
+    let initial = validate_architecture(repo.path(), changed_only()).unwrap();
+    assert_eq!(initial.summary.errors, 0);
+
+    repo.write("go.mod", "module example.com/new\n\ngo 1.22\n");
+
+    let report = validate_architecture(repo.path(), changed_only()).unwrap();
+
+    assert!(report.changed_only_requested);
+    assert!(report.changed_only_degraded_to_full_scan);
+    assert_eq!(report.changed_only_mode, "degraded_full_scan");
+    assert_eq!(
+        report.changed_only_degradation_reason.as_deref(),
+        Some("resolver_context_changed")
+    );
+    assert_eq!(report.summary.errors, 1);
+    assert_eq!(
+        report.violations[0].path.as_deref(),
+        Some("src/domain/event.go")
+    );
+}
+
+fn changed_only() -> ArchitectureScanOptions {
+    ArchitectureScanOptions {
+        changed_only: true,
+        ..ArchitectureScanOptions::default()
+    }
+}
+
+fn forbidden_domain_to_infrastructure_config() -> &'static str {
+    r#"layers:
+  domain:
+    paths:
+      - "src/domain/**"
+  infrastructure:
+    paths:
+      - "src/infrastructure/**"
+allowed_dependencies:
+  domain:
+  infrastructure:
+    - domain
+rules:
+  no_forbidden_layer_dependencies:
+    enabled: true
+    severity: error
+"#
+}
+
+fn commit_all(root: &Path, message: &str) {
+    run_git(root, &["add", "."]);
+    run_git(root, &["commit", "-m", message]);
+}
+
+fn run_git(root: &Path, args: &[&str]) {
+    let output = Command::new("git")
+        .args(args)
+        .current_dir(root)
+        .output()
+        .unwrap();
+    assert!(
+        output.status.success(),
+        "git {:?} failed: {}{}",
+        args,
+        String::from_utf8_lossy(&output.stdout),
+        String::from_utf8_lossy(&output.stderr)
+    );
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lamentis/naome",
-  "version": "1.3.13",
+  "version": "1.3.15",
   "description": "Native-first CLI for the NAOME agent harness.",
   "license": "Apache-2.0",
   "type": "module",

package/templates/naome-root/.naome/manifest.json

@@ -9,7 +9,7 @@
     ".naome/task-contract.schema.json": "sha256:1b3b62350328d0d6d660e36d1d1baaa2b88718530db774f9ab2a9e2fcba369c8",
     "AGENTS.md": "sha256:e8b2fc786c1c72b69ba8f2b2ffce4f459e799c7453ce9ff4a9f6448a8f9e6b4f",
     "docs/naome/agent-workflow.md": "sha256:0be1c29adfbcd3fd73c4f904080ffc67237692fe413871a30243538c4db38ac7",
-    "docs/naome/architecture-fitness.md": "sha256:26f04884c3ada083380bee5c3cb1aa3f39d8c8a1cc31ccc84c4ae795c594de5b",
+    "docs/naome/architecture-fitness.md": "sha256:88aa979f61f82c2802c416af2c374ba041c94157189d59048d6889b07034d394",
     "docs/naome/context-economy.md": "sha256:3ed5075815ecf4ada46a5e65438769310307c35759fcd46b13dc0b96e02bebd9",
     "docs/naome/execution.md": "sha256:bfc5d55838942ec8e3d790b59e3c634ff5bf6a2298265cef3dca9788a097eafb",
     "docs/naome/first-run.md": "sha256:1466ce8c65e19a1514885f917db14e8a772350e3f6d1c03a66326963365919e1",

package/templates/naome-root/docs/naome/architecture-fitness.md

@@ -14,8 +14,9 @@ facts instead of prompt text.
 - `naome arch validate` runs architecture rules with human output.
 - `naome arch validate --json` emits stable machine-readable output.
 - `naome arch validate --agent-feedback` emits compact repair instructions.
-- `naome arch validate --changed-only` uses changed paths when available and
-  safely degrades to a full scan for graph-level soundness.
+- `naome arch validate --changed-only` uses changed paths with the persistent
+  architecture cache when available and safely degrades to a full scan when the
+  cache cannot prove graph-level soundness.
 
 ## Graph Model
 
@@ -127,17 +128,37 @@ ignore:
 Agents should run `naome arch validate --changed-only --json` after changing
 source or template files. JSON output includes status, severity counts,
 violations, concrete suggestions, and `agentFeedback` entries optimized for
-repair loops.
+repair loops. It also reports `changedOnlyMode` and
+`changedOnlyDegradationReason`, so agents can distinguish an incremental cache
+run from a deliberate full-scan fallback.
+
+## Incremental Cache
+
+NAOME stores architecture file facts in `.naome/cache/architecture/cache.json`.
+Cache entries are keyed by file path and content hash, and the cache is tied to
+the effective architecture config hash plus the repository file-list hash.
+
+Changed-only validation is sound by construction:
+
+- the first run without a compatible cache performs a full scan and records
+  `changedOnlyMode: "degraded_full_scan"` with reason `cache_miss`;
+- config changes perform a full scan with reason `config_changed`;
+- added or deleted repository files perform a full scan with reason
+  `file_set_changed`;
+- when config and file set are unchanged, NAOME reuses cached facts for
+  untouched files, rescans changed files, rebuilds the full graph, and runs all
+  graph-level rules against that graph.
 
 ## CI Integration
 
 Use `node .naome/bin/naome.js arch validate --changed-only` as a fast gate.
-The first foundation release reports warnings for existing file-size debt and
-fails only on configured error rules.
+The command is deterministic in both cache-backed and fallback modes; CI can
+inspect the JSON fields above when it needs to distinguish performance from
+soundness fallbacks.
 
 ## Language Support
 
-The v1.3.13 foundation classifies TypeScript, JavaScript, Rust, Python, Go,
+The v1.3.14 foundation classifies TypeScript, JavaScript, Rust, Python, Go,
 Java, Kotlin, and Swift files by path extension. It extracts import facts for
 TypeScript, JavaScript, Rust, Python, Go, and Swift, resolves relative imports
 and simple repository-absolute aliases where the language supports them, and
@@ -158,5 +179,5 @@ policies.
 
 This release intentionally keeps validation file-graph based. Manifest
 extractors are dependency-owner oriented and do not yet parse every build-tool
-feature. SARIF output, persistent scan caching, and deeper symbol-level call
-analysis remain planned follow-up slices before v1.4.0.
+feature. SARIF output and deeper symbol-level call analysis remain planned
+follow-up slices before v1.4.0.

package/crates/naome-core/src/task_state/reconcile.rs

@@ -1,7 +0,0 @@
-pub(super) use super::completed_refresh::add_completed_task_diff_notice;
-pub(super) use super::push_gate::{format_dirty_diff_admission_blocker, validate_push_gate};
-pub(super) use super::repair::{
-    is_deterministic_harness_refresh_diff, is_harness_repair_diff,
-    is_install_or_upgrade_baseline_diff, is_packaged_machine_owned_path, is_repair_archive_path,
-    is_safe_harness_refresh_path,
-};