@lamentis/naome 1.3.13 → 1.3.15

package/crates/naome-core/src/architecture/scan.rs

@@ -1,14 +1,19 @@
 use std::collections::BTreeMap;
 use std::path::{Path, PathBuf};
 
-use serde::Serialize;
+use serde::{Deserialize, Serialize};
 
 use crate::git;
 use crate::models::NaomeError;
 
-use super::config::{read_architecture_config, ArchitectureConfig};
+use cache::CacheStatus;
+
+use super::config::{
+    default_architecture_config_text, read_architecture_config, ArchitectureConfig,
+};
 use super::model::ArchitectureGraph;
 
+mod cache;
 mod graph_builder;
 mod imports;
 mod manifest;
@@ -28,6 +33,8 @@ pub struct ArchitectureScanReport {
     pub files_scanned: usize,
     pub changed_only_requested: bool,
     pub changed_only_degraded_to_full_scan: bool,
+    pub changed_only_mode: String,
+    pub changed_only_degradation_reason: Option<String>,
     pub changed_paths: Vec<String>,
     #[serde(skip_serializing)]
     pub config: ArchitectureConfig,
@@ -37,7 +44,7 @@ pub struct ArchitectureScanReport {
     pub manifest_facts: Vec<ManifestFact>,
 }
 
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct FileFact {
     pub path: String,
@@ -49,7 +56,7 @@ pub struct FileFact {
     pub imports: Vec<ImportFact>,
 }
 
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ImportFact {
     pub specifier: String,
@@ -59,7 +66,7 @@ pub struct ImportFact {
     pub extractor: String,
 }
 
-#[derive(Debug, Clone, Serialize, PartialEq, Eq)]
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]
 pub enum ImportTarget {
     File(String),
@@ -67,7 +74,7 @@ pub enum ImportTarget {
     Unknown(String),
 }
 
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ManifestFact {
     pub path: String,
@@ -78,7 +85,7 @@ pub struct ManifestFact {
     pub extractor: String,
 }
 
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ManifestDependency {
     pub name: String,
@@ -94,24 +101,235 @@ pub fn scan_architecture(
     let config = read_architecture_config(root, options.config_path.as_deref())?;
     let changed_paths = changed_paths(root, options.changed_only)?;
     let files = path_scan::repository_files(root, &config)?;
+    let config_hash = cache::config_hash(
+        root,
+        options.config_path.as_deref(),
+        default_architecture_config_text(),
+    )?;
+    let file_list_hash = cache::file_list_hash(&files);
     let manifest_facts = manifest::extract_manifests(root, &files);
-    let (mut graph, file_facts) =
-        graph_builder::build_path_graph(root, files, &config, &manifest_facts);
 
+    let scan = if options.changed_only {
+        changed_only_scan(
+            root,
+            files,
+            &config,
+            &manifest_facts,
+            &changed_paths,
+            config_hash,
+            file_list_hash,
+        )?
+    } else {
+        full_scan(
+            root,
+            files,
+            &config,
+            &manifest_facts,
+            config_hash,
+            file_list_hash,
+            false,
+            None,
+            "full_scan",
+        )?
+    };
+
+    Ok(scan.with_changed_paths(changed_paths))
+}
+
+fn changed_only_scan(
+    root: &Path,
+    files: Vec<String>,
+    config: &ArchitectureConfig,
+    manifest_facts: &[ManifestFact],
+    changed_paths: &[String],
+    config_hash: String,
+    file_list_hash: String,
+) -> Result<ArchitectureScanReport, NaomeError> {
+    let Some(cache) = cache::read(root) else {
+        return degraded_full_scan(
+            root,
+            files,
+            config,
+            manifest_facts,
+            config_hash,
+            file_list_hash,
+            "cache_miss",
+        );
+    };
+    match cache.is_compatible(&config_hash, &file_list_hash) {
+        CacheStatus::Miss(reason) => degraded_full_scan(
+            root,
+            files,
+            config,
+            manifest_facts,
+            config_hash,
+            file_list_hash,
+            reason,
+        ),
+        CacheStatus::Hit => incremental_scan(
+            root,
+            files,
+            config,
+            manifest_facts,
+            changed_paths,
+            config_hash,
+            file_list_hash,
+            cache,
+        ),
+    }
+}
+
+fn incremental_scan(
+    root: &Path,
+    files: Vec<String>,
+    config: &ArchitectureConfig,
+    manifest_facts: &[ManifestFact],
+    changed_paths: &[String],
+    config_hash: String,
+    file_list_hash: String,
+    cache: cache::ArchitectureCache,
+) -> Result<ArchitectureScanReport, NaomeError> {
+    let file_set = files.iter().cloned().collect();
+    let changed = cache::changed_set(changed_paths);
+    if import_resolver_context_changed(changed_paths) {
+        return degraded_full_scan(
+            root,
+            files,
+            config,
+            manifest_facts,
+            config_hash,
+            file_list_hash,
+            "resolver_context_changed",
+        );
+    }
+    if cached_clean_content_changed(root, &files, &changed, &cache) {
+        return degraded_full_scan(
+            root,
+            files,
+            config,
+            manifest_facts,
+            config_hash,
+            file_list_hash,
+            "content_changed",
+        );
+    }
+    let mut file_facts = BTreeMap::new();
+    let mut scanned = 0;
+
+    for path in &files {
+        if changed.contains(path) || !cache.files.contains_key(path) {
+            let fact = graph_builder::scan_file_fact(root, path, config, &file_set);
+            scanned += 1;
+            file_facts.insert(path.clone(), fact);
+        } else if let Some(cached) = cache.files.get(path) {
+            file_facts.insert(path.clone(), cached.fact.clone());
+        }
+    }
+
+    let mut graph =
+        graph_builder::build_graph_from_facts(&files, &file_facts, config, manifest_facts);
     graph.sort_stable();
+    let _ = cache::write(root, config_hash, file_list_hash, &file_facts);
     Ok(ArchitectureScanReport {
         schema: "naome.arch.scan.v1".to_string(),
-        files_scanned: file_facts.len(),
+        files_scanned: scanned,
         graph,
-        changed_only_requested: options.changed_only,
-        changed_only_degraded_to_full_scan: options.changed_only,
-        changed_paths,
-        config,
+        changed_only_requested: true,
+        changed_only_degraded_to_full_scan: false,
+        changed_only_mode: "incremental_cache".to_string(),
+        changed_only_degradation_reason: None,
+        changed_paths: Vec::new(),
+        config: config.clone(),
         file_facts,
+        manifest_facts: manifest_facts.to_vec(),
+    })
+}
+
+fn cached_clean_content_changed(
+    root: &Path,
+    files: &[String],
+    changed: &std::collections::BTreeSet<String>,
+    cache: &cache::ArchitectureCache,
+) -> bool {
+    files.iter().any(|path| {
+        !changed.contains(path)
+            && cache.files.get(path).is_some_and(|cached| {
+                cache::content_hash(root, path)
+                    .map(|current| current != cached.content_hash)
+                    .unwrap_or(true)
+            })
+    })
+}
+
+fn import_resolver_context_changed(changed_paths: &[String]) -> bool {
+    changed_paths.iter().any(|path| {
+        Path::new(path)
+            .file_name()
+            .and_then(|value| value.to_str())
+            .is_some_and(|name| matches!(name, "go.mod" | "tsconfig.json" | "jsconfig.json"))
+    })
+}
+
+fn degraded_full_scan(
+    root: &Path,
+    files: Vec<String>,
+    config: &ArchitectureConfig,
+    manifest_facts: &[ManifestFact],
+    config_hash: String,
+    file_list_hash: String,
+    reason: &'static str,
+) -> Result<ArchitectureScanReport, NaomeError> {
+    full_scan(
+        root,
+        files,
+        config,
         manifest_facts,
+        config_hash,
+        file_list_hash,
+        true,
+        Some(reason),
+        "degraded_full_scan",
+    )
+}
+
+fn full_scan(
+    root: &Path,
+    files: Vec<String>,
+    config: &ArchitectureConfig,
+    manifest_facts: &[ManifestFact],
+    config_hash: String,
+    file_list_hash: String,
+    changed_only_degraded_to_full_scan: bool,
+    changed_only_degradation_reason: Option<&str>,
+    changed_only_mode: &str,
+) -> Result<ArchitectureScanReport, NaomeError> {
+    let (mut graph, file_facts) =
+        graph_builder::build_path_graph(root, files, config, manifest_facts);
+    graph.sort_stable();
+    let files_scanned = file_facts.len();
+    let _ = cache::write(root, config_hash, file_list_hash, &file_facts);
+    Ok(ArchitectureScanReport {
+        schema: "naome.arch.scan.v1".to_string(),
+        files_scanned,
+        graph,
+        changed_only_requested: changed_only_degraded_to_full_scan,
+        changed_only_degraded_to_full_scan,
+        changed_only_mode: changed_only_mode.to_string(),
+        changed_only_degradation_reason: changed_only_degradation_reason.map(str::to_string),
+        changed_paths: Vec::new(),
+        config: config.clone(),
+        file_facts,
+        manifest_facts: manifest_facts.to_vec(),
     })
 }
 
+impl ArchitectureScanReport {
+    fn with_changed_paths(mut self, changed_paths: Vec<String>) -> Self {
+        self.changed_paths = changed_paths;
+        self
+    }
+}
+
 fn changed_paths(root: &Path, changed_only: bool) -> Result<Vec<String>, NaomeError> {
     if changed_only {
         git::changed_paths(root)

package/crates/naome-core/src/architecture.rs

@@ -13,12 +13,12 @@ pub use config::{
 };
 pub use model::{
     ArchitectureEdge, ArchitectureEdgeKind, ArchitectureGraph, ArchitectureMetadata,
-    ArchitectureNode, ArchitectureNodeKind, SourceRange,
+    ArchitectureNode, ArchitectureNodeKind, Severity, SourceRange,
 };
 pub use output::{
     format_architecture_explain, format_architecture_scan, format_architecture_validation,
-    ArchitectureAgentFeedback, ArchitectureValidation, ArchitectureViolation, Severity,
-    ViolationSummary, ARCHITECTURE_RULE_IDS,
+    ArchitectureAgentFeedback, ArchitectureValidation, ArchitectureViolation, ViolationSummary,
+    ARCHITECTURE_RULE_IDS,
 };
 pub use scan::{scan_architecture, ArchitectureScanOptions, ArchitectureScanReport};
 

package/crates/naome-core/src/intent/legacy.rs

@@ -4,8 +4,8 @@ use crate::models::Decision;
 
 use super::classifier::{has_candidate, winning_intent};
 use super::legacy_response::response_policy;
+use super::model::ResolvedIntent;
 use super::model::{CanonicalIntent, IntentKind};
-use super::resolver::ResolvedIntent;
 
 #[derive(Debug, Clone, Serialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]

package/crates/naome-core/src/intent/model.rs

@@ -75,3 +75,30 @@ pub(crate) struct CanonicalIntent {
     pub has_workflow_conflict: bool,
     pub validation_errors: Vec<String>,
 }
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub(crate) enum CompletedTaskReadiness {
+    Valid,
+    ValidAfterHarnessRefresh,
+    ValidWithUnrelatedDirty,
+    Invalid,
+}
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub(crate) enum DirtyDiffReadiness {
+    Unclassified,
+    HarnessRefreshOnly,
+    HarnessRefreshWithUnrelatedDirty,
+}
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub(crate) struct ResolvedIntent {
+    pub prompt_intent: IntentKind,
+    pub certainty: String,
+    pub policy_action: String,
+    pub allowed: bool,
+    pub summary: String,
+    pub next_action: String,
+    pub reason_codes: Vec<String>,
+    pub risk_codes: Vec<String>,
+}

package/crates/naome-core/src/intent/resolver.rs

@@ -1,37 +1,12 @@
 use crate::models::Decision;
 
 use super::classifier::winning_intent;
-use super::model::{CanonicalIntent, IntentKind};
+use super::model::{
+    CanonicalIntent, CompletedTaskReadiness, DirtyDiffReadiness, IntentKind, ResolvedIntent,
+};
 use super::resolver_policy::state_policy;
 use super::resolver_shared::{ambiguous_conflict, ambiguous_empty, unsafe_policy, Policy};
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-pub(crate) enum CompletedTaskReadiness {
-    Valid,
-    ValidAfterHarnessRefresh,
-    ValidWithUnrelatedDirty,
-    Invalid,
-}
-
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-pub(crate) enum DirtyDiffReadiness {
-    Unclassified,
-    HarnessRefreshOnly,
-    HarnessRefreshWithUnrelatedDirty,
-}
-
-#[derive(Debug, Clone, PartialEq, Eq)]
-pub(crate) struct ResolvedIntent {
-    pub prompt_intent: IntentKind,
-    pub certainty: String,
-    pub policy_action: String,
-    pub allowed: bool,
-    pub summary: String,
-    pub next_action: String,
-    pub reason_codes: Vec<String>,
-    pub risk_codes: Vec<String>,
-}
-
 pub(crate) fn resolve_intent(
     decision: &Decision,
     canonical: &CanonicalIntent,

package/crates/naome-core/src/intent/resolver_baseline.rs

@@ -1,5 +1,4 @@
-use super::model::IntentKind;
-use super::resolver::DirtyDiffReadiness;
+use super::model::{DirtyDiffReadiness, IntentKind};
 use super::resolver_catalog::{
     POLICY_BASELINE_BLOCK, POLICY_BASELINE_CANCEL, POLICY_BASELINE_COMMIT_UPGRADE,
     POLICY_BASELINE_NEW_REFRESH, POLICY_BASELINE_NEW_UPGRADE, POLICY_BASELINE_NO_COMMIT,

package/crates/naome-core/src/intent/resolver_policy.rs

@@ -1,7 +1,6 @@
 use crate::models::Decision;
 
-use super::model::IntentKind;
-use super::resolver::{CompletedTaskReadiness, DirtyDiffReadiness};
+use super::model::{CompletedTaskReadiness, DirtyDiffReadiness, IntentKind};
 use super::resolver_active::active_policy;
 use super::resolver_baseline::{baseline_policy, dirty_policy};
 use super::resolver_catalog::{

package/crates/naome-core/src/intent.rs

@@ -24,7 +24,8 @@ use crate::task_state::{
 use classifier::canonical_intent;
 pub(crate) use envelope::prompt_envelope_json;
 pub use legacy::{format_intent, IntentDecision, PromptEvidence};
-use resolver::{resolve_intent, CompletedTaskReadiness, DirtyDiffReadiness};
+use model::{CompletedTaskReadiness, DirtyDiffReadiness};
+use resolver::resolve_intent;
 
 pub fn evaluate_intent(
     root: &Path,

package/crates/naome-core/src/quality/adapter_ios.rs

@@ -1,4 +1,6 @@
-use super::adapters::{path_rule, test_file_limits};
+use super::adapter_support::{
+    quality_path_rule as path_rule, quality_test_file_limits as test_file_limits,
+};
 use super::types::{QualityLimitOverrides, QualityPathRule};
 
 pub(super) fn swift_path_rules() -> Vec<QualityPathRule> {

package/crates/naome-core/src/quality/adapter_support.rs

@@ -2,6 +2,8 @@ use std::collections::HashSet;
 
 use crate::models::NaomeError;
 
+use super::types::{QualityLimitOverrides, QualityPathRule};
+
 pub(crate) struct RepoSignals<'a> {
     paths: &'a [String],
 }
@@ -98,6 +100,36 @@ pub(crate) fn extend_unique(target: &mut Vec<String>, values: &[&str]) {
     }
 }
 
+pub(crate) fn quality_test_file_limits(max_top_level_symbols: usize) -> QualityLimitOverrides {
+    QualityLimitOverrides {
+        max_file_lines: Some(650),
+        max_diff_added_lines: Some(220),
+        max_function_lines: Some(140),
+        max_top_level_symbols: Some(max_top_level_symbols),
+        duplicate_block_lines: Some(14),
+        near_duplicate_similarity: Some(0.96),
+        ..QualityLimitOverrides::default()
+    }
+}
+
+pub(crate) fn quality_path_rule(
+    id: &str,
+    paths: &[&str],
+    limits: QualityLimitOverrides,
+    disabled_checks: &[&str],
+) -> QualityPathRule {
+    QualityPathRule {
+        id: id.to_string(),
+        paths: string_list(paths),
+        limits,
+        disabled_checks: string_list(disabled_checks),
+    }
+}
+
+fn string_list(values: &[&str]) -> Vec<String> {
+    values.iter().map(|value| (*value).to_string()).collect()
+}
+
 pub(crate) fn detects_rust_project(signals: &RepoSignals<'_>) -> bool {
     signals.has_manifest("Cargo.toml") || signals.has_extension(&[".rs"])
 }

package/crates/naome-core/src/quality/adapters.rs

@@ -5,10 +5,10 @@ use super::adapter_support::{
     detected_ids, detects_generated_ios_project, detects_ios_app_structure_project,
     detects_ios_resources_project, detects_javascript_typescript_project, detects_rust_project,
     detects_swift_package_project, detects_swift_project, detects_swiftui_project,
-    detects_xcode_project, detects_xctest_project, extend_unique, find_adapter_by_id, validate_ids,
-    AdapterDescriptor, RepoSignals,
+    detects_xcode_project, detects_xctest_project, extend_unique, find_adapter_by_id,
+    quality_path_rule, quality_test_file_limits, validate_ids, AdapterDescriptor, RepoSignals,
 };
-use super::types::{QualityLimitOverrides, QualityPathRule, RepositoryQualityConfig};
+use super::types::{QualityPathRule, RepositoryQualityConfig};
 
 const CONFIG_PATH: &str = ".naome/repository-quality.json";
 
@@ -163,32 +163,15 @@ fn javascript_typescript_test_paths() -> Vec<String> {
     paths
 }
 
-pub(super) fn test_file_limits(max_top_level_symbols: usize) -> QualityLimitOverrides {
-    QualityLimitOverrides {
-        max_file_lines: Some(650),
-        max_diff_added_lines: Some(220),
-        max_function_lines: Some(140),
-        max_top_level_symbols: Some(max_top_level_symbols),
-        duplicate_block_lines: Some(14),
-        near_duplicate_similarity: Some(0.96),
-        ..QualityLimitOverrides::default()
-    }
+fn test_file_limits(max_top_level_symbols: usize) -> super::types::QualityLimitOverrides {
+    quality_test_file_limits(max_top_level_symbols)
 }
 
-pub(super) fn path_rule(
+fn path_rule(
     id: &str,
     paths: &[&str],
-    limits: QualityLimitOverrides,
+    limits: super::types::QualityLimitOverrides,
     disabled_checks: &[&str],
 ) -> QualityPathRule {
-    QualityPathRule {
-        id: id.to_string(),
-        paths: string_list(paths),
-        limits,
-        disabled_checks: string_list(disabled_checks),
-    }
-}
-
-fn string_list(values: &[&str]) -> Vec<String> {
-    values.iter().map(|value| (*value).to_string()).collect()
+    quality_path_rule(id, paths, limits, disabled_checks)
 }

package/crates/naome-core/src/quality/analysis_model.rs

@@ -0,0 +1,33 @@
+use std::collections::HashSet;
+
+#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
+pub struct FileAnalysis {
+    pub path: String,
+    pub line_count: usize,
+    pub added_lines: usize,
+    pub raw_lines: Vec<String>,
+    pub normalized_lines: Vec<NormalizedLine>,
+    pub symbols: Vec<SymbolAnalysis>,
+}
+
+#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
+pub struct NormalizedLine {
+    pub line_number: usize,
+    pub value: String,
+}
+
+#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
+pub struct SymbolAnalysis {
+    pub kind: String,
+    pub name: String,
+    pub start_line: usize,
+    pub end_line: usize,
+    pub indent: usize,
+    pub tokens: HashSet<String>,
+}
+
+impl SymbolAnalysis {
+    pub fn line_count(&self) -> usize {
+        self.end_line.saturating_sub(self.start_line) + 1
+    }
+}

package/crates/naome-core/src/quality/cache.rs

@@ -7,7 +7,7 @@ use sha2::{Digest, Sha256};
 
 use crate::models::NaomeError;
 
-use super::scanner::FileAnalysis;
+use super::analysis_model::FileAnalysis;
 use super::types::RepositoryQualityConfig;
 
 const CACHE_RELATIVE_PATH: &str = ".naome/cache/quality";

package/crates/naome-core/src/quality/checks/duplicate_blocks.rs

@@ -2,7 +2,8 @@ use std::collections::{HashMap, HashSet};
 
 use sha2::{Digest, Sha256};
 
-use super::super::scanner::{stable_fingerprint, NormalizedLine, QualityContext};
+use super::super::analysis_model::NormalizedLine;
+use super::super::scanner::{stable_fingerprint, QualityContext};
 use super::super::types::QualityViolation;
 use super::{is_code_like_path, QualityCheck};
 

package/crates/naome-core/src/quality/checks/near_duplicates.rs

@@ -1,6 +1,7 @@
 use std::collections::HashSet;
 
-use super::super::scanner::{FileAnalysis, QualityContext, SymbolAnalysis};
+use super::super::analysis_model::{FileAnalysis, SymbolAnalysis};
+use super::super::scanner::QualityContext;
 use super::super::types::QualityViolation;
 use super::{is_code_like_path, violation, QualityCheck};
 

package/crates/naome-core/src/quality/mod.rs

@@ -1,6 +1,7 @@
 mod adapter_ios;
 mod adapter_support;
 mod adapters;
+mod analysis_model;
 mod baseline;
 mod cache;
 mod checks;

package/crates/naome-core/src/quality/scanner/analysis.rs

@@ -4,7 +4,7 @@ use std::collections::{HashMap, HashSet};
 use std::fs;
 use std::path::Path;
 
-use super::{FileAnalysis, NormalizedLine, SymbolAnalysis};
+use crate::quality::analysis_model::{FileAnalysis, NormalizedLine, SymbolAnalysis};
 use crate::quality::cache::{content_hash, QualityCache};
 use normalize::{normalize_line, token_set};
 

package/crates/naome-core/src/quality/scanner.rs

@@ -11,6 +11,7 @@ use crate::{git, models::NaomeError, paths};
 pub(crate) use repo_paths::collect_repo_paths;
 use repo_paths::{added_lines_by_path, regular_repo_file_path, tracked_blob_hashes};
 
+use super::analysis_model::FileAnalysis;
 use super::cache::QualityCache;
 use super::types::{
     default_generated_paths, default_ignored_paths, QualityLimits, QualityMode,
@@ -55,38 +56,6 @@ impl QualityContext {
     }
 }
 
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-pub struct FileAnalysis {
-    pub path: String,
-    pub line_count: usize,
-    pub added_lines: usize,
-    pub raw_lines: Vec<String>,
-    pub normalized_lines: Vec<NormalizedLine>,
-    pub symbols: Vec<SymbolAnalysis>,
-}
-
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-pub struct NormalizedLine {
-    pub line_number: usize,
-    pub value: String,
-}
-
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-pub struct SymbolAnalysis {
-    pub kind: String,
-    pub name: String,
-    pub start_line: usize,
-    pub end_line: usize,
-    pub indent: usize,
-    pub tokens: HashSet<String>,
-}
-
-impl SymbolAnalysis {
-    pub fn line_count(&self) -> usize {
-        self.end_line.saturating_sub(self.start_line) + 1
-    }
-}
-
 pub fn scan_repository(
     root: &Path,
     mode: QualityMode,