@lamentis/naome 1.3.1 → 1.3.3

package/crates/naome-core/tests/verification_contract.rs

@@ -3,7 +3,10 @@ use serde_json::json;
 
 mod repo_support;
 
-use repo_support::{change_type, diff_check, verification_value, TestRepo};
+use repo_support::{
+    change_type, check_missing_last_verified_fixture, diff_check,
+    placeholder_verification_contract_fixture, quality_check, verification_value, TestRepo,
+};
 
 #[test]
 fn accepts_valid_contract_and_testing_map() {
@@ -39,35 +42,7 @@ fn rejects_missing_check_references_and_ready_placeholders() {
     repo.write_testing_markdown(default_testing_markdown());
     repo.write_naome_json(
         "verification.json",
-        json!({
-            "schema": "naome.verification.v1",
-            "version": 1,
-            "status": "ready",
-            "lastUpdated": "2026-05-05",
-            "checks": [
-                {
-                    "id": "example-check",
-                    "command": "replace with real command",
-                    "cwd": ".",
-                    "purpose": "Replace with what this proves.",
-                    "cost": "fast",
-                    "source": "replace with evidence source",
-                    "evidence": [],
-                    "lastVerified": null
-                }
-            ],
-            "changeTypes": [
-                {
-                    "id": "docs",
-                    "description": "Documentation changes.",
-                    "paths": ["docs/**"],
-                    "requiredChecks": ["missing-check"],
-                    "recommendedChecks": [],
-                    "humanReview": false
-                }
-            ],
-            "releaseGates": []
-        }),
+        placeholder_verification_contract_fixture(),
     );
 
     let errors = validate_verification_contract(repo.path()).unwrap();
@@ -77,32 +52,47 @@ fn rejects_missing_check_references_and_ready_placeholders() {
     assert!(joined.contains("must not contain example placeholders"));
 }
 
+#[test]
+fn rejects_repository_quality_without_semantic_required_check() {
+    let repo = TestRepo::new("verification-contract-semantic-required");
+    repo.write_testing_markdown(default_testing_markdown());
+    repo.write_naome_json("verification.json", {
+        let mut value = verification_value(
+            "ready",
+            vec![quality_check(
+                "repository-quality-check",
+                "node .naome/bin/naome.js quality check --changed",
+                "Validate changed files against repository quality rules.",
+                "fast",
+                vec![".naome/repository-quality.json"],
+            )],
+            vec![change_type(
+                "code",
+                "Code changes.",
+                vec!["src/**"],
+                vec!["repository-quality-check"],
+            )],
+        );
+        value["lastUpdated"] = json!("2026-05-11");
+        value["releaseGates"] = json!([{
+            "checkId": "repository-quality-check",
+            "requiredWhen": "Before release."
+        }]);
+        value
+    });
+
+    let errors = validate_verification_contract(repo.path()).unwrap();
+    let joined = errors.join("\n");
+
+    assert!(joined.contains("repository-semantic-check"));
+    assert!(joined.contains("changeTypes[0].requiredChecks"));
+}
+
 #[test]
 fn rejects_checks_without_explicit_last_verified_value() {
     let repo = TestRepo::new("verification-contract-last-verified");
     repo.write_testing_markdown(default_testing_markdown());
-    repo.write_naome_json(
-        "verification.json",
-        json!({
-            "schema": "naome.verification.v1",
-            "version": 1,
-            "status": "uninitialized",
-            "lastUpdated": null,
-            "checks": [
-                {
-                    "id": "diff-check",
-                    "command": "git diff --check",
-                    "cwd": ".",
-                    "purpose": "Reject whitespace errors.",
-                    "cost": "fast",
-                    "source": "git",
-                    "evidence": []
-                }
-            ],
-            "changeTypes": [],
-            "releaseGates": []
-        }),
-    );
+    repo.write_naome_json("verification.json", check_missing_last_verified_fixture());
 
     let errors = validate_verification_contract(repo.path()).unwrap();
     let joined = errors.join("\n");

package/crates/naome-core/tests/workflow_integrity.rs

@@ -5,8 +5,7 @@ use std::fs;
 use naome_core::{
     refresh_integrity, summarize_command_output, verification_phase_plan, CommandCheckResult,
 };
-use serde_json::json;
-use workflow_support::{check, phase, WorkflowFixture};
+use workflow_support::{phased_verification_fixture, WorkflowFixture};
 
 #[test]
 fn refresh_integrity_is_idempotent_and_repairs_manifest_hash() {
@@ -29,24 +28,7 @@ fn refresh_integrity_is_idempotent_and_repairs_manifest_hash() {
 #[test]
 fn failed_early_phase_withholds_expensive_recommendations() {
     let repo = WorkflowFixture::new("verification-phases");
-    repo.write_verification(json!({
-        "schema": "naome.verification.v1",
-        "version": 1,
-        "status": "ready",
-        "lastUpdated": "2026-05-07",
-        "checks": [
-            check("naome-harness-health", "node .naome/bin/check-harness-health.js", "fast"),
-            check("repository-quality-check", "node .naome/bin/naome.js quality check --changed", "fast"),
-            check("package-dry-run", "npm run pack:dry-run", "medium")
-        ],
-        "phases": [
-            phase("shape-health", 10, ["naome-harness-health"]),
-            phase("quality", 20, ["repository-quality-check"]),
-            phase("package-release", 50, ["package-dry-run"])
-        ],
-        "changeTypes": [],
-        "releaseGates": []
-    }));
+    repo.write_verification(phased_verification_fixture());
 
     let plan = verification_phase_plan(
         repo.path(),

package/crates/naome-core/tests/workflow_support/mod.rs

@@ -80,17 +80,10 @@ impl WorkflowFixture {
             checks,
             git_text(&self.root, &["rev-parse", "HEAD"]),
         );
-        self.write(
-            ".naome/task-state.json",
-            &pretty(json!({
-                "schema": "naome.task-state.v2",
-                "version": 2,
-                "status": status,
-                "activeTask": active_task,
-                "blocker": null,
-                "updatedAt": "2026-05-07T12:00:00.000Z"
-            })),
-        );
+        let mut task_state = task_state_template_fixture();
+        task_state["status"] = json!(status);
+        task_state["activeTask"] = active_task;
+        self.write(".naome/task-state.json", &pretty(task_state));
     }
 
     pub fn write_verification(&self, value: serde_json::Value) {
@@ -113,15 +106,32 @@ impl Drop for WorkflowFixture {
 }
 
 pub fn default_verification() -> serde_json::Value {
-    json!({
-        "schema": "naome.verification.v1",
-        "version": 1,
-        "status": "ready",
-        "lastUpdated": "2026-05-07",
-        "checks": [check("diff-check", "git diff --check", "fast")],
-        "changeTypes": [],
-        "releaseGates": []
-    })
+    let mut value = verification_template_fixture();
+    value["checks"] = json!([check("diff-check", "git diff --check", "fast")]);
+    value
+}
+
+pub fn phased_verification_fixture() -> serde_json::Value {
+    let mut value = verification_template_fixture();
+    value["checks"] = json!([
+        check(
+            "naome-harness-health",
+            "node .naome/bin/check-harness-health.js",
+            "fast"
+        ),
+        check(
+            "repository-quality-check",
+            "node .naome/bin/naome.js quality check --changed",
+            "fast"
+        ),
+        check("package-dry-run", "npm run pack:dry-run", "medium")
+    ]);
+    value["phases"] = json!([
+        phase("shape-health", 10, ["naome-harness-health"]),
+        phase("quality", 20, ["repository-quality-check"]),
+        phase("package-release", 50, ["package-dry-run"])
+    ]);
+    value
 }
 
 pub fn check(id: &str, command: &str, cost: &str) -> serde_json::Value {
@@ -159,6 +169,35 @@ fn active_task_state(
     })
 }
 
+fn task_state_template_fixture() -> serde_json::Value {
+    serde_json::from_str(
+        r#"{
+  "schema": "naome.task-state.v2",
+  "version": 2,
+  "status": null,
+  "activeTask": null,
+  "blocker": null,
+  "updatedAt": "2026-05-07T12:00:00.000Z"
+}"#,
+    )
+    .unwrap()
+}
+
+fn verification_template_fixture() -> serde_json::Value {
+    serde_json::from_str(
+        r#"{
+  "schema": "naome.verification.v1",
+  "version": 1,
+  "status": "ready",
+  "lastUpdated": "2026-05-07",
+  "checks": [],
+  "changeTypes": [],
+  "releaseGates": []
+}"#,
+    )
+    .unwrap()
+}
+
 fn admission_record(git_head: String) -> serde_json::Value {
     json!({
         "command": "node .naome/bin/check-task-state.js --admission",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lamentis/naome",
-  "version": "1.3.1",
+  "version": "1.3.3",
   "description": "Native-first CLI for the NAOME agent harness.",
   "license": "Apache-2.0",
   "type": "module",

package/templates/naome-root/.naome/bin/check-harness-health.js

@@ -18,7 +18,7 @@ const expectedMachineOwnedIntegrity = Object.freeze({
   "docs/naome/agent-workflow.md": "sha256:78faeb4eed157b60f0b60bc43da36c713fc4a3436b93bd963ce5f3c12dc91f22",
   "docs/naome/context-economy.md": "sha256:3ed5075815ecf4ada46a5e65438769310307c35759fcd46b13dc0b96e02bebd9",
   "docs/naome/execution.md": "sha256:bfc5d55838942ec8e3d790b59e3c634ff5bf6a2298265cef3dca9788a097eafb",
-  "docs/naome/first-run.md": "sha256:f1a2412f1b542e61c79b5ba65a3fdaa810b0f95cf79d9f734256418cdcfb19aa",
+  "docs/naome/first-run.md": "sha256:1466ce8c65e19a1514885f917db14e8a772350e3f6d1c03a66326963365919e1",
   "docs/naome/index.md": "sha256:07ef776f49130319a5280bdb3ae38af22141708253f38eb983a4336fbae1b25a",
   "docs/naome/task-ledger.md": "sha256:1e524085a2f88811941fd9f2f48ca826bc3e0e4816039d07e795637847714cbd",
   "docs/naome/upgrade.md": "sha256:2c60f0441bbd98bd528d109b30a7ded4b0ad55d61ffb9f52edac9e93b7999cb1"

package/templates/naome-root/.naome/bin/check-task-state.js

@@ -18,7 +18,7 @@ const expectedMachineOwnedIntegrity = Object.freeze({
   "docs/naome/agent-workflow.md": "sha256:78faeb4eed157b60f0b60bc43da36c713fc4a3436b93bd963ce5f3c12dc91f22",
   "docs/naome/context-economy.md": "sha256:3ed5075815ecf4ada46a5e65438769310307c35759fcd46b13dc0b96e02bebd9",
   "docs/naome/execution.md": "sha256:bfc5d55838942ec8e3d790b59e3c634ff5bf6a2298265cef3dca9788a097eafb",
-  "docs/naome/first-run.md": "sha256:f1a2412f1b542e61c79b5ba65a3fdaa810b0f95cf79d9f734256418cdcfb19aa",
+  "docs/naome/first-run.md": "sha256:1466ce8c65e19a1514885f917db14e8a772350e3f6d1c03a66326963365919e1",
   "docs/naome/index.md": "sha256:07ef776f49130319a5280bdb3ae38af22141708253f38eb983a4336fbae1b25a",
   "docs/naome/task-ledger.md": "sha256:1e524085a2f88811941fd9f2f48ca826bc3e0e4816039d07e795637847714cbd",
   "docs/naome/upgrade.md": "sha256:2c60f0441bbd98bd528d109b30a7ded4b0ad55d61ffb9f52edac9e93b7999cb1"

package/templates/naome-root/.naome/manifest.json

@@ -11,7 +11,7 @@
     "docs/naome/agent-workflow.md": "sha256:78faeb4eed157b60f0b60bc43da36c713fc4a3436b93bd963ce5f3c12dc91f22",
     "docs/naome/context-economy.md": "sha256:3ed5075815ecf4ada46a5e65438769310307c35759fcd46b13dc0b96e02bebd9",
     "docs/naome/execution.md": "sha256:bfc5d55838942ec8e3d790b59e3c634ff5bf6a2298265cef3dca9788a097eafb",
-    "docs/naome/first-run.md": "sha256:f1a2412f1b542e61c79b5ba65a3fdaa810b0f95cf79d9f734256418cdcfb19aa",
+    "docs/naome/first-run.md": "sha256:1466ce8c65e19a1514885f917db14e8a772350e3f6d1c03a66326963365919e1",
     "docs/naome/index.md": "sha256:07ef776f49130319a5280bdb3ae38af22141708253f38eb983a4336fbae1b25a",
     "docs/naome/task-ledger.md": "sha256:1e524085a2f88811941fd9f2f48ca826bc3e0e4816039d07e795637847714cbd",
     "docs/naome/upgrade.md": "sha256:2c60f0441bbd98bd528d109b30a7ded4b0ad55d61ffb9f52edac9e93b7999cb1"

package/templates/naome-root/docs/naome/first-run.md

@@ -102,7 +102,7 @@ Rules:
   real check.
 - This JSON is machine state, not prose context. It is exempt from the
   200-line instruction-file budget, but must stay bounded: at most 20 checks, 12
-  change types, and 10 release gates.
+  change types, and 12 release gates.
 - Do not read `.naome/verification.json` as long-form context during normal
   work. Select the relevant change type or check id, then read only the matching
   entries needed for proof.

package/templates/naome-root/docs/naome/testing.md

@@ -67,7 +67,7 @@ phase is failing or missing.
 - Use dates as `YYYY-MM-DD` or `null`.
 - Keep instruction files under 200 lines. `.naome/verification.json` is machine
   state instead; keep it schema-valid and bounded to 20 checks, 12 change types,
-  and 10 release gates.
+  and 12 release gates.
 - Store long command output as a compact summary that preserves command, cwd,
   exit code, relevant lines, affected paths, and artifacts.
 - When intake defines change types, include `repository-quality-check` and