@lamentis/naome 1.3.1 → 1.3.3

package/crates/naome-core/tests/harness_health.rs

@@ -156,50 +156,13 @@ impl HarnessFixture {
         write_file(
             &root,
             ".naome/manifest.json",
-            &format!(
-                "{}\n",
-                serde_json::to_string_pretty(&json!({
-                    "name": "naome",
-                    "harnessVersion": "0.6.1",
-                    "profile": "standard",
-                    "installedAt": "2026-05-05T00:00:00.000Z",
-                    "machineOwned": MACHINE_OWNED_PATHS,
-                    "projectOwned": PROJECT_OWNED_PATHS,
-                    "integrity": integrity
-                }))
-                .unwrap()
-            ),
-        );
-        write_file(
-            &root,
-            ".naome/task-state.json",
-            &format!(
-                "{}\n",
-                serde_json::to_string_pretty(&json!({
-                    "schema": "naome.task-state.v1",
-                    "version": 1,
-                    "status": "idle",
-                    "activeTask": null,
-                    "blocker": null,
-                    "updatedAt": null
-                }))
-                .unwrap()
-            ),
+            &pretty_json(manifest_fixture(&integrity)),
         );
+        write_file(&root, ".naome/task-state.json", "{}\n");
         write_file(
             &root,
             ".naome/upgrade-state.json",
-            &format!(
-                "{}\n",
-                serde_json::to_string_pretty(&json!({
-                    "status": "complete",
-                    "fromVersion": null,
-                    "toVersion": "0.6.1",
-                    "pending": [],
-                    "completed": []
-                }))
-                .unwrap()
-            ),
+            &pretty_json(complete_upgrade_state_fixture()),
         );
 
         Self { root, integrity }
@@ -214,6 +177,32 @@ impl HarnessFixture {
     }
 }
 
+fn manifest_fixture(integrity: &HashMap<String, String>) -> serde_json::Value {
+    json!({
+        "name": "naome",
+        "harnessVersion": "0.6.1",
+        "profile": "standard",
+        "installedAt": "2026-05-05T00:00:00.000Z",
+        "machineOwned": MACHINE_OWNED_PATHS,
+        "projectOwned": PROJECT_OWNED_PATHS,
+        "integrity": integrity
+    })
+}
+
+fn complete_upgrade_state_fixture() -> serde_json::Value {
+    json!({
+        "status": "complete",
+        "fromVersion": null,
+        "toVersion": "0.6.1",
+        "pending": [],
+        "completed": []
+    })
+}
+
+fn pretty_json(value: serde_json::Value) -> String {
+    format!("{}\n", serde_json::to_string_pretty(&value).unwrap())
+}
+
 fn machine_content(relative_path: &str) -> String {
     match relative_path {
         "AGENTS.md" => [

package/crates/naome-core/tests/repo_support/mod.rs

@@ -14,7 +14,10 @@ pub use routes::{
     try_route_readme_task,
 };
 pub use verification_values::{
-    change_type, diff_check, quality_check, repository_quality_config_source,
-    repository_quality_config_value, semantic_repository_quality_fixture_source,
+    change_type, check_missing_last_verified_fixture, diff_check,
+    placeholder_verification_contract_fixture, quality_check, repo_docs_verification_fixture,
+    repository_quality_config_source,
+    repository_quality_config_value, repository_semantic_check,
+    semantic_repository_quality_fixture_source,
     verification_value,
 };

package/crates/naome-core/tests/repo_support/verification.rs

@@ -2,7 +2,8 @@ use serde_json::{json, Value};
 
 use super::repo::TestRepo;
 use super::verification_values::{
-    change_type, diff_check, mutating_diff_check, repository_quality_check, verification_value,
+    change_type, diff_check, mutating_diff_check, repository_quality_check,
+    repository_semantic_check, verification_value,
 };
 
 impl TestRepo {
@@ -33,54 +34,39 @@ impl TestRepo {
     ) {
         let mut checks = vec![diff_check(vec!["README.md"])];
         checks.extend(extra_checks);
-
         self.write_naome_json(
             "verification.json",
-            json!({
-                "schema": "naome.verification.v1",
-                "version": 1,
-                "status": "ready",
-                "checks": checks,
-                "changeTypes": [
-                    {
-                        "id": "readme",
-                        "description": "README changes.",
-                        "paths": ["README.md"],
-                        "requiredChecks": required_checks,
-                        "recommendedChecks": [],
-                        "humanReview": false
-                    }
-                ],
-                "releaseGates": []
-            }),
+            verification_value(
+                "ready",
+                checks,
+                vec![change_type(
+                    "readme",
+                    "README changes.",
+                    vec!["README.md"],
+                    required_checks,
+                )],
+            ),
         );
     }
 
     pub fn write_product_quality_verification(&self) {
         self.write_naome_json(
             "verification.json",
-            json!({
-                "schema": "naome.verification.v1",
-                "version": 1,
-                "status": "ready",
-                "checks": product_quality_checks(),
-                "changeTypes": [
-                    {
-                        "id": "product-installer-or-template",
-                        "description": "NAOME product changes.",
-                        "paths": ["packages/naome/**", "scripts/**"],
-                        "requiredChecks": [
-                            "installer-tests",
-                            "rust-build",
-                            "decision-engine-tests",
-                            "package-dry-run"
-                        ],
-                        "recommendedChecks": [],
-                        "humanReview": false
-                    }
-                ],
-                "releaseGates": []
-            }),
+            verification_value(
+                "ready",
+                product_quality_checks(),
+                vec![change_type(
+                    "product-installer-or-template",
+                    "NAOME product changes.",
+                    vec!["packages/naome/**", "scripts/**"],
+                    vec![
+                        "installer-tests",
+                        "rust-build",
+                        "decision-engine-tests",
+                        "package-dry-run",
+                    ],
+                )],
+            ),
         );
     }
 
@@ -89,7 +75,7 @@ impl TestRepo {
             "verification.json",
             verification_value(
                 "ready",
-                vec![repository_quality_check()],
+                vec![repository_quality_check(), repository_semantic_check()],
                 vec![change_type(
                     "source",
                     "Source changes.",

package/crates/naome-core/tests/repo_support/verification_values.rs

@@ -1,4 +1,4 @@
-use serde_json::json;
+use serde_json::{json, Value};
 
 pub fn completed_task_state(admission_head: &str) -> serde_json::Value {
     json!({
@@ -67,6 +67,7 @@ pub fn verification_value(
         "schema": "naome.verification.v1",
         "version": 1,
         "status": status,
+        "lastUpdated": null,
         "checks": checks,
         "changeTypes": change_types,
         "releaseGates": []
@@ -118,6 +119,97 @@ pub fn change_type(
     })
 }
 
+pub fn repo_docs_verification_fixture() -> Value {
+    json!({
+        "schema": "naome.verification.v1",
+        "version": 1,
+        "status": "ready",
+        "lastUpdated": "2026-05-05",
+        "checks": [
+            {
+                "id": "repo-docs",
+                "command": "npm run docs:test",
+                "cwd": ".",
+                "purpose": "Validate repository documentation.",
+                "cost": "fast",
+                "source": "repository intake",
+                "evidence": ["package.json"],
+                "lastVerified": null
+            }
+        ],
+        "changeTypes": [
+            {
+                "id": "repo-docs",
+                "description": "Repository documentation changes.",
+                "paths": ["docs/**"],
+                "requiredChecks": ["repo-docs"],
+                "recommendedChecks": [],
+                "humanReview": false
+            }
+        ],
+        "releaseGates": [
+            {
+                "checkId": "repo-docs",
+                "requiredWhen": "Before merging repository documentation changes."
+            }
+        ]
+    })
+}
+
+pub fn placeholder_verification_contract_fixture() -> Value {
+    json!({
+        "schema": "naome.verification.v1",
+        "version": 1,
+        "status": "ready",
+        "lastUpdated": "2026-05-05",
+        "checks": [
+            {
+                "id": "example-check",
+                "command": "replace with real command",
+                "cwd": ".",
+                "purpose": "Replace with what this proves.",
+                "cost": "fast",
+                "source": "replace with evidence source",
+                "evidence": [],
+                "lastVerified": null
+            }
+        ],
+        "changeTypes": [
+            {
+                "id": "docs",
+                "description": "Documentation changes.",
+                "paths": ["docs/**"],
+                "requiredChecks": ["missing-check"],
+                "recommendedChecks": [],
+                "humanReview": false
+            }
+        ],
+        "releaseGates": []
+    })
+}
+
+pub fn check_missing_last_verified_fixture() -> Value {
+    json!({
+        "schema": "naome.verification.v1",
+        "version": 1,
+        "status": "uninitialized",
+        "lastUpdated": null,
+        "checks": [
+            {
+                "id": "diff-check",
+                "command": "git diff --check",
+                "cwd": ".",
+                "purpose": "Reject whitespace errors.",
+                "cost": "fast",
+                "source": "git",
+                "evidence": []
+            }
+        ],
+        "changeTypes": [],
+        "releaseGates": []
+    })
+}
+
 pub fn quality_check(
     id: &str,
     command: &str,
@@ -150,6 +242,19 @@ pub fn repository_quality_check() -> serde_json::Value {
     })
 }
 
+pub fn repository_semantic_check() -> serde_json::Value {
+    json!({
+        "id": "repository-semantic-check",
+        "command": "naome semantic check --changed",
+        "cwd": ".",
+        "purpose": "Validate changed files against repository semantic rules.",
+        "cost": "fast",
+        "source": "NAOME built-in",
+        "evidence": ["src/**"],
+        "lastVerified": null
+    })
+}
+
 pub fn semantic_repository_quality_fixture_source(name: &str) -> String {
     [
         format!("const {name} = {{"),

package/crates/naome-core/tests/route_user_diff.rs

@@ -73,14 +73,14 @@ fn execute_route_runs_repository_quality_check_without_shelling_to_repo_command(
 }
 
 #[test]
-fn execute_route_refuses_semantic_changed_findings_through_repository_quality_gate() {
-    let repo = TestRepo::new("route-semantic-quality-gate");
+fn execute_route_requires_semantic_gate_with_repository_quality_gate() {
+    let repo = TestRepo::new("route-repository-quality-requires-semantic");
     repo.init_git();
     repo.write_file(
         ".naome/repository-quality.json",
         &repository_quality_config_source(),
     );
-    repo.write_file("scripts/baseline.test.js", "const ok = { value: 1 };\n");
+    repo.write_file("src/clean.js", "export const clean = true;\n");
     repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
     repo.write_naome_json(
         "verification.json",
@@ -91,8 +91,56 @@ fn execute_route_refuses_semantic_changed_findings_through_repository_quality_ga
                 "naome quality check --changed",
                 "Validate changed files against repository quality rules.",
                 "fast",
-                vec!["scripts/**"],
+                vec!["src/**"],
             )],
+            vec![change_type(
+                "source",
+                "Source changes.",
+                vec!["src/**"],
+                vec!["repository-quality-check"],
+            )],
+        ),
+    );
+    repo.commit_all("baseline");
+    repo.write_file("src/clean.js", "export const clean = false;\n");
+    let before_head = repo.git_stdout(&["rev-parse", "HEAD"]);
+
+    let route = route_commit_request(&repo);
+
+    assert_quality_gate_blocked(&repo, &route, before_head, "src/clean.js");
+    assert!(route.user_message.contains("repository-semantic-check"));
+}
+
+#[test]
+fn execute_route_refuses_semantic_changed_findings_through_repository_quality_gate() {
+    let repo = TestRepo::new("route-semantic-quality-gate");
+    repo.init_git();
+    repo.write_file(
+        ".naome/repository-quality.json",
+        &repository_quality_config_source(),
+    );
+    repo.write_file("scripts/baseline.test.js", "const ok = { value: 1 };\n");
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
+    repo.write_naome_json(
+        "verification.json",
+        verification_value(
+            "ready",
+            vec![
+                quality_check(
+                    "repository-quality-check",
+                    "naome quality check --changed",
+                    "Validate changed files against repository quality rules.",
+                    "fast",
+                    vec!["scripts/**"],
+                ),
+                quality_check(
+                    "repository-semantic-check",
+                    "naome semantic check --changed",
+                    "Validate changed files against repository semantic rules.",
+                    "fast",
+                    vec!["scripts/**"],
+                ),
+            ],
             vec![change_type(
                 "scripts",
                 "Script changes.",

package/crates/naome-core/tests/task_state.rs

@@ -8,8 +8,8 @@ use naome_core::{
 };
 use serde_json::json;
 use task_state_support::{
-    active_task, complete_task_state, idle_task_state, strict_health_options, successful_admission,
-    successful_proof, TaskFixture,
+    active_task, complete_task_state, idle_task_state, ready_empty_verification_fixture,
+    strict_health_options, successful_admission, successful_proof, TaskFixture,
 };
 
 #[test]
@@ -137,15 +137,7 @@ fn commit_gate_allows_install_baseline_with_gitignore_and_project_owned_paths()
     repo.write("docs/naome/testing.md", "# Testing\n");
     repo.write_json(
         ".naome/verification.json",
-        json!({
-            "schema": "naome.verification.v1",
-            "version": 1,
-            "status": "ready",
-            "lastUpdated": "2026-05-05",
-            "checks": [],
-            "changeTypes": [],
-            "releaseGates": []
-        }),
+        ready_empty_verification_fixture(),
     );
 
     let report = commit_gate_report(&repo);
@@ -292,7 +284,7 @@ fn commit_gate_ignores_unstaged_user_edits_outside_completed_task_scope() {
 
 #[test]
 fn progress_accepts_implementing_task_with_scoped_diff_without_proof() {
-    let repo = TaskFixture::new(implementing_readme_task());
+    let repo = TaskFixture::new(implementing_readme_task_fixture());
     repo.init_git();
     repo.write("README.md", "# In progress\n");
 
@@ -303,7 +295,7 @@ fn progress_accepts_implementing_task_with_scoped_diff_without_proof() {
 
 #[test]
 fn progress_rejects_in_flight_work_outside_scope() {
-    let repo = TaskFixture::new(implementing_readme_task());
+    let repo = TaskFixture::new(implementing_readme_task_fixture());
     repo.init_git();
     repo.write("src/session.js", "export const session = null;\n");
 
@@ -417,27 +409,21 @@ fn progress_report(repo: &TaskFixture) -> TaskStateReport {
     .unwrap()
 }
 
-fn implementing_readme_task() -> serde_json::Value {
-    json!({
-        "schema": "naome.task-state.v1",
-        "version": 1,
-        "status": "implementing",
-        "activeTask": active_task(json!({
-            "allowedPaths": ["README.md"],
-            "proofResults": []
-        })),
-        "blocker": null,
-        "updatedAt": "2026-05-04T12:00:00.000Z"
-    })
+fn implementing_readme_task_fixture() -> serde_json::Value {
+    implementing_task_fixture(vec!["README.md"])
 }
 
 fn implementing_package_task() -> serde_json::Value {
+    implementing_task_fixture(vec!["Package.swift"])
+}
+
+fn implementing_task_fixture(allowed_paths: Vec<&str>) -> serde_json::Value {
     json!({
         "schema": "naome.task-state.v1",
         "version": 1,
         "status": "implementing",
         "activeTask": active_task(json!({
-            "allowedPaths": ["Package.swift"],
+            "allowedPaths": allowed_paths,
             "proofResults": []
         })),
         "blocker": null,

package/crates/naome-core/tests/task_state_support/mod.rs

@@ -11,7 +11,8 @@ use naome_core::{HarnessHealthOptions, MACHINE_OWNED_PATHS, PROJECT_OWNED_PATHS}
 use serde_json::{json, Value};
 use sha2::{Digest, Sha256};
 pub use states::{
-    active_task, complete_task_state, idle_task_state, successful_admission, successful_proof,
+    active_task, complete_task_state, idle_task_state, ready_empty_verification_fixture,
+    successful_admission, successful_proof,
 };
 
 static FIXTURE_COUNTER: AtomicU64 = AtomicU64::new(0);

package/crates/naome-core/tests/task_state_support/states.rs

@@ -1,24 +1,25 @@
 use serde_json::{json, Value};
 
 pub fn idle_task_state() -> Value {
-    json!({
-        "schema": "naome.task-state.v1",
-        "version": 1,
-        "status": "idle",
-        "activeTask": null,
-        "blocker": null,
-        "updatedAt": null
-    })
+    task_state_record("idle", Value::Null, Value::Null)
 }
 
 pub fn complete_task_state(overrides: Value) -> Value {
+    task_state_record(
+        "complete",
+        active_task(overrides),
+        json!("2026-05-04T12:00:00.000Z"),
+    )
+}
+
+fn task_state_record(status: &str, active_task: Value, updated_at: Value) -> Value {
     json!({
         "schema": "naome.task-state.v1",
         "version": 1,
-        "status": "complete",
-        "activeTask": active_task(overrides),
+        "status": status,
+        "activeTask": active_task,
         "blocker": null,
-        "updatedAt": "2026-05-04T12:00:00.000Z"
+        "updatedAt": updated_at
     })
 }
 
@@ -71,6 +72,22 @@ pub fn successful_proof(overrides: Value) -> Value {
     proof
 }
 
+pub fn ready_empty_verification_fixture() -> Value {
+    serde_json::from_str(
+        r#"{
+  "schema": "naome.verification.v1",
+  "version": 1,
+  "status": "ready",
+  "lastUpdated": "2026-05-05",
+  "checks": [],
+  "changeTypes": [],
+  "releaseGates": [],
+  "phases": []
+}"#,
+    )
+    .unwrap()
+}
+
 fn merge_object(target: &mut Value, overrides: Value) {
     let Some(target_object) = target.as_object_mut() else {
         return;

package/crates/naome-core/tests/verification.rs

@@ -2,30 +2,12 @@ use naome_core::seed_builtin_verification_checks;
 
 mod repo_support;
 
-use repo_support::{change_type, quality_check, verification_value, TestRepo};
+use repo_support::{repo_docs_verification_fixture, TestRepo};
 
 #[test]
 fn seeds_builtin_checks_without_removing_repo_specific_checks() {
     let repo = TestRepo::new("verification-seed");
-    repo.write_naome_json(
-        "verification.json",
-        verification_value(
-            "ready",
-            vec![quality_check(
-                "repo-docs",
-                "npm run docs:test",
-                "Validate repository documentation.",
-                "fast",
-                vec!["package.json"],
-            )],
-            vec![change_type(
-                "repo-docs",
-                "Repository documentation changes.",
-                vec!["docs/**"],
-                vec!["repo-docs"],
-            )],
-        ),
-    );
+    repo.write_naome_json("verification.json", repo_docs_verification_fixture());
 
     let changed = seed_builtin_verification_checks(repo.path()).unwrap();