@kabmo-labs/kabmo 0.17.0 → 0.18.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (269) hide show
  1. package/dist/client/index.html +1 -1
  2. package/dist/client/index.js +538 -457
  3. package/dist/client/static/js/index-hp75vsv9.css +1 -0
  4. package/dist/client/static/js/{index-rerjq5th.js → index-tc09dtca.js} +823 -814
  5. package/package.json +1 -1
  6. package/src/client/components/common/MarkdownRenderer.tsx +136 -89
  7. package/src/client/components/common/anchored-menu/index.test.tsx +141 -0
  8. package/src/client/components/common/anchored-menu/index.tsx +143 -0
  9. package/src/client/components/common/markdown-review/ReviewPopover.tsx +144 -0
  10. package/src/client/components/common/markdown-review/ReviewSummary.tsx +108 -0
  11. package/src/client/components/common/markdown-review/index.tsx +129 -0
  12. package/src/client/components/common/server-control/Panel.tsx +33 -23
  13. package/src/client/components/common/server-control/index.test.tsx +11 -5
  14. package/src/client/components/common/server-control/index.tsx +10 -8
  15. package/src/client/components/layout/session-sidebar/CategoryHeader.tsx +42 -21
  16. package/src/client/components/layout/session-sidebar/CategoryHeader.worktree.test.tsx +36 -17
  17. package/src/client/components/layout/session-sidebar/CategoryItem.tsx +8 -7
  18. package/src/client/components/layout/session-sidebar/about-modal/NotesDialog.tsx +94 -0
  19. package/src/client/components/layout/session-sidebar/about-modal/VersionLine.test.tsx +68 -0
  20. package/src/client/components/layout/session-sidebar/about-modal/VersionLine.tsx +36 -0
  21. package/src/client/components/layout/session-sidebar/about-modal/index.tsx +57 -34
  22. package/src/client/components/layout/session-sidebar/modern/WorkspaceHeader.tsx +28 -10
  23. package/src/client/components/layout/session-sidebar/modern/WorkspaceSection.tsx +7 -6
  24. package/src/client/components/layout/session-sidebar/modern/workspace-header.test.tsx +1 -1
  25. package/src/client/components/layout/update-popup/ReleaseNotes.tsx +8 -3
  26. package/src/client/components/layout/update-popup/index.tsx +5 -1
  27. package/src/client/components/mobile/mobile-right-sidebar/FullEditor.tsx +13 -15
  28. package/src/client/components/mobile/mobile-right-sidebar/Header.tsx +23 -1
  29. package/src/client/components/mobile/mobile-right-sidebar/MissingFileBanner.tsx +30 -0
  30. package/src/client/components/mobile/mobile-right-sidebar/PreviewScroller.tsx +18 -2
  31. package/src/client/components/mobile/mobile-session-sidebar/Item.tsx +22 -67
  32. package/src/client/components/mobile/mobile-session-sidebar/ItemMenu.tsx +110 -0
  33. package/src/client/components/settings/SettingsSidebarList.tsx +20 -0
  34. package/src/client/components/settings/categories/AgentSettings.tsx +23 -50
  35. package/src/client/components/settings/categories/CommandSettings.tsx +2 -2
  36. package/src/client/components/settings/categories/McpSettings.tsx +4 -21
  37. package/src/client/components/settings/categories/OmpSettings.tsx +147 -194
  38. package/src/client/components/settings/categories/SkillSettings.tsx +2 -2
  39. package/src/client/components/settings/categories/TokenUsageSettings.tsx +211 -229
  40. package/src/client/components/settings/categories/agent-settings/DetailPane.tsx +229 -237
  41. package/src/client/components/settings/categories/agent-settings/ModelPicker.tsx +71 -0
  42. package/src/client/components/settings/categories/agent-settings/SidebarList.tsx +9 -2
  43. package/src/client/components/settings/categories/agent-settings/levels.ts +38 -0
  44. package/src/client/components/settings/categories/behavior-settings/Editor.tsx +27 -7
  45. package/src/client/components/settings/categories/chat-settings/ToolRenderSection.tsx +23 -5
  46. package/src/client/components/settings/categories/command-settings/DetailPane.tsx +75 -33
  47. package/src/client/components/settings/categories/command-settings/SidebarList.tsx +7 -0
  48. package/src/client/components/settings/categories/mcp-settings/DetailPane.tsx +91 -76
  49. package/src/client/components/settings/categories/mcp-settings/EnvVarsSection.tsx +83 -0
  50. package/src/client/components/settings/categories/mcp-settings/ImportModal.tsx +26 -13
  51. package/src/client/components/settings/categories/mcp-settings/SidebarList.tsx +20 -0
  52. package/src/client/components/settings/categories/omp-settings/ConfigTabs.tsx +97 -36
  53. package/src/client/components/settings/categories/omp-settings/EngineHeader.tsx +151 -0
  54. package/src/client/components/settings/categories/omp-settings/ExtensionsPanel.tsx +68 -32
  55. package/src/client/components/settings/categories/omp-settings/OrderedChips.tsx +119 -0
  56. package/src/client/components/settings/categories/omp-settings/PresetBar.tsx +14 -7
  57. package/src/client/components/settings/categories/omp-settings/RoleEditor.tsx +15 -6
  58. package/src/client/components/settings/categories/omp-settings/RowEditor.tsx +165 -226
  59. package/src/client/components/settings/categories/omp-settings/types.ts +28 -0
  60. package/src/client/components/settings/categories/skill-settings/DetailHeader.tsx +35 -7
  61. package/src/client/components/settings/categories/skill-settings/DetailPane.tsx +34 -14
  62. package/src/client/components/settings/categories/skill-settings/SidebarList.tsx +21 -0
  63. package/src/client/components/settings/categories/skill-settings/pane.test.tsx +15 -6
  64. package/src/client/components/settings/categories/token-usage-settings/Breakdown.tsx +242 -102
  65. package/src/client/components/settings/categories/token-usage-settings/Chart.tsx +130 -56
  66. package/src/client/components/settings/categories/token-usage-settings/Controls.tsx +135 -0
  67. package/src/client/components/settings/categories/token-usage-settings/MetricsGrid.tsx +55 -33
  68. package/src/client/components/settings/categories/token-usage-settings/Provenance.tsx +59 -0
  69. package/src/client/components/settings/categories/token-usage-settings/panel.test.tsx +239 -0
  70. package/src/client/components/workspace/browser-panel/Screencast.test.ts +1 -0
  71. package/src/client/components/workspace/browser-panel/Screencast.tsx +17 -22
  72. package/src/client/components/workspace/browser-panel/TabStrip.test.tsx +158 -0
  73. package/src/client/components/workspace/browser-panel/TabStrip.tsx +90 -0
  74. package/src/client/components/workspace/browser-panel/index.tsx +50 -4
  75. package/src/client/components/workspace/browser-toolbar/index.tsx +41 -1
  76. package/src/client/components/workspace/chat-timeline/ThinkingSection.tsx +3 -1
  77. package/src/client/components/workspace/chat-timeline/ToolCallingSection.tsx +2 -0
  78. package/src/client/components/workspace/chat-timeline/block-chrome.test.tsx +13 -2
  79. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Bash.test.ts +88 -0
  80. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Bash.tsx +24 -1
  81. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Read.test.ts +34 -0
  82. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Read.tsx +5 -1
  83. package/src/client/components/workspace/chat-timeline/tool-renderers/shared/ArtifactChip.tsx +7 -6
  84. package/src/client/components/workspace/chat-timeline/tool-renderers/styles/Tui.test.tsx +237 -0
  85. package/src/client/components/workspace/chat-timeline/tool-renderers/styles/Tui.tsx +191 -0
  86. package/src/client/components/workspace/chat-timeline/tool-renderers/styles/styles.test.tsx +1 -1
  87. package/src/client/components/workspace/diff-panel/MergeDiffView.tsx +21 -7
  88. package/src/client/components/workspace/diff-panel/changes.test.ts +51 -0
  89. package/src/client/components/workspace/diff-panel/changes.ts +28 -12
  90. package/src/client/components/workspace/diff-panel/merge.test.ts +28 -0
  91. package/src/client/components/workspace/diff-panel/merge.ts +21 -1
  92. package/src/client/components/workspace/editor/Body.tsx +7 -0
  93. package/src/client/components/workspace/editor/FileDocument.tsx +15 -21
  94. package/src/client/components/workspace/editor/FilePane.tsx +12 -0
  95. package/src/client/components/workspace/editor/PreviewPane.tsx +70 -0
  96. package/src/client/components/workspace/editor/Toolbar.tsx +17 -1
  97. package/src/client/components/workspace/editor/index.tsx +25 -22
  98. package/src/client/components/workspace/editor/toolbar-clusters.test.ts +14 -0
  99. package/src/client/components/workspace/editor/toolbar-clusters.tsx +12 -86
  100. package/src/client/components/workspace/editor/toolbar-toggle.tsx +53 -0
  101. package/src/client/components/workspace/editor/toolbar-write-clusters.tsx +112 -0
  102. package/src/client/components/workspace/git-panel/commit-modal.test.ts +5 -3
  103. package/src/client/components/workspace/user-browser-panel/AddressBar.tsx +5 -0
  104. package/src/client/components/workspace/user-browser-panel/AnnotateBar.test.tsx +201 -0
  105. package/src/client/components/workspace/user-browser-panel/AnnotateBar.tsx +112 -0
  106. package/src/client/components/workspace/user-browser-panel/AnnotateLayer.test.tsx +225 -0
  107. package/src/client/components/workspace/user-browser-panel/AnnotateLayer.tsx +217 -0
  108. package/src/client/components/workspace/user-browser-panel/AnnotateTarget.tsx +99 -0
  109. package/src/client/components/workspace/user-browser-panel/Frame.tsx +30 -1
  110. package/src/client/components/workspace/user-browser-panel/index.tsx +81 -2
  111. package/src/client/data/agent-data/builtin.ts +0 -10
  112. package/src/client/data/agent-data/orchestrator.ts +0 -45
  113. package/src/client/data/agent-data/specialist.ts +0 -100
  114. package/src/client/data/mock/token-usage.ts +170 -120
  115. package/src/client/data/settings/omp-schema.json +33 -1
  116. package/src/client/hooks/browser/use-annotate.test.ts +143 -0
  117. package/src/client/hooks/browser/use-annotate.ts +98 -0
  118. package/src/client/hooks/browser/use-close-tab.test.ts +148 -0
  119. package/src/client/hooks/browser/use-close-tab.ts +67 -0
  120. package/src/client/hooks/browser/use-screencast.ts +13 -1
  121. package/src/client/hooks/chat/composer/browser-context.test.ts +117 -0
  122. package/src/client/hooks/chat/composer/browser-context.ts +40 -16
  123. package/src/client/hooks/chat/composer/items.test.ts +1 -1
  124. package/src/client/hooks/chat/composer/review-context.ts +38 -0
  125. package/src/client/hooks/chat/composer/use-draft.test.ts +132 -0
  126. package/src/client/hooks/chat/composer/use-draft.ts +31 -2
  127. package/src/client/hooks/chat/timeline/row-window.test.ts +15 -2
  128. package/src/client/hooks/editor/use-document-annotations.ts +124 -0
  129. package/src/client/hooks/editor/use-editor-panel-ui.ts +52 -0
  130. package/src/client/hooks/editor/use-file-review-mode.ts +35 -0
  131. package/src/client/hooks/editor/use-preview-review.ts +148 -0
  132. package/src/client/hooks/settings/agents.ts +149 -0
  133. package/src/client/hooks/settings/crud-list.test.ts +28 -6
  134. package/src/client/hooks/settings/crud-list.ts +96 -57
  135. package/src/client/hooks/settings/omp-config.ts +164 -0
  136. package/src/client/hooks/settings/useTokenUsage.ts +125 -0
  137. package/src/client/hooks/settings/write-feedback.test.ts +104 -0
  138. package/src/client/hooks/settings/write-feedback.ts +63 -0
  139. package/src/client/hooks/ui/markdown-hydration.ts +125 -0
  140. package/src/client/hooks/ui/updates/index.test.ts +100 -1
  141. package/src/client/hooks/ui/updates/index.ts +50 -0
  142. package/src/client/hooks/ui/updates/notes.test.ts +138 -0
  143. package/src/client/hooks/ui/updates/notes.ts +57 -0
  144. package/src/client/lib/browser/element-at.test.ts +229 -0
  145. package/src/client/lib/browser/element-at.ts +139 -0
  146. package/src/client/lib/review/client.ts +73 -0
  147. package/src/client/lib/router/search-params.ts +42 -20
  148. package/src/client/tailwind.css +65 -0
  149. package/src/server/lib/btw/lifecycle.server.ts +2 -2
  150. package/src/server/lib/db/schema.ts +7 -0
  151. package/src/server/lib/db/seed-terminal.test.ts +4 -0
  152. package/src/server/lib/omp/config/agent-definitions.test.ts +273 -0
  153. package/src/server/lib/omp/config/agents.ts +231 -61
  154. package/src/server/lib/omp/config/definitions.test.ts +9 -105
  155. package/src/server/lib/omp/config/extensions.ts +16 -7
  156. package/src/server/lib/omp/config/omp-config-files.test.ts +27 -0
  157. package/src/server/lib/omp/rpc/constants.test.ts +11 -0
  158. package/src/server/lib/omp/rpc/constants.ts +15 -0
  159. package/src/server/lib/omp/rpc/process.ts +11 -14
  160. package/src/server/lib/omp/rpc/session-commands.ts +6 -3
  161. package/src/server/lib/omp/rpc/utility-agent-dir.test.ts +134 -0
  162. package/src/server/lib/omp/rpc/utility-agent-dir.ts +138 -0
  163. package/src/server/lib/omp/rpc/utility.ts +12 -0
  164. package/src/server/lib/review/schema.server.ts +45 -0
  165. package/src/server/lib/review/store.server.ts +138 -0
  166. package/src/server/lib/terminal/attach-replay.test.ts +132 -0
  167. package/src/server/lib/terminal/output.test.ts +166 -0
  168. package/src/server/lib/terminal/output.ts +104 -0
  169. package/src/server/lib/terminal/runtime.server.ts +5 -0
  170. package/src/server/lib/terminal/send-result.test.ts +33 -0
  171. package/src/server/lib/terminal/send-result.ts +32 -0
  172. package/src/server/lib/terminal/session.server.ts +45 -11
  173. package/src/server/lib/terminal/store-liveness.test.ts +4 -0
  174. package/src/server/lib/updates/active-notes.test.ts +149 -0
  175. package/src/server/lib/updates/active-notes.ts +75 -0
  176. package/src/server/lib/updates/changelog-file.ts +42 -11
  177. package/src/server/lib/updates/changelog.test.ts +15 -1
  178. package/src/server/lib/updates/omp.ts +42 -15
  179. package/src/server/lib/updates/release-url.ts +27 -1
  180. package/src/server/lib/usage/index-parse.test.ts +200 -0
  181. package/src/server/lib/usage/index-parse.ts +178 -0
  182. package/src/server/lib/usage/index-query.server.ts +248 -0
  183. package/src/server/lib/usage/index-scan.server.ts +343 -0
  184. package/src/server/lib/usage/index-schema.server.ts +82 -0
  185. package/src/server/lib/usage/index.test.ts +234 -0
  186. package/src/server/lib/usage/providers.server.ts +4 -53
  187. package/src/server/routes/browser/index.ts +3 -0
  188. package/src/server/routes/browser/stream.ts +31 -2
  189. package/src/server/routes/browser/tabs.test.ts +94 -0
  190. package/src/server/routes/browser/tabs.ts +85 -0
  191. package/src/server/routes/index.ts +2 -0
  192. package/src/server/routes/review/bindings.ts +11 -0
  193. package/src/server/routes/review/index.ts +127 -0
  194. package/src/server/routes/review/routes.test.ts +191 -0
  195. package/src/server/routes/settings/agents.test.ts +180 -0
  196. package/src/server/routes/settings/agents.ts +95 -102
  197. package/src/server/routes/settings/mcp.test.ts +135 -0
  198. package/src/server/routes/settings/mcp.ts +14 -6
  199. package/src/server/routes/settings/settings-store-routes.test.ts +6 -113
  200. package/src/server/routes/telemetry/tokens.test.ts +145 -0
  201. package/src/server/routes/telemetry/tokens.ts +70 -149
  202. package/src/server/routes/terminal/ws.ts +6 -5
  203. package/src/server/routes/updates/index.ts +2 -0
  204. package/src/server/routes/updates/notes.ts +34 -0
  205. package/src/server/routes/updates/routes.test.ts +49 -0
  206. package/src/shared/lib/browser/annotate.test.ts +283 -0
  207. package/src/shared/lib/browser/annotate.ts +231 -0
  208. package/src/shared/lib/browser/browser-viewer.test.ts +26 -4
  209. package/src/shared/lib/browser/frame-gate.test.ts +91 -0
  210. package/src/shared/lib/browser/frame-gate.ts +69 -0
  211. package/src/shared/lib/browser/frame-params.test.ts +43 -0
  212. package/src/shared/lib/browser/frame-params.ts +60 -0
  213. package/src/shared/lib/browser/frame-pipeline.test.ts +132 -0
  214. package/src/shared/lib/browser/frame-pipeline.ts +80 -0
  215. package/src/shared/lib/browser/page-context.ts +60 -4
  216. package/src/shared/lib/browser/snapshot.test.ts +115 -0
  217. package/src/shared/lib/browser/snapshot.ts +112 -0
  218. package/src/shared/lib/browser/tab-close.test.ts +74 -0
  219. package/src/shared/lib/browser/tab-close.ts +77 -0
  220. package/src/shared/lib/browser/viewer.ts +45 -26
  221. package/src/shared/lib/chat/timeline/block-chrome.ts +19 -0
  222. package/src/shared/lib/chat/timeline/tool-render-mode.ts +17 -4
  223. package/src/shared/lib/chat/tool/artifact.ts +55 -20
  224. package/src/shared/lib/chat/tool/bash-facts.ts +96 -0
  225. package/src/shared/lib/chat/tool/minimized.test.ts +98 -0
  226. package/src/shared/lib/chat/tool/minimized.ts +64 -0
  227. package/src/shared/lib/chat/tool/summary.test.ts +28 -8
  228. package/src/shared/lib/chat/tool/summary.ts +3 -32
  229. package/src/shared/lib/markdown/blocks/anchor.ts +63 -0
  230. package/src/shared/lib/markdown/blocks/blocks.test.ts +141 -0
  231. package/src/shared/lib/markdown/blocks/renderer.ts +120 -0
  232. package/src/shared/lib/markdown/blocks/scan.ts +100 -0
  233. package/src/shared/lib/markdown/blocks/types.ts +62 -0
  234. package/src/shared/lib/markdown/marked.ts +58 -147
  235. package/src/shared/lib/markdown/math-extensions.ts +168 -0
  236. package/src/shared/lib/markdown/review/prompt.ts +77 -0
  237. package/src/shared/lib/markdown/review/reconcile.ts +55 -0
  238. package/src/shared/lib/markdown/review/review.test.ts +96 -0
  239. package/src/shared/lib/markdown/xml-sections.test.ts +140 -0
  240. package/src/shared/lib/markdown/xml-sections.ts +139 -0
  241. package/src/shared/lib/models/provider/label.ts +57 -0
  242. package/src/shared/lib/omp/config/agent-file.test.ts +54 -0
  243. package/src/shared/lib/omp/config/agent-file.ts +43 -0
  244. package/src/shared/lib/omp/config/row-value.test.ts +95 -0
  245. package/src/shared/lib/omp/config/row-value.ts +97 -0
  246. package/src/shared/lib/omp/config/schema.test.ts +31 -0
  247. package/src/shared/lib/omp/config/schema.ts +6 -0
  248. package/src/shared/lib/omp/rpc/frame.test.ts +48 -47
  249. package/src/shared/lib/omp/rpc/frame.ts +49 -40
  250. package/src/shared/lib/ui/menu-anchor.test.ts +69 -0
  251. package/src/shared/lib/ui/menu-anchor.ts +89 -0
  252. package/src/shared/lib/usage/breakdown.test.ts +197 -0
  253. package/src/shared/lib/usage/breakdown.ts +241 -0
  254. package/src/shared/lib/usage/range.test.ts +204 -0
  255. package/src/shared/lib/usage/range.ts +240 -0
  256. package/src/shared/lib/usage/view.test.ts +85 -0
  257. package/src/shared/lib/usage/view.ts +74 -0
  258. package/src/shared/types/browser.ts +78 -0
  259. package/src/shared/types/index.ts +1 -0
  260. package/src/shared/types/settings/agent.ts +28 -6
  261. package/src/shared/types/settings/state.ts +4 -3
  262. package/src/shared/types/settings/write.ts +6 -0
  263. package/src/shared/types/tokenUsage.ts +128 -21
  264. package/src/shared/types/updates.ts +20 -0
  265. package/dist/client/static/js/index-3ve31rzx.css +0 -1
  266. package/src/server/lib/omp/session/usage/aggregate-shaping.test.ts +0 -149
  267. package/src/server/lib/omp/session/usage/aggregate.test.ts +0 -243
  268. package/src/server/lib/omp/session/usage/aggregate.ts +0 -330
  269. package/src/server/lib/omp/session/usage/shaping.ts +0 -130
@@ -26,6 +26,9 @@ interface SettingsSidebarListProps {
26
26
  onChangeProject: (project: string) => void;
27
27
  /** Real workspace folders; defaults to the shared placeholder list. */
28
28
  projectOptions?: ProjectOption[];
29
+ /** Why the list could not be read. An empty list is not the same fact. */
30
+ loadError?: string;
31
+ onRetry?: () => void;
29
32
  }
30
33
 
31
34
  /**
@@ -46,6 +49,8 @@ export const SettingsSidebarList: FunctionComponent<SettingsSidebarListProps> =
46
49
  selectedProject,
47
50
  onChangeProject,
48
51
  projectOptions,
52
+ loadError,
53
+ onRetry,
49
54
  }) => {
50
55
  const builtInItems = items.filter((item) => item.isBuiltIn);
51
56
  const customItems = items.filter((item) => !item.isBuiltIn);
@@ -102,6 +107,21 @@ export const SettingsSidebarList: FunctionComponent<SettingsSidebarListProps> =
102
107
  </div>
103
108
 
104
109
  <div className="flex-1 scrollbar-overlay-container p-1.5 space-y-3 text-xs">
110
+ {loadError && (
111
+ <div className="mx-1 rounded-lg border border-error/30 bg-error/5 px-2.5 py-2 text-[11px] leading-snug text-error">
112
+ <div className="font-semibold">Could not read the list</div>
113
+ <div className="mt-0.5 break-words text-error/80">{loadError}</div>
114
+ {onRetry && (
115
+ <button
116
+ type="button"
117
+ onClick={onRetry}
118
+ className="mt-1.5 rounded border border-error/40 px-2 py-0.5 font-medium hover:bg-error/10 cursor-pointer"
119
+ >
120
+ Retry
121
+ </button>
122
+ )}
123
+ </div>
124
+ )}
105
125
  <div>
106
126
  <div className="px-2.5 pt-1.5 pb-1 text-[10px] font-bold text-ink/50 uppercase tracking-wider">
107
127
  {builtInLabel}
@@ -1,13 +1,14 @@
1
1
  import { useState } from 'preact/hooks';
2
2
  import type { FunctionComponent } from 'preact/compat';
3
- import type { AgentItem, SettingsState } from '@/shared/types';
3
+ import type { SettingsState } from '@/shared/types';
4
4
  import { AgentSidebarList } from '@/client/components/settings/categories/agent-settings/SidebarList';
5
5
  import { AgentDetailPane } from '@/client/components/settings/categories/agent-settings/DetailPane';
6
6
  import { LoadingState } from '@/client/components/settings/LoadingState';
7
- import { useCrudList } from '@/client/hooks/settings/crud-list';
7
+ import { useAgents } from '@/client/hooks/settings/agents';
8
8
  import { useSettingsMasterDetail } from '@/client/hooks/settings/master-detail';
9
9
  import { SettingsMasterDetail } from '@/client/components/settings/master-detail';
10
10
  import { GLOBAL_SCOPE_ID, useWorkspaceRoots } from '@/client/hooks/settings/workspace-roots';
11
+ import { emptyAgentTemplate } from '@/client/components/settings/categories/agent-settings/levels';
11
12
 
12
13
  interface AgentSettingsProps {
13
14
  settings: SettingsState;
@@ -17,55 +18,22 @@ interface AgentSettingsProps {
17
18
  /**
18
19
  * The Agents panel, scoped to one project at a time.
19
20
  *
20
- * The project picker used to offer three hardcoded names and do nothing with
21
- * the choice — `selectedProject` was local state no request read, so
22
- * `<workspace>/.omp/agents` was unreachable from the one screen whose job is
23
- * listing agents. It now scopes the read through the same `?root=` contract the
24
- * skills and commands panels use, so the three panels agree about what a
25
- * project scope is.
21
+ * The list IS omp's agent definitions — `~/.omp/agent/agents/*.md` plus the
22
+ * selected workspace's `.omp/agents/*.md` — read and written as files, because
23
+ * that is where omp loads agents from. It used to read a Kabmo-local mirror and
24
+ * POST edits into it, so a saved agent never reached the agent omp ran.
26
25
  */
27
26
  export const AgentSettings: FunctionComponent<AgentSettingsProps> = () => {
28
27
  const masterDetail = useSettingsMasterDetail();
29
28
  const roots = useWorkspaceRoots();
30
29
  const [selectedRootId, setSelectedRootId] = useState<string>(GLOBAL_SCOPE_ID);
30
+ const [isCreating, setIsCreating] = useState(false);
31
31
  const query = roots.queryFor(selectedRootId);
32
32
 
33
- const { items: agents, selectedId, selected: selectedAgent, isCreatingNew, isLoading, select, startCreate, save, remove } =
34
- useCrudList<AgentItem>({
35
- endpoint: '/api/settings/agents',
36
- query,
37
- listKey: 'agents',
38
- bodyKey: 'agent',
39
- messages: {
40
- load: 'Failed to load agents from API:',
41
- save: 'Failed to save agent via API:',
42
- delete: 'Failed to delete agent via API:',
43
- },
44
- cacheKey: 'agent',
45
- buildNew: (updated) => ({ ...updated, id: `agent-${Date.now()}`, isBuiltIn: false }),
46
- buildUpdate: (updated) => updated,
47
- isDeleteError: (data) => Boolean((data as { error?: string } | null)?.error),
48
- });
33
+ const { agents, selectedId, selected: selectedAgent, isLoading, loadError, reload, select, save, remove } = useAgents(query);
49
34
 
50
- const emptyAgentTemplate: AgentItem = {
51
- id: `new-${Date.now()}`,
52
- name: 'new-agent',
53
- description: '',
54
- scope: 'user',
55
- mode: 'subagent',
56
- overrideModel: 'Not selected',
57
- thinkingVariant: 'default',
58
- temperature: null,
59
- topP: null,
60
- systemPrompt: 'You are a specialized assistant...',
61
- isBuiltIn: false,
62
- };
63
-
64
- // A different scope is a different list: `useCrudList` re-reads when the query
65
- // changes and resolves its selection against the new list, so no extra reset
66
- // is needed here.
67
35
  if (isLoading) {
68
- return <LoadingState>Loading agents…</LoadingState>;
36
+ return <LoadingState>Reading omp’s agent definitions…</LoadingState>;
69
37
  }
70
38
 
71
39
  return (
@@ -77,35 +45,40 @@ export const AgentSettings: FunctionComponent<AgentSettingsProps> = () => {
77
45
  list={
78
46
  <AgentSidebarList
79
47
  agents={agents}
80
- selectedAgentId={isCreatingNew ? null : selectedId}
48
+ selectedAgentId={isCreating ? null : selectedId}
81
49
  onSelectAgent={(id) => {
50
+ setIsCreating(false);
82
51
  select(id);
83
52
  masterDetail.openDetail();
84
53
  }}
85
54
  onAddNewAgent={() => {
86
- startCreate();
55
+ setIsCreating(true);
87
56
  masterDetail.openDetail();
88
57
  }}
89
58
  selectedProject={selectedRootId}
90
59
  onChangeProject={setSelectedRootId}
91
60
  projectOptions={roots.options}
61
+ {...(loadError ? { loadError, onRetry: reload } : {})}
92
62
  />
93
63
  }
94
64
  detail={
95
65
  <div className="flex-1 h-full overflow-hidden flex flex-col">
96
- {isCreatingNew ? (
66
+ {isCreating ? (
97
67
  <AgentDetailPane
98
- agent={emptyAgentTemplate}
68
+ agent={emptyAgentTemplate()}
99
69
  isNew={true}
100
- onSave={save}
70
+ onSave={(draft) => save(draft)}
101
71
  />
102
72
  ) : selectedAgent ? (
103
73
  <AgentDetailPane
104
74
  key={selectedAgent.id}
105
75
  agent={selectedAgent}
106
- isNew={false}
107
- onSave={save}
108
- onDelete={remove}
76
+ onSave={(draft) => save(draft, selectedAgent.fileName)}
77
+ onDelete={async (agent) => {
78
+ const outcome = await remove(agent);
79
+ if (outcome.ok) masterDetail.back();
80
+ return outcome;
81
+ }}
109
82
  />
110
83
  ) : (
111
84
  <div className="flex-1 flex items-center justify-center px-6 text-center text-xs text-ink/40">
@@ -37,7 +37,7 @@ export const CommandSettings: FunctionComponent<CommandSettingsProps> = () => {
37
37
  const query = roots.queryFor(selectedRootId);
38
38
  const isWorkspaceScope = roots.isWorkspace(selectedRootId);
39
39
 
40
- const { items: commands, selectedId, selected: selectedCommand, isCreatingNew, isLoading, select, startCreate, save, remove } =
40
+ const { items: commands, selectedId, selected: selectedCommand, isCreatingNew, isLoading, loadError, reload, select, startCreate, save, remove } =
41
41
  useCrudList<CommandItem>({
42
42
  endpoint: '/api/settings/commands',
43
43
  query,
@@ -64,7 +64,6 @@ export const CommandSettings: FunctionComponent<CommandSettingsProps> = () => {
64
64
  scope: isWorkspaceScope ? 'project' : 'user',
65
65
  }),
66
66
  buildUpdate: (updated) => updated,
67
- isDeleteError: (data) => Boolean((data as { error?: string } | null)?.error),
68
67
  });
69
68
 
70
69
  const emptyCommandTemplate: CommandItem = {
@@ -103,6 +102,7 @@ export const CommandSettings: FunctionComponent<CommandSettingsProps> = () => {
103
102
  selectedProject={selectedRootId}
104
103
  onChangeProject={setSelectedRootId}
105
104
  projectOptions={roots.options}
105
+ {...(loadError ? { loadError, onRetry: reload } : {})}
106
106
  />
107
107
  }
108
108
  detail={
@@ -1,6 +1,6 @@
1
1
  import { useMemo, useState } from 'preact/hooks';
2
2
  import type { FunctionComponent } from 'preact/compat';
3
- import type { McpServerItem, SettingsState } from '@/shared/types';
3
+ import type { McpServerItem, SettingsState, WriteOutcome } from '@/shared/types';
4
4
  import { McpSidebarList } from '@/client/components/settings/categories/mcp-settings/SidebarList';
5
5
  import type { McpProjectOption } from '@/client/components/settings/categories/mcp-settings/SidebarList';
6
6
  import { McpDetailPane } from '@/client/components/settings/categories/mcp-settings/DetailPane';
@@ -33,7 +33,7 @@ export const McpSettings: FunctionComponent<McpSettingsProps> = () => {
33
33
 
34
34
  const query = selectedProject ? `?project=${encodeURIComponent(selectedProject)}` : '';
35
35
 
36
- const { items: servers, selectedId, selected: selectedServer, isCreatingNew, isLoading, select, startCreate, save, remove } =
36
+ const { items: servers, selectedId, selected: selectedServer, isCreatingNew, isLoading, loadError, reload, select, startCreate, save, remove } =
37
37
  useCrudList<McpServerItem>({
38
38
  endpoint: '/api/settings/mcp',
39
39
  listKey: 'servers',
@@ -62,27 +62,9 @@ export const McpSettings: FunctionComponent<McpSettingsProps> = () => {
62
62
  const saved = list.find((s) => s.name.toLowerCase() === target.name.toLowerCase());
63
63
  return saved?.id ?? target.id;
64
64
  },
65
- isSaveError: (data) => {
66
- const error = (data as { error?: string } | null)?.error;
67
- if (error) {
68
- console.error('Failed to save MCP server via API:', error);
69
- return true;
70
- }
71
- return false;
72
- },
73
- isDeleteError: (data) => {
74
- const error = (data as { error?: string } | null)?.error;
75
- if (error) {
76
- console.error('Failed to delete MCP server via API:', error);
77
- return true;
78
- }
79
- return false;
80
- },
81
65
  });
82
66
 
83
- const handleImportServer = (imported: McpServerItem) => {
84
- save(imported);
85
- };
67
+ const handleImportServer = (imported: McpServerItem): Promise<WriteOutcome> => save(imported);
86
68
 
87
69
  const emptyServerTemplate: McpServerItem = {
88
70
  id: `new-${Date.now()}`,
@@ -120,6 +102,7 @@ export const McpSettings: FunctionComponent<McpSettingsProps> = () => {
120
102
  }}
121
103
  selectedProject={selectedProject}
122
104
  onChangeProject={setSelectedProject}
105
+ {...(loadError ? { loadError, onRetry: reload } : {})}
123
106
  />
124
107
  }
125
108
  detail={