@kabmo-labs/kabmo 0.17.0 → 0.18.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (269) hide show
  1. package/dist/client/index.html +1 -1
  2. package/dist/client/index.js +538 -457
  3. package/dist/client/static/js/index-hp75vsv9.css +1 -0
  4. package/dist/client/static/js/{index-rerjq5th.js → index-tc09dtca.js} +823 -814
  5. package/package.json +1 -1
  6. package/src/client/components/common/MarkdownRenderer.tsx +136 -89
  7. package/src/client/components/common/anchored-menu/index.test.tsx +141 -0
  8. package/src/client/components/common/anchored-menu/index.tsx +143 -0
  9. package/src/client/components/common/markdown-review/ReviewPopover.tsx +144 -0
  10. package/src/client/components/common/markdown-review/ReviewSummary.tsx +108 -0
  11. package/src/client/components/common/markdown-review/index.tsx +129 -0
  12. package/src/client/components/common/server-control/Panel.tsx +33 -23
  13. package/src/client/components/common/server-control/index.test.tsx +11 -5
  14. package/src/client/components/common/server-control/index.tsx +10 -8
  15. package/src/client/components/layout/session-sidebar/CategoryHeader.tsx +42 -21
  16. package/src/client/components/layout/session-sidebar/CategoryHeader.worktree.test.tsx +36 -17
  17. package/src/client/components/layout/session-sidebar/CategoryItem.tsx +8 -7
  18. package/src/client/components/layout/session-sidebar/about-modal/NotesDialog.tsx +94 -0
  19. package/src/client/components/layout/session-sidebar/about-modal/VersionLine.test.tsx +68 -0
  20. package/src/client/components/layout/session-sidebar/about-modal/VersionLine.tsx +36 -0
  21. package/src/client/components/layout/session-sidebar/about-modal/index.tsx +57 -34
  22. package/src/client/components/layout/session-sidebar/modern/WorkspaceHeader.tsx +28 -10
  23. package/src/client/components/layout/session-sidebar/modern/WorkspaceSection.tsx +7 -6
  24. package/src/client/components/layout/session-sidebar/modern/workspace-header.test.tsx +1 -1
  25. package/src/client/components/layout/update-popup/ReleaseNotes.tsx +8 -3
  26. package/src/client/components/layout/update-popup/index.tsx +5 -1
  27. package/src/client/components/mobile/mobile-right-sidebar/FullEditor.tsx +13 -15
  28. package/src/client/components/mobile/mobile-right-sidebar/Header.tsx +23 -1
  29. package/src/client/components/mobile/mobile-right-sidebar/MissingFileBanner.tsx +30 -0
  30. package/src/client/components/mobile/mobile-right-sidebar/PreviewScroller.tsx +18 -2
  31. package/src/client/components/mobile/mobile-session-sidebar/Item.tsx +22 -67
  32. package/src/client/components/mobile/mobile-session-sidebar/ItemMenu.tsx +110 -0
  33. package/src/client/components/settings/SettingsSidebarList.tsx +20 -0
  34. package/src/client/components/settings/categories/AgentSettings.tsx +23 -50
  35. package/src/client/components/settings/categories/CommandSettings.tsx +2 -2
  36. package/src/client/components/settings/categories/McpSettings.tsx +4 -21
  37. package/src/client/components/settings/categories/OmpSettings.tsx +147 -194
  38. package/src/client/components/settings/categories/SkillSettings.tsx +2 -2
  39. package/src/client/components/settings/categories/TokenUsageSettings.tsx +211 -229
  40. package/src/client/components/settings/categories/agent-settings/DetailPane.tsx +229 -237
  41. package/src/client/components/settings/categories/agent-settings/ModelPicker.tsx +71 -0
  42. package/src/client/components/settings/categories/agent-settings/SidebarList.tsx +9 -2
  43. package/src/client/components/settings/categories/agent-settings/levels.ts +38 -0
  44. package/src/client/components/settings/categories/behavior-settings/Editor.tsx +27 -7
  45. package/src/client/components/settings/categories/chat-settings/ToolRenderSection.tsx +23 -5
  46. package/src/client/components/settings/categories/command-settings/DetailPane.tsx +75 -33
  47. package/src/client/components/settings/categories/command-settings/SidebarList.tsx +7 -0
  48. package/src/client/components/settings/categories/mcp-settings/DetailPane.tsx +91 -76
  49. package/src/client/components/settings/categories/mcp-settings/EnvVarsSection.tsx +83 -0
  50. package/src/client/components/settings/categories/mcp-settings/ImportModal.tsx +26 -13
  51. package/src/client/components/settings/categories/mcp-settings/SidebarList.tsx +20 -0
  52. package/src/client/components/settings/categories/omp-settings/ConfigTabs.tsx +97 -36
  53. package/src/client/components/settings/categories/omp-settings/EngineHeader.tsx +151 -0
  54. package/src/client/components/settings/categories/omp-settings/ExtensionsPanel.tsx +68 -32
  55. package/src/client/components/settings/categories/omp-settings/OrderedChips.tsx +119 -0
  56. package/src/client/components/settings/categories/omp-settings/PresetBar.tsx +14 -7
  57. package/src/client/components/settings/categories/omp-settings/RoleEditor.tsx +15 -6
  58. package/src/client/components/settings/categories/omp-settings/RowEditor.tsx +165 -226
  59. package/src/client/components/settings/categories/omp-settings/types.ts +28 -0
  60. package/src/client/components/settings/categories/skill-settings/DetailHeader.tsx +35 -7
  61. package/src/client/components/settings/categories/skill-settings/DetailPane.tsx +34 -14
  62. package/src/client/components/settings/categories/skill-settings/SidebarList.tsx +21 -0
  63. package/src/client/components/settings/categories/skill-settings/pane.test.tsx +15 -6
  64. package/src/client/components/settings/categories/token-usage-settings/Breakdown.tsx +242 -102
  65. package/src/client/components/settings/categories/token-usage-settings/Chart.tsx +130 -56
  66. package/src/client/components/settings/categories/token-usage-settings/Controls.tsx +135 -0
  67. package/src/client/components/settings/categories/token-usage-settings/MetricsGrid.tsx +55 -33
  68. package/src/client/components/settings/categories/token-usage-settings/Provenance.tsx +59 -0
  69. package/src/client/components/settings/categories/token-usage-settings/panel.test.tsx +239 -0
  70. package/src/client/components/workspace/browser-panel/Screencast.test.ts +1 -0
  71. package/src/client/components/workspace/browser-panel/Screencast.tsx +17 -22
  72. package/src/client/components/workspace/browser-panel/TabStrip.test.tsx +158 -0
  73. package/src/client/components/workspace/browser-panel/TabStrip.tsx +90 -0
  74. package/src/client/components/workspace/browser-panel/index.tsx +50 -4
  75. package/src/client/components/workspace/browser-toolbar/index.tsx +41 -1
  76. package/src/client/components/workspace/chat-timeline/ThinkingSection.tsx +3 -1
  77. package/src/client/components/workspace/chat-timeline/ToolCallingSection.tsx +2 -0
  78. package/src/client/components/workspace/chat-timeline/block-chrome.test.tsx +13 -2
  79. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Bash.test.ts +88 -0
  80. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Bash.tsx +24 -1
  81. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Read.test.ts +34 -0
  82. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Read.tsx +5 -1
  83. package/src/client/components/workspace/chat-timeline/tool-renderers/shared/ArtifactChip.tsx +7 -6
  84. package/src/client/components/workspace/chat-timeline/tool-renderers/styles/Tui.test.tsx +237 -0
  85. package/src/client/components/workspace/chat-timeline/tool-renderers/styles/Tui.tsx +191 -0
  86. package/src/client/components/workspace/chat-timeline/tool-renderers/styles/styles.test.tsx +1 -1
  87. package/src/client/components/workspace/diff-panel/MergeDiffView.tsx +21 -7
  88. package/src/client/components/workspace/diff-panel/changes.test.ts +51 -0
  89. package/src/client/components/workspace/diff-panel/changes.ts +28 -12
  90. package/src/client/components/workspace/diff-panel/merge.test.ts +28 -0
  91. package/src/client/components/workspace/diff-panel/merge.ts +21 -1
  92. package/src/client/components/workspace/editor/Body.tsx +7 -0
  93. package/src/client/components/workspace/editor/FileDocument.tsx +15 -21
  94. package/src/client/components/workspace/editor/FilePane.tsx +12 -0
  95. package/src/client/components/workspace/editor/PreviewPane.tsx +70 -0
  96. package/src/client/components/workspace/editor/Toolbar.tsx +17 -1
  97. package/src/client/components/workspace/editor/index.tsx +25 -22
  98. package/src/client/components/workspace/editor/toolbar-clusters.test.ts +14 -0
  99. package/src/client/components/workspace/editor/toolbar-clusters.tsx +12 -86
  100. package/src/client/components/workspace/editor/toolbar-toggle.tsx +53 -0
  101. package/src/client/components/workspace/editor/toolbar-write-clusters.tsx +112 -0
  102. package/src/client/components/workspace/git-panel/commit-modal.test.ts +5 -3
  103. package/src/client/components/workspace/user-browser-panel/AddressBar.tsx +5 -0
  104. package/src/client/components/workspace/user-browser-panel/AnnotateBar.test.tsx +201 -0
  105. package/src/client/components/workspace/user-browser-panel/AnnotateBar.tsx +112 -0
  106. package/src/client/components/workspace/user-browser-panel/AnnotateLayer.test.tsx +225 -0
  107. package/src/client/components/workspace/user-browser-panel/AnnotateLayer.tsx +217 -0
  108. package/src/client/components/workspace/user-browser-panel/AnnotateTarget.tsx +99 -0
  109. package/src/client/components/workspace/user-browser-panel/Frame.tsx +30 -1
  110. package/src/client/components/workspace/user-browser-panel/index.tsx +81 -2
  111. package/src/client/data/agent-data/builtin.ts +0 -10
  112. package/src/client/data/agent-data/orchestrator.ts +0 -45
  113. package/src/client/data/agent-data/specialist.ts +0 -100
  114. package/src/client/data/mock/token-usage.ts +170 -120
  115. package/src/client/data/settings/omp-schema.json +33 -1
  116. package/src/client/hooks/browser/use-annotate.test.ts +143 -0
  117. package/src/client/hooks/browser/use-annotate.ts +98 -0
  118. package/src/client/hooks/browser/use-close-tab.test.ts +148 -0
  119. package/src/client/hooks/browser/use-close-tab.ts +67 -0
  120. package/src/client/hooks/browser/use-screencast.ts +13 -1
  121. package/src/client/hooks/chat/composer/browser-context.test.ts +117 -0
  122. package/src/client/hooks/chat/composer/browser-context.ts +40 -16
  123. package/src/client/hooks/chat/composer/items.test.ts +1 -1
  124. package/src/client/hooks/chat/composer/review-context.ts +38 -0
  125. package/src/client/hooks/chat/composer/use-draft.test.ts +132 -0
  126. package/src/client/hooks/chat/composer/use-draft.ts +31 -2
  127. package/src/client/hooks/chat/timeline/row-window.test.ts +15 -2
  128. package/src/client/hooks/editor/use-document-annotations.ts +124 -0
  129. package/src/client/hooks/editor/use-editor-panel-ui.ts +52 -0
  130. package/src/client/hooks/editor/use-file-review-mode.ts +35 -0
  131. package/src/client/hooks/editor/use-preview-review.ts +148 -0
  132. package/src/client/hooks/settings/agents.ts +149 -0
  133. package/src/client/hooks/settings/crud-list.test.ts +28 -6
  134. package/src/client/hooks/settings/crud-list.ts +96 -57
  135. package/src/client/hooks/settings/omp-config.ts +164 -0
  136. package/src/client/hooks/settings/useTokenUsage.ts +125 -0
  137. package/src/client/hooks/settings/write-feedback.test.ts +104 -0
  138. package/src/client/hooks/settings/write-feedback.ts +63 -0
  139. package/src/client/hooks/ui/markdown-hydration.ts +125 -0
  140. package/src/client/hooks/ui/updates/index.test.ts +100 -1
  141. package/src/client/hooks/ui/updates/index.ts +50 -0
  142. package/src/client/hooks/ui/updates/notes.test.ts +138 -0
  143. package/src/client/hooks/ui/updates/notes.ts +57 -0
  144. package/src/client/lib/browser/element-at.test.ts +229 -0
  145. package/src/client/lib/browser/element-at.ts +139 -0
  146. package/src/client/lib/review/client.ts +73 -0
  147. package/src/client/lib/router/search-params.ts +42 -20
  148. package/src/client/tailwind.css +65 -0
  149. package/src/server/lib/btw/lifecycle.server.ts +2 -2
  150. package/src/server/lib/db/schema.ts +7 -0
  151. package/src/server/lib/db/seed-terminal.test.ts +4 -0
  152. package/src/server/lib/omp/config/agent-definitions.test.ts +273 -0
  153. package/src/server/lib/omp/config/agents.ts +231 -61
  154. package/src/server/lib/omp/config/definitions.test.ts +9 -105
  155. package/src/server/lib/omp/config/extensions.ts +16 -7
  156. package/src/server/lib/omp/config/omp-config-files.test.ts +27 -0
  157. package/src/server/lib/omp/rpc/constants.test.ts +11 -0
  158. package/src/server/lib/omp/rpc/constants.ts +15 -0
  159. package/src/server/lib/omp/rpc/process.ts +11 -14
  160. package/src/server/lib/omp/rpc/session-commands.ts +6 -3
  161. package/src/server/lib/omp/rpc/utility-agent-dir.test.ts +134 -0
  162. package/src/server/lib/omp/rpc/utility-agent-dir.ts +138 -0
  163. package/src/server/lib/omp/rpc/utility.ts +12 -0
  164. package/src/server/lib/review/schema.server.ts +45 -0
  165. package/src/server/lib/review/store.server.ts +138 -0
  166. package/src/server/lib/terminal/attach-replay.test.ts +132 -0
  167. package/src/server/lib/terminal/output.test.ts +166 -0
  168. package/src/server/lib/terminal/output.ts +104 -0
  169. package/src/server/lib/terminal/runtime.server.ts +5 -0
  170. package/src/server/lib/terminal/send-result.test.ts +33 -0
  171. package/src/server/lib/terminal/send-result.ts +32 -0
  172. package/src/server/lib/terminal/session.server.ts +45 -11
  173. package/src/server/lib/terminal/store-liveness.test.ts +4 -0
  174. package/src/server/lib/updates/active-notes.test.ts +149 -0
  175. package/src/server/lib/updates/active-notes.ts +75 -0
  176. package/src/server/lib/updates/changelog-file.ts +42 -11
  177. package/src/server/lib/updates/changelog.test.ts +15 -1
  178. package/src/server/lib/updates/omp.ts +42 -15
  179. package/src/server/lib/updates/release-url.ts +27 -1
  180. package/src/server/lib/usage/index-parse.test.ts +200 -0
  181. package/src/server/lib/usage/index-parse.ts +178 -0
  182. package/src/server/lib/usage/index-query.server.ts +248 -0
  183. package/src/server/lib/usage/index-scan.server.ts +343 -0
  184. package/src/server/lib/usage/index-schema.server.ts +82 -0
  185. package/src/server/lib/usage/index.test.ts +234 -0
  186. package/src/server/lib/usage/providers.server.ts +4 -53
  187. package/src/server/routes/browser/index.ts +3 -0
  188. package/src/server/routes/browser/stream.ts +31 -2
  189. package/src/server/routes/browser/tabs.test.ts +94 -0
  190. package/src/server/routes/browser/tabs.ts +85 -0
  191. package/src/server/routes/index.ts +2 -0
  192. package/src/server/routes/review/bindings.ts +11 -0
  193. package/src/server/routes/review/index.ts +127 -0
  194. package/src/server/routes/review/routes.test.ts +191 -0
  195. package/src/server/routes/settings/agents.test.ts +180 -0
  196. package/src/server/routes/settings/agents.ts +95 -102
  197. package/src/server/routes/settings/mcp.test.ts +135 -0
  198. package/src/server/routes/settings/mcp.ts +14 -6
  199. package/src/server/routes/settings/settings-store-routes.test.ts +6 -113
  200. package/src/server/routes/telemetry/tokens.test.ts +145 -0
  201. package/src/server/routes/telemetry/tokens.ts +70 -149
  202. package/src/server/routes/terminal/ws.ts +6 -5
  203. package/src/server/routes/updates/index.ts +2 -0
  204. package/src/server/routes/updates/notes.ts +34 -0
  205. package/src/server/routes/updates/routes.test.ts +49 -0
  206. package/src/shared/lib/browser/annotate.test.ts +283 -0
  207. package/src/shared/lib/browser/annotate.ts +231 -0
  208. package/src/shared/lib/browser/browser-viewer.test.ts +26 -4
  209. package/src/shared/lib/browser/frame-gate.test.ts +91 -0
  210. package/src/shared/lib/browser/frame-gate.ts +69 -0
  211. package/src/shared/lib/browser/frame-params.test.ts +43 -0
  212. package/src/shared/lib/browser/frame-params.ts +60 -0
  213. package/src/shared/lib/browser/frame-pipeline.test.ts +132 -0
  214. package/src/shared/lib/browser/frame-pipeline.ts +80 -0
  215. package/src/shared/lib/browser/page-context.ts +60 -4
  216. package/src/shared/lib/browser/snapshot.test.ts +115 -0
  217. package/src/shared/lib/browser/snapshot.ts +112 -0
  218. package/src/shared/lib/browser/tab-close.test.ts +74 -0
  219. package/src/shared/lib/browser/tab-close.ts +77 -0
  220. package/src/shared/lib/browser/viewer.ts +45 -26
  221. package/src/shared/lib/chat/timeline/block-chrome.ts +19 -0
  222. package/src/shared/lib/chat/timeline/tool-render-mode.ts +17 -4
  223. package/src/shared/lib/chat/tool/artifact.ts +55 -20
  224. package/src/shared/lib/chat/tool/bash-facts.ts +96 -0
  225. package/src/shared/lib/chat/tool/minimized.test.ts +98 -0
  226. package/src/shared/lib/chat/tool/minimized.ts +64 -0
  227. package/src/shared/lib/chat/tool/summary.test.ts +28 -8
  228. package/src/shared/lib/chat/tool/summary.ts +3 -32
  229. package/src/shared/lib/markdown/blocks/anchor.ts +63 -0
  230. package/src/shared/lib/markdown/blocks/blocks.test.ts +141 -0
  231. package/src/shared/lib/markdown/blocks/renderer.ts +120 -0
  232. package/src/shared/lib/markdown/blocks/scan.ts +100 -0
  233. package/src/shared/lib/markdown/blocks/types.ts +62 -0
  234. package/src/shared/lib/markdown/marked.ts +58 -147
  235. package/src/shared/lib/markdown/math-extensions.ts +168 -0
  236. package/src/shared/lib/markdown/review/prompt.ts +77 -0
  237. package/src/shared/lib/markdown/review/reconcile.ts +55 -0
  238. package/src/shared/lib/markdown/review/review.test.ts +96 -0
  239. package/src/shared/lib/markdown/xml-sections.test.ts +140 -0
  240. package/src/shared/lib/markdown/xml-sections.ts +139 -0
  241. package/src/shared/lib/models/provider/label.ts +57 -0
  242. package/src/shared/lib/omp/config/agent-file.test.ts +54 -0
  243. package/src/shared/lib/omp/config/agent-file.ts +43 -0
  244. package/src/shared/lib/omp/config/row-value.test.ts +95 -0
  245. package/src/shared/lib/omp/config/row-value.ts +97 -0
  246. package/src/shared/lib/omp/config/schema.test.ts +31 -0
  247. package/src/shared/lib/omp/config/schema.ts +6 -0
  248. package/src/shared/lib/omp/rpc/frame.test.ts +48 -47
  249. package/src/shared/lib/omp/rpc/frame.ts +49 -40
  250. package/src/shared/lib/ui/menu-anchor.test.ts +69 -0
  251. package/src/shared/lib/ui/menu-anchor.ts +89 -0
  252. package/src/shared/lib/usage/breakdown.test.ts +197 -0
  253. package/src/shared/lib/usage/breakdown.ts +241 -0
  254. package/src/shared/lib/usage/range.test.ts +204 -0
  255. package/src/shared/lib/usage/range.ts +240 -0
  256. package/src/shared/lib/usage/view.test.ts +85 -0
  257. package/src/shared/lib/usage/view.ts +74 -0
  258. package/src/shared/types/browser.ts +78 -0
  259. package/src/shared/types/index.ts +1 -0
  260. package/src/shared/types/settings/agent.ts +28 -6
  261. package/src/shared/types/settings/state.ts +4 -3
  262. package/src/shared/types/settings/write.ts +6 -0
  263. package/src/shared/types/tokenUsage.ts +128 -21
  264. package/src/shared/types/updates.ts +20 -0
  265. package/dist/client/static/js/index-3ve31rzx.css +0 -1
  266. package/src/server/lib/omp/session/usage/aggregate-shaping.test.ts +0 -149
  267. package/src/server/lib/omp/session/usage/aggregate.test.ts +0 -243
  268. package/src/server/lib/omp/session/usage/aggregate.ts +0 -330
  269. package/src/server/lib/omp/session/usage/shaping.ts +0 -130
@@ -1,331 +1,323 @@
1
1
  import { useEffect, useState } from 'preact/hooks';
2
2
  import type { FormEvent, FunctionComponent } from 'preact/compat';
3
- import { Check, Copy, Info, Minus, PenTool, Plus, Trash2 } from 'lucide-preact';
4
- import type { AgentItem, AgentMode, AgentScope } from '@/shared/types';
3
+ import { AlertCircle, Check, Copy, Info, Loader2, Save, Trash2 } from 'lucide-preact';
4
+ import type { AgentItem, WriteOutcome } from '@/shared/types';
5
+ import { agentFileNameError } from '@/shared/lib/omp/config/agent-file';
6
+ import { useWriteFeedback } from '@/client/hooks/settings/write-feedback';
7
+ import { AgentModelPicker } from '@/client/components/settings/categories/agent-settings/ModelPicker';
8
+ import { AGENT_THINKING_DEFAULT, AGENT_THINKING_LEVELS } from '@/client/components/settings/categories/agent-settings/levels';
5
9
 
6
10
  interface AgentDetailPaneProps {
7
11
  agent: AgentItem;
8
12
  isNew?: boolean;
9
- onSave: (updatedAgent: AgentItem) => void;
10
- onDelete?: (agentId: string) => void;
13
+ /** The file this definition replaced, when the name changed. */
14
+ previousFileName?: string | null;
15
+ onSave: (agent: AgentItem, previousFileName?: string | null) => Promise<WriteOutcome>;
16
+ onDelete?: (agent: AgentItem) => Promise<WriteOutcome>;
11
17
  }
12
18
 
13
- const AVAILABLE_MODELS = [
14
- 'Not selected',
15
- 'claude-3-7-sonnet-20250219',
16
- 'claude-3-5-sonnet-20241022',
17
- 'claude-3-5-haiku-20241022',
18
- 'gpt-4o',
19
- 'gpt-4o-mini',
20
- 'o3-mini',
21
- 'gemini-2.5-pro-preview-03-25',
22
- 'gemini-2.5-flash',
23
- 'deepseek-chat-v3',
24
- 'deepseek-reasoner-r1',
25
- ];
26
-
19
+ /**
20
+ * One agent definition, as the markdown file omp loads.
21
+ *
22
+ * Every control here corresponds to a key omp's own `parseAgentFields` reads
23
+ * (`name`, `description`, `model`, `thinkingLevel`, `tools`, `spawns`) or to the
24
+ * file body, which becomes the system prompt. That is deliberate: the pane used
25
+ * to offer `mode`, `temperature` and `topP`, and omp ignores all three — editing
26
+ * them changed a file to no effect, which is the worst kind of control.
27
+ *
28
+ * The file IS the agent, so creating one here writes it, and the tool allowlist
29
+ * and `spawns` are edited as the CSV omp reads rather than re-serialized from a
30
+ * record (that is what would drop a shipped agent's block-list `tools:`).
31
+ *
32
+ * Project agents stay read-only: that directory belongs to the workspace.
33
+ */
27
34
  export const AgentDetailPane: FunctionComponent<AgentDetailPaneProps> = ({
28
35
  agent,
29
36
  isNew = false,
37
+ previousFileName = null,
30
38
  onSave,
31
39
  onDelete,
32
40
  }) => {
33
41
  const [formData, setFormData] = useState<AgentItem>(agent);
34
- const [savedSuccess, setSavedSuccess] = useState(false);
42
+ const [toolsText, setToolsText] = useState((agent.tools ?? []).join(', '));
35
43
  const [copiedPrompt, setCopiedPrompt] = useState(false);
44
+ const [confirmDelete, setConfirmDelete] = useState(false);
45
+ const feedback = useWriteFeedback();
46
+
47
+ const readOnly = agent.sourceRoot === 'project';
36
48
 
37
49
  useEffect(() => {
38
50
  setFormData(agent);
39
- setSavedSuccess(false);
51
+ setToolsText((agent.tools ?? []).join(', '));
52
+ setConfirmDelete(false);
40
53
  }, [agent]);
41
54
 
42
- const handleSave = (e: FormEvent) => {
43
- e.preventDefault();
44
- onSave(formData);
45
- setSavedSuccess(true);
46
- setTimeout(() => setSavedSuccess(false), 2000);
47
- };
55
+ /** The name becomes the file name, and a blank prompt writes an agent that does nothing. */
56
+ const validationError = (() => {
57
+ if (readOnly) return null;
58
+ const nameError = agentFileNameError(formData.name);
59
+ if (nameError) return nameError;
60
+ if (!formData.systemPrompt.trim()) return 'A system prompt is required — an empty agent does nothing.';
61
+ return null;
62
+ })();
48
63
 
49
- const handleCopyPrompt = () => {
50
- navigator.clipboard.writeText(formData.systemPrompt);
51
- setCopiedPrompt(true);
52
- setTimeout(() => setCopiedPrompt(false), 1800);
53
- };
64
+ const dirty =
65
+ formData.name !== agent.name
66
+ || formData.description !== agent.description
67
+ || (formData.model ?? '') !== (agent.model ?? '')
68
+ || (formData.thinkingLevel ?? '') !== (agent.thinkingLevel ?? '')
69
+ || (formData.spawns ?? '') !== (agent.spawns ?? '')
70
+ || toolsText !== (agent.tools ?? []).join(', ')
71
+ || formData.systemPrompt !== agent.systemPrompt;
54
72
 
55
- const adjustTemp = (delta: number) => {
56
- setFormData((prev) => {
57
- const current = prev.temperature ?? 0.7;
58
- const next = Math.max(0, Math.min(2.0, parseFloat((current + delta).toFixed(2))));
59
- return { ...prev, temperature: next };
60
- });
73
+ const handleSave = (event: FormEvent) => {
74
+ event.preventDefault();
75
+ if (readOnly || validationError || feedback.saving) return;
76
+ // An UNTOUCHED tools field sends `undefined`, so the file keeps its own
77
+ // block-list form: re-sending the same names as CSV rewrote a shipped
78
+ // agent's `tools:\n - read` into one line for no reason.
79
+ const toolsChanged = toolsText.trim() !== (agent.tools ?? []).join(', ');
80
+ const tools = toolsChanged
81
+ ? toolsText.split(',').map((name) => name.trim()).filter(Boolean)
82
+ : undefined;
83
+ void feedback.run(() => onSave({ ...formData, name: formData.name.trim(), tools }, previousFileName));
61
84
  };
62
85
 
63
- const adjustTopP = (delta: number) => {
64
- setFormData((prev) => {
65
- const current = prev.topP ?? 0.95;
66
- const next = Math.max(0, Math.min(1.0, parseFloat((current + delta).toFixed(2))));
67
- return { ...prev, topP: next };
86
+ const handleDelete = () => {
87
+ if (!onDelete) return;
88
+ void feedback.run(async () => {
89
+ const outcome = await onDelete(agent);
90
+ if (!outcome.ok) setConfirmDelete(false);
91
+ return outcome;
68
92
  });
69
93
  };
70
94
 
71
95
  return (
72
96
  <form onSubmit={handleSave} className="flex-1 flex flex-col h-full scrollbar-overlay-container bg-paper text-ink p-6 md:p-8 space-y-6">
73
- {/* SECTION 1: Identity & Role */}
97
+ {readOnly && (
98
+ <div className="rounded-lg border border-ink/15 bg-ink/5 px-3 py-2 text-[11px] leading-relaxed text-ink/70">
99
+ This agent is defined by the workspace at{' '}
100
+ <span className="font-mono text-ink/80">{agent.filePath}</span>. It is listed here and stays read-only:
101
+ that <span className="font-mono">.omp/agents</span> directory belongs to the project.
102
+ </div>
103
+ )}
104
+
74
105
  <div className="space-y-3">
75
- <div className="flex items-center justify-between">
76
- <h2 className="text-xs font-bold uppercase tracking-wider text-ink">
77
- Identity & Role
78
- </h2>
79
- {formData.isBuiltIn && (
80
- <span className="text-[10px] font-mono px-2 py-0.5 rounded-md bg-ink/5 border border-ink/10 text-ink/60">
81
- Built-in System Agent (Read-only System Core)
106
+ <div className="flex items-center justify-between gap-2">
107
+ <h2 className="text-xs font-bold uppercase tracking-wider text-ink">Identity &amp; Role</h2>
108
+ {agent.fileName && (
109
+ <span className="truncate font-mono text-[10px] text-ink/40" title={agent.filePath}>
110
+ {agent.sourceRoot === 'project' ? '.omp/agents' : '~/.omp/agent/agents'}/{agent.fileName}.md
82
111
  </span>
83
112
  )}
84
113
  </div>
85
114
 
86
- {/* Name and Scope row */}
87
- <div className="flex items-center gap-3">
88
- <div className="flex-1">
89
- <label className="block text-xs font-semibold text-ink/80 mb-1.5">
90
- Agent Name
91
- </label>
92
- <div className="flex items-center border border-ink/20 hover:border-ink/40 focus-within:border-ink rounded-lg bg-paper transition-colors">
93
- <span className="px-3 py-2 font-mono text-xs text-ink/40 border-r border-ink/15 select-none">
94
- @
95
- </span>
96
- <input
97
- type="text"
98
- value={formData.name}
99
- onChange={(e) => setFormData({ ...formData, name: e.currentTarget.value })}
100
- required
101
- placeholder="agent-name"
102
- disabled={formData.isBuiltIn}
103
- className="w-full text-xs font-mono px-3 py-2 bg-transparent focus:outline-none disabled:opacity-60 text-ink"
104
- />
105
- </div>
106
- </div>
107
-
108
- <div className="w-40">
109
- <label className="block text-xs font-semibold text-ink/80 mb-1.5">
110
- Scope
111
- </label>
112
- <select
113
- value={formData.scope}
114
- onChange={(e) => setFormData({ ...formData, scope: e.currentTarget.value as AgentScope })}
115
- disabled={formData.isBuiltIn}
116
- className="w-full text-xs py-2 px-3 rounded-lg border border-ink/20 hover:border-ink/40 bg-paper focus:outline-none focus:border-ink disabled:opacity-60 text-ink transition-colors cursor-pointer"
117
- >
118
- <option value="user">user</option>
119
- <option value="project">project</option>
120
- <option value="system">system</option>
121
- </select>
122
- </div>
115
+ <div>
116
+ <label className="mb-1.5 block text-xs font-semibold text-ink/80">Agent name</label>
117
+ <input
118
+ type="text"
119
+ value={formData.name}
120
+ onInput={(e) => setFormData({ ...formData, name: e.currentTarget.value })}
121
+ required
122
+ placeholder="agent-name"
123
+ disabled={readOnly || feedback.saving}
124
+ aria-invalid={agentFileNameError(formData.name) ? true : undefined}
125
+ className="w-full rounded-lg border border-ink/20 bg-paper px-3 py-2 font-mono text-xs text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none disabled:opacity-60"
126
+ />
127
+ <p className="mt-1 text-[10px] text-ink/45">
128
+ The file name omp loads it from — letters, numbers, dots, dashes, underscores.
129
+ </p>
123
130
  </div>
124
131
 
125
- {/* Description */}
126
132
  <div>
127
- <label className="block text-xs font-semibold text-ink/80 mb-1.5">
128
- Description
129
- </label>
133
+ <label className="mb-1.5 block text-xs font-semibold text-ink/80">Description</label>
130
134
  <textarea
131
135
  value={formData.description}
132
- onChange={(e) => setFormData({ ...formData, description: e.currentTarget.value })}
133
- placeholder="What does this agent do?"
136
+ onInput={(e) => setFormData({ ...formData, description: e.currentTarget.value })}
137
+ placeholder="What does this agent do? Shown when omp lists it."
134
138
  rows={2}
135
- className="w-full text-xs p-3 rounded-lg border border-ink/20 hover:border-ink/40 bg-paper focus:outline-none focus:border-ink placeholder:text-ink/30 text-ink transition-colors"
139
+ disabled={readOnly || feedback.saving}
140
+ className="w-full rounded-lg border border-ink/20 bg-paper p-3 text-xs text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none placeholder:text-ink/30 disabled:opacity-60"
136
141
  />
137
- </div>
138
-
139
- {/* Mode Segmented Pills */}
140
- <div>
141
- <div className="flex items-center gap-1.5 mb-1.5">
142
- <label className="text-xs font-semibold text-ink/80">Mode</label>
143
- <span title="Defines agent delegation context (primary, subagent, or all)">
144
- <Info className="w-3.5 h-3.5 text-ink/40" />
145
- </span>
146
- </div>
147
- <div className="inline-flex rounded-lg border border-ink/15 p-0.5 bg-ink/5">
148
- {(['primary', 'subagent', 'all'] as AgentMode[]).map((mode) => (
149
- <button
150
- type="button"
151
- key={mode}
152
- onClick={() => setFormData({ ...formData, mode })}
153
- className={`px-3 py-1 text-xs rounded-md transition-colors cursor-pointer capitalize ${
154
- formData.mode === mode
155
- ? 'bg-paper text-ink shadow-xs font-semibold'
156
- : 'text-ink/60 hover:text-ink'
157
- }`}
158
- >
159
- {mode}
160
- </button>
161
- ))}
162
- </div>
142
+ <p className="mt-1 text-[10px] text-ink/45">
143
+ Required by omp: a definition without a description is not loaded at all.
144
+ </p>
163
145
  </div>
164
146
  </div>
165
147
 
166
148
  <div className="border-t border-ink/10" />
167
149
 
168
- {/* SECTION 2: Model & Parameters */}
169
150
  <div className="space-y-3">
170
- <h2 className="text-xs font-bold uppercase tracking-wider text-ink">
171
- Model & Parameters
172
- </h2>
173
-
174
- <div className="grid grid-cols-1 md:grid-cols-2 gap-4">
175
- {/* Override Model */}
151
+ <h2 className="text-xs font-bold uppercase tracking-wider text-ink">Model &amp; Capabilities</h2>
152
+ <div className="grid grid-cols-1 gap-4 md:grid-cols-2">
176
153
  <div>
177
- <label className="block text-xs font-semibold text-ink/80 mb-1.5">
178
- Override Model
179
- </label>
180
- <div className="flex items-center border border-ink/20 hover:border-ink/40 focus-within:border-ink rounded-lg bg-paper transition-colors">
181
- <span className="px-2.5 text-ink/40">
182
- <PenTool className="w-3.5 h-3.5" />
154
+ <div className="mb-1.5 flex items-center gap-1">
155
+ <label className="text-xs font-semibold text-ink/80">Model</label>
156
+ <span title="A provider/model selector from the live catalog. Leave it unselected to inherit the session model.">
157
+ <Info className="h-3.5 w-3.5 text-ink/40" />
183
158
  </span>
184
- <select
185
- value={formData.overrideModel || 'Not selected'}
186
- onChange={(e) => setFormData({ ...formData, overrideModel: e.currentTarget.value })}
187
- className="w-full text-xs font-mono py-2 pr-3 bg-transparent focus:outline-none cursor-pointer text-ink"
188
- >
189
- {AVAILABLE_MODELS.map((m) => (
190
- <option key={m} value={m}>
191
- {m}
192
- </option>
193
- ))}
194
- </select>
195
159
  </div>
160
+ <AgentModelPicker
161
+ value={formData.model ?? ''}
162
+ disabled={readOnly || feedback.saving}
163
+ onChange={(selector) => setFormData({ ...formData, model: selector || undefined })}
164
+ />
196
165
  </div>
197
166
 
198
- {/* Thinking Variant */}
199
167
  <div>
200
- <div className="flex items-center gap-1 mb-1.5">
201
- <label className="text-xs font-semibold text-ink/80">Thinking Variant</label>
202
- <span title="Controls chain-of-thought token depth">
203
- <Info className="w-3.5 h-3.5 text-ink/40" />
168
+ <div className="mb-1.5 flex items-center gap-1">
169
+ <label className="text-xs font-semibold text-ink/80">Thinking level</label>
170
+ <span title="An omp thinking selector. “inherit” leaves the level to the session.">
171
+ <Info className="h-3.5 w-3.5 text-ink/40" />
204
172
  </span>
205
173
  </div>
206
- <input
207
- type="text"
208
- value={formData.thinkingVariant || 'default'}
209
- onChange={(e) => setFormData({ ...formData, thinkingVariant: e.currentTarget.value })}
210
- placeholder="default"
211
- className="w-full text-xs font-mono px-3 py-2 rounded-lg border border-ink/20 hover:border-ink/40 bg-paper focus:outline-none focus:border-ink text-ink transition-colors"
212
- />
174
+ <select
175
+ aria-label="Thinking level"
176
+ value={formData.thinkingLevel ?? AGENT_THINKING_DEFAULT}
177
+ onChange={(e) => setFormData({ ...formData, thinkingLevel: e.currentTarget.value || undefined })}
178
+ disabled={readOnly || feedback.saving}
179
+ className="w-full cursor-pointer rounded-lg border border-ink/20 bg-paper py-2 pl-2 pr-3 font-mono text-xs text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none disabled:opacity-60"
180
+ >
181
+ <option value={AGENT_THINKING_DEFAULT}>inherit (session level)</option>
182
+ {AGENT_THINKING_LEVELS.map((level) => (
183
+ <option key={level} value={level}>{level}</option>
184
+ ))}
185
+ </select>
213
186
  </div>
214
187
 
215
- {/* Temperature Stepper */}
216
188
  <div>
217
- <div className="flex items-center gap-1 mb-1.5">
218
- <label className="text-xs font-semibold text-ink/80">Temperature</label>
219
- <span title="Higher values make output more random, lower values more deterministic">
220
- <Info className="w-3.5 h-3.5 text-ink/40" />
189
+ <div className="mb-1.5 flex items-center gap-1">
190
+ <label className="text-xs font-semibold text-ink/80">Tools</label>
191
+ <span title="Comma-separated tool names. Empty means omp's default set for this kind of agent.">
192
+ <Info className="h-3.5 w-3.5 text-ink/40" />
221
193
  </span>
222
194
  </div>
223
- <div className="flex items-center border border-ink/20 rounded-lg max-w-[150px] bg-paper overflow-hidden">
224
- <button
225
- type="button"
226
- onClick={() => adjustTemp(-0.05)}
227
- className="px-3 py-1.5 text-ink/60 hover:text-ink hover:bg-ink/5 transition-colors cursor-pointer"
228
- >
229
- <Minus className="w-3.5 h-3.5" />
230
- </button>
231
- <span className="flex-1 text-center font-mono text-xs font-medium text-ink">
232
- {formData.temperature != null ? formData.temperature.toFixed(2) : '—'}
233
- </span>
234
- <button
235
- type="button"
236
- onClick={() => adjustTemp(0.05)}
237
- className="px-3 py-1.5 text-ink/60 hover:text-ink hover:bg-ink/5 transition-colors cursor-pointer"
238
- >
239
- <Plus className="w-3.5 h-3.5" />
240
- </button>
241
- </div>
195
+ <input
196
+ type="text"
197
+ value={toolsText}
198
+ onInput={(e) => setToolsText(e.currentTarget.value)}
199
+ placeholder="read, grep, glob, edit"
200
+ disabled={readOnly || feedback.saving}
201
+ className="w-full rounded-lg border border-ink/20 bg-paper px-3 py-2 font-mono text-xs text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none placeholder:text-ink/30 disabled:opacity-60"
202
+ />
242
203
  </div>
243
204
 
244
- {/* Top P Stepper */}
245
205
  <div>
246
- <div className="flex items-center gap-1 mb-1.5">
247
- <label className="text-xs font-semibold text-ink/80">Top P</label>
248
- <span title="Nucleus sampling cutoff">
249
- <Info className="w-3.5 h-3.5 text-ink/40" />
206
+ <div className="mb-1.5 flex items-center gap-1">
207
+ <label className="text-xs font-semibold text-ink/80">Spawns</label>
208
+ <span title="Which agents this one may delegate to: * for any, or a comma-separated list.">
209
+ <Info className="h-3.5 w-3.5 text-ink/40" />
250
210
  </span>
251
211
  </div>
252
- <div className="flex items-center border border-ink/20 rounded-lg max-w-[150px] bg-paper overflow-hidden">
253
- <button
254
- type="button"
255
- onClick={() => adjustTopP(-0.05)}
256
- className="px-3 py-1.5 text-ink/60 hover:text-ink hover:bg-ink/5 transition-colors cursor-pointer"
257
- >
258
- <Minus className="w-3.5 h-3.5" />
259
- </button>
260
- <span className="flex-1 text-center font-mono text-xs font-medium text-ink">
261
- {formData.topP != null ? formData.topP.toFixed(2) : '—'}
262
- </span>
263
- <button
264
- type="button"
265
- onClick={() => adjustTopP(0.05)}
266
- className="px-3 py-1.5 text-ink/60 hover:text-ink hover:bg-ink/5 transition-colors cursor-pointer"
267
- >
268
- <Plus className="w-3.5 h-3.5" />
269
- </button>
270
- </div>
212
+ <input
213
+ type="text"
214
+ value={formData.spawns ?? ''}
215
+ onInput={(e) => setFormData({ ...formData, spawns: e.currentTarget.value || undefined })}
216
+ placeholder="*"
217
+ disabled={readOnly || feedback.saving}
218
+ className="w-full rounded-lg border border-ink/20 bg-paper px-3 py-2 font-mono text-xs text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none placeholder:text-ink/30 disabled:opacity-60"
219
+ />
271
220
  </div>
272
221
  </div>
273
222
  </div>
274
223
 
275
224
  <div className="border-t border-ink/10" />
276
225
 
277
- {/* SECTION 3: System Prompt */}
278
- <div className="space-y-2 flex-1 flex flex-col">
226
+ <div className="flex flex-1 flex-col space-y-2">
279
227
  <div className="flex items-center justify-between">
280
- <label className="text-xs font-bold uppercase tracking-wider text-ink">
281
- System Prompt
282
- </label>
228
+ <label className="text-xs font-bold uppercase tracking-wider text-ink">System prompt</label>
283
229
  <button
284
230
  type="button"
285
- onClick={handleCopyPrompt}
286
- className="flex items-center gap-1.5 text-xs text-ink/60 hover:text-ink transition-colors cursor-pointer"
231
+ onClick={() => {
232
+ navigator.clipboard.writeText(formData.systemPrompt).then(() => {
233
+ setCopiedPrompt(true);
234
+ setTimeout(() => setCopiedPrompt(false), 1800);
235
+ }).catch((err) => console.error('Failed to copy the system prompt:', err));
236
+ }}
237
+ className="flex items-center gap-1.5 text-xs text-ink/60 transition-colors hover:text-ink cursor-pointer"
287
238
  >
288
- {copiedPrompt ? <Check className="w-3.5 h-3.5 text-ink" /> : <Copy className="w-3.5 h-3.5" />}
239
+ {copiedPrompt ? <Check className="h-3.5 w-3.5 text-ink" /> : <Copy className="h-3.5 w-3.5" />}
289
240
  <span>{copiedPrompt ? 'Copied' : 'Copy'}</span>
290
241
  </button>
291
242
  </div>
292
243
  <textarea
293
244
  value={formData.systemPrompt}
294
- onChange={(e) => setFormData({ ...formData, systemPrompt: e.currentTarget.value })}
245
+ onInput={(e) => setFormData({ ...formData, systemPrompt: e.currentTarget.value })}
295
246
  rows={7}
296
- placeholder="You are an expert coding assistant..."
297
- className="w-full flex-1 min-h-[140px] text-xs font-mono p-3 rounded-lg border border-ink/20 hover:border-ink/40 bg-ink/5 focus:outline-none focus:border-ink leading-relaxed transition-colors"
247
+ disabled={readOnly || feedback.saving}
248
+ placeholder="You are an expert coding assistant…"
249
+ aria-invalid={validationError && !agentFileNameError(formData.name) ? true : undefined}
250
+ className={`min-h-[140px] w-full flex-1 rounded-lg border bg-ink/5 p-3 font-mono text-xs leading-relaxed text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none disabled:opacity-60 ${
251
+ validationError && !agentFileNameError(formData.name) ? 'border-error' : 'border-ink/20'
252
+ }`}
298
253
  />
299
254
  </div>
300
255
 
301
- {/* Footer Controls */}
302
- <div className="pt-3 border-t border-ink/10 flex items-center justify-between">
303
- <div>
304
- {!formData.isBuiltIn && !isNew && onDelete && (
305
- <button
306
- type="button"
307
- onClick={() => onDelete(formData.id)}
308
- className="flex items-center gap-1.5 px-3.5 py-2 rounded-lg border border-ink/20 hover:border-error hover:text-error text-ink/70 text-xs font-medium transition-colors cursor-pointer"
309
- >
310
- <Trash2 className="w-3.5 h-3.5" />
311
- Delete Agent
312
- </button>
256
+ {feedback.error && (
257
+ <div className="flex items-start gap-1.5 rounded-lg border border-error/30 bg-error/5 px-3 py-2 text-[11px] text-error">
258
+ <AlertCircle className="mt-px h-3.5 w-3.5 flex-shrink-0" />
259
+ <span className="flex-1 break-words">{feedback.error}</span>
260
+ <button type="button" onClick={feedback.dismissError} className="cursor-pointer text-error/60 hover:text-error" aria-label="Dismiss error">
261
+ ×
262
+ </button>
263
+ </div>
264
+ )}
265
+
266
+ <div className="flex flex-wrap items-center justify-between gap-3 border-t border-ink/10 pt-3">
267
+ <div className="flex items-center gap-2">
268
+ {!readOnly && !isNew && onDelete && (
269
+ confirmDelete ? (
270
+ <>
271
+ <span className="text-[11px] text-ink/70">Delete “{agent.name}”? The file is removed.</span>
272
+ <button
273
+ type="button"
274
+ onClick={handleDelete}
275
+ disabled={feedback.saving}
276
+ className="rounded-lg border border-error/40 px-2.5 py-1 text-xs font-medium text-error transition-colors hover:bg-error/10 cursor-pointer disabled:opacity-50"
277
+ >
278
+ Delete
279
+ </button>
280
+ <button
281
+ type="button"
282
+ onClick={() => setConfirmDelete(false)}
283
+ className="px-2 py-1 text-xs text-ink/50 transition-colors hover:text-ink cursor-pointer"
284
+ >
285
+ Cancel
286
+ </button>
287
+ </>
288
+ ) : (
289
+ <button
290
+ type="button"
291
+ onClick={() => setConfirmDelete(true)}
292
+ className="flex items-center gap-1.5 rounded-lg border border-ink/20 px-3.5 py-2 text-xs font-medium text-ink/70 transition-colors hover:border-error hover:text-error cursor-pointer"
293
+ >
294
+ <Trash2 className="h-3.5 w-3.5" />
295
+ Delete agent
296
+ </button>
297
+ )
313
298
  )}
314
299
  </div>
315
300
 
316
301
  <div className="flex items-center gap-3">
317
- {savedSuccess && (
318
- <span className="flex items-center gap-1 text-xs text-ink font-medium">
319
- <Check className="w-3.5 h-3.5" />
320
- Saved successfully
302
+ {feedback.saved && (
303
+ <span className="flex items-center gap-1 text-xs font-medium text-ink">
304
+ <Check className="h-3.5 w-3.5" /> Saved to the agent file
321
305
  </span>
322
306
  )}
323
- <button
324
- type="submit"
325
- className="px-4 py-2 rounded-lg bg-ink text-paper text-xs font-medium hover:bg-ink/90 transition-colors shadow-xs cursor-pointer"
326
- >
327
- {isNew ? 'Create Agent' : 'Save Agent'}
328
- </button>
307
+ {validationError && !feedback.saved && (
308
+ <span className="max-w-[16rem] text-right text-[11px] leading-snug text-error">{validationError}</span>
309
+ )}
310
+ {!readOnly && (
311
+ <button
312
+ type="submit"
313
+ disabled={feedback.saving || Boolean(validationError) || (!isNew && !dirty)}
314
+ title={!isNew && !dirty ? 'Nothing changed yet' : undefined}
315
+ className="flex items-center gap-1.5 rounded-lg bg-ink px-4 py-2 text-xs font-medium text-paper shadow-xs transition-colors hover:bg-ink/90 cursor-pointer disabled:cursor-not-allowed disabled:opacity-40"
316
+ >
317
+ {feedback.saving ? <Loader2 className="h-3.5 w-3.5 animate-spin" /> : <Save className="h-3.5 w-3.5" />}
318
+ {isNew ? 'Create agent' : 'Save agent'}
319
+ </button>
320
+ )}
329
321
  </div>
330
322
  </div>
331
323
  </form>
@@ -0,0 +1,71 @@
1
+ /**
2
+ * @license
3
+ * SPDX-License-Identifier: MIT
4
+ */
5
+
6
+ /**
7
+ * An agent's `model` frontmatter as a PICKER over the live catalog.
8
+ *
9
+ * omp resolves an agent's model from a `provider/model` selector, so a text box
10
+ * invites a typo that silently falls back to the session model — the same trap
11
+ * the model-role rows already avoid. The list is `/api/models` (the catalog the
12
+ * composer uses), grouped by provider; a stored selector the catalog no longer
13
+ * lists stays selectable so the form never rewrites a value it could not show.
14
+ */
15
+
16
+ import { useMemo } from 'preact/hooks';
17
+ import { useModelsCatalog } from '@/client/hooks/models/use-models-catalog';
18
+
19
+ interface ModelPickerProps {
20
+ value: string;
21
+ disabled: boolean;
22
+ onChange: (selector: string) => void;
23
+ }
24
+
25
+ const NOT_SELECTED = 'Not selected';
26
+
27
+ export function AgentModelPicker({ value, disabled, onChange }: ModelPickerProps) {
28
+ const models = useModelsCatalog((data) => {
29
+ if (!Array.isArray(data.modelList) || data.modelList.length === 0) return undefined;
30
+ return data.modelList.map((entry) => ({
31
+ selector: `${entry.provider}/${entry.id}`,
32
+ provider: entry.provider,
33
+ name: entry.name || entry.id,
34
+ }));
35
+ }) ?? [];
36
+
37
+ const groups = useMemo(() => {
38
+ const byProvider = new Map<string, Array<{ selector: string; name: string }>>();
39
+ for (const model of models) {
40
+ const bucket = byProvider.get(model.provider);
41
+ if (bucket) bucket.push(model);
42
+ else byProvider.set(model.provider, [model]);
43
+ }
44
+ return [...byProvider.entries()];
45
+ }, [models]);
46
+
47
+ const known = models.some((model) => model.selector === value);
48
+
49
+ return (
50
+ <select
51
+ aria-label="Override model"
52
+ value={value || NOT_SELECTED}
53
+ onChange={(event) => {
54
+ const next = event.currentTarget.value;
55
+ onChange(next === NOT_SELECTED ? '' : next);
56
+ }}
57
+ disabled={disabled}
58
+ className="w-full cursor-pointer rounded-lg border border-ink/20 bg-paper py-2 pl-2 pr-3 font-mono text-xs text-ink transition-colors hover:border-ink/40 focus:border-ink focus:outline-none disabled:opacity-60"
59
+ >
60
+ <option value={NOT_SELECTED}>{NOT_SELECTED} — inherits the session model</option>
61
+ {value && !known && <option value={value}>{value} (not in catalog)</option>}
62
+ {groups.map(([provider, entries]) => (
63
+ <optgroup key={provider} label={provider}>
64
+ {entries.map((model) => (
65
+ <option key={model.selector} value={model.selector}>{model.name}</option>
66
+ ))}
67
+ </optgroup>
68
+ ))}
69
+ </select>
70
+ );
71
+ }