@jwilger/pi-development-system 0.48.0 → 0.51.1

package/src/subagents/prefs/import-discovery.ts

@@ -1,5 +1,5 @@
 // @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
-import { lstatSync, readdirSync, readFileSync, type Dirent, type Stats } from "node:fs";
+import { type Dirent, lstatSync, readdirSync, readFileSync, type Stats } from "node:fs";
 import { homedir } from "node:os";
 import { delimiter, dirname, isAbsolute, join, normalize, relative, resolve, sep } from "node:path";
 import { parseDocument } from "yaml";
@@ -17,8 +17,8 @@ export interface DiscoverImportOptions {
   cwd: string;
   agentDir: string;
   includeProject: boolean;
-  homeDir?: string;
-  extraAgentDirs?: string;
+  homeDir?: string | undefined;
+  extraAgentDirs?: string | undefined;
 }
 
 const EXTRA_AGENT_DIRS_ENV = "PI_SUBAGENT_EXTRA_AGENT_DIRS";
@@ -227,7 +227,7 @@ function walk(
         continue;
       }
       if (isSkillMarkdownName(entry.name)) continue;
-      if (!entry.isFile() || !entry.name.endsWith(".md") || entry.name.endsWith(".chain.md")) {
+      if (!(entry.isFile() && entry.name.endsWith(".md")) || entry.name.endsWith(".chain.md")) {
         continue;
       }
       if (isExcluded(child, excludes) || isManagerOwned(child, managerDirs)) continue;
@@ -270,7 +270,7 @@ function considerFile(
   const rawName = fields.name?.trim() ?? "";
   const name = rawName || (permissive ? filenameName(resolved) : "");
   const description = fields.description ?? (permissive ? "" : undefined);
-  if (!name || description === undefined || (!permissive && !description.trim())) return;
+  if (!name || description === undefined || !(permissive || description.trim())) return;
   const packageName = fields.packageName?.trim() ?? "";
   candidates.push({
     id: resolved,
@@ -303,7 +303,7 @@ function looseDisplayFields(content: string): DisplayFields | undefined {
       /* Ambiguous display metadata is not selectable. */
     }
   }
-  if (!fields.name || !fields.description) return undefined;
+  if (!(fields.name && fields.description)) return undefined;
   return { name: fields.name, description: fields.description, packageName: fields.package };
 }
 

package/src/subagents/prefs/models.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
 import { resolveCandidate } from "../../core/models.ts";
 
 const MODEL_IDENTITY = /^[^\s/]+\/[^\s]+$/;
@@ -15,15 +14,12 @@ export function getModelPreferences(type: {
 }): string[] | undefined {
   const hasModels = type.models !== undefined;
   const hasModel = type.model !== undefined;
-  if (hasModels && hasModel)
-    throw new Error("Specify either models or model, not both");
+  if (hasModels && hasModel) throw new Error("Specify either models or model, not both");
   if (hasModels) {
     if (!Array.isArray(type.models))
       throw new Error("models must be an array of provider/model-id strings");
     if (type.models.length === 0)
-      throw new Error(
-        "models must not be empty; omit models to inherit the parent/default model",
-      );
+      throw new Error("models must not be empty; omit models to inherit the parent/default model");
     const models = type.models.map((value, index) =>
       validateModelPreference(value, `models[${index}]`),
     );
@@ -40,11 +36,11 @@ export function modelIdentity(model: { provider: string; id: string }): string {
 }
 
 export class ModelPreferenceError extends Error {
-  constructor(
-    message: string,
-    readonly scopedModelFiltering: boolean,
-  ) {
+  readonly scopedModelFiltering: boolean;
+
+  constructor(message: string, scopedModelFiltering: boolean) {
     super(message);
+    this.scopedModelFiltering = scopedModelFiltering;
   }
 
   get summary(): string {

package/src/subagents/prefs/settings.ts

@@ -1,4 +1,5 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
+// biome-ignore-all lint/complexity/noExcessiveCognitiveComplexity: vendored upstream TUI/config code with no tests; rewriting it risks behaviour (see src/subagents/VENDORED.md)
+// biome-ignore-all lint/suspicious/noShadow: vendored upstream TUI/config code with no tests; rewriting it risks behaviour (see src/subagents/VENDORED.md)
 import { randomUUID } from "node:crypto";
 import {
   closeSync,
@@ -23,11 +24,7 @@ export type WidgetMode = (typeof WIDGET_MODES)[number];
 const TOOL_FILTERING_MODES = ["allowed", "all-except-blocked", "all"] as const;
 export type ToolFilteringMode = (typeof TOOL_FILTERING_MODES)[number];
 
-const MODEL_SELECTION_MODES = [
-  "pick-first-available",
-  "pick-first-scoped",
-  "use-current",
-] as const;
+const MODEL_SELECTION_MODES = ["pick-first-available", "pick-first-scoped", "use-current"] as const;
 export type ModelSelectionMode = (typeof MODEL_SELECTION_MODES)[number];
 
 export interface ManagerSettings {
@@ -55,7 +52,15 @@ export const DEFAULT_MANAGER_SETTINGS: ManagerSettings = {
 };
 
 const KEYS = [
-  "maxLevels", "maxConcurrent", "maxThreads", "modelSelection", "subagentMode", "toolFiltering", "widgetMode", "nerdFontIcons", "finalRecap",
+  "maxLevels",
+  "maxConcurrent",
+  "maxThreads",
+  "modelSelection",
+  "subagentMode",
+  "toolFiltering",
+  "widgetMode",
+  "nerdFontIcons",
+  "finalRecap",
 ] as const;
 const MAX_LEVELS = 32;
 
@@ -65,9 +70,7 @@ function errorCode(error: unknown): string | undefined {
     : undefined;
 }
 
-function lstatIfPresent(
-  path: string,
-): ReturnType<typeof lstatSync> | undefined {
+function lstatIfPresent(path: string): ReturnType<typeof lstatSync> | undefined {
   try {
     return lstatSync(path);
   } catch (error) {
@@ -76,9 +79,7 @@ function lstatIfPresent(
   }
 }
 
-function assertNotSymlinkPath(
-  path: string,
-): ReturnType<typeof lstatSync> | undefined {
+function assertNotSymlinkPath(path: string): ReturnType<typeof lstatSync> | undefined {
   const stat = lstatIfPresent(path);
   if (stat?.isSymbolicLink()) throw new Error(`Unsafe symlink path: ${path}`);
   return stat;
@@ -107,8 +108,8 @@ function parseSettings(content: string): Partial<ManagerSettings> {
   try {
     parsed = JSON.parse(content);
   } catch (error) {
-    const detail = error instanceof Error ? error.message : String(error);
-    throw new Error(`Invalid JSON: ${detail}`);
+    const reason = error instanceof Error ? error.message : String(error);
+    throw new Error(`Invalid JSON: ${reason}`, { cause: error });
   }
   if (parsed === null || typeof parsed !== "object" || Array.isArray(parsed)) {
     throw new Error("Settings must be a JSON object");
@@ -123,7 +124,9 @@ function parseSettings(content: string): Partial<ManagerSettings> {
     if (typeof record.scopedModelFiltering !== "boolean")
       throw new Error("scopedModelFiltering must be a boolean");
     if (!Object.hasOwn(record, "modelSelection"))
-      layer.modelSelection = record.scopedModelFiltering ? "pick-first-scoped" : "pick-first-available";
+      layer.modelSelection = record.scopedModelFiltering
+        ? "pick-first-scoped"
+        : "pick-first-available";
   }
   for (const key of KEYS) {
     if (!Object.hasOwn(record, key)) continue;
@@ -186,8 +189,7 @@ function readLayerContent(entry: SettingsLayer): string | undefined {
   }
   const stat = assertNotSymlinkPath(entry.filePath);
   if (!stat) return undefined;
-  if (!stat.isFile())
-    throw new Error(`Settings must be a regular file: ${entry.filePath}`);
+  if (!stat.isFile()) throw new Error(`Settings must be a regular file: ${entry.filePath}`);
   return readFileSync(entry.filePath, "utf8");
 }
 
@@ -214,9 +216,13 @@ export function loadManagerSaveScope(options: {
     if (content !== undefined) {
       const state: unknown = JSON.parse(content);
       if (
-        state && typeof state === "object" && !Array.isArray(state) &&
-        "saveScope" in state && state.saveScope === "user"
-      ) return "user";
+        state &&
+        typeof state === "object" &&
+        !Array.isArray(state) &&
+        "saveScope" in state &&
+        state.saveScope === "user"
+      )
+        return "user";
     }
   } catch {
     // Missing, invalid or unsafe UI state must not prevent opening settings.
@@ -243,8 +249,7 @@ export function loadManagerSettings(options: {
   const diagnostics: string[] = [];
   const settings: ManagerSettings = { ...DEFAULT_MANAGER_SETTINGS };
   const layers = [layer(options.agentDir, ["subagent-manager"])];
-  if (options.includeProject)
-    layers.push(layer(options.cwd, [".pi", "agent", "subagent-manager"]));
+  if (options.includeProject) layers.push(layer(options.cwd, [".pi", "agent", "subagent-manager"]));
   for (const entry of layers) {
     try {
       const parsed = readLayer(entry);
@@ -257,13 +262,6 @@ export function loadManagerSettings(options: {
 }
 
 function serializedSettings(settings: ManagerSettings): string {
-  if (
-    settings === null ||
-    typeof settings !== "object" ||
-    Array.isArray(settings)
-  ) {
-    throw new Error("Settings must be a JSON object");
-  }
   for (const key of Object.keys(settings)) {
     if (!isSupportedKey(key)) throw new Error(`Unknown settings key: ${key}`);
   }
@@ -298,17 +296,20 @@ function ensureOwnedDirectory(directory: string): void {
 }
 
 function ensureScopeDirectories(directories: string[]): void {
-  assertExistingDirectory(directories[0]);
-  for (let index = 1; index < directories.length; index++) {
-    assertExistingDirectory(directories[index - 1]);
-    ensureOwnedDirectory(directories[index]);
+  const [root, ...rest] = directories;
+  if (root === undefined) return;
+  assertExistingDirectory(root);
+  let parent = root;
+  for (const directory of rest) {
+    assertExistingDirectory(parent);
+    ensureOwnedDirectory(directory);
+    parent = directory;
   }
 }
 
 function assertRegularFileOrAbsent(filePath: string): void {
   const stat = assertNotSymlinkPath(filePath);
-  if (stat && !stat.isFile())
-    throw new Error(`Settings must be a regular file: ${filePath}`);
+  if (stat && !stat.isFile()) throw new Error(`Settings must be a regular file: ${filePath}`);
 }
 
 function exclusiveCreateFlags(): number {
@@ -333,8 +334,7 @@ function writeAtomically(entry: SettingsLayer, content: string): void {
     for (const directory of entry.directories) assertExistingDirectory(directory);
     assertRegularFileOrAbsent(filePath);
     const tempStat = assertNotSymlinkPath(temporary);
-    if (!tempStat?.isFile())
-      throw new Error(`Settings must be a regular file: ${temporary}`);
+    if (!tempStat?.isFile()) throw new Error(`Settings must be a regular file: ${temporary}`);
     renameSync(temporary, filePath);
   } finally {
     if (created) {

package/src/subagents/types.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
 import type { AgentMessage } from "@earendil-works/pi-agent-core";
 import type { ToolDefinition } from "@earendil-works/pi-coding-agent";
 
@@ -11,22 +10,24 @@ export interface ResolvedAgentSettings {
 export interface AgentType {
   name: string;
   description: string;
-  models?: string[];
+  models?: string[] | undefined;
   /** @deprecated Use ordered models instead. */
-  model?: string;
+  model?: string | undefined;
   /** Advisory display names. Not provider/model pins and never used for selection. */
-  modelSuggestions?: string[];
-  thinkingLevel?: ThinkingLevel;
+  modelSuggestions?: string[] | undefined;
+  thinkingLevel?: ThinkingLevel | undefined;
   /** devsys: per-spawn pin set by the coordinator via agent_spawn; beats preferences and inheritance. */
-  spawnOverrides?: { model?: string; thinkingLevel?: ThinkingLevel };
+  spawnOverrides?:
+    | { model?: string | undefined; thinkingLevel?: ThinkingLevel | undefined }
+    | undefined;
   /** Pi semantic token for the type pill background and task path foreground. */
-  color?: string;
+  color?: string | undefined | undefined;
   /** Optional literal Nerd Font glyph; displayed only when the labs setting is enabled. */
-  icon?: string;
-  tools?: { allow?: string[]; block?: string[] };
+  icon?: string | undefined | undefined;
+  tools?: { allow?: string[] | undefined; block?: string[] | undefined } | undefined;
   systemPrompt: string;
-  filePath?: string;
-  source?: "bundled" | "user" | "project";
+  filePath?: string | undefined;
+  source?: "bundled" | "user" | "project" | undefined;
   /**
    * How this definition is customized relative to its base.
    * - fork: a full `<name>.md` copy (owns the system prompt).
@@ -34,15 +35,17 @@ export interface AgentType {
    *   (no Markdown body; unset fields follow the base).
    * Absent for pure bundled definitions and brand-new drafts.
    */
-  customization?: {
-    kind: "fork" | "override";
-    scope: "user" | "project";
-    filePath: string;
-  };
+  customization?:
+    | {
+        kind: "fork" | "override";
+        scope: "user" | "project";
+        filePath: string;
+      }
+    | undefined;
   /** Source of the base definition under the customization, if any. */
-  baseSource?: "bundled" | "user" | "project";
+  baseSource?: "bundled" | "user" | "project" | undefined;
   /** File path of the base definition under the customization, if any. */
-  baseFilePath?: string;
+  baseFilePath?: string | undefined;
 }
 type ThreadState = "starting" | "running" | "paused" | "completed" | "failed" | "stopped";
 export interface ThreadView {
@@ -50,33 +53,33 @@ export interface ThreadView {
   parent: string | null;
   owner: string;
   type: string;
-  color?: string;
-  icon?: string;
+  color?: string | undefined;
+  icon?: string | undefined;
   state: ThreadState;
   task: string;
   status: string;
-  output?: string;
-  error?: string;
+  output?: string | undefined;
+  error?: string | undefined;
   createdAt: number;
   updatedAt: number;
-  sessionFile?: string;
+  sessionFile?: string | undefined;
   /** Frozen active time. Renderer adds `Date.now() - startedAt` while a run is active. */
   elapsedMs?: number;
   /** Current run start. Live only; omitted from saved views so reloads do not count offline time. */
-  startedAt?: number;
+  startedAt?: number | undefined;
   /** Cumulative input tokens, including cache read/write. Live views include the in-progress message. */
   inputTokens?: number;
   /** Cumulative output tokens. Live views include the in-progress message. */
   outputTokens?: number;
   /** devsys: per-spawn model/thinkingLevel pin requested through agent_spawn, when any. */
-  pinned?: { model?: string; thinkingLevel?: ThinkingLevel };
+  pinned?: { model?: string | undefined; thinkingLevel?: ThinkingLevel | undefined };
 }
 type DriverEvent =
   | { kind: "activity" | "error"; text: string }
   | {
       kind: "checkpoint";
       text: string;
-      sessionFile?: string;
+      sessionFile?: string | undefined;
       sessionLeafId?: string | null;
     }
   | {
@@ -106,7 +109,7 @@ export interface TranscriptSnapshot {
   tools: readonly TranscriptToolState[];
   inheritedCount: number;
   thread?: ThreadView;
-  error?: string;
+  error?: string | undefined;
 }
 export interface TranscriptObservation {
   snapshot: TranscriptSnapshot;
@@ -123,7 +126,7 @@ export interface AgentDriver {
   abort(): Promise<void>;
   dispose(): void;
   sendUpdate(content: string): Promise<void> | void;
-  sessionFile?: string;
+  sessionFile?: string | undefined;
   sessionLeafId?: string | null;
 }
 export interface DriverOptions {
@@ -134,7 +137,7 @@ export interface DriverOptions {
   onEvent(event: DriverEvent): void;
   shouldPause(): boolean;
   parentPath: string | null;
-  sessionFile?: string;
+  sessionFile?: string | undefined;
   /** Retained transcript of a nested lexical parent. Absent for /root and independent roots. */
   parentSessionFile?: string;
   sessionLeafId?: string | null;
@@ -145,15 +148,15 @@ export interface SavedThreadView {
   parent: string | null;
   owner: string;
   type: string;
-  color?: string;
-  icon?: string;
+  color?: string | undefined;
+  icon?: string | undefined;
   state: ThreadState;
   task: string;
   status: string;
-  output?: string;
-  error?: string;
+  output?: string | undefined;
+  error?: string | undefined;
   createdAt: number;
-  sessionFile?: string;
+  sessionFile?: string | undefined;
   sessionLeafId?: string | null;
   /** Frozen cumulative active time. `startedAt` is intentionally not persisted. */
   elapsedMs?: number;

package/src/subagents/ui/agent-navigation-editor.ts

@@ -5,11 +5,11 @@ import {
   type KeybindingsManager,
 } from "@earendil-works/pi-coding-agent";
 import {
+  type EditorTheme,
   getKeybindings,
   Key,
-  matchesKey,
-  type EditorTheme,
   type Keybinding,
+  matchesKey,
   type TUI,
 } from "@earendil-works/pi-tui";
 
@@ -87,8 +87,11 @@ export class AgentNavigationEditor extends CustomEditor {
 
   override handleInput(data: string): void {
     const outer = this.dispatchDepth === 0;
-    const direction = this.ordinaryArrow(data, "left") ? "left"
-      : this.ordinaryArrow(data, "right") ? "right" : undefined;
+    const direction = this.ordinaryArrow(data, "left")
+      ? "left"
+      : this.ordinaryArrow(data, "right")
+        ? "right"
+        : undefined;
     if (outer && (!direction || (this.pending && this.pending !== direction))) this.inputEpoch++;
     const previousPaste = this.pastePending;
     const wasPaste = previousPaste || data.includes("\x1b[200~");
@@ -100,10 +103,12 @@ export class AgentNavigationEditor extends CustomEditor {
     const cursor = this.getCursor();
     const text = this.getText();
     const lines = text.split("\n");
-    const atBoundary = direction === "left"
-      ? cursor.line === 0 && cursor.col === 0
-      : direction === "right" && cursor.line === lines.length - 1 &&
-        cursor.col === lines.at(-1)!.length;
+    const atBoundary =
+      direction === "left"
+        ? cursor.line === 0 && cursor.col === 0
+        : direction === "right" &&
+          cursor.line === lines.length - 1 &&
+          cursor.col === lines.at(-1)!.length;
     const eligible =
       outer &&
       direction !== undefined &&
@@ -170,9 +175,10 @@ export class AgentNavigationEditor extends CustomEditor {
     generation: unknown,
     direction: "left" | "right",
   ): void {
-    const allowed = () => direction === "left"
-      ? this.navigation.canOpen()
-      : !!this.navigation.collapseWidget && (this.navigation.canCollapse?.() ?? false);
+    const allowed = () =>
+      direction === "left"
+        ? this.navigation.canOpen()
+        : !!this.navigation.collapseWidget && (this.navigation.canCollapse?.() ?? false);
     if (this.pending || !allowed()) return;
     this.pending = direction;
     const epoch = this.inputEpoch;
@@ -195,8 +201,9 @@ export class AgentNavigationEditor extends CustomEditor {
       try {
         // Call within the checked microtask: an extra Promise.then would leave
         // a gap in which root ownership could change after validation.
-        void Promise.resolve(direction === "left"
-          ? this.navigation.openTree() : this.navigation.collapseWidget!())
+        void Promise.resolve(
+          direction === "left" ? this.navigation.openTree() : this.navigation.collapseWidget!(),
+        )
           .catch((error: unknown) => this.navigation.onError?.(error))
           .finally(() => {
             this.pending = undefined;