@jwilger/pi-development-system 0.48.0 → 0.51.1

package/extensions/development-system.ts

@@ -9,7 +9,6 @@ import { applyPromptSection } from "../src/context/system-prompt.ts";
 import { DEFAULT_VERIFIER_MAX, registerTurnVerifier } from "../src/context/turn-verifier.ts";
 import { type Exec, timeoutAsFailure } from "../src/core/exec.ts";
 import { defaultMatrix } from "../src/core/models.ts";
-import { detectProfiles } from "../src/core/profile.ts";
 import { createApprovalStore } from "../src/gates/approvals.ts";
 import { registerCommitGuard } from "../src/gates/commit-guard.ts";
 import { registerGitGuard } from "../src/gates/git-guard.ts";
@@ -24,6 +23,7 @@ import { createReviewRecordTool, createReviewStartTool } from "../src/review/rev
 import { registerCiCommand } from "../src/state/ci-command.ts";
 import { loadConfig } from "../src/state/config.ts";
 import { createModelsTool, registerModelsCommand } from "../src/state/models-command.ts";
+import { detectProfiles } from "../src/state/profile-detect.ts";
 import { createRouteTaskTool } from "../src/state/route-task-tool.ts";
 import { createSessionState } from "../src/state/session-state.ts";
 import { registerTestEvidence } from "../src/state/test-evidence.ts";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.48.0",
+  "version": "0.51.1",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"
@@ -59,7 +59,7 @@
     "test:jev": "node --experimental-transform-types --no-warnings --test \"test/live/*.live.ts\"",
     "check:jev": "node scripts/run-jev-fixtures.ts",
     "typecheck": "tsc --noEmit",
-    "lint": "biome check .",
+    "lint": "biome check --error-on-warnings .",
     "lint:fix": "biome check --write .",
     "check:build-gate": "node scripts/build-gate.ts",
     "check:version": "node scripts/check-version.ts",

package/skills/strict-lints/SKILL.md

@@ -39,7 +39,8 @@ A warning is an error that has not been triaged yet. Before every commit:
   working; deny in CI.
 - Vendored code under `src/subagents` is on a ratchet: `test/subagents/nocheck-files.ts`
   lists the files still skipping type checks and may only shrink. A file you touch there
-  is made clean and dropped from the list.
+  is made type-clean and lint-clean, dropped from the list, and removed from the
+  `!src/subagents/...` exclusions in `biome.json`.
 
 ## What the extension does
 

package/src/core/profile.ts

@@ -1,12 +1,11 @@
-import { access } from "node:fs/promises";
-import { join } from "node:path";
-import { isParseError, type ParseError, type Profile, parseError } from "./types.ts";
+import { type ParseError, type Profile, parseError } from "./types.ts";
 
 export type { Profile };
 
 const PROFILES: readonly Profile[] = ["rust", "typescript"];
 
-const MARKERS: ReadonlyArray<{ profile: Profile; files: readonly string[] }> = [
+/** Files whose presence marks a repo as using a language profile. */
+export const MARKERS: ReadonlyArray<{ profile: Profile; files: readonly string[] }> = [
   { profile: "rust", files: ["Cargo.toml"] },
   { profile: "typescript", files: ["package.json", "tsconfig.json"] },
 ];
@@ -24,26 +23,3 @@ export function parseProfiles(names: readonly string[]): Profile[] | ParseError
   }
   return out;
 }
-
-const exists = (path: string): Promise<boolean> =>
-  access(path).then(
-    () => true,
-    () => false,
-  );
-
-/** Profiles that apply to `repoRoot`; a non-empty `override` (valid names only) replaces detection. */
-export async function detectProfiles(
-  repoRoot: string,
-  override: readonly string[] = [],
-): Promise<Profile[]> {
-  if (override.length > 0) {
-    const parsed = parseProfiles(override);
-    if (!isParseError(parsed)) return parsed;
-  }
-  const found: Profile[] = [];
-  for (const { profile, files } of MARKERS) {
-    const hits = await Promise.all(files.map((f) => exists(join(repoRoot, f))));
-    if (hits.some(Boolean)) found.push(profile);
-  }
-  return found;
-}

package/src/core/spawn-overrides.ts

@@ -6,8 +6,8 @@ export type ThinkingLevel = (typeof THINKING_LEVELS)[number];
 
 /** Per-spawn choices the coordinator makes; they beat agent-type preferences and inheritance. */
 export type SpawnOverrides = {
-  readonly model?: string;
-  readonly thinkingLevel?: ThinkingLevel;
+  readonly model?: string | undefined;
+  readonly thinkingLevel?: ThinkingLevel | undefined;
 };
 
 export type Settings = {

package/src/core/test-runner.ts

@@ -2,7 +2,7 @@ import { basename, isAssignment, segments, splitLines, WRAPPERS } from "./git-in
 import { redactSecrets } from "./redact.ts";
 
 const PACKAGE_MANAGERS = new Set(["npm", "pnpm", "yarn", "bun"]);
-const DIRECT_RUNNERS = new Set(["vitest", "jest", "pytest", "mocha", "ava"]);
+const DIRECT_RUNNERS = new Set(["vitest", "jest", "pytest", "mocha", "ava", "tap"]);
 const EXEC_PREFIX = new Set(["npx", "bunx", "pnpx"]);
 const SUMMARY_LINES = 3;
 const SUMMARY_MAX = 300;
@@ -63,6 +63,12 @@ export type ResultLike = {
 
 /** A pipe or sequence makes the shell report the last command's status, not the runner's. */
 const NO_TEST_SCRIPT = /Missing script: "?test/;
+/** What npm prints around a missing script; any other line means something else ran or failed. */
+const NPM_MISSING_SCRIPT_NOISE =
+  /^(?:npm (?:error|ERR!)\s*)?(?:$|.*Missing script.*|.*To see a list of scripts.*|.*A complete log of this run.*|.*Did you mean.*|.*npm run.*)$/;
+const onlyMissingScript = (text: string): boolean =>
+  NO_TEST_SCRIPT.test(text) &&
+  text.split("\n").every((l) => NPM_MISSING_SCRIPT_NOISE.test(l.trim()));
 const MASKS_STATUS = /[|;\n]/;
 const FAILURE_MARKERS =
   /^(?:# |ℹ )fail [1-9]|test result: FAILED|\b[1-9]\d* (?:failed|failing)\b|^FAILED\b|^FAIL\b|\bnot ok\b/m;
@@ -72,8 +78,9 @@ const isRecord = (v: unknown): v is Record<string, unknown> =>
 
 /** Exit code of a bash tool result: structured `exit_code`, else pi's status line, else error/not. */
 export function exitCodeOf(result: ResultLike): number {
-  // `npm test` in a package without a test script exits 1 but ran no tests, so it is not a RED.
-  if (NO_TEST_SCRIPT.test(result.text)) return 0;
+  // `npm test` in a package without a test script exits 1 but ran no tests, so it is not a RED;
+  // but with --workspaces one package may lack the script while another fails for real.
+  if (onlyMissingScript(result.text) && !FAILURE_MARKERS.test(result.text)) return 0;
   const reported = reportedExit(result);
   if (reported !== 0) return reported;
   // `npm test | tail` exits 0 whatever the tests did, even in the structured status; trust the output.

package/src/review/digest.ts

@@ -102,7 +102,8 @@ export async function snapshotDiff(
     const hashed = await hashUntracked(exec, cwd, untracked);
     if (!hashed.ok) return hashed;
     const files = { ...tracked.value, ...hashed.value };
-    const names = Object.keys(files).sort((a, b) => a.localeCompare(b));
+    // Code-unit order, not locale order: the digest must not depend on the runtime's collation.
+    const names = Object.keys(files).sort(byCodeUnit);
     const untrackedStat = [
       ...untracked.map((p) => ` ${p} (untracked)`),
       ...nested.map((p) => ` ${p} (nested repository, not reviewable)`),
@@ -118,6 +119,11 @@ export async function snapshotDiff(
   }
 }
 
+const byCodeUnit = (a: string, b: string): number => {
+  if (a === b) return 0;
+  return a < b ? -1 : 1;
+};
+
 /** Content digests (`new:<blob>`) of untracked files; symlinks are hashed by target, not followed. */
 async function hashUntracked(
   exec: Exec,

package/src/state/profile-detect.ts

@@ -0,0 +1,27 @@
+import { access } from "node:fs/promises";
+import { join } from "node:path";
+import { MARKERS, parseProfiles } from "../core/profile.ts";
+import { isParseError, type Profile } from "../core/types.ts";
+
+const exists = (path: string): Promise<boolean> =>
+  access(path).then(
+    () => true,
+    () => false,
+  );
+
+/** Profiles that apply to `repoRoot`; a non-empty `override` (valid names only) replaces detection. */
+export async function detectProfiles(
+  repoRoot: string,
+  override: readonly string[] = [],
+): Promise<Profile[]> {
+  if (override.length > 0) {
+    const parsed = parseProfiles(override);
+    if (!isParseError(parsed)) return parsed;
+  }
+  const found: Profile[] = [];
+  for (const { profile, files } of MARKERS) {
+    const hits = await Promise.all(files.map((f) => exists(join(repoRoot, f))));
+    if (hits.some(Boolean)) found.push(profile);
+  }
+  return found;
+}

package/src/subagents/VENDORED.md

@@ -9,7 +9,7 @@
 
 ## Local modifications (keep this list current)
 
-1. Every `*.ts` file starts with `// @ts-nocheck`: upstream compiles under looser options than this repo's strict `tsconfig.json` (`exactOptionalPropertyTypes`, `erasableSyntaxOnly`). `biome.json` excludes `src/subagents`. Both are deliberate: the code is verbatim, and reformatting or retyping it would make upstream diffs unreadable.
+1. Ratchet. Upstream compiles under looser options than this repo's strict `tsconfig.json` (`exactOptionalPropertyTypes`, `erasableSyntaxOnly`). Files not yet retyped keep `// @ts-nocheck` and are excluded from biome in `biome.json`; both lists must match `test/subagents/nocheck-files.ts`, which may only shrink (`test/subagents/ratchet.test.ts`). Any file we touch is retyped, linted at the repo's strict biome rules and removed from the list. Retyped files that keep a rule violation carry a file-level `biome-ignore-all` with a reason.
 2. Relative `.js` import specifiers were rewritten to `.ts` (upstream relies on a TypeScript-aware loader; this repo's tests run under Node's native type stripping).
 3. `prefs/config.ts`: the bundled-agents directory is `../../../agents/` (was `../../agents/`) because the sources moved one level deeper.
 4. Per-spawn pins (I5.2): `types.ts` `AgentType.spawnOverrides` and `ThreadService.spawn` args gain `model`/`thinkingLevel`; `orch/tools.ts` `agent_spawn` schema exposes both; `orch/manager.ts` `spawn` validates them with `src/core/spawn-overrides.ts` and stores them on the cloned type (so saved threads keep them); `orch/runtime.ts` `resolveInitialSettings` skips the type's preference list when a model is pinned (via `modelSource` in `src/core/spawn-overrides.ts`, so resumed threads keep their model), applies the pin last for fresh spawns, and `createDriver` drops model preferences/scope policy when a model is pinned; `ThreadView.pinned` (`types.ts`) is filled in `orch/manager.ts` `view()` so `agent_status` reports the pins. A pin therefore bypasses `/scoped-models`.

package/src/subagents/index.ts

@@ -1,21 +1,25 @@
 // @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
 import { randomUUID } from "node:crypto";
-import { buildSessionContext, getAgentDir } from "@earendil-works/pi-coding-agent";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { buildSessionContext, getAgentDir } from "@earendil-works/pi-coding-agent";
 import { fuzzyFilter } from "@earendil-works/pi-tui";
-import { ConfigStore } from "./prefs/config.ts";
-import { IMPORT_REQUEST_PREFIX, markImportOffered, offerAgentImport } from "./prefs/agent-import.ts";
+import { createInheritedToolSource } from "./orch/inherited-tools.ts";
 import { ThreadManager } from "./orch/manager.ts";
+import { subagentPrompt } from "./orch/prompt.ts";
+import { createDriverFactory } from "./orch/runtime.ts";
+import { agentTools } from "./orch/tools.ts";
+import {
+  IMPORT_REQUEST_PREFIX,
+  markImportOffered,
+  offerAgentImport,
+} from "./prefs/agent-import.ts";
+import { ConfigStore } from "./prefs/config.ts";
 import { loadManagerSettings } from "./prefs/settings.ts";
+import type { SavedThread, ThreadEvent } from "./types.ts";
+import { AgentNavigationEditor } from "./ui/agent-navigation-editor.ts";
 import { configureAgents } from "./ui/settings-ui.ts";
 import { AgentNavigationController, showAgentStatus } from "./ui/status-ui.ts";
-import { AgentNavigationEditor } from "./ui/agent-navigation-editor.ts";
-import { createDriverFactory } from "./orch/runtime.ts";
-import { createInheritedToolSource } from "./orch/inherited-tools.ts";
-import { subagentPrompt } from "./orch/prompt.ts";
-import { agentTools } from "./orch/tools.ts";
 import { editAgentTypes, updateWidget } from "./ui/ui.ts";
-import type { SavedThread, ThreadEvent } from "./types.ts";
 
 const REGISTRY_ENTRY = "pi-subagent:registry:v1";
 const ROOT_MAILBOX_ENTRY = "pi-subagent:root-mailbox:v1";
@@ -81,32 +85,55 @@ export default function piSubagent(pi: ExtensionAPI): void {
     if (existingFactory && existingFactory !== navigationEditorFactory) return;
     // The host only transfers raw text, not cursor/undo/expanded-paste state.
     if (ctx.ui.getEditorText?.()) return;
-    const history = buildSessionContext(ctx.sessionManager.getBranch()).messages.flatMap((message) => {
-      if (message.role !== "user") return [];
-      const content = message.content;
-      return [typeof content === "string" ? content : content
-        .filter((block) => block.type === "text").map((block) => block.text).join("")];
-    });
+    const history = buildSessionContext(ctx.sessionManager.getBranch()).messages.flatMap(
+      (message) => {
+        if (message.role !== "user") return [];
+        const content = message.content;
+        return [
+          typeof content === "string"
+            ? content
+            : content
+                .filter((block) => block.type === "text")
+                .map((block) => block.text)
+                .join(""),
+        ];
+      },
+    );
     navigationEditorFactory = (tui, theme, keys) => {
       const editor = new AgentNavigationEditor(tui, theme, keys, {
         // Initial startup hydrates after session_start; replacement editors do not.
         initialHistory: seedHistory ? history : undefined,
         generation: () => navigationGeneration,
-        canOpen: () => manager !== undefined && context?.mode === "tui" &&
-          limits.subagentMode !== "off" && !navigation.isOpen &&
-          manager.list().some((thread) => thread.path !== "/root" &&
-            (thread.state === "starting" || thread.state === "running")),
-        openTree: () => manager && context
-          ? navigation.open(context, manager.scope("/root"), undefined, limits.nerdFontIcons) : undefined,
-        canCollapse: () => manager !== undefined && context?.mode === "tui" &&
-          limits.subagentMode !== "off" && !navigation.isOpen && !widgetCollapsed &&
-          limits.widgetMode === "full" && widgetThreads().some((thread) => thread.path !== "/root"),
+        canOpen: () =>
+          manager !== undefined &&
+          context?.mode === "tui" &&
+          limits.subagentMode !== "off" &&
+          !navigation.isOpen &&
+          manager
+            .list()
+            .some(
+              (thread) =>
+                thread.path !== "/root" &&
+                (thread.state === "starting" || thread.state === "running"),
+            ),
+        openTree: () =>
+          manager && context
+            ? navigation.open(context, manager.scope("/root"), undefined, limits.nerdFontIcons)
+            : undefined,
+        canCollapse: () =>
+          manager !== undefined &&
+          context?.mode === "tui" &&
+          limits.subagentMode !== "off" &&
+          !navigation.isOpen &&
+          !widgetCollapsed &&
+          limits.widgetMode === "full" &&
+          widgetThreads().some((thread) => thread.path !== "/root"),
         collapseWidget: () => {
           widgetCollapsed = true;
           if (context) refreshWidget(context);
         },
-        onError: (error) => context?.ui.notify(
-          error instanceof Error ? error.message : String(error), "error"),
+        onError: (error) =>
+          context?.ui.notify(error instanceof Error ? error.message : String(error), "error"),
       });
       navigationEditor = editor;
       return editor;
@@ -120,7 +147,10 @@ export default function piSubagent(pi: ExtensionAPI): void {
     // Migration requires the root's file tools and must not delegate source prompts.
     if (limits.subagentMode === "orchestration") {
       if (!firstRun)
-        ctx.ui.notify("Agent import requires Opportunistic mode. Change Subagent Mode in /agents settings.", "info");
+        ctx.ui.notify(
+          "Agent import requires Opportunistic mode. Change Subagent Mode in /agents settings.",
+          "info",
+        );
       return;
     }
     if (importInProgress) return;
@@ -140,12 +170,15 @@ export default function piSubagent(pi: ExtensionAPI): void {
     if (!manager) throw new Error("Subagent threads are not initialized; start a Pi session first");
     return manager;
   };
-  const widgetThreads = () => requireManager().list().filter((thread) => {
-    // Resuming a retained session makes it visible for this task, even after it settles again.
-    if (thread.state === "starting" || thread.state === "running")
-      hiddenWidgetThreads.delete(thread.path);
-    return !hiddenWidgetThreads.has(thread.path);
-  });
+  const widgetThreads = () =>
+    requireManager()
+      .list()
+      .filter((thread) => {
+        // Resuming a retained session makes it visible for this task, even after it settles again.
+        if (thread.state === "starting" || thread.state === "running")
+          hiddenWidgetThreads.delete(thread.path);
+        return !hiddenWidgetThreads.has(thread.path);
+      });
   const requireContext = () => {
     if (!context) throw new Error("No active Pi session");
     return context;
@@ -187,44 +220,72 @@ export default function piSubagent(pi: ExtensionAPI): void {
   };
   const pendingSummaries = (ctx: ExtensionContext) => {
     const entries = ctx.sessionManager.getBranch();
-    const summarized = new Set(entries.flatMap((entry) => {
-      if (entry.type !== "custom_message" || entry.customType !== ROOT_SUMMARY_MESSAGE) return [];
-      const ids = (entry.details as { mailboxIds?: unknown } | undefined)?.mailboxIds;
-      return Array.isArray(ids) ? ids.filter((id): id is string => typeof id === "string") : [];
-    }));
+    const summarized = new Set(
+      entries.flatMap((entry) => {
+        if (entry.type !== "custom_message" || entry.customType !== ROOT_SUMMARY_MESSAGE) return [];
+        const ids = (entry.details as { mailboxIds?: unknown } | undefined)?.mailboxIds;
+        return Array.isArray(ids) ? ids.filter((id): id is string => typeof id === "string") : [];
+      }),
+    );
     return entries.flatMap((entry) => {
       if (entry.type !== "custom" || entry.customType !== ROOT_MAILBOX_ENTRY) return [];
       const notification = entry.data as RootNotification | undefined;
       return notification?.rootSessionId === ctx.sessionManager.getSessionId() &&
-        notification.finalRecap === true && typeof notification.content === "string" &&
+        notification.finalRecap === true &&
+        typeof notification.content === "string" &&
         typeof notification.details?.mailboxId === "string" &&
-        !summarized.has(notification.details.mailboxId) ? [notification] : [];
+        !summarized.has(notification.details.mailboxId)
+        ? [notification]
+        : [];
     });
   };
   const scheduleSummary = (ctx: ExtensionContext) => {
-    if (!limits.finalRecap || limits.subagentMode === "off" || summaryRunning || suspendingSummaries ||
-        summaryTimer !== undefined || ctx.isIdle() === false || !pendingSummaries(ctx).length) return;
+    if (
+      !limits.finalRecap ||
+      limits.subagentMode === "off" ||
+      summaryRunning ||
+      suspendingSummaries ||
+      summaryTimer !== undefined ||
+      ctx.isIdle() === false ||
+      !pendingSummaries(ctx).length
+    )
+      return;
     const currentGeneration = generation;
     // Coalesce siblings finishing together and leave the settlement boundary before
     // starting a new turn. Recheck settings/session/idle state after the deferral.
     summaryTimer = setTimeout(() => {
       summaryTimer = undefined;
-      if (currentGeneration !== generation || context?.sessionManager !== ctx.sessionManager ||
-          !limits.finalRecap || limits.subagentMode === "off" || suspendingSummaries || ctx.isIdle() === false) return;
+      if (
+        currentGeneration !== generation ||
+        context?.sessionManager !== ctx.sessionManager ||
+        !limits.finalRecap ||
+        limits.subagentMode === "off" ||
+        suspendingSummaries ||
+        ctx.isIdle() === false
+      )
+        return;
       const notifications = pendingSummaries(ctx);
       if (!notifications.length) return;
       summaryRunning = true;
       try {
-        pi.sendMessage({
-          customType: ROOT_SUMMARY_MESSAGE,
-          content: "Summarize the newly finished asynchronous subagent results for the user. " +
-            "Their results are in the preceding subagent notifications; use agent_output if more detail is needed. " +
-            "Give a concise main-thread answer covering results and any failures. " +
-            "Do not spawn or resume agents solely to summarize.\nAgents: " +
-            [...new Set(notifications.map((notification) => notification.details.path))].join(", "),
-          display: false,
-          details: { mailboxIds: notifications.map((notification) => notification.details.mailboxId) },
-        }, { triggerTurn: true });
+        pi.sendMessage(
+          {
+            customType: ROOT_SUMMARY_MESSAGE,
+            content:
+              "Summarize the newly finished asynchronous subagent results for the user. " +
+              "Their results are in the preceding subagent notifications; use agent_output if more detail is needed. " +
+              "Give a concise main-thread answer covering results and any failures. " +
+              "Do not spawn or resume agents solely to summarize.\nAgents: " +
+              [...new Set(notifications.map((notification) => notification.details.path))].join(
+                ", ",
+              ),
+            display: false,
+            details: {
+              mailboxIds: notifications.map((notification) => notification.details.mailboxId),
+            },
+          },
+          { triggerTurn: true },
+        );
       } catch (error) {
         summaryRunning = false;
         warnDelivery(error);
@@ -278,7 +339,10 @@ export default function piSubagent(pi: ExtensionAPI): void {
           content: message,
           // Foreground results already handled by a busy main thread do not need
           // another turn. Completions during a summary do need a follow-up summary.
-          finalRecap: limits.finalRecap && !suspendingSummaries && event.kind === "settled" &&
+          finalRecap:
+            limits.finalRecap &&
+            !suspendingSummaries &&
+            event.kind === "settled" &&
             (thread.state === "completed" || thread.state === "failed") &&
             (requireContext().isIdle() || summaryRunning),
           details: {
@@ -335,8 +399,14 @@ export default function piSubagent(pi: ExtensionAPI): void {
   const refreshWidget = (ctx: ExtensionContext) => {
     if (limits.subagentMode === "off") {
       if (ctx.hasUI) ctx.ui.setWidget("pi-subagent", undefined);
-    } else updateWidget(ctx, widgetThreads(), widgetCollapsed ? "minimal" : limits.widgetMode,
-      limits.nerdFontIcons, rootTurnEnded);
+    } else
+      updateWidget(
+        ctx,
+        widgetThreads(),
+        widgetCollapsed ? "minimal" : limits.widgetMode,
+        limits.nerdFontIcons,
+        rootTurnEnded,
+      );
   };
   pi.on("agent_start", async (_event, ctx) => {
     // A new task must not resurrect the previous task's settled agents. Automatic
@@ -374,7 +444,11 @@ export default function piSubagent(pi: ExtensionAPI): void {
     };
   });
 
-  const attachSession = async (ctx: ExtensionContext, installEditor = false, seedHistory = true) => {
+  const attachSession = async (
+    ctx: ExtensionContext,
+    installEditor = false,
+    seedHistory = true,
+  ) => {
     cancelSummary();
     const token = ++generation;
     closeNavigation(installEditor);
@@ -531,9 +605,19 @@ export default function piSubagent(pi: ExtensionAPI): void {
           },
         });
       } else if (command === "status") {
-        await showAgentStatus(ctx, requireManager().scope("/root"), undefined, limits.nerdFontIcons);
+        await showAgentStatus(
+          ctx,
+          requireManager().scope("/root"),
+          undefined,
+          limits.nerdFontIcons,
+        );
       } else if (command === "tree") {
-        await navigation.open(ctx, requireManager().scope("/root"), rest.join(" ") || undefined, limits.nerdFontIcons);
+        await navigation.open(
+          ctx,
+          requireManager().scope("/root"),
+          rest.join(" ") || undefined,
+          limits.nerdFontIcons,
+        );
       } else
         ctx.ui.notify(
           "Usage: /agents [tree [path] | status | settings | types | import | reload]",

package/src/subagents/orch/inherited-tools.ts

@@ -43,7 +43,7 @@ export function createInheritedToolSource(pi: ExtensionAPI) {
       for (const tool of loadout.registered) {
         const exposure = loadout.getExposure(tool.name);
         // Inactive direct tools and hidden tools are not available in the root either.
-        if (!callable.has(tool.name) && !active.has(tool.name)) continue;
+        if (!(callable.has(tool.name) || active.has(tool.name))) continue;
         if (exposure === "hidden") continue;
         const metadata = info.get(tool.name);
         tools.push({
@@ -64,14 +64,14 @@ export function createInheritedToolSource(pi: ExtensionAPI) {
               // SDK orchestrators are instead recreated locally by runtime.
               throw new Error(
                 `Cannot safely inherit model-only tool ${tool.name}: the SDK does not ` +
-                "provide a hook-preserving execution bridge. Run it in the main session.",
+                  "provide a hook-preserving execution bridge. Run it in the main session.",
               );
             }
             const bridge = rootContext ?? context;
             if (!bridge) {
               throw new Error(
                 "Inherited tool execution needs a main-session agent_* tool call first. " +
-                "Use agent_steer to resume this child instead of the thread dialog.",
+                  "Use agent_steer to resume this child instead of the thread dialog.",
               );
             }
             const outcome = await bridge.executeTool(tool.name, args, { signal, onUpdate });

package/src/subagents/orch/mailbox.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
 import { randomUUID } from "node:crypto";
 import type { SessionEntry, SessionManager } from "@earendil-works/pi-coding-agent";
 
@@ -94,10 +93,12 @@ const normalizeLegacyQueue = (
   const steering = value.steering;
   const followUp = value.followUp;
   if (
-    !Array.isArray(steering) ||
-    !steering.every((text) => typeof text === "string") ||
-    !Array.isArray(followUp) ||
-    !followUp.every((text) => typeof text === "string")
+    !(
+      Array.isArray(steering) &&
+      steering.every((text) => typeof text === "string") &&
+      Array.isArray(followUp) &&
+      followUp.every((text) => typeof text === "string")
+    )
   ) {
     return undefined;
   }
@@ -137,7 +138,10 @@ export class DurableMailbox {
   private readonly consumed = new Set<string>();
   private readonly enqueued = new Set<string>();
 
-  constructor(private readonly sessionManager: SessionManager) {
+  private readonly sessionManager: SessionManager;
+
+  constructor(sessionManager: SessionManager) {
+    this.sessionManager = sessionManager;
     this.migrateLegacyQueue();
     this.restore();
   }
@@ -166,7 +170,7 @@ export class DurableMailbox {
 
   private consumeAppended(messageEntryId: string, markerSource: unknown): void {
     const id = getMailboxMarker(markerSource)?.id;
-    if (!id || !this.accepted.has(id) || this.consumed.has(id)) return;
+    if (!(id && this.accepted.has(id)) || this.consumed.has(id)) return;
     this.sessionManager.appendCustomEntry(CONSUMED_TYPE, { id, messageEntryId });
     this.consumed.add(id);
     this.enqueued.delete(id);