@joshuafolkken/kit 1.872.0

package/scripts/document/retired-phrases.ts

@@ -0,0 +1,143 @@
+// Phrases retracted from the distributed documents, kept so a clone or a reverted decision cannot
+// creep back unnoticed (joshuafolkken/kit#1923). This is the small negative table that replaced the
+// ~140 scattered `not.toContain` assertions the per-rule marker suites carried: each phrase is
+// checked absent from the whole document corpus at once by `document-markers.test.ts`.
+//
+// Whitespace is collapsed on both sides before the comparison, so a phrase that the formatter would
+// wrap across a line break is still caught. A phrase here must stay genuinely gone everywhere; if one
+// is ever a legitimate part of a new document, remove its row rather than scoping it.
+const RETIRED_PHRASES: ReadonlyArray<string> = [
+	'"Implemented <title>:',
+	'"dev": "vite dev --port $(josh port dev)',
+	'"dev": "vite dev --port $(pnpm josh port dev)',
+	'"preview": "wrangler dev --port $(josh port preview)',
+	'"preview": "wrangler dev --port $(pnpm josh port preview)',
+	'"preview:stop": "kill-port $(josh port preview)',
+	'"preview:stop": "kill-port $(pnpm josh port preview)',
+	'### セッション対話の言語（`JOSH_SESSION_LANG`）',
+	'**2 つ目を作ってはならない。**',
+	'**2 件目以降で `--exclude` を省略してはならない。**',
+	'**EPIC 作成へ落ちてはならない。**',
+	'**`#N` が宣言された順序に載っていなくても構わない。**',
+	'**`--ordered` は必須であって好みの問題ではない。**',
+	'**`-u` は省略できない。**',
+	'**■ Overview (plain language — always first)**',
+	'**書き換えられた lock ファイルは最初の子と一緒に入る。**',
+	'--- 技術詳細 ---',
+	'2 件以上に分割したら常に epic を作る。件数の閾値も、実行順序の有無による分岐も無い',
+	'3-6 line work summary',
+	'3–6 line work summary',
+	'Artifact languages are unaffected',
+	'Ask the user to run `pnpm josh test` and share the output',
+	'CI only runs the suite it can find, so specs stay under',
+	'CI status check indicates a managed config file was updated',
+	"Cross-package problems → interrupt with a new Issue, don't patch locally.",
+	'EPIC 全体で 1 回の質問',
+	'Fix in place and re-run `/code-review` at the level `pnpm josh review:level` prints on `git diff main`',
+	'Implement + PR',
+	'Invoking `halfrun` authorizes commit, push, and PR creation',
+	'Issue / PR / Telegram の言語は英語のまま変更なし',
+	'Issue plan comments MUST be written in English',
+	'Issue 本文に「`halfrun` で実行すること」と書いても強制力が無く',
+	'Neither toolkit carries `shot` yet',
+	'No toolkit ships that command yet',
+	'Plan comments MUST be in English',
+	'Poll at the polling interval; ask',
+	'Post the agreed plan in English',
+	'Post the plan in English',
+	'Print the headings exactly as written',
+	'Re-run after applying fixes until **no high or medium findings remain**.',
+	'The recommended default when in doubt is the root-cause interrupt',
+	'The user runs `pnpm josh test` and shares the full output',
+	String.raw`Today that\n> is every consumer`,
+	'Typing `halfrun` approved implementing and merging',
+	'Verify **every** rule below. These are non-standard, so call out any violation.',
+	'What still waits for a person, today',
+	'`into owner/repo#N` は正しい書式である',
+	'`queue` との違いはひとつだけである',
+	'about 60 characters in Japanese, 15 words in English',
+	'artifact languages (Issue / PR / Telegram = English) are unchanged',
+	'ask them to run **`pnpm josh test`** locally',
+	'blocker を見る前に',
+	'chain-rule decision table in \\',
+	'code-reviewer',
+	'compose an implementation summary in English',
+	'exactly what it was) → `pnpm josh git -y` →',
+	'exists in neither toolkit yet',
+	'fix them in place and re-run `/code-review` at the level `pnpm josh review:level` prints. Nothing is committed yet',
+	'fresh-context',
+	'fresh-context subagent',
+	'gh issue list --label review-round2-skipped',
+	'including commit, push, PR creation',
+	'is a separate deliverable',
+	"it asks only after a child that ran in the parent's own context",
+	'its own `pnpm josh gate` join',
+	'join it, and `pnpm josh git -y`; on `skip`',
+	'kit exports that rule for consumers and does not apply it to itself',
+	'operating-rules.md` → "Auto-merge',
+	'park したことで人が必要になる',
+	'park しない',
+	'park は依存として表現できない場合に限る',
+	'post the final review markdown as a PR comment',
+	'queue #101',
+	'runs the same pipeline through PR creation',
+	'sleep the polling interval and go back to step 1',
+	'stay in English regardless of `JOSH_SESSION_LANG`',
+	'stop before merge',
+	'stop with the PR OPEN',
+	'the artifact language stays English',
+	'the completed PR diff',
+	"the threshold is the same number the epic's own measurement produced",
+	'through PR creation',
+	'until the user confirms E2E passed',
+	'while the PR is still OPEN',
+	'→ `pnpm josh git -y` → the follow-up filing',
+	'→ join → `pnpm josh git -y`,',
+	'■ これからやること',
+	'この停止は残す',
+	'これが無いと、判断が返ったのに子が永久に止まる',
+	'これは advisory であり、アトミックではない',
+	'これは分割ではない',
+	'これは意図した差である',
+	'そのたびに人が口頭で起票先を指示していた',
+	'どちらを取るか迷う場合は、**根本対応（割り込み Issue）を既定とする**',
+	'コミット後かつ `pnpm josh followup` 実行前',
+	'マップが答えるのは「チェックアウトがどこにあるか」であって',
+	'ラウンドごとのコミットや CI 再実行も発生しない',
+	'ラベルはリポジトリごとに一度作る',
+	'レビュー自体はコミットの前のままで',
+	'今こうなっている: <1文',
+	'位置の判断は対象 EPIC が既に採ってきた基準に従う',
+	'候補画像からの採用決定など',
+	'入口ごとに条件が違う状態は欠陥である',
+	'入口だけがこの記法から取り残されていた',
+	'勝手に clone することは人の作業機の配置を勝手に決めることである',
+	'子 1 件の `fullrun` は分単位。これより短くしても API 消費が増えるだけ',
+	'子が 13 件なら stash も 13 個になる',
+	'子を実装するリポジトリではない',
+	'実行手順の正典は本節であり',
+	'常駐判定の問いは',
+	'成果物が存在した時点で入れる',
+	'成果物の良し悪しは機械では測れない',
+	'成果物は常に英語',
+	'打ち忘れた回の Issue はどの EPIC にも属さない',
+	'排他はリポジトリ単位であり、それを適用するのは `epic:next` である',
+	'推薦は信号が弱ければ何もしないが',
+	'新規 EPIC を作る前に、`#N` が既に EPIC の子でないかを確かめる',
+	'日本語で 60 字程度',
+	'昇格が他人の Issue を容れ物へ書き換える構造変更であり',
+	'最後の行が最も重要である',
+	'検討した 3 案のうち',
+	'片方だけでは後から辿れない',
+	'理由は綴りである',
+	'省略可能な確認ではない',
+	'矛盾を抱えた計画に対して一括決定を行っても、決定ごと作り直しになる',
+	'確認という歯止めを外す以上、上限を付ける',
+	'禁じられているのは裸の',
+	'自分で外せる印は印として機能せず',
+	'自動投稿される Issue コメント文面は英語で記載する',
+	'読み取りにこそ付け忘れやすく、付け忘れは黙って通る',
+	'閉じていない blocker を宣言している候補を除外する',
+]
+
+export { RETIRED_PHRASES }

package/scripts/document/review-agent-type.ts

@@ -0,0 +1,46 @@
+import { read_unwrapped } from './ai-document-fixture'
+
+// The `/code-review` subagent's agent type is named once, in `chain-rule.md` step 1, so a run stops
+// guessing a name like `code-reviewer` and receiving `Agent type not found` (joshuafolkken/kit#2297).
+// This reads that name back and checks it is a real Claude Code agent type rather than a plausible
+// invention.
+
+const CHAIN_RULE = '.claude/skills/workflow-commands/chain-rule.md'
+
+// The built-in Claude Code agent types the `Agent` tool resolves. `general-purpose` is the one the
+// review uses — it carries every tool, so it can load the review skill and, with `--fix`, apply
+// findings. The set is the source of truth the document test measures the named type against; there is
+// no runtime registry to derive it from, so it is enumerated here.
+const KNOWN_AGENT_TYPES: ReadonlySet<string> = new Set([
+	'general-purpose',
+	'Explore',
+	'Plan',
+	'claude',
+	'claude-code-guide',
+	'statusline-setup',
+])
+
+// The type named as `` `<name>` agent type ``, read from the unwrapped document so a reflow that moved
+// the words to a new line does not hide it.
+const AGENT_TYPE_PATTERN = /`([\w-]+)` agent type/u
+
+function named_agent_type(text: string = read_unwrapped(CHAIN_RULE)): string | undefined {
+	return AGENT_TYPE_PATTERN.exec(text)?.[1]
+}
+
+// Whether the document names an agent type and that type is a real one. A missing name and an invented
+// name are both failures — the first leaves the run guessing, the second is the guess made canonical.
+function names_known_type(text: string = read_unwrapped(CHAIN_RULE)): boolean {
+	const named = named_agent_type(text)
+
+	return named !== undefined && KNOWN_AGENT_TYPES.has(named)
+}
+
+const review_agent_type = {
+	CHAIN_RULE,
+	KNOWN_AGENT_TYPES,
+	named_agent_type,
+	names_known_type,
+}
+
+export { review_agent_type }

package/scripts/document/single-source.ts

@@ -0,0 +1,73 @@
+// The single-source check a document-rule test runs to keep one piece of prose in one place
+// (joshuafolkken/kit#2188). Epic #2166 trims the entry read by turning prose a reader interprets into
+// commands and reference-only pointers; that only holds if the body moved to its command's help does
+// not get pasted back into the prose. This is the framework a later child pins each such move with —
+// give it the body marker and the file allowed to carry it, and it names every other document that
+// still carries the body.
+//
+// **It is a pure function of the corpus, so the reader is injected.** Reading the repository is the
+// test's job (`ai-document-fixture.read_repo_file`); this module takes a `read` and answers from what
+// it returns, so the same logic verifies synthetic inputs in its own test and the real corpus in a
+// document-rule suite.
+
+const SINGLE = 1
+
+interface SingleSourceRule {
+	// The prose fragment that must live in exactly one place.
+	marker: string
+	// The one document allowed to carry it; every reference elsewhere points here rather than copying.
+	canonical: string
+}
+
+type ReadDocument = (document_path: string) => string
+
+// Prose is re-wrapped by the formatter, so a marker that spans a line break would miss on a reflow
+// that changed nothing. Collapsing whitespace on both sides pins the words rather than the column,
+// exactly as `read_unwrapped` does for the marker suites.
+function collapsed(text: string): string {
+	return text.replaceAll(/\s+/gu, ' ')
+}
+
+function carries(text: string, marker: string): boolean {
+	return collapsed(text).includes(collapsed(marker))
+}
+
+// Every document whose text carries the marker, canonical included — the primitive the two checks
+// below read from.
+function carriers(
+	marker: string,
+	documents: ReadonlyArray<string>,
+	read: ReadDocument,
+): Array<string> {
+	return documents.filter((document_path) => carries(read(document_path), marker))
+}
+
+// The documents that carry the body but are not its canonical home — a non-empty result is the
+// violation a single-source suite asserts against.
+function violations(
+	rule: SingleSourceRule,
+	documents: ReadonlyArray<string>,
+	read: ReadDocument,
+): Array<string> {
+	return carriers(rule.marker, documents, read).filter(
+		(document_path) => document_path !== rule.canonical,
+	)
+}
+
+// True only when the canonical carries the body and nothing else does. A body missing from its
+// canonical home is as wrong as one copied elsewhere — a pointer left with nothing to point at — so
+// both halves are checked here rather than only the copies.
+function is_single_sourced(
+	rule: SingleSourceRule,
+	documents: ReadonlyArray<string>,
+	read: ReadDocument,
+): boolean {
+	const found = carriers(rule.marker, documents, read)
+
+	return found.length === SINGLE && found[0] === rule.canonical
+}
+
+const single_source = { carriers, is_single_sourced, violations }
+
+export type { ReadDocument, SingleSourceRule }
+export { single_source }