@joshuafolkken/kit 1.1471.0 → 1.1784.0

package/scripts/issue/issue-comment-cli.ts

@@ -1,5 +1,3 @@
-#!/usr/bin/env tsx
-import { fileURLToPath } from 'node:url'
 import { git_gh_command } from '#scripts/gh/git-gh-command'
 import { issue_number_shape } from '#scripts/issue/issue-number-shape'
 import { cli_body } from '#scripts/josh/cli-body'
@@ -19,7 +17,6 @@ import { error_text } from '#scripts/lib/error-message'
 
 const SUCCESS_EXIT_CODE = 0
 const FAILURE_EXIT_CODE = 1
-const ARGV_OFFSET = 2
 const BODY_FLAG = '--body'
 const BODY_FILE_FLAG = '--body-file'
 const USAGE = `Usage: josh issue:comment <issue-number> ${BODY_FLAG} <text> | ${BODY_FILE_FLAG} <path>`
@@ -33,23 +30,12 @@ interface CommentRequest {
 // ignored. `cli_body.resolve` owns the both-flags-at-once refusal and the file read.
 const OPTIONS = { body: { type: 'string' }, 'body-file': { type: 'string' } } as const
 
-// The number is the one positional, and it must be a real issue number: a missing, malformed or
-// second one refuses the whole call rather than posting to some other issue.
-function single_issue_number(positionals: ReadonlyArray<string>): string | undefined {
-	const [issue_number, ...rest] = positionals
-	const is_single = rest.length === 0 && issue_number !== undefined
-
-	return is_single && issue_number_shape.ISSUE_NUMBER_PATTERN.test(issue_number)
-		? issue_number
-		: undefined
-}
-
 // `resolve` may throw when both body flags are given, which `run` reports — the message names the two
 // flags a caller must pick between.
 function parse_request(argv: ReadonlyArray<string>): CommentRequest | undefined {
 	const parsed = cli_flags.arguments_of(argv, OPTIONS)
 	if (parsed === undefined) return undefined
-	const issue_number = single_issue_number(parsed.positionals)
+	const issue_number = issue_number_shape.single_of(parsed.positionals)
 	if (issue_number === undefined) return undefined
 
 	const body = cli_body.resolve({
@@ -67,11 +53,16 @@ function parse_request(argv: ReadonlyArray<string>): CommentRequest | undefined
 // A both-flags refusal and a file-read failure both surface as an `Error` from `resolve`, and its
 // message already names the flags or the resolved path — so it is printed as-is and `USAGE` is
 // withheld. `undefined` is the other refusal: a bad number or an empty body, which `USAGE` explains.
-function resolve_request(argv: ReadonlyArray<string>): CommentRequest | undefined {
+// `usage` is the caller's: `run:park` parks with the same issue number and body, so it reads them here
+// and prints its own usage on a refusal.
+function resolve_request(
+	argv: ReadonlyArray<string>,
+	usage: string = USAGE,
+): CommentRequest | undefined {
 	try {
 		const request = parse_request(argv)
 
-		if (request === undefined) console.error(USAGE)
+		if (request === undefined) console.error(usage)
 
 		return request
 	} catch (error) {
@@ -93,12 +84,7 @@ async function run(argv: ReadonlyArray<string>): Promise<number> {
 	return SUCCESS_EXIT_CODE
 }
 
-async function main(argv: ReadonlyArray<string>): Promise<void> {
-	process.exitCode = await run(argv)
-}
-
-const issue_comment_cli = { USAGE, run }
-
-if (process.argv[1] === fileURLToPath(import.meta.url)) await main(process.argv.slice(ARGV_OFFSET))
+const issue_comment_cli = { USAGE, resolve_request, run }
 
+export type { CommentRequest }
 export { issue_comment_cli }

package/scripts/issue/issue-comment-main.ts

@@ -0,0 +1,12 @@
+#!/usr/bin/env tsx
+import { fileURLToPath } from 'node:url'
+import { issue_comment_cli } from './issue-comment-cli'
+
+// The `josh issue:comment` entry, kept apart from `issue-comment-cli.ts` because other modules import
+// that one: a bundle is one file, so a main guard there would fire for every command that carries it
+// (joshuafolkken/kit#4186).
+if (process.argv[1] === fileURLToPath(import.meta.url)) {
+	const ARGV_OFFSET = 2
+
+	process.exitCode = await issue_comment_cli.run(process.argv.slice(ARGV_OFFSET))
+}

package/scripts/issue/issue-evidence-exit.ts

@@ -0,0 +1,100 @@
+import { git_gh_command } from '#scripts/gh/git-gh-command'
+import { issue_number_shape } from '#scripts/issue/issue-number-shape'
+import { cli_body } from '#scripts/josh/cli-body'
+import { cli_flags } from '#scripts/lib/cli-flags'
+import { error_text } from '#scripts/lib/error-message'
+import { run_hold_cli } from '#scripts/run/hold/run-hold-cli'
+
+// The shape every evidence exit shares — `josh issue:already-done` and `josh issue:measured`: the
+// evidence comment, the exit's own finishing write, then the `run:release`, in that order.
+//
+// **The order is the point.** The finishing write without the comment is an uncited claim, so the
+// comment goes first and each step runs only once the one before it landed — a failure stops there
+// and names the step.
+
+const FAILURE_EXIT_CODE = 1
+const EVIDENCE_FILE_FLAG = '--evidence-file'
+const OPTIONS = { 'evidence-file': { type: 'string' } } as const
+
+interface EvidenceRequest {
+	issue_number: string
+	evidence: string
+}
+
+// `admit`, when given, runs once the request parsed and before the first write: an exit that does not
+// fit the Issue refuses there, with nothing written.
+interface EvidenceExit {
+	command: string
+	finish: (issue_number: string) => Promise<boolean>
+	admit?: (issue_number: string) => Promise<boolean>
+}
+
+// An evidence file that is empty or whitespace only is refused before anything is written: a comment
+// with no citations is not the finding an exit is for. The throw carries the reason to `run`.
+function parse_request(argv: ReadonlyArray<string>): EvidenceRequest | undefined {
+	const parsed = cli_flags.arguments_of(argv, OPTIONS)
+	if (parsed === undefined) return undefined
+	const issue_number = issue_number_shape.single_of(parsed.positionals)
+	const file_path = parsed.values['evidence-file']
+	if (issue_number === undefined || file_path === undefined) return undefined
+	const evidence = cli_body.read_file_or_stdin(file_path).trim()
+	if (evidence.length === 0) throw new Error(`Evidence file is empty: ${file_path}`)
+
+	return { issue_number, evidence }
+}
+
+// A file-read failure or an empty file is an `Error` naming the path, printed as-is; every other
+// refusal is `undefined`, which the usage line explains.
+function resolve_request(
+	argv: ReadonlyArray<string>,
+	command: string,
+): EvidenceRequest | undefined {
+	try {
+		const request = parse_request(argv)
+
+		if (request === undefined) {
+			console.error(`Usage: josh ${command} <issue-number> ${EVIDENCE_FILE_FLAG} <path>`)
+		}
+
+		return request
+	} catch (error) {
+		console.error(error_text.message_of(error))
+
+		return undefined
+	}
+}
+
+async function post_evidence(request: EvidenceRequest): Promise<boolean> {
+	try {
+		console.info(await git_gh_command.issue_comment(request.issue_number, request.evidence))
+
+		return true
+	} catch (error) {
+		console.error(`Evidence comment not posted: ${error_text.message_of(error)}`)
+
+		return false
+	}
+}
+
+// Each write runs only once the one before it landed: `&&` stops at the first that did not.
+async function write_exit(request: EvidenceRequest, exit: EvidenceExit): Promise<boolean> {
+	return (await post_evidence(request)) && (await exit.finish(request.issue_number))
+}
+
+async function is_admitted(request: EvidenceRequest, exit: EvidenceExit): Promise<boolean> {
+	return exit.admit === undefined || (await exit.admit(request.issue_number))
+}
+
+async function run(argv: ReadonlyArray<string>, exit: EvidenceExit): Promise<number> {
+	const request = resolve_request(argv, exit.command)
+	if (request === undefined || !(await is_admitted(request, exit))) return FAILURE_EXIT_CODE
+
+	return (await write_exit(request, exit))
+		? await run_hold_cli.run(['--release', request.issue_number])
+		: FAILURE_EXIT_CODE
+}
+
+const issue_evidence_exit = { run }
+
+export type { EvidenceExit }
+export { issue_evidence_exit }

package/scripts/issue/issue-file-cli.ts

@@ -14,20 +14,24 @@ import { repository_labels } from '#scripts/repo/repository-labels'
 import { run_event_filed } from '#scripts/run/event/run-event-filed'
 import { run_event_stream } from '#scripts/run/event/run-event-stream'
 import { run_event_stream_emit } from '#scripts/run/event/run-event-stream-emit'
+import { run_hold_member } from '#scripts/run/hold/run-hold-member'
 import { issue_auto_ok } from './issue-auto-ok'
 import { issue_cite } from './issue-cite'
 import { issue_file, type FileArguments } from './issue-file'
 import { issue_file_fold } from './issue-file-fold'
 import { issue_lint_cli } from './issue-lint-cli'
+import { issue_priority } from './issue-priority'
 import { issue_release_cli } from './issue-release-cli'
+import { issue_sample_source } from './issue-sample-source'
 import { issue_scout_cli } from './issue-scout-cli'
 import { issue_wip } from './issue-wip'
 
-// `josh issue:file "<title>" --body-file <path> --depth <0|1|2> [--route <route>] [--label <name>]…
+// `josh issue:file "<title>" --body-file <path> [--route <route>] [--label <name>]…
 // [--repo <owner/repo>] [--distinct <N,…>] [--over-cap] [--no-auto-ok] [--release]` — file an Issue
 // with every filing step run in order: the third-party refusal, the body
 // lint, the `## Origin` check for another repository, the `auto-ok` decision
-// with the run label it owes, the fold question against the run's earlier
+// with the run label it owes, the start condition read as a pull request, the fold question against
+// the run's earlier
 // filings, the WIP cap count, the
 // duplicate scout, the missing workflow labels created, the create call
 // carrying every label, the release link on `--release`, and `epic:bundle`.
@@ -37,7 +41,7 @@ const SUCCESS_EXIT_CODE = 0
 const FAILURE_EXIT_CODE = 1
 const ARGV_OFFSET = 2
 const USAGE =
-	'Usage: josh issue:file "<title>" --body-file <path> --depth <0|1|2> [--route <tier-a|split|interrupt|review-cap>] [--label <name>]… [--repo <owner/repo>] [--distinct <N,…>] [--over-cap] [--no-auto-ok] [--release]'
+	'Usage: josh issue:file "<title>" --body-file <path> [--route <tier-a|split|interrupt|review-cap>] [--label <name>]… [--repo <owner/repo>] [--distinct <N,…>] [--over-cap] [--no-auto-ok] [--release]'
 const UNKNOWN_REPO_MESSAGE =
 	'Could not read this repository from `git remote`, so the filing has no repository to compare against — check `gh auth status`.'
 const THIRD_PARTY_MESSAGE =
@@ -77,6 +81,7 @@ function refusals_of(filing: Filing): ReadonlyArray<string> {
 	const problems = [
 		...issue_lint_cli.problems(filing.body),
 		issue_auto_ok.declaration_problem(filing.body),
+		issue_priority.problem(filing.body, filing.args.labels),
 		issue_file.origin_problem(filing.body, filing.target, filing.current),
 	]
 
@@ -223,8 +228,9 @@ async function place(url: string, target: string): Promise<void> {
 }
 
 // Every filing lands on the run's event stream: this is the one filing path, so
-// one append here reaches `run:board` from every route. A filing outside a run lands too and is left
-// out by the board's own scope to the invocation; the append is best-effort, as every emit is.
+// one append here reaches `run:board` from every route. A filing outside a run lands too, unmarked as
+// the run's (`run_hold_member`), and the board counts only the marked ones; the append is best-effort,
+// as every emit is.
 async function record(url: string, filing: Filing, labels: ReadonlyArray<string>): Promise<void> {
 	const number = String(issue_number_of(url))
 	const reference = issue_cite.plain(
@@ -233,7 +239,9 @@ async function record(url: string, filing: Filing, labels: ReadonlyArray<string>
 	)
 	const found_during = await issue_file_fold.finder()
 	const kind = run_event_filed.kind_of(labels)
-	const text = run_event_filed.text_of({ reference, kind, title: filing.args.title, found_during })
+	const is_run = await run_hold_member.is_run_member()
+	const { title } = filing.args
+	const text = run_event_filed.text_of({ reference, kind, title, found_during, is_run })
 
 	await run_event_stream_emit.emit(run_event_stream.EVENT_KIND.FILED, text)
 }
@@ -247,6 +255,20 @@ function is_admitted(filing: Filing): boolean {
 	return false
 }
 
+// The start condition's citation read against GitHub — after the local refusals, before any listing.
+async function is_source_clear(filing: Filing): Promise<boolean> {
+	const is_here = issue_file.is_same_repository(filing.target, filing.current)
+	const problem = await issue_sample_source.problem(
+		filing.body,
+		is_here ? undefined : filing.target,
+	)
+
+	if (problem === undefined) return true
+	console.error(`✖ ${problem}`)
+
+	return false
+}
+
 async function send(filing: Filing, labels: ReadonlyArray<string>): Promise<number> {
 	const url = await create(filing, labels)
 
@@ -270,7 +292,7 @@ async function is_clear(filing: Filing): Promise<boolean> {
 }
 
 async function file(filing: Filing): Promise<number> {
-	if (!is_admitted(filing)) return FAILURE_EXIT_CODE
+	if (!is_admitted(filing) || !(await is_source_clear(filing))) return FAILURE_EXIT_CODE
 	const labels = labels_of(filing)
 
 	if (labels === undefined || !(await is_clear(filing))) return FAILURE_EXIT_CODE

package/scripts/issue/issue-file.ts

@@ -7,19 +7,19 @@ import { issue_backlinks } from './issue-backlinks'
 import { issue_classification } from './issue-classification'
 import {
 	AUTO_OK_LABEL,
-	DEPTH_LABEL_ORDER,
 	FILING_ROUTE_LABELS,
 	has_label_name,
 	RUN_LANE_LABEL,
 	RUN_SOLO_LABEL,
 } from './issue-labels'
+import { issue_not_before_label } from './issue-not-before-label'
+import { issue_priority } from './issue-priority'
 import { markdown_section } from './markdown-section'
 
 // The decisions behind `josh issue:file`, kept apart from the command that
 // reads the network so each one is a pure answer a test can pin. The filing steps are the command's
 // arguments: a label the filing owes is a required option rather than a line to remember.
 
-const DEPTH_PREFIX = 'depth:'
 const ROUTE_PREFIX = 'route:'
 const LIST_SEPARATOR = ','
 const WORD_SEPARATOR = /\s+/u
@@ -32,7 +32,6 @@ const DIGIT = /\d/u
 interface FileArguments {
 	title: string
 	body_file: string
-	depth: string
 	route: string | undefined
 	labels: ReadonlyArray<string>
 	repo: string | undefined
@@ -48,7 +47,6 @@ interface FileArguments {
 
 const OPTIONS = {
 	'body-file': { type: 'string' },
-	depth: { type: 'string' },
 	route: { type: 'string' },
 	label: { type: 'string', multiple: true },
 	repo: { type: 'string' },
@@ -58,8 +56,8 @@ const OPTIONS = {
 	release: { type: 'boolean' },
 } as const
 
-// The label a `--depth` / `--route` value names, or `undefined` when it names none — read against the
-// label sets `issue-labels.ts` defines, so the command cannot apply a depth or route nobody provisions.
+// The label a `--route` value names, or `undefined` when it names none — read against the route
+// labels `issue-labels.ts` defines, so the command cannot apply a route nobody provisions.
 function label_of(
 	prefix: string,
 	value: string | undefined,
@@ -97,18 +95,15 @@ function has_text(value: string | undefined): value is string {
 	return value !== undefined && value.trim() !== ''
 }
 
-// The labelled half of the arguments, or `undefined` when a depth, route or `--distinct` entry is not
-// one the command knows.
-function labelled_of(
-	values: ParsedValues,
-): Pick<FileArguments, 'depth' | 'route' | 'distinct'> | undefined {
-	const depth = label_of(DEPTH_PREFIX, values.depth, DEPTH_LABEL_ORDER)
+// The labelled half of the arguments, or `undefined` when a route or `--distinct` entry is not one the
+// command knows.
+function labelled_of(values: ParsedValues): Pick<FileArguments, 'route' | 'distinct'> | undefined {
 	const route = route_of(values)
 	const distinct = distinct_numbers(values.distinct ?? [])
 
-	if (route === false || depth === undefined || distinct === undefined) return undefined
+	if (route === false || distinct === undefined) return undefined
 
-	return { depth, route, distinct }
+	return { route, distinct }
 }
 
 function arguments_of(values: ParsedValues, title: string | undefined): FileArguments | undefined {
@@ -144,14 +139,19 @@ function is_undeclared_classification(label: string, body: string): boolean {
 	return is_classification && !has_label_name(issue_classification.required_labels(body), label)
 }
 
-// Every label the filing carries: the depth, the route when there is one, the classification labels
+// Every label the filing carries: the route when there is one, the classification labels
 // the body declares (`issue_classification.labels_for`, which merges case-insensitively), then any
 // extra `--label`, then `auto-ok` when the filing is judged in (`issue-auto-ok.ts`) and no `--label`
-// already named it. One request applies them all, so no label is a separate step to forget.
+// already named it, `not-before` while the body's start time is ahead (`issue-not-before-label.ts`), and
+// the declared priority's label unless a `--label` typed one (`issue-priority.ts`).
+// One request applies them all, so no label is a separate step to forget.
 function labels_of(args: FileArguments, body: string, is_auto_ok = false): ReadonlyArray<string> {
 	const extra = args.labels.filter((label) => !is_undeclared_classification(label, body))
-	const declared = [args.depth, ...(args.route === undefined ? [] : [args.route]), ...extra]
-	const labels = issue_classification.labels_for(body, declared)
+	const declared = [...(args.route === undefined ? [] : [args.route]), ...extra]
+	const labels = issue_priority.with_label(
+		issue_not_before_label.with_label(issue_classification.labels_for(body, declared), body),
+		body,
+	)
 
 	if (!is_auto_ok || has_label_name(labels, AUTO_OK_LABEL)) return labels
 
@@ -168,7 +168,7 @@ function triage_problem(labels: ReadonlyArray<string>): string | undefined {
 
 	if (!is_owed) return undefined
 
-	return `an \`${AUTO_OK_LABEL}\` filing needs \`--label ${RUN_LANE_LABEL}\` or \`--label ${RUN_SOLO_LABEL}\` — \`${RUN_SOLO_LABEL}\` only for a defect in kit's own verification that makes unrelated PRs answer wrongly on main now (\`backlogrun-lanes.md\`), else \`${RUN_LANE_LABEL}\``
+	return `an \`${AUTO_OK_LABEL}\` filing needs \`--label ${RUN_LANE_LABEL}\` or \`--label ${RUN_SOLO_LABEL}\` — \`${RUN_SOLO_LABEL}\` only for a defect in kit's own verification that makes unrelated PRs answer wrongly on main on every run (\`backlogrun-lanes.md\`), else \`${RUN_LANE_LABEL}\` — a flaky one takes \`${RUN_LANE_LABEL}\` and \`priority:critical\``
 }
 
 function is_same_repository(target: string, current: string): boolean {

package/scripts/issue/issue-fold-cli.ts

@@ -1,9 +1,7 @@
-#!/usr/bin/env tsx
-import { fileURLToPath } from 'node:url'
-import { git_command } from '#scripts/git/git-command'
 import { path_decision } from '#scripts/josh/path-decision'
 import { cli_flags } from '#scripts/lib/cli-flags'
 import { split_assess, type SplitVerdict } from '#scripts/split/split-assess'
+import { split_measure } from '#scripts/split/split-measure'
 import { issue_fold, type FoldVerdict } from './issue-fold'
 
 // `josh issue:fold "<title>" "<title>" …` — before a run files a second finding, answer whether the
@@ -15,7 +13,6 @@ import { issue_fold, type FoldVerdict } from './issue-fold'
 // `--not-separable` when the findings are really one deliverable. The verdict logic is in
 // `issue-fold.ts`; everything here is the invocation.
 
-const ARGV_OFFSET = 2
 const USAGE = 'Usage: josh issue:fold "<title>" "<title>" … [--not-separable] [--json]'
 const JSON_KEY = 'fold'
 const FAILURE_EXIT_CODE = 1
@@ -58,7 +55,7 @@ function read_arguments(argv: ReadonlyArray<string>): FoldArguments | undefined
 // rather than folding on no evidence. `issue:file` asks it too.
 async function size_verdict(): Promise<SplitVerdict | undefined> {
 	try {
-		const measurement = split_assess.assess(await git_command.diff_main_numstat())
+		const measurement = await split_measure.read_branch()
 
 		return measurement.files === 0 ? undefined : measurement.verdict
 	} catch {
@@ -91,12 +88,6 @@ async function run(argv: ReadonlyArray<string>): Promise<number> {
 	return 0
 }
 
-async function main(argv: ReadonlyArray<string>): Promise<void> {
-	process.exitCode = await run(argv)
-}
-
 const issue_fold_cli = { REASONS, read_arguments, size_verdict, run }
 
-if (process.argv[1] === fileURLToPath(import.meta.url)) await main(process.argv.slice(ARGV_OFFSET))
-
 export { issue_fold_cli }

package/scripts/issue/issue-fold-main.ts

@@ -0,0 +1,12 @@
+#!/usr/bin/env tsx
+import { fileURLToPath } from 'node:url'
+import { issue_fold_cli } from './issue-fold-cli'
+
+// The `josh issue:fold` entry, kept apart from `issue-fold-cli.ts` because other modules import that
+// one: a bundle is one file, so a main guard there would fire for every command that carries it
+// (joshuafolkken/kit#4186).
+if (process.argv[1] === fileURLToPath(import.meta.url)) {
+	const ARGV_OFFSET = 2
+
+	process.exitCode = await issue_fold_cli.run(process.argv.slice(ARGV_OFFSET))
+}