@joshuafolkken/kit 1.1471.0 → 1.1784.0

package/scripts/gate/core-admission.ts

@@ -1,25 +1,37 @@
+import { MS_PER_SECOND } from '#scripts/lib/timeouts'
 import type { LedgerLoad, MachineBudget } from './machine-capacity'
 
 // The ledger's admission arithmetic, kept apart from the markers `core-budget.ts` reads and writes so
 // that file stays under its line ceiling as the budget grew a memory side.
 // Everything here is a pure function of the ledger it is handed.
 
-const MS_PER_SECOND = 1000
 // **How long an admitted claim's tool takes to reach its declared peak.** The machine reading holds only
 // what a tool has already allocated, so a claim admitted moments ago is not in it yet: adding its
 // declared memory back would admit the next claim into memory about to be taken — the concurrent start
-// this ledger exists to stop. Until the window passes, the claim's memory counts only in the FIFO walk; a
+// this ledger exists to stop. Until the window passes, the claim's memory counts only in `is_admitted`; a
 // tool partway up is then counted twice, which costs a slower admission, never a swap. Its cores are in
 // the reading from the start, so the window does not apply to them.
 const RAMP_UP_MS = 30_000
+// How long after a waiting claim's own claim a lighter claim may still pass it (`may_pass`): long
+// enough for the related checks an edit triggers together, short enough that a heavy claim waits only
+// for the claims already in flight.
+const BYPASS_WINDOW_MS = 30_000
+// A narrowed unit claim still runs one worker: zero would run no test and report the suite green.
+const MIN_GRANT = 1
+// A unit claim narrowed to less than its asked weight over this waits rather than starts (`is_too_narrow`).
+const NARROW_DIVISOR = 2
 
 // What admission reads from a marker. `memory_mb` and `admitted_at` are optional because a marker an
 // older `josh` wrote has neither: it declares no memory, and it counts as load from outside the ledger.
+// `granted` is the narrower weight a unit claim was admitted at past the wait cap; once set, it is the
+// load the claim holds.
 interface LedgerReservation {
 	weight: number
 	claimed_at: number
 	memory_mb?: number | undefined
 	admitted_at?: number | undefined
+	granted?: number | undefined
+	is_unit?: boolean | undefined
 }
 
 interface LedgerEntry {
@@ -37,8 +49,13 @@ interface Overflow {
 	budget: MachineBudget
 }
 
+// `granted` is set only when a unit claim was narrowed to the room left at the wait cap. `waited_ms` is
+// how long the claim waited, about one machine read's window for one admitted on its first read
+// (joshuafolkken/kit#4451).
 interface Admission {
 	overflow: Overflow | undefined
+	granted?: number | undefined
+	waited_ms?: number | undefined
 }
 
 // Claim order, with the filename as the tiebreak so every reader agrees on the same ledger order
@@ -50,54 +67,169 @@ function compare_claim(left: LedgerEntry, right: LedgerEntry): number {
 }
 
 function add_load(totals: LedgerLoad, reservation: LedgerReservation): void {
-	totals.cores += reservation.weight
+	totals.cores += reservation.granted ?? reservation.weight
 	totals.memory_mb += reservation.memory_mb ?? 0
 }
 
-function exceeds(totals: LedgerLoad, budget: MachineBudget): boolean {
+function exceeds(totals: LedgerLoad, budget: LedgerLoad): boolean {
 	return totals.cores > budget.cores || totals.memory_mb > budget.memory_mb
 }
 
-// **The keys admitted under FIFO.** The head always runs — a single check heavier than the whole
-// machine must not wait for room that will never come — and each later reservation runs while the
-// cumulative weight ahead of it still fits the budget. The first that does not fit stops the walk, so a
-// place is never jumped: admission is in claim order, which is what removes the start-time asymmetry.
-// Memory is walked the same way, so a claim whose tool would not fit in free memory waits like one whose
-// cores would not fit.
-function admitted_keys(
-	reservations: ReadonlyArray<LedgerEntry>,
-	budget: number,
-	memory_budget = Infinity,
-): Set<string> {
-	const limit = { cores: budget, memory_mb: memory_budget }
-	const totals = { cores: 0, memory_mb: 0 }
-	const admitted = new Set<string>()
+function sum_load(reservations: ReadonlyArray<LedgerEntry>): LedgerLoad {
+	const load = { cores: 0, memory_mb: 0 }
+
+	for (const entry of reservations) add_load(load, entry.reservation)
+
+	return load
+}
+
+function is_waiting(entry: LedgerEntry): boolean {
+	return entry.reservation.admitted_at === undefined
+}
+
+function fits(entries: ReadonlyArray<LedgerEntry>, limit: LedgerLoad): boolean {
+	return !exceeds(sum_load(entries), limit)
+}
+
+// Where a claim stands in the ledger: the claims already running, whatever their place, and the
+// claims still waiting ahead of it in claim order.
+interface Placement {
+	own: LedgerEntry
+	is_oldest: boolean
+	ahead: Array<LedgerEntry>
+	running: Array<LedgerEntry>
+}
 
-	for (const [index, entry] of reservations.toSorted(compare_claim).entries()) {
-		add_load(totals, entry.reservation)
+function place(key: string, reservations: ReadonlyArray<LedgerEntry>): Placement | undefined {
+	const ordered = reservations.toSorted(compare_claim)
+	const index = ordered.findIndex((entry) => entry.key === key)
+	const own = ordered[index]
 
-		if (index !== 0 && exceeds(totals, limit)) break
+	if (own === undefined) return undefined
 
-		admitted.add(entry.key)
+	return {
+		own,
+		is_oldest: index === 0,
+		ahead: ordered.slice(0, index).filter((entry) => is_waiting(entry)),
+		running: ordered.filter((entry) => entry.key !== key && !is_waiting(entry)),
 	}
+}
 
-	return admitted
+// **The first waiting claim is held by the ledger, never by load from outside it**
+// (joshuafolkken/kit#4313). Holding it on `busy_excess` (joshuafolkken/kit#4238) made a solo gate's unit
+// claim wait out the cap behind one core of Claude sessions or editor load — work deferred, not removed.
+// It is admitted against the cores the ledger leaves, and a unit claim narrows to the room the outside
+// load leaves (`narrowed_weight`), so that load bounds its workers instead of its start. **On an
+// overloaded machine it waits like any claim** (`is_overloaded`, joshuafolkken/kit#4361): every poll reads
+// the load afresh, so it runs once the load falls back under the cap.
+function first_waiter_limit(budget: MachineBudget): LedgerLoad {
+	if (budget.is_overloaded === true) return budget
+
+	return { cores: budget.cores + (budget.busy_excess ?? 0), memory_mb: budget.memory_mb }
+}
+
+// **A light claim passes a waiting one only within a window of that one's claim** (#4313). A claim that
+// fits the room the running claims leave runs instead of queueing behind a heavier claim that does not
+// fit it; a claim made more than the window after a waiter queues behind it, so a waiter is passed by a
+// bounded set of claims and is never starved.
+function may_pass({ own, ahead, running }: Placement, budget: MachineBudget): boolean {
+	const latest = own.reservation.claimed_at - BYPASS_WINDOW_MS
+	const is_recent = ahead.every((entry) => entry.reservation.claimed_at > latest)
+
+	return is_recent && fits([...running, own], budget)
+}
+
+function fits_in_order({ own, ahead, running }: Placement, budget: MachineBudget): boolean {
+	const limit = ahead.length === 0 ? first_waiter_limit(budget) : budget
+
+	return fits([...running, ...ahead, own], limit)
+}
+
+// **A host-wide swap stall holds the oldest claim too** (joshuafolkken/kit#4451). Running alone skipped
+// the memory test, so a lone gate started a 2.4 GB lint into a stall with 1.7 GB free and swapped it
+// for 830 s. Only both together hold: traffic alone is this machine's daily norm (#4313), and a claim
+// heavier than free memory on a calm machine would wait for room that never comes.
+function is_swap_stalled({ own, running }: Placement, budget: MachineBudget): boolean {
+	const needed_mb = sum_load([...running, own]).memory_mb
+
+	return budget.memory_pressured === true && needed_mb > budget.memory_mb
+}
+
+// **The wait cap does not release a swap-stall hold, for any claim** (joshuafolkken/kit#4451): the cap
+// exists so a wedged sibling cannot stall the machine for good, but a stall ends when its traffic stops
+// or its memory is free, so the hold cannot outlive it. Released at the cap, a 2.4 GB lint started into
+// the stall it waited on and swapped for the same 830 s — and holding only a lone claim let a gate's
+// later claims start into the stall at their own caps, after which the lint was no longer alone.
+function is_swap_held(
+	key: string,
+	reservations: ReadonlyArray<LedgerEntry>,
+	budget: MachineBudget,
+): boolean {
+	const placement = place(key, reservations)
+
+	return placement !== undefined && is_swap_stalled(placement, budget)
+}
+
+// The oldest claim runs alone once nothing else does — unless the machine is overloaded, where it waits
+// like the first waiter (`first_waiter_limit`) until a poll reads the load back under the cap, or stalled
+// on swap (`is_swap_stalled`), where it waits until the traffic stops or its memory is free.
+function runs_alone(placement: Placement, budget: MachineBudget): boolean {
+	if (!placement.is_oldest || placement.running.length > 0) return false
+
+	return budget.is_overloaded !== true && !is_swap_stalled(placement, budget)
 }
 
+// **Admission: the oldest claim runs once nothing else does, then claim order, then a bounded pass.**
+// The oldest runs because a single check heavier than the whole machine must not wait for room that will
+// never come — except into a swap stall (`is_swap_stalled`), which passes. Claims that passed it are
+// still running beside it, and their room does come back, so it waits for them rather than starting on
+// top of their cores and memory. A later claim runs when every running claim, every claim waiting
+// ahead of it and its own load fit the budget — the first waiter against the ledger alone
+// (`first_waiter_limit`) — or when it may pass the waiters ahead (`may_pass`).
 function is_admitted(
 	key: string,
 	reservations: ReadonlyArray<LedgerEntry>,
 	budget: MachineBudget,
 ): boolean {
-	return admitted_keys(reservations, budget.cores, budget.memory_mb).has(key)
+	const placement = place(key, reservations)
+
+	if (placement === undefined) return false
+	if (runs_alone(placement, budget)) return true
+
+	return fits_in_order(placement, budget) || may_pass(placement, budget)
 }
 
-function sum_load(reservations: ReadonlyArray<LedgerEntry>): LedgerLoad {
-	const load = { cores: 0, memory_mb: 0 }
+function mark_admitted(entries: Array<LedgerEntry>, key: string): void {
+	const index = entries.findIndex((entry) => entry.key === key)
+	const entry = entries[index]
 
-	for (const entry of reservations) add_load(load, entry.reservation)
+	if (entry === undefined) return
 
-	return load
+	entries[index] = {
+		...entry,
+		reservation: { ...entry.reservation, admitted_at: entry.reservation.claimed_at },
+	}
+}
+
+// **The keys one round of polls admits**, each claim polling in claim order and reading the ledger the
+// claims before it left — an admitted claim is running for every claim after it, as its marker is.
+function admitted_keys(
+	reservations: ReadonlyArray<LedgerEntry>,
+	budget: number,
+	memory_budget = Infinity,
+): Set<string> {
+	const limit = { cores: budget, memory_mb: memory_budget }
+	const ledger = [...reservations]
+	const admitted = new Set<string>()
+
+	for (const { key } of reservations.toSorted(compare_claim)) {
+		if (!is_admitted(key, ledger, limit)) continue
+
+		admitted.add(key)
+		mark_admitted(ledger, key)
+	}
+
+	return admitted
 }
 
 function is_ramped(reservation: LedgerReservation, now: number): boolean {
@@ -120,6 +252,59 @@ function total_weight(reservations: ReadonlyArray<LedgerEntry>): number {
 	return sum_load(reservations).cores
 }
 
+// **The weight a unit claim admitted past the wait cap may take: the cores the admitted claims leave
+// free, never below one worker and never above what it asked for.** Admitting it at full width put the
+// ledger past the machine (joshuafolkken/kit#4235); a unit suite is the one tool whose width follows a
+// number, so it narrows instead. `undefined` for any other claim, and for one that fits as asked.
+function narrowed_weight(
+	key: string,
+	reservations: ReadonlyArray<LedgerEntry>,
+	budget: number,
+): number | undefined {
+	const own = reservations.find((entry) => entry.key === key)?.reservation
+
+	if (own?.is_unit !== true) return undefined
+
+	const others = reservations.filter(
+		(entry) => entry.key !== key && entry.reservation.admitted_at !== undefined,
+	)
+	const room = Math.max(MIN_GRANT, Math.floor(budget - total_weight(others)))
+
+	return room >= own.weight ? undefined : room
+}
+
+// **A unit claim narrowed below half its asked width waits for room instead, until the wait cap**
+// (joshuafolkken/kit#4167). vitest fixes its pool at start, so a width read off one busy instant holds for
+// the whole suite after the cores come back: over seven days a run at three workers or fewer took a
+// median 197 s against 76–90 s at seven, and 14 of the 18 slowest unit runs started that narrow. The
+// wait costs at most the cap, past which the claim narrows as before; a narrowing to half or more — a
+// core of editor load beside a solo gate — still starts at once (joshuafolkken/kit#4313).
+function is_too_narrow(
+	key: string,
+	reservations: ReadonlyArray<LedgerEntry>,
+	granted: number | undefined,
+): boolean {
+	if (granted === undefined) return false
+
+	const own = reservations.find((entry) => entry.key === key)?.reservation
+
+	return own !== undefined && granted * NARROW_DIVISOR < own.weight
+}
+
+// The ledger as it stands once `key` is admitted at `granted`, so the overflow it reports counts the
+// narrowed weight rather than the one the claim asked for.
+function with_grant<T extends LedgerEntry>(
+	key: string,
+	reservations: ReadonlyArray<T>,
+	granted: number | undefined,
+): Array<T> {
+	if (granted === undefined) return [...reservations]
+
+	return reservations.map((entry) =>
+		entry.key === key ? { ...entry, reservation: { ...entry.reservation, granted } } : entry,
+	)
+}
+
 // The weight actually running at once — what the reproduction test asserts stays within the budget.
 function admitted_load(reservations: ReadonlyArray<LedgerEntry>, budget: number): number {
 	const admitted = admitted_keys(reservations, budget)
@@ -149,13 +334,18 @@ function describe_overflow(admission: Admission): string | undefined {
 }
 
 const core_admission = {
+	BYPASS_WINDOW_MS,
 	RAMP_UP_MS,
 	admitted_keys,
 	admitted_load,
 	describe_overflow,
 	is_admitted,
+	is_swap_held,
+	is_too_narrow,
 	ledger_load,
+	narrowed_weight,
 	sum_load,
+	with_grant,
 }
 
 export type { Admission, LedgerEntry, Overflow }

package/scripts/gate/core-budget-timing.ts

@@ -0,0 +1,37 @@
+// How often a waiting reservation re-reads the ledger: short enough that a freed place is taken up
+// promptly, long enough that the wait itself burns no measurable CPU.
+const POLL_INTERVAL_MS = 50
+// The longest a reservation waits before it is admitted at minimum width regardless — a heavy step must
+// make progress even if the budget never clears, so a leaked or wedged sibling cannot stall the machine
+// for good. Two minutes is well past a unit suite's worst measured time under six-way load. A claim a
+// swap stall holds is the exception (`core_admission.is_swap_held`).
+const WAIT_CAP_MS = 120_000
+
+// The clock and cadence a wait runs on, resolved apart from the ledger fields so `reserve` stays under
+// the complexity limit — each default is a branch.
+interface TimingConfig {
+	now: () => number
+	sleep: (ms: number) => Promise<void>
+	poll_interval_ms: number
+	wait_cap_ms: number
+}
+
+async function default_sleep(ms: number): Promise<void> {
+	await new Promise<void>((resolve) => {
+		setTimeout(resolve, ms)
+	})
+}
+
+function resolve_timing(options: Partial<TimingConfig>): TimingConfig {
+	return {
+		now: options.now ?? Date.now,
+		sleep: options.sleep ?? default_sleep,
+		poll_interval_ms: options.poll_interval_ms ?? POLL_INTERVAL_MS,
+		wait_cap_ms: options.wait_cap_ms ?? WAIT_CAP_MS,
+	}
+}
+
+const core_budget_timing = { resolve_timing }
+
+export type { TimingConfig }
+export { core_budget_timing }