@jmruthers/pace-core 0.6.6 → 0.6.7

package/src/utils/__tests__/lazyLoad.unit.test.tsx

@@ -15,19 +15,19 @@ import { renderWithProviders } from '../../__tests__/helpers/test-utils';
 
 // Mock the DataTable component
 vi.mock('../../components/DataTable', () => ({
-  DataTable: vi.fn(() => <div data-testid="data-table">DataTable Component</div>)
+  DataTable: vi.fn(() => <section data-testid="data-table">DataTable Component</section>)
 }));
 
 // Mock the LoadingSpinner component
 vi.mock('../../components/LoadingSpinner/LoadingSpinner', () => ({
-  LoadingSpinner: vi.fn(() => <div data-testid="loading-spinner">Loading...</div>)
+  LoadingSpinner: vi.fn(() => <p data-testid="loading-spinner">Loading...</p>)
 }));
 
 describe('LazyLoad Utility', () => {
     describe('createLazyComponent', () => {
     it('should create a lazy component with default fallback', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
-        default: () => <div data-testid="lazy-component">Lazy Component</div>
+        default: () => <section data-testid="lazy-component">Lazy Component</section>
       });
 
       const LazyTestComponent = createLazyComponent(
@@ -38,11 +38,11 @@ describe('LazyLoad Utility', () => {
       renderWithProviders(<LazyTestComponent />);
 
       // Should show loading spinner initially
-      expect(screen.getByTestId('loading-spinner')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-spinner')).toBeDefined();
 
       // Wait for the component to load
       await waitFor(() => {
-        expect(screen.getByTestId('lazy-component')).toBeInTheDocument();
+        expect(screen.getByTestId('lazy-component')).toBeDefined();
       });
 
       expect(mockImportFn).toHaveBeenCalledTimes(1);
@@ -50,10 +50,10 @@ describe('LazyLoad Utility', () => {
 
     it('should create a lazy component with custom fallback', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
-        default: () => <div data-testid="lazy-component">Lazy Component</div>
+        default: () => <section data-testid="lazy-component">Lazy Component</section>
       });
 
-      const customFallback = <div data-testid="custom-fallback">Custom Loading...</div>;
+      const customFallback = <p data-testid="custom-fallback">Custom Loading...</p>;
 
       const LazyTestComponent = createLazyComponent(
         mockImportFn,
@@ -64,21 +64,21 @@ describe('LazyLoad Utility', () => {
       renderWithProviders(<LazyTestComponent />);
 
       // Should show custom fallback initially
-      expect(screen.getByTestId('custom-fallback')).toBeInTheDocument();
+      expect(screen.getByTestId('custom-fallback')).toBeDefined();
 
       // Wait for the component to load
       await waitFor(() => {
-        expect(screen.getByTestId('lazy-component')).toBeInTheDocument();
+        expect(screen.getByTestId('lazy-component')).toBeDefined();
       });
     });
 
     it('should create a lazy component with error boundary', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
-        default: () => <div data-testid="lazy-component">Lazy Component</div>
+        default: () => <section data-testid="lazy-component">Lazy Component</section>
       });
 
       const ErrorBoundary = ({ children }: { children: React.ReactNode }) => (
-        <div data-testid="error-boundary">{children}</div>
+        <section data-testid="error-boundary">{children}</section>
       );
 
       const LazyTestComponent = createLazyComponent(
@@ -90,15 +90,15 @@ describe('LazyLoad Utility', () => {
       renderWithProviders(<LazyTestComponent />);
 
       // Should show loading spinner initially
-      expect(screen.getByTestId('loading-spinner')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-spinner')).toBeDefined();
 
       // Wait for the component to load
       await waitFor(() => {
-        expect(screen.getByTestId('lazy-component')).toBeInTheDocument();
+        expect(screen.getByTestId('lazy-component')).toBeDefined();
       });
 
       // Error boundary should wrap the component
-      expect(screen.getByTestId('error-boundary')).toBeInTheDocument();
+      expect(screen.getByTestId('error-boundary')).toBeDefined();
     });
 
     it('should handle import errors gracefully', async () => {
@@ -121,7 +121,7 @@ describe('LazyLoad Utility', () => {
 
         render() {
           if (this.state.hasError) {
-            return <div data-testid="error-display">Error occurred</div>;
+            return <p data-testid="error-display">Error occurred</p>;
           }
           return this.props.children;
         }
@@ -139,11 +139,11 @@ describe('LazyLoad Utility', () => {
       renderWithProviders(<LazyTestComponent />);
 
       // Should show loading spinner initially
-      expect(screen.getByTestId('loading-spinner')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-spinner')).toBeDefined();
 
       // Wait for error to be caught and displayed
       await waitFor(() => {
-        expect(screen.getByTestId('error-display')).toBeInTheDocument();
+        expect(screen.getByTestId('error-display')).toBeDefined();
       }, { timeout: 2000 });
 
       // The import function should have been called
@@ -154,7 +154,7 @@ describe('LazyLoad Utility', () => {
 
     it('should set display name correctly', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
-        default: () => <div data-testid="lazy-component">Lazy Component</div>
+        default: () => <section data-testid="lazy-component">Lazy Component</section>
       });
 
       const LazyTestComponent = createLazyComponent(
@@ -168,9 +168,9 @@ describe('LazyLoad Utility', () => {
     it('should pass props to the lazy component', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
         default: ({ title, count }: { title: string; count: number }) => (
-          <div data-testid="lazy-component">
+          <section data-testid="lazy-component">
             {title}: {count}
-          </div>
+          </section>
         )
       });
 
@@ -189,7 +189,7 @@ describe('LazyLoad Utility', () => {
     it('should handle multiple instances of the same lazy component', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
         default: ({ id }: { id: string }) => (
-          <div data-testid={`lazy-component-${id}`}>Component {id}</div>
+          <section data-testid={`lazy-component-${id}`}>Component {id}</section>
         )
       });
 
@@ -199,15 +199,15 @@ describe('LazyLoad Utility', () => {
       );
 
       renderWithProviders(
-        <div>
+        <section>
           <LazyTestComponent id="1" />
           <LazyTestComponent id="2" />
-        </div>
+        </section>
       );
 
       await waitFor(() => {
-        expect(screen.getByTestId('lazy-component-1')).toBeInTheDocument();
-        expect(screen.getByTestId('lazy-component-2')).toBeInTheDocument();
+        expect(screen.getByTestId('lazy-component-1')).toBeDefined();
+        expect(screen.getByTestId('lazy-component-2')).toBeDefined();
       });
 
       // Import function should only be called once due to React.lazy caching
@@ -219,37 +219,40 @@ describe('LazyLoad Utility', () => {
     it('should render the DataTable component when loaded', async () => {
       const mockProps = {
         data: [{ id: 1, name: 'Test' }],
-        columns: [{ id: 'name', accessorKey: 'name', header: 'Name' }]
+        columns: [{ id: 'name', accessorKey: 'name', header: 'Name' }],
+        rbac: { pageName: 'test-page' }
       };
 
       renderWithProviders(<LazyDataTable {...mockProps} />);
 
       // Should show loading spinner initially
-      expect(screen.getByTestId('loading-spinner')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-spinner')).toBeDefined();
 
       // Wait for the DataTable to load
       await waitFor(() => {
-        expect(screen.getByTestId('data-table')).toBeInTheDocument();
+        expect(screen.getByTestId('data-table')).toBeDefined();
       });
     });
 
     it('should pass props to the DataTable component', async () => {
       const mockProps = {
         data: [{ id: 1, name: 'Test' }],
-        columns: [{ id: 'name', accessorKey: 'name', header: 'Name' }]
+        columns: [{ id: 'name', accessorKey: 'name', header: 'Name' }],
+        rbac: { pageName: 'test-page' }
       };
 
       renderWithProviders(<LazyDataTable {...mockProps} />);
 
       await waitFor(() => {
-        expect(screen.getByTestId('data-table')).toBeInTheDocument();
+        expect(screen.getByTestId('data-table')).toBeDefined();
       });
     });
 
     it('should render without errors', () => {
       const mockProps = {
         data: [{ id: 1, name: 'Test' }],
-        columns: [{ id: 'name', accessorKey: 'name', header: 'Name' }]
+        columns: [{ id: 'name', accessorKey: 'name', header: 'Name' }],
+        rbac: { pageName: 'test-page' }
       };
 
       expect(() => renderWithProviders(<LazyDataTable {...mockProps} />)).not.toThrow();
@@ -259,7 +262,7 @@ describe('LazyLoad Utility', () => {
   describe('Component Integration', () => {
     it('should work with React Suspense boundaries', async () => {
       const mockImportFn = vi.fn().mockResolvedValue({
-        default: () => <div data-testid="lazy-component">Lazy Component</div>
+        default: () => <section data-testid="lazy-component">Lazy Component</section>
       });
 
       const LazyTestComponent = createLazyComponent(
@@ -268,23 +271,23 @@ describe('LazyLoad Utility', () => {
       );
 
       const TestWrapper = () => (
-        <div data-testid="wrapper">
+        <section data-testid="wrapper">
           <LazyTestComponent />
-        </div>
+        </section>
       );
 
       renderWithProviders(<TestWrapper />);
 
       // Should show loading spinner initially
-      expect(screen.getByTestId('loading-spinner')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-spinner')).toBeDefined();
 
       // Wait for the component to load
       await waitFor(() => {
-        expect(screen.getByTestId('lazy-component')).toBeInTheDocument();
+        expect(screen.getByTestId('lazy-component')).toBeDefined();
       });
 
       // Wrapper should still be present
-      expect(screen.getByTestId('wrapper')).toBeInTheDocument();
+      expect(screen.getByTestId('wrapper')).toBeDefined();
     });
 
     it('should handle unmounting before load completes', async () => {
@@ -292,7 +295,7 @@ describe('LazyLoad Utility', () => {
         new Promise(resolve => {
           setTimeout(() => {
             resolve({
-              default: () => <div data-testid="lazy-component">Lazy Component</div>
+              default: () => <section data-testid="lazy-component">Lazy Component</section>
             });
           }, 100);
         })
@@ -306,7 +309,7 @@ describe('LazyLoad Utility', () => {
       const { unmount } = renderWithProviders(<LazyTestComponent />);
 
       // Should show loading spinner initially
-      expect(screen.getByTestId('loading-spinner')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-spinner')).toBeDefined();
 
       // Unmount before load completes
       unmount();

package/src/utils/storage/README.md

@@ -67,7 +67,7 @@ Enhanced file upload component with progress tracking, previews, and validation.
   onProgress={(progress) => {}}     // Progress callback
 >
   {/* Optional custom upload UI */}
-  <div>Custom upload area</div>
+  <section>Custom upload area</section>
 </FileUpload>
 ```
 

package/cursor-rules/01-standards-compliance.mdc

@@ -1,285 +0,0 @@
----
-description: Enforce compliance with all pace-core standards across architecture, API, components, code style, security, testing, and RBAC/RLS
-globs: ["src/**/*.{ts,tsx,js,jsx}", "supabase/migrations/**/*.sql"]
-alwaysApply: false
-paceCoreVersion: "0.6.x"
-rulesVersion: "2025-01-28"
----
-# Standards Compliance Guide
-
-This guide ensures consuming apps comply with all pace-core standards. Follow these standards to maintain quality, security, and consistency.
-
-## MUST: Include Complete Cursor Ruleset
-
-Consuming apps **MUST** include the complete pace-core ruleset in the repository so audits are deterministic and repeatable.
-
-- **MUST** include these files under `.cursor/rules/` (exact filenames):
-  - `00-pace-core-compliance.mdc`
-  - `01-standards-compliance.mdc`
-  - `02-project-structure.mdc`
-  - `03-solid-principles.mdc`
-  - `06-code-quality.mdc`
-  - `07-tech-stack-compliance.mdc`
-  - `08-markup-quality.mdc`
-  - `09-rbac-compliance.mdc`
-  - `10-error-handling-patterns.mdc`
-  - `11-performance-optimization.mdc`
-- **MUST NOT** rename or partially copy rules files.
-- If a rule does not apply to a given app, document the exception and the reason, but keep the rule file present.
-
-
-## Architecture Standard
-
-### MUST: Follow Architecture Principles
-
-**MUST adhere to:**
-- Composition over complexity
-- Separation of concerns
-- Domain-agnostic design
-- Extensible, stable APIs
-- Secure by default
-- Performance-conscious
-
-### MUST: Use Helper Functions in RLS Policies
-
-**RLS policies MUST use helper functions, NEVER subqueries.**
-
-```sql
--- ❌ WRONG: Subquery in RLS policy (causes N+1 queries)
-CREATE POLICY rbac_select_users ON users FOR SELECT USING (
-  organisation_id IN (SELECT organisation_id FROM organisation_memberships WHERE user_id = auth.uid())
-);
-
--- ✅ CORRECT: Helper function with STABLE SECURITY DEFINER
-CREATE OR REPLACE FUNCTION get_user_organisation_ids() RETURNS uuid[] LANGUAGE plpgsql STABLE SECURITY DEFINER SET search_path TO public AS $$
-BEGIN RETURN ARRAY(SELECT organisation_id FROM organisation_memberships WHERE user_id = get_effective_user_id()); END;
-$$;
-CREATE POLICY rbac_select_users ON users FOR SELECT USING (organisation_id = ANY(get_user_organisation_ids()));
-```
-
-### MUST: Test Database Migrations
-
-**MUST verify migrations don't cause query timeouts or performance degradation.**
-
-## API & RPC Standard
-
-### MUST: Follow RPC Naming Convention
-
-**RPCs MUST follow pattern: `<family>_<domain>_<verb>`**
-
-- `data_*` prefix for read operations: `data_cake_dishes_list`, `data_file_reference_list`
-- `app_*` prefix for write operations: `app_cake_dish_create`, `app_cake_dish_update`
-- CRUD verbs only: `create`, `read`, `update`, `delete`, `list`, `get`
-- Bulk operations: `_bulk` suffix (e.g., `app_cake_dish_create_bulk`)
-
-```sql
--- ✅ CORRECT: data_cake_dishes_list, app_cake_dish_create, app_cake_dish_create_bulk
--- ❌ WRONG: getDishes, create_dish (wrong naming pattern)
-```
-
-### MUST: Use ApiResult Shape
-
-**All RPCs MUST return ApiResult shape:**
-
-```typescript
-type ApiResult<T> = { ok: true; data: T } | { ok: false; error: ApiError };
-type ApiError = { code: string; message: string; details?: object };
-```
-
-### MUST: Enforce RLS in RPCs
-
-**RPCs MUST enforce RLS and tenant boundaries.** Never bypass RLS.
-
-### SHOULD: Make Write RPCs Idempotent
-
-**Write RPCs SHOULD be idempotent when possible.**
-
-## Component Standard
-
-### MUST: Follow Component Principles
-
-**Components MUST:**
-- Be stateless when possible
-- Use composable structure
-- Be accessible by default
-- Be fully typed
-- Have small surface area
-
-### MUST NOT: Add Domain Logic to Components
-
-**Components MUST NOT:**
-- Include domain-specific logic
-- Fetch data directly (use hooks/services)
-- Include business workflows
-
-### MUST: Ensure Accessibility
-
-**Components MUST:**
-- Be keyboard operable
-- Have correct ARIA roles
-- Have visible focus states
-- Avoid inaccessible interactions
-
-## Code Style Standard
-
-### MUST: Follow TypeScript Rules
-
-**MUST:**
-- Use strict mode (`strict: true` in tsconfig)
-- Prefer discriminated unions
-- Use ReadonlyArray where possible
-- Avoid boolean mode flags (use unions instead)
-
-**MUST NOT:**
-- Use `any` (use `unknown` if type is truly unknown)
-- Use implicit any
-- Use unnecessary type assertions
-
-### MUST: Follow Naming Conventions
-
-- Hooks: `useSomething`
-- Providers: `SomethingProvider`
-- Utilities: `camelCase`
-- Components: `PascalCase`
-
-### SHOULD: Use Preferred Patterns
-
-**SHOULD:**
-- Use pure functions
-- Prefer composition over inheritance
-- Use early returns
-- Extract large functions into small helpers
-
-## Security Standard
-
-### MUST: Never Bypass RLS
-
-**MUST enforce RLS on all tables.** Never bypass RLS policies.
-
-### MUST: Validate All Inputs
-
-**MUST validate all inputs using Zod schemas or similar.**
-
-### MUST: Sanitize Logs
-
-**MUST NOT log:**
-- Passwords
-- Tokens
-- Sensitive data (PII)
-
-**MAY log:**
-- IDs
-- Non-PII metadata
-
-### MUST: Use Safe Error Messaging
-
-**MUST NOT expose internal details in error messages.**
-
-### MUST: Use Helper Functions in RLS
-
-**RLS policies MUST use STABLE SECURITY DEFINER helper functions:**
-- `STABLE` - Results consistent within transaction
-- `SECURITY DEFINER` - Bypass RLS to avoid recursion
-- `SET search_path TO 'public'` - Prevent search path injection
-
-## Testing Standard
-
-### MUST: Meet Coverage Requirements
-
-**MUST achieve:**
-- ≥90% coverage for utils & hooks
-- ≥70% coverage for components
-
-
-### MUST: Enforce Coverage Thresholds in Tooling
-
-Coverage requirements must be **machine-enforced**, not aspirational:
-
-- **MUST** provide a script: `npm run test:coverage`
-- **MUST** configure the test runner (Vitest/Jest) to enforce the thresholds:
-  - ≥90% for utils & hooks
-  - ≥70% for components
-- **MUST** fail the command when thresholds are not met (CI or local execution).
-
-**Verification:**
-- `npm run test:coverage` exits non-zero when below threshold.
-- A coverage summary artifact is produced (e.g., `coverage/coverage-summary.json` or equivalent).
-
-### MUST: Use React Testing Library
-
-**MUST use React Testing Library + userEvent for component tests.**
-
-### SHOULD: Colocate Tests
-
-**Tests SHOULD be colocated: `*.test.ts` or `*.test.tsx`**
-
-### SHOULD: Test Critical Paths
-
-**SHOULD test:**
-- Key user interactions
-- Error handling
-- Edge cases
-- Critical business logic
-
-## RBAC & RLS Standard
-
-### MUST: Use Helper Functions
-
-**All RLS policies MUST use helper functions with:**
-- `STABLE` attribute
-- `SECURITY DEFINER` attribute
-- `SET search_path TO 'public'`
-
-### MUST: Follow Policy Naming
-
-**RLS policies MUST follow pattern: `rbac_{operation}_{table_name}_{scope}`**
-
-Example: `rbac_select_users_organisation`
-
-### MUST: Include Organisation Context
-
-**RLS policies MUST include `organisation_id` for multi-tenant isolation.**
-
-### MUST: Include Super Admin Checks
-
-**RLS policies SHOULD include super admin checks where appropriate.**
-
-## Standards Precedence
-
-When standards conflict, follow this order:
-1. Security Standard (highest priority)
-2. API & RPC Standard
-3. Component Standard
-4. Code Style Standard
-5. Testing Standard
-6. Documentation Standard
-
-## Compliance Checklist
-
-Before committing code, verify:
-- [ ] RLS policies use helper functions (no subqueries)
-- [ ] RPCs follow naming convention
-- [ ] Components are accessible and typed
-- [ ] No `any` types used
-- [ ] Inputs are validated
-- [ ] Tests meet coverage requirements
-- [ ] No sensitive data in logs
-- [ ] Error messages are safe
-
-## Reference
-
-**📚 Human-Readable Standard**: See [01-standards-compliance.md](../../packages/core/docs/standards/01-standards-compliance.md) for complete documentation.
-
-**Related Standards** (all have corresponding cursor rules):
-- **00-pace-core-compliance.mdc** - pace-core usage patterns
-- **02-project-structure.mdc** - Project structure and organization
-- **03-solid-principles.mdc** - SOLID architecture principles
-- **04-testing-standards.mdc** - Testing framework standards
-- **05-bug-reports-and-features.mdc** - Issue reporting templates
-- **06-code-quality.mdc** - Code quality and TypeScript standards
-- **07-tech-stack-compliance.mdc** - Tech stack and API/RPC standards
-- **08-markup-quality.mdc** - Markup and styling standards
-- **09-rbac-compliance.mdc** - RBAC and RLS standards
-- **10-error-handling-patterns.mdc** - Error handling patterns
-- **11-performance-optimization.mdc** - Performance optimization
-- **12-ci-cd-integration.mdc** - CI/CD integration patterns