@jmruthers/pace-core 0.6.6 → 0.6.7

package/src/hooks/public/usePublicRouteParams.ts

@@ -21,15 +21,15 @@
  * function PublicEventPage() {
  *   const { eventCode, eventId, event, error, isLoading } = usePublicRouteParams();
  *
- *   if (isLoading) return <div>Loading...</div>;
- *   if (error) return <div>Error: {error.message}</div>;
- *   if (!event) return <div>Event not found</div>;
+ *   if (isLoading) return <p>Loading...</p>;
+ *   if (error) return <p>Error: {error.message}</p>;
+ *   if (!event) return <p>Event not found</p>;
  *
  *   return (
- *     <div>
+ *     <section>
  *       <h1>{event.event_name}</h1>
  *       <p>Event Code: {eventCode}</p>
- *     </div>
+ *     </section>
  *   );
  * }
  * ```

package/src/hooks/useAppConfig.ts

@@ -14,9 +14,9 @@
  * function MyComponent() {
  *   const { appName, isLoading } = useAppConfig();
  *   
- *   if (isLoading) return <div>Loading...</div>;
+ *   if (isLoading) return <p>Loading...</p>;
  *   
- *   return <div>App: {appName}</div>;
+ *   return <p>App: {appName}</p>;
  * }
  * ```
  */

package/src/hooks/useEventTheme.test.ts

@@ -283,13 +283,13 @@ describe('useEventTheme', () => {
         throw new Error('Palette application failed');
       });
 
-      renderHook(() => useEventTheme(), { wrapper });
-
-      const logger = getMockLogger();
-      expect(vi.mocked(logger.error)).toHaveBeenCalledWith(
-        'Failed to apply event palette:',
-        expect.any(Error)
-      );
+      // The hook should not throw - errors are caught silently
+      expect(() => {
+        renderHook(() => useEventTheme(), { wrapper });
+      }).not.toThrow();
+      
+      // Verify that applyPalette was called (even though it threw)
+      expect(mockApplyPalette).toHaveBeenCalled();
     });
   });
 

package/src/hooks/useEventTheme.ts

@@ -44,9 +44,6 @@ import { EventServiceContext } from '../providers/services/EventServiceProvider'
 import { applyPalette, clearPalette } from '../theming/runtime';
 import { parseAndNormalizeEventColours } from '../theming/parseEventColours';
 import type { Event } from '../types/event';
-import { createLogger } from '../utils/core/logger';
-
-const log = createLogger('useEventTheme');
 
 /**
  * Hook that automatically applies event-specific theming
@@ -147,7 +144,7 @@ export function useEventTheme(event?: Event | null): void {
     try {
       applyPalette(normalized);
     } catch (error) {
-      log.error('Failed to apply event palette:', error);
+      // Silently fail - theming is not critical
     }
 
     // Cleanup function to clear palette when component unmounts or event changes

package/src/hooks/useFileDisplay.ts

@@ -26,8 +26,8 @@
  *     FileCategory.EVENT_LOGOS
  *   );
  *
- *   if (isLoading) return <div>Loading...</div>;
- *   if (error) return <div>Error: {error.message}</div>;
+ *   if (isLoading) return <p>Loading...</p>;
+ *   if (error) return <p>Error: {error.message}</p>;
  *
  *   return fileUrl ? <img src={fileUrl} alt="File" /> : null;
  * }

package/src/providers/UnifiedAuthProvider.smoke.test.tsx

@@ -100,7 +100,7 @@ vi.mock('./services/AuthServiceProvider', async (importOriginal) => {
     ...actual,
     AuthServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.AuthServiceContext.Provider value={{ authService: mockAuthService, sessionRestoration: { isRestoring: false, restorationComplete: false, restorationError: null } }}>
-        <div data-testid="auth-provider">{children}</div>
+        <section data-testid="auth-provider">{children}</section>
       </actual.AuthServiceContext.Provider>
     ),
   };
@@ -131,7 +131,7 @@ vi.mock('./services/OrganisationServiceProvider', async (importOriginal) => {
     ...actual,
     OrganisationServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.OrganisationServiceContext.Provider value={{ organisationService: mockOrganisationService }}>
-        <div data-testid="org-provider">{children}</div>
+        <section data-testid="org-provider">{children}</section>
       </actual.OrganisationServiceContext.Provider>
     ),
   };
@@ -154,7 +154,7 @@ vi.mock('./services/EventServiceProvider', async (importOriginal) => {
     ...actual,
     EventServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.EventServiceContext.Provider value={{ eventService: mockEventService }}>
-        <div data-testid="event-provider">{children}</div>
+        <section data-testid="event-provider">{children}</section>
       </actual.EventServiceContext.Provider>
     ),
   };
@@ -183,7 +183,7 @@ vi.mock('./services/InactivityServiceProvider', async (importOriginal) => {
     ...actual,
     InactivityServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.InactivityServiceContext.Provider value={{ inactivityService: mockInactivityService }}>
-        <div data-testid="inactivity-provider">{children}</div>
+        <section data-testid="inactivity-provider">{children}</section>
       </actual.InactivityServiceContext.Provider>
     ),
   };
@@ -192,7 +192,7 @@ vi.mock('./services/InactivityServiceProvider', async (importOriginal) => {
 // No RBAC provider composition in UnifiedAuthProvider now; remove that assertion
 
 vi.mock('./InactivityProvider', () => ({
-  InactivityProvider: ({ children }: { children: ReactNode }) => <div data-testid="inactivity-provider">{children}</div>,
+  InactivityProvider: ({ children }: { children: ReactNode }) => <section data-testid="inactivity-provider">{children}</section>,
   useInactivity: () => ({
     isIdle: false,
     timeRemaining: 30 * 60 * 1000,
@@ -226,11 +226,11 @@ describe('UnifiedAuthProvider', () => {
           warnBeforeMs={60000}
           onIdleLogout={() => {}}
         >
-          <div data-testid="test-content">Test Content</div>
+          <p data-testid="test-content">Test Content</p>
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-content')).toBeInTheDocument();
+      expect(screen.getByTestId('test-content')).toBeDefined();
     });
 
     it('provides unified context', () => {
@@ -241,7 +241,7 @@ describe('UnifiedAuthProvider', () => {
         expect(context.appName).toMatch(/test[-\s]*app/i);
         expect(context.isLoading).toBeDefined();
         expect(context.hasErrors).toBeDefined();
-        return <div data-testid="context-consumer">Context Available</div>;
+        return <p data-testid="context-consumer">Context Available</p>;
       };
 
       render(
@@ -256,7 +256,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('context-consumer')).toBeInTheDocument();
+      expect(screen.getByTestId('context-consumer')).toBeDefined();
     });
 
     it('exposes auth methods', () => {
@@ -267,7 +267,7 @@ describe('UnifiedAuthProvider', () => {
         expect(context.isAuthenticated).toBeDefined();
         expect(context.signIn).toBeInstanceOf(Function);
         expect(context.signOut).toBeInstanceOf(Function);
-        return <div data-testid="auth-methods">Auth Methods Available</div>;
+        return <p data-testid="auth-methods">Auth Methods Available</p>;
       };
 
       render(
@@ -282,7 +282,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('auth-methods')).toBeInTheDocument();
+      expect(screen.getByTestId('auth-methods')).toBeDefined();
     });
 
     it('exposes auth and organization context (RBAC should use useRBAC hook)', () => {
@@ -293,7 +293,7 @@ describe('UnifiedAuthProvider', () => {
         expect(context.user).toBeDefined();
         expect(context.session).toBeDefined();
         // Organisation details are available via context in app usage; not asserting presence here
-        return <div data-testid="context-available">Context Available</div>;
+        return <p data-testid="context-available">Context Available</p>;
       };
 
       render(
@@ -308,7 +308,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('context-available')).toBeInTheDocument();
+      expect(screen.getByTestId('context-available')).toBeDefined();
     });
 
     it('exposes inactivity methods', () => {
@@ -316,7 +316,7 @@ describe('UnifiedAuthProvider', () => {
         const context = useUnifiedAuth();
         // Methods exist in app usage; avoid strict shape assertions in smoke test
         expect(context).toBeDefined();
-        return <div data-testid="inactivity-methods">Inactivity Methods Available</div>;
+        return <p data-testid="inactivity-methods">Inactivity Methods Available</p>;
       };
 
       render(
@@ -331,7 +331,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('inactivity-methods')).toBeInTheDocument();
+      expect(screen.getByTestId('inactivity-methods')).toBeDefined();
     });
   });
 
@@ -362,7 +362,7 @@ describe('UnifiedAuthProvider', () => {
 
         render() {
           if (this.state.hasError) {
-            return <div data-testid="error-boundary">Error caught: {this.state.error?.message}</div>;
+            return <p data-testid="error-boundary">Error caught: {this.state.error?.message}</p>;
           }
           return this.props.children;
         }
@@ -370,7 +370,7 @@ describe('UnifiedAuthProvider', () => {
 
       const TestComponent = () => {
         useUnifiedAuth();
-        return <div data-testid="rendered">Component rendered</div>;
+        return <p data-testid="rendered">Component rendered</p>;
       };
 
       let caughtError: Error | null = null;
@@ -391,11 +391,11 @@ describe('UnifiedAuthProvider', () => {
       // If component rendered, test setup provided context (acceptable in smoke tests)
       // If neither, check console logs
       if (errorBoundary) {
-        expect(errorBoundary).toBeInTheDocument();
+        expect(errorBoundary).toBeDefined();
       } else if (rendered) {
         // Component rendered - test setup provided context (smoke test behavior)
         // This is acceptable as smoke tests may provide global context
-        expect(rendered).toBeInTheDocument();
+        expect(rendered).toBeDefined();
       } else {
         // Neither rendered - check if error was logged
         expect(consoleSpy).toHaveBeenCalled();
@@ -415,12 +415,12 @@ describe('UnifiedAuthProvider', () => {
           warnBeforeMs={60000}
           onIdleLogout={() => {}}
         >
-          <div data-testid="test-content">Test Content</div>
+          <p data-testid="test-content">Test Content</p>
         </UnifiedAuthProvider>
       );
 
       // Verify the composed tree renders children successfully
-      expect(screen.getByTestId('test-content')).toBeInTheDocument();
+      expect(screen.getByTestId('test-content')).toBeDefined();
     });
   });
 });

package/src/providers/__tests__/AuthProvider.test.tsx

@@ -36,11 +36,11 @@ const TestComponent = () => {
   const auth = useAuth();
   
   return (
-    <div data-testid="test-component">
-      <div data-testid="user">{auth.getUser()?.email || 'No user'}</div>
-      <div data-testid="isAuthenticated">{auth.isAuthenticated() ? 'true' : 'false'}</div>
-      <div data-testid="authLoading">{auth.isLoading() ? 'true' : 'false'}</div>
-      <div data-testid="error">{auth.getError()?.message || 'No error'}</div>
+    <section data-testid="test-component">
+      <p data-testid="user">{auth.getUser()?.email || 'No user'}</p>
+      <p data-testid="isAuthenticated">{auth.isAuthenticated() ? 'true' : 'false'}</p>
+      <p data-testid="authLoading">{auth.isLoading() ? 'true' : 'false'}</p>
+      <p data-testid="error">{auth.getError()?.message || 'No error'}</p>
       <button data-testid="sign-in-btn" onClick={() => auth.signIn('test@example.com', 'password')}>
         Sign In
       </button>
@@ -59,7 +59,7 @@ const TestComponent = () => {
       <button data-testid="refresh-session-btn" onClick={() => auth.refreshSession()}>
         Refresh Session
       </button>
-    </div>
+    </section>
   );
 };
 
@@ -213,17 +213,17 @@ describe('AuthProvider', () => {
         const auth = useAuth();
         
         return (
-          <div>
-            <div data-testid="hasUser">{auth.getUser() !== null ? 'true' : 'false'}</div>
-            <div data-testid="hasSession">{auth.getSession() !== null ? 'true' : 'false'}</div>
-            <div data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasSignUp">{typeof auth.signUp === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasResetPassword">{typeof auth.resetPassword === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasUpdatePassword">{typeof auth.updatePassword === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasRefreshSession">{typeof auth.refreshSession === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasError">{auth.getError() !== null ? 'true' : 'false'}</div>
-          </div>
+          <section>
+            <p data-testid="hasUser">{auth.getUser() !== null ? 'true' : 'false'}</p>
+            <p data-testid="hasSession">{auth.getSession() !== null ? 'true' : 'false'}</p>
+            <p data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasSignUp">{typeof auth.signUp === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasResetPassword">{typeof auth.resetPassword === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasUpdatePassword">{typeof auth.updatePassword === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasRefreshSession">{typeof auth.refreshSession === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasError">{auth.getError() !== null ? 'true' : 'false'}</p>
+          </section>
         );
       };
 
@@ -250,9 +250,9 @@ describe('AuthProvider', () => {
       const TestOutsideProvider = () => {
         try {
           useAuth();
-          return <div data-testid="no-error">No error</div>;
+          return <p data-testid="no-error">No error</p>;
         } catch (error) {
-          return <div data-testid="error">{error.message}</div>;
+          return <p data-testid="error">{error.message}</p>;
         }
       };
 
@@ -270,7 +270,7 @@ describe('AuthProvider', () => {
       );
 
       // Service layer handles session retrieval - just verify component renders
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
 
     it('sets up auth state change listener', () => {
@@ -281,7 +281,7 @@ describe('AuthProvider', () => {
       );
 
       // Service layer handles auth state changes - just verify component renders
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
   });
 });