@jmruthers/pace-core 0.6.10 → 0.6.11

package/src/utils/{__tests__/organisationContext.unit.test.ts → organisationContext.unit.test.ts}

@@ -5,7 +5,7 @@ import {
   clearOrganisationContext,
   getOrganisationContext,
   isOrganisationContextAvailable
-} from '../context/organisationContext';
+} from './context/organisationContext';
 
 describe('organisationContext', () => {
   let mockSupabase: SupabaseClient;
@@ -29,23 +29,19 @@ describe('organisationContext', () => {
       const mockRpc = vi.fn().mockResolvedValue({ error: null });
       mockSupabase.rpc = mockRpc;
 
-      // setOrganisationContext is now a no-op (deprecated)
-      await setOrganisationContext(mockSupabase, organisationId);
-
-      // Should not call rpc since it's a no-op
+      const result = await setOrganisationContext(mockSupabase, organisationId);
+      expect(result.ok).toBe(true);
       expect(mockRpc).not.toHaveBeenCalled();
     });
 
     it('should handle missing supabase client gracefully', async () => {
-      await setOrganisationContext(null as any, 'org-123');
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await setOrganisationContext(null as any, 'org-123');
+      expect(result.ok).toBe(true);
     });
 
     it('should handle missing organisation ID gracefully', async () => {
-      await setOrganisationContext(mockSupabase, '');
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await setOrganisationContext(mockSupabase, '');
+      expect(result.ok).toBe(true);
     });
 
     it('should handle database function not available', async () => {
@@ -54,18 +50,16 @@ describe('organisationContext', () => {
       });
       mockSupabase.rpc = mockRpc;
 
-      await setOrganisationContext(mockSupabase, 'org-123');
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await setOrganisationContext(mockSupabase, 'org-123');
+      expect(result.ok).toBe(true);
     });
 
     it('should handle unexpected errors gracefully', async () => {
       const mockRpc = vi.fn().mockRejectedValue(new Error('Network error'));
       mockSupabase.rpc = mockRpc;
 
-      await setOrganisationContext(mockSupabase, 'org-123');
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await setOrganisationContext(mockSupabase, 'org-123');
+      expect(result.ok).toBe(true);
     });
   });
 
@@ -74,8 +68,8 @@ describe('organisationContext', () => {
       const mockRpc = vi.fn().mockResolvedValue({ error: null });
       mockSupabase.rpc = mockRpc;
 
-      await clearOrganisationContext(mockSupabase);
-
+      const result = await clearOrganisationContext(mockSupabase);
+      expect(result.ok).toBe(true);
       expect(mockRpc).toHaveBeenCalledWith('rbac_audit_log', {
         p_event_type: 'organisation_switched',
         p_metadata: { action: 'clear_context' }
@@ -83,9 +77,8 @@ describe('organisationContext', () => {
     });
 
     it('should handle missing supabase client gracefully', async () => {
-      await clearOrganisationContext(null as any);
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await clearOrganisationContext(null as any);
+      expect(result.ok).toBe(true);
     });
 
     it('should handle database function not available', async () => {
@@ -94,18 +87,18 @@ describe('organisationContext', () => {
       });
       mockSupabase.rpc = mockRpc;
 
-      await clearOrganisationContext(mockSupabase);
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await clearOrganisationContext(mockSupabase);
+      expect(result.ok).toBe(false);
+      expect(result.error.message).toBe('Function not found');
     });
 
     it('should handle unexpected errors gracefully', async () => {
       const mockRpc = vi.fn().mockRejectedValue(new Error('Network error'));
       mockSupabase.rpc = mockRpc;
 
-      await clearOrganisationContext(mockSupabase);
-      // Function should complete without throwing
-      expect(true).toBe(true);
+      const result = await clearOrganisationContext(mockSupabase);
+      expect(result.ok).toBe(false);
+      expect(result.error.message).toContain('Network error');
     });
   });
 
@@ -118,16 +111,14 @@ describe('organisationContext', () => {
       mockSupabase.rpc = mockRpc;
 
       const result = await getOrganisationContext(mockSupabase);
-
-      // Note: Current implementation returns null (not yet implemented)
-      // This is a placeholder until proper context management is added
-      expect(result).toBeNull();
+      expect(result.ok).toBe(true);
+      expect(result.data).toBeNull();
     });
 
     it('should handle missing supabase client gracefully', async () => {
       const result = await getOrganisationContext(null as any);
-
-      expect(result).toBeNull();
+      expect(result.ok).toBe(true);
+      expect(result.data).toBeNull();
     });
 
     it('should handle database function not available', async () => {
@@ -138,8 +129,8 @@ describe('organisationContext', () => {
       mockSupabase.rpc = mockRpc;
 
       const result = await getOrganisationContext(mockSupabase);
-
-      expect(result).toBeNull();
+      expect(result.ok).toBe(true);
+      expect(result.data).toBeNull();
     });
 
     it('should handle unexpected errors gracefully', async () => {
@@ -147,25 +138,23 @@ describe('organisationContext', () => {
       mockSupabase.rpc = mockRpc;
 
       const result = await getOrganisationContext(mockSupabase);
-
-      expect(result).toBeNull();
+      expect(result.ok).toBe(true);
+      expect(result.data).toBeNull();
     });
   });
 
   describe('isOrganisationContextAvailable', () => {
     it('should return false (deprecated function)', async () => {
-      // isOrganisationContextAvailable is deprecated and always returns false
       const result = await isOrganisationContextAvailable(mockSupabase);
-
-      // Should not call RPC since function is deprecated
       expect(mockSupabase.rpc).not.toHaveBeenCalled();
-      expect(result).toBe(false);
+      expect(result.ok).toBe(true);
+      expect(result.data).toBe(false);
     });
 
     it('should return false when supabase client is missing', async () => {
       const result = await isOrganisationContextAvailable(null as any);
-
-      expect(result).toBe(false);
+      expect(result.ok).toBe(true);
+      expect(result.data).toBe(false);
     });
 
     it('should return false when database function has error', async () => {
@@ -175,8 +164,8 @@ describe('organisationContext', () => {
       mockSupabase.rpc = mockRpc;
 
       const result = await isOrganisationContextAvailable(mockSupabase);
-
-      expect(result).toBe(false);
+      expect(result.ok).toBe(true);
+      expect(result.data).toBe(false);
     });
 
     it('should return false when unexpected error occurs', async () => {
@@ -184,8 +173,8 @@ describe('organisationContext', () => {
       mockSupabase.rpc = mockRpc;
 
       const result = await isOrganisationContextAvailable(mockSupabase);
-
-      expect(result).toBe(false);
+      expect(result.ok).toBe(true);
+      expect(result.data).toBe(false);
     });
   });
 }); 

package/src/utils/performance/{__tests__/bundleAnalysis.test.ts → bundleAnalysis.test.ts}

@@ -1,12 +1,12 @@
 /**
  * @file Bundle Analysis Tests
  * @package @jmruthers/pace-core
- * @module Utils/Performance/__tests__
+ * @module Utils/Performance
  * @since 1.0.0
  */
 
 import { describe, it, expect, beforeEach, vi } from 'vitest';
-import { bundleAnalyzer, validateImportPattern, trackDynamicImport } from '../bundleAnalysis';
+import { bundleAnalyzer, validateImportPattern, trackDynamicImport } from './bundleAnalysis';
 
 // Note: import.meta.env cannot be easily mocked in Vitest
 // Tests verify that functions don't throw and handle errors gracefully

package/src/utils/performance/{__tests__/performanceBenchmark.test.ts → performanceBenchmark.test.ts}

@@ -1,12 +1,12 @@
 /**
  * @file Performance Benchmark Tests
  * @package @jmruthers/pace-core
- * @module Utils/Performance/__tests__
+ * @module Utils/Performance
  * @since 1.0.0
  */
 
 import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { createPerformanceBenchmark, measureRenderPerformance } from '../performanceBenchmark';
+import { createPerformanceBenchmark, measureRenderPerformance } from './performanceBenchmark';
 
 // Mock performance API
 const mockPerformance = {

package/src/utils/performance/{__tests__/performanceBudgets.test.ts → performanceBudgets.test.ts}

@@ -1,12 +1,12 @@
 /**
  * @file Performance Budgets Tests
  * @package @jmruthers/pace-core
- * @module Utils/Performance/__tests__
+ * @module Utils/Performance
  * @since 1.0.0
  */
 
 import { describe, it, expect, beforeEach, vi } from 'vitest';
-import { performanceBudgetMonitor, PERFORMANCE_BUDGETS } from '../performanceBudgets';
+import { performanceBudgetMonitor, PERFORMANCE_BUDGETS } from './performanceBudgets';
 
 describe('Performance Budgets', () => {
   beforeEach(() => {

package/src/utils/{__tests__/performanceBenchmark.test.ts → performanceBenchmark.test.ts}

@@ -1,7 +1,7 @@
 /**
  * @file Performance Benchmark Tests
  * @package @jmruthers/pace-core
- * @module Utils/__tests__
+ * @module Utils
  * @since 1.0.0
  *
  * Tests for performance benchmarking utilities.
@@ -11,7 +11,7 @@ import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { 
   createPerformanceBenchmark, 
   measureRenderPerformance
-} from '../performance/performanceBenchmark';
+} from './performance/performanceBenchmark';
 
 describe('Performance Benchmark', () => {
   beforeEach(() => {

package/src/utils/{__tests__/performanceBudgets.unit.test.ts → performanceBudgets.unit.test.ts}

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import { performanceBudgetMonitor, PERFORMANCE_BUDGETS } from '../performance/performanceBudgets';
-import { Logger, LogLevel } from '../core/logger';
+import { performanceBudgetMonitor, PERFORMANCE_BUDGETS } from './performance/performanceBudgets';
+import { Logger, LogLevel } from './core/logger';
 
 describe('performanceBudgets', () => {
   let consoleSpy: {

package/src/utils/{__tests__/permissionTypes.unit.test.ts → permissionTypes.unit.test.ts}

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { PermissionType, parsePermission } from '../permissions/permissionTypes';
+import { PermissionType, parsePermission } from './permissions/permissionTypes';
 
 describe('permissionTypes', () => {
   describe('PermissionType enum', () => {

package/src/utils/{__tests__/permissionUtils.unit.test.ts → permissionUtils.unit.test.ts}

@@ -4,7 +4,7 @@ import {
   hasPermission,
   hasAnyPermission,
   hasAllPermissions
-} from '../permissions/permissionUtils';
+} from './permissions/permissionUtils';
 
 describe('permissionUtils', () => {
   describe('transformPermissionMapToBoolean', () => {

package/src/utils/permissions/{__tests__/permissionTypes.test.ts → permissionTypes.test.ts}

@@ -1,12 +1,12 @@
 /**
  * @file Permission Types Tests
  * @package @jmruthers/pace-core
- * @module Utils/Permissions/__tests__
+ * @module Utils/Permissions
  * @since 1.0.0
  */
 
 import { describe, it, expect } from 'vitest';
-import { parsePermission, PermissionType } from '../permissionTypes';
+import { parsePermission, PermissionType } from './permissionTypes';
 
 describe('Permission Types', () => {
   describe('PermissionType enum', () => {

package/src/utils/persistence/{__tests__/keyDerivation.test.ts → keyDerivation.test.ts}

@@ -1,7 +1,7 @@
 /**
  * @file Key Derivation Tests
  * @package @jmruthers/pace-core
- * @module Utils/Persistence/__tests__
+ * @module Utils/Persistence
  */
 
 import { describe, it, expect } from 'vitest';
@@ -10,7 +10,7 @@ import {
   deriveDialogKey,
   deriveFormKey,
   hashStableFingerprint,
-} from '../keyDerivation';
+} from './keyDerivation';
 
 describe('keyDerivation', () => {
   describe('deriveDataTableKey', () => {

package/src/utils/persistence/{__tests__/sensitiveFieldDetection.test.ts → sensitiveFieldDetection.test.ts}

@@ -1,7 +1,7 @@
 /**
  * @file Sensitive Field Detection Tests
  * @package @jmruthers/pace-core
- * @module Utils/Persistence/__tests__
+ * @module Utils/Persistence
  */
 
 import { describe, it, expect } from 'vitest';
@@ -9,7 +9,7 @@ import {
   isSensitiveField,
   filterSensitiveFields,
   getSensitiveFieldNames,
-} from '../sensitiveFieldDetection';
+} from './sensitiveFieldDetection';
 
 describe('sensitiveFieldDetection', () => {
   describe('isSensitiveField', () => {

package/src/utils/{__tests__/request-deduplication.test.ts → request-deduplication.test.ts}

@@ -1,7 +1,7 @@
 /**
  * @file Request Deduplication Tests
  * @package @jmruthers/pace-core
- * @module Utils/__tests__
+ * @module Utils
  * @since 2.0.0
  */
 
@@ -12,7 +12,7 @@ import {
   clearInFlightRequests,
   getInFlightRequestStats,
   deduplicatedQuery,
-} from '../request-deduplication';
+} from './request-deduplication';
 
 describe('Request Deduplication', () => {
   beforeEach(() => {

package/src/utils/{__tests__/sanitization.unit.test.ts → sanitization.unit.test.ts}

@@ -16,7 +16,7 @@ import {
   sanitizeFormData,
   generateCSPHeader,
   RateLimiter
-} from '../validation/sanitization';
+} from './validation/sanitization';
 import { z } from 'zod';
 
 describe('Sanitization Utilities', () => {

package/src/utils/{__tests__/schemaUtils.unit.test.ts → schemaUtils.unit.test.ts}

@@ -1,6 +1,6 @@
 import { describe, it, expect } from 'vitest';
 import { z } from 'zod';
-import { pickSchema, combineSchemas } from '../validation/schema';
+import { pickSchema, combineSchemas } from './validation/schema';
 
 describe('schemaUtils', () => {
   describe('pickSchema', () => {

package/src/utils/{__tests__/secureDataAccess.unit.test.ts → secureDataAccess.unit.test.ts}

@@ -6,8 +6,8 @@
  */
 
 import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { createSecureDataAccess } from '../security/secureDataAccess';
-import { testDataGenerators } from '../../__tests__/helpers/test-utils';
+import { createSecureDataAccess } from './security/secureDataAccess';
+import { testDataGenerators } from '../__tests__/helpers/test-utils';
 
 // Create a proper mock for Supabase query chain
 const createMockQuery = (returnData: any = null, returnError: any = null) => {

package/src/utils/{__tests__/secureErrors.unit.test.ts → secureErrors.unit.test.ts}

@@ -14,11 +14,11 @@ import {
   sanitizeError, 
   generateRequestId, 
   logSecurityEvent 
-} from '../security/secureErrors';
-import { AuthErrorCode } from '../../types/core';
+} from './security/secureErrors';
+import { AuthErrorCode } from '../types/core';
 
 // Mock the Logger module
-vi.mock('../core/logger', () => {
+vi.mock('./core/logger', () => {
   const mockLoggerInstance = {
     warn: vi.fn(),
   };
@@ -28,7 +28,7 @@ vi.mock('../core/logger', () => {
 });
 
 // Get the mock instance after mock is set up
-import { createLogger } from '../core/logger';
+import { createLogger } from './core/logger';
 const getMockLogger = () => createLogger('test');
 
 describe('Secure Errors', () => {

package/src/utils/{__tests__/secureStorage.unit.test.ts → secureStorage.unit.test.ts}

@@ -6,7 +6,7 @@
  */
 
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import { secureStorage } from '../security/secureStorage';
+import { secureStorage } from './security/secureStorage';
 
 // Mock localStorage
 const mockLocalStorage = {

package/src/utils/security/auth-utils.ts

@@ -2,7 +2,8 @@
  * @file Authentication utilities
  */
 
-import type { User, SupabaseClient } from '@supabase/supabase-js';
+import type { User, Session, SupabaseClient, AuthError } from '@supabase/supabase-js';
+import { ok, err, type ApiResult, type ApiError } from '../../types/api-result';
 
 export interface LoginCredentials {
   email: string;
@@ -14,55 +15,65 @@ export interface SignUpData {
   password: string;
 }
 
-export interface AuthResponse {
-  user?: User;
-  error?: Error;
+/** Success payload for auth operations that return user/session. */
+export interface AuthSessionData {
+  user: User | null;
+  session: Session | null;
 }
 
-export async function signInWithEmail(_credentials: LoginCredentials): Promise<AuthResponse> {
+/**
+ * Maps Error or AuthError to ApiError for consistent API result shape.
+ */
+export function toApiError(error: Error | AuthError): ApiError {
+  const message = error.message || 'An unexpected error occurred';
+  const code =
+    'status' in error && typeof (error as AuthError).status === 'number'
+      ? `AUTH_${(error as AuthError).status}`
+      : error.name || 'AUTH_ERROR';
+  return { code, message };
+}
+
+export async function signInWithEmail(_credentials: LoginCredentials): Promise<ApiResult<AuthSessionData>> {
   try {
     // TODO: Implement actual authentication logic
     // For now, return a proper error response indicating this needs implementation
-    return { 
-      error: new Error('Authentication not yet implemented - placeholder function') 
-    };
+    return err(toApiError(new Error('Authentication not yet implemented - placeholder function')));
   } catch (error) {
-    return { error: error instanceof Error ? error : new Error('Unknown authentication error') };
+    return err(toApiError(error instanceof Error ? error : new Error('Unknown authentication error')));
   }
 }
 
-export async function signUpWithEmail(_data: SignUpData): Promise<AuthResponse> {
+export async function signUpWithEmail(_data: SignUpData): Promise<ApiResult<AuthSessionData>> {
   try {
     // TODO: Implement actual registration logic
     // For now, return a proper error response indicating this needs implementation
-    return { 
-      error: new Error('Registration not yet implemented - placeholder function') 
-    };
+    return err(toApiError(new Error('Registration not yet implemented - placeholder function')));
   } catch (error) {
-    return { error: error instanceof Error ? error : new Error('Unknown registration error') };
+    return err(toApiError(error instanceof Error ? error : new Error('Unknown registration error')));
   }
 }
 
-export async function resetPassword(_email: string): Promise<{ error?: Error }> {
+export async function resetPassword(_email: string): Promise<ApiResult<void>> {
   try {
     // TODO: Implement actual password reset logic
     // For now, return a proper error response indicating this needs implementation
-    return { 
-      error: new Error('Password reset not yet implemented - placeholder function') 
-    };
+    return err(toApiError(new Error('Password reset not yet implemented - placeholder function')));
   } catch (error) {
-    return { error: error instanceof Error ? error : new Error('Unknown password reset error') };
+    return err(toApiError(error instanceof Error ? error : new Error('Unknown password reset error')));
   }
 }
 
-export async function updatePassword(supabaseClient: SupabaseClient, newPassword: string): Promise<{ error?: Error }> {
+export async function updatePassword(supabaseClient: SupabaseClient, newPassword: string): Promise<ApiResult<void>> {
   try {
     const { error } = await supabaseClient.auth.updateUser({
       password: newPassword
     });
-    return { error: error || undefined };
-  } catch (err) {
-    return { error: err as Error };
+    if (error) {
+      return err(toApiError(error));
+    }
+    return ok(undefined);
+  } catch (e) {
+    return err(toApiError(e instanceof Error ? e : new Error('Unknown error updating password')));
   }
 }