@jmruthers/pace-core 0.6.10 → 0.6.11

package/src/components/PaceAppLayout/PaceAppLayout.edge-cases.test.tsx

@@ -43,7 +43,7 @@ import {
 } from './test-setup.tsx';
 
 // Import the hoisted mock for isSuperAdmin
-let mockIsSuperAdmin: ReturnType<typeof vi.fn>;
+let _mockIsSuperAdmin: ReturnType<typeof vi.fn>;
 
 // Override mockLocation pathname for this test file
 mockLocation.pathname = '/dashboard';
@@ -87,7 +87,7 @@ vi.mock('../../hooks/useOrganisations', () => ({
   })),
 }));
 
-// Mock useEvents hook (used by useEventTheme)
+// Mock useEvents and useOptionalEvents (PaceAppLayout uses useOptionalEvents for event context)
 vi.mock('../../hooks/useEvents', () => ({
   useEvents: vi.fn(() => ({
     selectedEvent: { event_id: 'event-123' },
@@ -95,6 +95,9 @@ vi.mock('../../hooks/useEvents', () => ({
     isLoading: false,
     error: null,
   })),
+  useOptionalEvents: vi.fn(() => ({
+    selectedEvent: { event_id: 'event-123' },
+  })),
 }));
 
 // Mock useEventTheme to avoid EventServiceProvider requirement
@@ -152,16 +155,16 @@ vi.mock('@supabase/supabase-js', () => {
 });
 
 // Mock RBAC functions
-const mockIsSuperAdminAPI = vi.hoisted(() => vi.fn().mockResolvedValue(false));
+const mockIsSuperAdminAPI = vi.hoisted(() => vi.fn().mockResolvedValue({ ok: true, data: false }));
 
 vi.mock('../../rbac/api', () => ({
-  isPermitted: vi.fn().mockResolvedValue(true),
-  isPermittedCached: vi.fn().mockResolvedValue(true),
+  isPermitted: vi.fn().mockResolvedValue({ ok: true, data: true }),
+  isPermittedCached: vi.fn().mockResolvedValue({ ok: true, data: true }),
   isSuperAdmin: mockIsSuperAdminAPI,
   setupRBAC: vi.fn(),
-  getPermissionMap: vi.fn().mockResolvedValue({}),
-  getPageScopeType: vi.fn().mockResolvedValue('both'),
-  getAccessLevel: vi.fn().mockResolvedValue('viewer'),
+  getPermissionMap: vi.fn().mockResolvedValue({ ok: true, data: {} }),
+  getPageScopeType: vi.fn().mockResolvedValue({ ok: true, data: 'both' }),
+  getAccessLevel: vi.fn().mockResolvedValue({ ok: true, data: 'viewer' }),
 }));
 
 // Mock RBAC hooks
@@ -207,7 +210,7 @@ vi.mock('../Header', () => ({
     user, 
     onSignOut, 
     onChangePassword, 
-    currentPath, 
+    currentPath: _currentPath, 
     onNavigate, 
     showContextSelector, 
     showOrganisations,
@@ -290,17 +293,17 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
     resetPaceAppLayoutMocks();
     mockLocation.pathname = '/dashboard';
     const rbacApi = await import('../../rbac/api');
-    mockIsSuperAdmin = vi.mocked(rbacApi.isSuperAdmin);
-    mockIsSuperAdminAPI.mockResolvedValue(false);
+    _mockIsSuperAdmin = vi.mocked(rbacApi.isSuperAdmin);
+    mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
     const { isPermitted, isPermittedCached, getPermissionMap, getPageScopeType } = await import('../../rbac/api');
     vi.mocked(isPermitted).mockReset();
-    vi.mocked(isPermitted).mockResolvedValue(true);
+    vi.mocked(isPermitted).mockResolvedValue({ ok: true, data: true });
     vi.mocked(isPermittedCached).mockReset();
-    vi.mocked(isPermittedCached).mockResolvedValue(true);
+    vi.mocked(isPermittedCached).mockResolvedValue({ ok: true, data: true });
     vi.mocked(getPermissionMap).mockReset();
-    vi.mocked(getPermissionMap).mockResolvedValue({});
+    vi.mocked(getPermissionMap).mockResolvedValue({ ok: true, data: {} });
     vi.mocked(getPageScopeType).mockReset();
-    vi.mocked(getPageScopeType).mockResolvedValue('both');
+    vi.mocked(getPageScopeType).mockResolvedValue({ ok: true, data: 'both' });
     mockUseCan.mockReturnValue({
       can: true,
       isLoading: false,
@@ -429,15 +432,18 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
     it('filters navigation items by event scope when event context is selected', async () => {
       const { getPageScopeType, getPermissionMap } = await import('../../rbac/api');
       vi.mocked(getPermissionMap).mockResolvedValue({
-        'read:page.event-page': true,
-        'read:page.org-page': true,
-        'read:page.both-page': true,
-        '*': false, // Not super admin
+        ok: true,
+        data: {
+          'read:page.event-page': true,
+          'read:page.org-page': true,
+          'read:page.both-page': true,
+          '*': false,
+        },
       });
       vi.mocked(getPageScopeType)
-        .mockResolvedValueOnce('event') // First item is event-scoped
-        .mockResolvedValueOnce('organisation') // Second item is org-scoped
-        .mockResolvedValueOnce('both'); // Third item is both
+        .mockResolvedValueOnce({ ok: true, data: 'event' })
+        .mockResolvedValueOnce({ ok: true, data: 'organisation' })
+        .mockResolvedValueOnce({ ok: true, data: 'both' });
 
       const navItems = [
         { id: 'event-page', label: 'Event Page', href: '/event-page', icon: 'Calendar' },
@@ -482,24 +488,27 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
     });
 
     it('filters navigation items by organisation scope when only org context is selected', async () => {
-      // Mock no event context by making useEvents throw
-      const { useEvents } = await import('../../hooks/useEvents');
-      const originalUseEvents = vi.mocked(useEvents);
-      vi.mocked(useEvents).mockImplementation(() => {
-        throw new Error('Event provider not available');
-      });
+      // Mock no event context: useOptionalEvents returns selectedEvent null
+      const { useOptionalEvents } = await import('../../hooks/useEvents');
+      const originalUseOptionalEvents = vi.mocked(useOptionalEvents);
+      vi.mocked(useOptionalEvents).mockImplementation(() => ({
+        selectedEvent: null,
+      }));
 
       const { getPageScopeType, getPermissionMap } = await import('../../rbac/api');
       vi.mocked(getPermissionMap).mockResolvedValue({
-        'read:page.event-page': true,
-        'read:page.org-page': true,
-        'read:page.both-page': true,
-        '*': false, // Not super admin
+        ok: true,
+        data: {
+          'read:page.event-page': true,
+          'read:page.org-page': true,
+          'read:page.both-page': true,
+          '*': false,
+        },
       });
       vi.mocked(getPageScopeType)
-        .mockResolvedValueOnce('event') // First item is event-scoped
-        .mockResolvedValueOnce('organisation') // Second item is org-scoped
-        .mockResolvedValueOnce('both'); // Third item is both
+        .mockResolvedValueOnce({ ok: true, data: 'event' })
+        .mockResolvedValueOnce({ ok: true, data: 'organisation' })
+        .mockResolvedValueOnce({ ok: true, data: 'both' });
 
       const navItems = [
         { id: 'event-page', label: 'Event Page', href: '/event-page', icon: 'Calendar' },
@@ -543,18 +552,21 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
       }, { timeout: 10000 });
 
       // Restore original mock
-      vi.mocked(useEvents).mockImplementation(originalUseEvents);
+      vi.mocked(useOptionalEvents).mockImplementation(originalUseOptionalEvents);
     });
 
     it('falls back to permission-only filtering when scope type check fails', async () => {
       const { getPageScopeType, getPermissionMap } = await import('../../rbac/api');
       vi.mocked(getPermissionMap).mockResolvedValue({
-        'read:page.event-page': true,
-        'read:page.org-page': true,
+        ok: true,
+        data: {
+          'read:page.event-page': true,
+          'read:page.org-page': true,
+        },
       });
       vi.mocked(getPageScopeType)
-        .mockRejectedValueOnce(new Error('Database error'))
-        .mockRejectedValueOnce(new Error('Database error'));
+        .mockResolvedValueOnce({ ok: false, error: { code: 'RBAC_ERROR', message: 'Database error' } })
+        .mockResolvedValueOnce({ ok: false, error: { code: 'RBAC_ERROR', message: 'Database error' } });
 
       const navItems = [
         { id: 'event-page', label: 'Event Page', href: '/event-page', icon: 'Calendar' },
@@ -585,19 +597,22 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
     });
 
     it('handles empty navigation when all items are filtered by scope', async () => {
-      // Mock no event context by making useEvents throw
-      const { useEvents } = await import('../../hooks/useEvents');
-      const originalUseEvents = vi.mocked(useEvents);
-      vi.mocked(useEvents).mockImplementation(() => {
-        throw new Error('Event provider not available');
-      });
+      // Mock no event context: useOptionalEvents returns selectedEvent null
+      const { useOptionalEvents } = await import('../../hooks/useEvents');
+      const originalUseOptionalEvents = vi.mocked(useOptionalEvents);
+      vi.mocked(useOptionalEvents).mockImplementation(() => ({
+        selectedEvent: null,
+      }));
 
       const { getPageScopeType, getPermissionMap } = await import('../../rbac/api');
       vi.mocked(getPermissionMap).mockResolvedValue({
-        'read:page.event-page': true,
-        '*': false, // Not super admin
+        ok: true,
+        data: {
+          'read:page.event-page': true,
+          '*': false,
+        },
       });
-      vi.mocked(getPageScopeType).mockResolvedValue('event'); // All items are event-scoped
+      vi.mocked(getPageScopeType).mockResolvedValue({ ok: true, data: 'event' });
 
       const navItems = [
         { id: 'event-page', label: 'Event Page', href: '/event-page', icon: 'Calendar' },
@@ -636,7 +651,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
       }, { timeout: 10000 });
 
       // Restore original mock
-      vi.mocked(useEvents).mockImplementation(originalUseEvents);
+      vi.mocked(useOptionalEvents).mockImplementation(originalUseOptionalEvents);
     });
   });
 
@@ -744,7 +759,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
         hasValidOrganisationContext: false,
       });
 
-      mockIsSuperAdminAPI.mockResolvedValue(true);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: true });
       mockUseRBAC.mockReturnValue({
         isSuperAdmin: true,
         isLoading: false,
@@ -781,7 +796,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
         hasValidOrganisationContext: false,
       });
 
-      mockIsSuperAdminAPI.mockResolvedValue(false);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
       mockUseRBAC.mockReturnValue({
         isSuperAdmin: false,
         isLoading: false,
@@ -850,7 +865,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
         'read:page.settings': true,
         'read:page.admin': false,
       };
-      vi.mocked(getPermissionMap).mockResolvedValue(mockPermissionMap);
+      vi.mocked(getPermissionMap).mockResolvedValue({ ok: true, data: mockPermissionMap });
 
       const navItems = [
         { id: 'dashboard', label: 'Dashboard', href: '/dashboard', icon: 'LayoutDashboard' },
@@ -888,7 +903,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
         'read:page.settings': false, // No permission
         'read:page.admin': true,
       };
-      vi.mocked(getPermissionMap).mockResolvedValue(mockPermissionMap);
+      vi.mocked(getPermissionMap).mockResolvedValue({ ok: true, data: mockPermissionMap });
 
       const navItems = [
         { id: 'dashboard', label: 'Dashboard', href: '/dashboard', icon: 'LayoutDashboard' },
@@ -924,7 +939,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
 
   describe('Audit Logging', () => {
     it('logs strict mode violations when enabled', async () => {
-      mockIsSuperAdminAPI.mockResolvedValue(false);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
       mockUseCan.mockReturnValue({
         can: false,
         isLoading: false,
@@ -964,7 +979,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
 
     it('calls onStrictModeViolation callback when provided', async () => {
       const onStrictModeViolation = vi.fn();
-      mockIsSuperAdminAPI.mockResolvedValue(false);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
       mockUseCan.mockReturnValue({
         can: false,
         isLoading: false,
@@ -995,7 +1010,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
 
     it('calls onPageAccessDenied callback when access is denied', async () => {
       const onPageAccessDenied = vi.fn();
-      mockIsSuperAdminAPI.mockResolvedValue(false);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
       mockUseCan.mockReturnValue({
         can: false,
         isLoading: false,
@@ -1029,7 +1044,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
       const pageFallback = <div data-testid="page-fallback">Page Access Denied</div>;
       const generalFallback = <div data-testid="general-fallback">General Access Denied</div>;
       
-      mockIsSuperAdminAPI.mockResolvedValue(false);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
       mockUseCan.mockReturnValue({
         can: false,
         isLoading: false,
@@ -1064,7 +1079,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
       const pageFallback = <div data-testid="page-fallback">Page Access Denied</div>;
       const generalFallback = <div data-testid="general-fallback">General Access Denied</div>;
       
-      mockIsSuperAdminAPI.mockResolvedValue(false);
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: false });
       mockUseCan.mockReturnValue({
         can: false,
         isLoading: false,
@@ -1109,7 +1124,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
         roleMap: {},
       });
 
-      mockIsSuperAdminAPI.mockResolvedValue(true); // Direct check returns true
+      mockIsSuperAdminAPI.mockResolvedValue({ ok: true, data: true }); // Direct check returns true
 
       renderWithProviders(
         <TestWrapper>
@@ -1188,7 +1203,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
         expect(screen.getByTestId('header')).toBeInTheDocument();
       }, { timeout: 2000 });
 
-      const initialCallCount = callCount;
+      const _initialCallCount = callCount;
 
       // Re-render with same props
       rerender(
@@ -1217,7 +1232,7 @@ describe('PaceAppLayout Edge Cases and Complex Scenarios', () => {
       ];
 
       const { isPermittedCached } = await import('../../rbac/api');
-      vi.mocked(isPermittedCached).mockResolvedValue(true);
+      vi.mocked(isPermittedCached).mockResolvedValue({ ok: true, data: true });
 
       renderWithProviders(
         <TestWrapper>

package/src/components/PaceAppLayout/PaceAppLayout.integration.test.tsx

@@ -837,7 +837,7 @@ describe('PaceAppLayout Integration', () => {
       expect(screen.getByRole('contentinfo')).toBeInTheDocument(); // footer
       
       const main = screen.getByTestId('mock-outlet').parentElement;
-      expect(main).toHaveClass('px-4', 'w-[min(var(--app-width),100%)]', 'mx-auto', 'py-8');
+      expect(main).toHaveClass('px-4', 'w-full', 'max-w-app-content-max', 'mx-auto', 'py-8');
     });
 
     it('ensures main content area grows to fill available space', () => {
@@ -848,7 +848,7 @@ describe('PaceAppLayout Integration', () => {
       );
       
       const main = screen.getByTestId('mock-outlet').parentElement;
-      expect(main).toHaveClass('px-4', 'w-[min(var(--app-width),100%)]', 'mx-auto', 'py-8');
+      expect(main).toHaveClass('px-4', 'w-full', 'max-w-app-content-max', 'mx-auto', 'py-8');
     });
 
     it('integrates custom header className', () => {
@@ -868,7 +868,7 @@ describe('PaceAppLayout Integration', () => {
         </TestWrapper>
       );
       
-      expect(screen.getByTestId('mock-header')).toHaveClass('sticky', 'top-0', 'z-[40]', 'w-full');
+      expect(screen.getByTestId('mock-header')).toHaveClass('sticky', 'top-0', 'z-header', 'w-full');
     });
   });
 

package/src/components/PaceAppLayout/PaceAppLayout.security.test.tsx

@@ -58,7 +58,7 @@ const createMockSupabaseClient = vi.hoisted(() => {
   });
 });
 
-// Mock OrganisationProvider - hoist so it's available in mock factories
+// Mock useOrganisations hook - hoist so it's available in mock factories
 const mockOrganisation = vi.hoisted(() => ({
   id: 'test-org-id',
   name: 'Test Organisation',
@@ -202,7 +202,7 @@ vi.mock('../../hooks/useEventTheme', () => ({
 // CRITICAL: All mocks must resolve immediately to prevent test hanging
 const mockIsPermitted = vi.hoisted(() => vi.fn().mockResolvedValue(true));
 const mockCheckPermission = vi.hoisted(() => vi.fn().mockResolvedValue(true));
-const mockIsSuperAdmin = vi.hoisted(() => vi.fn().mockResolvedValue(false));
+const mockIsSuperAdmin = vi.hoisted(() => vi.fn().mockResolvedValue({ ok: true, data: false }));
 
 // Define RBAC hook mocks using vi.hoisted() so they're available in hoisted vi.mock factories
 const mockHasPermissionRBAC = vi.hoisted(() => vi.fn().mockResolvedValue(true));
@@ -293,9 +293,9 @@ vi.mock('@supabase/supabase-js', () => {
 vi.mock('../../rbac/api', () => {
   return {
     isPermitted: mockIsPermitted,
-    isPermittedCached: vi.fn().mockResolvedValue(true),
-    getPermissionMap: vi.fn().mockResolvedValue({}),
-    getAccessLevel: vi.fn().mockResolvedValue('viewer'),
+    isPermittedCached: vi.fn().mockResolvedValue({ ok: true, data: true }),
+    getPermissionMap: vi.fn().mockResolvedValue({ ok: true, data: {} }),
+    getAccessLevel: vi.fn().mockResolvedValue({ ok: true, data: 'viewer' }),
     isSuperAdmin: mockIsSuperAdmin,
     setupRBAC: vi.fn().mockResolvedValue(undefined),
   };
@@ -409,7 +409,7 @@ describe('PaceAppLayout Security', () => {
     // CRITICAL: Ensure all async mocks resolve immediately to prevent hanging
     // Reset super admin mock - must resolve immediately
     mockIsSuperAdmin.mockClear();
-    mockIsSuperAdmin.mockResolvedValue(false);
+    mockIsSuperAdmin.mockResolvedValue({ ok: true, data: false });
     
     // Reset RBAC hook mocks - must return immediately (not async)
     mockHasPermissionRBAC.mockClear();
@@ -476,7 +476,7 @@ describe('PaceAppLayout Security', () => {
 
     it('prevents access when user lacks permission', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
-      mockIsSuperAdmin.mockResolvedValueOnce(false);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: false });
       
       // Mock useCan to return false (deny access)
       mockUseCan.mockReturnValue({
@@ -530,7 +530,7 @@ describe('PaceAppLayout Security', () => {
 
     it('handles permission check failures securely', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
-      mockIsSuperAdmin.mockResolvedValueOnce(false);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: false });
       
       // Mock useCan to return an error state
       mockUseCan.mockReturnValue({
@@ -750,8 +750,7 @@ describe('PaceAppLayout Security', () => {
       };
       
       // Test that organisation context is properly isolated
-      vi.doMock('../../../providers/OrganisationProvider', () => ({
-        OrganisationProvider: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+      vi.doMock('../../../hooks/useOrganisations', () => ({
         useOrganisations: () => ({
           ...mockOrganisationContext,
           selectedOrganisation: org1
@@ -765,8 +764,7 @@ describe('PaceAppLayout Security', () => {
       );
       
       // Change organisation context
-      vi.doMock('../../../providers/OrganisationProvider', () => ({
-        OrganisationProvider: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+      vi.doMock('../../../hooks/useOrganisations', () => ({
         useOrganisations: () => ({
           ...mockOrganisationContext,
           selectedOrganisation: org2
@@ -869,7 +867,7 @@ describe('PaceAppLayout Security', () => {
 
     it('handles permission errors securely', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
-      mockIsSuperAdmin.mockResolvedValueOnce(false);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: false });
       
       // Mock useCan to return false (deny access)
       mockUseCan.mockReturnValue({
@@ -898,7 +896,7 @@ describe('PaceAppLayout Security', () => {
 
     it('prevents information leakage in error messages', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
-      mockIsSuperAdmin.mockResolvedValueOnce(false);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: false });
       
       // Mock useCan to return an error with sensitive information
       const sensitiveError = new Error('Database connection failed: password=secret123');
@@ -956,8 +954,7 @@ describe('PaceAppLayout Security', () => {
 
     it('handles organisation context loss securely', { timeout: 10000 }, () => {
       // Mock organisation context becoming invalid
-      vi.doMock('../../../providers/OrganisationProvider', () => ({
-        OrganisationProvider: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+      vi.doMock('../../../hooks/useOrganisations', () => ({
         useOrganisations: () => ({
           ...mockOrganisationContext,
           hasValidOrganisationContext: false,
@@ -1009,7 +1006,7 @@ describe('PaceAppLayout Security', () => {
 
     it('allows super admin to bypass all permission checks', { timeout: 3000 }, async () => {
       // Mock super admin status
-      mockIsSuperAdmin.mockResolvedValueOnce(true);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: true });
       
       // Mock useCan to return false (would normally deny access)
       mockUseCan.mockReturnValueOnce({
@@ -1042,7 +1039,7 @@ describe('PaceAppLayout Security', () => {
 
     it('does not log strict mode violations for super admins', { timeout: 5000 }, async () => {
       // Mock super admin status (resolve immediately)
-      mockIsSuperAdmin.mockResolvedValueOnce(true);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: true });
       
       // Mock useCan to return false (would normally trigger violation)
       mockUseCan.mockReturnValue({
@@ -1113,7 +1110,7 @@ describe('PaceAppLayout Security', () => {
       mockLocation.pathname = '/admin';
       
       // Ensure super admin check completes first
-      mockIsSuperAdmin.mockResolvedValueOnce(false);
+      mockIsSuperAdmin.mockResolvedValueOnce({ ok: true, data: false });
       
       // Mock useCan to return false (deny admin access)
       mockUseCan.mockReturnValue({