@jbrowse/plugin-alignments 2.2.0 → 2.2.2

package/src/BamAdapter/MismatchParser.test.ts

@@ -139,79 +139,88 @@ test('more skip', () => {
       (a, b) => a.start - b.start,
     ),
   ).toMatchInlineSnapshot(`
-    Array [
-      Object {
+    [
+      {
         "altbase": "G",
         "base": "A",
         "length": 1,
+        "qual": undefined,
         "start": 6,
         "type": "mismatch",
       },
-      Object {
+      {
         "altbase": "C",
         "base": "A",
         "length": 1,
+        "qual": undefined,
         "start": 11,
         "type": "mismatch",
       },
-      Object {
+      {
         "base": "1",
         "length": 0,
         "start": 31,
         "type": "insertion",
       },
-      Object {
+      {
         "altbase": "G",
         "base": "C",
         "length": 1,
+        "qual": undefined,
         "start": 32,
         "type": "mismatch",
       },
-      Object {
+      {
         "altbase": "A",
         "base": "C",
         "length": 1,
+        "qual": undefined,
         "start": 34,
         "type": "mismatch",
       },
-      Object {
+      {
         "altbase": "C",
         "base": "C",
         "length": 1,
+        "qual": undefined,
         "start": 40,
         "type": "mismatch",
       },
-      Object {
+      {
         "altbase": "A",
         "base": "C",
         "length": 1,
+        "qual": undefined,
         "start": 46,
         "type": "mismatch",
       },
-      Object {
+      {
         "base": "*",
         "length": 1,
         "start": 48,
         "type": "deletion",
       },
-      Object {
+      {
         "altbase": "A",
         "base": "G",
         "length": 1,
+        "qual": undefined,
         "start": 52,
         "type": "mismatch",
       },
-      Object {
+      {
         "altbase": "G",
         "base": "G",
         "length": 1,
+        "qual": undefined,
         "start": 68,
         "type": "mismatch",
       },
-      Object {
+      {
         "altbase": "G",
         "base": "G",
         "length": 1,
+        "qual": undefined,
         "start": 70,
         "type": "mismatch",
       },

package/src/BamAdapter/MismatchParser.ts

@@ -16,7 +16,7 @@ export function parseCigar(cigar = '') {
 }
 export function cigarToMismatches(
   ops: string[],
-  seq: string,
+  seq?: string,
   ref?: string,
   qual?: Buffer,
 ): Mismatch[] {
@@ -70,7 +70,7 @@ export function cigarToMismatches(
         length: len,
       })
     } else if (op === 'X') {
-      const r = seq.slice(soffset, soffset + len)
+      const r = seq?.slice(soffset, soffset + len) || []
       const q = qual?.slice(soffset, soffset + len) || []
 
       for (let j = 0; j < len; j++) {
@@ -195,10 +195,7 @@ export function mdToMismatches(
         }
         const s = getTemplateCoordLocal(curr.start)
         curr.base = seq[s] || 'X'
-        const qualScore = qual?.[s]
-        if (qualScore) {
-          curr.qual = qualScore
-        }
+        curr.qual = qual?.[s]
         curr.altbase = token
         nextRecord()
       }
@@ -209,8 +206,8 @@ export function mdToMismatches(
 
 export function getMismatches(
   cigar: string,
-  md: string,
-  seq: string,
+  md?: string,
+  seq?: string,
   ref?: string,
   qual?: Buffer,
 ): Mismatch[] {
@@ -223,7 +220,7 @@ export function getMismatches(
   }
 
   // now let's look for CRAM or MD mismatches
-  if (md) {
+  if (md && seq) {
     mismatches = mismatches.concat(
       mdToMismatches(md, ops, mismatches, seq, qual),
     )
@@ -332,7 +329,7 @@ export function getModificationTypes(mm: string) {
 
       const matches = basemod.match(modificationRegex)
       if (!matches) {
-        throw new Error('bad format for MM tag')
+        throw new Error(`bad format for MM tag: ${mm}`)
       }
       const [, , , typestr] = matches