@itwin/core-geometry 5.2.0-dev.8 → 5.2.1

package/lib/esm/curve/Arc3d.js

@@ -262,16 +262,31 @@ export class Arc3d extends CurvePrimitive {
     setRefs(center, matrix, sweep) {
         this._center = center;
         this._matrix = matrix;
-        this._sweep = sweep;
+        sweep.clampToFullCircle(this._sweep);
     }
     /**
-     * Redefine the arc with (clones of) given data.
-     * @param center arc center.
-     * @param matrix matrix with columns vector0, vector90, and their unit cross product.
-     * @param sweep angle sweep.
+     * Redefine the arc with (copies of) the given data.
+     * * Even if an input is omitted, the corresponding instance data is set to the default value.
+     * * For example, all default inputs result in a unit circle centered at the origin in the xy-plane.
+     * @param center arc center. Default is zero.
+     * @param matrix matrix with columns vector0, vector90, and their unit cross product. Default is identity.
+     * @param sweep angle sweep. Default is full sweep.
+     * @returns the instance
      */
     set(center, matrix, sweep) {
-        this.setRefs(center.clone(), matrix.clone(), sweep ? sweep.clone() : AngleSweep.create360());
+        if (center)
+            this._center.setFrom(center);
+        else
+            this._center.setZero();
+        if (matrix)
+            this._matrix.setFrom(matrix);
+        else
+            this._matrix.setIdentity();
+        if (sweep)
+            sweep.clampToFullCircle(this._sweep);
+        else
+            AngleSweep.create360(0, this._sweep);
+        return this;
     }
     /** Copy center, matrix, and sweep from other Arc3d. */
     setFrom(other) {
@@ -285,17 +300,16 @@ export class Arc3d extends CurvePrimitive {
     }
     /**
      * Create an arc, capturing references to center, matrix and sweep.
-     * @param center center point.
-     * @param matrix matrix with columns vector0, vector90, and their unit cross product.
-     * @param sweep sweep limits.
-     * @param result optional preallocated result.
+     * * Default inputs construct a unit circle centered at the origin in the xy-plane.
+     * @param center center point. Default is zero.
+     * @param matrix matrix with columns vector0, vector90, and their unit cross product. Default is identity.
+     * @param sweep sweep limits. Default is full sweep.
+     * @param result optional preallocated result to receive copies of the inputs (or default values) and return.
      */
     static createRefs(center, matrix, sweep, result) {
-        if (result) {
-            result.setRefs(center, matrix, sweep);
-            return result;
-        }
-        return new Arc3d(center, matrix, sweep);
+        if (result)
+            return result.set(center, matrix, sweep);
+        return new Arc3d(center ?? Point3d.createZero(), matrix ?? Matrix3d.createIdentity(), sweep ?? AngleSweep.create360());
     }
     /**
      * Create an arc from center, x column to be scaled, and y column to be scaled.
@@ -333,8 +347,10 @@ export class Arc3d extends CurvePrimitive {
      */
     static create(center, vector0, vector90, sweep, result) {
         const normal = vector0.unitCrossProductWithDefault(vector90, 0, 0, 0); // normal will be 000 for degenerate case
-        const matrix = Matrix3d.createColumns(vector0, vector90, normal);
-        return Arc3d.createRefs(center !== undefined ? center.clone() : Point3d.create(0, 0, 0), matrix, sweep ? sweep.clone() : AngleSweep.create360(), result);
+        const matrix = Matrix3d.createColumns(vector0, vector90, normal, result?._matrix);
+        if (result)
+            return result.set(center, matrix, sweep);
+        return this.createRefs(center?.clone(), matrix, sweep?.clone());
     }
     /**
      * Create an elliptical arc from three points on the ellipse: two points on an axis and one in between.
@@ -421,9 +437,10 @@ export class Arc3d extends CurvePrimitive {
      * @param start start point of the arc.
      * @param end end point of the arc.
      * @param helper a third point near the arc in its plane, or a vector in the direction of the arc normal.
+     * @param result optional preallocated result to populate and return.
      * @returns the constructed arc, or undefined if desired arc cannot be constructed.
      */
-    static createCircularStartEndRadius(start, end, radius, helper) {
+    static createCircularStartEndRadius(start, end, radius, helper, result) {
         // Construct a line segment from start to end. It is a chord of the circle,
         // so the circle center is on its perpendicular bisector.
         const semiChordLen2 = 0.25 * start.distanceSquared(end);
@@ -441,13 +458,14 @@ export class Arc3d extends CurvePrimitive {
         // the normal and chord direction give us the side of the chord on which the center resides
         if (!normal.normalizeInPlace() || !normal.crossProductStartEnd(start, end, vecToCenter).scaleToLength(height, vecToCenter))
             return undefined;
-        const center = Point3d.createZero();
+        const center = Point3d.createZero(result?.centerRef);
         start.interpolate(0.5, end, center).addInPlace(vecToCenter);
         const vector0 = Vector3d.createStartEnd(center, start, this._workVectorW);
         const endVector = Vector3d.createStartEnd(center, end, this._workVectorV); // reuse static
-        const sweep = AngleSweep.create(vector0.signedAngleTo(endVector, normal));
+        const sweep = AngleSweep.createStartEndRadians(0, vector0.signedRadiansTo(endVector, normal), result?.sweep);
         const vector90 = normal.crossProduct(vector0, this._workVectorV); // has length radius (reuse static)
-        return Arc3d.createRefs(center, Matrix3d.createColumns(vector0, vector90, normal), sweep);
+        const matrix = Matrix3d.createColumns(vector0, vector90, normal, result?.matrixRef);
+        return this.createRefs(center, matrix, sweep, result);
     }
     /**
      * Return a clone of this arc, projected to given z value.
@@ -966,28 +984,39 @@ export class Arc3d extends CurvePrimitive {
         result.set(plane.altitude(this._center), plane.velocityXYZ(this._matrix.coffs[0], this._matrix.coffs[3], this._matrix.coffs[6]), plane.velocityXYZ(this._matrix.coffs[1], this._matrix.coffs[4], this._matrix.coffs[7]));
         return result;
     }
-    /** Create a new arc which is a unit circle in the xy-plane centered at the origin. */
-    static createUnitCircle() {
-        return Arc3d.createRefs(Point3d.create(0, 0, 0), Matrix3d.createIdentity(), AngleSweep.create360());
+    /**
+     * Create a new arc which is a unit circle in the xy-plane centered at the origin.
+     * @param result optional preallocated object to populate and return.
+     */
+    static createUnitCircle(result) {
+        return Arc3d.createRefs(undefined, undefined, undefined, result);
     }
     /**
      * Create a new arc which is parallel to the xy plane, with given center and radius and optional angle sweep.
      * @param center center of arc.
      * @param radius radius of arc.
      * @param sweep sweep limits; defaults to full circle.
+     * @param result optional preallocated object to populate and return.
      */
-    static createXY(center, radius, sweep = AngleSweep.create360()) {
-        return new Arc3d(center.clone(), Matrix3d.createScale(radius, radius, 1.0), sweep.clone());
+    static createXY(center, radius, sweep, result) {
+        const matrix = Matrix3d.createScale(radius, radius, 1.0, result?.matrixRef);
+        if (result)
+            return result.set(center, matrix, sweep);
+        return Arc3d.createRefs(center.clone(), matrix, sweep?.clone());
     }
     /**
      * Create a new arc which is parallel to the xy plane, with given center and x,y radii, and optional angle sweep
      * @param center center of ellipse.
      * @param radiusA x axis radius.
      * @param radiusB y axis radius.
-     * @param sweep angle sweep.
+     * @param sweep angle sweep. Default is full circle.
+     * @param result optional preallocated object to populate and return.
      */
-    static createXYEllipse(center, radiusA, radiusB, sweep = AngleSweep.create360()) {
-        return new Arc3d(center.clone(), Matrix3d.createScale(radiusA, radiusB, 1.0), sweep.clone());
+    static createXYEllipse(center, radiusA, radiusB, sweep, result) {
+        const matrix = Matrix3d.createScale(radiusA, radiusB, 1.0, result?.matrixRef);
+        if (result)
+            return result.set(center, matrix, sweep);
+        return Arc3d.createRefs(center.clone(), matrix, sweep?.clone());
     }
     /**
      * Replace the arc's 0 and 90 degree vectors.
@@ -1273,16 +1302,14 @@ export class Arc3d extends CurvePrimitive {
     }
     /** Return the (signed) area between (a fractional portion of) the arc and the chord between those points. */
     areaToChordXY(fraction0, fraction1) {
-        let detJ = Geometry.crossProductXYXY(this._matrix.coffs[0], this._matrix.coffs[3], this._matrix.coffs[1], this._matrix.coffs[4]);
-        // areas in arc of unit circle with radians limits
+        const detJ = Geometry.crossProductXYXY(this._matrix.coffs[0], this._matrix.coffs[3], this._matrix.coffs[1], this._matrix.coffs[4]); // area scale factor from local to world
         const radians0 = this._sweep.fractionToRadians(fraction0);
         const radians1 = this._sweep.fractionToRadians(fraction1);
-        // const midRadians = 0.5 * (radians0 + radians1);
-        const alpha = 0.5 * (radians1 - radians0);
-        if (alpha < 0.0)
-            detJ = -detJ;
+        const alpha = 0.5 * (radians1 - radians0); // signed area of local sector
+        // Compute signed area of local triangle ("wedge") formed by origin and arc endpoints p0, p1:
+        // (p0 x p1)/2 = (cos(r0)sin(r1)-cos(r1)sin(r0))/2 = sin(r1-r0)/2 = cos(a)sin(a)
         const wedgeArea = Math.cos(alpha) * Math.sin(alpha);
-        return (alpha - wedgeArea) * detJ;
+        return (alpha - wedgeArea) * detJ; // to world
     }
     /**
      * Construct an offset of the instance curve as viewed in the xy-plane (ignoring z).
@@ -1302,13 +1329,10 @@ export class Arc3d extends CurvePrimitive {
                 && (this.isCircular || (!Geometry.isSmallMetricDistance(r90new) && (r90 * r90new > 0.0)))) {
                 const factor0 = r0new / r0;
                 const factor90 = this.isCircular ? factor0 : r90new / r90;
-                const matrix = arcXY.matrixClone();
-                matrix.scaleColumnsInPlace(factor0, factor90, 1.0);
-                return Arc3d.createRefs(arcXY.center.clone(), matrix, arcXY.sweep.clone());
-            }
-            else {
-                return undefined; // zero radius
+                arcXY.matrixRef.scaleColumnsInPlace(factor0, factor90, 1.0);
+                return arcXY;
             }
+            return undefined; // zero radius
         }
         // default impl
         const handler = new CurveOffsetXYHandler(this, options.leftOffsetDistance);