@itwin/core-geometry 4.3.0-dev.9 → 4.4.0-dev.1

package/lib/esm/serialization/GeometrySamples.js

@@ -9,7 +9,7 @@ import { BezierCurve3d } from "../bspline/BezierCurve3d";
 import { BezierCurve3dH } from "../bspline/BezierCurve3dH";
 import { BSplineCurve3d } from "../bspline/BSplineCurve";
 import { BSplineCurve3dH } from "../bspline/BSplineCurve3dH";
-import { BSplineSurface3d, BSplineSurface3dH, WeightStyle } from "../bspline/BSplineSurface";
+import { BSplineSurface3d, BSplineSurface3dH, UVSelect, WeightStyle } from "../bspline/BSplineSurface";
 import { InterpolationCurve3d, InterpolationCurve3dOptions } from "../bspline/InterpolationCurve3d";
 import { BSplineWrapMode, KnotVector } from "../bspline/KnotVector";
 import { ClipPlane } from "../clipping/ClipPlane";
@@ -1102,8 +1102,8 @@ class Sample {
      */
     static createPseudoTorusBsplineSurface(radiusU, radiusV, numU, numV, orderU, orderV) {
         const points = [];
-        const numUPole = numU + orderU - 1;
-        const numVPole = numV + orderV - 1;
+        const numUPole = numU + orderU - 1; // degreeU wrap-around poles
+        const numVPole = numV + orderV - 1; // degreeV wrap-around poles
         const uKnots = KnotVector.createUniformWrapped(numU, orderU - 1, 0, 1);
         const vKnots = KnotVector.createUniformWrapped(numV, orderV - 1, 0, 1);
         const dURadians = 2.0 * Math.PI / numU;
@@ -1122,8 +1122,8 @@ class Sample {
         }
         const result = BSplineSurface3d.create(points, numUPole, orderU, uKnots.knots, numVPole, orderV, vKnots.knots);
         if (result) {
-            result.setWrappable(0, BSplineWrapMode.OpenByAddingControlPoints);
-            result.setWrappable(1, BSplineWrapMode.OpenByAddingControlPoints);
+            result.setWrappable(UVSelect.uDirection, BSplineWrapMode.OpenByAddingControlPoints);
+            result.setWrappable(UVSelect.vDirection, BSplineWrapMode.OpenByAddingControlPoints);
         }
         return result;
     }
@@ -1159,10 +1159,8 @@ class Sample {
             controlPoints.push(Sample.createBsplineArc90SectionToXYZWArrays(center, axes, r0, r90, false));
         }
         const result = BSplineSurface3dH.createGrid(controlPoints, WeightStyle.WeightsSeparateFromCoordinates, 3, uKnots, 2, vKnots);
-        // if (result) {
-        // result.setWrappable(0, BSplineWrapMode.OpenByAddingControlPoints);
-        // result.setWrappable(1, BSplineWrapMode.OpenByAddingControlPoints);
-        // }
+        if (result)
+            result.setWrappable(UVSelect.uDirection, BSplineWrapMode.OpenByRemovingKnots);
         return result;
     }
     /** Create bspline surface on xy grid with weights. */