@itwin/core-geometry 4.10.0-dev.2 → 4.10.0-dev.22

package/lib/cjs/numerics/Polynomials.js

@@ -828,7 +828,7 @@ class AnalyticRoots {
             // EDL April 5, 2020 replace classic GraphicsGems solver by RWDNickalls.
             // Don't know if improveRoots is needed.
             // Breaks in AnalyticRoots.test.ts checkQuartic suggest it indeed converts many e-16 errors to zero.
-            //  e-13 cases are unaffected
+            // e-13 cases are unaffected
             this.improveRoots(c, 3, results, false);
         }
         else {
@@ -837,49 +837,46 @@ class AnalyticRoots {
         // this.appendCubicRootsUnsorted(c, results);
         results.sort();
     }
-    /** Compute roots of quartic 'c[0] + c[1] * x + c[2] * x^2 + c[3] * x^3 + c[4] * x^4 */
+    /** Compute roots of quartic `c[0] + c[1] * x + c[2] * x^2 + c[3] * x^3 + c[4] * x^4` */
     static appendQuarticRoots(c, results) {
-        const coffs = new Float64Array(4); // at various times .. coefficients of quadratic an cubic intermediates.
+        // for details, see core\geometry\internaldocs\quarticRoots.md
+        const coffs = new Float64Array(4);
         let u;
         let v;
-        // normal form: x^4 + Ax^3 + Bx^2 + Cx + D = 0
         const coffScale = new Float64Array(1);
         if (!this.safeDivide(coffScale, 1.0, c[4], 0.0, 0)) {
             this.appendCubicRoots(c, results);
             return;
         }
+        // normal form: x^4 + Ax^3 + Bx^2 + Cx + D = 0
         const A = c[3] * coffScale[0];
         const B = c[2] * coffScale[0];
         const C = c[1] * coffScale[0];
         const D = c[0] * coffScale[0];
         const origin = -0.25 * A;
-        /*  substitute x = y - A/4 to eliminate cubic term:
-            x^4 + px^2 + qx + r = 0 */
+        // substitute x = y - A/4 to eliminate cubic term: y^4 + py^2 + qy + r = 0
         const sq_A = A * A;
-        const p = -3.0 / 8 * sq_A + B;
+        const p = -0.375 * sq_A + B;
         const q = 0.125 * sq_A * A - 0.5 * A * B + C;
-        const r = -3.0 / 256 * sq_A * sq_A + 1.0 / 16 * sq_A * B - 1.0 / 4 * A * C + D;
-        const tempStack = new GrowableFloat64Array_1.GrowableFloat64Array();
-        if (this.isZero(r)) {
-            // no absolute term: y(y^3 + py + q) = 0
+        const r = -0.01171875 * sq_A * sq_A + 0.0625 * sq_A * B - 0.25 * A * C + D;
+        const cubicSolutions = new GrowableFloat64Array_1.GrowableFloat64Array();
+        if (this.isZero(r)) { // no absolute term: y(y^3 + py + q) = 0
             coffs[0] = q;
             coffs[1] = p;
             coffs[2] = 0;
             coffs[3] = 1;
             this.appendCubicRoots(coffs, results);
-            results.push(0); // APPLY ORIGIN ....
-            this.addConstant(origin, results);
+            results.push(0);
+            this.addConstant(origin, results); // apply origin
             return;
         }
-        else {
-            // Solve the resolvent cubic
-            coffs[0] = 1.0 / 2 * r * p - 1.0 / 8 * q * q;
+        else { // solve the resolvent cubic
+            coffs[0] = 0.5 * r * p - 0.125 * q * q;
             coffs[1] = -r;
-            coffs[2] = -1.0 / 2 * p;
+            coffs[2] = -0.5 * p;
             coffs[3] = 1;
-            this.appendCubicRoots(coffs, tempStack);
-            const z = this.mostDistantFromMean(tempStack);
-            // ... to build two quadric equations
+            this.appendCubicRoots(coffs, cubicSolutions);
+            const z = this.mostDistantFromMean(cubicSolutions);
             u = z * z - r;
             v = 2 * z - p;
             if (this.isSmallRatio(u, r)) {
@@ -898,11 +895,9 @@ class AnalyticRoots {
                 v = Math.sqrt(v);
             }
             else {
-                for (let i = 0; i < tempStack.length; i++) {
-                    results.push(tempStack.atUncheckedIndex(i));
-                }
                 return;
             }
+            // the two quadratic equations
             coffs[0] = z - u;
             coffs[1] = ((q < 0) ? (-v) : (v));
             coffs[2] = 1;
@@ -912,8 +907,7 @@ class AnalyticRoots {
             coffs[2] = 1;
             this.appendQuadraticRoots(coffs, results);
         }
-        // substitute
-        this.addConstant(origin, results);
+        this.addConstant(origin, results); // apply origin
         results.sort();
         this.improveRoots(c, 4, results, true);
         return;
@@ -1018,19 +1012,17 @@ class PowerPolynomial {
         return this.degreeKnownEvaluate(coff, degree, x);
     }
     /**
-     * * Accumulate Q*scale into P. Both are treated as full degree.
-     * * (Expect Address exceptions if P is smaller than Q)
-     * * Returns degree of result as determined by comparing trailing coefficients to zero
+     * Accumulate `coffQ*scaleQ` into `coffP`.
+     * * The length of `coffP` must be at least length of `coffQ`.
+     * * Returns degree of result as determined by comparing trailing coefficients to zero.
      */
     static accumulate(coffP, coffQ, scaleQ) {
         let degreeP = coffP.length - 1;
         const degreeQ = coffQ.length - 1;
-        for (let i = 0; i <= degreeQ; i++) {
+        for (let i = 0; i <= degreeQ; i++)
             coffP[i] += scaleQ * coffQ[i];
-        }
-        while (degreeP >= 0 && coffP[degreeP] === 0.0) {
+        while (degreeP >= 0 && coffP[degreeP] === 0.0)
             degreeP--;
-        }
         return degreeP;
     }
     /** Zero all coefficients */
@@ -1047,17 +1039,18 @@ exports.PowerPolynomial = PowerPolynomial;
  */
 class TrigPolynomial {
     /**
-     *  Solve a polynomial created from trigonometric condition using
-     * Trig.S, Trig.C, Trig.W.  Solution logic includes inferring angular roots
-     * corresponding zero leading coefficients (roots at infinity)
-     * @param coff Coefficients
-     * @param nominalDegree degree of the polynomial under most complex
-     *     root case.  If there are any zero coefficients up to this degree, a single root
-     *     "at infinity" is recorded as its corresponding angular parameter at negative pi/2
-     * @param referenceCoefficient A number which represents the size of coefficients
-     *     at various stages of computation.  A small fraction of this will be used as a zero
-     *     tolerance
-     * @param radians Roots are placed here
+     * Solve a polynomial created from trigonometric condition using Trig.S, Trig.C, Trig.W.
+     * * Polynomial is of degree 4:
+     * `p(t) = coff[0] + coff[1] * t + coff[2] * t^2 + coff[3] * t^3 + coff[4] * t^4`
+     * * Solution logic includes inferring angular roots corresponding zero leading coefficients
+     * (roots at infinity).
+     * @param coff coefficients.
+     * @param nominalDegree degree of the polynomial under most complex root case. If there are
+     * any zero coefficients up to this degree, a single root "at infinity" is recorded as its
+     * corresponding angular parameter at negative pi/2.
+     * @param referenceCoefficient a number which represents the size of coefficients at various
+     * stages of computation. A small fraction of this will be used as a zero tolerance
+     * @param radians roots are placed here.
      * @return false if equation is all zeros. This usually means any angle is a solution.
      */
     static solveAngles(coff, nominalDegree, referenceCoefficient, radians) {
@@ -1067,31 +1060,23 @@ class TrigPolynomial {
         const relTol = this._smallAngle;
         for (let i = 0; i <= nominalDegree; i++) {
             a = Math.abs(coff[i]);
-            if (a > maxCoff) {
+            if (a > maxCoff)
                 maxCoff = a;
-            }
         }
         const coffTol = relTol * maxCoff;
         let degree = nominalDegree;
-        while (degree > 0 && (Math.abs(coff[degree]) <= coffTol)) {
+        while (degree > 0 && (Math.abs(coff[degree]) <= coffTol))
             degree--;
-        }
-        // let status = false;
         const roots = new GrowableFloat64Array_1.GrowableFloat64Array();
         if (degree === -1) {
-            // Umm.   Dunno.   Nothing there.
-            // status = false;
+            // do nothing
         }
         else {
-            // status = true;
             if (degree === 0) {
-                // p(t) is a nonzero constant
-                // No roots, but not degenerate.
-                // status = true;
+                // p(t) is a nonzero constant; no roots but not degenerate.
             }
             else if (degree === 1) {
-                // p(t) = coff[1] * t + coff[0]
-                roots.push(-coff[0] / coff[1]);
+                roots.push(-coff[0] / coff[1]); // p(t) = coff[0] + coff[1] * t
             }
             else if (degree === 2) {
                 AnalyticRoots.appendQuadraticRoots(coff, roots);
@@ -1103,70 +1088,67 @@ class TrigPolynomial {
                 AnalyticRoots.appendQuarticRoots(coff, roots);
             }
             else {
-                // TODO: WILL WORK WITH BEZIER SOLVER
-                // status = false;
+                // TODO: WORK WITH BEZIER SOLVER
             }
             if (roots.length > 0) {
-                // Each solution t represents an angle with
-                //  Math.Cos(theta)=C(t)/W(t),  ,sin(theta)=S(t)/W(t)
-                // Division by W has no effect on Atan2 calculations, so we just compute S(t),C(t)
+                // Each solution t represents an angle with Math.Cos(theta) = C(t)/W(t) and sin(theta) = S(t)/W(t)
+                // Division by W has no effect on atan2 calculations, so we just compute S(t),C(t)
                 for (let i = 0; i < roots.length; i++) {
                     const ss = PowerPolynomial.evaluate(this.S, roots.atUncheckedIndex(i));
                     const cc = PowerPolynomial.evaluate(this.C, roots.atUncheckedIndex(i));
                     radians.push(Math.atan2(ss, cc));
                 }
-                // Each leading zero at the front of the coefficients corresponds to a root at -PI/2.
-                // Only make one entry....
-                // for (int i = degree; i < nominalDegree; i++)
-                if (degree < nominalDegree) {
+                // each leading zero at the front of the coefficient array corresponds to a root at -PI/2.
+                // only make one entry because we don't report multiplicity.
+                if (degree < nominalDegree)
                     radians.push(-0.5 * Math.PI);
-                }
             }
         }
         return radians.length > 0;
     }
     /**
      * Compute intersections of unit circle `x^2 + y^2 = 1` with general quadric
-     * `axx * x^2 + axy * x * y + ayy * y^2 + ax * x + ay * y + a1 = 0`
+     * `axx * x^2 + axy * x * y + ayy * y^2 + ax * x + ay * y + a = 0`
      * Solutions are returned as angles. Sine and Cosine of the angles are the x, y results.
-     * @param axx  Coefficient of x^2
-     * @param axy  Coefficient of xy
-     * @param ayy  Coefficient of y^2
-     * @param ax  Coefficient of x
-     * @param ay  Coefficient of y
-     * @param a1  Constant coefficient
-     * @param radians  solution angles
+     * @param axx coefficient of x^2
+     * @param axy coefficient of xy
+     * @param ayy coefficient of y^2
+     * @param ax coefficient of x
+     * @param ay coefficient of y
+     * @param a constant coefficient
+     * @param radians solution angles
      */
-    static solveUnitCircleImplicitQuadricIntersection(axx, axy, ayy, ax, ay, a1, radians) {
-        const Coffs = new Float64Array(5);
-        PowerPolynomial.zero(Coffs);
+    static solveUnitCircleImplicitQuadricIntersection(axx, axy, ayy, ax, ay, a, radians) {
+        const coffs = new Float64Array(5);
+        PowerPolynomial.zero(coffs);
         let degree;
-        if (Geometry_1.Geometry.hypotenuseXYZ(axx, axy, ayy) > TrigPolynomial._coefficientRelTol * Geometry_1.Geometry.hypotenuseXYZ(ax, ay, a1)) {
-            PowerPolynomial.accumulate(Coffs, this.CW, ax);
-            PowerPolynomial.accumulate(Coffs, this.SW, ay);
-            PowerPolynomial.accumulate(Coffs, this.WW, a1);
-            PowerPolynomial.accumulate(Coffs, this.SS, ayy);
-            PowerPolynomial.accumulate(Coffs, this.CC, axx);
-            PowerPolynomial.accumulate(Coffs, this.SC, axy);
+        // see core\geometry\internaldocs\unitCircleEllipseIntersection.md for derivation of these coefficients
+        if (Geometry_1.Geometry.hypotenuseXYZ(axx, axy, ayy) > TrigPolynomial._coefficientRelTol * Geometry_1.Geometry.hypotenuseXYZ(ax, ay, a)) {
+            PowerPolynomial.accumulate(coffs, this.CW, ax);
+            PowerPolynomial.accumulate(coffs, this.SW, ay);
+            PowerPolynomial.accumulate(coffs, this.WW, a);
+            PowerPolynomial.accumulate(coffs, this.SS, ayy);
+            PowerPolynomial.accumulate(coffs, this.CC, axx);
+            PowerPolynomial.accumulate(coffs, this.SC, axy);
             degree = 4;
         }
         else {
-            PowerPolynomial.accumulate(Coffs, this.C, ax);
-            PowerPolynomial.accumulate(Coffs, this.S, ay);
-            PowerPolynomial.accumulate(Coffs, this.W, a1);
+            PowerPolynomial.accumulate(coffs, this.C, ax);
+            PowerPolynomial.accumulate(coffs, this.S, ay);
+            PowerPolynomial.accumulate(coffs, this.W, a);
             degree = 2;
         }
-        let maxCoff = 0.0;
-        maxCoff = Math.max(maxCoff, Math.abs(axx), Math.abs(ayy), Math.abs(axy), Math.abs(ax), Math.abs(ay), Math.abs(a1));
-        const b = this.solveAngles(Coffs, degree, maxCoff, radians);
+        const maxCoff = Math.max(Math.abs(axx), Math.abs(ayy), Math.abs(axy), Math.abs(ax), Math.abs(ay), Math.abs(a));
+        const b = this.solveAngles(coffs, degree, maxCoff, radians);
         /*
         for (const theta of angles) {
           const c = theta.cos();
           const s = theta.sin();
           GeometryCoreTestIO.consoleLog({
             angle: theta, co: c, si: s,
-            f: axx * c * c + axy * c * s + ayy * s * s + ax * c + ay * s + a1});
-      } */
+            f: axx * c * c + axy * c * s + ayy * s * s + ax * c + ay * s + a,
+          });
+        } */
         return b;
     }
     /**
@@ -1184,6 +1166,7 @@ class TrigPolynomial {
      */
     static solveUnitCircleEllipseIntersection(cx, cy, ux, uy, vx, vy, ellipseRadians, circleRadians) {
         circleRadians.length = 0;
+        // see core\geometry\internaldocs\unitCircleEllipseIntersection.md for derivation of these coefficients:
         const acc = ux * ux + uy * uy;
         const acs = 2.0 * (ux * vx + uy * vy);
         const ass = vx * vx + vy * vy;
@@ -1201,7 +1184,7 @@ class TrigPolynomial {
         return status;
     }
     /**
-     * Compute intersections of unit circle `x^2 + y^2 = w^2` with the ellipse
+     * Compute intersections of unit circle `x^2 + y^2 = w^2` (in homogeneous coordinates) with the ellipse
      * `F(t) = (cx + ux cos(t) + vx sin(t), cy + uy cos(t) + vy sin(t)) / (cw + uw cos(t) + vw sin(t))`.
      * @param cx center x
      * @param cy center y
@@ -1217,13 +1200,14 @@ class TrigPolynomial {
      */
     static solveUnitCircleHomogeneousEllipseIntersection(cx, cy, cw, ux, uy, uw, vx, vy, vw, ellipseRadians, circleRadians) {
         circleRadians.length = 0;
+        // see core\geometry\internaldocs\unitCircleEllipseIntersection.md for derivation of these coefficients:
         const acc = ux * ux + uy * uy - uw * uw;
         const acs = 2.0 * (ux * vx + uy * vy - uw * vw);
         const ass = vx * vx + vy * vy - vw * vw;
         const ac = 2.0 * (ux * cx + uy * cy - uw * cw);
-        const asi = 2.0 * (vx * cx + vy * cy - vw * cw);
+        const as = 2.0 * (vx * cx + vy * cy - vw * cw);
         const a = cx * cx + cy * cy - cw * cw;
-        const status = this.solveUnitCircleImplicitQuadricIntersection(acc, acs, ass, ac, asi, a, ellipseRadians);
+        const status = this.solveUnitCircleImplicitQuadricIntersection(acc, acs, ass, ac, as, a, ellipseRadians);
         for (const radians of ellipseRadians) {
             const cc = Math.cos(radians);
             const ss = Math.sin(radians);
@@ -1237,25 +1221,26 @@ class TrigPolynomial {
 exports.TrigPolynomial = TrigPolynomial;
 // tolerance for small angle decision.
 TrigPolynomial._smallAngle = 1.0e-11;
-/** Standard Basis coefficients for rational sine numerator. */
+// see core\geometry\internaldocs\unitCircleEllipseIntersection.md for derivation of these coefficients.
+/** Standard Basis coefficients for the numerator of the y-coordinate y(t) = S(t)/W(t) in the rational semicircle parameterization. */
 TrigPolynomial.S = Float64Array.from([0.0, 2.0, -2.0]);
-/** Standard Basis coefficients for rational cosine numerator. */
+/** Standard Basis coefficients for the numerator of the x-coordinate x(t) = C(t)/W(t) in the rational semicircle parameterization. */
 TrigPolynomial.C = Float64Array.from([1.0, -2.0]);
-/** Standard Basis coefficients for rational denominator. */
+/** Standard Basis coefficients for the denominator of x(t) and y(t) in the rational semicircle parameterization. */
 TrigPolynomial.W = Float64Array.from([1.0, -2.0, 2.0]);
-/** Standard Basis coefficients for cosine*weight numerator */
+/** Standard Basis coefficients for C(t) * W(t). */
 TrigPolynomial.CW = Float64Array.from([1.0, -4.0, 6.0, -4.0]);
-/** Standard Basis coefficients for sine*weight numerator */
+/** Standard Basis coefficients for S(t) * W(t). */
 TrigPolynomial.SW = Float64Array.from([0.0, 2.0, -6.0, 8.0, -4.0]);
-/** Standard Basis coefficients for sine*cosine numerator */
+/** Standard Basis coefficients for S(t) * C(t). */
 TrigPolynomial.SC = Float64Array.from([0.0, 2.0, -6.0, 4.0]);
-/** Standard Basis coefficients for sine^2 numerator */
+/** Standard Basis coefficients for S(t) * S(t). */
 TrigPolynomial.SS = Float64Array.from([0.0, 0.0, 4.0, -8.0, 4.0]);
-/** Standard Basis coefficients for cosine^2 numerator */
+/** Standard Basis coefficients for C(t) * C(t). */
 TrigPolynomial.CC = Float64Array.from([1.0, -4.0, 4.0]);
-/** Standard Basis coefficients for weight^2 */
+/** Standard Basis coefficients for W(t) * W(t). */
 TrigPolynomial.WW = Float64Array.from([1.0, -4.0, 8.0, -8.0, 4.0]);
-/** Standard Basis coefficients for (Math.Cos^2 - sine^2) numerator */
+/** Standard Basis coefficients for C(t) * C(t) - S(t) * S(t). */
 TrigPolynomial.CCminusSS = Float64Array.from([1.0, -4.0, 0.0, 8.0, -4.0]);
 TrigPolynomial._coefficientRelTol = 1.0e-12;
 /**