@iowarp/clio-coder 0.3.1 → 0.3.3

package/src/worker/entry.ts

@@ -14,7 +14,32 @@
 // id is appended once the spec is parsed.
 process.title = "clio-coder-worker";
 
-import { disposeLmStudioClients } from "../engine/apis/lmstudio-native.js";
+import { AI_AGENT_NAME } from "../core/agent-environment.js";
+import { deleteInjectedCompileCacheFrom } from "../core/compile-cache.js";
+import {
+	setGitCommitAttributionEnabled,
+	withManagedGitCommitAttributionEnvironment,
+} from "../core/git-commit-attribution.js";
+
+process.env.AI_AGENT = AI_AGENT_NAME;
+
+// Consume the compile-cache pair the dispatcher injected for THIS entry's
+// module graph. Node read NODE_COMPILE_CACHE at bootstrap, before any of this
+// ran, so the worker's own cache stays enabled; deleting the pair here is what
+// keeps it out of every child this process spawns: bash tool commands, hooks,
+// and external runtime subprocesses (claude, antigravity) that would otherwise
+// inherit the unfiltered environment and write into Clio's cache.
+deleteInjectedCompileCacheFrom(process.env);
+
+// Marks this process, and every child a worker's own bash tool spawns, as
+// running inside a dispatched worker rather than the operator's interactive
+// session. `installSkillFromSource` reads this to stamp skill provenance with
+// who performed the install, so a skill a worker drops into a trusted root
+// does not read as operator-installed. Set unconditionally at both local and
+// remote launch, since neither transport otherwise leaves a uniform signal on
+// the worker's own environment.
+process.env.CLIO_CODER_WORKER_RUN = "1";
+
 import { setProtectedModelsProvider, setResidencyNoticeSink } from "../engine/apis/residency.js";
 import { startWorkerRun, type WorkerRunInput, workerProviderSupportsTools } from "../engine/worker-runtime.js";
 import { attestedToolSignature } from "../engine/worker-tools.js";
@@ -109,6 +134,19 @@ async function main(): Promise<number> {
 
 	const spec = await demux.readSpec();
 	process.title = `clio-coder-worker:${spec.agentId}`;
+	const attributionEnabled = spec.gitCommitAttribution ?? true;
+	setGitCommitAttributionEnabled(attributionEnabled);
+	const attribution = withManagedGitCommitAttributionEnvironment(process.env, {
+		cwd: process.cwd(),
+		enabled: attributionEnabled,
+	});
+	for (const key of Object.keys(process.env)) {
+		if (!(key in attribution.env)) Reflect.deleteProperty(process.env, key);
+	}
+	Object.assign(process.env, attribution.env);
+	if (attribution.diagnostic !== null) {
+		process.stderr.write(`[worker] commit attribution: ${attribution.diagnostic}\n`);
+	}
 	// The worker has no settings view of its own; the dispatcher copied the
 	// operator's configured model ids onto the spec so this process protects
 	// the same residents as the orchestrator.
@@ -239,7 +277,6 @@ async function main(): Promise<number> {
 		// Best-effort dispose of any LMStudioClient instances cached by the
 		// engine so we close their WebSocket sessions cleanly before the worker
 		// process exits.
-		await disposeLmStudioClients();
 	}
 }
 

package/src/worker/spec-contract.ts

@@ -37,6 +37,8 @@ export interface SerializedWorkerRuntimeDescriptor {
 	kind: RuntimeKind;
 	apiFamily: RuntimeApiFamily;
 	auth: RuntimeAuth;
+	/** Legacy or alternate ids that resolve to this runtime; absent when it has none. */
+	aliases?: ReadonlyArray<string>;
 }
 
 /** Immutable, admission-time snapshot of the parent session's hard blocks. */
@@ -121,6 +123,8 @@ interface WorkerSpecFields {
 	/** Skill names the agent recipe binds to this run; context(scope=skills) admits exactly these. */
 	agentSkills?: ReadonlyArray<string>;
 	trustProjectCompatRoots?: boolean;
+	/** Effective commit-attribution setting inherited from the dispatching session. */
+	gitCommitAttribution?: boolean;
 	/**
 	 * Dispatch-time tool profile that narrowed `allowedTools`. Carried so
 	 * black-box external CLI runtimes that cannot mediate per-tool calls can
@@ -195,7 +199,6 @@ const RUNTIME_API_FAMILIES = [
 	"bedrock-converse-stream",
 	"google-generative-ai",
 	"google-vertex",
-	"lmstudio-native",
 	"mistral-conversations",
 	"ollama-native",
 	"rerank-http",
@@ -247,6 +250,10 @@ export function serializeWorkerRuntimeDescriptor(runtime: RuntimeDescriptor): Se
 		kind: runtime.kind,
 		apiFamily: runtime.apiFamily,
 		auth: runtime.auth,
+		// Carried so the target check can recognize a configured runtime id that
+		// resolves to this runtime through an alias. Without them the contract has
+		// no way to tell a legacy spelling from a genuinely wrong runtime.
+		...(runtime.aliases !== undefined && runtime.aliases.length > 0 ? { aliases: [...runtime.aliases] } : {}),
 	};
 }
 
@@ -335,12 +342,21 @@ function validateProtectedModels(value: unknown): void {
 	});
 }
 
-function validateTarget(value: unknown, runtimeId: string): void {
+/**
+ * The configured target names a runtime by whatever id the operator wrote, which
+ * may be an alias the registry resolves to the canonical id. Comparing the two
+ * spellings literally rejected every dispatch to a target whose settings still
+ * said `lmstudio-native`, because the settings migration that rewrites it runs
+ * only under `clio-coder upgrade`. An alias is the same runtime, so it passes.
+ */
+function validateTarget(value: unknown, runtimeId: string, runtimeAliases: ReadonlyArray<string>): void {
 	const target = readRecord(value, "WorkerSpec.target");
 	const targetId = readString(target.id, "WorkerSpec.target.id");
 	const targetRuntime = readString(target.runtime, "WorkerSpec.target.runtime");
-	if (targetRuntime !== runtimeId) {
-		throw new Error(`WorkerSpec target runtime mismatch: target.runtime=${targetRuntime} runtimeId=${runtimeId}`);
+	if (targetRuntime !== runtimeId && !runtimeAliases.includes(targetRuntime)) {
+		throw new Error(
+			`WorkerSpec target runtime mismatch: target.runtime=${targetRuntime} runtimeId=${runtimeId}. Set the target's runtime to '${runtimeId}' in settings.yaml, or run 'clio-coder upgrade' to migrate a legacy runtime id.`,
+		);
 	}
 	if (targetId.length === 0) throw new Error("WorkerSpec.target.id must be a non-empty string");
 	readOptionalString(target, "url", "WorkerSpec.target");
@@ -545,6 +561,8 @@ export function parseWorkerSpec(value: unknown): WorkerSpec {
 	if (runtimeId !== runtimeRefId) {
 		throw new Error(`WorkerSpec runtime id mismatch: runtimeId=${runtimeId} runtime.id=${runtimeRefId}`);
 	}
+	const runtimeAliases =
+		runtime.aliases === undefined ? [] : readStringArray(runtime.aliases, "WorkerSpec.runtime.aliases");
 	const runtimeKind = readEnum(runtime.kind, "WorkerSpec.runtime.kind", RUNTIME_KINDS);
 	const runtimeApiFamily = readEnum(runtime.apiFamily, "WorkerSpec.runtime.apiFamily", RUNTIME_API_FAMILIES);
 	readEnum(runtime.auth, "WorkerSpec.runtime.auth", RUNTIME_AUTHS);
@@ -555,7 +573,7 @@ export function parseWorkerSpec(value: unknown): WorkerSpec {
 	readOptionalString(spec, "dynamicHash", "WorkerSpec");
 	readString(spec.agentId, "WorkerSpec.agentId");
 	readString(spec.task, "WorkerSpec.task");
-	validateTarget(spec.target, runtimeId);
+	validateTarget(spec.target, runtimeId, runtimeAliases);
 	readString(spec.wireModelId, "WorkerSpec.wireModelId");
 	readOptionalString(spec, "sessionId", "WorkerSpec");
 	readOptionalString(spec, "apiKey", "WorkerSpec");
@@ -595,6 +613,9 @@ export function parseWorkerSpec(value: unknown): WorkerSpec {
 	if (spec.trustProjectCompatRoots !== undefined && typeof spec.trustProjectCompatRoots !== "boolean") {
 		throw new Error("WorkerSpec.trustProjectCompatRoots must be a boolean");
 	}
+	if (spec.gitCommitAttribution !== undefined && typeof spec.gitCommitAttribution !== "boolean") {
+		throw new Error("WorkerSpec.gitCommitAttribution must be a boolean");
+	}
 	readOptionalEnum(spec, "toolProfile", "WorkerSpec", TOOL_PROFILE_NAMES);
 	readOptionalEnum(spec, "product", "WorkerSpec", WORKER_PRODUCTS);
 	if (