@ionic/core 7.5.8-dev.11701806358.1ca1b519 → 7.5.8-dev.11701894917.1c1465bd

package/dist/collection/components/{picker-legacy-column/picker-column.ios.css → picker-internal/picker-internal.md.css}

@@ -53,56 +53,89 @@
  *   }
  * }
  */
-.picker-col {
+:host {
   display: flex;
   position: relative;
-  flex: 1;
+  align-items: center;
   justify-content: center;
-  height: 100%;
-  box-sizing: content-box;
-  contain: content;
+  width: 100%;
+  height: 200px;
+  /**
+   * Picker columns should display
+   * in the order in which developers
+   * added them and should ignore
+   * LTR vs RTL directions.
+   */
+  direction: ltr;
+  /**
+   * This is required otherwise the
+   * highlight will appear behind
+   * the picker when used inline.
+   */
+  z-index: 0;
 }
 
-.picker-opts {
-  position: relative;
-  flex: 1;
-  max-width: 100%;
+:host .picker-before,
+:host .picker-after {
+  position: absolute;
+  width: 100%;
+  /**
+   * The transform and z-index
+   * are needed for WebKit otherwise
+   * the fade will appear underneath the picker.
+   */
+  transform: translateZ(0);
+  z-index: 1;
+  pointer-events: none;
 }
 
-.picker-opt {
+:host .picker-before {
   top: 0;
-  display: block;
-  position: absolute;
-  width: 100%;
-  border: 0;
-  text-align: center;
-  text-overflow: ellipsis;
-  white-space: nowrap;
-  contain: strict;
-  overflow: hidden;
-  will-change: transform;
+  height: 83px;
 }
 @supports (inset-inline-start: 0) {
-  .picker-opt {
+  :host .picker-before {
     inset-inline-start: 0;
   }
 }
 @supports not (inset-inline-start: 0) {
-  .picker-opt {
+  :host .picker-before {
     left: 0;
   }
-  :host-context([dir=rtl]) .picker-opt {
+  :host-context([dir=rtl]) .picker-before {
     left: unset;
     right: unset;
     right: 0;
   }
-  [dir=rtl] .picker-opt {
+  @supports selector(:dir(rtl)) {
+    :host(:dir(rtl)) .picker-before {
+      left: unset;
+      right: unset;
+      right: 0;
+    }
+  }
+}
+
+:host .picker-after {
+  top: 116px;
+  height: 84px;
+}
+@supports (inset-inline-start: 0) {
+  :host .picker-after {
+    inset-inline-start: 0;
+  }
+}
+@supports not (inset-inline-start: 0) {
+  :host .picker-after {
+    left: 0;
+  }
+  :host-context([dir=rtl]) .picker-after {
     left: unset;
     right: unset;
     right: 0;
   }
   @supports selector(:dir(rtl)) {
-    .picker-opt:dir(rtl) {
+    :host(:dir(rtl)) .picker-after {
       left: unset;
       right: unset;
       right: 0;
@@ -110,38 +143,55 @@
   }
 }
 
-.picker-opt.picker-opt-disabled {
-  pointer-events: none;
+:host .picker-highlight {
+  border-radius: 8px;
+  left: 0;
+  right: 0;
+  top: 50%;
+  bottom: 0;
+  -webkit-margin-start: auto;
+  margin-inline-start: auto;
+  -webkit-margin-end: auto;
+  margin-inline-end: auto;
+  margin-top: 0;
+  margin-bottom: 0;
+  position: absolute;
+  width: calc(100% - 16px);
+  height: 34px;
+  transform: translateY(-50%);
+  background: var(--wheel-highlight-background);
+  z-index: -1;
 }
 
-.picker-opt-disabled {
+:host input {
+  position: absolute;
+  top: 0;
+  left: 0;
+  right: 0;
+  bottom: 0;
+  width: 100%;
+  height: 100%;
+  margin: 0;
+  padding: 0;
+  border: 0;
+  outline: 0;
+  clip: rect(0 0 0 0);
   opacity: 0;
+  overflow: hidden;
+  -webkit-appearance: none;
+  -moz-appearance: none;
 }
 
-.picker-opts-left {
-  justify-content: flex-start;
-}
-
-.picker-opts-right {
-  justify-content: flex-end;
-}
-
-.picker-opt:active, .picker-opt:focus {
-  outline: none;
+:host ::slotted(ion-picker-column-internal:first-of-type) {
+  text-align: start;
 }
 
-.picker-prefix {
-  position: relative;
-  flex: 1;
+:host ::slotted(ion-picker-column-internal:last-of-type) {
   text-align: end;
-  white-space: nowrap;
 }
 
-.picker-suffix {
-  position: relative;
-  flex: 1;
-  text-align: start;
-  white-space: nowrap;
+:host ::slotted(ion-picker-column-internal:only-child) {
+  text-align: center;
 }
 
 /**
@@ -199,57 +249,10 @@
  *   }
  * }
  */
-.picker-col {
-  -webkit-padding-start: 4px;
-  padding-inline-start: 4px;
-  -webkit-padding-end: 4px;
-  padding-inline-end: 4px;
-  padding-top: 0;
-  padding-bottom: 0;
-  transform-style: preserve-3d;
-}
-
-.picker-prefix,
-.picker-suffix,
-.picker-opts {
-  top: 77px;
-  transform-style: preserve-3d;
-  color: inherit;
-  font-size: 20px;
-  line-height: 42px;
-  pointer-events: none;
-}
-
-.picker-opt {
-  padding-left: 0;
-  padding-right: 0;
-  padding-top: 0;
-  padding-bottom: 0;
-  margin-left: 0;
-  margin-right: 0;
-  margin-top: 0;
-  margin-bottom: 0;
-  transform-origin: center center;
-  height: 46px;
-  transform-style: preserve-3d;
-  transition-timing-function: ease-out;
-  background: transparent;
-  color: inherit;
-  font-size: 20px;
-  line-height: 42px;
-  backface-visibility: hidden;
-  pointer-events: auto;
-}
-:host-context([dir=rtl]) .picker-opt {
-  transform-origin: calc(100% - center) center;
+:host .picker-before {
+  background: linear-gradient(to bottom, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 1) 20%, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 0) 90%);
 }
 
-[dir=rtl] .picker-opt {
-  transform-origin: calc(100% - center) center;
-}
-
-@supports selector(:dir(rtl)) {
-  .picker-opt:dir(rtl) {
-    transform-origin: calc(100% - center) center;
-  }
+:host .picker-after {
+  background: linear-gradient(to top, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 1) 30%, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 0) 90%);
 }

package/dist/collection/components/{picker/test/a11y/picker.e2e.js → picker-internal/test/a11y/picker-internal.e2e.js}

@@ -5,9 +5,9 @@ import AxeBuilder from "@axe-core/playwright";
 import { expect } from "@playwright/test";
 import { configs, test } from "../../../../utils/test/playwright/index";
 configs().forEach(({ title, config }) => {
-    test.describe(title('picker: a11y'), () => {
+    test.describe(title('picker-internal: a11y'), () => {
         test('should not have accessibility violations', async ({ page }) => {
-            await page.goto(`/src/components/picker/test/a11y`, config);
+            await page.goto(`/src/components/picker-internal/test/a11y`, config);
             const results = await new AxeBuilder({ page }).analyze();
             expect(results.violations).toEqual([]);
         });

package/dist/collection/components/picker-internal/test/basic/picker-internal.e2e.js

@@ -0,0 +1,118 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+/**
+ * This behavior does not vary across directions.
+ */
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+    test.describe(title('picker-internal: rendering'), () => {
+        test('inline pickers should not have visual regression', async ({ page }) => {
+            await page.goto(`/src/components/picker-internal/test/basic`, config);
+            const fullStack = page.locator('#inline button[data-value="full-stack"]');
+            const onion = page.locator('#inline button[data-value="onion"]');
+            await expect(fullStack).toHaveClass(/picker-item-active/);
+            await expect(onion).toHaveClass(/picker-item-active/);
+            await page.waitForChanges();
+            await expect(page.locator('#inline')).toHaveScreenshot(screenshot(`picker-internal-inline-diff`));
+        });
+    });
+    test.describe(title('picker-internal: overlay rendering'), () => {
+        test('popover: should not have visual regression', async ({ page }) => {
+            await page.goto(`/src/components/picker-internal/test/basic`, config);
+            const button = page.locator('#popover');
+            const didPresent = await page.spyOnEvent('ionPopoverDidPresent');
+            const pickerInternal = page.locator('ion-popover ion-picker-internal');
+            await button.click();
+            await didPresent.next();
+            await expect(pickerInternal).toBeVisible();
+            const popoverContent = page.locator('ion-popover .ion-delegate-host');
+            await expect(popoverContent).toHaveScreenshot(screenshot(`picker-internal-popover-diff`), {
+                /**
+                 * Animations must be enabled to capture the screenshot.
+                 * By default, animations are disabled with toHaveScreenshot,
+                 * and when capturing the screenshot will call animation.finish().
+                 * This will cause the popover to close and the screenshot capture
+                 * to be invalid.
+                 */
+                animations: 'allow',
+            });
+        });
+        test('modal: should not have visual regression', async ({ page }) => {
+            await page.goto('/src/components/picker-internal/test/basic', config);
+            const button = page.locator('#modal');
+            const didPresent = await page.spyOnEvent('ionModalDidPresent');
+            const pickerInternal = page.locator('ion-modal ion-picker-internal');
+            await button.click();
+            await didPresent.next();
+            await expect(pickerInternal).toBeVisible();
+            const modalContent = page.locator('ion-modal .ion-delegate-host');
+            await expect(modalContent).toHaveScreenshot(screenshot(`picker-internal-modal-diff`), {
+                /**
+                 * Animations must be enabled to capture the screenshot.
+                 * By default, animations are disabled with toHaveScreenshot,
+                 * and when capturing the screenshot will call animation.finish().
+                 * This will cause the modal to close and the screenshot capture
+                 * to be invalid.
+                 */
+                animations: 'allow',
+            });
+        });
+    });
+});
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+    test.describe(title('picker-internal: focus'), () => {
+        test.beforeEach(async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal value="full-stack" id="first"></ion-picker-column-internal>
+          <ion-picker-column-internal value="onion" id="second"></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const columns = document.querySelectorAll('ion-picker-column-internal');
+          columns[0].items = [
+            { text: 'Minified', value: 'minified' },
+            { text: 'Responsive', value: 'responsive' },
+            { text: 'Full Stack', value: 'full-stack' },
+            { text: 'Mobile First', value: 'mobile-first' },
+            { text: 'Serverless', value: 'serverless' },
+          ]
+
+          columns[1].items = [
+            { text: 'Tomato', value: 'tomato' },
+            { text: 'Avocado', value: 'avocado' },
+            { text: 'Onion', value: 'onion' },
+            { text: 'Potato', value: 'potato' },
+            { text: 'Artichoke', value: 'artichoke' },
+          ];
+        </script>
+      `, config);
+        });
+        test('tabbing should correctly move focus between columns', async ({ page }) => {
+            const firstColumn = page.locator('ion-picker-column-internal#first');
+            const secondColumn = page.locator('ion-picker-column-internal#second');
+            // Focus first column
+            await page.keyboard.press('Tab');
+            await expect(firstColumn).toBeFocused();
+            await page.waitForChanges();
+            // Focus second column
+            await page.keyboard.press('Tab');
+            await expect(secondColumn).toBeFocused();
+        });
+        test('tabbing should correctly move focus back', async ({ page }) => {
+            const firstColumn = page.locator('ion-picker-column-internal#first');
+            const secondColumn = page.locator('ion-picker-column-internal#second');
+            await secondColumn.focus();
+            await expect(secondColumn).toBeFocused();
+            await page.waitForChanges();
+            // Focus first column
+            await page.keyboard.press('Shift+Tab');
+            await expect(firstColumn).toBeFocused();
+        });
+    });
+});

package/dist/collection/components/{picker/test/keyboard-entry/picker.e2e.js → picker-internal/test/keyboard-entry/picker-internal.e2e.js}

@@ -6,17 +6,16 @@ import { configs, test } from "../../../../utils/test/playwright/index";
 /**
  * This behavior does not vary across modes/directions.
  */
-// TODO FW-5580 fix this functionality
 configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
-    test.describe.skip(title('picker: keyboard entry'), () => {
+    test.describe(title('picker-internal: keyboard entry'), () => {
         test('should scroll to and update the value prop for a single column', async ({ page }) => {
             await page.setContent(`
-        <ion-picker>
-          <ion-picker-column></ion-picker-column>
-        </ion-picker>
+        <ion-picker-internal>
+          <ion-picker-column-internal></ion-picker-column-internal>
+        </ion-picker-internal>
 
         <script>
-          const column = document.querySelector('ion-picker-column');
+          const column = document.querySelector('ion-picker-column-internal');
           column.items = [
             { text: '01', value: 1 },
             { text: '02', value: 2 },
@@ -28,22 +27,22 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           column.numericInput = true;
         </script>
       `, config);
-            const column = page.locator('ion-picker-column');
+            const column = page.locator('ion-picker-column-internal');
             const ionChange = await page.spyOnEvent('ionChange');
-            await column.evaluate((el) => el.setFocus());
+            await column.focus();
             await page.keyboard.press('Digit2');
             await expect(ionChange).toHaveReceivedEventDetail({ text: '02', value: 2 });
             await expect(column).toHaveJSProperty('value', 2);
         });
         test('should scroll to and update the value prop for multiple columns', async ({ page }) => {
             await page.setContent(`
-        <ion-picker>
-          <ion-picker-column id="first"></ion-picker-column>
-          <ion-picker-column id="second"></ion-picker-column>
-        </ion-picker>
+        <ion-picker-internal>
+          <ion-picker-column-internal id="first"></ion-picker-column-internal>
+          <ion-picker-column-internal id="second"></ion-picker-column-internal>
+        </ion-picker-internal>
 
         <script>
-          const firstColumn = document.querySelector('ion-picker-column#first');
+          const firstColumn = document.querySelector('ion-picker-column-internal#first');
           firstColumn.items = [
             { text: '01', value: 1 },
             { text: '02', value: 2 },
@@ -54,7 +53,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           firstColumn.value = 5;
           firstColumn.numericInput = true;
 
-          const secondColumn = document.querySelector('ion-picker-column#second');
+          const secondColumn = document.querySelector('ion-picker-column-internal#second');
           secondColumn.items = [
             { text: '20', value: 20 },
             { text: '21', value: 21 },
@@ -66,9 +65,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           secondColumn.numericInput = true;
         </script>
       `, config);
-            const firstColumn = page.locator('ion-picker-column#first');
-            const secondColumn = page.locator('ion-picker-column#second');
-            const highlight = page.locator('ion-picker .picker-highlight');
+            const firstColumn = page.locator('ion-picker-column-internal#first');
+            const secondColumn = page.locator('ion-picker-column-internal#second');
+            const highlight = page.locator('ion-picker-internal .picker-highlight');
             const firstIonChange = await firstColumn.spyOnEvent('ionChange');
             const secondIonChange = await secondColumn.spyOnEvent('ionChange');
             const box = await highlight.boundingBox();
@@ -86,12 +85,12 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
         });
         test('should select 00', async ({ page }) => {
             await page.setContent(`
-        <ion-picker>
-          <ion-picker-column></ion-picker-column>
-        </ion-picker>
+        <ion-picker-internal>
+          <ion-picker-column-internal></ion-picker-column-internal>
+        </ion-picker-internal>
 
         <script>
-          const column = document.querySelector('ion-picker-column');
+          const column = document.querySelector('ion-picker-column-internal');
           column.items = [
             { text: '00', value: 12 },
             { text: '01', value: 1 },
@@ -104,9 +103,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           column.numericInput = true;
         </script>
       `, config);
-            const column = page.locator('ion-picker-column');
+            const column = page.locator('ion-picker-column-internal');
             const ionChange = await page.spyOnEvent('ionChange');
-            await column.evaluate((el) => el.setFocus());
+            await column.focus();
             await page.keyboard.press('Digit0');
             await expect(ionChange).toHaveReceivedEventDetail({ text: '00', value: 12 });
             await expect(column).toHaveJSProperty('value', 12);

package/dist/collection/utils/overlays.js

@@ -29,10 +29,7 @@ export const alertController = /*@__PURE__*/ createController('ion-alert');
 export const actionSheetController = /*@__PURE__*/ createController('ion-action-sheet');
 export const loadingController = /*@__PURE__*/ createController('ion-loading');
 export const modalController = /*@__PURE__*/ createController('ion-modal');
-/**
- * @deprecated Use the inline ion-picker component instead.
- */
-export const pickerController = /*@__PURE__*/ createController('ion-picker-legacy');
+export const pickerController = /*@__PURE__*/ createController('ion-picker');
 export const popoverController = /*@__PURE__*/ createController('ion-popover');
 export const toastController = /*@__PURE__*/ createController('ion-toast');
 /**
@@ -142,7 +139,7 @@ const focusLastDescendant = (ref, overlay) => {
  * Should NOT include: Toast
  */
 const trapKeyboardFocus = (ev, doc) => {
-    const lastOverlay = getPresentedOverlay(doc, 'ion-alert,ion-action-sheet,ion-loading,ion-modal,ion-picker-legacy,ion-popover');
+    const lastOverlay = getPresentedOverlay(doc, 'ion-alert,ion-action-sheet,ion-loading,ion-modal,ion-picker,ion-popover');
     const target = ev.target;
     /**
      * If no active overlay, ignore this event.
@@ -327,7 +324,7 @@ export const dismissOverlay = (doc, data, role, overlayTag, id) => {
  */
 export const getOverlays = (doc, selector) => {
     if (selector === undefined) {
-        selector = 'ion-alert,ion-action-sheet,ion-loading,ion-modal,ion-picker-legacy,ion-popover,ion-toast';
+        selector = 'ion-alert,ion-action-sheet,ion-loading,ion-modal,ion-picker,ion-popover,ion-toast';
     }
     return Array.from(doc.querySelectorAll(selector)).filter((c) => c.overlayIndex > 0);
 };